[PATCH] D136154: [clang-format] Fix the continuation indenter

owenpan added inline comments. Comment at: clang/lib/Format/ContinuationIndenter.cpp:803-808 - } else if ((Previous.isOneOf(TT_BinaryOperator, TT_ConditionalExpr, - TT_CtorInitializerColon)) && +} else if (Previous.is(TT_CtorInitializerColon)) {

[PATCH] D134050: [clang][RISCV][NFC][WIP/RFC] Move riscv-abi.cpp and riscv32-*abi.c tests to use update_cc_test_checks.py

kito-cheng accepted this revision. kito-cheng added a comment. This revision is now accepted and ready to land. LGTM, manually update such testcase is really painful! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134050/new/ https://reviews.llvm.org/D134050

[PATCH] D134050: [clang][RISCV][NFC][WIP/RFC] Move riscv-abi.cpp and riscv32-*abi.c tests to use update_cc_test_checks.py

kito-cheng added a comment. Oh, it's still `[WIP/RFC]`, but anyway that's really good way to go. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134050/new/ https://reviews.llvm.org/D134050 ___ cfe-commits mailing list cfe-commits@lists.llvm.or

[PATCH] D135951: [X86][1/2] SUPPORT RAO-INT

pengfei updated this revision to Diff 471040. pengfei added a comment. Address review comments; Change intrinsics name from *_si* to *_i*. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135951/new/ https://reviews.llvm.org/D135951 Files: clang/do

[PATCH] D136784: [Clang] Improve diagnostic message for loop hint pragma

SjoerdMeijer added a reviewer: fhahn. SjoerdMeijer added inline comments. Comment at: clang/lib/Parse/ParsePragma.cpp:1306 StringRef Str = PragmaName.getIdentifierInfo()->getName(); + if (Str == "loop") +return (llvm::Twine("clang loop ") + Option.getIdentifierInfo()->ge

[PATCH] D135932: [X86] Add AVX-IFMA instructions.

pengfei accepted this revision. pengfei added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135932/new/ https://reviews.llvm.org/D135932

[PATCH] D136783: Pre-commit test case for D136784

SjoerdMeijer accepted this revision. SjoerdMeijer added a comment. This revision is now accepted and ready to land. Looks like a good set of extra tests to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136783/new/ https://reviews.llvm.org/D1367

[PATCH] D135938: [X86] Add AVX-VNNI-INT8 instructions.

pengfei accepted this revision. pengfei added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135938/new/ https://reviews.llvm.org/D135938

[PATCH] D134128: [P0857R0 Part B] Resubmit an implemention for constrained template template parameters

lime updated this revision to Diff 471046. lime added a comment. Update as suggested. Could you please help me apply this patch (F25074675: 0001-P0857R0-Part-B-Allows-require-clauses-appearing-in-t(1).patch )? It seems unsuitable to grant a fresh account the

[PATCH] D136783: Pre-commit test case for D136784

eopXD updated this revision to Diff 471047. eopXD added a comment. Update to latest main. (Triggering CI again) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136783/new/ https://reviews.llvm.org/D136783 Files: clang/test/Parser/pragma-loop.cpp

[PATCH] D136784: [Clang] Improve diagnostic message for loop hint pragma

eopXD updated this revision to Diff 471048. eopXD added a comment. Rebase upon latest main and simplify existing checks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136784/new/ https://reviews.llvm.org/D136784 Files: clang/lib/Parse/ParsePragm

[PATCH] D136784: [Clang] Improve diagnostic message for loop hint pragma

eopXD marked an inline comment as done. eopXD added inline comments. Comment at: clang/lib/Parse/ParsePragma.cpp:1306 StringRef Str = PragmaName.getIdentifierInfo()->getName(); + if (Str == "loop") +return (llvm::Twine("clang loop ") + Option.getIdentifierInfo()->getName

[PATCH] D136796: [llvm-objdump][Offload] Use common offload extraction method

jhenderson added a comment. As a general rule, dumping tools should avoid hard errors, because usually they prevent the dumping tool from continuing to dump other useful and valid information as part of the same execution. I don't have a strong objection in this particular case, because I presu

[PATCH] D136784: [Clang] Improve diagnostic message for loop hint pragma

SjoerdMeijer added inline comments. Comment at: clang/lib/Parse/ParsePragma.cpp:1306 StringRef Str = PragmaName.getIdentifierInfo()->getName(); + if (Str == "loop") +return (llvm::Twine("clang loop ") + Option.getIdentifierInfo()->getName()).str(); eopXD

[PATCH] D136784: [Clang] Improve diagnostic message for loop hint pragma

eopXD updated this revision to Diff 471057. eopXD marked an inline comment as done. eopXD added a comment. Update code based on suggestion. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136784/new/ https://reviews.llvm.org/D136784 Files: clang/l

[PATCH] D136784: [Clang] Improve diagnostic message for loop hint pragma

eopXD marked an inline comment as done. eopXD added inline comments. Comment at: clang/lib/Parse/ParsePragma.cpp:1306 StringRef Str = PragmaName.getIdentifierInfo()->getName(); + if (Str == "loop") +return (llvm::Twine("clang loop ") + Option.getIdentifierInfo()->getName

[clang] 1705975 - [clang-format] Move InsertBraces unit tests out of FormatTest.cpp

Author: owenca Date: 2022-10-27T01:29:31-07:00 New Revision: 17059753f1337209fb4cb06098c1bc65418775e9 URL: https://github.com/llvm/llvm-project/commit/17059753f1337209fb4cb06098c1bc65418775e9 DIFF: https://github.com/llvm/llvm-project/commit/17059753f1337209fb4cb06098c1bc65418775e9.diff LOG: [

[PATCH] D136658: [clang-format] Move InsertBraces unit tests out of FormatTest.cpp

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG17059753f133: [clang-format] Move InsertBraces unit tests out of FormatTest.cpp (authored by owenpan). Repository: rG LLVM Github Monorepo CHANGE

[clang] 0cbf003 - [PowerPC] Fix check for ieeelongdouble support

Author: Nikita Popov Date: 2022-10-27T10:36:37+02:00 New Revision: 0cbf003c78cdba5cc81b69ee4cd6cee53f2e2796 URL: https://github.com/llvm/llvm-project/commit/0cbf003c78cdba5cc81b69ee4cd6cee53f2e2796 DIFF: https://github.com/llvm/llvm-project/commit/0cbf003c78cdba5cc81b69ee4cd6cee53f2e2796.diff

[PATCH] D136258: [PowerPC] Fix check for ieeelongdouble support

This revision was automatically updated to reflect the committed changes. Closed by commit rG0cbf003c78cd: [PowerPC] Fix check for ieeelongdouble support (authored by nikic). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo CHANGES SINC

[PATCH] D135932: [X86] Add AVX-IFMA instructions.

skan accepted this revision. skan added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135932/new/ https://reviews.llvm.org/D135932 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D135583: [LLVM] Use DWARFv4 bitfields when tuning for GDB

DavidSpickett updated this revision to Diff 471065. DavidSpickett added a comment. - DWARFvN -> DWARF vN - Remove superfluous brackets. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135583/new/ https://reviews.llvm.org/D135583 Files: clang/docs/

[clang] e8541e4 - [NFC] [Modules] Rename modules related things in Preprocessor and AffectingModules

Author: Chuanqi Xu Date: 2022-10-27T16:40:26+08:00 New Revision: e8541e4b42c54e106940b846123508742e026b7d URL: https://github.com/llvm/llvm-project/commit/e8541e4b42c54e106940b846123508742e026b7d DIFF: https://github.com/llvm/llvm-project/commit/e8541e4b42c54e106940b846123508742e026b7d.diff LO

[PATCH] D135938: [X86] Add AVX-VNNI-INT8 instructions.

skan accepted this revision. skan added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135938/new/ https://reviews.llvm.org/D135938 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] c6e2de6 - [LLVM] Use DWARFv4 bitfields when tuning for GDB

Author: David Spickett Date: 2022-10-27T08:51:07Z New Revision: c6e2de60423ae98b1a7a175bab98c3c3c578b284 URL: https://github.com/llvm/llvm-project/commit/c6e2de60423ae98b1a7a175bab98c3c3c578b284 DIFF: https://github.com/llvm/llvm-project/commit/c6e2de60423ae98b1a7a175bab98c3c3c578b284.diff LOG

[PATCH] D135583: [LLVM] Use DWARFv4 bitfields when tuning for GDB

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc6e2de60423a: [LLVM] Use DWARFv4 bitfields when tuning for GDB (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[PATCH] D135366: [clang][Interp] Implement String- and CharacterLiterals

cor3ntin accepted this revision. cor3ntin added a comment. This revision is now accepted and ready to land. Give some time for Aaron/Tom to have the chance to raise further comment but I'm happy with it otherwise. Thanks for doing that, and sorry I missed you earlier ping. CHANGES SINCE LAST AC

[PATCH] D136440: [clang] Do not hide base member using-decls with different template head.

ilya-biryukov accepted this revision. ilya-biryukov added inline comments. This revision is now accepted and ready to land. Comment at: clang/test/SemaTemplate/concepts-using-decl.cpp:174 +} // namespace heads_without_concepts. \ No newline at end of file NIT: a

[PATCH] D135951: [X86][1/2] SUPPORT RAO-INT

RKSimon accepted this revision. RKSimon added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135951/new/ https://reviews.llvm.org/D135951 _

[clang] 97dcbd1 - Pre-commit test case for D136784

Author: eopXD Date: 2022-10-27T01:57:24-07:00 New Revision: 97dcbd124d542f46313fdc28ae48ae0d4fd09ac7 URL: https://github.com/llvm/llvm-project/commit/97dcbd124d542f46313fdc28ae48ae0d4fd09ac7 DIFF: https://github.com/llvm/llvm-project/commit/97dcbd124d542f46313fdc28ae48ae0d4fd09ac7.diff LOG: Pr

[PATCH] D136783: Pre-commit test case for D136784

This revision was automatically updated to reflect the committed changes. Closed by commit rG97dcbd124d54: Pre-commit test case for D136784 (authored by eopXD). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136783/new/ https://reviews.llvm.org/D1367

[PATCH] D134453: Disambiguate type names when printing NTTP types

DoDoENT updated this revision to Diff 471081. DoDoENT edited the summary of this revision. DoDoENT added a comment. Removed the policy and full explicit type printing behind it and keep only printing of first type name, as suggested by the review. This is essentially (2) from here: https://revie

[PATCH] D134453: Disambiguate type names when printing NTTP types

DoDoENT updated this revision to Diff 471083. DoDoENT added a comment. Restored trailing whitespace on untouched line that was automatically deleted by editor's save action. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134453/new/ https://reviews

[PATCH] D136723: [include-cleaner] Record main-file macro occurences and includes

kadircet added inline comments. Comment at: clang-tools-extra/include-cleaner/include/clang-include-cleaner/Record.h:54 +struct RecordedPP { + // The callback (when installed into clang) tracks macros/includes in this. + std::unique_ptr record(const Preprocessor &PP);

[PATCH] D136440: [clang] Do not hide base member using-decls with different template head.

usaxena95 updated this revision to Diff 471086. usaxena95 marked 2 inline comments as done. usaxena95 added a comment. Addressed comments. Added release notes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136440/new/ https://reviews.llvm.org/D1364

[PATCH] D136826: [clang][Interp] Make sure we free() allocated InitMaps

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane, tahonermann, shafik. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. They get allocated when calling `initialize()` on a

[clang] b51b90d - [X86][1/2] SUPPORT RAO-INT

Author: Phoebe Wang Date: 2022-10-27T17:20:07+08:00 New Revision: b51b90d6e25c3a3129608e2d764cae8818b7ad15 URL: https://github.com/llvm/llvm-project/commit/b51b90d6e25c3a3129608e2d764cae8818b7ad15 DIFF: https://github.com/llvm/llvm-project/commit/b51b90d6e25c3a3129608e2d764cae8818b7ad15.diff L

[PATCH] D135951: [X86][1/2] SUPPORT RAO-INT

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb51b90d6e25c: [X86][1/2] SUPPORT RAO-INT (authored by pengfei). Changed prior to commit: https://reviews.llvm.org/D135951?vs=471040&id=471093#toc

[clang] 56099d2 - [clang] Do not hide base member using-decls with different template head.

Author: Utkarsh Saxena Date: 2022-10-27T11:52:46+02:00 New Revision: 56099d242809f80984e4afa37693177484aab13d URL: https://github.com/llvm/llvm-project/commit/56099d242809f80984e4afa37693177484aab13d DIFF: https://github.com/llvm/llvm-project/commit/56099d242809f80984e4afa37693177484aab13d.diff

[PATCH] D136440: [clang] Do not hide base member using-decls with different template head.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG56099d242809: [clang] Do not hide base member using-decls with different template head. (authored by usaxena95). Changed prior to commit: https://

[PATCH] D136830: [clang-format][NFC] Move BracesRemover tests out of FormatTest.cpp

owenpan created this revision. owenpan added reviewers: MyDeveloperDay, HazardyKnusperkeks, rymiel. owenpan added a project: clang-format. Herald added a project: All. owenpan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG

[PATCH] D136568: [Clang] Support constexpr builtin ilogb

Izaron updated this revision to Diff 471101. Izaron added a comment. Deal with MSVC where sizeof(long double) == sizeof(double) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136568/new/ https://reviews.llvm.org/D136568 Files: clang/docs/Language

[PATCH] D136831: [clang][Interp] Protect Record creation against infinite recusion

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane, tahonermann, shafik. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This only happens in error cases as far as I know,

[clang] e26f287 - Fix buildbot fail

Author: Phoebe Wang Date: 2022-10-27T18:23:19+08:00 New Revision: e26f28711c1f81b7f74ce749269e7539492d3934 URL: https://github.com/llvm/llvm-project/commit/e26f28711c1f81b7f74ce749269e7539492d3934 DIFF: https://github.com/llvm/llvm-project/commit/e26f28711c1f81b7f74ce749269e7539492d3934.diff L

[PATCH] D136589: [AArch64] Add support for the Cortex-X3 CPU

vhscampos planned changes to this revision. vhscampos added a comment. We found an issue in the list of target features for v9-A. This patch will be affected. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136589/new/ https://reviews.llvm.org/D1365

[PATCH] D136071: [include-cleaner] WIP: Add PragmaIncludes which handles include-mapping pragmas.

kadircet added inline comments. Comment at: clang-tools-extra/include-cleaner/include/clang-include-cleaner/Record.h:35 +// Captures #include mapping information. It analyses IWYU Pragma comments and +// other use-instead-like mechanisms (#pragma include_instead) on included -

[PATCH] D136603: [analyzer] Model cast after LValueToRValueBitCasts

steakhal updated this revision to Diff 471112. steakhal added a comment. Previously, even in the `RegionStoreManager::getBinding()` even if `T` was non-null, we replaced it with `TVR->getValueType()` in case the `MR` was `TypedValueRegion`. IMO we shouldn't overwrite the type unless we actually

[PATCH] D136532: [clang][Interp] Implement left and right shifts

tbaeder updated this revision to Diff 471113. tbaeder marked 3 inline comments as done. tbaeder added a comment. Added suport for `>>=` and `<<=` as well so the test cases for those can be enabled. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136532/new/ https://reviews.llvm.org/D1365

[PATCH] D136532: [clang][Interp] Implement left and right shifts

tbaeder added inline comments. Comment at: clang/test/AST/Interp/shifts.cpp:57 +//c >>= 99; // expected-warning {{shift count >= width of type}} +//c <<= CHAR_BIT; // expected-warning {{shift count >= width of type}} +//c >>= CHAR_BIT; // expected-warning {{shift

[PATCH] D136835: [Clang][LoongArch] Support inline asm constraint 'J'

SixWeining created this revision. SixWeining added reviewers: xen0n, xry111, MaskRay, wangleiat, gonglingqin. Herald added subscribers: StephenFan, hiraditya. Herald added a project: All. SixWeining requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llv

[PATCH] D136624: [clang][modules] Account for non-affecting inputs in `ASTWriter`

jansvoboda11 added a comment. In D136624#3880526 , @Bigcheese wrote: > This looks reasonable. Have you measured the performance impact of this > change? I have done comparison between this patch and https://github.com/apple/llvm-project/pull/5451 (that

[PATCH] D136776: [clang codegen] Fix __try/__finally blocks in C++ constructors.

mstorsjo resigned from this revision. mstorsjo added a comment. Sorry, I know essentially nothing about this area... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136776/new/ https://reviews.llvm.org/D136776 ___

[clang] 88d7508 - Harmonize cmake_policy() across standalone builds of all projects

Author: Michał Górny Date: 2022-10-27T13:46:56+02:00 New Revision: 88d7508dc479210f07abccb17f0194b66264b125 URL: https://github.com/llvm/llvm-project/commit/88d7508dc479210f07abccb17f0194b66264b125 DIFF: https://github.com/llvm/llvm-project/commit/88d7508dc479210f07abccb17f0194b66264b125.diff

[PATCH] D136572: Harmonize cmake_policy() across standalone builds of all projects

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG88d7508dc479: Harmonize cmake_policy() across standalone builds of all projects (authored by mgorny). Herald added projects: clang, LLDB, Flang. Rep

[PATCH] D136572: Harmonize cmake_policy() across standalone builds of all projects

mstorsjo added a comment. Herald added subscribers: JDevlieghere, jdoerfert. This broke builds where clang/lld/lldb are symlinked into `llvm/tools` instead of specified via `LLVM_ENABLE_PROJECTS` - since `${CMAKE_CURRENT_SOURCE_DIR}/../cmake` doesn't find anything in that context. (The reason f

[PATCH] D136839: [clang][Interp] Handle non-primitive locals without initializer

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane, tahonermann, shafik. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This previously made us crash later on when passing

[PATCH] D136817: [RISCV] Add H extension

asb added a comment. Thanks for this patch Kito - I'm thinking that perhaps we erred in not treating the hypervisor instructions (e.g. HLV* and HSV*) as being gated on the H extension, so a sensible follow-on to this patch would be to mark those instructions as requiring FeatureStdExtH - what d

[PATCH] D136812: [RISCV] Drop single letter b extension support

asb accepted this revision. asb added a comment. This revision is now accepted and ready to land. LGTM, thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136812/new/ https://reviews.llvm.org/D136812

[PATCH] D136796: [llvm-objdump][Offload] Use common offload extraction method

jhuber6 updated this revision to Diff 471132. jhuber6 added a comment. Adding separate tests for `ET_REL`, `ET_EXEC`, and `ET_DYN`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136796/new/ https://reviews.llvm.org/D136796 Files: clang/tools/cla

[PATCH] D136572: Harmonize cmake_policy() across standalone builds of all projects

mstorsjo added a comment. In D136572#3888177 , @mstorsjo wrote: > This broke builds where clang/lld/lldb are symlinked into `llvm/tools` > instead of specified via `LLVM_ENABLE_PROJECTS` - since > `${CMAKE_CURRENT_SOURCE_DIR}/../cmake` doesn't find anyt

[PATCH] D136835: [Clang][LoongArch] Support inline asm constraint 'J'

SixWeining updated this revision to Diff 471135. SixWeining added a comment. Add missing comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136835/new/ https://reviews.llvm.org/D136835 Files: clang/lib/Basic/Targets/LoongArch.cpp clang/tes

[PATCH] D136532: [clang][Interp] Implement left and right shifts

aaron.ballman added inline comments. Comment at: clang/lib/AST/Interp/Interp.h:1291-1305 + if (RHS.isNegative()) { const SourceInfo &Loc = S.Current->getSource(OpPC); S.CCEDiag(Loc, diag::note_constexpr_negative_shift) << RHS.toAPSInt(); -return ShiftLeft(S, OpPC,

[PATCH] D134453: Disambiguate type names when printing NTTP types

aaron.ballman added reviewers: aaron.ballman, dblaikie. aaron.ballman added a comment. Thanks! The changes are generally looking good to me. Can you add a release note about the improvement to our diagnostic behavior (in clang/docs/ReleaseNotes.rst -- there's a section for diagnostic improvement

[PATCH] D134859: [clang][Interp] Implement basic support for floating point values

sepavloff added inline comments. Comment at: clang/lib/AST/Interp/PrimType.h:39 PT_Bool, + PT_Float, PT_Ptr, In contrast to other members of this enumeration, `PT_Float` does not designate a concrete type, and it must creates problems. For example, how fu

[PATCH] D135366: [clang][Interp] Implement String- and CharacterLiterals

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM aside from a testing request. Comment at: clang/test/AST/Interp/literals.cpp:342 + static_assert(mc == 'abc', ""); + __WCHAR_TYPE__ wm = L'abc'; // ref-error{{wide character literals may not contain mu

[PATCH] D136572: Harmonize cmake_policy() across standalone builds of all projects

mgorny added a comment. I've reverted it right now, and I'll update the patch later today. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136572/new/ https://reviews.llvm.org/D136572 ___ cfe-commits maili

[PATCH] D136532: [clang][Interp] Implement left and right shifts

tbaeder updated this revision to Diff 471138. tbaeder marked 5 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136532/new/ https://reviews.llvm.org/D136532 Files: clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/lib/AST/Interp/Interp.h clang/lib/AST/Interp/Opco

[PATCH] D136532: [clang][Interp] Implement left and right shifts

tbaeder added inline comments. Comment at: clang/lib/AST/Interp/Interp.h:1291-1305 + if (RHS.isNegative()) { const SourceInfo &Loc = S.Current->getSource(OpPC); S.CCEDiag(Loc, diag::note_constexpr_negative_shift) << RHS.toAPSInt(); -return ShiftLeft(S, OpPC, LHS, T

[PATCH] D136826: [clang][Interp] Make sure we free() allocated InitMaps

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. The changes look correct to me, but you may want to wait a little bit before landing to give the other reviewers a chance to look this over given that there's no tests possible f

[PATCH] D136532: [clang][Interp] Implement left and right shifts

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136532/new/ https://reviews.llvm.org/D136532 ___ cfe-commits mailing lis

[PATCH] D136841: [LoongArch] Support inline asm operand modifier 'z'

SixWeining created this revision. SixWeining added reviewers: xen0n, xry111, MaskRay, wangleiat, gonglingqin. Herald added subscribers: StephenFan, pengfei, hiraditya. Herald added a project: All. SixWeining requested review of this revision. Herald added projects: clang, LLVM. Herald added subscri

[PATCH] D134859: [clang][Interp] Implement basic support for floating point values

tbaeder added inline comments. Comment at: clang/lib/AST/Interp/PrimType.h:39 PT_Bool, + PT_Float, PT_Ptr, sepavloff wrote: > In contrast to other members of this enumeration, `PT_Float` does not > designate a concrete type, and it must creates problems.

[PATCH] D136807: [clang][Sema] Fix a clang crash with btf_type_tag

aaron.ballman added a comment. The changes generally look good to me, but can you add a release note for the fix as well? Comment at: clang/test/Sema/attr-btf_type_tag-func-ptr.c:1 +// RUN: %clang_cc1 -x c -triple x86_64-pc-linux-gnu -dwarf-version=4 -fsyntax-only -verify %s

[PATCH] D116735: [RISCV] Adjust RISCV data layout by using n32:64 in layout string

asb added a comment. I've put it on the agenda for the call today so we can close this off (I figure given it's been sitting so long, waiting a few extra days to cover it in the call is no big deal). But if the data shows this overall improves things, I think it's a sensible change to make. R

[PATCH] D136071: [include-cleaner] WIP: Add PragmaIncludes which handles include-mapping pragmas.

sammccall added a comment. LG from my side Comment at: clang-tools-extra/include-cleaner/include/clang-include-cleaner/Record.h:58 + // Line numbers for the include directives in the main file that have the + // `IWYU pragma: keep` right after. + llvm::DenseSet ShouldKeep;

[PATCH] D136710: [include-cleaner] Add the missing parts of Symbol and Header clases.

sammccall updated this revision to Diff 471143. sammccall added a comment. Add comment on variant/enum order match. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136710/new/ https://reviews.llvm.org/D136710 Files: clang-tools-extra/include-clean

[PATCH] D135366: [clang][Interp] Implement String- and CharacterLiterals

tbaeder updated this revision to Diff 471144. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135366/new/ https://reviews.llvm.org/D135366 Files: clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/lib/AST/Interp/ByteCodeExprGen.h clang/test/AST/Interp/literals.cpp clang/test/Lexer/char

[PATCH] D134128: [P0857R0 Part B] Resubmit an implemention for constrained template template parameters

erichkeane added a comment. In D134128#3887549 , @lime wrote: > Update as suggested. Could you please help me apply this patch? It seems > unsuitable to grant a fresh account the accessibility. > > F25074741: 0001-P0857R0-Part-B-Allows-require-clauses-ap

[PATCH] D136474: [CodeView][clang] Disable emitting command line into CodeView by default and add flag to enable

thakis added a comment. > I read that, and I'm indicating that I don't agree. Chromium's requirements > are driven by its particular usage of a cross-compiling distributed build > system, which may not represent the average user's needs. Are you saying that it's a good thing if clang produces d

[PATCH] D134453: Disambiguate type names when printing NTTP types

DoDoENT updated this revision to Diff 471145. DoDoENT added a comment. Updated clang release notes about improvement to diagnostics as requested by reviewers and added more vim-specific temp files to .gitignore. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[PATCH] D136710: [include-cleaner] Add the missing parts of Symbol and Header clases.

kadircet accepted this revision. kadircet added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/include-cleaner/include/clang-include-cleaner/Types.h:49 + Kind kind() const { return static_cast(Storage.index()); } + bool operat

[PATCH] D136828: [clang][Interp] Diagnose uninitialized array record fields

aaron.ballman added inline comments. Comment at: clang/lib/AST/Interp/Interp.cpp:446-448 +static void DiagnoseUninitializedSubobject(InterpState &S, const SourceInfo &SI, + QualType SubObjType, +

[PATCH] D134128: [P0857R0 Part B] Resubmit an implemention for constrained template template parameters

lime added a comment. `Liming Liu ` It is also included in the patch file. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134128/new/ https://reviews.llvm.org/D134128 ___ cfe-commits mailing list cfe-com

[PATCH] D134128: [P0857R0 Part B] Resubmit an implemention for constrained template template parameters

erichkeane added a comment. In D134128#3888361 , @lime wrote: > `Liming Liu ` > > It is also included in the patch file. Ok, I'll use that. Typically we don't use a separately attached patch-file, we just use the phabricator 'download patch', so I didn

[PATCH] D134453: Disambiguate type names when printing NTTP types

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM assuming precommit CI comes back green. Do you need someone to land these changes on your behalf? If so, please let me know what name and email address you'd like used for p

[PATCH] D136723: [include-cleaner] Record main-file macro occurences and includes

sammccall updated this revision to Diff 471150. sammccall marked 10 inline comments as done. sammccall added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136723/new/ https://reviews.llvm.org/D136723 Files: clang-tool

[PATCH] D136624: [clang][modules] Account for non-affecting inputs in `ASTWriter`

jansvoboda11 added a comment. I tried optimizing this patch a bit. Instead of creating compact data structure and using binary search to find the preceding non-affecting file, I now store the adjustment information for each `FileID` in a vector. During deserialization, `FileID` is simply used a

[PATCH] D128457: [clangd] Add new IncludeType to IncludeHeaderWithReferences

kadircet added inline comments. Comment at: clang-tools-extra/clangd/index/Symbol.h:93 +Import = 2, + }; + you can use `LLVM_MARK_AS_BITMASK_ENUM` and relevant magic to implement bitwise operators on the type (see llvm-project/llvm/include/llvm/ADT/BitmaskE

[PATCH] D136624: [clang][modules] Account for non-affecting inputs in `ASTWriter`

jansvoboda11 updated this revision to Diff 471152. jansvoboda11 added a comment. New version with flat vector + `FileID` indices; replacing the previous compact representation & binary search approach Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D136831: [clang][Interp] Protect Record creation against infinite recusion

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136831/new/ https://reviews.llvm.org/D136831

[clang] ae48d1c - [P0857R0 Part-B] Allows `require' clauses appearing in

Author: Liming Liu Date: 2022-10-27T06:41:43-07:00 New Revision: ae48d1c76a6c14cdbf3a3e73f6c2c2befd0a81b0 URL: https://github.com/llvm/llvm-project/commit/ae48d1c76a6c14cdbf3a3e73f6c2c2befd0a81b0 DIFF: https://github.com/llvm/llvm-project/commit/ae48d1c76a6c14cdbf3a3e73f6c2c2befd0a81b0.diff LO

[PATCH] D134128: [P0857R0 Part B] Resubmit an implemention for constrained template template parameters

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rGae48d1c76a6c: [P0857R0 Part-B] Allows `require' clauses appearing in (authored by lime, committed by erichkeane). Changed

[PATCH] D136710: [include-cleaner] Add the missing parts of Symbol and Header clases.

sammccall marked an inline comment as done. sammccall added inline comments. Comment at: clang-tools-extra/include-cleaner/include/clang-include-cleaner/Types.h:49 + Kind kind() const { return static_cast(Storage.index()); } + bool operator==(const Symbol &RHS) const { retur

[PATCH] D136844: [libclang] Expose completion result kind in `CXCompletionResult`

egorzhdan created this revision. egorzhdan added reviewers: arphaman, bnbarham. Herald added a subscriber: kadircet. Herald added a project: All. egorzhdan requested review of this revision. Herald added projects: clang, clang-tools-extra. Herald added a subscriber: cfe-commits. This allows client

[PATCH] D136723: [include-cleaner] Record main-file macro occurences and includes

sammccall updated this revision to Diff 471155. sammccall added a comment. const Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136723/new/ https://reviews.llvm.org/D136723 Files: clang-tools-extra/include-cleaner/include/clang-include-cleaner/Re

[PATCH] D136694: [clang][Interp] Check that constructor calls initialize all record fields

aaron.ballman added a comment. It's worth noting that there are core issues in this area: https://wg21.link/cwg2558 and https://wg21.link/cwg2536 and they're not yet resolved. Comment at: clang/test/AST/Interp/records.cpp:276 // FIXME: This is currently not being diagnos

[PATCH] D136844: [libclang] Expose completion result kind in `CXCompletionResult`

kadircet added inline comments. Comment at: clang/include/clang/Sema/CodeCompleteConsumer.h:755 - /// Describes the kind of result generated. - enum ResultKind { -/// Refers to a declaration. i don't follow the reason for replacing this struct with `CXComp

[PATCH] D136782: [include-cleaner] Move the writeHTMLReport to the public header, NFC.

sammccall added a comment. OOC, Is there something prompting doing this immediately? I *did* originally plan to mechanically move this and we *can* but... The API isn't even approximately the right shape (FileID should go away as we've baked main-file assumption in, Roots needs to be paired with

[PATCH] D136474: [CodeView][clang] Disable emitting command line into CodeView by default and add flag to enable

aganea added a comment. In D136474#3888330 , @thakis wrote: >> I read that, and I'm indicating that I don't agree. Chromium's requirements >> are driven by its particular usage of a cross-compiling distributed build >> system, which may not represent th

[PATCH] D136846: [Driver] Enable profi flag as user-facing flag

HaoyuZhang created this revision. Herald added a subscriber: wenlei. Herald added a project: All. HaoyuZhang requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. This patch enable -sample-profile-use-profi in Clang frontend as user-facin

  1   2   3   >