[PATCH] D136571: [RISCV] add svinval extension

reames accepted this revision. reames added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136571/new/ https://reviews.llvm.org/D136571 ___

[PATCH] D136103: OpenMP asynchronous memory copy support

tianshilei1992 accepted this revision. tianshilei1992 added a comment. This revision is now accepted and ready to land. Thanks! LG. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136103/new/ https://reviews.llvm.org/D136103 ___ cfe-commits mai

[PATCH] D136737: [Draft] [clang] Add builtin_unspecified_value

erichkeane added a comment. It doesn't really make sense to me why this is an AST node expr-node-type rather than just being a call to a builtin (that'll likely need to take a var as a parameter)? We can make that builtin result in a freeze/poison value if necessary. So something like: `_si

[clang] 7d7940f - [RISCV] add svinval extension

Author: Piyou Chen Date: 2022-10-26T09:45:30-07:00 New Revision: 7d7940fd7761e21b68f915e948389b87835d1304 URL: https://github.com/llvm/llvm-project/commit/7d7940fd7761e21b68f915e948389b87835d1304 DIFF: https://github.com/llvm/llvm-project/commit/7d7940fd7761e21b68f915e948389b87835d1304.diff LO

[PATCH] D136571: [RISCV] add svinval extension

This revision was automatically updated to reflect the committed changes. Closed by commit rG7d7940fd7761: [RISCV] add svinval extension (authored by BeMg). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136571/new/ https://reviews.llvm.org/D136571

[PATCH] D135583: [LLVM] Use DWARFv4 bitfields when tuning for GDB

dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. Sounds good, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135583/new/ https://reviews.llvm.org/D135583 ___

[PATCH] D136532: [clang][Interp] Implement left and right shifts

shafik added inline comments. Comment at: clang/test/AST/Interp/shifts.cpp:57 +//c >>= 99; // expected-warning {{shift count >= width of type}} +//c <<= CHAR_BIT; // expected-warning {{shift count >= width of type}} +//c >>= CHAR_BIT; // expected-warning {{shift c

[PATCH] D136737: [Draft] [clang] Add builtin_unspecified_value

erichkeane added a subscriber: aaron.ballman. erichkeane added a comment. Also, as discussed with @aaron.ballman, 'unspecified' has VERY specific meaning in C/C++, and you don't seem to mean that here. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D134453: Disambiguate type names when printing NTTP types

dblaikie added a comment. > it's up to IDE's and good editors and CI log parsers to parse that and > present in a possibly better format. Lots of folks use the diagnostic info from their compiler without IDEs or log parsers doing anything else to them - we should be trying to design these thin

[clang] 443e2a1 - Reland "[PGO] Make emitted symbols hidden"

Author: Alex Brachet Date: 2022-10-26T17:13:05Z New Revision: 443e2a10f69caeedb9fa621366b16fe0d4358279 URL: https://github.com/llvm/llvm-project/commit/443e2a10f69caeedb9fa621366b16fe0d4358279 DIFF: https://github.com/llvm/llvm-project/commit/443e2a10f69caeedb9fa621366b16fe0d4358279.diff LOG:

[PATCH] D136532: [clang][Interp] Implement left and right shifts

aaron.ballman added inline comments. Comment at: clang/test/AST/Interp/shifts.cpp:57 +//c >>= 99; // expected-warning {{shift count >= width of type}} +//c <<= CHAR_BIT; // expected-warning {{shift count >= width of type}} +//c >>= CHAR_BIT; // expected-warning {{

[PATCH] D135583: [LLVM] Use DWARFv4 bitfields when tuning for GDB

MaskRay added inline comments. Comment at: clang/docs/ReleaseNotes.rst:619 +Previously when emitting DWARFv4 and tuning for GDB, Clang would use DWARFv2's +``DW_AT_bit_offset`` and ``DW_AT_data_member_location``. Clang now uses DWARFv4's "DWARF v4" is more com

[PATCH] D135011: Add builtin_elementwise_sin and builtin_elementwise_cos

bob80905 added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135011/new/ https://reviews.llvm.org/D135011 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[PATCH] D136700: clang: Add a cmake toggle to disable libclang's libxml2 dependency

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. lgtm CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136700/new/ https://reviews.llvm.org/D136700 ___ cfe-commits mailing list cfe-commits@lists

[PATCH] D134128: [P0857R0 Part B] Resubmit an implemention for constrained template template parameters

erichkeane added inline comments. Comment at: clang/docs/ReleaseNotes.rst:554 +- Implemented `P0857R0 `_, + which words for constrained lambdas and constrained template *template-parameter*\s. ---

[PATCH] D136744: [Clang] perform "maximum TLS alignment" check for template instantiation

ychen updated this revision to Diff 470858. ychen added a comment. Herald added a reviewer: aaron.ballman. - remove unnecessary check Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136744/new/ https://reviews.llvm.org/D136744 Files: clang/include

[PATCH] D136744: [Clang] perform "maximum TLS alignment" check for template instantiation

ychen added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:14038-14039 + + if (!Context.getTargetInfo().isTLSSupported()) +return; + mizvekov wrote: > Is this needed? It seems `getMaxTLSAlign()` will return 0 in that case anyway. It is checked in t

[PATCH] D136701: [LinkerWrapper] Perform device linking steps in parallel

jhuber6 updated this revision to Diff 470859. jhuber6 added a comment. Make the default number of threads one, let users use `-Wl,--wrapper-jobs=N` to use parallelism. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136701/new/ https://reviews.llvm.

[PATCH] D136707: [clang][Toolchains][Gnu] pass -gdwarf-* through to assembler

nickdesaulniers updated this revision to Diff 470860. nickdesaulniers marked 3 inline comments as done. nickdesaulniers added a comment. - add const, fix lowerCamelCase, use Twine Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136707/new/ https://re

[clang] df239a6 - clang: Add a cmake toggle to disable libclang's libxml2 dependency

Author: Nico Weber Date: 2022-10-26T13:34:19-04:00 New Revision: df239a6c17fa51274e38f185e72ac02c2f8fb914 URL: https://github.com/llvm/llvm-project/commit/df239a6c17fa51274e38f185e72ac02c2f8fb914 DIFF: https://github.com/llvm/llvm-project/commit/df239a6c17fa51274e38f185e72ac02c2f8fb914.diff LO

[PATCH] D136700: clang: Add a cmake toggle to disable libclang's libxml2 dependency

This revision was automatically updated to reflect the committed changes. Closed by commit rGdf239a6c17fa: clang: Add a cmake toggle to disable libclang's libxml2 dependency (authored by thakis). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[PATCH] D136707: [clang][Toolchains][Gnu] pass -gdwarf-* through to assembler

MaskRay added inline comments. Comment at: clang/lib/Driver/ToolChains/Gnu.cpp:979 + unsigned DwarfVersion = GetDwarfVersion(getToolChain(), Args); + std::string DV = "-gdwarf-" + std::to_string(DwarfVersion); + CmdArgs.push_back(Args.MakeArgString(DV)); --

[clang] ad78ce4 - [clang][Toolchains][Gnu] pass -gdwarf-* through to assembler

Author: Nick Desaulniers Date: 2022-10-26T10:45:22-07:00 New Revision: ad78ce44bb4771139d2a18d6e1052268a7507a52 URL: https://github.com/llvm/llvm-project/commit/ad78ce44bb4771139d2a18d6e1052268a7507a52 DIFF: https://github.com/llvm/llvm-project/commit/ad78ce44bb4771139d2a18d6e1052268a7507a52.di

[PATCH] D136707: [clang][Toolchains][Gnu] pass -gdwarf-* through to assembler

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGad78ce44bb47: [clang][Toolchains][Gnu] pass -gdwarf-* through to assembler (authored by nickdesaulniers). Repository: rG LLVM Github Monorepo CHA

[PATCH] D136701: [LinkerWrapper] Perform device linking steps in parallel

jhuber6 updated this revision to Diff 470867. jhuber6 added a comment. Herald added a subscriber: mgrang. Adding a sort so the entires appear in a deterministic order. The sort is simply a lexigraphic comparison. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews

[clang] 5e676aa - Add tests for C11 DRs and update the status page

Author: Aaron Ballman Date: 2022-10-26T13:53:50-04:00 New Revision: 5e676aa702d8df32a832c765eb8f60773d190236 URL: https://github.com/llvm/llvm-project/commit/5e676aa702d8df32a832c765eb8f60773d190236 DIFF: https://github.com/llvm/llvm-project/commit/5e676aa702d8df32a832c765eb8f60773d190236.diff

[PATCH] D128457: [clangd] Add new IncludeType to IncludeHeaderWithReferences

dgoldman updated this revision to Diff 470868. dgoldman added a comment. Change IncludeTypes to be a bitset Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128457/new/ https://reviews.llvm.org/D128457 Files: clang-tools-extra/clangd/index/Merge.cp

[clang] 09ff2e5 - [Driver] Avoid unsafe Twine local variable after D136707

Author: Fangrui Song Date: 2022-10-26T10:58:22-07:00 New Revision: 09ff2e567a5f9bf9f3c82390020a5bd995feeaaf URL: https://github.com/llvm/llvm-project/commit/09ff2e567a5f9bf9f3c82390020a5bd995feeaaf DIFF: https://github.com/llvm/llvm-project/commit/09ff2e567a5f9bf9f3c82390020a5bd995feeaaf.diff

[PATCH] D136743: [HLSL] support ConstantBuffer

python3kgae updated this revision to Diff 470870. python3kgae edited the summary of this revision. python3kgae added a comment. Fix windows test fail caused by dead ptr. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136743/new/ https://reviews.llvm

[PATCH] D136080: [flang] Add -ffp-contract option processing

MaskRay added inline comments. Comment at: clang/lib/Driver/ToolChains/Flang.cpp:89 +const StringRef Val = A->getValue(); +if (Val.equals("fast") || Val.equals("off")) { + FPContract = Val; We prefer `==` to `equals` CHANGES SINCE LAST ACTION htt

[PATCH] D134453: Disambiguate type names when printing NTTP types

aaron.ballman added a comment. In D134453#3885961 , @dblaikie wrote: >> it's up to IDE's and good editors and CI log parsers to parse that and >> present in a possibly better format. > > Lots of folks use the diagnostic info from their compiler without I

[PATCH] D136776: [clang codegen] Fix __try/__finally blocks in C++ constructors.

efriedma created this revision. efriedma added reviewers: rjmccall, rnk, mstorsjo. Herald added a project: All. efriedma requested review of this revision. Herald added a project: clang. We were crashing trying to construct a GlobalDecl from a CXXConstructorDecl in the mangler. Instead of trying

[PATCH] D136737: [Draft] [clang] Add builtin_unspecified_value

aaron.ballman added a comment. It looks like this is missing parsing logic and test cases. Comment at: clang/include/clang-c/Index.h:1534-1539 + /** + * A clang-builtin of unspecified value. + */ + CXCursor_UnspecifiedValueExpr = 155, + + CXCursor_LastExpr = CXCursor_Uns

[PATCH] D134831: [Clang][Sema] Add -Wcast-function-type-strict

samitolvanen added a comment. The patch to disable this warning in Linux without W=1 is now in all supported stable kernels (https://lwn.net/Articles/912498/), so I'll commit this later today. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134831/n

[PATCH] D136737: [Draft] [clang] Add builtin_unspecified_value

erichkeane added inline comments. Comment at: clang/lib/Sema/TreeTransform.h:11725 +TreeTransform::TransformUnspecifiedValueExpr(UnspecifiedValueExpr *E) { + return E; +} aaron.ballman wrote: > @erichkeane -- is this correct, or does work need to be done to ins

[PATCH] D136779: [clang][AST] make FunctionProtoType::Profile consistent for FoldingSet

troyj created this revision. troyj added a reviewer: bruno. Herald added a project: All. troyj requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch changes the Profile function to match the FunctionProtoType constructor, which uses e

[clang] 5b11caa - [NFC][Offload Bundler] Formatting clang offloadbundler source file.

Author: raghavmedicherla Date: 2022-10-26T15:12:47-04:00 New Revision: 5b11caa826202126ff102f3452d60d6c7b009913 URL: https://github.com/llvm/llvm-project/commit/5b11caa826202126ff102f3452d60d6c7b009913 DIFF: https://github.com/llvm/llvm-project/commit/5b11caa826202126ff102f3452d60d6c7b009913.di

[PATCH] D136715: [NFC][Offload Bundler] Formatting clang offloadbundler source file

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5b11caa82620: [NFC][Offload Bundler] Formatting clang offloadbundler source file. (authored by raghavmedicherla). Repository: rG LLVM Github Monor

[PATCH] D133698: [clang][dataflow] Implement transferBranch

aaron.ballman added a comment. FWIW, it looks like this change broke the AIX bot: https://lab.llvm.org/buildbot/#/builders/214/builds/3932 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133698/new/ https://reviews.llvm.org/D133698

[PATCH] D136651: [Clang] Give Clang the ability to use a shared stat cache

friss added inline comments. Comment at: llvm/lib/Support/VirtualFileSystem.cpp:3002 +// The format of the stat cache is (pseudo-code): +// struct stat_cache { +//char Magic[4]; // "STAT" or "Stat" steven_wu wrote: > Few comments about stats repres

[clang] 126db46 - [OpenMP][FIX] Adjust to clang tests after D136740

Author: Johannes Doerfert Date: 2022-10-26T12:33:55-07:00 New Revision: 126db4674aa54a37af4349d39f22e506b93d15de URL: https://github.com/llvm/llvm-project/commit/126db4674aa54a37af4349d39f22e506b93d15de DIFF: https://github.com/llvm/llvm-project/commit/126db4674aa54a37af4349d39f22e506b93d15de.d

[clang] 211f5af - [clang] Move getenv call for SOURCE_DATE_EPOCH out of frontend NFC

Author: Ben Langmuir Date: 2022-10-26T12:42:56-07:00 New Revision: 211f5af38af1810925343bb71d90ca8485e66300 URL: https://github.com/llvm/llvm-project/commit/211f5af38af1810925343bb71d90ca8485e66300 DIFF: https://github.com/llvm/llvm-project/commit/211f5af38af1810925343bb71d90ca8485e66300.diff

[PATCH] D136717: [clang] Move getenv call for SOURCE_DATE_EPOCH out of frontend NFC

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG211f5af38af1: [clang] Move getenv call for SOURCE_DATE_EPOCH out of frontend NFC (authored by benlangmuir). Herald added a project: clang. Herald add

[PATCH] D136717: [clang] Move getenv call for SOURCE_DATE_EPOCH out of frontend NFC

benlangmuir added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:4324 +if (Epoch.getAsInteger(10, V) || V > MaxTimestamp) { Diags.Report(diag::err_fe_invalid_source_date_epoch) << Epoch << MaxTimestamp; benlangmuir wr

[PATCH] D136782: [include-cleaner] Move the writeHTMLReport to the public header, NFC.

hokein created this revision. hokein added a reviewer: sammccall. Herald added a project: All. hokein requested review of this revision. Herald added a project: clang-tools-extra. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D136782 Files: clang-tools-extra/include-cleaner/in

[PATCH] D124260: [clang-format] ColumnLimit check for trailing comments alignment acts wrong for multi-byte UTF-8 #47624

HazardyKnusperkeks added a comment. Do you still intend to work on this? Otherwise I will commandeer and abandon. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124260/new/ https://reviews.llvm.org/D124260 ___ cfe-commits mailing list cfe-comm

[PATCH] D136783: Pre-commit test case

eopXD created this revision. Herald added a project: All. eopXD requested review of this revision. Herald added subscribers: cfe-commits, pcwang-thead. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D136783 Files: clang/test/Parser/pragma-loop.cpp

[PATCH] D136784: [Clang] Improve diagnotisc message for loop hint pragma

eopXD created this revision. Herald added a project: All. eopXD requested review of this revision. Herald added subscribers: cfe-commits, pcwang-thead. Herald added a project: clang. Originally the loop hint is not displayed correctly in the diagnostic. This patch fixes it. Repository: rG LLVM

[PATCH] D136784: [Clang] Improve diagnotisc message for loop hint pragma

eopXD updated this revision to Diff 470913. eopXD added a comment. Trigger upon parent revision. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136784/new/ https://reviews.llvm.org/D136784 Files: clang/lib/Parse/ParsePragma.cpp clang/test/Parse

[PATCH] D136601: [OpenMP] [OMPIRBuilder] Create a new datatype to hold the unique target region info

kda added a comment. This may have broken HWASAN buildbot: https://lab.llvm.org/buildbot/#/builders/236/builds/786 Running a build just before and after to check to validate guess based on stack. log snippet: ==956880==ERROR: HWAddressSanitizer: tag-mismatch on address 0xc09c0031 at pc 0

[PATCH] D136723: [include-cleaner] Record main-file macro occurences and includes

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. looks good from my side. Comment at: clang-tools-extra/include-cleaner/include/clang-include-cleaner/Types.h:52 struct Symbol { enum Kind { // A canonical clang dec

[PATCH] D135472: [ODRHash] Hash attributes on declarations.

vsapsai updated this revision to Diff 470915. vsapsai added a comment. Rebase and diagnose attribute mismatch for function parameters. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135472/new/ https://reviews.llvm.org/D135472 Files: clang/includ

[PATCH] D136651: [Clang] Give Clang the ability to use a shared stat cache

steven_wu added a comment. > Yes, we can. I pondered doing it in the original patch but didn't see a > reason this would evolve in the future. Of course, I can't predict the > future, so maybe a version field is the safe approach. I think a version number should be good enough for now. For the

[PATCH] D135918: [clang-format] Fix lambda formatting in conditional

HazardyKnusperkeks updated this revision to Diff 470914. HazardyKnusperkeks marked an inline comment as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135918/new/ https://reviews.llvm.org/D135918 Files: clang/lib/Format/ContinuationIndenter.c

[PATCH] D135918: [clang-format] Fix lambda formatting in conditional

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/ContinuationIndenter.cpp:336 + Previous.MatchingParen && Previous.MatchingParen->Previous && + Previous.MatchingParen->Previous->is(tok::r_brace) && + Previous.MatchingParen->Previous->MatchingP

[PATCH] D133874: [clang] Changes to produce sugared converted template arguments

glandium added a comment. Reduced testcase: cc1 command line: `clang-16 -cc1 -triple x86_64-unknown-linux-gnu -emit-obj -o Unified_cpp_editor_txmgr0.o -x c++-cpp-output Unified_cpp_editor_txmgr0.ii` source file content: class nsCycleCollectionParticipant; class nsCycleCollectingAutoRefCnt;

[PATCH] D135284: [Driver] select alternative target containing . in executable name

dankm added a comment. Thanks for the feedback. I've added a testcase for this, I'll push that change and update the summary. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135284/new/ https://reviews.llvm.org/D135284 _

[PATCH] D135284: [Driver] select alternative target containing . in executable name

MaskRay added a comment. In D135284#3886469 , @dankm wrote: > Thanks for the feedback. I've added a testcase for this, I'll push that > change and update the summary. Did you upload a new patch to the differential? I cannot see it. Repository: rG LL

[PATCH] D135284: [Driver] select alternative target containing . in executable name

dankm updated this revision to Diff 470918. dankm added a comment. Added a simple testcase, and updated commit message. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135284/new/ https://reviews.llvm.org/D135284 Files: clang/lib/Driver/ToolChain.

[PATCH] D135284: [Driver] select alternative target containing . in executable name

dankm added a comment. In D135284#3886471 , @MaskRay wrote: > In D135284#3886469 , @dankm wrote: > >> Thanks for the feedback. I've added a testcase for this, I'll push that >> change and update the summary. > >

[PATCH] D136786: Fix `unsafe-fp-math` attribute emission.

michele.scandale created this revision. michele.scandale added reviewers: zahiraam, aaron.ballman, andrew.w.kaylor, rjmccall, efriedma, fhahn. Herald added a subscriber: ormris. Herald added a project: All. michele.scandale requested review of this revision. Herald added a project: clang. Herald a

[PATCH] D136007: [clang][modules][deps] System module maps might not be affecting

Bigcheese accepted this revision. Bigcheese added a comment. This revision is now accepted and ready to land. lgtm once D136624 lands. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136007/new/ https://reviews.llvm

[PATCH] D135284: [Driver] allow target override containing . in executable name

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135284/new/ https://reviews.llvm.org/D135284 __

[PATCH] D136635: [clang-format] Don't misannotate in CTor init list

HazardyKnusperkeks updated this revision to Diff 470921. HazardyKnusperkeks marked an inline comment as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136635/new/ https://reviews.llvm.org/D136635 Files: clang/lib/Format/TokenAnnotator.cpp c

[clang] 1aad641 - [Clang][Sema] Add -Wcast-function-type-strict

Author: Sami Tolvanen Date: 2022-10-26T20:38:37Z New Revision: 1aad641c793090b4d036c03e737df2ebe2c32c57 URL: https://github.com/llvm/llvm-project/commit/1aad641c793090b4d036c03e737df2ebe2c32c57 DIFF: https://github.com/llvm/llvm-project/commit/1aad641c793090b4d036c03e737df2ebe2c32c57.diff LOG:

[PATCH] D134831: [Clang][Sema] Add -Wcast-function-type-strict

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1aad641c7930: [Clang][Sema] Add -Wcast-function-type-strict (authored by samitolvanen). Changed prior to commit: https://reviews.llvm.org/D134831?

[PATCH] D136786: Fix `unsafe-fp-math` attribute emission.

michele.scandale added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:1865 FuncAttrs.addAttribute("approx-func-fp-math", "true"); -if ((LangOpts.FastMath || - (!LangOpts.FastMath && LangOpts.AllowFPReassoc && - LangOpts.AllowRecip && !LangOp

[PATCH] D135284: [Driver] allow target override containing . in executable name

dankm added a comment. Thanks! Since I don't have privileges to push, can you do that on my behalf? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135284/new/ https://reviews.llvm.org/D135284 ___ cfe-comm

[PATCH] D136786: Fix `unsafe-fp-math` attribute emission.

michele.scandale added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:1865 FuncAttrs.addAttribute("approx-func-fp-math", "true"); -if ((LangOpts.FastMath || - (!LangOpts.FastMath && LangOpts.AllowFPReassoc && - LangOpts.AllowRecip && !LangOp

[PATCH] D136789: [clang] Remove no-op -fexperimental-new-pass-manager/-fno-legacy-pass-manager flags

aeubanks created this revision. aeubanks added a reviewer: MaskRay. Herald added a subscriber: StephenFan. Herald added a reviewer: ctetreau. Herald added a project: All. aeubanks requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. These have b

[PATCH] D136790: [Clang][Sema] Add -Wincompatible-function-pointer-types-strict

samitolvanen created this revision. Herald added a project: All. samitolvanen requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Clang supports indirect call Control-Flow Integrity (CFI) sanitizers (e.g. -fsanitize=cfi-icall), which enforce an

[PATCH] D136790: [Clang][Sema] Add -Wincompatible-function-pointer-types-strict

samitolvanen added reviewers: aaron.ballman, nickdesaulniers, pcc, joaomoreira, kees, nathanchance. samitolvanen added a comment. Similarly to D134831 , `-Wincompatible-function-pointer-types` also seems to miss int <-> enum mismatches in function pointer assig

[clang] f039437 - git clang-format HEAD~

Author: Nick Desaulniers Date: 2022-10-26T14:24:30-07:00 New Revision: f03943722ba5a9fb2a0f23eb158ad469428b8876 URL: https://github.com/llvm/llvm-project/commit/f03943722ba5a9fb2a0f23eb158ad469428b8876 DIFF: https://github.com/llvm/llvm-project/commit/f03943722ba5a9fb2a0f23eb158ad469428b8876.di

[PATCH] D136533: [clang] Fix missing diagnostic of declaration use when accessing TypeDecls through typename access

glandium added a comment. In D136533#3885302 , @mizvekov wrote: > Nonetheless, it seems libc++ uses a deprecated declaration from it's own > headers. It's the opposite of deprecated, it's (optionally) using something that is only available in newer ver

[PATCH] D136796: [llvm-objdump][Offload] Use common offload extraction method

jhuber6 created this revision. jhuber6 added reviewers: JonChesterfield, tra, yaxunl, jdoerfert, tianshilei1992. Herald added a subscriber: hiraditya. Herald added a reviewer: alexander-shaposhnikov. Herald added a reviewer: jhenderson. Herald added a reviewer: MaskRay. Herald added a project: All

[PATCH] D134453: Disambiguate type names when printing NTTP types

dblaikie added a comment. >>> So we might print it with a syntax as if the class was a simple pod type, >>> even though that might produce a completely different result if used in >>> practice. >>> I don't think we can do much better without having the actual expression >>> used. >>> >>> That m

[PATCH] D133874: [clang] Changes to produce sugared converted template arguments

mizvekov added a comment. Thanks. Reduced to: void foo(); template void bar() {} template void bar<>(); template void bar(); Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133874/new/ https://reviews.llvm.org/D133874

[clang] 7846d59 - Extend the C++03 definition of POD to include defaulted functions

Author: David Blaikie Date: 2022-10-26T22:00:49Z New Revision: 7846d590033e8d661198f4c00f56f46a4993c526 URL: https://github.com/llvm/llvm-project/commit/7846d590033e8d661198f4c00f56f46a4993c526 DIFF: https://github.com/llvm/llvm-project/commit/7846d590033e8d661198f4c00f56f46a4993c526.diff LOG:

[PATCH] D119051: Extend the C++03 definition of POD to include defaulted functions

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7846d590033e: Extend the C++03 definition of POD to include defaulted functions (authored by dblaikie). Changed prior to commit: https://reviews.l

[PATCH] D136797: [clang-tidy] Skip template ctors in modernize-use-equals-default

alexander-shaposhnikov created this revision. alexander-shaposhnikov added reviewers: gribozavr2, ymandel, LegalizeAdulthood, alexfh. alexander-shaposhnikov created this object with visibility "All Users". Herald added subscribers: carlosgalvezp, xazax.hun. Herald added a project: All. alexander-s

[PATCH] D136797: [clang-tidy] Skip template ctors in modernize-use-equals-default

ymandel accepted this revision. ymandel added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clang-tidy/modernize/UseEqualsDefaultCheck.cpp:249 unless(isVariadic()), parameterCountIs(0), +un

[clang] ec273d3 - Add a warning for not packing non-POD members in packed structs

Author: David Blaikie Date: 2022-10-26T22:18:51Z New Revision: ec273d3e3a8c3bcb2cf98f893f28bee5bf9b30af URL: https://github.com/llvm/llvm-project/commit/ec273d3e3a8c3bcb2cf98f893f28bee5bf9b30af DIFF: https://github.com/llvm/llvm-project/commit/ec273d3e3a8c3bcb2cf98f893f28bee5bf9b30af.diff LOG:

[PATCH] D118511: Add a warning for not packing non-POD members in packed structs

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGec273d3e3a8c: Add a warning for not packing non-POD members in packed structs (authored by dblaikie). Changed prior to commit: https://reviews.llv

[PATCH] D136533: [clang] Fix missing diagnostic of declaration use when accessing TypeDecls through typename access

mizvekov added a comment. In D136533#388 , @glandium wrote: > It's the opposite of deprecated, it's (optionally) using something that is > only available in newer versions of macos. Right, I mis-typed, but this is probably using the 'availability' a

[PATCH] D136568: [Clang] Support constexpr builtin ilogb

Izaron updated this revision to Diff 470962. Izaron added a comment. Add test for min/max value. Fix comment for ilog. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136568/new/ https://reviews.llvm.org/D136568 Files: clang/docs/LanguageExtension

[PATCH] D136568: [Clang] Support constexpr builtin ilogb

Izaron marked 2 inline comments as done. Izaron added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:12452 +int Ilogb; +if (APFloat::opStatus St = ilogb(F, Ilogb); !isConstantOpStatus(St)) + return false; jcranmer-intel wrote: > Izaron w

[PATCH] D133874: [clang] Changes to produce sugared converted template arguments

mizvekov added a comment. This is surprisingly not from a bug in this patch. So `getCanonicalTemplateArgument` is broken for the types of declarations. This bug was supposedly fixed by zygoloid (https://github.com/llvm/llvm-project/commit/849c60541b630ddf8cabf9179fa771b3f4207) But then was reve

[PATCH] D134902: [clang] Implement -fstrict-flex-arrays=3

void added a comment. Quick ping to @kees and @serge-sans-paille for any comments. :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134902/new/ https://reviews.llvm.org/D134902 ___ cfe-commits mailing li

[clang] 0d7eba1 - [Driver] Allow target override containing . in executable name

Author: Dan McGregor Date: 2022-10-26T16:52:32-07:00 New Revision: 0d7eba1aeed853798bd8012f786c305e83a97b67 URL: https://github.com/llvm/llvm-project/commit/0d7eba1aeed853798bd8012f786c305e83a97b67 DIFF: https://github.com/llvm/llvm-project/commit/0d7eba1aeed853798bd8012f786c305e83a97b67.diff

[PATCH] D135284: [Driver] allow target override containing . in executable name

This revision was automatically updated to reflect the committed changes. Closed by commit rG0d7eba1aeed8: [Driver] Allow target override containing . in executable name (authored by dankm, committed by MaskRay). Changed prior to commit: https://reviews.llvm.org/D135284?vs=470918&id=470970#toc

[PATCH] D134902: [clang] Implement -fstrict-flex-arrays=3

kees accepted this revision. kees added a comment. The self-tests all look correct to me, so I expect it is working how I'd expect. I haven't had a chance to do kernel builds with this yet, but I'm hoping to make time soon. I'd say if others are happy, let's land it, and if anything unexpected

[PATCH] D133874: [clang] Changes to produce sugared converted template arguments

mizvekov added a comment. I think there is a high chance that the bug that caused richard's patch to be reverted, was actually fixed afterwards by https://github.com/llvm/llvm-project/commit/acb767f5cda59302aa9100afcf6133d66779d42c So I will try to land that one again, and then I will try to la

[PATCH] D136803: [clang] Include the type of a pointer or reference non-type template parameter in its notion of template argument identity.

mizvekov created this revision. Herald added a project: All. mizvekov requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. We already did this for all the other kinds of non-type template argument. We're still missing the type from the mangling,

[PATCH] D133874: [clang] Changes to produce sugared converted template arguments

glandium added a comment. I can confirm that applying the following: diff --git a/clang/lib/AST/ASTContext.cpp b/clang/lib/AST/ASTContext.cpp index a8585a6d84ad..f07c40cb6c5d 100644 --- a/clang/lib/AST/ASTContext.cpp +++ b/clang/lib/AST/ASTContext.cpp @@ -6774,7 +6774,7 @@ ASTContext::g

[PATCH] D133874: [clang] Changes to produce sugared converted template arguments

mizvekov added a comment. Thanks for confirming. I have pushed a patch at: https://reviews.llvm.org/D136803 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133874/new/ https://reviews.llvm.org/D133874 ___

[PATCH] D136807: [clang][Sema] Fix a clang crash with btf_type_tag

yonghong-song created this revision. yonghong-song added reviewers: aaron.ballman, dblaikie. yonghong-song added a project: clang. Herald added a project: All. yonghong-song requested review of this revision. Herald added a subscriber: cfe-commits. For the following program, $ cat t.c struct

[PATCH] D135488: [codegen] Display stack layouts in console

paulkirth updated this revision to Diff 470983. paulkirth retitled this revision from "[codegen][WIP] Display stack layouts in console" to "[codegen] Display stack layouts in console". paulkirth edited the summary of this revision. paulkirth added a comment. Rebase and update description Reposi

[PATCH] D135488: [codegen] Display stack layouts in console

paulkirth updated this revision to Diff 470984. paulkirth added a comment. Fix pass name in a comment block Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135488/new/ https://reviews.llvm.org/D135488 Files: llvm/include/llvm/CodeGen/Passes.h ll

[PATCH] D134128: [P0857R0 Part B] Resubmit an implemention for constrained template template parameters

h-vetinari added inline comments. Comment at: clang/docs/ReleaseNotes.rst:554 +- Implemented `P0857R0 `_, + which words for constrained lambdas and constrained template *template-parameter*\s. ---

[PATCH] D127462: [Clang] Begin implementing Plan 9 C extensions

ksaunders added a comment. Thanks for your response. I am working on an RFC now which addresses your feedback and questions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127462/new/ https://reviews.llvm.org/D127462 __

<    1   2   3   >