[PATCH] D135729: [clang][macho] Add support for -darwin-target-variant-sdk-version in cc1as

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd11b9fa3bfb9: [clang][macho] Add support for -darwin-target-variant-sdk-version in cc1as (authored by drodriguez). Changed prior to commit: https:

[clang] 91b3823 - [clang][Sema] Use size of char in bits for void types

Author: Bill Wendling Date: 2022-10-14T14:46:19-07:00 New Revision: 91b3823bd000b1a6ffde96a6363098f59307317a URL: https://github.com/llvm/llvm-project/commit/91b3823bd000b1a6ffde96a6363098f59307317a DIFF: https://github.com/llvm/llvm-project/commit/91b3823bd000b1a6ffde96a6363098f59307317a.diff

[PATCH] D135989: [clang][Sema] Use size of char for void types

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG91b3823bd000: [clang][Sema] Use size of char in bits for void types (authored by void). Changed prior to commit: https://reviews.llvm.org/D135989?

[PATCH] D135989: [clang][Sema] Use size of char for void types

void added a comment. In D135989#3859763 , @nickdesaulniers wrote: > LGTM; please consider appending to the commit message something along the > lines of "operations on the result of getTypeSize() are in bits, not bytes. > Using 1 as the value for voi

[PATCH] D129531: [clang][C++20] P0960R3: Allow initializing aggregates from a parenthesized list of values

ayzhao updated this revision to Diff 467932. ayzhao added a comment. implement serialization stuff Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129531/new/ https://reviews.llvm.org/D129531 Files: clang/include/clang-c/Index.h clang/include/cl

[PATCH] D131858: [clang] Track the templated entity in type substitution.

mizvekov added a comment. I pushed some late changes: - Implement this new scheme uniformly across all template parameter kinds. Before we were doing only type parameters, now we are doing non-type and template template parameters. While the diff is not very small, it's more of the same stuff.

[PATCH] D134371: [clang-doc] Add typedef/using information.

This revision was automatically updated to reflect the committed changes. Closed by commit rG21fb70c6ab3b: [clang-doc] Add typedef/using information. (authored by brettw). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134371/new/ https://reviews.llv

[clang-tools-extra] 21fb70c - [clang-doc] Add typedef/using information.

Author: Brett Wilson Date: 2022-10-14T14:59:29-07:00 New Revision: 21fb70c6ab3b25fe8f5f8384714a9a359b4b5a54 URL: https://github.com/llvm/llvm-project/commit/21fb70c6ab3b25fe8f5f8384714a9a359b4b5a54 DIFF: https://github.com/llvm/llvm-project/commit/21fb70c6ab3b25fe8f5f8384714a9a359b4b5a54.diff

[PATCH] D129531: [clang][C++20] P0960R3: Allow initializing aggregates from a parenthesized list of values

ayzhao updated this revision to Diff 467940. ayzhao added a comment. implement StmtProfiler and Sema::canThrow Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129531/new/ https://reviews.llvm.org/D129531 Files: clang/include/clang-c/Index.h clan

[PATCH] D135110: [NFC] [HLSL] Move common metadata to LLVMFrontend

mstorsjo added a comment. I don't quite know why, but it seems like this new library breaks tests of llvm-config; if I start out with an empty build directory and run `ninja check-llvm` (or `ninja llvm-test-depends`), then this library doesn't get built, and llvm-config prints `llvm-config: err

[PATCH] D135920: [clang][Sema] Use correct array size for diagnostic

void updated this revision to Diff 467941. void added a comment. Update test to use a smaller index. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135920/new/ https://reviews.llvm.org/D135920 Files: clang/lib/Sema/SemaChecking.cpp clang/test/S

[PATCH] D135340: [PGO] Make emitted symbols hidden

zequanwu added a comment. This causing instrprof-darwin-dead-strip.c failed on mac. FAIL: Profile-x86_64 :: instrprof-darwin-dead-strip.c (1 of 238) TEST 'Profile-x86_64 :: instrprof-darwin-dead-strip.c' FAILED Script: -- : 'RUN: at line 4';

[clang] 82035ec - Revert "[PGO] Make emitted symbols hidden"

Author: Zequan Wu Date: 2022-10-14T15:23:26-07:00 New Revision: 82035ecf683067c7c7b9f344bb7ca28b4717 URL: https://github.com/llvm/llvm-project/commit/82035ecf683067c7c7b9f344bb7ca28b4717 DIFF: https://github.com/llvm/llvm-project/commit/82035ecf683067c7c7b9f344bb7ca28b4717.diff LOG

[PATCH] D135097: Remove redundant option '-menable-unsafe-fp-math'.

saugustine added a comment. The newly added test func-attr.c fails when run in opt mode. If it is expected to run only at a certain optimization level, it should probably include that level in the test itself. I don't think it seriously blocks anything, but would be good to fix. /usr/local/g

[PATCH] D135097: Remove redundant option '-menable-unsafe-fp-math'.

jrtc27 added a comment. It also will fail if the configured default target triple is one where the default program address space is non-zero, and maybe other things (do any targets do pre-IR name mangling for C?) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[PATCH] D135919: [Clang] Set thread_local Itanium ABI guard variables before calling constructors.

rjmccall added a comment. In D135919#3859520 , @hubert.reinterpretcast wrote: > In D135919#3859491 , @tahonermann > wrote: > >>> the case from https://github.com/llvm/llvm-project/issues/57828 is not for >>> a

[PATCH] D135832: Do not append terminating NUL to the string with embedded GPU binary.

tra updated this revision to Diff 467957. tra added a comment. Reworked string/array generation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135832/new/ https://reviews.llvm.org/D135832 Files: clang/lib/CodeGen/CGCUDANV.cpp clang/test/CodeGe

[PATCH] D135832: Do not append terminating NUL to the string with embedded GPU binary.

tra added inline comments. Comment at: clang/lib/CodeGen/CGCUDANV.cpp:95 llvm::ConstantInt::get(SizeTy, 0)}; -auto ConstStr = CGM.GetAddrOfConstantCString(Str, Name.c_str()); +auto ConstStr = CGM.GetAddrOfConstantCString(Str, Name.c_str(),

[PATCH] D135919: [Clang] Set thread_local Itanium ABI guard variables before calling constructors.

rjmccall added a comment. Please add a comment something like this: The semantics of dynamic initialization of thread-local variables depends subtly on whether they are block-scope. The initialization of block-scope thread locals can be aborted with an exception and later retried (), and recur

[PATCH] D130324: [ODRHash] Hash `ObjCProtocolDecl` and diagnose discovered mismatches.

bruno accepted this revision. bruno added a comment. Great to see both this and D130325 landing, LGTM too. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130324/new/ https://reviews.llvm.org/D130324 _

[PATCH] D136007: [clang][modules][deps] System module maps might not be affecting

jansvoboda11 created this revision. Herald added a subscriber: ributzka. Herald added a project: All. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The dependency scanner relies on the module map filtering logic in `ASTWriter

[PATCH] D127695: [clang] Implement Template Specialization Resugaring

rjmccall added a comment. What is this work about? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127695/new/ https://reviews.llvm.org/D127695 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https

[PATCH] D85802: [clang] Add -fc++-abi= flag for specifying which C++ ABI to use

dblaikie added a comment. In D85802#3859540 , @leonardchan wrote: >> Naive question, but what does it mean to target Fuschia but be >> gnu-compatible? (how would that be different than using whatever gnu OS >> (linux, etc) the other code was built for) >

[PATCH] D135707: [clang-format] Correctly annotate star/amp in function pointer params

owenpan added a comment. In D135707#3858097 , @MyDeveloperDay wrote: > Thanks @rymiel its great to have another active contributor, especially one > who seems so focused on github issues. Really appreciate your recent > contributions. Can we start incl

[PATCH] D135871: [clang-format][NFC] Handle language specific stuff at the top...

owenpan added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:3121 + return 1; +if (Right.is(tok::period)) + return 500; Otherwise, it wouldn't be NFC. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://rev

[PATCH] D135926: [clang] Fix crash with -funique-internal-linkage-names

tmsriram accepted this revision. tmsriram added a comment. This revision is now accepted and ready to land. LGTM, thanks for fixing this! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135926/new/ https://reviews.llvm.org/D135926 __

[PATCH] D127695: [clang] Implement Template Specialization Resugaring

mizvekov added a comment. In D127695#3860237 , @rjmccall wrote: > What is this work about? I have written more about it in this discourse thread: https://discourse.llvm.org/t/rfc-improving-diagnostics-with-template-specialization-resugaring/64294 Repo

[PATCH] D127695: [clang] Implement Template Specialization Resugaring

rjmccall added a comment. I see, thank you. I know you've marked this a WIP, but it's always good to describe these things in the patch description; that's what it's for. This is quite exciting! Thank you for looking into this. I think you could usefully be much more incremental here. Obvious

[PATCH] D135013: [clang][Interp] Array initialization via ImplicitValueInitExpr

shafik added a comment. I found a way to get `ImplictValueInitExpr` for a record: https://godbolt.org/z/Eqf9Gz1G4 I am not sure if we can achieve the same in C++ b/c value init of a class break down to default init or zero init. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135013/new

[PATCH] D133375: [CMake] Remove CLANG_DEFAULT_STD_C/CLANG_DEFAULT_STD_CXX

mgorny accepted this revision. mgorny added a comment. This revision is now accepted and ready to land. Thanks for doing this. For the record, Gentoo didn't need to use this for a long time now, so there's no backwards compatibility concern here. Repository: rG LLVM Github Monorepo CHANGES S

[PATCH] D135013: [clang][Interp] Array initialization via ImplicitValueInitExpr

tbaeder added a comment. In D135013#3860317 , @shafik wrote: > I found a way to get `ImplictValueInitExpr` for a record: > https://godbolt.org/z/Eqf9Gz1G4 > > I am not sure if we can achieve the same in C++ b/c value init of a class > break down to defa

<    1   2   3