[clang] 74e4f77 - [Lex] Simplify and cleanup the updateConsecutiveMacroArgTokens implementation.

Author: Haojian Wu Date: 2022-10-07T09:16:08+02:00 New Revision: 74e4f778cf16cbf7163b5c6de6027a43f5e9169f URL: https://github.com/llvm/llvm-project/commit/74e4f778cf16cbf7163b5c6de6027a43f5e9169f DIFF: https://github.com/llvm/llvm-project/commit/74e4f778cf16cbf7163b5c6de6027a43f5e9169f.diff LO

[PATCH] D134942: [Lex] Simplify and cleanup the updateConsecutiveMacroArgTokens implementation.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. hokein marked an inline comment as done. Closed by commit rG74e4f778cf16: [Lex] Simplify and cleanup the updateConsecutiveMacroArgTokens implementation. (authored by ho

[PATCH] D135132: [SourceManager] Improve getFileIDLocal.

hokein updated this revision to Diff 465988. hokein marked an inline comment as done. hokein added a comment. update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135132/new/ https://reviews.llvm.org/D135132 Files: clang/lib/Basic/SourceManager.

[PATCH] D135132: [SourceManager] Improve getFileIDLocal.

hokein added inline comments. Comment at: clang/lib/Basic/SourceManager.cpp:797 - LocalSLocEntryTable[LastFileIDLookup.ID].getOffset() < SLocOffset) { -// Neither loc prunes our search. -I = LocalSLocEntryTable.end(); nickdesaulniers wrote: > nickdes

[clang] a6a0d9e - [SourceManager] Improve getFileIDLocal.

Author: Haojian Wu Date: 2022-10-07T09:37:04+02:00 New Revision: a6a0d9ecd5d744316e699fa78a053376bb659dd1 URL: https://github.com/llvm/llvm-project/commit/a6a0d9ecd5d744316e699fa78a053376bb659dd1 DIFF: https://github.com/llvm/llvm-project/commit/a6a0d9ecd5d744316e699fa78a053376bb659dd1.diff LO

[PATCH] D135132: [SourceManager] Improve getFileIDLocal.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa6a0d9ecd5d7: [SourceManager] Improve getFileIDLocal. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https

[PATCH] D135429: [HLSL] [DirectX backend] Move generateGlobalCtorDtorCalls into DirectX backend.

python3kgae created this revision. python3kgae added reviewers: efriedma, pow2clk, beanz, bogner. Herald added subscribers: Anastasia, hiraditya. Herald added a project: All. python3kgae requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, c

[PATCH] D129443: [clang-format] Add option for aligning requires clause body

rymiel added a comment. It wasn't an accidental regression, though, it was a conscious formatting decision (maybe ask @HazardyKnusperkeks for more). Similar to how lambdas can be formatted aligned to the introducer, i think this option does make sense. Repository: rG LLVM Github Monorepo CH

[PATCH] D135169: [LLDB] Fix printing a static bool struct member when using "image lookup -t"

This revision was automatically updated to reflect the committed changes. Closed by commit rG02c1c939486f: [LLDB] Fix printing a static bool struct member when using "image lookup -t" (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.l

[PATCH] D134902: [clang] Implement -fstrict-flex-arrays=3

void marked an inline comment as done. void added inline comments. Comment at: clang/test/CodeGen/bounds-checking-fam.c:2 // REQUIRES: x86-registered-target -// RUN: %clang_cc1 -emit-llvm -triple x86_64 -fstrict-flex-arrays=0 -fsanitize=array-bounds%s -o - | FileCheck %

[PATCH] D135170: [LLDB] Fix crash when printing a struct with a static signed char member

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5a9e21305803: [LLDB] Fix crash when printing a struct with a static signed char member (authored by DavidSpickett). Repository: rG LLVM Github Mon

[clang] 5a9e213 - [LLDB] Fix crash when printing a struct with a static signed char member

Author: David Spickett Date: 2022-10-07T09:11:15Z New Revision: 5a9e21305803336dc359f72014849845b1a7e173 URL: https://github.com/llvm/llvm-project/commit/5a9e21305803336dc359f72014849845b1a7e173 DIFF: https://github.com/llvm/llvm-project/commit/5a9e21305803336dc359f72014849845b1a7e173.diff LOG

[PATCH] D134902: [clang] Implement -fstrict-flex-arrays=3

void updated this revision to Diff 466011. void added a comment. Herald added subscribers: steakhal, martong. Herald added a reviewer: NoQ. Update comments to reflect reality. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134902/new/ https://review

[PATCH] D135257: [clangd][Tweak] Make sure enclosing function doesnt have invalid children

kadircet added a comment. I wasn't claiming that there are legitimate reasons for having null children, I completely agree with your verdict on this one. The only one I can think of is cases like this, i.e. you don't want to perform some analysis if function body has invalid code in it. but i t

[PATCH] D135257: [clangd][Tweak] Make sure enclosing function doesnt have invalid children

ilya-biryukov added a comment. To be clear: landing this change seems fine, I was not trying to block it, sorry if it seemed that way. I'm just trying to understand whether it would also make sense to change the defaults. I believe we are on the same page here, it's just a matter of booking som

[PATCH] D129443: [clang-format] Add option for aligning requires clause body

HazardyKnusperkeks added a comment. In D129443#3841248 , @owenpan wrote: > Is this option really required? Can we just fix the regression as reported in > https://github.com/llvm/llvm-project/issues/56283? It seems that we haven't > followed the policy

[PATCH] D135422: Fix clang-format misattributing preprocessor directives to macros

HazardyKnusperkeks added a comment. Please add a regression test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135422/new/ https://reviews.llvm.org/D135422 ___ cfe-commits mailing list cfe-commits@lists

[PATCH] D135433: [clang][Interp] Implement while and do-while loops

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane, shafik, tahonermann. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. I was wondering whether it is somehow possible to g

[clang-tools-extra] e09aa0d - [clangd][Tweak] Make sure enclosing function doesnt have invalid children

Author: Kadir Cetinkaya Date: 2022-10-07T12:00:22+02:00 New Revision: e09aa0d192e0ae240c55aaf8205e8320d49f9bdb URL: https://github.com/llvm/llvm-project/commit/e09aa0d192e0ae240c55aaf8205e8320d49f9bdb DIFF: https://github.com/llvm/llvm-project/commit/e09aa0d192e0ae240c55aaf8205e8320d49f9bdb.dif

[PATCH] D135257: [clangd][Tweak] Make sure enclosing function doesnt have invalid children

This revision was automatically updated to reflect the committed changes. Closed by commit rGe09aa0d192e0: [clangd][Tweak] Make sure enclosing function doesnt have invalid children (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D135433: [clang][Interp] Implement while and do-while loops

tbaeder updated this revision to Diff 466022. tbaeder added a comment. Add `break` and `continue` support as well. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135433/new/ https://reviews.llvm.org/D135433 Files: clang/lib/AST/Interp/ByteCodeStmtGen.cpp clang/lib/AST/Interp/ByteCod

[PATCH] D135154: Keep inherited dllimport/export attrs for explicit specialization of template class member functions

hans added a comment. Looking at the Chromium code some more, the case of trying to delete a specialization of a dllexport class template member seems suspect. Since the error also matches MSVC I think we should keep that behavior, but I'll add a release note about it. Repository: rG LLVM G

[PATCH] D135154: Keep inherited dllimport/export attrs for explicit specialization of template class member functions

This revision was automatically updated to reflect the committed changes. Closed by commit rGc9b771b9fc2f: Keep inherited dllimport/export attrs for explicit specialization of class… (authored by hans). Changed prior to commit: https://reviews.llvm.org/D135154?vs=464984&id=466023#toc Repositor

[clang] c9b771b - Keep inherited dllimport/export attrs for explicit specialization of class template member functions

Author: Hans Wennborg Date: 2022-10-07T12:24:19+02:00 New Revision: c9b771b9fc2f17cccd9ccbf8f1d52e2642679b8a URL: https://github.com/llvm/llvm-project/commit/c9b771b9fc2f17cccd9ccbf8f1d52e2642679b8a DIFF: https://github.com/llvm/llvm-project/commit/c9b771b9fc2f17cccd9ccbf8f1d52e2642679b8a.diff

[PATCH] D134859: [clang][Interp] Implement basic support for floating point values

tbaeder updated this revision to Diff 466027. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134859/new/ https://reviews.llvm.org/D134859 Files: clang/lib/AST/CMakeLists.txt clang/lib/AST/Interp/Boolean.h clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/lib/AST/Interp/ByteCodeExprGe

[PATCH] D134859: [clang][Interp] Implement basic support for floating point values

tbaeder updated this revision to Diff 466031. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134859/new/ https://reviews.llvm.org/D134859 Files: clang/lib/AST/CMakeLists.txt clang/lib/AST/Interp/Boolean.h clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/lib/AST/Interp/ByteCodeExprGe

[PATCH] D135439: Keep configuration file search directories in ExpansionContext. NFC

sepavloff created this revision. sepavloff added reviewers: MaskRay, mgorny. Herald added subscribers: StephenFan, hiraditya. Herald added a project: All. sepavloff requested review of this revision. Herald added projects: clang, LLVM. Herald added a subscriber: llvm-commits. Class ExpansionContex

[PATCH] D135440: [SourceManager] Speedup getFileIDLocal with a separate Offset Table.

hokein created this revision. hokein added reviewers: sammccall, nickdesaulniers. Herald added a subscriber: kadircet. Herald added a project: All. hokein requested review of this revision. Herald added a subscriber: ilya-biryukov. Herald added a project: clang. This patch introduces a separate Of

[PATCH] D135367: [clang-tidy] Dump effective diagnostics level in YAML output

DmitryPolukhin updated this revision to Diff 466037. DmitryPolukhin added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135367/new/ https://reviews.llvm.org/D135367 Files: clang-tools-extra/clang-tidy/ClangTidyDiagnosticConsume

[PATCH] D135361: [clang][Interp] Implement bitwise Or operations

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135361/new/ https://reviews.llvm.org/D135361 ___ cfe-commits mailing list cfe-commi

[PATCH] D135392: Use PoisonValue in vector BIs [NFC]

nlopes accepted this revision. nlopes added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135392/new/ https://reviews.llvm.org/D135392 ___

[PATCH] D129755: Thread safety analysis: Support copy-elided production of scoped capabilities through arbitrary calls

aaron.ballman added inline comments. Comment at: clang/lib/Analysis/ThreadSafety.cpp:1789 + auto inserted = ConstructedObjects.insert({Exp, Placeholder.first}); + assert(inserted.second && "Are we visiting the same expression again?"); + if (isa(Exp)) -

[clang] 14e2592 - [clang][CodeGen] Use poison instead of undef as placeholder in ARM builtins [NFC]

Author: Manuel Brito Date: 2022-10-07T12:50:59+01:00 New Revision: 14e2592ff6112d1869ba1533d058822200162bf1 URL: https://github.com/llvm/llvm-project/commit/14e2592ff6112d1869ba1533d058822200162bf1 DIFF: https://github.com/llvm/llvm-project/commit/14e2592ff6112d1869ba1533d058822200162bf1.diff

[PATCH] D135392: Use PoisonValue in vector BIs [NFC]

This revision was automatically updated to reflect the committed changes. Closed by commit rG14e2592ff611: [clang][CodeGen] Use poison instead of undef as placeholder in ARM builtins… (authored by ManuelJBrito, committed by nlopes). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 4627cef - [OpenMP][OMPIRBuilder] Migrate emitOffloadingArraysArgument from clang

Author: Jan Sjodin Date: 2022-10-07T07:03:03-05:00 New Revision: 4627cef1134f99f3802a5ebfe26188d2c66da22f URL: https://github.com/llvm/llvm-project/commit/4627cef1134f99f3802a5ebfe26188d2c66da22f DIFF: https://github.com/llvm/llvm-project/commit/4627cef1134f99f3802a5ebfe26188d2c66da22f.diff LO

[PATCH] D134662: [OpenMPIRBuilder] Migrate emitOffloadingArraysArgument from clang

This revision was automatically updated to reflect the committed changes. Closed by commit rG4627cef1134f: [OpenMP][OMPIRBuilder] Migrate emitOffloadingArraysArgument from clang (authored by jsjodin). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Git

[PATCH] D135397: [clang][dataflow] Add support for a Top value in boolean formulas.

ymandel added a comment. Thanks for the thorough reviews! Agreed on all points, and will address. Comment at: clang/include/clang/Analysis/FlowSensitive/DataflowAnalysisContext.h:157 + TopValue &createTop() { +return takeOwnership(std::make_unique()); + } ---

[clang] d779356 - [SourceManager] Fix the incorrect counting stats in getFileIDLoaded.

Author: Haojian Wu Date: 2022-10-07T14:24:31+02:00 New Revision: d779356043a895280d0880551ef33d663fe36c7e URL: https://github.com/llvm/llvm-project/commit/d779356043a895280d0880551ef33d663fe36c7e DIFF: https://github.com/llvm/llvm-project/commit/d779356043a895280d0880551ef33d663fe36c7e.diff LO

[clang] a4afa2b - Revert "Thread safety analysis: Support copy-elided production of scoped capabilities through arbitrary calls"

Author: Hans Wennborg Date: 2022-10-07T14:30:36+02:00 New Revision: a4afa2bde6f4db215ddd3267a8d11c04367812e5 URL: https://github.com/llvm/llvm-project/commit/a4afa2bde6f4db215ddd3267a8d11c04367812e5 DIFF: https://github.com/llvm/llvm-project/commit/a4afa2bde6f4db215ddd3267a8d11c04367812e5.diff

[PATCH] D129755: Thread safety analysis: Support copy-elided production of scoped capabilities through arbitrary calls

hans added a comment. We're hitting a false positive in grpc after this: > ../../third_party/grpc/src/src/core/lib/gprpp/ref_counted_ptr.h:335:31: error: calling function 'TlsSessionKeyLoggerCache' requires holding mutex 'g_tls_session_key_log_cache_mu' exclusively [-Werror,-Wthread-safety-an

[PATCH] D135362: [clang] Make variables of undeduced types to have dependent alignment

This revision was automatically updated to reflect the committed changes. Closed by commit rG5a42c90b778c: [clang] Make variables of undeduced types to have dependent alignment (authored by ArcsinX). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1353

[clang] 5a42c90 - [clang] Make variables of undeduced types to have dependent alignment

Author: Aleksandr Platonov Date: 2022-10-07T20:40:03+08:00 New Revision: 5a42c90b778c65238a54f0f1d8c8d6b35e2f6007 URL: https://github.com/llvm/llvm-project/commit/5a42c90b778c65238a54f0f1d8c8d6b35e2f6007 DIFF: https://github.com/llvm/llvm-project/commit/5a42c90b778c65238a54f0f1d8c8d6b35e2f6007.

[PATCH] D129755: Thread safety analysis: Support copy-elided production of scoped capabilities through arbitrary calls

aaron.ballman added a comment. In D129755#3842729 , @hans wrote: > We're hitting a false positive in grpc after this: > > > ../../third_party/grpc/src/src/core/lib/gprpp/ref_counted_ptr.h:335:31: > error: calling function 'TlsSessionKeyLoggerCache' req

[PATCH] D134813: Properly print unnamed TagDecl objects in diagnostics

aaron.ballman updated this revision to Diff 466052. aaron.ballman added a comment. Herald added a subscriber: kadircet. Herald added a project: clang-tools-extra. Updated to fix the clangd unit test breakage. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134813/new/ https://reviews.llvm

[PATCH] D129755: Thread safety analysis: Support copy-elided production of scoped capabilities through arbitrary calls

hans added a comment. We also hit a different case: https://bugs.chromium.org/p/chromium/issues/detail?id=1372394#c6 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129755/new/ https://reviews.llvm.org/D129755 __

[clang] 853df5e - [Concepts] Fix friend duplicate detection when referencing containing Record

Author: Erich Keane Date: 2022-10-07T06:14:11-07:00 New Revision: 853df5e1d63684cbf3bf3da63d3e467003262282 URL: https://github.com/llvm/llvm-project/commit/853df5e1d63684cbf3bf3da63d3e467003262282 DIFF: https://github.com/llvm/llvm-project/commit/853df5e1d63684cbf3bf3da63d3e467003262282.diff L

[PATCH] D134128: Resubmit an implemention for constrained template template parameters [P0857R0 Part B]

lime updated this revision to Diff 466056. lime added a comment. > The changes in Sema.h and the changes of CalculateTemplateDepthForConstraints I think it might be fine now. The above changes are related to `NormalizationCache`. This cache used to take `NamedDecl` as its key. However, as const

[PATCH] D135384: Enable the use of the -pg flag

cebowleratibm added inline comments. Comment at: clang/test/CodeGen/mcount-aix.c:2 +// RUN: %clang_cc1 -pg -no-opaque-pointers -triple powerpc-ibm-aix7.2.0.0 -S -emit-llvm %s -o - | FileCheck %s +// RUN: %clang_cc1 -pg -no-opaque-pointers -triple powerpc64-ibm-aix7.2.0.0 -S -em

[PATCH] D135370: Narrow inline namespace filtration for unqualified friend declarations

troyj updated this revision to Diff 466072. troyj added a comment. Added more diff context as requested. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135370/new/ https://reviews.llvm.org/D135370 Files: clang/lib/Sema/SemaTemplateInstantiateDecl

[clang] bb46022 - [CMake] Small fix to HLSL header install paths

Author: Chris Bieneman Date: 2022-10-07T09:45:11-05:00 New Revision: bb46022abe78497d3d5a8c6a6cf8599f7ec0d2ec URL: https://github.com/llvm/llvm-project/commit/bb46022abe78497d3d5a8c6a6cf8599f7ec0d2ec DIFF: https://github.com/llvm/llvm-project/commit/bb46022abe78497d3d5a8c6a6cf8599f7ec0d2ec.diff

[PATCH] D135269: [AMDGPU] Disable bool range metadata to workaround backend issue

This revision was automatically updated to reflect the committed changes. Closed by commit rG107ee2613063: [AMDGPU] Disable bool range metadata to workaround backend issue (authored by yaxunl). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https

[clang] 107ee26 - [AMDGPU] Disable bool range metadata to workaround backend issue

Author: Yaxun (Sam) Liu Date: 2022-10-07T10:46:04-04:00 New Revision: 107ee2613063183cb643cef97f0fad403508c9f0 URL: https://github.com/llvm/llvm-project/commit/107ee2613063183cb643cef97f0fad403508c9f0 DIFF: https://github.com/llvm/llvm-project/commit/107ee2613063183cb643cef97f0fad403508c9f0.dif

[clang] 3b652fc - [analyzer] Fix static code analysis concerns

Author: Soumi Manna Date: 2022-10-07T16:58:37+02:00 New Revision: 3b652fc6d6447aae91c9e8c35815eed19245757d URL: https://github.com/llvm/llvm-project/commit/3b652fc6d6447aae91c9e8c35815eed19245757d DIFF: https://github.com/llvm/llvm-project/commit/3b652fc6d6447aae91c9e8c35815eed19245757d.diff L

[PATCH] D135290: [analyzer] Fix static code analysis concerns

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3b652fc6d644: [analyzer] Fix static code analysis concerns (authored by Manna, committed by isuckatcs). Herald added a project: clang. Herald added a

[PATCH] D129689: [limits.h] USHRT_MAX fix for 16 bit architectures

aaron.ballman added a comment. This seems to have fallen through the cracks -- @SebastianPerta are you planning to update the patch, or would you be okay if I commandeered it? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129689/new/ https://reviews.llvm.org/D129689 __

[PATCH] D135236: [Clang][OpenMP] Add one missing form of atomic compare capture

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135236/new/ https://reviews.llvm.org/D135236 ___

[clang] eb26baf - Fix test bool-range.cu

Author: Yaxun (Sam) Liu Date: 2022-10-07T11:17:28-04:00 New Revision: eb26baf4ade6c1e73eb14e8a89d5771e57bc61a3 URL: https://github.com/llvm/llvm-project/commit/eb26baf4ade6c1e73eb14e8a89d5771e57bc61a3 DIFF: https://github.com/llvm/llvm-project/commit/eb26baf4ade6c1e73eb14e8a89d5771e57bc61a3.dif

[PATCH] D135367: [clang-tidy] Dump effective diagnostics level in YAML output

njames93 accepted this revision. njames93 added a comment. This revision is now accepted and ready to land. LGTM, just maybe include a test case where a warning from a clang-tidy check is promoted to an error as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://re

[PATCH] D135341: [clang] adds `__reference_constructs_from_temporary` and `__reference_converts_from_temporary`

cjdb updated this revision to Diff 466088. cjdb added a comment. Gets `__reference_constructs_from_temporary` correct. Still WIP for the latter. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135341/new/ https://reviews.llvm.org/D135341 Files: cl

[PATCH] D135199: [OpenMP][C++] Allow #pragma omp simd in constexpr functions

aaron.ballman added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:8274-8279 // Only if a local variable was declared in the function currently being // evaluated, do we expect to be able to find its value in the current // frame. (Otherwise it was lik

[PATCH] D135099: [C2x] Implement support for nullptr and nullptr_t

aaron.ballman added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135099/new/ https://reviews.llvm.org/D135099 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D135099: [C2x] Implement support for nullptr and nullptr_t

erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land. Happy with this, thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135099/new/ https://reviews.llvm.org/D135099 ___ cfe-commit

[PATCH] D129755: Thread safety analysis: Support copy-elided production of scoped capabilities through arbitrary calls

gulfem added a comment. We also started seeing `-Wthread-safety-precise` error in our Fuchsia code. https://luci-milo.appspot.com/ui/p/fuchsia/builders/ci/clang_toolchain.ci.core.x64-release/b8800959115965408001/overview I'm trying to verify with our team whether it is a false positive, but I jus

[PATCH] D129755: Thread safety analysis: Support copy-elided production of scoped capabilities through arbitrary calls

aaronpuchert added a comment. In D129755#3842729 , @hans wrote: > We're hitting a false positive in grpc after this: > > > ../../third_party/grpc/src/src/core/lib/gprpp/ref_counted_ptr.h:335:31: > error: calling function 'TlsSessionKeyLoggerCache' requ

[PATCH] D135461: [LLDB] Fix crash when printing a struct with a static wchar_t member

aeubanks created this revision. aeubanks added a reviewer: DavidSpickett. Herald added a project: All. aeubanks requested review of this revision. Herald added projects: clang, LLDB. Herald added subscribers: lldb-commits, cfe-commits. Similar to D135170 . Repos

[PATCH] D129755: Thread safety analysis: Support copy-elided production of scoped capabilities through arbitrary calls

aaronpuchert added a comment. In D129755#3843144 , @gulfem wrote: > We also started seeing `-Wthread-safety-precise` error in our Fuchsia code. > https://luci-milo.appspot.com/ui/p/fuchsia/builders/ci/clang_toolchain.ci.core.x64-release/b8800959115965408

[PATCH] D135366: [clang][Interp] Implement String- and CharacterLiterals

aaron.ballman added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:446 + if (Optional T = classify(LitType)) { +APInt Val(getIntWidth(LitType), E->getValue()); +return this->emitConst(*T, 0, Val, E); Should this be concerned about

[PATCH] D135466: [clang-format] Add support to remove unnecessary semicolons after function definition

MyDeveloperDay created this revision. MyDeveloperDay added reviewers: HazardyKnusperkeks, owenpan, curdeius, rymiel, Eugene.Zelenko. MyDeveloperDay added projects: clang, clang-format. Herald added a project: All. MyDeveloperDay requested review of this revision. Fixes: #58217 This change is to

[PATCH] D133668: [HLSL] Use _BitInt(16) for int16_t to avoid promote to int.

python3kgae added a comment. Hi, @rjmccall and @efriedma, Could you take a look at this PR? Or should I find someone else to review it? Thanks Xiang Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133668/new/ https://reviews.llvm.org/D133668 __

[PATCH] D129755: Thread safety analysis: Support copy-elided production of scoped capabilities through arbitrary calls

aaronpuchert planned changes to this revision. aaronpuchert added a comment. In D129755#3843206 , @aaronpuchert wrote: > Presumably `Cursor` is some kind of alias to `VmoCursor`, as we don't look at > base destructors yet. Since the code is not easily s

[PATCH] D129755: Thread safety analysis: Support copy-elided production of scoped capabilities through arbitrary calls

gulfem added a comment. In D129755#3843206 , @aaronpuchert wrote: > In D129755#3843144 , @gulfem wrote: > >> We also started seeing `-Wthread-safety-precise` error in our Fuchsia code. >> https://luci-milo.appsp

[PATCH] D135091: Create storage for the `_cmd` argument to the helper function for generated getters/setters of `direct` Objective-C properties.

mwyman added inline comments. Comment at: clang/lib/CodeGen/CGObjC.cpp:1125 +llvm::Type *selType = CGF.ConvertType(CGF.getContext().getObjCSelType()); +return llvm::UndefValue::get(selType); + } nlopes wrote: > Please consider using PoisonValue here inst

[PATCH] D135245: [clang][Tooling] Move STL recognizer to its own library

kamaub added a comment. This change causes a linking failure during the `check-all` testing of 'clang-tools-extra' on the clang-ppc64le-rhel #22596 and clang-ppc64le-linux-multistage #23864

[PATCH] D135199: [OpenMP][C++] Allow #pragma omp simd in constexpr functions

jdoerfert added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:8274-8279 // Only if a local variable was declared in the function currently being // evaluated, do we expect to be able to find its value in the current // frame. (Otherwise it was likely

[PATCH] D134330: [Docs] [HLSL] Add note about PCH support

This revision was automatically updated to reflect the committed changes. Closed by commit rG6a6f10fd23b2: [Docs] [HLSL] Add note about PCH support (authored by python3kgae). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134330/new/ https://reviews.

[clang] 6a6f10f - [Docs] [HLSL] Add note about PCH support

Author: Xiang Li Date: 2022-10-07T10:49:21-07:00 New Revision: 6a6f10fd23b2730e2c01051541c5a83f5df9131b URL: https://github.com/llvm/llvm-project/commit/6a6f10fd23b2730e2c01051541c5a83f5df9131b DIFF: https://github.com/llvm/llvm-project/commit/6a6f10fd23b2730e2c01051541c5a83f5df9131b.diff LOG:

[PATCH] D133983: [HLSL] Add SV_DispatchThreadID

beanz added inline comments. Comment at: clang/lib/CodeGen/CGHLSLRuntime.cpp:135 +llvm::Function *DxThreadID = CGM.getIntrinsic(Intrinsic::dx_thread_id); +// dx_thread_id +return buildVectorInput(B, DxThreadID, Ty); nit: this comment doesn't add value

[PATCH] D135397: [clang][dataflow] Add support for a Top value in boolean formulas.

ymandel updated this revision to Diff 466124. ymandel marked an inline comment as done. ymandel added a comment. Address (most) comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135397/new/ https://reviews.llvm.org/D135397 Files: clang/inc

[clang-tools-extra] bb4f0af - [clangd] Fix buildbots after d1f13c54f172875d9a14c46c09afb1f22d78cdf8

Author: Kadir Cetinkaya Date: 2022-10-07T20:10:32+02:00 New Revision: bb4f0af97dba600c50a0f727b25a760e8185c578 URL: https://github.com/llvm/llvm-project/commit/bb4f0af97dba600c50a0f727b25a760e8185c578 DIFF: https://github.com/llvm/llvm-project/commit/bb4f0af97dba600c50a0f727b25a760e8185c578.dif

[PATCH] D135397: [clang][dataflow] Add support for a Top value in boolean formulas.

ymandel marked 11 inline comments as done. ymandel added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/WatchedLiteralsSolver.cpp:237-238 + case Value::Kind::Top: +// Nothing more to do. Each `Top` instance will be mapped to a fresh +// variabl

[PATCH] D135328: [CUDA] Refactored CUDA version housekeeping to use less boilerplate.

tra added a comment. @yaxunl - Are you OK with the patch? PTAL. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135328/new/ https://reviews.llvm.org/D135328 ___ cfe-commits mailing list cfe-commits@lists.l

[PATCH] D135397: [clang][dataflow] Add support for a Top value in boolean formulas.

gribozavr2 accepted this revision. gribozavr2 added inline comments. Comment at: clang/include/clang/Analysis/FlowSensitive/DataflowAnalysisContext.h:157 + TopValue &createTop() { +return takeOwnership(std::make_unique()); + } ymandel wrote: > xazax.hun wr

[PATCH] D135471: [CMake] Drop libLTO and switch to PIE for Fuchsia toolchain

phosek created this revision. phosek added a reviewer: abrachet. Herald added a subscriber: inglorion. Herald added a project: All. phosek requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. All our users have migrated to ld64.lld so we no long

[PATCH] D135472: [ODRHash] Hash attributes on declarations.

vsapsai created this revision. vsapsai added reviewers: rtrieu, aaron.ballman, ChuanqiXu, Bigcheese. Herald added a subscriber: ributzka. Herald added a project: All. vsapsai requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Arguments not for

[PATCH] D135472: [ODRHash] Hash attributes on declarations.

vsapsai added inline comments. Comment at: clang/lib/AST/ODRHash.cpp:479-480 + + llvm::copy_if(D->attrs(), std::back_inserter(HashableAttrs), +[](const Attr *A) { return !A->isImplicit(); }); +} I'm not sure `isImplicit` is the best indicator of

[PATCH] D135177: [clang] adds `__is_scoped_enum`, `__is_nullptr`, and `__is_referenceable`

aaron.ballman added inline comments. Comment at: clang/test/SemaCXX/type-traits.cpp:374 +void is_scoped_enum() { + static_assert(!__is_scoped_enum(Enum), ""); It'd probably not be a bad idea at some point to add test coverage for incomplete types. =

[PATCH] D135471: [CMake] Drop libLTO and switch to PIE for Fuchsia toolchain

abrachet accepted this revision. abrachet added a comment. This revision is now accepted and ready to land. Nice thats 71mb saved :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135471/new/ https://reviews.llvm.org/D135471 ___

[PATCH] D135177: [clang] adds `__is_scoped_enum`, `__is_nullptr`, and `__is_referenceable`

aaron.ballman accepted this revision. aaron.ballman added a comment. Assuming the additional test cases don't uncover any surprises, this LGTM as well (modulo nits already brought up). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135177/new/ http

[PATCH] D133983: [HLSL] Add SV_DispatchThreadID

python3kgae updated this revision to Diff 466141. python3kgae marked 5 inline comments as done. python3kgae added a comment. Fix test fail after rebase and code cleanup to match comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133983/new/ ht

[PATCH] D135466: [clang-format] Add support to remove unnecessary semicolons after function definition

lahwaacz added inline comments. Comment at: clang/docs/ClangFormatStyleOptions.rst:3769 + care should be taken to review code changes made by this option. + NOTE: + Setting this to false will not add `;` where they were missing Nit: the note should probably

[PATCH] D134369: [Clang] Support constexpr builtin fmax

jcranmer-intel added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:14029-14030 + case Builtin::BI__builtin_fmaxf16: + case Builtin::BI__builtin_fmaxf128: { +APFloat RHS(0.); +if (!EvaluateFloat(E->getArg(0), Result, Info) || I think you sh

[PATCH] D135476: [clang-tidy] Support concepts in `bugprone-forwarding-reference-overload`

Izaron created this revision. Izaron added reviewers: hokein, aaron.ballman, LegalizeAdulthood, njames93. Herald added subscribers: carlosgalvezp, xazax.hun. Herald added a project: All. Izaron requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber:

[PATCH] D135476: [clang-tidy] Support concepts in `bugprone-forwarding-reference-overload`

Izaron updated this revision to Diff 466147. Izaron added a comment. Fixes https://github.com/llvm/llvm-project/issues/58230 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135476/new/ https://reviews.llvm.org/D135476 Files: clang-tools-extra/clan

[PATCH] D135476: [clang-tidy] Support concepts in `bugprone-forwarding-reference-overload`

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/bugprone/forwarding-reference-overload.rst:54 constructor could hide in this case. We also suppress warnings for constructors -like C3 and C4 that are guarded with an ``enable_if``, assum

[PATCH] D134813: Properly print unnamed TagDecl objects in diagnostics

aaron.ballman updated this revision to Diff 466145. aaron.ballman added a comment. Fixes the failing AST unit test in Clang found by precommit CI. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134813/new/ https://reviews.llvm.org/D134813 Files: clang-tools-extra/clangd/unittests/Find

[PATCH] D134369: [Clang] Support constexpr builtin fmax

Izaron updated this revision to Diff 466151. Izaron added a comment. Add TODO comment about sNaN. Thanks to @jcranmer-intel! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134369/new/ https://reviews.llvm.org/D134369 Files: clang/docs/LanguageExt

[PATCH] D135433: [clang][Interp] Implement while and do-while loops

aaron.ballman added inline comments. Comment at: clang/test/AST/Interp/loops.cpp:93 + } + static_assert(f4() == 5, ""); +}; Can you also add some tests that use nested loops with multiple levels of `break` and `continue` use? Also, I think it might be useful

[PATCH] D135370: Narrow inline namespace filtration for unqualified friend declarations

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM! Should we also add a release note or do we think this isn't enough of a compile-time performance improvement to warrant that? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1

[PATCH] D129755: Thread safety analysis: Support copy-elided production of scoped capabilities through arbitrary calls

hans added a comment. In D129755#3843146 , @aaronpuchert wrote: > In D129755#3842729 , @hans wrote: > >> We're hitting a false positive in grpc after this: >> >> > ../../third_party/grpc/src/src/core/lib/gprpp/

[PATCH] D135328: [CUDA] Refactored CUDA version housekeeping to use less boilerplate.

yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. LGTM. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135328/new/ https://reviews.llvm.org/D135328 __

  1   2   >