[PATCH] D134020: [clang][Interp] Handle enums

tbaeder added inline comments. Comment at: clang/test/AST/Interp/enums.cpp:25 + SIX = FIVE + 2, + +}; aaron.ballman wrote: > tbaeder wrote: > > aaron.ballman wrote: > > > tbaeder wrote: > > > > shafik wrote: > > > > > Maybe some edge case values for enumerators

[PATCH] D131465: C++/ObjC++: switch to gnu++17 as the default standard

aaron.ballman added a comment. In D131465#3823599 , @hans wrote: > In D131465#3821701 , @aaron.ballman > wrote: > >> Perhaps the simple rule we're going for is "when executed on Windows, Clang >> defaults to C++

[PATCH] D134020: [clang][Interp] Handle enums

aaron.ballman added inline comments. Comment at: clang/test/AST/Interp/enums.cpp:25 + SIX = FIVE + 2, + +}; tbaeder wrote: > aaron.ballman wrote: > > tbaeder wrote: > > > aaron.ballman wrote: > > > > tbaeder wrote: > > > > > shafik wrote: > > > > > > Maybe some

[PATCH] D134820: [LTO][clang] Teaching Clang to Pass Plugin Options to the AIX Linker

qiongsiwu1 updated this revision to Diff 463878. qiongsiwu1 added a comment. Fix the test failure on Windows. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134820/new/ https://reviews.llvm.org/D134820 Files: clang/lib/Driver/ToolChains/AIX.cpp

[PATCH] D134878: Update developer policy on potentially breaking changes

aaron.ballman created this revision. aaron.ballman added reviewers: rnk, lattner, ldionne, rjmccall, Mordante, tahonermann, bruno, tonic. Herald added a project: All. aaron.ballman requested review of this revision. Herald added a project: LLVM. We've recently had issues appropriately notifying u

[PATCH] D134878: Update developer policy on potentially breaking changes

aaron.ballman added a subscriber: mehdi_amini. aaron.ballman added a comment. Note: I would love to add a vendors group to Phabricator for LLVM and lldb (and any other project we think has vendors), but this requires admin privileges to do. @mehdi_amini, is this something you could help out with

[PATCH] D134880: [clang] [test] Use %clang_cc1 substitution consistently

mgorny created this revision. mgorny added reviewers: python3kgae, beanz, jhuber6, davide, asb, MaskRay, plotfi. Herald added subscribers: StephenFan, frasercrmck, luismarques, apazos, sameer.abuasal, s.egerton, Jim, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng

[PATCH] D134804: [clang][Interp] Implement bitwise Not operations

aaron.ballman added a comment. LGTM aside from a question about naming. Comment at: clang/lib/AST/Interp/Integral.h:228-231 + static bool Not(Integral A, Integral *R) { +*R = Integral(~A.V); +return false; + } Can we name this one `complement` instead

[PATCH] D133413: [clang-tidy] Fix crashes on `if consteval` in readability checks

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, though please add a release note for the fix. Do you need someone to commit on your behalf? If so, what name and email address would you like used for patch attribution?

[PATCH] D134878: Update developer policy on potentially breaking changes

aaron.ballman added a reviewer: JDevlieghere. aaron.ballman added a comment. Adding someone from lldb as a review for awareness. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134878/new/ https://reviews.llvm.org/D134878 ___

[PATCH] D134871: [llvm] [lit] Move %clang_dxc substitution from clang/test

python3kgae accepted this revision. python3kgae added a comment. This revision is now accepted and ready to land. LGTM. Thanks for the fix. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134871/new/ https://reviews.llvm.org/D134871 ___ cfe-com

[PATCH] D134878: Update developer policy on potentially breaking changes

ldionne added a comment. Thanks for working on this! FWIW, this more or less standardizes what we've been doing in libc++ for the past ~1.5 years and it's been pretty low effort for us to do. And putting my vendor hat on, it's been extremely useful for me to track down potential issues when try

[PATCH] D134831: [Clang][Sema] Add -Wcast-function-type-strict

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:8686 +def warn_cast_function_type_strict : Warning, + InGroup, DefaultIgnore; def err_cast_pointer_to_non_pointer_int : Error< samitolvanen wrote: > nickdesaulnier

[PATCH] D134872: AMDGPU: Add __builtin_amdgcn_permlane64

yaxunl accepted this revision as: yaxunl. yaxunl added a comment. This revision is now accepted and ready to land. LGTM. Thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134872/new/ https://reviews.llvm.org/D134872 ___ cfe-commits mailin

[PATCH] D134878: Update developer policy on potentially breaking changes

aaron.ballman added inline comments. Comment at: llvm/docs/DeveloperPolicy.rst:140 + +* After the change has been committed to the repository, the potentially + disruptive changes described in the release notes should be posted to the ldionne wrote: > I wonder w

[PATCH] D112621: [analyzer][solver] Introduce reasoning for not equal to operator

manas updated this revision to Diff 463910. manas added a comment. Fix casting to bigger/unsigned type and add tests with multiple ranges in RangeSet Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112621/new/ https://reviews.llvm.org/D112621 Files

[PATCH] D88976: [clang] Use correct address space for global variable debug info

yaxunl accepted this revision. yaxunl added a comment. LGTM. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88976/new/ https://reviews.llvm.org/D88976 ___ cfe-commits mailing list cfe-commits@list

[PATCH] D112621: [analyzer][solver] Introduce reasoning for not equal to operator

manas marked 3 inline comments as done. manas added a comment. Thanks @martong and @ASDenysPetrov for the feedback. I utilized `(u != n)` to disallow bifurcation in test cases. Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:1630-1631 + + RangeSet CastedL

[PATCH] D134885: [Clang] Fix variant crashes from GH58028, GH57370

royjacobson created this revision. royjacobson added a reviewer: shafik. Herald added a project: All. royjacobson requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fixes a null dereference in some diagnostic issuing code. Closes https://gith

[PATCH] D133659: [Clang] P1169R4: static operator()

royjacobson updated this revision to Diff 463920. royjacobson added a comment. Rebase and address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133659/new/ https://reviews.llvm.org/D133659 Files: clang/docs/ReleaseNotes.rst clang/inc

[PATCH] D133119: [clang-tidy] Add checker 'bugprone-suspicious-realloc-usage'.

steakhal accepted this revision. steakhal added a comment. LGTM, no objection here. Comment at: clang-tools-extra/test/clang-tidy/checkers/bugprone/suspicious-realloc-usage.cpp:81-85 +void warn_if_copy_exists(void *p) { + void *q = p; + p = realloc(p, 111); + // CHECK-MESSA

[PATCH] D134020: [clang][Interp] Handle enums

tbaeder added inline comments. Comment at: clang/test/AST/Interp/enums.cpp:25 + SIX = FIVE + 2, + +}; aaron.ballman wrote: > tbaeder wrote: > > aaron.ballman wrote: > > > tbaeder wrote: > > > > aaron.ballman wrote: > > > > > tbaeder wrote: > > > > > > shafik wro

[PATCH] D133659: [Clang] P1169R4: static operator()

cor3ntin added a comment. @aaron.ballman Can you give one last pass at this? The new conversions rules is not something I feel confident blessing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133659/new/ https://reviews.llvm.org/D133659

[PATCH] D133659: [Clang] P1169R4: static operator()

royjacobson updated this revision to Diff 463926. royjacobson added a comment. Rebase (main was broken) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133659/new/ https://reviews.llvm.org/D133659 Files: clang/docs/ReleaseNotes.rst clang/include

[PATCH] D134885: [Clang] Fix variant crashes from GH58028, GH57370

royjacobson updated this revision to Diff 463929. royjacobson added a comment. Rebase on main (build was broken) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134885/new/ https://reviews.llvm.org/D134885 Files: clang/lib/Sema/SemaInit.cpp clan

[PATCH] D134831: [Clang][Sema] Add -Wcast-function-type-strict

kees added a subscriber: nathanchance. kees added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:8686 +def warn_cast_function_type_strict : Warning, + InGroup, DefaultIgnore; def err_cast_pointer_to_non_pointer_int : Error< aaron.

[PATCH] D128372: [Clang-Tidy] Empty Check

denik added a comment. @LegalizeAdulthood, @njames93, friendly ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128372/new/ https://reviews.llvm.org/D128372 ___ cfe-commits mailing list cfe-commits@li

[PATCH] D134878: Update developer policy on potentially breaking changes

Mordante accepted this revision. Mordante added a comment. This revision is now accepted and ready to land. Thanks a lot for working on this! A few small nits, otherwise LGTM. Comment at: llvm/docs/DeveloperPolicy.rst:112 + +Please help notify users of potential disruptions whe

[PATCH] D134880: [clang] [test] Use %clang_cc1 substitution consistently

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134880/new/ https://reviews.llvm.org/D134880 ___ cfe-commits mailing list cfe-commit

[PATCH] D134337: [clang] [Driver] More flexible rules for loading default configs

MaskRay added inline comments. Comment at: clang/lib/Driver/Driver.cpp:1065-1080 + StringRef EffectiveDriverMode; + if (CLOptions) +EffectiveDriverMode = CLOptions->getLastArgValue(options::OPT_driver_mode); + if (EffectiveDriverMode.empty()) +EffectiveDriverMode = Cla

[PATCH] D134820: [LTO][clang] Teaching Clang to Pass Plugin Options to the AIX Linker

qiongsiwu1 updated this revision to Diff 463943. qiongsiwu1 added a comment. Fix test case on Windows. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134820/new/ https://reviews.llvm.org/D134820 Files: clang/lib/Driver/ToolChains/AIX.cpp clang/

[PATCH] D134831: [Clang][Sema] Add -Wcast-function-type-strict

nathanchance added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:8686 +def warn_cast_function_type_strict : Warning, + InGroup, DefaultIgnore; def err_cast_pointer_to_non_pointer_int : Error< kees wrote: > aaron.ballman wrote: >

[PATCH] D134337: [clang] [Driver] More flexible rules for loading default configs

mgorny marked 2 inline comments as done. mgorny added inline comments. Comment at: clang/lib/Driver/Driver.cpp:1065-1080 + StringRef EffectiveDriverMode; + if (CLOptions) +EffectiveDriverMode = CLOptions->getLastArgValue(options::OPT_driver_mode); + if (EffectiveDriverMode

[PATCH] D134337: [clang] [Driver] More flexible rules for loading default configs

mgorny updated this revision to Diff 463944. mgorny marked an inline comment as done. mgorny added a comment. Change confusing comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134337/new/ https://reviews.llvm.org/D134337 Files: clang/docs/ReleaseNotes.rst clang/docs/UsersMan

[PATCH] D134369: [Clang] Support constexpr builtin fmax

efriedma added inline comments. Comment at: clang/test/Sema/constant-builtins-fmax.cpp:35-39 +#define FMAX_TEST_BOTH_ZERO(T, FUNC) \ +static_assert(0.0 == FUNC(0.0, 0.0)); \ +static_assert(0.0 == FUNC(-0.0, 0.0)); \ +static_assert(0.0 == FUNC(0.0, -0.0)); \ +

[PATCH] D134454: [Driver][Distro] Fix ArchLinux sysroot detection

nickdesaulniers accepted this revision. nickdesaulniers added a comment. This revision is now accepted and ready to land. Looks great! Nice job @10ne1 . Need me to commit this for you? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134454/new/ https://reviews.llvm.org/D134454 __

[PATCH] D134878: Update developer policy on potentially breaking changes

aaron.ballman updated this revision to Diff 463949. aaron.ballman marked 3 inline comments as done. aaron.ballman added a comment. Applying review feedback. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134878/new/ https://reviews.llvm.org/D134878 Files: llvm/docs/DeveloperPolicy.rst

[PATCH] D134878: Update developer policy on potentially breaking changes

aaron.ballman added inline comments. Comment at: llvm/docs/DeveloperPolicy.rst:129 + + People interested in joining the vendors group can do so by clicking the + "Join Project" link on the vendor's "Members" page in Phabricator. Mordante wrote: > I didn't appl

[PATCH] D134453: Introduce the `AlwaysIncludeTypeForNonTypeTemplateArgument` into printing policy

dblaikie added a comment. In D134453#3823141 , @DoDoENT wrote: >> Generally the way to do it, if you want to introspect into the type, its >> template parameters, etc, then yes, keeping pointers to the AST or reparsing >> the name with Clang as-needed,

[PATCH] D134878: Update developer policy on potentially breaking changes

Mordante added inline comments. Comment at: llvm/docs/DeveloperPolicy.rst:129 + + People interested in joining the vendors group can do so by clicking the + "Join Project" link on the vendor's "Members" page in Phabricator. aaron.ballman wrote: > Mordante wrote

[PATCH] D134454: [Driver][Distro] Fix ArchLinux sysroot detection

10ne1 added a comment. In D134454#3824391 , @nickdesaulniers wrote: > Looks great! Nice job @10ne1 . Need me to commit this for you? Yes please, thank you! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134454/new/ https://reviews.llvm.org/D13

[PATCH] D133659: [Clang] P1169R4: static operator()

aaron.ballman added a comment. Double-checking my understanding of the overload resolution changes: we added a new conversion sequence, but we don't expect that conversion sequence to cause a change in overload resolution in practice? (I'm wondering if there's test coverage we should be adding

[PATCH] D133659: [Clang] P1169R4: static operator()

cor3ntin added inline comments. Comment at: clang/lib/Parse/ParseExprCXX.cpp:1265 + if (Intro.hasLambdaCapture()) +P.Diag(StaticLoc, diag::err_static_lambda_captures); +} aaron.ballman wrote: > aaron.ballman wrote: > > royjacobson wrote: > > > cor3ntin wrote

[PATCH] D134319: [HLSL] add ceil library function

bob80905 updated this revision to Diff 463960. bob80905 added a comment. - got clang-format working on VS2022 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134319/new/ https://reviews.llvm.org/D134319 Files: clang/lib/Headers/hlsl/hlsl_intrinsic

[PATCH] D134880: [clang] [test] Use %clang_cc1 substitution consistently

probinson added inline comments. Comment at: clang/test/Driver/lit.local.cfg:8 -('%clang_cc1', - """*** Do not use 'clang -cc1' in Driver tests. ***""") ) But we _don't_ want to use `%clang_cc1` in Driver tests; if we do, then we're not testing the dri

[PATCH] D134454: [Driver][Distro] Fix ArchLinux sysroot detection

MaskRay added a comment. Since this decreases complexity, it's probably fine. But we really need some tests in clang/test/Driver see linux-cross.cpp CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134454/new/ https://reviews.llvm.org/D134454 _

[PATCH] D134337: [clang] [Driver] More flexible rules for loading default configs

MaskRay added inline comments. Comment at: clang/test/Driver/config-file3.c:176 // -// SHORT-NAME: Configuration file: {{.*}}/testdmode/qqq.cfg -// SHORT-NAME: -Werror -// SHORT-NAME-NOT: -Wundefined-func-template +// FULL3-NOT: Configuration file: +// FULL3: Configuration file:

[PATCH] D134303: [AST] Preserve more structure in UsingEnumDecl node.

sammccall added a comment. In D134303#3823620 , @urnathan wrote: > Does this still apply with the fix for dr2621 landed? Not cleanly, as getType already creates the ElaboratedTypeLoc for the qualifier but without the `enum` keyword. Wrapping it with a s

[PATCH] D20401: [Lexer] Don't merge macro args from different macro files

nickdesaulniers added subscribers: justinstitt, nikic, tstellar, serge-sans-paille. nickdesaulniers added a comment. In D20401#3823476 , @sammccall wrote: > In D20401#2770059 , @nickdesaulniers > wrote: > >> I kno

[PATCH] D134454: [Driver][Distro] Fix ArchLinux sysroot detection

MaskRay requested changes to this revision. MaskRay added a comment. This revision now requires changes to proceed. I'll grab an Arch Linux machine for testing, but I don't think this is currently in a form for submitting. This adds new functionality for non-MIPS and we need some fake file hierar

[PATCH] D134454: [Driver][Distro] Fix ArchLinux sysroot detection

MaskRay added inline comments. Comment at: clang/lib/Driver/ToolChains/Linux.cpp:369 + // Path = $GCCToolchainPath/csky-linux-gnuabiv2/libc + if (getTriple().isCSKY()) +Path += "/libc"; If the `else` branch uses braces, the `then` branch needs brances as we

[PATCH] D134831: [Clang][Sema] Add -Wcast-function-type-strict

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:8686 +def warn_cast_function_type_strict : Warning, + InGroup, DefaultIgnore; def err_cast_pointer_to_non_pointer_int : Error< nathanchance wrote: > kees wrote: >

[clang] 013012b - [Clang][NFC] Add missing feature macros to lexer test

Author: Roy Jacobson Date: 2022-09-29T21:16:29+03:00 New Revision: 013012b99a5448f067cfdce8dd07cf503a6172a7 URL: https://github.com/llvm/llvm-project/commit/013012b99a5448f067cfdce8dd07cf503a6172a7 DIFF: https://github.com/llvm/llvm-project/commit/013012b99a5448f067cfdce8dd07cf503a6172a7.diff

[PATCH] D134454: [Driver][Distro] Fix ArchLinux sysroot detection

MaskRay added a comment. Another opinion is whether we actually need the more and more complex sysroot computation logic. https://reviews.llvm.org/D134337 will soon land and we can move to require distributions to provide a config file instead. Yes, I see mips and csky special cases. To be fai

[PATCH] D134337: [clang] [Driver] More flexible rules for loading default configs

nickdesaulniers added a comment. It might be nice to work with `rustc` folks on the format of these configs. A frequent difficulty between Rust and C interop is the totally different command line flags necessary to compile code meant to link together and match as much of the ABI as possible.

[PATCH] D134671: [Driver] Prevent Mips specific code from claiming -mabi argument on other targets.

nickdesaulniers added subscribers: nathanchance, nickdesaulniers. nickdesaulniers added a comment. I don't think it's an issue for us to work around downstream, but this did regress support for `-mabi=ms` used in UEFI related build scripts. https://github.com/ClangBuiltLinux/linux/issues/1725 Not

[PATCH] D134898: [Clang] define __cpp_named_character_escapes

royjacobson created this revision. royjacobson added a reviewer: cor3ntin. Herald added a project: All. royjacobson requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Define the feature test macro for named character escapes. I assume this was

[PATCH] D121445: [Clang][CSKY] Add the CSKY target and compiler driver

MaskRay added a comment. mips computed sysroot from GCCInstallation very early in 2013 rG08450bd55ccdc4aee4f5f73cde97e25b3c4ce5b9 and Android followed up in 2018 (D45291 ), but I am not sure

[clang] 29e0435 - [libclang] Split-out parts of `Index.h`

Author: Jan Svoboda Date: 2022-09-29T11:29:53-07:00 New Revision: 29e0435ac04957861aa1f85d41291c8b19db0122 URL: https://github.com/llvm/llvm-project/commit/29e0435ac04957861aa1f85d41291c8b19db0122 DIFF: https://github.com/llvm/llvm-project/commit/29e0435ac04957861aa1f85d41291c8b19db0122.diff L

[clang] 1392126 - [clang][deps] NFC: Expose more flexible version of `Worker::computeDependencies()`

Author: Jan Svoboda Date: 2022-09-29T11:29:53-07:00 New Revision: 13921262cae0e7346e41875c1850d8861be0488e URL: https://github.com/llvm/llvm-project/commit/13921262cae0e7346e41875c1850d8861be0488e DIFF: https://github.com/llvm/llvm-project/commit/13921262cae0e7346e41875c1850d8861be0488e.diff L

[PATCH] D134837: [libclang] Split-out some data structures out of `Index.h`

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG29e0435ac049: [libclang] Split-out parts of `Index.h` (authored by jansvoboda11). Changed prior to commit: https://reviews.llvm.org/D134837?vs=463

[PATCH] D134838: [clang][deps] NFC: Expose more flexible version of `Worker::computeDependencies()`

This revision was automatically updated to reflect the committed changes. Closed by commit rG13921262cae0: [clang][deps] NFC: Expose more flexible version of `Worker::computeDependencies… (authored by jansvoboda11). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[PATCH] D134671: [Driver] Prevent Mips specific code from claiming -mabi argument on other targets.

aaron.ballman added a comment. In D134671#3824644 , @nickdesaulniers wrote: > I don't think it's an issue for us to work around downstream, but this did > regress support for `-mabi=ms` used in UEFI related build scripts. > https://github.com/ClangBuilt

[PATCH] D134337: [clang] [Driver] More flexible rules for loading default configs

ojeda added a comment. Thanks Nick for the ping. Indeed, `rustc` allows to use a "target specification file" to create new targets that are not built-in, as a JSON file. They are unstable though, since they are fairly tied to LLVM, and I think the Rust compiler team prefers to stabilize flags i

[PATCH] D133659: [Clang] P1169R4: static operator()

royjacobson updated this revision to Diff 463978. royjacobson marked 7 inline comments as done. royjacobson added a comment. Address CR comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133659/new/ https://reviews.llvm.org/D133659 Files: cl

[PATCH] D133659: [Clang] P1169R4: static operator()

royjacobson added a comment. In D133659#3824472 , @aaron.ballman wrote: > Double-checking my understanding of the overload resolution changes: we added > a new conversion sequence, but we don't expect that conversion sequence to > cause a change in ove

[PATCH] D134453: Introduce the `AlwaysIncludeTypeForNonTypeTemplateArgument` into printing policy

aaron.ballman added a comment. In D134453#3824423 , @dblaikie wrote: > In D134453#3823141 , @DoDoENT wrote: > >>> Generally the way to do it, if you want to introspect into the type, its >>> template parameters,

[PATCH] D20401: [Lexer] Don't merge macro args from different macro files

sammccall added a comment. Thanks Nick for the info! No kernel experience here, so if you have any particular suggestions about how to measure the workload you care about it'd be much appreciated (e.g. are particular files that are slow enough to measure in isolation, or is it better to do a fu

[PATCH] D134852: [clang-format][NFC] Clean up class HeaderIncludes and Format.cpp

owenpan added a comment. @kwk D134733 reminded me of https://reviews.llvm.org/D121370#3401173, which I realized didn't go far enough. This NFC patch is what I should have suggested to you then. If you want to do the cleanup differently, you can either make sug

[PATCH] D20401: [Lexer] Don't merge macro args from different macro files

nikic added a comment. In D20401#3824569 , @nickdesaulniers wrote: > But I wouldn't be surprised if other Linux distro's like RHEL bootstrap their > clang distribution via GCC. @tstellar or @serge-sans-paille or @nikic might > know. We did get a curio

[PATCH] D134871: [llvm] [lit] Move %clang_dxc substitution from clang/test

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG74085ebfb68e: [llvm] [lit] Move %clang_dxc substitution from clang/test (authored by mgorny). Herald added a project: clang. Repository: rG LLVM G

[PATCH] D134337: [clang] [Driver] More flexible rules for loading default configs

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG063e17d8b04b: [clang] [Driver] More flexible rules for loading default configs (authored by mgorny). Herald added a project: clang. Repository: rG

[clang] 063e17d - [clang] [Driver] More flexible rules for loading default configs

Author: Michał Górny Date: 2022-09-29T20:58:59+02:00 New Revision: 063e17d8b04b41cd8bd174aebb6603eb1a76d34a URL: https://github.com/llvm/llvm-project/commit/063e17d8b04b41cd8bd174aebb6603eb1a76d34a DIFF: https://github.com/llvm/llvm-project/commit/063e17d8b04b41cd8bd174aebb6603eb1a76d34a.diff

[clang] 74085eb - [llvm] [lit] Move %clang_dxc substitution from clang/test

Author: Michał Górny Date: 2022-09-29T20:59:00+02:00 New Revision: 74085ebfb68e067ba6c21722ac02d2ffbb42a00c URL: https://github.com/llvm/llvm-project/commit/74085ebfb68e067ba6c21722ac02d2ffbb42a00c DIFF: https://github.com/llvm/llvm-project/commit/74085ebfb68e067ba6c21722ac02d2ffbb42a00c.diff

[clang] 1609a5d - [clang] [test] Use %clang_cc1 substitution consistently

Author: Michał Górny Date: 2022-09-29T20:59:00+02:00 New Revision: 1609a5d7715c06ff52c13af8b20ee64811a8ec7b URL: https://github.com/llvm/llvm-project/commit/1609a5d7715c06ff52c13af8b20ee64811a8ec7b DIFF: https://github.com/llvm/llvm-project/commit/1609a5d7715c06ff52c13af8b20ee64811a8ec7b.diff

[PATCH] D111000: [clang-format] allow clang-format to be passed a file of filenames so we can add a regression suite of "clean clang-formatted files" from LLVM

probinson added a comment. In D111000#3822354 , @ychen wrote: > It is possible to just use `clang-format @response.txt`? That should also > invoke the executable once. It's true that whatever file you're handing to `--files` could just as easily be spe

[PATCH] D134880: [clang] [test] Use %clang_cc1 substitution consistently

This revision was automatically updated to reflect the committed changes. Closed by commit rG1609a5d7715c: [clang] [test] Use %clang_cc1 substitution consistently (authored by mgorny). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[PATCH] D133659: [Clang] P1169R4: static operator()

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, thank you for all the work on this! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133659/new/ https://reviews.llvm.org/D1336

[PATCH] D134020: [clang][Interp] Handle enums

aaron.ballman added inline comments. Comment at: clang/test/AST/Interp/enums.cpp:25 + SIX = FIVE + 2, + +}; tbaeder wrote: > aaron.ballman wrote: > > tbaeder wrote: > > > aaron.ballman wrote: > > > > tbaeder wrote: > > > > > aaron.ballman wrote: > > > > > > tbae

[PATCH] D134880: [clang] [test] Use %clang_cc1 substitution consistently

MaskRay added inline comments. Comment at: clang/test/Driver/lit.local.cfg:8 -('%clang_cc1', - """*** Do not use 'clang -cc1' in Driver tests. ***""") ) probinson wrote: > But we _don't_ want to use `%clang_cc1` in Driver tests; if we do, then we're >

[PATCH] D134874: [Concepts] Fix Concepts on generic lambda in a VarTemplateSpecDecl

erichkeane added inline comments. Comment at: clang/test/SemaTemplate/concepts-lambda.cpp:26 + template + auto f2 = [](auto... args) +requires (sizeof...(args) > 0) Huh... this f2 example seems to ICE for some reason, I could swear it worked, but building

[PATCH] D133983: [HLSL] Add SV_DispatchThreadID

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from a think-o that I introduced with an earlier suggested change. I'm not super qualified for the CodeGen changes. They look correct to me, but @beanz would probably

[clang] 3a79f1c - [Driver][test] Restore %clang -cc1 in test/Driver

Author: Fangrui Song Date: 2022-09-29T12:21:57-07:00 New Revision: 3a79f1caa9bd1e43f4e0e9187b87c978105c40b1 URL: https://github.com/llvm/llvm-project/commit/3a79f1caa9bd1e43f4e0e9187b87c978105c40b1 DIFF: https://github.com/llvm/llvm-project/commit/3a79f1caa9bd1e43f4e0e9187b87c978105c40b1.diff

[PATCH] D124751: [HLSL] Support -E option for HLSL.

MaskRay added inline comments. Comment at: clang/test/Driver/hlsl-entry.cpp:1 +// RUN:not %clang -cc1 -triple dxil-pc-shadermodel6.3-compute -x c++ -hlsl-entry foo %s 2>&1 | FileCheck %s --check-prefix=NOTHLSL + Note, test/Driver deliberately discourages `%cla

[PATCH] D134801: [clang][Interp] Implement ConditionalOperators

aaron.ballman added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.h:90 bool VisitOpaqueValueExpr(const OpaqueValueExpr *E); + bool VisitConditionalOperator(const ConditionalOperator *E); Do we want to handle `BinaryConditionalOperator` a

[PATCH] D52290: [driver][mips] Adjust target triple accordingly to provided ABI name

MaskRay added inline comments. Herald added a project: All. Comment at: cfe/trunk/lib/Driver/Driver.cpp:486 + // accordingly to provided ABI name. + A = Args.getLastArg(options::OPT_mabi_EQ); + if (A && Target.isMIPS()) getLastArg claims the option for non-mip

[PATCH] D125142: [clang][auto-init] Remove -enable flag for "zero" mode

kees added a comment. Thanks for all the careful consideration; I appreciate it! I'll land this tomorrow unless there are new specific objections. :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125142/new/ https://reviews.llvm.org/D125142 _

[PATCH] D125142: [clang][auto-init] Remove -enable flag for "zero" mode

aaron.ballman added inline comments. Comment at: clang/docs/ReleaseNotes.rst:240-243 +- -enable-trivial-auto-var-init-zero-knowing-it-will-be-removed-from-clang + has been deprecated. The flag will be removed in Clang 17. + -ftrivial-auto-var-init=zero is now available uncondit

[PATCH] D134337: [clang] [Driver] More flexible rules for loading default configs

MaskRay added a comment. In D134337#3824683 , @ojeda wrote: > Thanks Nick for the ping. Indeed, `rustc` allows to use a "target > specification file" to create new targets that are not built-in, as a JSON > file. > > They are unstable though, since they

[PATCH] D134821: [flang][driver] Allow main program to be in an archive

ekieri updated this revision to Diff 463998. ekieri added a comment. Fix test link-f90-main.f90, which was failing for statically linked builds. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134821/new/ https://reviews.llvm.org/D134821 Files: cl

[PATCH] D134671: [Driver] Prevent Mips specific code from claiming -mabi argument on other targets.

MaskRay added a comment. In D134671#3824672 , @aaron.ballman wrote: > In D134671#3824644 , > @nickdesaulniers wrote: > >> I don't think it's an issue for us to work around downstream, but this did >> regress su

[PATCH] D134820: [LTO][clang] Teaching Clang to Pass Plugin Options to the AIX Linker

qiongsiwu1 updated this revision to Diff 464001. qiongsiwu1 added a comment. Try fixing the test case on Windows, hopefully one last time. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134820/new/ https://reviews.llvm.org/D134820 Files: clang/li

[PATCH] D134880: [clang] [test] Use %clang_cc1 substitution consistently

mgorny added inline comments. Comment at: clang/test/Driver/lit.local.cfg:8 -('%clang_cc1', - """*** Do not use 'clang -cc1' in Driver tests. ***""") ) MaskRay wrote: > probinson wrote: > > But we _don't_ want to use `%clang_cc1` in Driver tests; if we

[PATCH] D133659: [Clang] P1169R4: static operator()

royjacobson added a comment. Thanks for the patient review and the discussion! @aaron.ballman @cor3ntin Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133659/new/ https://reviews.llvm.org/D133659 ___ cfe-

[PATCH] D134874: [Concepts] Fix Concepts on generic lambda in a VarTemplateSpecDecl

erichkeane updated this revision to Diff 464003. erichkeane added a comment. Looks like that problem was fixed easy enough, so back to all tests passing :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134874/new/ https://reviews.llvm.org/D134874 Files: clang/include/clang/AST/DeclBa

[clang] 6523814 - [Clang] P1169R4: static operator()

Author: Roy Jacobson Date: 2022-09-29T23:03:26+03:00 New Revision: 6523814c4e38ad70f8fd3fc3c39d089195e099a1 URL: https://github.com/llvm/llvm-project/commit/6523814c4e38ad70f8fd3fc3c39d089195e099a1 DIFF: https://github.com/llvm/llvm-project/commit/6523814c4e38ad70f8fd3fc3c39d089195e099a1.diff

[PATCH] D133659: [Clang] P1169R4: static operator()

This revision was automatically updated to reflect the committed changes. Closed by commit rG6523814c4e38: [Clang] P1169R4: static operator() (authored by royjacobson). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133659/new/ https://reviews.llvm.o

[clang] 8a1e069 - [Clang][NFC] Fix broken link in release notes

Author: Roy Jacobson Date: 2022-09-29T23:16:17+03:00 New Revision: 8a1e069cc479e501b058bdb1a3d961ee6f852c3d URL: https://github.com/llvm/llvm-project/commit/8a1e069cc479e501b058bdb1a3d961ee6f852c3d DIFF: https://github.com/llvm/llvm-project/commit/8a1e069cc479e501b058bdb1a3d961ee6f852c3d.diff

[PATCH] D134898: [Clang] define __cpp_named_character_escapes

royjacobson updated this revision to Diff 464007. royjacobson added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134898/new/ https://reviews.llvm.org/D134898 Files: clang/lib/Frontend/InitPreprocessor.cpp clang/test/Lexer/cx

[PATCH] D134314: [HIP] stop forcing the lang std in the driver

This revision was automatically updated to reflect the committed changes. Closed by commit rGcecb0e98d4b1: [HIP] stop forcing the lang std in the driver (authored by scchan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134314/new/ https://reviews.

<    1   2   3   >