[PATCH] D134652: [clang-format] Add Really Basic Carbon Support/Infrastructure

MyDeveloperDay updated this revision to Diff 462966. MyDeveloperDay added a comment. Treat a class like a C# or Javascript class there is no semi after the brace `};` class Sum { var a: i32; fn Add[me:Self](var num: i32) -> i32 { var total: i32 = me.a + num; return total;

[PATCH] D134653: [clang][modules] Over-align the `Module` class

srj added a comment. > Thanks for verifying the build. You can test for correctness by "building" > the `check-clang` target. Thanks -- I'll also build and test Halide locally. > You can contact the infrastructure working group. Note that we run more > configurations post-commit: https://lab.l

[PATCH] D134337: [clang] [Driver] More flexible rules for loading default configs (WIP)

MaskRay added a comment. In D134337#3815412 , @mgorny wrote: > In D134337#3815339 , @sepavloff > wrote: > >> In D134337#3805368 , @mgorny wrote: >> >>> For target, it wil

[PATCH] D134468: [Driver] Ignore -fmsc-version= -fms-compatibility-version= values smaller than 19

MaskRay added a comment. I am not a user of the MSVC toolchain, so leaving this work to someone working on it is better:) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134468/new/ https://reviews.llvm.org/D134468 _

[PATCH] D134653: [clang][modules] Over-align the `Module` class

srj added a comment. > Thanks for verifying the build. You can test for correctness by "building" > the `check-clang` target. Tests are passing locally, LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134653/new/ https://reviews.llvm.org/D1346

[PATCH] D134653: [clang][modules] Over-align the `Module` class

jansvoboda11 added a comment. In D134653#3815703 , @srj wrote: > I opened a question at https://discourse.llvm.org/t/x86-32-bit-testing/65480 > on Friday but got no responses. Is there a better venue for asking the right > people? That's what I would d

[PATCH] D134653: [clang][modules] Over-align the `Module` class

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG715bd12d2e1d: [clang][modules] Over-align the `Module` class (authored by jansvoboda11). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[clang] 715bd12 - [clang][modules] Over-align the `Module` class

Author: Jan Svoboda Date: 2022-09-26T10:55:22-07:00 New Revision: 715bd12d2e1d4373b58ce515a6e2923d9b617226 URL: https://github.com/llvm/llvm-project/commit/715bd12d2e1d4373b58ce515a6e2923d9b617226 DIFF: https://github.com/llvm/llvm-project/commit/715bd12d2e1d4373b58ce515a6e2923d9b617226.diff L

[PATCH] D134657: [Driver] pass -fcrash-diagnostics-dir to LTO

ychen updated this revision to Diff 462968. ychen added a comment. - use getLastArg - rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134657/new/ https://reviews.llvm.org/D134657 Files: clang/lib/Driver/ToolChains/CommonArgs.cpp clang/tes

[PATCH] D53847: [C++2a] P0634r3: Down with typename!

ayzhao updated this revision to Diff 462969. ayzhao added a comment. clang-format + rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53847/new/ https://reviews.llvm.org/D53847 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td clang/i

[PATCH] D134659: [Driver] pass -fjmc to LTO

ychen created this revision. ychen added reviewers: MaskRay, probinson. Herald added subscribers: StephenFan, inglorion. Herald added a project: All. ychen requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. So the behavior is consistent with n

[PATCH] D134222: [clang][deps] Report module map describing compiled module

w2yehia added a comment. @jansvoboda11 FYI, this is breaking AIX buildbot: https://lab.llvm.org/buildbot/#/builders/214/builds/3436/steps/6/logs/FAIL__Clang__modules-header-sharing_m Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134222/new/ https:

[PATCH] D134660: [LinkerWrapper] Fix optimized debugging builds for NVPTX LTO

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, tianshilei1992, JonChesterfield, markdewing. Herald added subscribers: mattd, gchakrabarti, asavonic, inglorion. Herald added a project: All. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits, sstefan1

[PATCH] D133705: [HIP] Fix unbundling archive

tra added inline comments. Comment at: clang/test/Driver/clang-offload-bundler.c:410-412 +// Check clang-offload-bundler extracts empty archives if the input file +// is not an archive when --allow-missing-bundles is specified, otherwise +// report an error. Is t

[PATCH] D134224: [clang][modules][deps] Report modulemaps describing excluded headers

jansvoboda11 added a comment. Fixed in D134653 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134224/new/ https://reviews.llvm.org/D134224 ___ cfe-commits mailing list

[clang] 8df1f3b - [clang][deps] Fix test on AIX

Author: Jan Svoboda Date: 2022-09-26T12:40:28-07:00 New Revision: 8df1f3bc19d7b37c9be6ce32564c9b8fd73d2aa3 URL: https://github.com/llvm/llvm-project/commit/8df1f3bc19d7b37c9be6ce32564c9b8fd73d2aa3 DIFF: https://github.com/llvm/llvm-project/commit/8df1f3bc19d7b37c9be6ce32564c9b8fd73d2aa3.diff L

[PATCH] D133574: [C2x] reject type definitions in offsetof

aaron.ballman accepted this revision. aaron.ballman added a subscriber: nathanchance. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, thank you! Please don't land until you have some indication from the kernel folks that this won't be super disruptive for the

[PATCH] D134222: [clang][deps] Report module map describing compiled module

jansvoboda11 added a comment. In D134222#3815793 , @w2yehia wrote: > @jansvoboda11 > FYI, this is breaking AIX buildbot: > https://lab.llvm.org/buildbot/#/builders/214/builds/3436/steps/6/logs/FAIL__Clang__modules-header-sharing_m Thanks for reporting t

[PATCH] D134668: [LTO][clang] Using Single Dash Consistently when Passing LTO Options

qiongsiwu1 created this revision. qiongsiwu1 added reviewers: w2yehia, MaskRay. qiongsiwu1 added a project: clang. Herald added subscribers: ormris, StephenFan, inglorion. Herald added a project: All. qiongsiwu1 requested review of this revision. Herald added a subscriber: cfe-commits. The followi

[PATCH] D86049: RFC: Implement optional exportable wrapper function generation for objc_direct methods.

plotfi updated this revision to Diff 462999. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86049/new/ https://reviews.llvm.org/D86049 Files: clang/include/clang/AST/DeclObjC.h clang/lib/AST/DeclObjC.cpp clang/lib/AST/Mangle.cpp clang/lib/Cod

[PATCH] D133036: [InstCombine] Treat passing undef to noundef params as UB

aeubanks added a comment. @vitalybuka can we turn on -fsanitize-memory-param-retval by default upstream? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133036/new/ https://reviews.llvm.org/D133036 ___ cfe

[PATCH] D86049: RFC: Implement optional exportable wrapper function generation for objc_direct methods.

plotfi added a comment. @dmaclach @ahatanak @mwyman How do things look from here? Do you want something for properties as well or would it be ok if we did this in a later commit? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86049/new/ https://rev

[PATCH] D134652: [clang-format] Add Really Basic Carbon Support/Infrastructure

MyDeveloperDay updated this revision to Diff 463000. MyDeveloperDay added a comment. Fix pointer function arguments Add release notes Fix more `TT_TrailingReturnArrow` cases CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134652/new/ https://reviews.llvm.org/D134652 Files: clang/.clang

[PATCH] D134652: [clang-format] Add Really Basic Carbon Support/Infrastructure

MyDeveloperDay updated this revision to Diff 463001. MyDeveloperDay added a comment. Remove .clang-format change CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134652/new/ https://reviews.llvm.org/D134652 Files: clang/docs/ClangFormatStyleOptions.rst clang/docs/ReleaseNotes.rst cl

[PATCH] D134669: [clang][msan] Turn on -fsanitize-memory-param-retval by default

aeubanks created this revision. aeubanks added a reviewer: vitalybuka. Herald added a project: All. aeubanks requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This eagerly reports use of undef values when passed to noundef parameters or retur

[PATCH] D134669: [clang][msan] Turn on -fsanitize-memory-param-retval by default

aeubanks added a comment. hmm, looks like this breaks a bunch of msan tests with `-DLLVM_ENABLE_RUNTIMES=compiler-rt` and `ninja && ninja check-runtimes` MemorySanitizer-X86_64 :: Linux/swapcontext_annotation_reset.cpp MemorySanitizer-X86_64 :: bsearch.cpp MemorySanitizer-X86_64 :: chained

[PATCH] D133036: [InstCombine] Treat passing undef to noundef params as UB

aeubanks added a comment. In D133036#3816002 , @aeubanks wrote: > @vitalybuka can we turn on -fsanitize-memory-param-retval by default upstream? attempt in https://reviews.llvm.org/D134669 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

[PATCH] D134669: [clang][msan] Turn on -fsanitize-memory-param-retval by default

aeubanks added a comment. before looking into those, is it ok to proceed with this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134669/new/ https://reviews.llvm.org/D134669 ___ cfe-commits mailing list

[PATCH] D134544: [clang-cl] Implement /ZH: flag

dblaikie added inline comments. Comment at: clang/include/clang/Driver/Options.td:3220 Values<"simple,mangled">, Flags<[CC1Option, NoDriverOption]>; +def gsrc_hash_EQ : Joined<["-"], "gsrc-hash=">, + Group, Flags<[CC1Option, NoDriverOption]>, This is a dr

[PATCH] D133574: [C2x] reject type definitions in offsetof

nathanchance added a comment. In D133574#3815951 , @aaron.ballman wrote: > LGTM, thank you! Please don't land until you have some indication from the > kernel folks that this won't be super disruptive for them. CC > @nickdesaulniers and @nathanchance f

[PATCH] D134671: [Driver] Prevent Mips specific code from claiming -mabi argument on other targets.

craig.topper created this revision. craig.topper added reviewers: aaron.ballman, erichkeane. Herald added subscribers: StephenFan, atanasyan, arichardson, sdardis. Herald added a project: All. craig.topper requested review of this revision. Herald added a subscriber: MaskRay. Herald added a project

[PATCH] D133574: [C2x] reject type definitions in offsetof

nickdesaulniers added a comment. In D133574#3816066 , @nathanchance wrote: > In D133574#3815951 , @aaron.ballman > wrote: > >> LGTM, thank you! Please don't land until you have some indication from the >> kerne

[PATCH] D134235: [clang-doc] Clean up *Info constructors.

haowei added a comment. @brettw Thanks for the clarification. I was oncall for buildgardener last week and got quite busy due to breakages. Thanks for your clarification, that is really helpful to understand the your intent. While I still don't see the way these constructors are implemented is

[PATCH] D134673: [Driver][PS4] pass -fcrash-diagnostics-dir to LTO

ychen created this revision. ychen added a reviewer: probinson. Herald added a subscriber: inglorion. Herald added a project: All. ychen requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. Also refactor the existing code a little bit.

[PATCH] D130096: [Clang][AMDGPU] Emit AMDGPU library control constants in clang

arsenm added a comment. In D130096#3815529 , @jhuber6 wrote: > The best solution would be to handle these per-TU variables in the backend. > Or maybe even all of these could be placed in the backend where the code > paths that currently require a contro

[PATCH] D133705: [HIP] Fix unbundling archive

yaxunl marked an inline comment as done. yaxunl added inline comments. Comment at: clang/test/Driver/clang-offload-bundler.c:410-412 +// Check clang-offload-bundler extracts empty archives if the input file +// is not an archive when --allow-missing-bundles is specified, otherwis

[PATCH] D133705: [HIP] Fix unbundling archive

yaxunl updated this revision to Diff 463016. yaxunl marked an inline comment as done. yaxunl added a comment. check file magic and only unbundle real archives CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133705/new/ https://reviews.llvm.org/D133705 Files: clang/lib/Driver/Driver.cpp

[PATCH] D134673: [Driver][PS4] pass -fcrash-diagnostics-dir to LTO

probinson added a comment. I'm guessing the non-PS4 targets would also want this, so a similar change is needed in tools::addLTOOptions. This can be a separate patch if you wish. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134673/new/ https://r

[PATCH] D134673: [Driver][PS4] pass -fcrash-diagnostics-dir to LTO

ychen added a comment. In D134673#3816166 , @probinson wrote: > I'm guessing the non-PS4 targets would also want this, so a similar change is > needed in tools::addLTOOptions. This can be a separate patch if you wish. That's right. It was submitted htt

[PATCH] D133574: [C2x] reject type definitions in offsetof

aaron.ballman added a comment. In D133574#3816066 , @nathanchance wrote: > In D133574#3815951 , @aaron.ballman > wrote: > >> LGTM, thank you! Please don't land until you have some indication from the >> kernel

[clang] 0ca1051 - Check whether the allocated type is an array type before calling

Author: Akira Hatanaka Date: 2022-09-26T14:21:21-07:00 New Revision: 0ca1051bfc6e9548763f0a52641733393c33a427 URL: https://github.com/llvm/llvm-project/commit/0ca1051bfc6e9548763f0a52641733393c33a427 DIFF: https://github.com/llvm/llvm-project/commit/0ca1051bfc6e9548763f0a52641733393c33a427.diff

[PATCH] D134057: [clang][Interp] Start implementing record types

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from a minor nit, we can handle the other cases in follow-ups. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:642 + +for (const auto *Init

[PATCH] D133683: [c++] implements tentative DR1432 for partial ordering of function template

ychen updated this revision to Diff 463019. ychen added a comment. - update comments suggested by @mizvekov Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133683/new/ https://reviews.llvm.org/D133683 Files: clang/lib/Sema/SemaTemplateDeduction.cp

[PATCH] D133683: [c++] implements tentative DR1432 for partial ordering of function template

ychen added a comment. ping ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133683/new/ https://reviews.llvm.org/D133683 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D130096: [Clang][AMDGPU] Emit AMDGPU library control constants in clang

yaxunl added inline comments. Comment at: clang/lib/CodeGen/CodeGenAction.cpp:299-308 + if (!LinkModules.empty() && Gen->CGM().getTriple().isAMDGCN() && + !Gen->CGM().getLangOpts().GPURelocatableDeviceCode) { +const StringRef GVS[] = {"__oclc_daz_opt", "__oc

[PATCH] D134556: [Clang][OpenMP] Fix run time crash when use_device_addr is used.

jyu2 added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:8561-8617 for (const auto *Cl : Clauses) { const auto *C = dyn_cast(Cl); if (!C) continue; for (const auto L : C->component_lists()) { OMPClauseMappableExprCo

[PATCH] D134458: [AST] Add C++11 attribute 'msvc::no_unique_address'

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/Attr.td:3505 + let LangOpts = [MicrosoftExt]; + let Spellings = [CXX11<"msvc", "no_unique_address", 201803>]; + let Subjects = SubjectList<[NonBitField], ErrorDiag>; Does the `201803` v

[PATCH] D127910: [Clang][AArch64] Add SME C intrinsics for load and store

sagarkulkarni19 updated this revision to Diff 463023. sagarkulkarni19 added a comment. Update testcases by adding "arm_streaming" attribute to the callee. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127910/new/ https://reviews.llvm.org/D127910 F

[PATCH] D133711: [Sema] Reject array element types whose sizes aren't a multiple of their alignments

ahatanak added a comment. Fixed in 0ca1051bf . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133711/new/ https://reviews.llvm.org/D133711 ___

[PATCH] D134550: [Clang] Make Clang driver suggest '-Xclang' for CC1 options passed to the driver

aaron.ballman added a comment. In D134550#3813285 , @jyknight wrote: > In D134550#3813269 , @aaron.ballman > wrote: > >> Alternatively, perhaps those experimental options should be exposed from the >> driver ins

[PATCH] D134550: [Clang] Make Clang driver suggest '-Xclang' for CC1 options passed to the driver

jhuber6 added a comment. In D134550#3816239 , @aaron.ballman wrote: > In terms of this patch -- is there sentiment to revert (even temporarily > while we discuss)? I think alternatively we could just change the message to mention that the provided fla

[PATCH] D134677: [Clang][AArch64] Add SME zero intrinsic

sagarkulkarni19 created this revision. sagarkulkarni19 added reviewers: sdesmalen, rsandifo-arm, david-arm. sagarkulkarni19 added a project: clang. Herald added a subscriber: kristof.beyls. Herald added a project: All. sagarkulkarni19 requested review of this revision. Herald added a subscriber: cf

[PATCH] D134020: [clang][Interp] Handle enums

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134020/new/ https://reviews.llvm.org/D134020 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.o

[PATCH] D131172: [clang][llvm][doc] Add more information for the ABI change in FP16

mehdi_amini added inline comments. Comment at: clang/docs/ReleaseNotes.rst:633 +- If you are using downstream runtimes that provide FP16 conversions, update +them with the new ABI. + Can you add a link to a documentation that describe the new ABI? Repository:

[PATCH] D131172: [clang][llvm][doc] Add more information for the ABI change in FP16

mehdi_amini added inline comments. Comment at: llvm/docs/ReleaseNotes.rst:206 +When you find failures with ``half`` type, check the calling conversion of the +code and switch it to the new ABI. + (same here: users reading "switch it to the new ABI" will be confus

[PATCH] D134550: [Clang] Make Clang driver suggest '-Xclang' for CC1 options passed to the driver

aaron.ballman added a comment. In D134550#3816255 , @jhuber6 wrote: > In D134550#3816239 , @aaron.ballman > wrote: > >> In terms of this patch -- is there sentiment to revert (even temporarily >> while we discus

[PATCH] D133705: [HIP] Fix unbundling archive

tra accepted this revision. tra added a comment. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133705/new/ https://reviews.llvm.org/D133705 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/l

[PATCH] D133993: [HLSL] Remove global ctor/dtor variable for non-lib profile.

aaron.ballman edited reviewers, added: rjmccall, efriedma; removed: aaron.ballman. aaron.ballman added a comment. Switching up code reviewers for the codegen questions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133993/new/ https://reviews.llvm

[PATCH] D134671: [Driver] Prevent Mips specific code from claiming -mabi argument on other targets.

arichardson added inline comments. Comment at: clang/lib/Driver/Driver.cpp:637 // accordingly to provided ABI name. - A = Args.getLastArg(options::OPT_mabi_EQ); + A = Args.getLastArgNoClaim(options::OPT_mabi_EQ); if (A && Target.isMIPS()) { Would it make

[PATCH] D134678: [Clang][AArch64] Add SME ldr and str intrinsic

sagarkulkarni19 created this revision. sagarkulkarni19 added reviewers: sdesmalen, rsandifo-arm, david-arm. sagarkulkarni19 added a project: clang. Herald added a subscriber: kristof.beyls. Herald added a project: All. sagarkulkarni19 requested review of this revision. Herald added a subscriber: cf

[PATCH] D134679: [Clang][AArch64] Add SME svcntsb/h/w/d C intrinsics

sagarkulkarni19 created this revision. sagarkulkarni19 added reviewers: sdesmalen, rsandifo-arm, david-arm. sagarkulkarni19 added a project: clang. Herald added a subscriber: kristof.beyls. Herald added a project: All. sagarkulkarni19 requested review of this revision. Herald added a subscriber: cf

[PATCH] D134454: [Driver][Distro] Fix ArchLinux triplet and sysroot detection

nickdesaulniers requested changes to this revision. nickdesaulniers added a comment. This revision now requires changes to proceed. It's not clear to me why Arch is special here. The path may be different, but normalizing the triple seems unnecessary. Blocking this until I'm confident that we're

[PATCH] D134680: [Clang][AArch64] Add SME svaddha and svaddva intrinsics

sagarkulkarni19 created this revision. sagarkulkarni19 added reviewers: sdesmalen, david-arm, rsandifo-arm. sagarkulkarni19 added a project: clang. Herald added a subscriber: kristof.beyls. Herald added a project: All. sagarkulkarni19 requested review of this revision. Herald added a subscriber: cf

[PATCH] D134681: [Clang][AArch64] Add SME outer product intrinsics

sagarkulkarni19 created this revision. sagarkulkarni19 added reviewers: sdesmalen, rsandifo-arm, david-arm. sagarkulkarni19 added a project: clang. Herald added a subscriber: kristof.beyls. Herald added a project: All. sagarkulkarni19 requested review of this revision. Herald added a subscriber: cf

[PATCH] D134222: [clang][deps] Report module map describing compiled module

w2yehia added a comment. In D134222#3815956 , @jansvoboda11 wrote: > In D134222#3815793 , @w2yehia wrote: > >> @jansvoboda11 >> FYI, this is breaking AIX buildbot: >> https://lab.llvm.org/buildbot/#/builders/214

Re: [PATCH] D134235: [clang-doc] Clean up *Info constructors.

On Mon, Sep 26, 2022 at 1:42 PM Haowei Wu via Phabricator < revi...@reviews.llvm.org> wrote: > haowei added a comment. > > @brettw Thanks for the clarification. I was oncall for buildgardener last > week and got quite busy due to breakages. > > Thanks for your clarification, that is really helpful

[PATCH] D129802: [DRAFT] Implementing new atomic orderings in LLVM and generate barriers for legacy __sync builtins. Support corresponding memory model in outline atomics as well.

ilinpv added a comment. @sebpop could you ellaborate on __sync_* operations usage, are you getting issues with current Clang implementation? Do Clang need to keep supporting them and fix introducing new memory model? It seems we need compelling reasons to do that. >> However if sync primitives

[PATCH] D134235: [clang-doc] Clean up *Info constructors.

brettw added a comment. I can guarantee that nobody uses this for anything useful because it doesn't work well enough. For example, before I started changing it, requesting HTML output crashed on startup and many of the most basic syntactic things were broken. My previous patch changed enums fr

Re: [PATCH] D134235: [clang-doc] Clean up *Info constructors.

Please avoid directly replying to the email as they won't be logged in the phabricator. This boolean is logged into YAML output, while I don't have data, I could bet there will be users depending on it even if it looks so unlikely. We don't own the tool in the first place, in that case, I felt if

[PATCH] D134454: [Driver][Distro] Fix ArchLinux triplet and sysroot detection

MaskRay added a comment. I am nervous as well as Arch Linux has many derivatives. They likely don't use `ID=arch` in `/etc/os-release`. The patch won't work for them. The last few comments of https://discourse.llvm.org/t/rfc-adding-a-default-file-location-to-config-file-support/63606 discuss a

[PATCH] D134352: [AArch64] Add Neoverse V2 CPU support

paulwalker-arm accepted this revision. paulwalker-arm added inline comments. Comment at: clang/docs/ReleaseNotes.rst:376 them, which it cannot. +- Add driver and tuning support for Neoverse V2 support via the flag + ``-mcpu=neoverse-v2``. Native detection is also supported vi

[PATCH] D130096: [Clang][AMDGPU] Emit AMDGPU library control constants in clang

jhuber6 updated this revision to Diff 463042. jhuber6 added a comment. Adding test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130096/new/ https://reviews.llvm.org/D130096 Files: clang/lib/CodeGen/CodeGenAction.cpp clang/lib/CodeGen/CodeGenM

[PATCH] D132379: [Support] Class for response file expansion

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132379/new/ https://reviews.llvm.org/D132379 ___ cfe-c

[PATCH] D134671: [Driver] Prevent Mips specific code from claiming -mabi argument on other targets.

MaskRay added inline comments. Comment at: clang/test/Driver/mabi.c:1 +// RUN: %clang -target i386-unknown-linux -mabi=ms -S %s -### 2>&1 | FileCheck --check-prefix=CHECK %s + `-target ` is legacy. Use `--target=` Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D134669: [clang][msan] Turn on -fsanitize-memory-param-retval by default

vitalybuka added reviewers: thakis, hans, glider. vitalybuka added a comment. LGTM. I was thinking about this recently as well. Main inconvenience is users like Chromium. They have recompiled libraries. They will need to use -fno-sanitize-memory-param-retval, if recompiling is not an option. R

[PATCH] D134671: [Driver] Prevent Mips specific code from claiming -mabi argument on other targets.

craig.topper added inline comments. Comment at: clang/lib/Driver/Driver.cpp:637 // accordingly to provided ABI name. - A = Args.getLastArg(options::OPT_mabi_EQ); + A = Args.getLastArgNoClaim(options::OPT_mabi_EQ); if (A && Target.isMIPS()) { arichardson w

[PATCH] D134669: [clang][msan] Turn on -fsanitize-memory-param-retval by default

aeubanks added a comment. do you want the tests to all properly work with -fsanitize-memory-param-retval, or just pin them to -fno-sanitize-memory-param-retval if they're failing? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134669/new/ https://r

[PATCH] D133993: [HLSL] Remove global ctor/dtor variable for non-lib profile.

efriedma added a comment. Why are we using different mechanisms for global constructors in "libraries" vs. other code? If we need a mechanism in LLVM already, we might as well use it all the time? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133

[PATCH] D134456: [PGO] Consider parent context when weighing branches with likelyhood.

wenlei added a comment. There's also subtle difference between different variants of PGO. For instrumentation PGO where profile quality is higher, profile counts always take precedence. But for sampling PGO (AutoFDO, CSSPGO), it tries to not overwrite any existing branch weights, which means th

[PATCH] D134671: [Driver] Prevent Mips specific code from claiming -mabi argument on other targets.

craig.topper updated this revision to Diff 463049. craig.topper added a comment. Herald added subscribers: pcwang-thead, s.egerton, simoncook. Address review comments. I didn't test the -march because all of the target I'm familiar with use -march. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D134669: [clang][msan] Turn on -fsanitize-memory-param-retval by default

vitalybuka added a comment. In D134669#3816519 , @aeubanks wrote: > do you want the tests to all properly work with > -fsanitize-memory-param-retval, or just pin them to > -fno-sanitize-memory-param-retval if they're failing? I have some draft patch fo

[PATCH] D133993: [HLSL] Remove global ctor/dtor variable for non-lib profile.

python3kgae added a comment. In D133993#3816526 , @efriedma wrote: > Why are we using different mechanisms for global constructors in "libraries" > vs. other code? If we need a mechanism in LLVM already, we might as well use > it all the time? For lib

[PATCH] D134685: Fix SourceManager::isBeforeInTranslationUnit bug with token-pasting

sammccall created this revision. sammccall added reviewers: ilya-biryukov, hokein. Herald added subscribers: kadircet, arphaman. Herald added a project: All. sammccall requested review of this revision. Herald added projects: clang, clang-tools-extra. Herald added a subscriber: cfe-commits. isBefo

[clang] b2d7a0d - [AArch64] Check target feature support for __builtin_arm_crc*

Author: Fangrui Song Date: 2022-09-26T17:16:44-07:00 New Revision: b2d7a0dcf1ff1c08cac173f408843a8659c6f3cd URL: https://github.com/llvm/llvm-project/commit/b2d7a0dcf1ff1c08cac173f408843a8659c6f3cd DIFF: https://github.com/llvm/llvm-project/commit/b2d7a0dcf1ff1c08cac173f408843a8659c6f3cd.diff

[PATCH] D134235: [clang-doc] Clean up *Info constructors.

haowei added inline comments. Comment at: clang-tools-extra/clang-doc/BitcodeReader.cpp:336 Reference *I, FieldId &F) { switch (ID) { case REFERENCE_USR: This block ID came from L582, which read from a bitcode file when `BI_REFEREN

[PATCH] D134669: [clang][msan] Turn on -fsanitize-memory-param-retval by default

vitalybuka added inline comments. Comment at: clang/include/clang/Driver/Options.td:1767 MarshallingInfoEnum, "Global">; defm sanitize_memory_param_retval : BoolFOption<"sanitize-memory-param-retval", you need to update SanitizerArgs::MsanParamRetval

[PATCH] D134669: [clang][msan] Turn on -fsanitize-memory-param-retval by default

vitalybuka updated this revision to Diff 463058. vitalybuka added a comment. Herald added a subscriber: MaskRay. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134669/new/ https://reviews.llvm.org/D134669 Files: clang/include/clang/Driver/

[PATCH] D134669: [clang][msan] Turn on -fsanitize-memory-param-retval by default

aeubanks updated this revision to Diff 463061. aeubanks added a comment. add release notes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134669/new/ https://reviews.llvm.org/D134669 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Driver

[PATCH] D134687: [clang] Ensure correct metadata for relative vtables

leonardchan created this revision. leonardchan added reviewers: phosek, mcgrathr, tejohnson, pcc. leonardchan added a project: clang. Herald added a subscriber: Prazek. Herald added a project: All. leonardchan requested review of this revision. Prior to this, metadata pertaining to the size or add

[PATCH] D133574: [C2x] reject type definitions in offsetof

inclyc updated this revision to Diff 463063. inclyc added a comment. This revision fixes: **anonymous struct** > You should be able to pass in the TagDecl directly because the diagnostics > engine knows how to print a NamedDecl. I've switch back to using `Context.getTagDeclType(New)` because th

[PATCH] D86049: RFC: Implement optional exportable wrapper function generation for objc_direct methods.

plotfi updated this revision to Diff 463064. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86049/new/ https://reviews.llvm.org/D86049 Files: clang/include/clang/AST/DeclObjC.h clang/lib/AST/Mangle.cpp clang/lib/CodeGen/CGObjC.cpp clang/lib/C

[clang] f3e0298 - [NFC][Clang] Remove dead code

Author: Yuanfang Chen Date: 2022-09-26T18:32:52-07:00 New Revision: f3e02989e6e5d6fa90d5ac1ea21c592197a0ae7d URL: https://github.com/llvm/llvm-project/commit/f3e02989e6e5d6fa90d5ac1ea21c592197a0ae7d DIFF: https://github.com/llvm/llvm-project/commit/f3e02989e6e5d6fa90d5ac1ea21c592197a0ae7d.diff

[PATCH] D134688: MSVC AArch64 ABI: Homogeneous aggregates

dblaikie created this revision. dblaikie added reviewers: hansw, rnk. Herald added subscribers: mstorsjo, kristof.beyls. Herald added a project: All. dblaikie requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fixes: Protected members, HFA: ht

[PATCH] D134235: [clang-doc] Clean up *Info constructors.

brettw added inline comments. Comment at: clang-tools-extra/clang-doc/BitcodeReader.cpp:336 Reference *I, FieldId &F) { switch (ID) { case REFERENCE_USR: haowei wrote: > This block ID came from L582, which read from a bitcode file w

[PATCH] D134235: [clang-doc] Clean up *Info constructors.

haowei accepted this revision. haowei added a comment. This revision is now accepted and ready to land. LGTM @paulkirth Do you have more comments? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134235/new/ https://reviews.llvm.org/D134235 ___

[PATCH] D134235: [clang-doc] Clean up *Info constructors.

paulkirth accepted this revision. paulkirth added a comment. I'm good w/ this. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134235/new/ https://reviews.llvm.org/D134235 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lis

[PATCH] D134669: [clang][msan] Turn on -fsanitize-memory-param-retval by default

vitalybuka added a comment. diff --git a/clang/test/Driver/fsanitize-memory-param-retval.c b/clang/test/Driver/fsanitize-memory-param-retval.c index d82d20812186..79ade32178b6 100644 --- a/clang/test/Driver/fsanitize-memory-param-retval.c +++ b/clang/test/Driver/fsanitize-memory-param-ret

[clang] 1172bde - [HIP] Fix unbundling archive

Author: Yaxun (Sam) Liu Date: 2022-09-26T22:16:17-04:00 New Revision: 1172bdecfab364579d90e6aa5ba7fc64a5b96786 URL: https://github.com/llvm/llvm-project/commit/1172bdecfab364579d90e6aa5ba7fc64a5b96786 DIFF: https://github.com/llvm/llvm-project/commit/1172bdecfab364579d90e6aa5ba7fc64a5b96786.dif

[PATCH] D134693: [CMake] Add `CLANG_ENABLE_HLSL` CMake option

beanz created this revision. beanz added reviewers: phosek, smeenai, compnerd. Herald added a subscriber: Anastasia. Herald added a project: All. beanz requested review of this revision. Herald added a project: clang. The HLSL support in clang is in proress and not fully functioning. As such we do

[PATCH] D134694: Clean up isBeforeInTranslationUnit cache and add eviction.

sammccall created this revision. Herald added a project: All. sammccall requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Previously the first 300 entries would stay around forever, and any new queries would thrash on entry 301. The cache cod

<    1   2   3   >