[clang] 7cddf9c - [analyzer] Dump the environment entry kind as well

Author: Balazs Benics Date: 2022-09-13T09:04:27+02:00 New Revision: 7cddf9cad18a65217c8ba0661fefcf78d841a16b URL: https://github.com/llvm/llvm-project/commit/7cddf9cad18a65217c8ba0661fefcf78d841a16b DIFF: https://github.com/llvm/llvm-project/commit/7cddf9cad18a65217c8ba0661fefcf78d841a16b.diff

[PATCH] D132109: [analyzer] Dump the environment entry kind as well

This revision was automatically updated to reflect the committed changes. Closed by commit rG7cddf9cad18a: [analyzer] Dump the environment entry kind as well (authored by steakhal). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132109/new/ https://r

[PATCH] D132285: [Clang][LoongArch] Implement ABI lowering

SixWeining added a comment. ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132285/new/ https://reviews.llvm.org/D132285 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org

[PATCH] D133753: [clang][Interp] WIP: Array fillers

tbaeder created this revision. tbaeder added reviewers: erichkeane, aaron.ballman, shafik, tahonermann. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Uploading this now to get some early feedback on th

[PATCH] D132030: [analyzer] Pass correct bldrCtx to computeObjectUnderConstruction

tomasz-kaminski-sonarsource updated this revision to Diff 459666. tomasz-kaminski-sonarsource added a comment. Ping and reformat. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132030/new/ https://reviews.llvm.org/D132030 Files: clang/include/cla

[clang] fbfe1db - [clang] Explicitly set the EmulatedTLS codegen option. NFC.

Author: Martin Storsjö Date: 2022-09-13T10:40:54+03:00 New Revision: fbfe1db4a95a73ed6a0767db0ab7d449fc03405e URL: https://github.com/llvm/llvm-project/commit/fbfe1db4a95a73ed6a0767db0ab7d449fc03405e DIFF: https://github.com/llvm/llvm-project/commit/fbfe1db4a95a73ed6a0767db0ab7d449fc03405e.diff

[PATCH] D132916: [clang] Explicitly set the EmulatedTLS codegen option

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGfbfe1db4a95a: [clang] Explicitly set the EmulatedTLS codegen option. NFC. (authored by mstorsjo). Repository: rG LLVM Github Monorepo CHANGES SIN

[PATCH] D132848: [clang] Fix checking for emulated TLS in shouldAssumeDSOLocal in CodeGen

mstorsjo abandoned this revision. mstorsjo added a comment. Abandoned in favour of D132916 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132848/new/ https://reviews.llvm.org/D132848 _

[PATCH] D111283: [clang] template / auto deduction deduces common sugar

alexfh added a comment. In D111283#3785259 , @alexfh wrote: > In D111283#3785240 , @alexfh wrote: > >> In D111283#3783627 , @alexfh wrote: >> >>> Hi Matheus, an early head

[PATCH] D133756: [clangd] Introduce CompileCommandsAdjuster

nridge created this revision. nridge added reviewers: kadircet, sammccall. Herald added a subscriber: arphaman. Herald added a project: All. nridge requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Use it in

[PATCH] D133757: [clangd] Turn QueryDriverDatabase into a CompileCommandsAdjuster

nridge created this revision. nridge added reviewers: kadircet, sammccall. Herald added a subscriber: arphaman. Herald added a project: All. nridge requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. This allo

[PATCH] D133756: [clangd] Introduce CompileCommandsAdjuster

nridge added a comment. Herald added a subscriber: ormris. This is a refactoring in preparation for D133757 , please see that for motivation Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133756/new/ https://review

[PATCH] D133757: [clangd] Turn QueryDriverDatabase into a CompileCommandsAdjuster

nridge added a comment. Depends on https://reviews.llvm.org/D133756 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133757/new/ https://reviews.llvm.org/D133757 ___ cfe-commits mailing list cfe-commits@lis

[PATCH] D133757: [clangd] Turn QueryDriverDatabase into a CompileCommandsAdjuster

nridge added a comment. So far I've only written a test for https://github.com/clangd/clangd/issues/1089. I plan to add tests for the other two issues as well, but I thought I'd get the review ball rolling in the mean time to get feedback on the fix approach and test approach. Repository:

[PATCH] D133757: [clangd] Turn QueryDriverDatabase into a CompileCommandsAdjuster

nridge added inline comments. Comment at: clang-tools-extra/clangd/unittests/ClangdLSPServerTests.cpp:242 +CompileFlags: + Compiler: gcc + )yaml"; To exercise `QueryDriverDatabase`, this test assumes that the machine running the test will have a `gcc` somewher

[PATCH] D133647: [clang-format] Parse the else part of `#if 0`

owenpan accepted this revision. owenpan added a comment. This revision is now accepted and ready to land. Thanks! Comment at: clang/lib/Format/UnwrappedLineParser.cpp:1128 +// If the first branch is unreachable, set the BranchIndex to 1. This way +// the next branch it

[clang] bf3efa8 - [clang][Interp] Handle DeclRefExpr of reference types

Author: Timm Bäder Date: 2022-09-13T10:40:51+02:00 New Revision: bf3efa8b1622080b29b2dc4ba57bdccd0ca1e889 URL: https://github.com/llvm/llvm-project/commit/bf3efa8b1622080b29b2dc4ba57bdccd0ca1e889 DIFF: https://github.com/llvm/llvm-project/commit/bf3efa8b1622080b29b2dc4ba57bdccd0ca1e889.diff LO

[clang] 9b087a7 - [clang][Interp][NFC] Forward-declare Pointer in PrimType header

Author: Timm Bäder Date: 2022-09-13T10:40:52+02:00 New Revision: 9b087a70e66c785f64279634c536a848e78261ea URL: https://github.com/llvm/llvm-project/commit/9b087a70e66c785f64279634c536a848e78261ea DIFF: https://github.com/llvm/llvm-project/commit/9b087a70e66c785f64279634c536a848e78261ea.diff LO

[clang] f756ddb - [clang][Interp][NFC] InterpFrame: localBlock() can be const

Author: Timm Bäder Date: 2022-09-13T10:41:18+02:00 New Revision: f756ddba17c9f0f0ee49b45dd4b15b487aff9b67 URL: https://github.com/llvm/llvm-project/commit/f756ddba17c9f0f0ee49b45dd4b15b487aff9b67 DIFF: https://github.com/llvm/llvm-project/commit/f756ddba17c9f0f0ee49b45dd4b15b487aff9b67.diff LO

[clang] 5d24514 - [clang][Interp][NFC] InterpFrame::getLocal() can be const

Author: Timm Bäder Date: 2022-09-13T10:41:24+02:00 New Revision: 5d2451468c5f105bd7837f57c5e385fbbbdb65a4 URL: https://github.com/llvm/llvm-project/commit/5d2451468c5f105bd7837f57c5e385fbbbdb65a4 DIFF: https://github.com/llvm/llvm-project/commit/5d2451468c5f105bd7837f57c5e385fbbbdb65a4.diff LO

[PATCH] D132997: [clang][Interp] Handle DeclRefExpr of reference types

This revision was automatically updated to reflect the committed changes. Closed by commit rGbf3efa8b1622: [clang][Interp] Handle DeclRefExpr of reference types (authored by tbaeder). Changed prior to commit: https://reviews.llvm.org/D132997?vs=458662&id=459681#toc Repository: rG LLVM Github

[clang] 53d8687 - [clang][Interp][NFC] Use constexpr if in OffsetHelper

Author: Timm Bäder Date: 2022-09-13T10:41:34+02:00 New Revision: 53d8687a13e76b5a387e8df59ae231ab53ab9279 URL: https://github.com/llvm/llvm-project/commit/53d8687a13e76b5a387e8df59ae231ab53ab9279 DIFF: https://github.com/llvm/llvm-project/commit/53d8687a13e76b5a387e8df59ae231ab53ab9279.diff LO

[clang] b02f689 - [clang][Interp][NFC] InterpFrame::getParam can be const

Author: Timm Bäder Date: 2022-09-13T10:41:28+02:00 New Revision: b02f6890f52a48de6fc3a1d977a6ae50bc8fa984 URL: https://github.com/llvm/llvm-project/commit/b02f6890f52a48de6fc3a1d977a6ae50bc8fa984 DIFF: https://github.com/llvm/llvm-project/commit/b02f6890f52a48de6fc3a1d977a6ae50bc8fa984.diff LO

[clang] cd20a18 - Revert "[clang, llvm] Add __declspec(safebuffers), support it in CodeView"

Author: Sylvestre Ledru Date: 2022-09-13T10:53:59+02:00 New Revision: cd20a1828605887699579789b5433111d5bc0319 URL: https://github.com/llvm/llvm-project/commit/cd20a1828605887699579789b5433111d5bc0319 DIFF: https://github.com/llvm/llvm-project/commit/cd20a1828605887699579789b5433111d5bc0319.dif

[clang] 5a7764c - [OpenCL] Guard depth image builtins

Author: Sven van Haastregt Date: 2022-09-13T10:10:48+01:00 New Revision: 5a7764c9ff5db8c460b52bc2dec95d19df44d4c8 URL: https://github.com/llvm/llvm-project/commit/5a7764c9ff5db8c460b52bc2dec95d19df44d4c8 DIFF: https://github.com/llvm/llvm-project/commit/5a7764c9ff5db8c460b52bc2dec95d19df44d4c8.

[PATCH] D102494: [Clang, Driver] Default to Darwin_libsystem_m veclib on iOS based targets.

fhahn abandoned this revision. fhahn added a comment. Herald added a subscriber: MaskRay. Herald added a project: All. As of now, I don't think this is safe to do with the precision guarantees Darwin_libsystem_m provides unfortunately. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[PATCH] D133737: [HLSL] [clang] Add vector version of abs for HLSL

fhahn added a comment. I'm not familiar with HLSL but I think making use of the existing vector builtins makes sense here! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133737/new/ https://reviews.llvm.org/D133737

[PATCH] D133764: Honor cgroup limitation when running in parallel

dsilakov created this revision. dsilakov added a reviewer: steakhal. dsilakov added a project: clang. Herald added a subscriber: whisperity. Herald added a reviewer: NoQ. Herald added a project: All. dsilakov requested review of this revision. Herald added a subscriber: cfe-commits. cpu.cfs_quota_

[PATCH] D133578: [OpenMP] Add generation of SIMD align assumptions to OMPIRBuilder

domada updated this revision to Diff 459697. domada added a comment. Applied review remarks. Scope of changes: 1. replaced ArrayRef AlignedVars, Value * Alignment arguments with DenseMap. It allows to generate different alignment assumption for different variables. OpenMP allows to specify mult

[clang-tools-extra] 637da9d - Revert "[clang] template / auto deduction deduces common sugar"

Author: Alexander Kornienko Date: 2022-09-13T12:18:07+02:00 New Revision: 637da9de4c6619c0e179c2c2f0dbfebd08ac2a0f URL: https://github.com/llvm/llvm-project/commit/637da9de4c6619c0e179c2c2f0dbfebd08ac2a0f DIFF: https://github.com/llvm/llvm-project/commit/637da9de4c6619c0e179c2c2f0dbfebd08ac2a0f

[PATCH] D111283: [clang] template / auto deduction deduces common sugar

alexfh added a comment. I've reverted d200db38637884fd0b421802c6094b2a03ceb29e in 637da9de4c6619c0e179c2c2f0dbfebd08ac2a0f . And a bit more compact test ca

[PATCH] D133578: [OpenMP] Add generation of SIMD align assumptions to OMPIRBuilder

domada marked an inline comment as done. domada added inline comments. Comment at: llvm/include/llvm/Frontend/OpenMP/OMPIRBuilder.h:629 + llvm::ArrayRef AlignedVars, + llvm::Value *Alignment, Value *IfCond, ConstantInt *Simdlen, C

[PATCH] D111283: [clang] template / auto deduction deduces common sugar

mizvekov added a comment. Even simpler: template using P = T; template void j(P, T, A...); template void j(P, T); void g() { j(P{}, int{}); } Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111283/new/ https://reviews.llvm.org/D1112

[PATCH] D133589: [clang-format] JSON formatting add new option for controlling newlines in json arrays

MyDeveloperDay updated this revision to Diff 459712. MyDeveloperDay marked 4 inline comments as done. MyDeveloperDay added a comment. put back removed braces address other review comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133589/new/ https://reviews.llvm.org/D133589 Files:

[PATCH] D133756: [clangd] Introduce CompileCommandsAdjuster

tom-anders added inline comments. Comment at: clang-tools-extra/clangd/indexer/IndexerMain.cpp:150-151 clang::tooling::ArgumentsAdjuster( - clang::clangd::CommandMangler::detect())); + [Mangler = std::shared_ptr( + clang::clangd::CommandMang

[clang] 7f57b64 - [OpenMP] Extend lit test for parallel for simd construct

Author: Animesh Kumar Date: 2022-09-13T17:07:11+05:30 New Revision: 7f57b646d1501fedb21cfe8e02d5ede243ac51b1 URL: https://github.com/llvm/llvm-project/commit/7f57b646d1501fedb21cfe8e02d5ede243ac51b1 DIFF: https://github.com/llvm/llvm-project/commit/7f57b646d1501fedb21cfe8e02d5ede243ac51b1.diff

[PATCH] D132643: [OpenMP] Extend lit test for parallel for simd construct

This revision was automatically updated to reflect the committed changes. Closed by commit rG7f57b646d150: [OpenMP] Extend lit test for parallel for simd construct (authored by animeshk-amd). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132643/new/

[PATCH] D133726: [OpenMP][AMDGPU] Link bitcode ROCm device libraries per-TU

jhuber6 updated this revision to Diff 459716. jhuber6 added a comment. Renaming virtual function to make it more generic. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133726/new/ https://reviews.llvm.org/D133726 Files: clang/include/clang/Drive

[clang] 1b19df1 - Correct the __has_c_attribute value for nodiscard

Author: Aaron Ballman Date: 2022-09-13T08:13:01-04:00 New Revision: 1b19df12b84a7045f75e34009a3a7ff44f599375 URL: https://github.com/llvm/llvm-project/commit/1b19df12b84a7045f75e34009a3a7ff44f599375 DIFF: https://github.com/llvm/llvm-project/commit/1b19df12b84a7045f75e34009a3a7ff44f599375.diff

[PATCH] D133771: Add a "Potentially Breaking Changes" section to the Clang release notes

aaron.ballman created this revision. aaron.ballman added reviewers: tstellar, mgorny, jyknight. Herald added a project: All. aaron.ballman requested review of this revision. Herald added a project: clang. Sometimes we make changes to the compiler that we expect may cause disruption for users. For

[PATCH] D133771: Add a "Potentially Breaking Changes" section to the Clang release notes

aaron.ballman added a subscriber: thieta. aaron.ballman added a comment. @tstellar or @thieta -- will this cause any problems for your release scripts? (Note I used `Clang |release|` in the new wording; I can pull the `|release|` bit out if that's a problem.) Also, do you suppose there's a way w

[PATCH] D133726: [OpenMP][AMDGPU] Link bitcode ROCm device libraries per-TU

jhuber6 updated this revision to Diff 459721. jhuber6 added a comment. Adding a test for using `-nogpulib`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133726/new/ https://reviews.llvm.org/D133726 Files: clang/include/clang/Driver/ToolChain.h

[PATCH] D111283: [clang] template / auto deduction deduces common sugar

davrec added inline comments. Comment at: clang/lib/AST/ASTContext.cpp:12367 + case Type::Class: \ +llvm_unreachable("Unexpected " Kind ": " #Class); + Could we just return `X` here? Would that just

[PATCH] D111283: [clang] template / auto deduction deduces common sugar

mizvekov added inline comments. Comment at: clang/lib/AST/ASTContext.cpp:12367 + case Type::Class: \ +llvm_unreachable("Unexpected " Kind ": " #Class); + davrec wrote: > Could we just return `X` her

[PATCH] D111283: [clang] template / auto deduction deduces common sugar

mizvekov edited the summary of this revision. mizvekov updated this revision to Diff 459725. Herald added subscribers: mstorsjo, arichardson. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111283/new/ https://reviews.llvm.org/D111283 Files: clang-t

[PATCH] D111283: [clang] template / auto deduction deduces common sugar

mizvekov updated this revision to Diff 459726. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111283/new/ https://reviews.llvm.org/D111283 Files: clang-tools-extra/clangd/unittests/ASTTests.cpp clang-tools-extra/clangd/unittests/HoverTests.cpp

[PATCH] D111283: [clang] template / auto deduction deduces common sugar

davrec added inline comments. Comment at: clang/lib/AST/ASTContext.cpp:12367 + case Type::Class: \ +llvm_unreachable("Unexpected " Kind ": " #Class); + mizvekov wrote: > davrec wrote: > > Could we j

[PATCH] D133757: [clangd] Turn QueryDriverDatabase into a CompileCommandsAdjuster

kadircet added a comment. thanks, i agree that we should make query driver work coherently with `CompileFlags.Compiler`, but I am not sure if we really need to complexity for handling this adjustment logic before resolving the driver. I've got some comments right next to the change but to summa

[PATCH] D131469: [Clang] change default storing path of `-ftime-trace`

dongjunduo added a comment. @MaskRay ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131469/new/ https://reviews.llvm.org/D131469 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.

[PATCH] D133338: [clang][PowerPC] PPC64 VAArg use coerced integer type for direct aggregate fits in register

uweigand added a comment. This LGTM now, but maybe some of the PowerPC reviewers would like to comment as well. @nemanjai ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D18/new/ https://reviews.llvm.org/D18 __

[PATCH] D111283: [clang] template / auto deduction deduces common sugar

mizvekov added inline comments. Comment at: clang/lib/AST/ASTContext.cpp:12367 + case Type::Class: \ +llvm_unreachable("Unexpected " Kind ": " #Class); + davrec wrote: > mizvekov wrote: > > davrec w

[PATCH] D133773: [clang] fix linker executable path in test

ashay-github created this revision. ashay-github added reviewers: alvinhochun, rnk, mstorsjo, stella.stamenova. Herald added a project: All. ashay-github requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. A previous patch (https://reviews.llvm

[clang] 0f28cf4 - Correct the __has_c_attribute value for maybe_unused

Author: Aaron Ballman Date: 2022-09-13T09:33:20-04:00 New Revision: 0f28cf416d00a0fa0cb6cf572dd7ebbc19529190 URL: https://github.com/llvm/llvm-project/commit/0f28cf416d00a0fa0cb6cf572dd7ebbc19529190 DIFF: https://github.com/llvm/llvm-project/commit/0f28cf416d00a0fa0cb6cf572dd7ebbc19529190.diff

[clang] 843d074 - Update the C Status page for the Clang 15 release

Author: Aaron Ballman Date: 2022-09-13T09:36:54-04:00 New Revision: 843d074400fe9868329e870d6423728333cc7e1a URL: https://github.com/llvm/llvm-project/commit/843d074400fe9868329e870d6423728333cc7e1a DIFF: https://github.com/llvm/llvm-project/commit/843d074400fe9868329e870d6423728333cc7e1a.diff

[PATCH] D111283: [clang] template / auto deduction deduces common sugar

davrec added inline comments. Comment at: clang/lib/AST/ASTContext.cpp:12367 + case Type::Class: \ +llvm_unreachable("Unexpected " Kind ": " #Class); + mizvekov wrote: > davrec wrote: > > mizvekov w

[PATCH] D111509: [clang] use getCommonSugar in an assortment of places

mizvekov marked an inline comment as not done. mizvekov added a subscriber: davrec. mizvekov added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:1091-1150 +QualType fpTy = ComplexTy->castAs()->getElementType(); IntExpr = S.ImpCastExprToType(IntExpr.get(), fpTy

[PATCH] D133664: [clangd] Fix hover on symbol introduced by using declaration

kadircet added inline comments. Comment at: clang-tools-extra/clangd/Hover.cpp:1091 +// better, which in this example would be the actual declaration of foo. +auto *DeclToUse = Decls.begin(); +while (llvm::isa(*DeclToUse) && we actually w

[PATCH] D133771: Add a "Potentially Breaking Changes" section to the Clang release notes

mgorny accepted this revision. mgorny added a comment. This revision is now accepted and ready to land. I think this is a good idea — thanks for doing this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133771/new/ https://reviews.llvm.org/D133771

[PATCH] D133338: [clang][PowerPC] PPC64 VAArg use coerced integer type for direct aggregate fits in register

nemanjai added a comment. I am not crazy about adding the Boolean parameter here or about the name. Seems somewhat unclear when a caller wants to pass `true` there. What I think would be a more robust solution would be to use the same logic that decides whether to coerce the struct argument to

[PATCH] D133771: Add a "Potentially Breaking Changes" section to the Clang release notes

thesamesam accepted this revision. thesamesam added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133771/new/ https://reviews.llvm.org/D133771 ___ cfe-commits mailing list cfe-commits@

[PATCH] D132913: [HLSL] Preserve vec3 for HLSL.

alexgatea reopened this revision. alexgatea added a comment. This revision is now accepted and ready to land. This test fails because the actual output has <3 x float>* rather than ptr. Could you please fix this test case? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https

[PATCH] D133771: Add a "Potentially Breaking Changes" section to the Clang release notes

tschuett added a comment. The LLD release notes always refer to the Diff where the change was introduced. It is kind of sad that we loose all the discussions when we move to GitHub PRs. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133771/new/ htt

[PATCH] D133641: [Clang] [Sema] Ignore invalid multiversion function redeclarations

tahonermann accepted this revision. tahonermann added a comment. This revision is now accepted and ready to land. Thank you, this looks good to me! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133641/new/ https://reviews.llvm.org/D133641

[PATCH] D133773: [clang] fix linker executable path in test

alvinhochun added a comment. Ah sorry about that, I didn't realize the command includes `.exe` on Windows. (For the record, `ld"` matches both `ld` and `ld.lld`.) Comment at: clang/test/Driver/mingw-cfguard.c:6 // NO_CF-NOT: "-cfguard-no-checks" -// NO_CF-NEXT: ld" +// NO_CF-

[PATCH] D133726: [OpenMP][AMDGPU] Link bitcode ROCm device libraries per-TU

yaxunl added inline comments. Comment at: clang/lib/Driver/ToolChains/AMDGPU.cpp:717 AMDGPUToolChain::getGPUArch(const llvm::opt::ArgList &DriverArgs) const { - return getProcessorFromTargetID( - getTriple(), DriverArgs.getLastArgValue(options::OPT_mcpu_EQ)); + if (Driver

[PATCH] D111509: [clang] use getCommonSugar in an assortment of places

davrec added a comment. The lines you changed (clang/lib/Sema/SemaExpr.cpp:1091-1150) look good (IIUC you just change cast to cast_as and dyn_cast to getAs, and reorganize for clarity). I suggested some renaming and a few more comments to further clarify. Comment at: clang/l

[PATCH] D111509: [clang] use getCommonSugar in an assortment of places

davrec added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:1113-1114 +// "double _Complex" is promoted to "long double _Complex". +static QualType handleComplexFloatConversion(Sema &S, ExprResult &LHS, + QualType LHSType, Qua

[clang] b8266f5 - Correct the __has_c_attribute value for fallthrough

Author: Aaron Ballman Date: 2022-09-13T11:08:58-04:00 New Revision: b8266f512a6218e8319379b65a637fa82b3900f6 URL: https://github.com/llvm/llvm-project/commit/b8266f512a6218e8319379b65a637fa82b3900f6 DIFF: https://github.com/llvm/llvm-project/commit/b8266f512a6218e8319379b65a637fa82b3900f6.diff

[PATCH] D133726: [OpenMP][AMDGPU] Link bitcode ROCm device libraries per-TU

jhuber6 added inline comments. Comment at: clang/lib/Driver/ToolChains/AMDGPU.cpp:717 AMDGPUToolChain::getGPUArch(const llvm::opt::ArgList &DriverArgs) const { - return getProcessorFromTargetID( - getTriple(), DriverArgs.getLastArgValue(options::OPT_mcpu_EQ)); + if (Drive

[PATCH] D133771: Add a "Potentially Breaking Changes" section to the Clang release notes

sylvestre.ledru added inline comments. Comment at: clang/docs/ReleaseNotes.rst:49 + present in major C++ implementations (including Clang), this error has the + ability to be downgraded into a warning (via: -Wno-error=enum-constexpr-conversion) + to provide a transition perio

[PATCH] D133773: [clang] fix linker executable path in test

mstorsjo added a comment. In D133773#3786484 , @alvinhochun wrote: > Ah sorry about that, I didn't realize the command includes `.exe` on Windows. > (For the record, `ld"` matches both `ld` and `ld.lld`.) No, iirc these quotes are checked as literal pa

[PATCH] D133726: [OpenMP][AMDGPU] Link bitcode ROCm device libraries per-TU

arsenm added a comment. Does this fix the weird behavior where you needed to use -lm to use anything in the device libraries? I don't see that being removed Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133726/new/ https://reviews.llvm.org/D133726

[PATCH] D111283: [clang] template / auto deduction deduces common sugar

vhscampos added a comment. For reference, another small reproducer of the crash, but with a different stack trace than the first example posted here: // Must compile with -std=c++03 to crash #include int main(int, char**) { int i[3] = {1, 2, 3}; int j[3] = {4, 5, 6}; std:

[PATCH] D133773: [clang] fix linker executable path in test

alvinhochun added a comment. In D133773#3786602 , @mstorsjo wrote: > In D133773#3786484 , @alvinhochun > wrote: > >> Ah sorry about that, I didn't realize the command includes `.exe` on >> Windows. (For the reco

[PATCH] D133726: [OpenMP][AMDGPU] Link bitcode ROCm device libraries per-TU

jhuber6 added a comment. In D133726#3786607 , @arsenm wrote: > Does this fix the weird behavior where you needed to use -lm to use anything > in the device libraries? I don't see that being removed That was removed earlier when these files were just sen

[PATCH] D133726: [OpenMP][AMDGPU] Link bitcode ROCm device libraries per-TU

yaxunl added inline comments. Comment at: clang/lib/Driver/ToolChains/AMDGPU.cpp:717 AMDGPUToolChain::getGPUArch(const llvm::opt::ArgList &DriverArgs) const { - return getProcessorFromTargetID( - getTriple(), DriverArgs.getLastArgValue(options::OPT_mcpu_EQ)); + if (Driver

[PATCH] D133773: [clang] fix linker executable path in test

mstorsjo added a comment. In D133773#3786611 , @alvinhochun wrote: > In D133773#3786602 , @mstorsjo > wrote: > >> In D133773#3786484 , @alvinhochun >> wrote: >> >>> Ah

[PATCH] D133726: [OpenMP][AMDGPU] Link bitcode ROCm device libraries per-TU

jhuber6 added inline comments. Comment at: clang/lib/Driver/ToolChains/AMDGPU.cpp:717 AMDGPUToolChain::getGPUArch(const llvm::opt::ArgList &DriverArgs) const { - return getProcessorFromTargetID( - getTriple(), DriverArgs.getLastArgValue(options::OPT_mcpu_EQ)); + if (Drive

[PATCH] D132913: [HLSL] Preserve vec3 for HLSL.

python3kgae added a comment. In D132913#3786432 , @alexgatea wrote: > This test fails because the actual output has <3 x float>* rather than ptr. > Could you please fix this test case? Thanks for reporting the issue. But I cannot repro the fail. Do you

[PATCH] D111283: [clang] template / auto deduction deduces common sugar

mizvekov added inline comments. Comment at: clang/lib/AST/ASTContext.cpp:12367 + case Type::Class: \ +llvm_unreachable("Unexpected " Kind ": " #Class); + davrec wrote: > mizvekov wrote: > > davrec w

[PATCH] D111283: [clang] template / auto deduction deduces common sugar

mizvekov added a comment. @alexfh This new revision that I just pushed should be good. Do you want to give it a look / test, or should we go ahead and merge it? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111283/new/ https://reviews.llvm.org/D11

[PATCH] D132913: [HLSL] Preserve vec3 for HLSL.

alexgatea added a comment. > Thanks for reporting the issue. > But I cannot repro the fail. > Do you mind sharing your cmake command? Hmm, I'm just running the command in the test case: clang --driver-mode=dxc -Tlib_6_7 -fcgl -Fo - clang/test/CodeGenHLSL/float3.hlsl | FileCheck clang/test/Code

[PATCH] D133773: [clang] fix linker executable path in test

ashay-github updated this revision to Diff 459771. ashay-github added a comment. Thanks! I updated the regex to be `ld{{.*}}"`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133773/new/ https://reviews.llvm.org/D133773 Files: clang/test/Driver/

[PATCH] D111283: [clang] template / auto deduction deduces common sugar

mizvekov added a comment. In D111283#3786610 , @vhscampos wrote: > For reference, another small reproducer of the crash, but with a different > stack trace than the first example posted here: > > // Must compile with -std=c++03 to crash > #include >

[PATCH] D132913: [HLSL] Preserve vec3 for HLSL.

python3kgae added a comment. In D132913#3786679 , @alexgatea wrote: >> Thanks for reporting the issue. >> But I cannot repro the fail. >> Do you mind sharing your cmake command? > > Hmm, I'm just running the command in the test case: > clang --driver-mode

[PATCH] D133711: [Sema] Reject array element types whose alignments are larger than their sizes

rnk added a comment. Usually the solution is to round up the size to the alignment. Can you provide godbolt examples of what GCC and MSVC do? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133711/new/ https://reviews.llvm.org/D133711 _

[PATCH] D128750: [C++20] Implement P2113R0: Changes to the Partial Ordering of Constrained Functions

mizvekov added inline comments. Comment at: clang/include/clang/Sema/SemaConcept.h:54-68 + if (ArgA.getKind() == TemplateArgument::Type && + ArgB.getKind() == TemplateArgument::Type) +if (const auto *SubstA = +ArgA.getAsType()->getAs()) +

[PATCH] D133711: [Sema] Reject array element types whose alignments are larger than their sizes

efriedma added a comment. > Usually the solution is to round up the size to the alignment. Can you > provide godbolt examples of what GCC and MSVC do? gcc prints a similar error, MSVC doesn't support an equivalent alignment attribute. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D133726: [OpenMP][AMDGPU] Link bitcode ROCm device libraries per-TU

yaxunl added inline comments. Comment at: clang/lib/Driver/ToolChains/AMDGPU.cpp:717 AMDGPUToolChain::getGPUArch(const llvm::opt::ArgList &DriverArgs) const { - return getProcessorFromTargetID( - getTriple(), DriverArgs.getLastArgValue(options::OPT_mcpu_EQ)); + if (Driver

[PATCH] D133726: [OpenMP][AMDGPU] Link bitcode ROCm device libraries per-TU

JonChesterfield added a comment. march for openmp, mcpu for hip seems ok. Notably llc needs to be told this as well, using mcpu, which may be an issue for save-temps Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133726/new/ https://reviews.llvm.or

[PATCH] D133108: [clang] Rework IsTailPaddedMemberArray into isFlexibleArrayMemberExpr

msebor added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:15969 + if (const MemberExpr *ME = dyn_cast(BaseExpr)) +ND = ME->getMemberDecl(); + I'm not familiar with this code but I'm guessing that at most one of the `if` conditionals is true,

[PATCH] D133726: [OpenMP][AMDGPU] Link bitcode ROCm device libraries per-TU

jhuber6 updated this revision to Diff 459786. jhuber6 added a comment. Removing use of `getGPUArch` and just using `-march` directly for OpenMP Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133726/new/ https://reviews.llvm.org/D133726 Files: cla

[PATCH] D133249: [libc++] Documents details of the pre-commit CI.

ldionne accepted this revision. ldionne added a comment. This revision is now accepted and ready to land. LGTM w/ comments. Thanks a lot for writing this! Comment at: clang/www/hacking.html:279 + + Some changes in Clang affect https://libcxx.llvm.org";>libc++, + for example:

[PATCH] D133773: [clang] fix linker executable path in test

ashay-github updated this revision to Diff 459791. ashay-github added a comment. Updated the regex to `ld{{(.lld)?}}{{(.exe)?}}"`, so that it matches the following sequences: `ld`, `ld.lld`, `ld.exe`, `ld.lld.exe`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[PATCH] D131939: [clang-tidy] Add performance-expensive-flat-container-operation check

nicovank added a comment. Mid-CppCon ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131939/new/ https://reviews.llvm.org/D131939 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists

[PATCH] D133771: Add a "Potentially Breaking Changes" section to the Clang release notes

MaskRay accepted this revision. MaskRay added inline comments. Herald added a subscriber: StephenFan. Comment at: clang/docs/ReleaseNotes.rst:49 + present in major C++ implementations (including Clang), this error has the + ability to be downgraded into a warning (via: -Wno-er

[PATCH] D133737: [HLSL] [clang] Add vector version of abs for HLSL

beanz added a comment. In D133737#3785987 , @fhahn wrote: > I'm not familiar with HLSL but I think making use of the existing vector > builtins makes sense here! Does it make sense to be using the vector builtin for non-vectors? Repository: rG LLVM

[PATCH] D127910: [Clang][AArch64] Add SME C intrinsics for load and store

sagarkulkarni19 updated this revision to Diff 459803. sagarkulkarni19 added a comment. - Support Opaque pointers - Correct predicate types for the intrinsics. - Decorate intrinsics with SME attributes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1

[PATCH] D133737: [HLSL] [clang] Add vector version of abs for HLSL

RKSimon added a comment. The elementwise builtins should work for scalars as well (and IIRC we do test this as well). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133737/new/ https://reviews.llvm.org/D133737 _

[PATCH] D128845: [HLSL]Add -O and -Od option for dxc mode.

beanz added inline comments. Comment at: clang/include/clang/Basic/TargetOptions.h:120 + /// Keep the information about disable optimization for ShaderFlags. + bool DxcOptDisable = false; }; If `Od` and `O0` are the same you shouldn't need to track this, or ha

  1   2   3   >