[PATCH] D133589: [clang-format] JSON formatting add new option for controlling newlines in json arrays

MyDeveloperDay updated this revision to Diff 459408. MyDeveloperDay added a comment. - address review comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133589/new/ https://reviews.llvm.org/D133589 Files: clang/docs/ClangFormatStyleOptions.rst clang/include/clang/Format/Format.

[PATCH] D133589: [clang-format] JSON formatting add new option for controlling newlines in json arrays

MyDeveloperDay marked 6 inline comments as done. MyDeveloperDay added inline comments. Comment at: clang/include/clang/Format/Format.h:2076 + /// \version 16 + bool BreakArrays; + HazardyKnusperkeks wrote: > HazardyKnusperkeks wrote: > > Please sort. > What abo

[PATCH] D133571: [clang-format] Introduce NoFallThrough option into AllowShortCaseLabelsOnASingleLine

MyDeveloperDay marked an inline comment as done. MyDeveloperDay added inline comments. Comment at: clang/include/clang/Format/Format.h:469 + /// Different styles for merging short case labels. + enum ShortCaseLabelStyle : int8_t { +/// Never merge case code

[PATCH] D133589: [clang-format] JSON formatting add new option for controlling newlines in json arrays

owenpan accepted this revision. owenpan added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Format/TokenAnnotator.cpp:4403-4404 +// Always break after a JSON array opener based on BreakArrays. if (Left.is(TT_ArrayInitializerLSqua

[PATCH] D132643: [OpenMP] Extend lit test for parallel for simd construct

animeshk-amd added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132643/new/ https://reviews.llvm.org/D132643 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.or

[PATCH] D133683: [c++] implements tentative DR1432 for partial ordering of function template

ychen created this revision. ychen added reviewers: aaron.ballman, erichkeane. Herald added a project: All. ychen requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. D128745 handled DR1432 for the partial ord

[PATCH] D133635: [clang-format] Don't insert braces for loops with a null statement

owenpan added a comment. In D133635#378 , @MyDeveloperDay wrote: > Can't tell you how much I love this `InsertBraces` feature @owenpan, I work > for a team (with a large code base) that uses them all the time, and we are > catching missing braces

[clang] 5889ed8 - [clang-format] Don't insert braces for loops with a null statement

Author: owenca Date: 2022-09-12T00:37:47-07:00 New Revision: 5889ed83a0ffa71f2cf010b73bbbf210f9690778 URL: https://github.com/llvm/llvm-project/commit/5889ed83a0ffa71f2cf010b73bbbf210f9690778 DIFF: https://github.com/llvm/llvm-project/commit/5889ed83a0ffa71f2cf010b73bbbf210f9690778.diff LOG: [

[PATCH] D133635: [clang-format] Don't insert braces for loops with a null statement

This revision was automatically updated to reflect the committed changes. Closed by commit rG5889ed83a0ff: [clang-format] Don't insert braces for loops with a null statement (authored by owenpan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133635/

[PATCH] D133659: [Clang] P1169R4: static operator()

royjacobson updated this revision to Diff 459413. royjacobson added a comment. Fix test after warning text change Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133659/new/ https://reviews.llvm.org/D133659 Files: clang/docs/ReleaseNotes.rst cla

[PATCH] D133659: [Clang] P1169R4: static operator()

royjacobson updated this revision to Diff 459414. royjacobson added a comment. format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133659/new/ https://reviews.llvm.org/D133659 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Basic/Diagn

[PATCH] D111283: [clang] template / auto deduction deduces common sugar

mizvekov added a comment. In D111283#3783250 , @ychen wrote: > Hi @mizvekov , I noticed that deduction for partial ordering also inherits > this new behavior. Do you think partial ordering could opt out of this, or is > it better for partial ordering to

[PATCH] D127403: [clangd] Implement semantic token modifier "definition"

ckandeler added inline comments. Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:863 + Tok.addModifier(HighlightingModifier::Declaration); +if (const auto Func = dyn_cast(Decl)) { + if (Func->isThisDeclarationADefinition())

[PATCH] D133194: rewording note note_constexpr_invalid_cast

This revision was automatically updated to reflect the committed changes. Closed by commit rGea26ed1f9c37: Rewording note note_constexpr_invalid_cast (authored by Codesbyusman, committed by aaron.ballman). Changed prior to commit: https://reviews.llvm.org/D133194?vs=459296&id=459422#toc Reposi

[clang] ea26ed1 - Rewording note note_constexpr_invalid_cast

Author: Muhammad Usman Shahid Date: 2022-09-12T07:47:39-04:00 New Revision: ea26ed1f9c37465e0123c3357e459dd819c7d402 URL: https://github.com/llvm/llvm-project/commit/ea26ed1f9c37465e0123c3357e459dd819c7d402 DIFF: https://github.com/llvm/llvm-project/commit/ea26ed1f9c37465e0123c3357e459dd819c7d4

[clang] f0403c8 - Fix build of Lex unit test with CLANG_DYLIB

Author: Jonas Hahnfeld Date: 2022-09-12T13:49:57+02:00 New Revision: f0403c853bc93fe1127fef7493a4feff1479191e URL: https://github.com/llvm/llvm-project/commit/f0403c853bc93fe1127fef7493a4feff1479191e DIFF: https://github.com/llvm/llvm-project/commit/f0403c853bc93fe1127fef7493a4feff1479191e.diff

[PATCH] D131469: [Clang] change default storing path of `-ftime-trace`

dongjunduo updated this revision to Diff 459423. dongjunduo added a comment. fix related nits Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131469/new/ https://reviews.llvm.org/D131469 Files: clang/lib/Driver/Driver.cpp clang/test/Driver/check

[PATCH] D133668: [HLSL] Use _BitInt(16) for int16_t to avoid promote to int.

aaron.ballman added a comment. In D133668#3783090 , @beanz wrote: > HLSL deviates from C here. HLSL doesn't actually have `short` (although I'm > actually not sure we should disable it in Clang). We do have `int16_t`, but > we don't promote `int16_t` to

[PATCH] D131469: [Clang] change default storing path of `-ftime-trace`

dongjunduo added a comment. In D131469#3775741 , @MaskRay wrote: > I appreciate the detailed summary. It has sufficient information but I think > it can be rephased to be conciser. > I request changes for the verbosity and the possibly functionality issu

[PATCH] D133088: [Clang] Reword diagnostic for scope identifier with linkage

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133088/new/ https://reviews.llvm.org/D133088 _

[PATCH] D133052: [clang] Avoid crash when expanding conversion templates in concepts.

luken-google added a comment. Friendly ping on this, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133052/new/ https://reviews.llvm.org/D133052 ___ cfe-commits mailing list cfe-commits@lists.llvm

[PATCH] D133574: [C2x] reject type definitions in offsetof

aaron.ballman added a comment. In D133574#3781907 , @inclyc wrote: > Use RAII object to maintain the Parser state > >> have you explored making a new DeclSpecContext and modifying >> isDefiningTypeSpecifierContext()? I think that would likely be a cleane

[PATCH] D133634: [clang] Allow vector of BitInt

aaron.ballman added a reviewer: erichkeane. aaron.ballman added a subscriber: erichkeane. aaron.ballman added a comment. In D133634#3783160 , @python3kgae wrote: > In D133634#3782999 , @xbolva00 > wrote: > >> Mi

[PATCH] D111283: [clang] template / auto deduction deduces common sugar

alexfh added a comment. Hi Matheus, an early heads up: this commit is causing clang crashes on some of our code. I'll post more details a bit later. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111283/new/ https://reviews.llvm.org/D111283 __

[PATCH] D133694: [Clang][OpenMP] Fix use_device_addr

doru1004 created this revision. Herald added subscribers: guansong, yaxunl. Herald added a project: All. doru1004 requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. With the current implementation,

[PATCH] D131688: [clang][dataflow][NFC] Remove LatticeJoinEffect from framework interfaces

ymandel added a comment. In D131688#3716467 , @xazax.hun wrote: > Returning whether the lattice was changed can be a nice optimization when > comparing lattice elements is expensive. On the other hand, it can be one > more source of errors. I am fine wi

[PATCH] D133698: [clang][dataflow] SignAnalysis, edgeTransfer, branchTransfer

martong created this revision. martong added reviewers: xazax.hun, gribozavr2, sgatev, ymandel, samestep. Herald added subscribers: steakhal, gamesh411, Szelethus, dkrupp, rnkovacs, mgorny. Herald added a reviewer: Szelethus. Herald added a reviewer: NoQ. Herald added a project: All. martong reque

[PATCH] D133694: [Clang][OpenMP] Fix use_device_addr

doru1004 updated this revision to Diff 459452. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133694/new/ https://reviews.llvm.org/D133694 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp clang/lib/CodeGen/CGStmtOpenMP.cpp clang/test/OpenMP/target_data_use_device_addr_codegen_ptr.cpp

[PATCH] D133298: [clang-rename] RecursiveSymbolVisitor - visit namespace aliases and using directives

imctrading added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133298/new/ https://reviews.llvm.org/D133298 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 1d51bb8 - [Clang] Reword diagnostic for scope identifier with linkage

Author: Jun Zhang Date: 2022-09-12T22:40:54+08:00 New Revision: 1d51bb824f25140a5b1aa783f6860ac3e7f7d16d URL: https://github.com/llvm/llvm-project/commit/1d51bb824f25140a5b1aa783f6860ac3e7f7d16d DIFF: https://github.com/llvm/llvm-project/commit/1d51bb824f25140a5b1aa783f6860ac3e7f7d16d.diff LOG

[PATCH] D133574: [C2x] reject type definitions in offsetof

inclyc updated this revision to Diff 459458. inclyc added a comment. Use declaration context Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133574/new/ https://reviews.llvm.org/D133574 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Basi

[PATCH] D133354: [Clang]: Diagnose deprecated copy operations also in MSVC compatibility mode

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. lgtm Maybe give Richard another day or two in case he wants to take a look, but otherwise landing this and seeing if there are any problems we didn't know about sounds good to me. CHANGES SINCE

[PATCH] D133611: [clang] sort additional module maps when serializing

rmaz updated this revision to Diff 459467. rmaz added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133611/new/ https://reviews.llvm.org/D133611 Files: clang/lib/Serialization/ASTWriter.cpp Index: clang/lib/Serialization/ASTW

[PATCH] D126864: [clang] Introduce -fstrict-flex-arrays= for stricter handling of flexible arrays

msebor added inline comments. Comment at: clang/docs/ClangCommandLineReference.rst:2648 + +Control which arrays are considered as flexible arrays members. +can be 1 (array of size 0, 1 and undefined are considered) or 2 (array of size 0 aaron.ballman wrote: > Th

[PATCH] D133703: [Clang] NFC: Make UnqualifiedId::Kind private for consistency.

cor3ntin created this revision. Herald added a project: All. cor3ntin requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D133703 Files: clang/include/clang/Sema/DeclSpec.h cl

[PATCH] D133694: [Clang][OpenMP] Fix use_device_addr

doru1004 updated this revision to Diff 459475. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133694/new/ https://reviews.llvm.org/D133694 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp clang/lib/CodeGen/CGStmtOpenMP.cpp clang/test/OpenMP/target_data_use_device_addr_codegen_ptr.cpp

[PATCH] D133668: [HLSL] Use _BitInt(16) for int16_t to avoid promote to int.

beanz added a comment. In D133668#3783489 , @aaron.ballman wrote: > Okay, that's good to know! If you don't intend to *ever* conform to the > standard in this area, then I think this approach is very reasonable. But you > should know up front that you'

[PATCH] D133705: [HIP] Fix unbundling archive

yaxunl created this revision. yaxunl added a reviewer: tra. Herald added a project: All. yaxunl requested review of this revision. HIP is able to unbundle archive of bundled bitcode. However currently there are two bugs: 1. archives passed by -l: are not unbundled. 2. archives passed as input fi

[PATCH] D133705: [HIP] Fix unbundling archive

yaxunl updated this revision to Diff 459482. yaxunl added a comment. Herald added subscribers: sstefan1, MaskRay. Herald added a reviewer: jdoerfert. sorry. update with the correct patch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133705/new/ https://reviews.llvm.org/D133705 Files:

[PATCH] D133289: [C2X] N3007 Type inference for object definitions

aaron.ballman added a comment. This is awesome, thank you for working on it! @to268 and I had a really good discussion during my office hours and what we decided for next steps were: 0) Next time you upload a patch, please use `-U` to give the patch more context for reviewers to see. 1. Ne

[PATCH] D133705: [HIP] Fix unbundling archive

yaxunl updated this revision to Diff 459484. yaxunl added a comment. remove debug output CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133705/new/ https://reviews.llvm.org/D133705 Files: clang/lib/Driver/Driver.cpp clang/lib/Driver/ToolChains/CommonArgs.cpp clang/test/Driver/hip-

[PATCH] D133289: [C2X] N3007 Type inference for object definitions

shafik added inline comments. Comment at: clang/test/Sema/c2x-auto.c:49 +auto b = 9; +auto c = a + b; + } When I made the comment about the example from the proposal, this was what I was thinking about. Repository: rG LLVM Github Monorepo CHANGES S

Re: [clang] b7a7aee - [clang] Qualify auto in range-based for loops (NFC)

On Sat, Sep 10, 2022 at 3:01 PM Kazu Hirata wrote: > > Thank you Aaron and David for your inputs. > > First and foremost, I apologize if I made your job harder by increasing the > number of commits you have to peel to get to the real author. > > I hear that we are moving toward github pull reques

[PATCH] D133289: [C2X] N3007 Type inference for object definitions

aaron.ballman added a comment. FYI: regarding `auto auto`, I've heard back from the author of N3007 and the intent was to disallow this construct ("others" was meant to exclude `auto` and "except typedef" was meant to add onto the list of exclusions). Repository: rG LLVM Github Monorepo CHA

[PATCH] D133289: [C2X] N3007 Type inference for object definitions

aaron.ballman added a comment. One thought that occurred to me is that the way C has this specified is awfully effectively the same way implicit int worked. It may be worth exploring a change to our implicit int functionality to instead generate an implicit `auto` type when in C2x mode. Repos

[PATCH] D133705: [HIP] Fix unbundling archive

scchan requested changes to this revision. scchan added inline comments. This revision now requires changes to proceed. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:1959 + if (FoundAOB) +break; } The AOBFileNames small vector needs to

[PATCH] D133611: [clang] sort additional module maps when serializing

rmaz updated this revision to Diff 459492. rmaz added a comment. clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133611/new/ https://reviews.llvm.org/D133611 Files: clang/lib/Serialization/ASTWriter.cpp Index: clang/lib/Serializatio

[PATCH] D132131: [clang-format] Adds a formatter for aligning trailing comments over empty lines

MyDeveloperDay added inline comments. Comment at: clang/include/clang/Format/Format.h:406 +/// Specifies the way to align trailing comments +TrailingCommentsAlignmentKinds Kind; +/// How many empty lines to apply alignment Kind? doesn't feel like the

[clang] d96f526 - [clang][test] Disallow using the default module cache path in lit tests

Author: Ben Langmuir Date: 2022-09-12T09:54:56-07:00 New Revision: d96f526196ac4cebfdd318473816f6d4b9d76707 URL: https://github.com/llvm/llvm-project/commit/d96f526196ac4cebfdd318473816f6d4b9d76707 DIFF: https://github.com/llvm/llvm-project/commit/d96f526196ac4cebfdd318473816f6d4b9d76707.diff

[PATCH] D133622: [clang][test] Disallow using the default module cache path in lit tests

This revision was automatically updated to reflect the committed changes. Closed by commit rGd96f526196ac: [clang][test] Disallow using the default module cache path in lit tests (authored by benlangmuir). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D132131: [clang-format] Adds a formatter for aligning trailing comments over empty lines

yusuke-kadowaki marked 2 inline comments as done. yusuke-kadowaki added a comment. So other than the naming, does the struct look good? Comment at: clang/include/clang/Format/Format.h:406 +/// Specifies the way to align trailing comments +TrailingCommentsAlignmentKinds

[PATCH] D133694: [Clang][OpenMP] Fix use_device_addr

ye-luo added inline comments. Comment at: clang/test/OpenMP/target_data_use_device_addr_codegen_ptr.cpp:14 +{ +#pragma omp target data use_device_addr(x) +{ In my understanding of the spec. `map(tofrom:x[0:256])` only maps the memory segment t

[PATCH] D133705: [HIP] Fix unbundling archive

yaxunl marked an inline comment as done. yaxunl added inline comments. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:1959 + if (FoundAOB) +break; } scchan wrote: > The AOBFileNames small vector needs to be cleared if !FoundAOB or just m

[PATCH] D133705: [HIP] Fix unbundling archive

yaxunl updated this revision to Diff 459502. yaxunl marked an inline comment as done. yaxunl added a comment. revised by Siu Chi's comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133705/new/ https://reviews.llvm.org/D133705 Files: clang/lib/Driver/Driver.cpp clang/lib/Driver

[clang] 7eead18 - [Clang] NFC: Make UnqualifiedId::Kind private for consistency.

Author: Corentin Jabot Date: 2022-09-12T19:14:06+02:00 New Revision: 7eead180b92dcff7eaf9d71df14e33936ec4dbe5 URL: https://github.com/llvm/llvm-project/commit/7eead180b92dcff7eaf9d71df14e33936ec4dbe5 DIFF: https://github.com/llvm/llvm-project/commit/7eead180b92dcff7eaf9d71df14e33936ec4dbe5.diff

[PATCH] D133703: [Clang] NFC: Make UnqualifiedId::Kind private for consistency.

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7eead180b92d: [Clang] NFC: Make UnqualifiedId::Kind private for co

[PATCH] D133711: [Sema] Reject array element types whose alignments are larger than their sizes

ahatanak created this revision. ahatanak added reviewers: efriedma, rjmccall, rnk, sepavloff. ahatanak added a project: clang. Herald added a project: All. ahatanak requested review of this revision. In the following code, the first element is aligned on a 16-byte boundary, but the remaining elem

[PATCH] D133325: [Driver] Allow search of included response files as configuration files

sepavloff updated this revision to Diff 459508. sepavloff added a comment. Rebased, addressed reviewers' notes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133325/new/ https://reviews.llvm.org/D133325 Files: clang/docs/UsersManual.rst clang/

[PATCH] D133694: [Clang][OpenMP] Fix use_device_addr

doru1004 added inline comments. Comment at: clang/test/OpenMP/target_data_use_device_addr_codegen_ptr.cpp:14 +{ +#pragma omp target data use_device_addr(x) +{ ye-luo wrote: > In my understanding of the spec. > `map(tofrom:x[0:256])` only maps

[PATCH] D133711: [Sema] Reject array element types whose alignments are larger than their sizes

efriedma added a reviewer: aaron.ballman. efriedma added inline comments. Comment at: clang/lib/Sema/SemaType.cpp:2406 + + if (Size.isZero() || Size >= Context.getTypeAlignInChars(EltTy)) +return false; I think you need to check that the size is a multiple o

[PATCH] D132421: [HLSL] Support PCH for cc1 mode

python3kgae updated this revision to Diff 459519. python3kgae marked an inline comment as done. python3kgae added a comment. Fix test fail caused by not add HLSL builtin Resource type. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132421/new/ https

[PATCH] D133705: [HIP] Fix unbundling archive

scchan accepted this revision. scchan added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133705/new/ https://reviews.llvm.org/D133705 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D132643: [OpenMP] Extend lit test for parallel for simd construct

saiislam accepted this revision. saiislam added a comment. This revision is now accepted and ready to land. LGTM. Thank! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132643/new/ https://reviews.llvm.org/D132643 ___

[PATCH] D133694: [Clang][OpenMP] Fix use_device_addr

ye-luo added inline comments. Comment at: clang/test/OpenMP/target_data_use_device_addr_codegen_ptr.cpp:14 +{ +#pragma omp target data use_device_addr(x) +{ doru1004 wrote: > ye-luo wrote: > > In my understanding of the spec. > > `map(tofrom:x

[PATCH] D133325: [Driver] Allow search of included response files as configuration files

sepavloff marked 4 inline comments as done. sepavloff added a comment. In D133325#3771275 , @MaskRay wrote: > For a config file, `--search-config-dirs` is introduced to change how `@cfg` > is resolved > (relative to `--config-system-dir` or `--config-use

[PATCH] D133659: [Clang] P1169R4: static operator()

royjacobson marked 6 inline comments as done. royjacobson added inline comments. Comment at: clang/lib/Parse/ParseExprCXX.cpp:1265 + if (Intro.hasLambdaCapture()) +P.Diag(StaticLoc, diag::err_static_lambda_captures); +} cor3ntin wrote: > We might want to add

[PATCH] D133659: [Clang] P1169R4: static operator()

royjacobson updated this revision to Diff 459525. royjacobson marked an inline comment as done. royjacobson added a comment. Add note in diagnostic. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133659/new/ https://reviews.llvm.org/D133659 Files:

[PATCH] D133694: [Clang][OpenMP] Fix use_device_addr

doru1004 added inline comments. Comment at: clang/test/OpenMP/target_data_use_device_addr_codegen_ptr.cpp:14 +{ +#pragma omp target data use_device_addr(x) +{ ye-luo wrote: > doru1004 wrote: > > ye-luo wrote: > > > In my understanding of the s

[PATCH] D133694: [Clang][OpenMP] Fix use_device_addr

ye-luo added inline comments. Comment at: clang/test/OpenMP/target_data_use_device_addr_codegen_ptr.cpp:14 +{ +#pragma omp target data use_device_addr(x) +{ doru1004 wrote: > ye-luo wrote: > > doru1004 wrote: > > > ye-luo wrote: > > > > In my

[PATCH] D133659: [Clang] P1169R4: static operator()

lichray added inline comments. Comment at: clang/test/CodeGenCXX/cxx2b-static-call-operator.cpp:5 +struct Functor { + static int operator()(int x, int y) { +return x + y; I want to see some tests that diagnose `extern operator()`. Comment

[PATCH] D133674: [Lex/DependencyDirectivesScanner] Handle the case where the source line starts with a `tok::hashhash`

jansvoboda11 added a comment. Could you explain why this is necessary and even correct? I'd expect Clang to give an error when seeing `##` in this position, and I'd expect the scanner to do the same. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1

[PATCH] D133705: [HIP] Fix unbundling archive

tra added a comment. > Archives passed by -l: should not be prefixed with > prefix lib and appended with '.a', but still need to be prefixed with > paths in -L options. > Archives passed as input files should not be prefixed > or appended with anything. I'm not sure I understand the requiremen

[PATCH] D133668: [HLSL] Use _BitInt(16) for int16_t to avoid promote to int.

aaron.ballman added a comment. In D133668#3783975 , @beanz wrote: > In D133668#3783489 , @aaron.ballman > wrote: > >> Okay, that's good to know! If you don't intend to *ever* conform to the >> standard in this a

[clang] 3c1b423 - [clang] sort additional module maps when serializing

Author: Richard Howell Date: 2022-09-12T12:00:43-07:00 New Revision: 3c1b42347b3a0666c93948ade2f420a20e060c1a URL: https://github.com/llvm/llvm-project/commit/3c1b42347b3a0666c93948ade2f420a20e060c1a DIFF: https://github.com/llvm/llvm-project/commit/3c1b42347b3a0666c93948ade2f420a20e060c1a.diff

[PATCH] D133611: [clang] sort additional module maps when serializing

This revision was automatically updated to reflect the committed changes. Closed by commit rG3c1b42347b3a: [clang] sort additional module maps when serializing (authored by rmaz). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133611/new/ https://rev

[PATCH] D111283: [clang] template / auto deduction deduces common sugar

ychen added a comment. In D111283#3783338 , @mizvekov wrote: > In D111283#3783250 , @ychen wrote: > >> Hi @mizvekov , I noticed that deduction for partial ordering also inherits >> this new behavior. Do you think

Re: [clang] b7a7aee - [clang] Qualify auto in range-based for loops (NFC)

On Mon, Sep 12, 2022 at 12:17 PM David Blaikie wrote: > > On Sat, Sep 10, 2022 at 3:01 PM Kazu Hirata wrote: > > > > Thank you Aaron and David for your inputs. > > > > First and foremost, I apologize if I made your job harder by increasing the > > number of commits you have to peel to get to the

[PATCH] D133668: [HLSL] Use _BitInt(16) for int16_t to avoid promote to int.

python3kgae added a comment. In D133668#3784607 , @aaron.ballman wrote: > In D133668#3783975 , @beanz wrote: > >> In D133668#3783489 , >> @aaron.ballman wrote: >> >>> Ok

[PATCH] D133668: [HLSL] Use _BitInt(16) for int16_t to avoid promote to int.

python3kgae added a comment. In D133668#3784636 , @python3kgae wrote: > In D133668#3784607 , @aaron.ballman > wrote: > >> In D133668#3783975 , @beanz wrote: >> >>> In D1

[PATCH] D111283: [clang] template / auto deduction deduces common sugar

mizvekov added a comment. In D111283#3784615 , @ychen wrote: > `A` is currently modeled as ElaboratedType. It was > `TemplateSpecializationType` before. Reading comments for `ElaboratedType`, > it looks like sugar type might not be needed here? Ah you

[PATCH] D128958: Add assembler plumbing for sanitize_memtag

hctim updated this revision to Diff 459534. hctim added a comment. Remove unnecessary hasSanitizerMetadata() Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128958/new/ https://reviews.llvm.org/D128958 Files: clang/test/Driver/memtag-stack.c cla

[PATCH] D111283: [clang] template / auto deduction deduces common sugar

ychen added a comment. In D111283#3784648 , @mizvekov wrote: > In D111283#3784615 , @ychen wrote: > >> `A` is currently modeled as ElaboratedType. It was >> `TemplateSpecializationType` before. Reading comments f

[PATCH] D111283: [clang] template / auto deduction deduces common sugar

mizvekov added a comment. In D111283#3784663 , @ychen wrote: > Thanks for the link. I'm not blocked by any of these patches, instead just > trying to have a mental model of when to expect the sugared type :-). For > partial ordering, the `TemplateSpecia

[PATCH] D133674: [Lex/DependencyDirectivesScanner] Handle the case where the source line starts with a `tok::hashhash`

akyrtzi added a comment. In D133674#3784602 , @jansvoboda11 wrote: > Could you explain why this is necessary and even correct? I'd expect Clang to > give an error when seeing `##` in this position, and I'd expect the scanner > to do the same. `##` is

[PATCH] D132975: [CMake] Add clang-bolt target

Amir updated this revision to Diff 459539. Amir added a comment. Address @phosek's comment about dependency on shell Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132975/new/ https://reviews.llvm.org/D132975 Files: clang/CMakeLists.txt clang/c

[PATCH] D132975: [CMake] Add clang-bolt target

Amir marked an inline comment as not done. Amir added inline comments. Comment at: clang/CMakeLists.txt:930-937 +-DCMAKE_INSTALL_PREFIX=${CMAKE_INSTALL_PREFIX} +-DCMAKE_C_COMPILER=${CLANG_INSTRUMENTED} +-DCMAKE_CXX_COMPILER=${CLANGX

[clang] 4a72459 - Revert "[clang][test] Disallow using the default module cache path in lit tests"

Author: Ben Langmuir Date: 2022-09-12T13:10:22-07:00 New Revision: 4a72459ed639e3eb7188565c758181c43d3192aa URL: https://github.com/llvm/llvm-project/commit/4a72459ed639e3eb7188565c758181c43d3192aa DIFF: https://github.com/llvm/llvm-project/commit/4a72459ed639e3eb7188565c758181c43d3192aa.diff

[PATCH] D133574: [C2x] reject type definitions in offsetof

shafik added inline comments. Comment at: clang/include/clang/Parse/Parser.h:2283 case DeclSpecContext::DSC_top_level: +case DeclSpecContext::DSC_offsetof: return true; Why `true` for this case? What does this allow that we want? Do we test it?

[PATCH] D133622: [clang][test] Disallow using the default module cache path in lit tests

benlangmuir added a comment. Reverted due to failure on a bot https://lab.llvm.org/buildbot/#/builders/214/builds/3252 I'm not sure how to deal with missing `env -u`. - We could do `env CLANG_MODULE_CACHE_PATH=` and change the compiler's interpretation of empty string for this variable. I'm no

[PATCH] D133589: [clang-format] JSON formatting add new option for controlling newlines in json arrays

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/Format.cpp:1965 (Style.JavaScriptQuotes == FormatStyle::JSQS_Double && - !Input.startswith("\'"))) { + !Input.startswith("\'"))) continue; These

[PATCH] D133571: [clang-format] Introduce NoFallThrough option into AllowShortCaseLabelsOnASingleLine

HazardyKnusperkeks added inline comments. Comment at: clang/include/clang/Format/Format.h:469 + /// Different styles for merging short case labels. + enum ShortCaseLabelStyle : int8_t { +/// Never merge case code MyDeveloperDay wrote: > HazardyKnusperkeks w

[PATCH] D133648: Clang, increase upper bound of partially initialized array sizes

shafik added inline comments. Comment at: clang/lib/Sema/SemaInit.cpp:866 ElementEntity.getKind() == InitializedEntity::EK_VectorElement) ElementEntity.setElementIndex(Init); `setElementIndex(...)` takes `unsigned` as well and therefore `Initia

[PATCH] D133725: Searching for tokens including comments

barcisz created this revision. Herald added a project: All. barcisz requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is a small diff that adds an optional argument to the Lexer::findNextToken that allows for searching for the token whi

[PATCH] D133694: [Clang][OpenMP] Fix use_device_addr

doru1004 added inline comments. Comment at: clang/test/OpenMP/target_data_use_device_addr_codegen_ptr.cpp:14 +{ +#pragma omp target data use_device_addr(x) +{ ye-luo wrote: > doru1004 wrote: > > ye-luo wrote: > > > doru1004 wrote: > > > > ye-l

[PATCH] D111283: [clang] template / auto deduction deduces common sugar

ychen added a comment. In D111283#3784702 , @mizvekov wrote: > In D111283#3784663 , @ychen wrote: > >> Thanks for the link. I'm not blocked by any of these patches, instead just >> trying to have a mental model o

[PATCH] D133648: Clang, increase upper bound of partially initialized array sizes

efriedma added inline comments. Comment at: clang/lib/Sema/SemaInit.cpp:866 ElementEntity.getKind() == InitializedEntity::EK_VectorElement) ElementEntity.setElementIndex(Init); shafik wrote: > `setElementIndex(...)` takes `unsigned` as well and

[clang] ab56719 - [clang, llvm] Add __declspec(safebuffers), support it in CodeView

Author: David Majnemer Date: 2022-09-12T21:15:34Z New Revision: ab56719acd98778fb2e48fa425ac7c8d27bdea86 URL: https://github.com/llvm/llvm-project/commit/ab56719acd98778fb2e48fa425ac7c8d27bdea86 DIFF: https://github.com/llvm/llvm-project/commit/ab56719acd98778fb2e48fa425ac7c8d27bdea86.diff LOG

[PATCH] D133726: [OpenMP][AMDGPU] Link bitcode ROCm device libraries per-TU

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, JonChesterfield, ronlieb, arsenm, yaxunl, tianshilei1992, ye-luo. Herald added subscribers: kosarev, kerbowa, guansong, t-tye, tpr, dstuttard, jvesely, kzhuravl. Herald added a project: All. jhuber6 requested review of this revisi

[PATCH] D133586: [clang] do not hash undefined qualifiers for FunctionNoProtoType

rmaz planned changes to this revision. rmaz added a comment. I think it is probably safer to zero out the FastTypeQuals instead. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133586/new/ https://reviews.llvm.org/D133586 ___

[PATCH] D112374: [clang] Implement ElaboratedType sugaring for types written bare

davrec added inline comments. Comment at: clang/include/clang/AST/Type.h:5530-5537 /// Represents a type that was referred to using an elaborated type /// keyword, e.g., struct S, or via a qualified name, e.g., N::M::type, /// or both. /// /// This type is used to keep track

  1   2   >