[PATCH] D86049: RFC: Implement optional exportable wrapper function generation for objc_direct methods.

plotfi added inline comments. Comment at: clang/test/CodeGenObjC/objc-direct-wrapper.m:30 +#if ENABLE_VISIBLE_OBJC_DIRECT +#define OBJC_DIRECT __attribute((objc_direct)) __attribute__((objc_direct_visible)) +#else dmaclach wrote: > This is the case that mwyman d

[PATCH] D86049: RFC: Implement optional exportable wrapper function generation for objc_direct methods.

plotfi updated this revision to Diff 459267. plotfi added a comment. Update test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86049/new/ https://reviews.llvm.org/D86049 Files: clang/include/clang/AST/DeclObjC.h clang/include/clang/Basic/Attr

[clang] 1e56821 - [Linux] Hack around Linux/sparc

Author: Rainer Orth Date: 2022-09-10T09:37:35+02:00 New Revision: 1e56821bac02a5d3c6249bbf3ef43b8b569d2551 URL: https://github.com/llvm/llvm-project/commit/1e56821bac02a5d3c6249bbf3ef43b8b569d2551 DIFF: https://github.com/llvm/llvm-project/commit/1e56821bac02a5d3c6249bbf3ef43b8b569d2551.diff L

[PATCH] D86049: RFC: Implement optional exportable wrapper function generation for objc_direct methods.

plotfi updated this revision to Diff 459268. plotfi added a comment. Adding a test case to cover @protocol methods not being allowed to contain direct Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86049/new/ https://reviews.llvm.org/D86049 Files:

[PATCH] D133405: [Linux] Hack around Linux/sparc

This revision was automatically updated to reflect the committed changes. Closed by commit rG1e56821bac02: [Linux] Hack around Linux/sparc (authored by ro). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133405/new/ https://review

[PATCH] D86049: RFC: Implement optional exportable wrapper function generation for objc_direct methods.

plotfi marked an inline comment as done. plotfi added inline comments. Comment at: clang/test/CodeGenObjC/objc-direct-wrapper.m:35 + +@interface C +- (void)testMethod:(int)arg1 bar:(float)arg2 OBJC_DIRECT; dmaclach wrote: > I'd like to see a test for the protocol

[PATCH] D133405: [Linux] Hack around Linux/sparc

nikic added a comment. > I've been using this hack to work around the Linux/sparc64 compile failure > described in Issue #47994, especially since the underlying glibc PR > build/27558 doesn't seem to be making progress and some fix is required to > have LLVM build on sparc64-unknown-linux-gnu a

[PATCH] D133088: [Clang] Fix wrong diagnostic for scope identifier with internal linkage

pmor13 added a comment. @aaron.ballman > block scope variable to have *internal* linkage instead of *no* linkage static int x; void f(void) { extern int x; // block scope, internal linkage } Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.l

[PATCH] D133405: [Linux] Hack around Linux/sparc

glaubitz added a comment. In D133405#3782092 , @nikic wrote: >> I've been using this hack to work around the Linux/sparc64 compile failure >> described in Issue #47994, especially since the underlying glibc PR >> build/27558 doesn't seem to be making pr

[PATCH] D133405: [Linux] Hack around Linux/sparc

nikic added a comment. In D133405#3782136 , @glaubitz wrote: > In D133405#3782092 , @nikic wrote: > >>> I've been using this hack to work around the Linux/sparc64 compile failure >>> described in Issue #47994, es

[PATCH] D133405: [Linux] Hack around Linux/sparc

glaubitz added a comment. In D133405#3782137 , @nikic wrote: > In D133405#3782136 , @glaubitz > wrote: > >> In D133405#3782092 , @nikic wrote: >> I've been using thi

[PATCH] D133354: [Clang]: Diagnose deprecated copy operations also in MSVC compatibility mode

ningvin updated this revision to Diff 459277. ningvin added a comment. I added the respective RUN lines to the different test cases, did not seem to break anything on my end. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133354/new/ https://reviews.llvm.org/D133354 Files: clang/lib/

[PATCH] D133088: [Clang] Fix wrong diagnostic for scope identifier with internal linkage

aaron.ballman added a comment. In D133088#3782126 , @pmor13 wrote: > @aaron.ballman > >> block scope variable to have *internal* linkage instead of *no* linkage > > static int x; > > void f(void) > { > extern int x; // block scope, interna

[PATCH] D133518: [HLSL] Call global destructors from entries

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. In D133518#3781308 , @beanz wrote: > In D133518#3781101 , @aaron.ballman > wrote: > >> This ge

[PATCH] D133194: rewording note note_constexpr_invalid_cast

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. In D133194#3781271 , @Codesbyusman wrote: > updated, I am not getting why this is happening but in the .cpp test file > without Wvla al

[PATCH] D133589: [clang-format] JSON formatting add new option for controlling newlines in json arrays

MyDeveloperDay updated this revision to Diff 459283. MyDeveloperDay marked 7 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133589/new/ https://reviews.llvm.org/D133589 Files: clang/.clang-format clang/docs/ClangFormatStyleOptions.rst clang/include/clang/For

[PATCH] D133589: [clang-format] JSON formatting add new option for controlling newlines in json arrays

MyDeveloperDay added a comment. Addressed review comments, renamed the options Comment at: clang/docs/ClangFormatStyleOptions.rst:3115 +**JsonMultilineArrays** (``Boolean``) :versionbadge:`clang-format 16` + If ``true``, clang-format will always break after a Json array `[`

[PATCH] D133589: [clang-format] JSON formatting add new option for controlling newlines in json arrays

MyDeveloperDay added inline comments. Comment at: clang/docs/ClangFormatStyleOptions.rst:3115 +**JsonMultilineArrays** (``Boolean``) :versionbadge:`clang-format 16` + If ``true``, clang-format will always break after a Json array `[` MyDeveloperDay wrote: > cu

[PATCH] D133635: [clang-format] Don't insert braces for loops with a null statement

MyDeveloperDay added a comment. Can't tell you how much I love this `InsertBraces` feature @ownpan, I work for a team (with a large code base) that uses them all the time, and we are catching missing braces in decade-old code! Thank you Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[PATCH] D133641: [Clang] [Sema] Ignore invalid multiversion function redeclarations

Izaron created this revision. Izaron added reviewers: tahonermann, erichkeane. Herald added a project: All. Izaron requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. If a redeclaration of a multiversion function is invalid, it may be in a brok

[PATCH] D133641: [Clang] [Sema] Ignore invalid multiversion function redeclarations

Izaron added a comment. How the bug was working on this example: void foo() {} [[gnu::target("default")]] void foo() {} [[gnu::target("avx2")]] void foo() {} 1. Clang parses the definition of the `foo` function (line 1) 2. When parsing the second definition (line 2), Clang will delete `T

[PATCH] D125142: [clang][auto-init] Remove -enable flag for "zero" mode

nickdesaulniers added a comment. @rsmith can we get some guidance here? Has your opinion changed in the time since GCC has been shipping this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125142/new/ https://reviews.llvm.org/D125142 ___

[PATCH] D133088: [Clang] Fix wrong diagnostic for scope identifier with internal linkage

junaire updated this revision to Diff 459287. junaire added a comment. Try to address Aaron's comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133088/new/ https://reviews.llvm.org/D133088 Files: clang/docs/ReleaseNotes.rst clang/include

[PATCH] D133570: Clang codegen, fixes issue with emitting partially initialized constant arrays larger than 2^32

OfekShochat added a comment. hello, solved the issue. it was, quite expectedly, a u64/unsigned problem in parsing, not codegen. no need to refactor this function. I will close this, thanks for the feedback and sorry for the hassle Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

[PATCH] D125142: [clang][auto-init] Remove -enable flag for "zero" mode

xbolva00 added a comment. In D125142#3782244 , @nickdesaulniers wrote: > @rsmith can we get some guidance here? Has your opinion changed in the time > since GCC has been shipping this? Maybe we should now ask @aaron.ballman as he is now main code owne

[PATCH] D132131: [clang-format] Adds a formatter for aligning trailing comments over empty lines

yusuke-kadowaki updated this revision to Diff 459292. yusuke-kadowaki marked an inline comment as done. yusuke-kadowaki added a comment. Just updated the Style struct field definitions for review. Haven't implemented the logics. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 0e8afdd - [Clang] NFC: Remove duplicated variable def in CheckLValueConstantExpression

Author: Corentin Jabot Date: 2022-09-10T19:10:23+02:00 New Revision: 0e8afddaa15fda1d50888b44695eecb89c0b1c0b URL: https://github.com/llvm/llvm-project/commit/0e8afddaa15fda1d50888b44695eecb89c0b1c0b DIFF: https://github.com/llvm/llvm-project/commit/0e8afddaa15fda1d50888b44695eecb89c0b1c0b.diff

[PATCH] D132131: [clang-format] Adds a formatter for aligning trailing comments over empty lines

yusuke-kadowaki marked 2 inline comments as done. yusuke-kadowaki added a comment. Thank you for the detailed explanation. I understood the needs for `unsigned OverEmptyLines` field. Please review the struct definition first. Then I'll implement the rest of the code. Comment

[PATCH] D133194: rewording note note_constexpr_invalid_cast

Codesbyusman added a comment. In D133194#3782198 , @aaron.ballman wrote: > In D133194#3781271 , @Codesbyusman > wrote: > >> updated, I am not getting why this is happening but in the .cpp test file >> without W

[PATCH] D133194: rewording note note_constexpr_invalid_cast

Codesbyusman updated this revision to Diff 459296. Codesbyusman added a comment. updating with the suggested changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133194/new/ https://reviews.llvm.org/D133194 Files: clang/include/clang/Basic/Dia

[PATCH] D133571: [clang-format] Introduce NoFallThrough option into AllowShortCaseLabelsOnASingleLine

HazardyKnusperkeks added inline comments. Comment at: clang/include/clang/Format/Format.h:469 + /// Different styles for merging short case labels. + enum ShortCaseLabelStyle : int8_t { +/// Never merge case code While we're at it, shouldn't there be a `Lea

[PATCH] D133647: [clang-format] Parse the else part of `#if 0`

sstwcw created this revision. sstwcw added reviewers: HazardyKnusperkeks, MyDeveloperDay, curdeius, owenpan. Herald added a project: All. sstwcw requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fixes https://github.com/llvm/llvm-project/issu

[PATCH] D133589: [clang-format] JSON formatting add new option for controlling newlines in json arrays

HazardyKnusperkeks added inline comments. Comment at: clang/.clang-format:2 BasedOnStyle: LLVM +RemoveBracesLLVM: true Unrelated. Comment at: clang/include/clang/Format/Format.h:2063 + /// otherwise it will scan until the closing `]` to deter

[PATCH] D133648: [Clang] changing behavior of constant array emission

OfekShochat created this revision. OfekShochat added a reviewer: klimek. Herald added a subscriber: hiraditya. Herald added a project: All. OfekShochat requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. fixes issue with emitt