[PATCH] D133087: [clang-format] [doc] Fix example of wrapping class definitions

Passw added a comment. In D133087#3769628 , @HazardyKnusperkeks wrote: > In D133087#3768928 , @Passw wrote: > >> I do not have commit access, please help to commit this change. >> Thanks. > > Please state a name

[PATCH] D133308: [cmake] do not set execution permission to regular files

phosek accepted this revision. phosek added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133308/new/ https://reviews.llvm.org/D133308 ___ cfe-commits mailing list cfe-commits@lists.llvm.

[PATCH] D133244: [clang-tidy] Readability-container-data-pointer adds new option to ignore Containers

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/readability/container-data-pointer.cpp:1 -// RUN: %check_clang_tidy %s readability-container-data-pointer %t -- -- -fno-delayed-template-parsing +// RUN: %check_clang_tidy %s readabilit

[PATCH] D125419: [Arm64EC 7/?] clang side of Arm64EC varargs ABI.

rjmccall added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:2457 +/*IsVectorCall=*/false, /*IsRegCall=*/false); + } + efriedma wrote: > rjmccall wrote: > > Hmm. Doesn't EC ABI lowering need to preserve this same state, or el

[clang] 7628f19 - [NFC] Remove invisible character in Diagnostic message and tests

Author: Chuanqi Xu Date: 2022-09-06T11:08:42+08:00 New Revision: 7628f19262e441b438a69176ec5229d8ccb96124 URL: https://github.com/llvm/llvm-project/commit/7628f19262e441b438a69176ec5229d8ccb96124 DIFF: https://github.com/llvm/llvm-project/commit/7628f19262e441b438a69176ec5229d8ccb96124.diff LO

[PATCH] D133289: [C2X] N3007 Type inference for object definitions

to268 updated this revision to Diff 458089. to268 added a comment. I have fixed my CodeGen test with the windows platform. (Linux uses an i64 for the long type instead windows is using an i32) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133289/new

[PATCH] D133325: [Driver] Allow search of included response files as configuration files

MaskRay added a comment. > Normally a file included into configuration file by directive @file is > searched for relative the including configuration file. In some cases it > is not convenient. Sorry, I am puzzled by the description. A configuration file may specify `--option=file` and `@cfg`. C

[PATCH] D133289: [C2X] N3007 Type inference for object definitions

to268 updated this revision to Diff 458092. to268 added a comment. Fixed `DeclSpec.cpp` formatting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133289/new/ https://reviews.llvm.org/D133289 Files: clang/lib/Parse/ParseDecl.cpp clang/lib/Sema/D

[PATCH] D133325: [Driver] Allow search of included response files as configuration files

MaskRay added inline comments. Comment at: llvm/include/llvm/Support/CommandLine.h:2132 + + bool getSearchAsConfig() const { return SearchAsConfig; } + ExpansionContext &setSearchAsConfig(bool X) { Unused Repository: rG LLVM Github Monorepo CHANGES SINCE L

[PATCH] D133248: [clang] Fix crash upon stray coloncolon token in C2x mode

tbaeder added inline comments. Comment at: clang/include/clang/Parse/Parser.h:863 bool MightBeCXXScopeToken() { -return Tok.is(tok::identifier) || Tok.is(tok::coloncolon) || - (Tok.is(tok::annot_template_id) && -NextToken().is(tok::coloncolon)) || -

[PATCH] D133336: [msan] Convert Msan to ModulePass

vitalybuka created this revision. Herald added subscribers: Enna1, ormris, jdoerfert, hiraditya. Herald added a project: All. vitalybuka requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. MemorySanitizerPass function pass vio

[PATCH] D133336: [msan] Convert Msan to ModulePass

vitalybuka updated this revision to Diff 458097. vitalybuka added a comment. update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D16/new/ https://reviews.llvm.org/D16 Files: clang/lib/CodeGen/BackendUtil.cpp llvm/include/llvm/Transform

[PATCH] D133336: [msan] Convert Msan to ModulePass

vitalybuka updated this revision to Diff 458098. vitalybuka added a comment. clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D16/new/ https://reviews.llvm.org/D16 Files: clang/lib/CodeGen/BackendUtil.cpp llvm/include/llvm/Tra

[PATCH] D125419: [Arm64EC 7/?] clang side of Arm64EC varargs ABI.

efriedma planned changes to this revision. efriedma added a comment. Just realized I forgot to add tests for va_arg. Comment at: clang/lib/CodeGen/TargetInfo.cpp:2457 +/*IsVectorCall=*/false, /*IsRegCall=*/false); + } + rjmccall wrote: > ef

[PATCH] D132843: [RISCV] Ensure target features get passed to the LTO linker for RISC-V

efriedma added a comment. In D132843#3771029 , @jrtc27 wrote: > In D132843#3770936 , @efriedma > wrote: > >>> There is also an issue with how to store and determine the final LTO target >>> features. For example

[PATCH] D133338: [clang][PowerPC] PPC64 VAArg use coerced integer type for direct aggregate fits in register

tingwang created this revision. tingwang added reviewers: uweigand, wschmidt, PowerPC. tingwang added a project: clang. Herald added subscribers: shchenz, kbarton, nemanjai. Herald added a project: All. tingwang requested review of this revision. Herald added a subscriber: cfe-commits. This is an

[clang] 4954196 - [NFC] Add test of sized deallocation for coroutines

Author: Chuanqi Xu Date: 2022-09-06T14:44:16+08:00 New Revision: 495419628bbab1a99cfc00d0c44b877bfc8e4a14 URL: https://github.com/llvm/llvm-project/commit/495419628bbab1a99cfc00d0c44b877bfc8e4a14 DIFF: https://github.com/llvm/llvm-project/commit/495419628bbab1a99cfc00d0c44b877bfc8e4a14.diff LO

<    1   2