[PATCH] D130181: [clang-tidy] Add readability-use-early-exits check

JonasToth added a comment. IMHO the check looks good, but I do have concerns about correctness of the transformation in specific cases, especially overloaded operators. If the conditions are inverted, it might be the case that the inverted operator is not overloaded, resulting in compilation er

[PATCH] D133092: [clang] fix generation of .debug_aranges with LTO

azat updated this revision to Diff 457850. azat added a comment. Adjust the test (to fix build on windows) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133092/new/ https://reviews.llvm.org/D133092 Files: clang/lib/Driver/ToolChains/CommonArgs.c

Re: [clang] b7a7aee - [clang] Qualify auto in range-based for loops (NFC)

FWIW, sweeping NFC changes like this cause a fair amount of code churn (which makes tools like git blame a bit harder to use) for a relatively small improvement to code readability, which is why our developer policy asks that you "Avoid committing formatting- or whitespace-only changes outside of c

[PATCH] D133088: [Clang] Fix wrong diagnostic for scope identifier with internal linkage

junaire updated this revision to Diff 457855. junaire added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133088/new/ https://reviews.llvm.org/D133088 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Basic/DiagnosticSem

[PATCH] D132131: [clang-format] Adds a formatter for aligning trailing comments over empty lines

yusuke-kadowaki updated this revision to Diff 457864. yusuke-kadowaki marked 8 inline comments as done. yusuke-kadowaki added a comment. - Revert doc - Revert rst as well - Apply format - Update implementation to deal with the setting of MaxEmptyLinesToKeep - Add test for the combination with MaxE

[PATCH] D132131: [clang-format] Adds a formatter for aligning trailing comments over empty lines

yusuke-kadowaki added inline comments. Comment at: clang/docs/ClangFormatStyleOptions.rst:3698 - QualifierOrder: ['inline', 'static', 'type', 'const'] + QualifierOrder: ['inline', 'static' , 'type', 'const'] HazardyKnusperkeks wrote: > Anyone knows

[clang] a46154c - [analyzer] Warn if the size of the array in `new[]` is undefined

Author: isuckatcs Date: 2022-09-04T23:06:58+02:00 New Revision: a46154cb1cd09aa26bc803d8696e6e9283aac6a9 URL: https://github.com/llvm/llvm-project/commit/a46154cb1cd09aa26bc803d8696e6e9283aac6a9 DIFF: https://github.com/llvm/llvm-project/commit/a46154cb1cd09aa26bc803d8696e6e9283aac6a9.diff LOG

[PATCH] D131299: [analyzer] Warn if the size of the array in `new[]` is undefined

This revision was automatically updated to reflect the committed changes. Closed by commit rGa46154cb1cd0: [analyzer] Warn if the size of the array in `new[]` is undefined (authored by isuckatcs). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github

[PATCH] D132713: [clang-tidy] Skip union-like classes in use-equals-default

alexander-shaposhnikov added a comment. gentle ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132713/new/ https://reviews.llvm.org/D132713 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http

[PATCH] D128750: [C++20] Implement P2113R0: Changes to the Partial Ordering of Constrained Functions

mizvekov added inline comments. Comment at: clang/include/clang/Sema/SemaConcept.h:48-52 + if (ArgA.getKind() == TemplateArgument::Expression && + ArgB.getKind() == TemplateArgument::Expression && + ArgA.getAsExpr()->getType()->isUndeducedAutoType() && +

[clang] baa9eae - [NFC] fix incorrect indentation in docs

Author: Chuanqi Xu Date: 2022-09-05T11:05:23+08:00 New Revision: baa9eae279c1639f406015734ebbf4c429b15c21 URL: https://github.com/llvm/llvm-project/commit/baa9eae279c1639f406015734ebbf4c429b15c21 DIFF: https://github.com/llvm/llvm-project/commit/baa9eae279c1639f406015734ebbf4c429b15c21.diff LO

[PATCH] D132192: [RISCV] Add '32bit' feature to rv32 only builtins.

craig.topper added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:4359 -return Diag(TheCall->getCallee()->getBeginLoc(), -diag::err_32_bit_builtin_64_bit_tgt); - luismarques wrote: > That tablegen def is still being used for X86.

[PATCH] D132952: [Sema] disable -Wvla for function array parameters

inclyc added inline comments. Comment at: clang/test/Sema/warn-vla.c:8-12 +void test2(int n, int v[n]) { // c99 no-warning +#if __STDC_VERSION__ < 199901L +// expected-warning@-2{{variable length arrays are a C99 feature}} +#endif } aaron.ballman wrote: > The di

[clang] 36a1ca5 - [ASTReader] Fix -Wunused-private-field in non-assertion builds after D128490. NFC

Author: Fangrui Song Date: 2022-09-04T23:48:55-07:00 New Revision: 36a1ca5835e0f7e0e02899d97cd2e4c7bf704361 URL: https://github.com/llvm/llvm-project/commit/36a1ca5835e0f7e0e02899d97cd2e4c7bf704361 DIFF: https://github.com/llvm/llvm-project/commit/36a1ca5835e0f7e0e02899d97cd2e4c7bf704361.diff

[PATCH] D132607: [OffloadPackager] Add ability to extract images from other file types

saiislam accepted this revision. saiislam added a comment. This revision is now accepted and ready to land. LGTM. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132607/new/ https://reviews.llvm.org/D132607 __