[PATCH] D133180: [MinGW] Ignore -fvisibility/-fvisibility-inlines-hidden for dllexport

2022-09-01 Thread Martin Storsjö via Phabricator via cfe-commits
mstorsjo accepted this revision. mstorsjo added a comment. This revision is now accepted and ready to land. This LGTM, but one question about the test. Thanks! Comment at: clang/test/CodeGenCXX/dllstorage-hidden.cpp:3 + +// RUN: %clang_cc1 -triple x86_64-windows-msvc -fms-exten

[PATCH] D123450: [clang-format] Parse Verilog if statements

2022-09-01 Thread Owen Pan via Phabricator via cfe-commits
owenpan added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:2592 - if (FormatTok->is(tok::l_brace)) { + if (Keywords.isBlockBegin(*FormatTok, Style)) { FormatTok->setFinalizedType(TT_ControlStatementLBrace); This is likely the cul

<    1   2   3