[PATCH] D132962: [clangd][ObjC] Improve completions for protocols + category names

dgoldman updated this revision to Diff 457067. dgoldman added a comment. Run clang format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132962/new/ https://reviews.llvm.org/D132962 Files: clang-tools-extra/clangd/CodeComplete.cpp clang-tools-e

[clang] 960e7a5 - [msan] Use Debug Info to point to affected fields

Author: Vitaly Buka Date: 2022-08-31T13:12:17-07:00 New Revision: 960e7a5513267b38a07405931300bbf40ddf1902 URL: https://github.com/llvm/llvm-project/commit/960e7a5513267b38a07405931300bbf40ddf1902 DIFF: https://github.com/llvm/llvm-project/commit/960e7a5513267b38a07405931300bbf40ddf1902.diff L

[PATCH] D132909: [msan] Use Debug Info to point to affected fields

This revision was automatically updated to reflect the committed changes. Closed by commit rG960e7a551326: [msan] Use Debug Info to point to affected fields (authored by vitalybuka). Changed prior to commit: https://reviews.llvm.org/D132909?vs=456541&id=457069#toc Repository: rG LLVM Github

[PATCH] D133044: [Frontend] Restore Preprocessor::getPredefines()

royjacobson updated this revision to Diff 457070. royjacobson edited the summary of this revision. royjacobson added a comment. Add a link to github issue. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133044/new/ https://reviews.llvm.org/D133044

[PATCH] D133044: [Frontend] Restore Preprocessor::getPredefines()

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGbb9dedce5d01: [Frontend] Restore Preprocessor::getPredefines() (authored by royjacobson). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang] bb9dedc - [Frontend] Restore Preprocessor::getPredefines()

Author: Roy Jacobson Date: 2022-08-31T23:16:49+03:00 New Revision: bb9dedce5d01f5608acd784942481f386c710c0d URL: https://github.com/llvm/llvm-project/commit/bb9dedce5d01f5608acd784942481f386c710c0d DIFF: https://github.com/llvm/llvm-project/commit/bb9dedce5d01f5608acd784942481f386c710c0d.diff

[PATCH] D132991: [Clang] Give error message for invalid profile path when compiling IR

aidengrossman updated this revision to Diff 457074. aidengrossman added a comment. Changed error message from "Could not read profile" to "Error in reading profile" to better reflect the fact that profile reading can fail for multiple reasons, not just when the file path cannot be read/does not

[PATCH] D132421: [HLSL] Support PCH for cc1 mode

python3kgae updated this revision to Diff 457081. python3kgae added a comment. Move reuse decl in PCH into BuiltinTypeDeclBuilder. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132421/new/ https://reviews.llvm.org/D132421 Files: clang/include/cl

[PATCH] D132421: [HLSL] Support PCH for cc1 mode

python3kgae marked an inline comment as done. python3kgae added inline comments. Comment at: clang/include/clang/Sema/HLSLExternalSemaSource.h:58 +/// them before we initialize the ExternalSemaSource base class. +struct ChainedHLSLExternalSemaSourceMembers { + ChainedHLSLExterna

[PATCH] D133052: [clang] Avoid crash when expanding conversion templates in concepts.

luken-google created this revision. Herald added a project: All. luken-google requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fixes https://github.com/llvm/llvm-project/issues/50891 Repository: rG LLVM Github Monorepo https://reviews.l

[PATCH] D133052: [clang] Avoid crash when expanding conversion templates in concepts.

luken-google updated this revision to Diff 457084. luken-google added a comment. Remove extraneous header inclusion. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133052/new/ https://reviews.llvm.org/D133052 Files: clang/docs/ReleaseNotes.rst

[PATCH] D116266: [SPIR-V] Add linking of separate translation units using spirv-link

Anastasia added inline comments. Herald added a subscriber: MaskRay. Herald added a project: All. Comment at: clang/docs/UsersManual.rst:3602 +Linking is done using ``spirv-link`` from `the SPIRV-Tools project +`_. Similar to

[PATCH] D132421: [HLSL] Support PCH for cc1 mode

beanz added inline comments. Comment at: clang/include/clang/Sema/HLSLExternalSemaSource.h:58 +/// them before we initialize the ExternalSemaSource base class. +struct ChainedHLSLExternalSemaSourceMembers { + ChainedHLSLExternalSemaSourceMembers(ExternalSemaSource *ExtSema)

[PATCH] D133052: [clang] Avoid crash when expanding conversion templates in concepts.

luken-google added a reviewer: ilya-biryukov. luken-google added a comment. I'm open to other suggestions if this doesn't seem like the right approach. The problem is the concept evaluation code is fairly separated in the call stack from this Sema code, so it's hard to think of a minimal change

[PATCH] D102107: [OpenMP] Codegen aggregate for outlined function captures

jdoerfert accepted this revision. jdoerfert added a comment. LG, the new remarks need to be addressed in a follow up. Please test for them and make a TODO that they should be optimized away. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102107/new/

[PATCH] D132975: [clang][BOLT] Add clang-bolt target (WIP)

Amir updated this revision to Diff 457102. Amir added a comment. Succeeded instrumenting Clang with BOLT Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132975/new/ https://reviews.llvm.org/D132975 Files: clang/CMakeLists.txt clang/cmake/caches/

[PATCH] D129488: [Sema] Delay evaluation of std::source_location::current() in default arguments

jyknight added a comment. In D129488#3761478 , @ilya-biryukov wrote: > In D129488#3761398 , @jyknight > wrote: > >> I believe this should print `fn=14 fn2=14`. I don't see how we can get that >> by special-casi

[PATCH] D132998: [clang-tidy] Restrict use-equals-default to c++11-or-later

alexander-shaposhnikov added a comment. Regarding the practical side - yeah, I've come across this issue (and others) while trying to run this check over a few large codebases (including LLVM and Chrome), and this particular issue accounts of a few hundreds of build breakages. Repository: rG

[PATCH] D133052: [clang] Avoid crash when expanding conversion templates in concepts.

ychen added a comment. Like mentioned in https://stackoverflow.com/questions/68853472/is-this-a-bug-in-clangs-c20-concepts-implementation-unnecessary-checking-of, could we not go down the path of considering conversion candidates? It seems that's blessed by the standard. Repository: rG LLVM

[PATCH] D133066: fix a typo in comment of AddConversionCandidate

zhouyizhou created this revision. zhouyizhou added reviewers: MikeStump, riccibruno, rsmith. Herald added a project: All. zhouyizhou requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Hi I think the comment above the condition expression ICS.

[PATCH] D133006: [clang-tidy] Skip copy assignment operators with nonstandard return types

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. Looks good! Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133006/new/ https://reviews.llvm.org/D133006 ___ cfe-comm

[PATCH] D133072: WIP: [clang] fix profiling of template arguments of template and declaration kind

mizvekov created this revision. Herald added projects: clang, libc++, All. Herald added subscribers: libcxx-commits, cfe-commits. Herald added a reviewer: libc++. mizvekov requested review of this revision. Template arguments of template and declaration kind were being profiled only by their canon

[PATCH] D133009: [libclang] Fix conversion from `StringRef` to `CXString`

aaronpuchert added inline comments. Comment at: clang/test/Index/comment-lots-of-unknown-commands.c:3 +// XFAIL: * + egorzhdan wrote: > gribozavr2 wrote: > > egorzhdan wrote: > > > This test was never properly passing. Because of the bug in string > > > conver

[PATCH] D132998: [clang-tidy] Restrict use-equals-default to c++11-or-later

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. In D132998#3762578 , @alexander-shaposhnikov wrote: > Regarding the practical side - yeah, I've come across this issue (and others) > while trying to

[PATCH] D132550: Changes to code ownership in clang and clang-tidy

alexfh accepted this revision. alexfh added a comment. LGTM. Thanks for driving this! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132550/new/ https://reviews.llvm.org/D132550 ___ cfe-commits mailing li

[clang] 98615fd - [Driver] Remove Joined -X

Author: Fangrui Song Date: 2022-08-31T17:30:51-07:00 New Revision: 98615fd376cea15af21e120e0e3ffa5ba68c2b6d URL: https://github.com/llvm/llvm-project/commit/98615fd376cea15af21e120e0e3ffa5ba68c2b6d DIFF: https://github.com/llvm/llvm-project/commit/98615fd376cea15af21e120e0e3ffa5ba68c2b6d.diff

[clang] 23ce683 - [Driver] Remove Joined -Z and err_drv_use_of_Z_option

Author: Fangrui Song Date: 2022-08-31T17:58:04-07:00 New Revision: 23ce683eea358f0cf82ef51692bba6c86ffcf4a8 URL: https://github.com/llvm/llvm-project/commit/23ce683eea358f0cf82ef51692bba6c86ffcf4a8 DIFF: https://github.com/llvm/llvm-project/commit/23ce683eea358f0cf82ef51692bba6c86ffcf4a8.diff

[clang] 58a4b4f - [Driver][test] Fix incorrect -arch= -amx-int8

Author: Fangrui Song Date: 2022-08-31T18:13:16-07:00 New Revision: 58a4b4fcebf45eecafab00d006de019d76f828d8 URL: https://github.com/llvm/llvm-project/commit/58a4b4fcebf45eecafab00d006de019d76f828d8 DIFF: https://github.com/llvm/llvm-project/commit/58a4b4fcebf45eecafab00d006de019d76f828d8.diff

[clang] 08d9912 - [Driver] Remove unimplemented Joined -a / --profile-blocks

Author: Fangrui Song Date: 2022-08-31T18:13:16-07:00 New Revision: 08d9912d1c599b5d79d4f2cd6f6be2cdb2bbfa83 URL: https://github.com/llvm/llvm-project/commit/08d9912d1c599b5d79d4f2cd6f6be2cdb2bbfa83 DIFF: https://github.com/llvm/llvm-project/commit/08d9912d1c599b5d79d4f2cd6f6be2cdb2bbfa83.diff

[PATCH] D132636: [X86][bugfix] redefine __SSC_MARK to escape cpp string literal concatenation problem

This revision was automatically updated to reflect the committed changes. Closed by commit rG2da0df5e7cac: [X86][bugfix] redefine __SSC_MARK to escape cpp string literal concatenation… (authored by xiangzhangllvm). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository:

[clang] 2da0df5 - [X86][bugfix] redefine __SSC_MARK to escape cpp string literal concatenation problem

Author: Xiang1 Zhang Date: 2022-09-01T09:37:23+08:00 New Revision: 2da0df5e7cac2d06e0632522a3451e3a2dbd1a37 URL: https://github.com/llvm/llvm-project/commit/2da0df5e7cac2d06e0632522a3451e3a2dbd1a37 DIFF: https://github.com/llvm/llvm-project/commit/2da0df5e7cac2d06e0632522a3451e3a2dbd1a37.diff

[PATCH] D132568: [clang][Sema] check default argument promotions for printf

inclyc updated this revision to Diff 457153. inclyc added a comment. Update comments according to review feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132568/new/ https://reviews.llvm.org/D132568 Files: clang/docs/ReleaseNotes.rst cla

[clang] e3bd67e - [clang][Sema] check default argument promotions for printf

Author: YingChi Long Date: 2022-09-01T10:10:10+08:00 New Revision: e3bd67eddf65b20956513e91715b1f997dae2690 URL: https://github.com/llvm/llvm-project/commit/e3bd67eddf65b20956513e91715b1f997dae2690 DIFF: https://github.com/llvm/llvm-project/commit/e3bd67eddf65b20956513e91715b1f997dae2690.diff

[PATCH] D132568: [clang][Sema] check default argument promotions for printf

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe3bd67eddf65: [clang][Sema] check default argument promotions for printf (authored by inclyc). Changed prior to commit: https://reviews.llvm.org/D

[PATCH] D133052: [clang] Avoid crash when expanding conversion templates in concepts.

luken-google added a comment. In D133052#3762596 , @ychen wrote: > Like mentioned in > https://stackoverflow.com/questions/68853472/is-this-a-bug-in-clangs-c20-concepts-implementation-unnecessary-checking-of, > could we not go down the path of consideri

[PATCH] D133082: WIP: [clang] Implement setting crash_diagnostics_dir through env variable

mizvekov created this revision. Herald added subscribers: libcxx-commits, cfe-commits, arichardson. Herald added projects: clang, libc++, All. Herald added a reviewer: libc++. mizvekov requested review of this revision. Herald added a subscriber: MaskRay. This implements setting the equivalent of

[PATCH] D133082: WIP: [clang] Implement setting crash_diagnostics_dir through env variable

mizvekov updated this revision to Diff 457159. mizvekov planned changes to this revision. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133082/new/ https://reviews.llvm.org/D133082 Files: clang/docs/ReleaseNotes.rst clang/lib/Driver/Driver.cpp

[PATCH] D132997: [clang][Interp] Handle DeclRefExpr of reference types

shafik added a comment. I think like @aaron.ballman was saying in another PR you should aim for as complete set of tests as possible even if you have to comment one that can't work yet. For example cases that would involve `MemberExpr` or `UsingShadow` for example as well as the cases you menti

[PATCH] D133085: [clang] trim trailing space in format tests. NFC

inclyc created this revision. inclyc added a reviewer: clang-language-wg. Herald added a project: All. inclyc requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Found in https://reviews.llvm.org/D132568 Repository: rG LLVM Github Monorepo

[PATCH] D133029: [Sema] Allow to diagnose the references to std::vector with incomplete T

shafik added a comment. Do you have an idea of how common this might be? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133029/new/ https://reviews.llvm.org/D133029 ___ cfe-commits mailing list cfe-commit

[PATCH] D133087: [Docs] fix wrong example of warping class definitions

Passw created this revision. Herald added a project: All. Passw requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. example of BraceWrapping AfterClass is wrong Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D133087

[PATCH] D133088: [Clang] Fix wrong diagnostic for scope identifier with internal linkage

junaire created this revision. junaire added a reviewer: aaron.ballman. Herald added a project: All. junaire requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. If the declaration of an identifier has block scope, and the identifier has externa

[PATCH] D133088: [Clang] Fix wrong diagnostic for scope identifier with internal linkage

junaire updated this revision to Diff 457171. junaire added a comment. Simpify code a little bit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133088/new/ https://reviews.llvm.org/D133088 Files: clang/docs/ReleaseNotes.rst clang/include/clang

[PATCH] D132421: [HLSL] Support PCH for cc1 mode

python3kgae marked an inline comment as done. python3kgae added inline comments. Comment at: clang/include/clang/Sema/HLSLExternalSemaSource.h:58 +/// them before we initialize the ExternalSemaSource base class. +struct ChainedHLSLExternalSemaSourceMembers { + ChainedHLSLExterna

[PATCH] D132975: [clang][BOLT] Add clang-bolt target (WIP)

Amir updated this revision to Diff 457172. Amir added a comment. Successfully invoke the bootstrap/profiling build Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132975/new/ https://reviews.llvm.org/D132975 Files: clang/CMakeLists.txt clang/cma

[PATCH] D133085: [clang] trim trailing space in format tests. NFC

ChuanqiXu added subscribers: aaron.ballman, ChuanqiXu. ChuanqiXu accepted this revision. ChuanqiXu added a comment. This revision is now accepted and ready to land. Do you have commit access? If you have, I remember LLVM encourages such fixes landed directly without review. (+ @aaron.ballman to m

[PATCH] D133052: [clang] Avoid crash when expanding conversion templates in concepts.

ychen added a comment. In D133052#3763041 , @luken-google wrote: > In D133052#3762596 , @ychen wrote: > >> Like mentioned in >> https://stackoverflow.com/questions/68853472/is-this-a-bug-in-clangs-c20-concepts-i

[PATCH] D133085: [clang] trim trailing space in format tests. NFC

This revision was automatically updated to reflect the committed changes. Closed by commit rG5ee51e815425: [clang] trim trailing space in format tests. NFC (authored by inclyc). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133085/new/ https://revie

[clang] 5ee51e8 - [clang] trim trailing space in format tests. NFC

Author: YingChi Long Date: 2022-09-01T13:30:40+08:00 New Revision: 5ee51e8154253088b333c8e82c64d0f00d7d0524 URL: https://github.com/llvm/llvm-project/commit/5ee51e8154253088b333c8e82c64d0f00d7d0524 DIFF: https://github.com/llvm/llvm-project/commit/5ee51e8154253088b333c8e82c64d0f00d7d0524.diff

[PATCH] D133085: [clang] trim trailing space in format tests. NFC

inclyc added a comment. In D133085#3763198 , @ChuanqiXu wrote: > Do you have commit access? If you have, I remember LLVM encourages to land > such fixes directly without reviewed. (+ @aaron.ballman to make sure) Thanks! I'm just not sure whether these c

[PATCH] D133092: [clang] fix generation of .debug_aranges with LTO

azat created this revision. Herald added a subscriber: inglorion. Herald added a project: All. azat requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. Right now in case of LTO the section is not emited: $ cat test.c void __attribu

[PATCH] D129488: [Sema] Delay evaluation of std::source_location::current() in default arguments

ChuanqiXu added a comment. In D129488#3760982 , @ilya-biryukov wrote: > @aaron.ballman, that's my reading of the standard as well. Do you think we > should proceed with the current approach or is there another direction worth > pursuing to make source_

[PATCH] D132991: [Clang] Give error message for invalid profile path when compiling IR

aidengrossman updated this revision to Diff 457179. aidengrossman added a comment. Fix tests and replace error message in CodeGenModule with assertion since we're now capturing the error message in CompileInvocation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revi

[PATCH] D133092: [clang] fix generation of .debug_aranges with LTO

azat updated this revision to Diff 457182. azat added a comment. Add test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133092/new/ https://reviews.llvm.org/D133092 Files: clang/lib/Driver/ToolChains/CommonArgs.cpp clang/test/Driver/debug-opti

[PATCH] D132975: [clang][BOLT] Add clang-bolt target (WIP)

phosek added a comment. This was already on my list of build system features I'd like to implement and I'm glad someone else is already looking into it, thank you! I have two high level comments about your approach. The first one is related to the use of Clang build as the training data. I thi

[PATCH] D133093: [clang-format] Fix a bug in merging blocks with a wrapped l_brace

owenpan created this revision. owenpan added reviewers: HazardyKnusperkeks, MyDeveloperDay, curdeius. owenpan added a project: clang-format. Herald added a project: All. owenpan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. When the openi

[PATCH] D133094: [X86] Add missing key feature for core2

FreddyYe created this revision. Herald added a subscriber: hiraditya. Herald added a project: All. FreddyYe requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D1

<    1   2