[PATCH] D132209: [Clang][OpenMP] Make copyin clause on combined and composite construct work

yutsumi updated this revision to Diff 454394. yutsumi added a comment. add a clang unit test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132209/new/ https://reviews.llvm.org/D132209 Files: clang/lib/CodeGen/CGStmtOpenMP.cpp clang/test/OpenMP

[PATCH] D131685: [clang][AST] RecursiveASTVisitor should visit owned TagDecl of friend type.

balazske updated this revision to Diff 454408. balazske marked 4 inline comments as done. balazske added a comment. - Removed FIXME comment - Updated test: check AST exactly Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131685/new/ https://reviews.

[PATCH] D132316: [CMake] `${LLVM_BINARY_DIR}/lib(${LLVM_LIBDIR_SUFFIX})?` -> `${LLVM_LIBRARY_DIR}`

sebastian-ne added inline comments. Comment at: llvm/tools/llvm-shlib/CMakeLists.txt:89 - set(LLVM_EXPORTED_SYMBOL_FILE ${LLVM_BINARY_DIR}/libllvm-c.exports) The lib here is not used as a folder, so this should probably not be replaced? It should probably in

[clang-tools-extra] 3c2cb8e - [clangd] Disable IncludeCleaner for ObjC

Author: Kadir Cetinkaya Date: 2022-08-22T11:28:06+02:00 New Revision: 3c2cb8e2f09b4ed48c83bda2551de82f2ded1d1d URL: https://github.com/llvm/llvm-project/commit/3c2cb8e2f09b4ed48c83bda2551de82f2ded1d1d DIFF: https://github.com/llvm/llvm-project/commit/3c2cb8e2f09b4ed48c83bda2551de82f2ded1d1d.dif

[PATCH] D131665: [CMake] Support passing arguments to build tool (bootstrap).

russell.gallop resigned from this revision. russell.gallop added a comment. Resign as reviewer as I work with Carlos (and am not familiar enough with the details of this area). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131665/new/ https://revi

[PATCH] D131614: [clang][dataflow] Extend transfer functions for other `CFGElement`s

sgatev added inline comments. Comment at: clang/include/clang/Analysis/FlowSensitive/DataflowAnalysis.h:103 + /// code being analysed. + virtual void transferCFGElement(const CFGElement *Element, Lattice &L, + Environment &Env) {} --

[PATCH] D121779: [RISCV] Add zihintntl compressed instructions

alextsao1999 updated this revision to Diff 454433. alextsao1999 added a comment. Fix check no c Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121779/new/ https://reviews.llvm.org/D121779 Files: llvm/lib/Target/RISCV/RISCVInstrInfoC.td llvm/tes

[PATCH] D121779: [RISCV] Add zihintntl compressed instructions

alextsao1999 marked an inline comment as done. alextsao1999 added inline comments. Comment at: llvm/test/MC/RISCV/rv32zihintntlc-valid.s:42 +# CHECK-ASM: encoding: [0x16,0x90] +c.ntl.all kito-cheng wrote: > Could you add an invalid check for `c.ntl` instruction t

[PATCH] D131469: [Clang] change default storing path of `-ftime-trace`

dongjunduo updated this revision to Diff 454439. dongjunduo added a comment. Restyle code Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131469/new/ https://reviews.llvm.org/D131469 Files: clang/lib/Driver/Driver.cpp clang/test/Driver/check-tim

[PATCH] D131469: [Clang] change default storing path of `-ftime-trace`

dongjunduo marked 7 inline comments as done. dongjunduo added inline comments. Comment at: clang/lib/Driver/Driver.cpp:4674 +for (auto &J : C.getJobs()) { + if (J.getSource().getKind() == Action::LinkJobClass && + !J.getOutputFilenames().empty()) { -

[PATCH] D130255: [Clang][LoongArch] Add initial LoongArch target and driver support

SixWeining updated this revision to Diff 454446. SixWeining added a comment. Use `-fsyntax-only`; `-check-prefix` to `--check-prefix`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130255/new/ https://reviews.llvm.org/D130255 Files: clang/lib/Ba

[clang] 3c48263 - [analyzer] Remove pattern matching of lambda capture initializers

Author: isuckatcs Date: 2022-08-22T13:00:31+02:00 New Revision: 3c482632e64c1a3e4967db325562f2e353513abc URL: https://github.com/llvm/llvm-project/commit/3c482632e64c1a3e4967db325562f2e353513abc DIFF: https://github.com/llvm/llvm-project/commit/3c482632e64c1a3e4967db325562f2e353513abc.diff LOG

[PATCH] D131944: [analyzer] Remove pattern matching of lambda capture initializers

This revision was automatically updated to reflect the committed changes. Closed by commit rG3c482632e64c: [analyzer] Remove pattern matching of lambda capture initializers (authored by isuckatcs). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github

[PATCH] D131533: [Flang][Driver] Enable PIC in the frontend

awarzynski accepted this revision. awarzynski added a comment. Thanks for all the updates and for working on this! I'm not an expert in the semantics of `-fpie`/`-fpic`/`-mrelocation-model`, but this basically replicates the logic in Clang and I am not aware of any good reasons for Flang to div

[PATCH] D131665: [CMake] Support passing arguments to build tool (bootstrap).

andrewng resigned from this revision. andrewng added a comment. Resign as reviewer as I also work with Carlos and helped to author this patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131665/new/ https://reviews.llvm.org/D131665 _

[clang] c81bf94 - [analyzer] Handling non-POD multidimensional arrays in ArrayInitLoopExpr

Author: isuckatcs Date: 2022-08-22T13:53:53+02:00 New Revision: c81bf940c77ee9439eb1f63011e7ecf0e07c56d9 URL: https://github.com/llvm/llvm-project/commit/c81bf940c77ee9439eb1f63011e7ecf0e07c56d9 DIFF: https://github.com/llvm/llvm-project/commit/c81bf940c77ee9439eb1f63011e7ecf0e07c56d9.diff LOG

[PATCH] D131840: [analyzer] Handling non-POD multidimensional arrays in ArrayInitLoopExpr

This revision was automatically updated to reflect the committed changes. Closed by commit rGc81bf940c77e: [analyzer] Handling non-POD multidimensional arrays in ArrayInitLoopExpr (authored by isuckatcs). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM

[PATCH] D132209: [Clang][OpenMP] Make copyin clause on combined and composite construct work

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132209/new/ https://reviews.llvm.org/D132209 ___

[PATCH] D127293: [clang-tidy] Ignore other members in a union if any member of it is initialized in cppcoreguidelines-pro-type-member-init

Sockke added a comment. Friendly ping @LegalizeAdulthood. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127293/new/ https://reviews.llvm.org/D127293 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailma

[PATCH] D132324: [RFC] Remove support for building libc++ with `LLVM_ENABLE_PROJECTS`

aaron.ballman added a comment. In D132324#3737976 , @Ericson2314 wrote: > Ah I see email about sphinx jobs defined out of tree :/ I will take a look at > that, see if it is easy to fix. This still hasn't been fixed, so none of the documentation is bein

[PATCH] D132290: [clang-tidy] Skip unions in use-equals-default

alexander-shaposhnikov updated this revision to Diff 454470. alexander-shaposhnikov added a comment. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132290/new/ https://reviews.llvm.org/D132290 Files: clang-tools-extra/clang-tidy/

[PATCH] D53847: [C++2a] P0634r3: Down with typename!

erichkeane added a comment. In D53847#3735758 , @erichkeane wrote: > In D53847#3735738 , @ilya-biryukov > wrote: > >> In D53847#3735704 , @erichkeane >> wrote: >> >>> Note

[PATCH] D132372: [X86][AVX512FP16] Add the missing const modifiers. NFCI

pengfei created this revision. pengfei added reviewers: craig.topper, yubing, LuoYuanke, RKSimon, skan, FreddyYe. Herald added a subscriber: StephenFan. Herald added a project: All. pengfei requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. T

[PATCH] D132342: [X86][AVX512FP16] Relax limitation to AVX512FP16 intrinsics. NFCI

pengfei updated this revision to Diff 454475. pengfei added a comment. Rebased on D132372 . > Should the const change be a separate patch? They feel unrelated. Done. The change results in lit test fails. Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[PATCH] D126183: Implement soft reset of the diagnostics engine.

mstorsjo added a comment. FYI, this change caused warnings when built with GCC: [1/1] Building CXX object tools/clang/unittests/Basic/CMakeFiles/BasicTests.dir/DiagnosticTest.cpp.o ../tools/clang/unittests/Basic/DiagnosticTest.cpp:17:6: warning: ‘void clang::DiagnosticsTestHelper(clang::Dia

[PATCH] D132372: [X86][AVX512FP16] Add the missing const modifiers. NFCI

RKSimon accepted this revision. RKSimon added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132372/new/ https://reviews.llvm.org/D132372 _

[PATCH] D132141: [X86] Emulate _rdrand64_step with two rdrand32 if it is 32bit

RKSimon added inline comments. Comment at: clang/lib/Headers/immintrin.h:301 + unsigned long long tmp; + if (__builtin_ia32_rdrand32_step((unsigned int *)&tmp) & + __builtin_ia32_rdrand32_step(((unsigned int *)&tmp) + 1)) { RKSimon wrote: > craig.topper wr

[PATCH] D131853: [clangd] Add doxygen parsing for Hover

tom-anders added reviewers: sammccall, nridge. tom-anders added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131853/new/ https://reviews.llvm.org/D131853 ___ cfe-commits mailing list cfe

[PATCH] D131990: [DRAFT][WebAssembly] Do not support `[[clang::musttail]]` by default

brianosman added a comment. I agree that the front-end error is preferable. In addition to front-end vs. back-end distinction being important -- it's also ignorable (if someone wants to do that). Is the goal to also make __has_cpp_attribute(clang::musttail) resolve to 0? I think that's the ide

[PATCH] D132141: [X86] Emulate _rdrand64_step with two rdrand32 if it is 32bit

yubing added inline comments. Comment at: clang/lib/Headers/immintrin.h:301 + unsigned long long tmp; + if (__builtin_ia32_rdrand32_step((unsigned int *)&tmp) & + __builtin_ia32_rdrand32_step(((unsigned int *)&tmp) + 1)) { RKSimon wrote: > RKSimon wrote: >

[clang] e2ab606 - Add N2562 to the C status page

Author: Aaron Ballman Date: 2022-08-22T09:46:12-04:00 New Revision: e2ab6061a976400df672842dc2af76b527fa421a URL: https://github.com/llvm/llvm-project/commit/e2ab6061a976400df672842dc2af76b527fa421a DIFF: https://github.com/llvm/llvm-project/commit/e2ab6061a976400df672842dc2af76b527fa421a.diff

[PATCH] D132266: [Clang][SemaChecking] move %hh and %h -Wformat warnings to -Wformat-pedantic

aaron.ballman added a comment. Thanks for working on this @nickdesaulniers! I think we actually want to go a slightly different direction than this and disable the diagnostics entirely. Basically, we should be make sure the format specifier diagnostics are accounting for the clarifications in

[PATCH] D113107: Support of expression granularity for _Float16.

zahiraam added a comment. In D113107#3736325 , @rjmccall wrote: > In D113107#3736312 , @zahiraam > wrote: > >> This is a reduced test case from the codegen/complex-strictfp.c >> >> _Complex double g1, g2; >> doub

[PATCH] D128619: [Clang] Implement P0848 (Conditionally Trivial Special Member Functions)

aaron.ballman added inline comments. Comment at: clang/lib/Frontend/InitPreprocessor.cpp:677 //Builder.defineMacro("__cpp_aggregate_paren_init", "201902L"); -Builder.defineMacro("__cpp_concepts", "201907L"); +Builder.defineMacro("__cpp_concepts", "202002L"); Bui

[PATCH] D132266: [Clang][SemaChecking] move %hh and %h -Wformat warnings to -Wformat-pedantic

inclyc added a comment. In D132266#3739513 , @aaron.ballman wrote: > Thanks for working on this @nickdesaulniers! I think we actually want to go a > slightly different direction than this and disable the diagnostics entirely. > Basically, we should be

[PATCH] D128619: [Clang] Implement P0848 (Conditionally Trivial Special Member Functions)

erichkeane added inline comments. Comment at: clang/lib/Frontend/InitPreprocessor.cpp:677 //Builder.defineMacro("__cpp_aggregate_paren_init", "201902L"); -Builder.defineMacro("__cpp_concepts", "201907L"); +Builder.defineMacro("__cpp_concepts", "202002L"); Builde

[PATCH] D131469: [Clang] change default storing path of `-ftime-trace`

jamieschmeiser added inline comments. Comment at: clang/lib/Driver/Driver.cpp:4667 + // Whether `-ftime-trace` or `-ftime-trace=` are specified + if (!TimeTrace && !TimeTraceFile) return; + The return should be on the next line. Did you run this through clang-

[PATCH] D132141: [X86] Emulate _rdrand64_step with two rdrand32 if it is 32bit

RKSimon added inline comments. Comment at: clang/lib/Headers/immintrin.h:301 + unsigned long long tmp; + if (__builtin_ia32_rdrand32_step((unsigned int *)&tmp) & + __builtin_ia32_rdrand32_step(((unsigned int *)&tmp) + 1)) { yubing wrote: > RKSimon wrote: >

[PATCH] D132302: [clang] Add support for __attribute__((guard(nocf)))

aaron.ballman added a comment. There should be some explicit test coverage that show the new attribute spelling(s) work when spelled directly rather than when relying on predefined macros. Comment at: clang/include/clang/Basic/Attr.td:3496 // we might also want to support

[clang] df23fc4 - [X86][AVX512FP16] Add the missing const modifiers. NFCI

Author: Phoebe Wang Date: 2022-08-22T22:07:42+08:00 New Revision: df23fc4f7fe7b9210217cbd37c409fc76d4ff136 URL: https://github.com/llvm/llvm-project/commit/df23fc4f7fe7b9210217cbd37c409fc76d4ff136 DIFF: https://github.com/llvm/llvm-project/commit/df23fc4f7fe7b9210217cbd37c409fc76d4ff136.diff L

[PATCH] D132372: [X86][AVX512FP16] Add the missing const modifiers. NFCI

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGdf23fc4f7fe7: [X86][AVX512FP16] Add the missing const modifiers. NFCI (authored by pengfei). Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[PATCH] D132372: [X86][AVX512FP16] Add the missing const modifiers. NFCI

pengfei added a comment. Thanks @RKSimon Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132372/new/ https://reviews.llvm.org/D132372 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.l

[PATCH] D132266: [Clang][SemaChecking] move %hh and %h -Wformat warnings to -Wformat-pedantic

inclyc added a comment. N2562.pdf: > Modify 7.21.6.2p12: > ... > Unless a length modifier is specified, t~~T~~he corresponding argument shall > be a pointer to int ~~signed integer~~. Does this clarification statement mean that `hhd` should not be considered to correspond to `int`, but a `sig

[PATCH] D132285: [LoongArch] Implement ABI lowering

xry111 added a comment. In D132285#3737855 , @SixWeining wrote: > Ignore zero-width bit fields and add a test. Thanks! There is a GCC test (https://gcc.gnu.org/r12-7951) which can be used to test if there is any ABI incompatibility between GCC and Cla

[PATCH] D132266: [Clang][SemaChecking] move %hh and %h -Wformat warnings to -Wformat-pedantic

aaron.ballman added a comment. In D132266#3739542 , @inclyc wrote: > In D132266#3739513 , @aaron.ballman > wrote: > >> Thanks for working on this @nickdesaulniers! I think we actually want to go >> a slightly di

[PATCH] D132342: [X86][AVX512FP16] Relax limitation to AVX512FP16 intrinsics. NFCI

RKSimon added inline comments. Comment at: clang/lib/Headers/avx512fp16intrin.h:13 +#ifdef __SSE2__ + Doesn't this have to be the general case like in other places in the headers? ``` #if !(defined(_MSC_VER) || defined(__SCE__)) || __has_feature(modules) ||

[clang] 210a419 - [docs] Adjust the example command line in DebuggingCoroutines.rst

Author: Chuanqi Xu Date: 2022-08-22T22:15:47+08:00 New Revision: 210a4197b4d73388030c63aea6dc51dde3e9166e URL: https://github.com/llvm/llvm-project/commit/210a4197b4d73388030c63aea6dc51dde3e9166e DIFF: https://github.com/llvm/llvm-project/commit/210a4197b4d73388030c63aea6dc51dde3e9166e.diff LO

[PATCH] D132074: [OpenMP] Add option to assert no nested OpenMP parallelism on the GPU

carlo.bertolli added a comment. This looks good, but what happens when the user accidentally adds a nested parallel when this option is turned on? Do we get serial (correct) execution? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132074/new/ http

[PATCH] D132266: [Clang][SemaChecking] move %hh and %h -Wformat warnings to -Wformat-pedantic

aaron.ballman added a comment. In D132266#3739567 , @inclyc wrote: > N2562.pdf: > >> Modify 7.21.6.2p12: >> ... >> Unless a length modifier is specified, t~~T~~he corresponding argument >> shall be a pointer to int ~~signed integer~~. > > Does this clar

[PATCH] D132266: [Clang][SemaChecking] move %hh and %h -Wformat warnings to -Wformat-pedantic

inclyc added a comment. What I'm confusing is Which of the following two explanations is the exact meaning of `hhd`? 1. consumes a 32-bit signed integer, then truncates it *inside* printf 2. consumes an 8-bit signed integer If it is the case 1, we should not emit this warning, but N2562 said tha

[PATCH] D132074: [OpenMP] Add option to assert no nested OpenMP parallelism on the GPU

jhuber6 added a comment. In D132074#3739593 , @carlo.bertolli wrote: > This looks good, but what happens when the user accidentally adds a nested > parallel when this option is turned on? Do we get serial (correct) execution? With the code as it is, it

[PATCH] D132074: [OpenMP] Add option to assert no nested OpenMP parallelism on the GPU

carlo.bertolli accepted this revision. carlo.bertolli added a comment. This revision is now accepted and ready to land. Thanks for explaining. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132074/new/ https://reviews.llvm.org/D132074 ___

[PATCH] D132377: [clang][dataflow] Add `SetupTest` parameter for `AnalysisInputs`.

wyt created this revision. Herald added subscribers: martong, xazax.hun. Herald added a project: All. wyt requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Moves the work required for retrieving annotation states into the `SetupTest` and `Po

[PATCH] D132266: [Clang][SemaChecking] move %hh and %h -Wformat warnings to -Wformat-pedantic

aaron.ballman added a comment. In D132266#3739600 , @inclyc wrote: > What I'm confusing is > Which of the following two explanations is the exact meaning of `hhd`? > > 1. consumes a 32-bit signed integer, then truncates it *inside* printf > 2. consumes an

[PATCH] D131469: [Clang] change default storing path of `-ftime-trace`

dongjunduo updated this revision to Diff 454501. dongjunduo added a comment. Restyle code Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131469/new/ https://reviews.llvm.org/D131469 Files: clang/lib/Driver/Driver.cpp clang/test/Driver/check-tim

[PATCH] D132266: [Clang][SemaChecking] move %hh and %h -Wformat warnings to -Wformat-pedantic

inclyc added a comment. In D132266#3739618 , @aaron.ballman wrote: > In D132266#3739600 , @inclyc wrote: > >> What I'm confusing is >> Which of the following two explanations is the exact meaning of `hhd`? >> >>

[PATCH] D132260: [pseudo] Eliminate a false parse of structured binding declaration.

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/pseudo/lib/cxx/CXX.cpp:164 +bool isStructuredBinding(const ForestNode* N) { + assert(N->symbol() == Symbol::decl_specifier_seq); --

[PATCH] D131469: [Clang] change default storing path of `-ftime-trace`

dongjunduo marked 2 inline comments as done. dongjunduo added inline comments. Comment at: clang/lib/Driver/Driver.cpp:4667 + // Whether `-ftime-trace` or `-ftime-trace=` are specified + if (!TimeTrace && !TimeTraceFile) return; + jamieschmeiser wrote: > The re

[PATCH] D132324: [RFC] Remove support for building libc++ with `LLVM_ENABLE_PROJECTS`

Ericson2314 added a comment. I did a "soft revert" in rG952f90b72b3546d6b6b038d410f07ce520c59b48 which makes it a non-fatal error so everything keeps on working, but I can do a real revert too if that is preferred. Reposito

[PATCH] D132324: [RFC] Remove support for building libc++ with `LLVM_ENABLE_PROJECTS`

Ericson2314 added a comment. https://reviews.llvm.org/rZORG3a209ca6c1b9 This s what I had started doing. but I am not sure it is a very good solution. I think I might write a discourse post with my thoughts. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[PATCH] D132342: [X86][AVX512FP16] Relax limitation to AVX512FP16 intrinsics. NFCI

pengfei added inline comments. Comment at: clang/lib/Headers/avx512fp16intrin.h:13 +#ifdef __SSE2__ + RKSimon wrote: > Doesn't this have to be the general case like in other places in the headers? > ``` > #if !(defined(_MSC_VER) || defined(__SCE__)) || __has_fe

[PATCH] D132379: [Support] Class for response file expansion

sepavloff created this revision. sepavloff added reviewers: rjmccall, kadircet, jackoalan, thakis, rnk. Herald added a subscriber: hiraditya. Herald added a project: All. sepavloff requested review of this revision. Herald added subscribers: llvm-commits, MaskRay. Herald added projects: clang, LLVM

[PATCH] D116203: [clang] adds unary type transformations as compiler built-ins

fdeazeve added a comment. I believe this patch might have broken LLDB bots https://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/46269/ I've confirmed that d2d77e050b32 is good while e9ef45635b77

[PATCH] D116203: [clang] adds unary type transformations as compiler built-ins

fdeazeve added a comment. Forgot to add the failure message: /usr/include/c++/v1/experimental/propagate_const:138:11: error: no template named 'remove_reference_t'; did you mean 'remove_reference'? typedef remove_reference_t())> element_type; Repository: rG LLVM Github Monorepo CHANGE

[PATCH] D132295: [clang-format] Change heuristic for locating lambda template arguments

rymiel updated this revision to Diff 454513. rymiel added a comment. Remove trailing newlines in added format tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132295/new/ https://reviews.llvm.org/D132295 Files: clang/lib/Format/UnwrappedLineP

[PATCH] D126907: Deferred Concept Instantiation Implementation Take 2

Mordante added a subscriber: aaron.ballman. Mordante added a comment. In D126907#3738383 , @erichkeane wrote: > There was a test I dealt with previously where a ton of the header files were > run with modules enabled (and an auto generated files), so I'

[PATCH] D113107: Support of expression granularity for _Float16.

pengfei added inline comments. Comment at: clang/test/CodeGen/X86/Float16-arithmetic.c:42 _Float16 add2(_Float16 a, _Float16 b, _Float16 c) { return a + b + c; } Missing the same ternary operation test in complex tests? Comment at: clang/t

[PATCH] D131614: [clang][dataflow] Extend transfer functions for other `CFGElement`s

wyt updated this revision to Diff 454523. wyt marked 8 inline comments as done. wyt added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131614/new/ https://reviews.llvm.org/D131614 Files: clang/include/clang/Analysis

[PATCH] D132147: [clang][dataflow] Refactor `TestingSupport.h`

wyt updated this revision to Diff 454525. wyt added a comment. Propagate change from parent patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132147/new/ https://reviews.llvm.org/D132147 Files: clang/unittests/Analysis/FlowSensitive/TestingSu

[PATCH] D132377: [clang][dataflow] Add `SetupTest` parameter for `AnalysisInputs`.

wyt updated this revision to Diff 454527. wyt added a comment. Herald added a reviewer: NoQ. Propagate change from parent patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132377/new/ https://reviews.llvm.org/D132377 Files: clang/include/clan

[PATCH] D116203: [clang] adds unary type transformations as compiler built-ins

fdeazeve added a comment. It seems like non-lldb bots are also failing, if it makes it easier to reproduce: https://green.lab.llvm.org/green/view/Clang/job/clang-stage1-RA/30837/consoleFull#-54352964249ba4694-19c4-4d7e-bec5-911270d8a58c Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[PATCH] D131614: [clang][dataflow] Extend transfer functions for other `CFGElement`s

wyt updated this revision to Diff 454532. wyt added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131614/new/ https://reviews.llvm.org/D131614 Files: clang/include/clang/Analysis/FlowSensitive/DataflowAnalysis.h clang/includ

[PATCH] D132324: [RFC] Remove support for building libc++ with `LLVM_ENABLE_PROJECTS`

aaron.ballman added a comment. In D132324#3739646 , @Ericson2314 wrote: > I did a "soft revert" in rG952f90b72b3546d6b6b038d410f07ce520c59b48 > which > makes it a non-fatal error so

[PATCH] D132258: clang/apple: Infer simulator env from -mios-simulator-version-min flag

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. lgtm since it matches xcode clang For the commit message, perhaps the "(Xcode's clang already behaves like this," part should be moved further down, probably to just after "This patch makes it so

[PATCH] D131616: [clang][dataflow] Generalise match switch utility to other AST types and add a `CFGMatchSwitch` which currently handles `CFGStmt` and `CFGInitializer`.

wyt updated this revision to Diff 454534. wyt added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131616/new/ https://reviews.llvm.org/D131616 Files: clang/include/clang/Analysis/FlowSensitive/CFGMatchSwitch.h clang/include/

[PATCH] D132147: [clang][dataflow] Refactor `TestingSupport.h`

wyt updated this revision to Diff 454535. wyt added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132147/new/ https://reviews.llvm.org/D132147 Files: clang/unittests/Analysis/FlowSensitive/TestingSupport.cpp clang/unittests/

[PATCH] D132388: [pseudo] Fix HeadsPartition is not initialized correctly.

hokein created this revision. hokein added a reviewer: sammccall. Herald added a project: All. hokein requested review of this revision. Herald added a subscriber: alextsao1999. Herald added a project: clang-tools-extra. The bug was that if we recover from the token 0, we will make the Heads empty

[PATCH] D126907: Deferred Concept Instantiation Implementation Take 2

aaron.ballman added a comment. In D126907#3739750 , @Mordante wrote: > In D126907#3738383 , @erichkeane > wrote: > >> There was a test I dealt with previously where a ton of the header files >> were run with mod

[PATCH] D132388: [pseudo] Fix HeadsPartition is not initialized correctly.

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132388/new/ https://reviews.llvm.org/D132388 __

[PATCH] D132377: [clang][dataflow] Add `SetupTest` parameter for `AnalysisInputs`.

wyt updated this revision to Diff 454537. wyt added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132377/new/ https://reviews.llvm.org/D132377 Files: clang/unittests/Analysis/FlowSensitive/TestingSupport.cpp clang/unittests/

[PATCH] D132258: clang/apple: Infer simulator env from -mios-simulator-version-min flag

This revision was automatically updated to reflect the committed changes. Closed by commit rG3affbae5300d: clang/apple: Infer simulator env from -mios-simulator-version-min= flag (authored by thakis). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 3affbae - clang/apple: Infer simulator env from -mios-simulator-version-min= flag

Author: Nico Weber Date: 2022-08-22T12:19:34-04:00 New Revision: 3affbae5300dcdf753c954a65ab6a96fcf65c483 URL: https://github.com/llvm/llvm-project/commit/3affbae5300dcdf753c954a65ab6a96fcf65c483 DIFF: https://github.com/llvm/llvm-project/commit/3affbae5300dcdf753c954a65ab6a96fcf65c483.diff LO

[PATCH] D132389: [pseudo] Apply the EOF fallback error-recovery strategy by default.

hokein created this revision. hokein added a reviewer: sammccall. Herald added a project: All. hokein requested review of this revision. Herald added a subscriber: alextsao1999. Herald added a project: clang-tools-extra. Address 2 FIXMEs. Repository: rG LLVM Github Monorepo https://reviews.ll

[PATCH] D126907: Deferred Concept Instantiation Implementation Take 2

erichkeane added a comment. In D126907#3739750 , @Mordante wrote: > In D126907#3738383 , @erichkeane > wrote: > >> There was a test I dealt with previously where a ton of the header files >> were run with module

[PATCH] D132342: [X86][AVX512FP16] Relax limitation to AVX512FP16 intrinsics. NFCI

RKSimon added inline comments. Comment at: clang/lib/Headers/avx512fp16intrin.h:13 +#ifdef __SSE2__ + pengfei wrote: > RKSimon wrote: > > Doesn't this have to be the general case like in other places in the > > headers? > > ``` > > #if !(defined(_MSC_VER) || d

[PATCH] D132266: [Clang][SemaChecking] move %hh and %h -Wformat warnings to -Wformat-pedantic

inclyc added a comment. If some one use `%hhd` with an unmatched type argument. Should we emit diagnose like format specifies type 'int' but the argument has type 'WhateverType' instead of format specifies type 'char' but the argument has type 'WhateverType' ? It's seems that there are m

[PATCH] D116203: [clang] adds unary type transformations as compiler built-ins

cjdb added a comment. In D116203#3739856 , @fdeazeve wrote: > It seems like non-lldb bots are also failing, if it makes it easier to > reproduce: > > https://green.lab.llvm.org/green/view/Clang/job/clang-stage1-RA/30837/consoleFull#-54352964249ba4694-1

[PATCH] D131665: [CMake] Support passing arguments to build tool (bootstrap).

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131665/new/ https://reviews.llvm.org/D131665 ___

[PATCH] D116203: [clang] adds unary type transformations as compiler built-ins

fdeazeve added a comment. In D116203#3740015 , @cjdb wrote: > In D116203#3739856 , @fdeazeve > wrote: > >> It seems like non-lldb bots are also failing, if it makes it easier to >> reproduce: >> >> https://gre

[PATCH] D132266: [Clang][SemaChecking] move %hh and %h -Wformat warnings to -Wformat-pedantic

aaron.ballman added a comment. In D132266#3740013 , @inclyc wrote: > If some one use `%hhd` with an unmatched type argument. Should we emit > diagnose like > > format specifies type 'int' but the argument has type 'WhateverType' > > instead of > > fo

[PATCH] D132379: [Support] Class for response file expansion

thakis added a comment. Can you say what you're trying to do? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132379/new/ https://reviews.llvm.org/D132379 ___ cfe-commits mailing list cfe-commits@lists.llv

[PATCH] D131469: [Clang] change default storing path of `-ftime-trace`

Whitney added inline comments. Comment at: clang/lib/Driver/Driver.cpp:4663 +void InferTimeTracePath(Compilation &C) { + bool TimeTrace = C.getArgs().getLastArg(options::OPT_ftime_trace) != nullptr; + bool TimeTraceFile = Usually bool variable has name that sta

[PATCH] D132286: [clang][Interp] Implement function calls

aaron.ballman added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:603 + if (const auto *FuncDecl = dyn_cast_or_null(Callee)) { +Function *Func = P.getFunction(FuncDecl); + Comment at: clang/lib/AST/Interp/ByteCodeE

[PATCH] D132266: [Clang][SemaChecking] move %hh and %h -Wformat warnings to -Wformat-pedantic

inclyc added a comment. > format specifies type 'short' but the argument has type 'double' (promoted > from 'float') I'm not sure about this. I'm curious about we just consider any integer with width less than or equal to `int` may be specified by `%hhd` ? (Because of default argument promotio

[PATCH] D128619: [Clang] Implement P0848 (Conditionally Trivial Special Member Functions)

royjacobson added inline comments. Comment at: clang/lib/Frontend/InitPreprocessor.cpp:677 //Builder.defineMacro("__cpp_aggregate_paren_init", "201902L"); -Builder.defineMacro("__cpp_concepts", "201907L"); +Builder.defineMacro("__cpp_concepts", "202002L"); Build

[PATCH] D132302: [clang] Add support for __attribute__((guard(nocf)))

alvinhochun updated this revision to Diff 454559. alvinhochun edited the summary of this revision. alvinhochun added a comment. Applied suggestions from Aaron. Thanks for the comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132302/new/ https:

[PATCH] D113107: Support of expression granularity for _Float16.

zahiraam marked an inline comment as done. zahiraam added inline comments. Comment at: clang/test/CodeGen/X86/Float16-arithmetic.c:207 +// CHECK-NEXT:[[EXT:%.*]] = fpext half [[TMP0]] to float +// CHECK-NEXT:store float [[EXT]], ptr [[RETVAL]], align 2 +// CHECK-NEXT:

[PATCH] D132379: [Support] Class for response file expansion

sepavloff added a comment. In D132379#3740102 , @thakis wrote: > Can you say what you're trying to do? There is an intention to extend algorithm of included files search. In particular it requires passing down paths where config files may be searched f

[PATCH] D128619: [Clang] Implement P0848 (Conditionally Trivial Special Member Functions)

erichkeane added inline comments. Comment at: clang/lib/Frontend/InitPreprocessor.cpp:677 //Builder.defineMacro("__cpp_aggregate_paren_init", "201902L"); -Builder.defineMacro("__cpp_concepts", "201907L"); +Builder.defineMacro("__cpp_concepts", "202002L"); Builde

[PATCH] D132398: Allow static consteval member functions to be used in const expressions.

usaxena95 created this revision. Herald added a project: All. usaxena95 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D132398 Files: clang/lib/AST/ExprConstant.cpp clang

  1   2   3   >