[PATCH] D131780: [clang-tidy] Do not trigger cppcoreguidelines-avoid-const-or-ref-data-members on lambda captures

njames93 accepted this revision. njames93 added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines/avoid-const-or-ref-data-members.cpp:191 + auto r5 = [&x5]{}; +} carlosgalv

[PATCH] D132209: [Clang][OpenMP] Make copyin clause on combined and composite construct work

yutsumi created this revision. yutsumi added reviewers: ABataev, jdoerfert, cchen. Herald added subscribers: guansong, yaxunl. Herald added a project: All. yutsumi requested review of this revision. Herald added subscribers: openmp-commits, cfe-commits, sstefan1. Herald added projects: clang, OpenM

[PATCH] D131687: [Clang]Replace aarch64_sve_ldN intrinsic by aarch64_sve_ldN.sret

sdesmalen accepted this revision. sdesmalen added a comment. This revision is now accepted and ready to land. LGTM with nit addressed, thanks @CarolineConcatto! Comment at: clang/lib/CodeGen/CGBuiltin.cpp:8866 + Value *Call = Builder.CreateCall(F, {Predicate, BasePtr}); + uns

[clang] a2dd613 - [clang][Modules] Fix a regression in handling missing framework headers.

Author: Iain Sandoe Date: 2022-08-19T09:13:22+01:00 New Revision: a2dd6130d49777d63c2d1b641bd8e56f26fa0822 URL: https://github.com/llvm/llvm-project/commit/a2dd6130d49777d63c2d1b641bd8e56f26fa0822 DIFF: https://github.com/llvm/llvm-project/commit/a2dd6130d49777d63c2d1b641bd8e56f26fa0822.diff L

[PATCH] D132098: [clang][Interp] Implement inv and neg unary operations

tbaeder updated this revision to Diff 453917. tbaeder added a comment. When changing the test to use `-verify=test`, I noticed that `static_assert(-false)` did not assert. I had to implement integral casts (only from sint32 to bool for now) in this patch as well to make it work. CHANGES SINCE

[PATCH] D132098: [clang][Interp] Implement inv and neg unary operations

tbaeder added inline comments. Comment at: clang/lib/AST/Interp/Integral.h:173 + } + template static Integral from(Integral<0, SrcSign> Value) { I'm a bit out of my element with the template magic here. CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[clang-tools-extra] 3fd4213 - [clang-tidy] Do not trigger cppcoreguidelines-avoid-const-or-ref-data-members on lambda captures

Author: Carlos Galvez Date: 2022-08-19T08:26:34Z New Revision: 3fd4213059a4ea9453809aeccd1bfc7d115d24b2 URL: https://github.com/llvm/llvm-project/commit/3fd4213059a4ea9453809aeccd1bfc7d115d24b2 DIFF: https://github.com/llvm/llvm-project/commit/3fd4213059a4ea9453809aeccd1bfc7d115d24b2.diff LOG:

[PATCH] D131780: [clang-tidy] Do not trigger cppcoreguidelines-avoid-const-or-ref-data-members on lambda captures

This revision was automatically updated to reflect the committed changes. Closed by commit rG3fd4213059a4: [clang-tidy] Do not trigger cppcoreguidelines-avoid-const-or-ref-data-members… (authored by carlosgalvezp). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews

[PATCH] D131780: [clang-tidy] Do not trigger cppcoreguidelines-avoid-const-or-ref-data-members on lambda captures

carlosgalvezp added a comment. Thanks for the review! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131780/new/ https://reviews.llvm.org/D131780 ___ cfe-commits mailing list cfe-commits@lists.llvm.org ht

[PATCH] D132142: [analyzer] Prefer wrapping SymbolicRegions by ElementRegions

steakhal added inline comments. Comment at: clang/test/Analysis/trivial-copy-struct.cpp:26 + + clang_analyzer_dump(n1); // expected-warning {{&SymRegion{reg_$2}}} + clang_analyzer_dump(n2); // expected-warning {{&HeapSymRegion{conj_$1{Node *, LC1, S1855, #1 ---

[PATCH] D128981: [C++20][Modules] Implement include translation.

iains added a comment. In D128981#3728503 , @iains wrote: > In D128981#3728070 , @jansvoboda11 > wrote: > >> Hi @iains, upstream Clang crashes on the attached test case due to an >> assertion failure. Git bisect

[PATCH] D128113: Clang: fix AST representation of expanded template arguments.

davrec added a comment. In D128113#3733764 , @mizvekov wrote: > In D128113#3733051 , @joanahalili > wrote: > >> We have a translation unit, on which we see an increase of compilation time >> and clang memory all

[PATCH] D132142: [analyzer] Prefer wrapping SymbolicRegions by ElementRegions

xazax.hun added a comment. I agree with @steakhal. Getting rid of element regions might be a lot of work and might have a lot of fallout that we need to deal with. I think we should not block a fix for something that we might not be able to land for a long time. Fixing this here, and independe

[PATCH] D131808: [clang,flang] Add help text for -fsyntax-only

alexiprof added a comment. ping @awarzynski @MaskRay @vzakhari Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131808/new/ https://reviews.llvm.org/D131808 ___ cfe-commits mailing list cfe-commits@lists.ll

[PATCH] D131808: [clang,flang] Add help text for -fsyntax-only

kiranchandramohan added a comment. I can land this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131808/new/ https://reviews.llvm.org/D131808 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http

[PATCH] D131808: [clang,flang] Add help text for -fsyntax-only

This revision was automatically updated to reflect the committed changes. Closed by commit rGcd86a03246a2: [clang,flang] Add help text for -fsyntax-only (authored by alexiprof, committed by kiranchandramohan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[clang] cd86a03 - [clang,flang] Add help text for -fsyntax-only

Author: Alexander Malkov Date: 2022-08-19T09:54:29Z New Revision: cd86a03246a2df350c2f694457f1ce946cf65663 URL: https://github.com/llvm/llvm-project/commit/cd86a03246a2df350c2f694457f1ce946cf65663 DIFF: https://github.com/llvm/llvm-project/commit/cd86a03246a2df350c2f694457f1ce946cf65663.diff L

[PATCH] D131808: [clang,flang] Add help text for -fsyntax-only

kiranchandramohan added a comment. In D131808#3722809 , @alexiprof wrote: > Could someone land this patch please? > Alexander Malkov Was landed with the email id contained in the patch (Author: Alexander Malkov ). Hope that is OK. May be you can update

[PATCH] D132209: [Clang][OpenMP] Make copyin clause on combined and composite construct work

ABataev added a comment. Add clang unit tests, please Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132209/new/ https://reviews.llvm.org/D132209 ___ cfe-commits mailing list cfe-commits@lists.llvm.org ht

[PATCH] D132110: [IncludeCleaner] Handle more C++ constructs

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/include-cleaner/lib/WalkAST.cpp:66 + bool VisitOverloadExpr(OverloadExpr *E) { +// Mark all candidates as used when overload is n

[PATCH] D131547: [Clang][AArch64] Use generic extract/insert vector for svget/svset/svcreate tuples

sdesmalen accepted this revision. sdesmalen added a comment. This revision is now accepted and ready to land. LGTM, thanks @CarolineConcatto. Please land D132137 before landing this one to avoid regressions on combines that previously worked on svget/svset.

[clang] 1bd2b2d - Add support for specifying the severity of a SARIF Result

Author: Vaibhav Yenamandra Date: 2022-08-19T07:14:50-04:00 New Revision: 1bd2b2dce2a92dd2777f4fe08098b8f19e3fb593 URL: https://github.com/llvm/llvm-project/commit/1bd2b2dce2a92dd2777f4fe08098b8f19e3fb593 DIFF: https://github.com/llvm/llvm-project/commit/1bd2b2dce2a92dd2777f4fe08098b8f19e3fb593.

[PATCH] D131084: Add support for specifying the severity of a SARIF Result.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1bd2b2dce2a9: Add support for specifying the severity of a SARIF Result (authored by vaibhav.y, committed by aaron.ballman). Repository: rG LLVM G

[PATCH] D131175: [clangd] Use the "macro" semantic token for pre-defined identifiers

ilya-biryukov added a comment. In D131175#3732379 , @sammccall wrote: > But often I forget and edit it in phab, and I don't know of a command to pull > those edits down into my git repo. I ended up always doing this for landing changes: $ git switch

[PATCH] D130586: [cmake] Use `CMAKE_INSTALL_LIBDIR` too

thakis added a comment. When this relands and it's not too much trouble, it'd be nice if you could reland d3a1dbc4907b59690f9013cdb6221573ca4233f1 in the commit that relands this. Repository: rG LLVM Github Monorepo CHAN

[PATCH] D131388: [docs] Add "C++20 Modules"

JohelEGP requested changes to this revision. JohelEGP added inline comments. This revision now requires changes to proceed. Comment at: clang/docs/CPlusPlus20Modules.rst:290 +``primary module interface unit`` by ``-fmodule-file`` +since the langugae specification says a module im

[PATCH] D131665: [CMake] Support passing arguments to build tool (bootstrap).

CarlosAlbertoEnciso added a comment. To give more scope to the reviewers, the following CMake options illustrate the benefit of this patch. For example, if I want to do a dry run on stage-2, I will pass `-DLLVM_EXTERNAL_PROJECT_BUILD_TOOL_ARGS="-n --verbose"` -DCLANG_ENABLE_BOOTSTRAP=ON -DLL

[PATCH] D132098: [clang][Interp] Implement inv and neg unary operations

aaron.ballman added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:620 + case UO_Deref: // *x + case UO_Not:// ~x + case UO_Real: // __real x tbaeder wrote: > aaron.ballman wrote: > > This is reachable and will always return true

[PATCH] D132098: [clang][Interp] Implement inv and neg unary operations

tbaeder added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:620 + case UO_Deref: // *x + case UO_Not:// ~x + case UO_Real: // __real x aaron.ballman wrote: > tbaeder wrote: > > aaron.ballman wrote: > > > This is reachable and wil

[PATCH] D132098: [clang][Interp] Implement inv and neg unary operations

erichkeane added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:620 + case UO_Deref: // *x + case UO_Not:// ~x + case UO_Real: // __real x tbaeder wrote: > aaron.ballman wrote: > > tbaeder wrote: > > > aaron.ballman wrote: > > > >

[PATCH] D132098: [clang][Interp] Implement inv and neg unary operations

erichkeane added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:620 + case UO_Deref: // *x + case UO_Not:// ~x + case UO_Real: // __real x erichkeane wrote: > tbaeder wrote: > > aaron.ballman wrote: > > > tbaeder wrote: > > > > aa

[PATCH] D132098: [clang][Interp] Implement inv and neg unary operations

aaron.ballman added inline comments. Comment at: clang/lib/AST/Interp/Integral.h:173 + } + template static Integral from(Integral<0, SrcSign> Value) { tbaeder wrote: > aaron.ballman wrote: > > tbaeder wrote: > > > I'm a bit out of my element with the templat

[PATCH] D132098: [clang][Interp] Implement inv and neg unary operations

erichkeane added inline comments. Comment at: clang/lib/AST/Interp/Integral.h:173 + } + template static Integral from(Integral<0, SrcSign> Value) { aaron.ballman wrote: > tbaeder wrote: > > aaron.ballman wrote: > > > tbaeder wrote: > > > > I'm a bit out of m

[clang-tools-extra] 13b2a0c - [clangd] Support hover on __func__ etc (PredefinedExpr)

Author: Sam McCall Date: 2022-08-19T14:51:46+02:00 New Revision: 13b2a0c69ba69c1317308b6e5a8279160561c4b2 URL: https://github.com/llvm/llvm-project/commit/13b2a0c69ba69c1317308b6e5a8279160561c4b2 DIFF: https://github.com/llvm/llvm-project/commit/13b2a0c69ba69c1317308b6e5a8279160561c4b2.diff LO

[PATCH] D132135: [clangd] Support hover on __func__ etc (PredefinedExpr)

This revision was automatically updated to reflect the committed changes. Closed by commit rG13b2a0c69ba6: [clangd] Support hover on __func__ etc (PredefinedExpr) (authored by sammccall). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132135/new/ htt

[PATCH] D132098: [clang][Interp] Implement inv and neg unary operations

tbaeder updated this revision to Diff 453968. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132098/new/ https://reviews.llvm.org/D132098 Files: clang/lib/AST/Interp/Boolean.h clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/lib/AST/Interp/ByteCodeExprGen.h clang/lib/AST/Interp/Inte

[PATCH] D132098: [clang][Interp] Implement inv and neg unary operations

tbaeder added inline comments. Comment at: clang/lib/AST/Interp/Integral.h:173 + } + template static Integral from(Integral<0, SrcSign> Value) { erichkeane wrote: > aaron.ballman wrote: > > tbaeder wrote: > > > aaron.ballman wrote: > > > > tbaeder wrote: > >

[PATCH] D132098: [clang][Interp] Implement inv and neg unary operations

tbaeder updated this revision to Diff 453970. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132098/new/ https://reviews.llvm.org/D132098 Files: clang/lib/AST/Interp/Boolean.h clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/lib/AST/Interp/ByteCodeExprGen.h clang/lib/AST/Interp/Inte

[PATCH] D132141: [X86] Emulate _rdrand64_step with two rdrand32 if it is 32bit

RKSimon added inline comments. Comment at: clang/test/CodeGen/X86/rdrand-builtins.c:20 #if __x86_64__ int rdrand64(unsigned long long *p) { why do you still need the #if-else-endif? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://

[PATCH] D130788: [clang-repl] Disable building when LLVM_STATIC_LINK_CXX_STDLIB is ON.

sunho added a comment. In D130788#3732325 , @sbc100 wrote: > In D130788#3731232 , @sunho wrote: > >> In D130788#3730533 , @sbc100 wrote: >> >>> I'm not totally sure but I

[PATCH] D130523: [pseudo] Perform unconstrained recovery prior to completion.

sammccall marked 2 inline comments as done. sammccall added inline comments. Comment at: clang-tools-extra/pseudo/lib/GLR.cpp:621 // Consume the token. glrShift(Heads, Terminals[I], Params, Lang, NextHeads); hokein wrote: > hokein wrote: > > I think w

[PATCH] D130523: [pseudo] Perform unconstrained recovery prior to completion.

This revision was automatically updated to reflect the committed changes. Closed by commit rG2cc7463c85c0: [pseudo] Perform unconstrained reduction prior to recovery. (authored by sammccall). Changed prior to commit: https://reviews.llvm.org/D130523?vs=447487&id=453972#toc Repository: rG LLV

[clang-tools-extra] 2cc7463 - [pseudo] Perform unconstrained reduction prior to recovery.

Author: Sam McCall Date: 2022-08-19T15:07:36+02:00 New Revision: 2cc7463c85c056e956ad332448189ce3e9004182 URL: https://github.com/llvm/llvm-project/commit/2cc7463c85c056e956ad332448189ce3e9004182 DIFF: https://github.com/llvm/llvm-project/commit/2cc7463c85c056e956ad332448189ce3e9004182.diff LO

[PATCH] D131052: [CMake] Allow setting the location of host tools with LLVM_NATIVE_TOOL_DIR

mstorsjo added a comment. In D131052#3731894 , @sammccall wrote: > FWIW I have no idea: in principle this makes sense, but I don't use such a > configuration and don't have a clear idea of what people who do use it want. Thanks for having a look and dis

[clang-tools-extra] 605035b - [pseudo] Changes omitted from previous commit

Author: Sam McCall Date: 2022-08-19T15:15:37+02:00 New Revision: 605035bf4508460f8c28857c7aaecf1d8c449ca8 URL: https://github.com/llvm/llvm-project/commit/605035bf4508460f8c28857c7aaecf1d8c449ca8 DIFF: https://github.com/llvm/llvm-project/commit/605035bf4508460f8c28857c7aaecf1d8c449ca8.diff LO

[PATCH] D129642: [Sema] Tweak diagnostic logic so suppress-in-hedaer logic works in tools too.

This revision was automatically updated to reflect the committed changes. Closed by commit rGac3178175988: [Sema] Tweak diagnostic logic so suppress-in-header logic works in tools too. (authored by sammccall). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[clang-tools-extra] ac31781 - [Sema] Tweak diagnostic logic so suppress-in-header logic works in tools too.

Author: Sam McCall Date: 2022-08-19T15:16:10+02:00 New Revision: ac31781759889226711b801c3833fea280fdb7aa URL: https://github.com/llvm/llvm-project/commit/ac31781759889226711b801c3833fea280fdb7aa DIFF: https://github.com/llvm/llvm-project/commit/ac31781759889226711b801c3833fea280fdb7aa.diff LO

[PATCH] D131052: [CMake] Allow setting the location of host tools with LLVM_NATIVE_TOOL_DIR

sammccall added a comment. TL;DR: Thanks for explanation, LG if we move the common logic into a macro. In D131052#3734986 , @mstorsjo wrote: > In D131052#3731894 , @sammccall > wrote: > >> FWIW I have no idea: i

[PATCH] D130510: Missing tautological compare warnings due to unary operators

Codesbyusman updated this revision to Diff 453976. Codesbyusman added a comment. updated. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130510/new/ https://reviews.llvm.org/D130510 Files: clang/docs/ReleaseNotes.rst clang/lib/Analysis/CFG.cpp

[PATCH] D12669: [libcxxabi] Fix alignment of pointers returned by fallback_malloc

ldionne commandeered this revision. ldionne added a reviewer: EricWF. ldionne added a comment. Commandeering to abandon since we're landing D129842 instead. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D12669/new/ https://reviews.llvm.org/D12669

[clang-tools-extra] e32799d - [pseudo] NFC, remove redundant ;

Author: Haojian Wu Date: 2022-08-19T15:55:19+02:00 New Revision: e32799d1d6f84206712076d385a1ce03e0944ab3 URL: https://github.com/llvm/llvm-project/commit/e32799d1d6f84206712076d385a1ce03e0944ab3 DIFF: https://github.com/llvm/llvm-project/commit/e32799d1d6f84206712076d385a1ce03e0944ab3.diff LO

[PATCH] D132229: [clang][dataflow] Mark `getDeclCtx` function in dataflow `Environment` `const`.

wyt created this revision. Herald added subscribers: martong, xazax.hun. Herald added a reviewer: NoQ. Herald added a project: All. wyt requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.l

[PATCH] D132098: [clang][Interp] Implement inv and neg unary operations

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132098/new/ https://reviews.llvm.org/D132098 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.o

[clang] 80bbc05 - [clang][Interp] Implement inv and neg unary operations

Author: Timm Bäder Date: 2022-08-19T16:05:00+02:00 New Revision: 80bbc05436d9c98d65b9b3a5f3907346ef3cb095 URL: https://github.com/llvm/llvm-project/commit/80bbc05436d9c98d65b9b3a5f3907346ef3cb095 DIFF: https://github.com/llvm/llvm-project/commit/80bbc05436d9c98d65b9b3a5f3907346ef3cb095.diff LO

[PATCH] D132098: [clang][Interp] Implement inv and neg unary operations

This revision was automatically updated to reflect the committed changes. Closed by commit rG80bbc05436d9: [clang][Interp] Implement inv and neg unary operations (authored by tbaeder). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132098/new/ https:

[clang] 7614785 - [clang][Interp] Rename Integral::T to Integral::ReprT

Author: Timm Bäder Date: 2022-08-19T16:14:37+02:00 New Revision: 7614785e1d284db5b1d1b9b0017f3bb5a3724f8c URL: https://github.com/llvm/llvm-project/commit/7614785e1d284db5b1d1b9b0017f3bb5a3724f8c DIFF: https://github.com/llvm/llvm-project/commit/7614785e1d284db5b1d1b9b0017f3bb5a3724f8c.diff LO

[PATCH] D132197: [RISCV] Use Triple::isRISCV/isRISCV32/isRISCV64 helps in some places. NFC

reames accepted this revision. reames added a comment. This revision is now accepted and ready to land. LGTM w/ optional comment. Comment at: clang/lib/Driver/ToolChains/Linux.cpp:741 getTriple().getArch() == llvm::Triple::thumbeb; - const bool IsRISC

[PATCH] D132079: [AMDGPU] Add iglp_opt builtin and MFMA GEMM Opt strategy

jrbyrnes added inline comments. Comment at: llvm/lib/Target/AMDGPU/AMDGPUIGroupLP.cpp:1063 +} else if (Opc == AMDGPU::IGLP_OPT) { + if (!foundSB && !foundIGLP) +initIGLPOpt(*R); I think this makes more sense if you parse the entire dag first, the

[PATCH] D130768: [OpenCL][SPIR-V] Add test for extern functions with a pointer

svenvh accepted this revision. svenvh added a comment. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130768/new/ https://reviews.llvm.org/D130768 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mai

[PATCH] D132232: Update coding standards for constexpr if statements; NFC

aaron.ballman created this revision. aaron.ballman added reviewers: dblaikie, rjmccall, echristo, erichkeane. Herald added a project: All. aaron.ballman requested review of this revision. Herald added a project: LLVM. We currently suggest that users not use an `else` clause after a `return` state

[PATCH] D129608: [Clang][OpenMP] Fix segmentation fault when data field is used in is_device_pt.

alexfh added a comment. It looks like this commit introduces an AddressSanitizer: stack-use-after-scope error: ==2796==ERROR: AddressSanitizer: stack-use-after-scope on address 0x7f544e9acc20 at pc 0x55f1f7f4b83e bp 0x7ffdfb37c560 sp 0x7ffdfb37c558 READ of size 4 at 0x7f544e9acc20 thread T0

[PATCH] D132232: Update coding standards for constexpr if statements; NFC

erichkeane added a comment. Agreed. For other reviewers, note that this is the compelling example: template static constexpr bool VarTempl = true; template int func() { if constexpr (VarTempl) return 1; static_assert(!VarTempl); } void use() { func();

[PATCH] D130510: Missing tautological compare warnings due to unary operators

This revision was automatically updated to reflect the committed changes. Closed by commit rGfd874e5fb119: Missing tautological compare warnings due to unary operators (authored by Codesbyusman, committed by aaron.ballman). Changed prior to commit: https://reviews.llvm.org/D130510?vs=453976&id=

[clang] fd874e5 - Missing tautological compare warnings due to unary operators

Author: Muhammad Usman Shahid Date: 2022-08-19T10:46:29-04:00 New Revision: fd874e5fb119e1d9f427a299ffa5bbabaeba9455 URL: https://github.com/llvm/llvm-project/commit/fd874e5fb119e1d9f427a299ffa5bbabaeba9455 DIFF: https://github.com/llvm/llvm-project/commit/fd874e5fb119e1d9f427a299ffa5bbabaeba94

[clang-tools-extra] bd5cc65 - [pseudo] Start rules are `_ := start-symbol EOF`, improve recovery.

Author: Sam McCall Date: 2022-08-19T16:49:37+02:00 New Revision: bd5cc6575bdbe1d091f1cc70fb7f0b3c07cb894b URL: https://github.com/llvm/llvm-project/commit/bd5cc6575bdbe1d091f1cc70fb7f0b3c07cb894b DIFF: https://github.com/llvm/llvm-project/commit/bd5cc6575bdbe1d091f1cc70fb7f0b3c07cb894b.diff LO

[PATCH] D130550: [pseudo] Start rules are `_ := start-symbol EOF`, improve recovery.

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. sammccall marked 4 inline comments as done. Closed by commit rGbd5cc6575bdb: [pseudo]

[PATCH] D132197: [RISCV] Use Triple::isRISCV/isRISCV32/isRISCV64 helps in some places. NFC

craig.topper added inline comments. Comment at: clang/lib/Driver/ToolChains/Linux.cpp:741 getTriple().getArch() == llvm::Triple::thumbeb; - const bool IsRISCV64 = getTriple().getArch() == llvm::Triple::riscv64; + const bool IsRISCV64 = getTriple().isRI

[clang] dbb95c2 - [clang][dataflow] Debug string for value kinds.

Author: Wei Yi Tee Date: 2022-08-19T15:00:01Z New Revision: dbb95c2a851c64e50ca9801a331cb871da88be49 URL: https://github.com/llvm/llvm-project/commit/dbb95c2a851c64e50ca9801a331cb871da88be49 DIFF: https://github.com/llvm/llvm-project/commit/dbb95c2a851c64e50ca9801a331cb871da88be49.diff LOG: [c

[PATCH] D131891: [clang][dataflow] Debug string for value kinds.

This revision was automatically updated to reflect the committed changes. Closed by commit rGdbb95c2a851c: [clang][dataflow] Debug string for value kinds. (authored by wyt). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131891/new/ https://reviews.l

[PATCH] D132142: [analyzer] Prefer wrapping SymbolicRegions by ElementRegions

steakhal updated this revision to Diff 454009. steakhal added a comment. - Use `:digit:` regex matching in the tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132142/new/ https://reviews.llvm.org/D132142 Files: clang/include/clang/StaticAna

[PATCH] D113107: Support of expression granularity for _Float16.

zahiraam marked 3 inline comments as done. zahiraam added a comment. Comment at: clang/test/CodeGen/X86/Float16-complex.c:1184 +// X86-NEXT:store float [[NEG_I]], ptr [[RETVAL_IMAGP]], align 2 +// X86-NEXT:[[TMP0:%.*]] = load <2 x half>, ptr [[RETVAL]], align 2 +// X86

[PATCH] D132111: [clang][Interp] Implement pointer (de)ref operations and DeclRefExprs

tahonermann added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:613-614 case UO_LNot: // !x +if (!this->Visit(SubExpr)) + return false; return this->emitInvBool(E); I don't love that the `Visit()` calls are now repeated fo

[PATCH] D132142: [analyzer] Prefer wrapping SymbolicRegions by ElementRegions

steakhal added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/MemRegion.h:791-793 + /// TODO: Ellaborate why this is not a typed region, and why this is just an + /// 'approximation'. + QualType getApproximatedType() const { ---

[PATCH] D132143: [analyzer] LazyCompoundVals should be always bound as default bindings

steakhal updated this revision to Diff 454010. steakhal added a comment. - Rebase for using `:digit:` regex matching in the tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132143/new/ https://reviews.llvm.org/D132143 Files: clang/lib/Static

[PATCH] D131388: [docs] Add "C++20 Modules"

ChuanqiXu updated this revision to Diff 454012. ChuanqiXu marked an inline comment as done. ChuanqiXu added a comment. Address comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131388/new/ https://reviews.llvm.org/D131388 Files: clang/docs/CPlusPlus20Modules.rst clang/docs/in

[PATCH] D132236: [analyzer] Fix liveness of LazyCompoundVals

steakhal created this revision. steakhal added reviewers: NoQ, xazax.hun, martong, ASDenysPetrov, Szelethus, isuckatcs, vabridgers. Herald added subscribers: manas, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware. Herald added a project: All. steakhal requeste

[PATCH] D131388: [docs] Add "C++20 Modules"

ChuanqiXu added inline comments. Comment at: clang/docs/CPlusPlus20Modules.rst:457 + +The declarations in a module unit which are not in global module fragment have new linkage names. + JohelEGP wrote: > Thanks for reviewing. BTW, the `request to change` button

[PATCH] D126818: Itanium ABI: Implement mangling for constrained friends

erichkeane added a comment. In D126818#3563376 , @erichkeane wrote: > In D126818#3562355 , @tahonermann > wrote: > >>> Note we might be confused, the parens there aren't completely clear as to >>> what your int

[PATCH] D131625: [HLSL] Entry functions require param annotation

beanz added inline comments. Comment at: clang/include/clang/AST/Attr.h:193 +class HLSLAnnotationAttr : public InheritableAttr { +protected: aaron.ballman wrote: > Is this intended to be used only for parameters (that's how I read the > summary for the patch)?

[PATCH] D132241: [clang][dataflow] Dummy patch 1

samestep created this revision. Herald added subscribers: martong, xazax.hun. Herald added a reviewer: NoQ. Herald added a project: All. samestep requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https:/

[PATCH] D132242: [clang][dataflow] Dummy patch 2

samestep created this revision. Herald added subscribers: martong, xazax.hun. Herald added a reviewer: NoQ. Herald added a project: All. samestep requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Depends On D132241

[PATCH] D132017: [clang][analyzer] Add errno modeling to StreamChecker

balazske updated this revision to Diff 454026. balazske marked 2 inline comments as done. balazske added a comment. - Use `Optional` for `EofInitialized` - Split tests into two files with and without note check. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.l

[PATCH] D132244: [docs] improve documentation for misc-const-correctness

JonasToth created this revision. JonasToth added reviewers: njames93, aaron.ballman, alexfh, hokein, sammccall. Herald added a project: All. JonasToth requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Improve the documentation for

[PATCH] D129608: [Clang][OpenMP] Fix segmentation fault when data field is used in is_device_pt.

jyu2 added a comment. Hi @alexfh, How could I reproduce the problem? Thanks. Thanks. Jennifer Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129608/new/ https://reviews.llvm.org/D129608 ___ cfe-commits

[PATCH] D130793: [clang-tidy] adjust treating of array-of-pointers when 'AnalyzePointers' is deactivated

JonasToth updated this revision to Diff 454031. JonasToth marked an inline comment as done. JonasToth added a comment. - split patch - remove unnecessary includes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130793/new/ https://reviews.llvm.org/D1

[PATCH] D130788: [clang-repl] Disable building when LLVM_STATIC_LINK_CXX_STDLIB is ON.

sbc100 added a comment. https://chromium-review.googlesource.com/c/emscripten-releases/+/3842345... I suppose the alternative would be to keep the backup method that was previously working in our case (but not in yours)? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

[PATCH] D130793: [clang-tidy] adjust treating of array-of-pointers when 'AnalyzePointers' is deactivated

JonasToth updated this revision to Diff 454032. JonasToth added a comment. - remove bad change from diff Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130793/new/ https://reviews.llvm.org/D130793 Files: clang-tools-extra/clang-tidy/misc/ConstCor

[PATCH] D131799: [HLSL] clang codeGen for HLSLNumThreadsAttr

beanz added inline comments. Comment at: clang/lib/CodeGen/CGHLSLRuntime.cpp:103 + << NumThreadsAttr->getZ(); +OS.flush(); +F->addFnAttr(NumThreadsKindStr, NumThreadsStr); You can replace this whole chunk of code with: ``` std::string NumThreadsStr

[PATCH] D132247: [clang] Fix emitVoidPtrVAArg for non-zero default alloca address space

jrtc27 created this revision. jrtc27 added a reviewer: arsenm. Herald added subscribers: kosarev, tpr. Herald added a project: All. jrtc27 requested review of this revision. Herald added subscribers: cfe-commits, wdng. Herald added a project: clang. Indirect arguments are passed on the stack and s

[PATCH] D132248: [CUDA][OpenMP] Fix the new driver crashing on multiple device-only outputs

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, tra, yaxunl, JonChesterfield. Herald added subscribers: mattd, guansong. Herald added a project: All. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits, sstefan1, MaskRay. Herald added a project: clang

[PATCH] D132066: [clang][deps] Allow switching between lazily/eagerly loaded PCMs

benlangmuir accepted this revision. benlangmuir added a comment. This revision is now accepted and ready to land. Thanks, LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132066/new/ https://reviews.llvm.org/D132066 _

[PATCH] D132248: [CUDA][OpenMP] Fix the new driver crashing on multiple device-only outputs

jhuber6 updated this revision to Diff 454036. jhuber6 added a comment. Forgot to use the new driver in the test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132248/new/ https://reviews.llvm.org/D132248 Files: clang/lib/Driver/Driver.cpp clan

[clang-tools-extra] ee648c0 - [clang][index] Index unresolved member expression as reference

Author: Denis Fatkulin Date: 2022-08-19T19:02:42+03:00 New Revision: ee648c0ce09b1edcee65407041eab38228f4b042 URL: https://github.com/llvm/llvm-project/commit/ee648c0ce09b1edcee65407041eab38228f4b042 DIFF: https://github.com/llvm/llvm-project/commit/ee648c0ce09b1edcee65407041eab38228f4b042.diff

[PATCH] D131091: [clang][index] Index unresolved member expression as reference

This revision was automatically updated to reflect the committed changes. Closed by commit rGee648c0ce09b: [clang][index] Index unresolved member expression as reference (authored by denis-fatkulin, committed by ArcsinX). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://

[clang] a47ec1b - [analyzer][NFC] Be more descriptive when we replay without inlining

Author: isuckatcs Date: 2022-08-19T18:05:52+02:00 New Revision: a47ec1b79797c8c48c44f9ddf36fb82f8d87229d URL: https://github.com/llvm/llvm-project/commit/a47ec1b79797c8c48c44f9ddf36fb82f8d87229d DIFF: https://github.com/llvm/llvm-project/commit/a47ec1b79797c8c48c44f9ddf36fb82f8d87229d.diff LOG

[PATCH] D132246: [analyzer][NFC] Be more descriptive when we replay without inlining

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa47ec1b79797: [analyzer][NFC] Be more descriptive when we replay without inlining (authored by isuckatcs). Herald added a project: clang. Herald adde

[PATCH] D132249: [clang][analyzer] Add some functions to StreamChecker with errno modeling.

balazske created this revision. Herald added subscribers: steakhal, manas, ASDenysPetrov, martong, gamesh411, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a reviewer: Szelethus. Herald added a reviewer: NoQ. Herald added a project:

[clang] 1a60e00 - [RISCV] Use Triple::isRISCV/isRISCV32/isRISCV64 helps in some places. NFC

Author: Craig Topper Date: 2022-08-19T09:11:22-07:00 New Revision: 1a60e003df8a8c03aae123bdec77e6a9db690862 URL: https://github.com/llvm/llvm-project/commit/1a60e003df8a8c03aae123bdec77e6a9db690862 DIFF: https://github.com/llvm/llvm-project/commit/1a60e003df8a8c03aae123bdec77e6a9db690862.diff

[PATCH] D132197: [RISCV] Use Triple::isRISCV/isRISCV32/isRISCV64 helps in some places. NFC

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1a60e003df8a: [RISCV] Use Triple::isRISCV/isRISCV32/isRISCV64 helps in some places. NFC (authored by craig.topper). Changed prior to commit: http

[PATCH] D132111: [clang][Interp] Implement pointer (de)ref operations and DeclRefExprs

tbaeder marked 3 inline comments as done. tbaeder added inline comments. Comment at: clang/test/AST/Interp/cxx20.cpp:2 +// RUN: %clang_cc1 -fexperimental-new-constant-interpreter -std=c++20 -verify %s +// RUN: %clang_cc1 -std=c++20 -verify %s -DREFERENCE + tahon

  1   2   >