[PATCH] D131479: Handle explicitly defaulted consteval special members.

2022-08-10 Thread Utkarsh Saxena via Phabricator via cfe-commits
usaxena95 updated this revision to Diff 451731. usaxena95 marked 3 inline comments as done. usaxena95 added a comment. Addressed comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131479/new/ https://reviews.llvm.org/D131479 Files: clang/li

[PATCH] D131134: [X86] Report error if the amx enabled on the non-64-bits target

2022-08-10 Thread Phoebe Wang via Phabricator via cfe-commits
pengfei added a comment. In D131134#3714860 , @craig.topper wrote: > Yes AMX is only supported in 64-bit mode but I doubt CPUID checks which mode > the program is running in. I guess `HasAMXSave` is `false` on 32-bit mode https://github.com/llvm/llvm-

[PATCH] D131479: Handle explicitly defaulted consteval special members.

2022-08-10 Thread Utkarsh Saxena via Phabricator via cfe-commits
usaxena95 added inline comments. Comment at: clang/test/SemaCXX/cxx2a-consteval.cpp:805 +void func() { + default_ctor fail0; // expected-error-re {{call to consteval function '{{.*::default_ctor<.*::foo>}}::default_ctor' is not a constant expression}} \ +

[clang] 156c075 - [clang][transformer] Finish plumbing `Note` all the way to the output.

2022-08-10 Thread Clement Courbet via cfe-commits
Author: Clement Courbet Date: 2022-08-11T07:54:44+02:00 New Revision: 156c0754bc2ee0b7d198cfeff230374a1961ac04 URL: https://github.com/llvm/llvm-project/commit/156c0754bc2ee0b7d198cfeff230374a1961ac04 DIFF: https://github.com/llvm/llvm-project/commit/156c0754bc2ee0b7d198cfeff230374a1961ac04.dif

[PATCH] D128807: [clang][transformer] Finish plumbing `Note` all the way to the output.

2022-08-10 Thread Clement Courbet via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG156c0754bc2e: [clang][transformer] Finish plumbing `Note` all the way to the output. (authored by courbet). Repository: rG LLVM Github Monorepo C

[PATCH] D131651: [AST] [Modules] Introduce Decl::getNonTransparentDeclContext to handle exported friends

2022-08-10 Thread Chuanqi Xu via Phabricator via cfe-commits
ChuanqiXu created this revision. ChuanqiXu added reviewers: aaron.ballman, erichkeane, ilya-biryukov, iains. ChuanqiXu added a project: clang. Herald added a project: All. ChuanqiXu requested review of this revision. Herald added a subscriber: cfe-commits. Closing https://github.com/llvm/llvm-proj

[PATCH] D131134: [X86] Report error if the amx enabled on the non-64-bits target

2022-08-10 Thread Phoebe Wang via Phabricator via cfe-commits
pengfei added a comment. In D131134#3715024 , @pengfei wrote: > In D131134#3714860 , @craig.topper > wrote: > >> Yes AMX is only supported in 64-bit mode but I doubt CPUID checks which mode >> the program is run

[PATCH] D131651: [AST] [Modules] Introduce Decl::getNonTransparentDeclContext to handle exported friends

2022-08-10 Thread Chuanqi Xu via Phabricator via cfe-commits
ChuanqiXu added inline comments. Comment at: clang/lib/Sema/SemaTemplateInstantiateDecl.cpp:6152 +// of `getDeclContext()` once we find the invalid test case. if (FD->getFriendObjectKind() && FD->getDeclContext()->isFileContext()){ DC = FD->getLexical

[PATCH] D131651: [AST] [Modules] Introduce Decl::getNonTransparentDeclContext to handle exported friends

2022-08-10 Thread Chuanqi Xu via Phabricator via cfe-commits
ChuanqiXu added inline comments. Comment at: clang/include/clang/AST/DeclBase.h:2020 /// Examples of transparent contexts include: enumerations (except for - /// C++0x scoped enums), and C++ linkage specifications. + /// C++0x scoped enums), C++ linkage specifications and ex

[clang] bcc90f6 - [Clang] Update cxx_dr_status [NFC]

2022-08-10 Thread Corentin Jabot via cfe-commits
Author: Corentin Jabot Date: 2022-08-11T08:24:31+02:00 New Revision: bcc90f6268182a42205bd546be996fac6d05a071 URL: https://github.com/llvm/llvm-project/commit/bcc90f6268182a42205bd546be996fac6d05a071 DIFF: https://github.com/llvm/llvm-project/commit/bcc90f6268182a42205bd546be996fac6d05a071.diff

[PATCH] D131134: [X86] Report error if the amx enabled on the non-64-bits target

2022-08-10 Thread Craig Topper via Phabricator via cfe-commits
craig.topper added a comment. In D131134#3715062 , @pengfei wrote: > In D131134#3715024 , @pengfei wrote: > >> In D131134#3714860 , @craig.topper >> wrote: >> >>> Yes AMX

[clang] 09117b2 - [clang][sema] Print more information about failed static assertions

2022-08-10 Thread Timm Bäder via cfe-commits
Author: Timm Bäder Date: 2022-08-11T08:44:38+02:00 New Revision: 09117b21890c652994f7ada0229d309b35b44259 URL: https://github.com/llvm/llvm-project/commit/09117b21890c652994f7ada0229d309b35b44259 DIFF: https://github.com/llvm/llvm-project/commit/09117b21890c652994f7ada0229d309b35b44259.diff LO

[PATCH] D130894: [clang] Print more information about failed static assertions

2022-08-10 Thread Timm Bäder via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG09117b21890c: [clang][sema] Print more information about failed static assertions (authored by tbaeder). Changed prior to commit: https://reviews.llvm.org/D130894?vs=451143&id=451744#toc Repository:

[clang-tools-extra] 15bf2aa - [clangd][test] Fix error message in SerializationTest.BinaryConversions

2022-08-10 Thread Tom Praschan via cfe-commits
Author: Tom Praschan Date: 2022-08-11T08:50:23+02:00 New Revision: 15bf2aa44aa1ffa049782316273f84c2db682e50 URL: https://github.com/llvm/llvm-project/commit/15bf2aa44aa1ffa049782316273f84c2db682e50 DIFF: https://github.com/llvm/llvm-project/commit/15bf2aa44aa1ffa049782316273f84c2db682e50.diff

<    1   2   3