[PATCH] D130058: [Clang] Diagnose ill-formed constant expression when setting a non fixed enum to a value outside the range of the enumeration values

erichkeane added a comment. In D130058#3688049 , @thakis wrote: > Here's a reduced repro of one case: > > % cat test.cc > typedef enum VkResult { > VK_ERROR_INVALID_OPAQUE_CAPTURE_ADDRESS = -1000257000, > VK_RESULT_MAX_ENUM = 0x7FFF >

[PATCH] D129131: Remove uses of llvm_shutdown

Meinersbur added inline comments. Comment at: polly/lib/External/isl/interface/extract_interface.cc:590 delete Clang; - llvm::llvm_shutdown(); This file is imported from the upstream project (https://repo.or.cz/isl.git/blob/295cf91923295ca694e9e4

[PATCH] D130516: [llvm] compression classes

MaskRay added a comment. I'd like to make a few arguments for the current namespace+free function design, as opposed to the class+member function design as explored in this patch (but thanks for the exploration!). Let's discuss several use cases. (a) if a use case just calls compress/uncompress

[PATCH] D130516: [llvm] compression classes

leonardchan added inline comments. Comment at: llvm/lib/Support/Compression.cpp:30-32 +ZStdCompressionAlgorithm +*llvm::compression::ZStdCompressionAlgorithm::Instance = +new ZStdCompressionAlgorithm(); Perhaps for each of these, you could instead hav

[clang] 09c4121 - Revert "Revert "[Clang][Attribute] Introduce maybe_undef attribute for function arguments which accepts undef values""

Author: skc7 Date: 2022-07-29T19:07:07Z New Revision: 09c41211231578765cdb296bda3b4c7f3c22b4ba URL: https://github.com/llvm/llvm-project/commit/09c41211231578765cdb296bda3b4c7f3c22b4ba DIFF: https://github.com/llvm/llvm-project/commit/09c41211231578765cdb296bda3b4c7f3c22b4ba.diff LOG: Revert "

[PATCH] D130726: [clang][dataflow] Handle multiple context-sensitive calls to the same function

samestep updated this revision to Diff 448698. samestep added a comment. Add more comments and tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130726/new/ https://reviews.llvm.org/D130726 Files: clang/include/clang/Analysis/FlowSensitive/Dat

[PATCH] D130794: [Docs] Add HLSL ResourceType documentation

beanz created this revision. beanz added reviewers: aaron.ballman, pow2clk, python3kgae, bogner, MaskRay. Herald added subscribers: Anastasia, StephenFan, arphaman. Herald added a project: All. beanz requested review of this revision. Herald added a project: clang. Along with the new documentation

[PATCH] D130058: [Clang] Diagnose ill-formed constant expression when setting a non fixed enum to a value outside the range of the enumeration values

shafik added a comment. In D130058#3688049 , @thakis wrote: > Here's a reduced repro of one case: > > % cat test.cc > typedef enum VkResult { > VK_ERROR_INVALID_OPAQUE_CAPTURE_ADDRESS = -1000257000, > VK_RESULT_MAX_ENUM = 0x7FFF > }

[PATCH] D130726: [clang][dataflow] Handle multiple context-sensitive calls to the same function

ymandel accepted this revision. ymandel added a comment. Nice work! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130726/new/ https://reviews.llvm.org/D130726 ___ cfe-commits mailing list cfe-commits@lis

[PATCH] D128490: [ODRHash diagnostics] Transform method `ASTReader::diagnoseOdrViolations` into a class `ODRDiagsEmitter`. NFC.

vsapsai planned changes to this revision. vsapsai added inline comments. Comment at: clang/lib/Serialization/ASTReader.cpp:9577-9584 +static std::string getOwningModuleNameForDiagnostic(const Decl *D) { + // If we know the owning module, use it. + if (Module *M = D->getImported

[clang] a6ddc68 - [clang][dataflow] Handle multiple context-sensitive calls to the same function

Author: Sam Estep Date: 2022-07-29T19:40:19Z New Revision: a6ddc68487823d48c0ec0ddd649ace4a2732d0b0 URL: https://github.com/llvm/llvm-project/commit/a6ddc68487823d48c0ec0ddd649ace4a2732d0b0 DIFF: https://github.com/llvm/llvm-project/commit/a6ddc68487823d48c0ec0ddd649ace4a2732d0b0.diff LOG: [cl

[PATCH] D130726: [clang][dataflow] Handle multiple context-sensitive calls to the same function

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa6ddc6848782: [clang][dataflow] Handle multiple context-sensitive calls to the same function (authored by samestep). Changed prior to commit: http

[PATCH] D129798: [clang-tidy] Rename the make-confusable-table executable

mstorsjo added inline comments. Comment at: llvm/utils/gn/secondary/clang-tools-extra/clang-tidy/misc/ConfusableTable/BUILD.gn:1 -executable("make-confusable-table") { +executable("clang-tidy-confusable-chars-gen") { deps = [ "//llvm/lib/Support" ] thakis wro

[PATCH] D126676: [clang] Disallow differences in defines used for creating and using PCH

mstorsjo updated this revision to Diff 448708. mstorsjo added a comment. Update the parameters to the internal `checkPreprocessorOptions` function to use a three-state enum instead of having two separate `bool` flags. The 15.x release already has been branched, but I'd like to have this backpor

[PATCH] D130516: [llvm] compression classes

dblaikie added a comment. In D130516#3688123 , @MaskRay wrote: > I'd like to make a few arguments for the current namespace+free function > design, as opposed to the class+member function design as explored in this > patch (but thanks for the exploratio

[PATCH] D126676: [clang] Disallow differences in defines used for creating and using PCH

dexonsmith added a comment. In D126676#3687491 , @mstorsjo wrote: > In D126676#3687227 , @dexonsmith > wrote: > >> There are cases where it’s safe to have mismatched defines (e.g., if a >> define can be proven d

[PATCH] D128490: [ODRHash diagnostics] Transform method `ASTReader::diagnoseOdrViolations` into a class `ODRDiagsEmitter`. NFC.

vsapsai updated this revision to Diff 448710. vsapsai added a comment. - Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128490/new/ https://reviews.llvm.org/D128490 Files: clang/include/clang/AST/DeclCXX.h clang/include

[PATCH] D128490: [ODRHash diagnostics] Transform method `ASTReader::diagnoseOdrViolations` into a class `ODRDiagsEmitter`. NFC.

vsapsai marked 2 inline comments as done. vsapsai added inline comments. Comment at: clang/lib/Serialization/ASTReader.cpp:9193-9195 - // Otherwise, use the name of the top-level module the decl is within. - if (ModuleFile *M = getOwningModuleFile(D)) -return M->ModuleName;

[PATCH] D129118: CommandLine: add and use cl::SubCommand::get{All,TopLevel}

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129118/new/ https://reviews.llvm.org/D129118 ___

[PATCH] D130799: [clang] Keep declaration name info in DeclRefExpr

SimplyDanny created this revision. SimplyDanny added a reviewer: yvvan. Herald added a subscriber: arphaman. Herald added a project: All. SimplyDanny requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Without it `getCXXOperatorNameRange` retur

[PATCH] D129973: [clang] Pass FoundDecl to DeclRefExpr creator for operator overloads

SimplyDanny added a comment. In D129973#3684940 , @yvvan wrote: > With this change we don't pass "LocInfo" directly and it seems to break the > locations when calling "getCXXOperatorNameRange" for this DeclRefExpr later > on. Please fix it. You can intr

[PATCH] D130577: clang-driver: use llvm_fast_shutdown

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130577/new/ https://reviews.llvm.org/D130577 ___

[PATCH] D130710: [ASTWriter] Provide capability to output a PCM/PCH file that does not write out information about its output path

akyrtzi updated this revision to Diff 448715. akyrtzi added a comment. Add `FIXME` comment to consider either removing `ORIGINAL_PCH_DIR` or changing the default. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130710/new/ https://reviews.llvm.org/D

[PATCH] D130710: [ASTWriter] Provide capability to output a PCM/PCH file that does not write out information about its output path

akyrtzi added a comment. In D130710#3685436 , @benlangmuir wrote: > Is the functionality provided by `ORIGINAL_PCH_DIR` still useful for making > it possible to move a PCH and its referenced headers? It's not completely > clear to me when this feature

[PATCH] D130800: [clang][Headers] Avoid compiler warnings in builtin headers

ddcc created this revision. ddcc added reviewers: efriedma, rnk, aaron.ballman. Herald added a project: All. ddcc requested review of this revision. Herald added a project: clang. While debugging module support using -Wsystem-headers, we discovered that if -Werror, and -Wundef or -Wmacro-redefined

[PATCH] D129973: [clang] Pass FoundDecl to DeclRefExpr creator for operator overloads

yvvan added a comment. In D129973#3688329 , @SimplyDanny wrote: > In D129973#3684940 , @yvvan wrote: > >> With this change we don't pass "LocInfo" directly and it seems to break the >> locations when calling "ge

[PATCH] D122768: [Clang][C++20] Support capturing structured bindings in lambdas

cor3ntin updated this revision to Diff 448726. cor3ntin added a comment. Fix codegen test (Thanks Erich!) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122768/new/ https://reviews.llvm.org/D122768 Files: clang-tools-extra/clang-tidy/modernize/Lo

[PATCH] D130786: [clang-repl] Disable execution unittests on unsupported platforms.

alanphipps added a comment. I'm still seeing a failure on my downstream Arm compiler on Linux in the unit tests -- I thought I saw the same failure on the buildbots: FAIL: llvm_regressions :: Clang-Unit/Interpreter/ClangReplInterpreterTests/1/8 3

[PATCH] D130801: [clang-tidy] Add trace code for ASTVisitors

njames93 created this revision. njames93 added reviewers: alexfh, aaron.ballman. Herald added subscribers: carlosgalvezp, xazax.hun, mgorny. Herald added a project: All. njames93 requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. T

[PATCH] D130786: [clang-repl] Disable execution unittests on unsupported platforms.

sunho added a comment. In D130786#3688387 , @alanphipps wrote: > I'm still seeing a failure on my downstream Arm compiler on Linux in the unit > tests -- I thought I saw the same failure on the buildbots: > > FAIL: llvm_regressions :: > Clang-Unit/In

[clang] 65c9265 - [clang-repl] Disable exectuion unitests on unsupported platform by lljit instance test.

Author: Sunho Kim Date: 2022-07-30T07:18:04+09:00 New Revision: 65c9265f4158512e8dc85558ef8e73c0714e90c3 URL: https://github.com/llvm/llvm-project/commit/65c9265f4158512e8dc85558ef8e73c0714e90c3 DIFF: https://github.com/llvm/llvm-project/commit/65c9265f4158512e8dc85558ef8e73c0714e90c3.diff LOG

[clang] 944a86d - [ASTWriter] Provide capability to output a PCM/PCH file that does not write out information about its output path

Author: Argyrios Kyrtzidis Date: 2022-07-29T15:21:54-07:00 New Revision: 944a86de7c504121da8958b37b7fe8fff53d43a2 URL: https://github.com/llvm/llvm-project/commit/944a86de7c504121da8958b37b7fe8fff53d43a2 DIFF: https://github.com/llvm/llvm-project/commit/944a86de7c504121da8958b37b7fe8fff53d43a2.

[PATCH] D130710: [ASTWriter] Provide capability to output a PCM/PCH file that does not write out information about its output path

This revision was automatically updated to reflect the committed changes. Closed by commit rG944a86de7c50: [ASTWriter] Provide capability to output a PCM/PCH file that does not write out… (authored by akyrtzi). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[PATCH] D129954: [CodeGen][inlineasm] assume the flag output of inline asm is boolean value

ychen updated this revision to Diff 448732. ychen added a comment. - use < 2 - check multiple flag outputs Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129954/new/ https://reviews.llvm.org/D129954 Files: clang/lib/CodeGen/CGStmt.cpp clang/tes

[PATCH] D129954: [CodeGen][inlineasm] assume the flag output of inline asm is boolean value

ychen updated this revision to Diff 448733. ychen added a comment. - update test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129954/new/ https://reviews.llvm.org/D129954 Files: clang/lib/CodeGen/CGStmt.cpp clang/test/CodeGen/inline-asm-x86-f

[PATCH] D129954: [CodeGen][inlineasm] assume the flag output of inline asm is boolean value

ychen marked 2 inline comments as done. ychen added a comment. In D129954#3686780 , @nikic wrote: > LGTM. After some further consideration, implementing this properly in LLVM > would probably take more effort than is worthwhile (especially as this is >

[PATCH] D128757: [Driver][test] Add -fuse-ld= option tests for NetBSD

MaskRay added a comment. Windows is very different from all other OSes. Having a fuse-ld-windows.c may be fine. Again, NetBSD shares many characteristics with other OSes and having a test for all ~10 ELF OSes Clang supports seems too much. Repository: rG LLVM Github Monorepo CHANGES SINCE L

[clang] 32f59b3 - [clang-repl] Add missing link component.

Author: Sunho Kim Date: 2022-07-30T08:00:15+09:00 New Revision: 32f59b34b663c48c217047d4963ad3d1a2378c23 URL: https://github.com/llvm/llvm-project/commit/32f59b34b663c48c217047d4963ad3d1a2378c23 DIFF: https://github.com/llvm/llvm-project/commit/32f59b34b663c48c217047d4963ad3d1a2378c23.diff LOG

[PATCH] D130786: [clang-repl] Disable execution unittests on unsupported platforms.

sunho added a comment. @alanphipps I just confirmed that the buildbot failures were fixed by the new fix https://reviews.llvm.org/rG65c9265f4158. Could you check out if this fixes the failure on your end too? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D130807: [InstrProf] Add the omitprofile attribute

ellis created this revision. Herald added subscribers: Enna1, wenlei, jdoerfert, hiraditya. Herald added a project: All. ellis edited the summary of this revision. ellis added reviewers: phosek, davidxl. ellis published this revision for review. Herald added projects: clang, LLVM. Herald added subs

[PATCH] D130808: [InstrProf] Add new format for -fprofile-list=

ellis created this revision. Herald added a project: All. ellis edited the summary of this revision. ellis added a reviewer: phosek. ellis edited the summary of this revision. ellis added a reviewer: davidxl. ellis published this revision for review. Herald added a project: clang. Herald added a su

[PATCH] D130811: [Clang] Fix handling of Max from getValueRange(...) in IntExprEvaluator::VisitCastExpr(...)

shafik created this revision. shafik added reviewers: erichkeane, aaron.ballman, tahonermann, thakis. Herald added a project: All. shafik requested review of this revision. This is a follow-up to D130058 to fix how we handle the `Max` value we obtain from `getVa

[PATCH] D130811: [Clang] Fix handling of Max from getValueRange(...) in IntExprEvaluator::VisitCastExpr(...)

shafik added a comment. @thakis I created a PR for the fix to D130058 since I wanted to document this. As long the pre-commit checks don't show anything off I will land this. I added a test to also cover your case as well. CHANGES SINCE LAST ACTION https:/

[PATCH] D130620: Fix lack of cc1 flag in llvmcmd sections when assertions are enabled

mtrofin added a comment. In D130620#3686357 , @aidengrossman wrote: > Thanks for the review and your suggestions. Do you mind pushing this commit? > I don't currently have commit access to LLVM. Thanks. I can do it. Repository: rG LLVM Github Monor

[clang] afb4efd - Fix lack of cc1 flag in llvmcmd sections when assertions are enabled

Author: Aiden Grossman Date: 2022-07-29T18:51:48-07:00 New Revision: afb4efd3bcc68ab95bf3c35183bedbdbf038356a URL: https://github.com/llvm/llvm-project/commit/afb4efd3bcc68ab95bf3c35183bedbdbf038356a DIFF: https://github.com/llvm/llvm-project/commit/afb4efd3bcc68ab95bf3c35183bedbdbf038356a.diff

[PATCH] D130620: Fix lack of cc1 flag in llvmcmd sections when assertions are enabled

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGafb4efd3bcc6: Fix lack of cc1 flag in llvmcmd sections when assertions are enabled (authored by aidengrossman, committed by mtrofin). Repository:

[clang] a0d6105 - [Clang] Fix handling of Max from getValueRange(...) in IntExprEvaluator::VisitCastExpr(...)

Author: Shafik Yaghmour Date: 2022-07-29T19:17:42-07:00 New Revision: a0d61051628825e2f394240dc442ad5d81fa78bc URL: https://github.com/llvm/llvm-project/commit/a0d61051628825e2f394240dc442ad5d81fa78bc DIFF: https://github.com/llvm/llvm-project/commit/a0d61051628825e2f394240dc442ad5d81fa78bc.dif

[PATCH] D130811: [Clang] Fix handling of Max from getValueRange(...) in IntExprEvaluator::VisitCastExpr(...)

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa0d610516288: [Clang] Fix handling of Max from getValueRange(...)

[clang] fb7fa27 - Preserve qualifiers when getting fully qualified type

Author: Weverything Date: 2022-07-29T19:42:54-07:00 New Revision: fb7fa27f92caf10315d3fb7def99affb71b4fe44 URL: https://github.com/llvm/llvm-project/commit/fb7fa27f92caf10315d3fb7def99affb71b4fe44 DIFF: https://github.com/llvm/llvm-project/commit/fb7fa27f92caf10315d3fb7def99affb71b4fe44.diff L

[clang] a948117 - [clang] Use has_value instead of value (NFC)

Author: Kazu Hirata Date: 2022-07-29T21:18:39-07:00 New Revision: a9481170888447176f3552c62ff7dca693c25b97 URL: https://github.com/llvm/llvm-project/commit/a9481170888447176f3552c62ff7dca693c25b97 DIFF: https://github.com/llvm/llvm-project/commit/a9481170888447176f3552c62ff7dca693c25b97.diff L

[clang] e5a1ccb - Use value instead of getValue (NFC)

Author: Kazu Hirata Date: 2022-07-29T21:18:41-07:00 New Revision: e5a1ccbf254e2e44830fde3d83357c06b814f881 URL: https://github.com/llvm/llvm-project/commit/e5a1ccbf254e2e44830fde3d83357c06b814f881 DIFF: https://github.com/llvm/llvm-project/commit/e5a1ccbf254e2e44830fde3d83357c06b814f881.diff L

[clang-tools-extra] 873888c - Use is_sorted (NFC)

Author: Kazu Hirata Date: 2022-07-29T21:18:42-07:00 New Revision: 873888c179744eb0a35d4b6d69424c6adf3d08d4 URL: https://github.com/llvm/llvm-project/commit/873888c179744eb0a35d4b6d69424c6adf3d08d4 DIFF: https://github.com/llvm/llvm-project/commit/873888c179744eb0a35d4b6d69424c6adf3d08d4.diff L

[PATCH] D112374: [clang] Implement ElaboratedType sugaring for types written bare

rtrieu added inline comments. Comment at: clang/lib/AST/QualTypeNames.cpp:455 + if (const auto *UT = QT->getAs()) { +return getFullyQualifiedType(UT->getUnderlyingType(), Ctx, + WithGlobalNsPrefix); Moving this down here means

[PATCH] D128158: [AMDGPU] Add amdgcn_sched_group_barrier builtin

uabelho added inline comments. Comment at: llvm/lib/Target/AMDGPU/AMDGPUIGroupLP.cpp:314 + +bool SchedGroup::isFull() const { + return MaxSize && Collection.size() >= *MaxSize; Compiling with gcc, I get a warning that this function is unused. I'm wondering, ther

[PATCH] D130786: [clang-repl] Disable execution unittests on unsupported platforms.

alanphipps added a comment. In D130786#3688503 , @sunho wrote: > @alanphipps I just confirmed that the buildbot failures were fixed by the new > fix https://reviews.llvm.org/rG65c9265f4158. Could you check out if this > fixes the failure on your end too

[PATCH] D130807: [InstrProf] Add the omitprofile attribute

paulkirth added a comment. Do you expect the difference between `noprofile` and `omitprofile` to be confusing to users? I can certainly see how users could be confused by what the difference is between `noprofile` and `omitprofile` ... Since what you want to communicate is "never profile"(which

[PATCH] D122768: [Clang][C++20] Support capturing structured bindings in lambdas

cor3ntin updated this revision to Diff 448773. cor3ntin added a comment. Fix formatting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122768/new/ https://reviews.llvm.org/D122768 Files: clang-tools-extra/clang-tidy/modernize/LoopConvertUtils.cpp

[PATCH] D128569: Start support for HLSL `RWBuffer`

uabelho added a comment. Hello, Compiling with gcc I get the following warning with this patch: [1832/2330] Building CXX object tools/clang/lib/Sema/CMakeFiles/obj.clangSema.dir/HLSLExternalSemaSource.cpp.o In file included from ../../clang/include/clang/Sema/ExternalSemaSource.h:15,

[PATCH] D129242: [clang-repl] Add host exception support check utility flag.

uabelho added a comment. In D129242#3687968 , @sunho wrote: > https://reviews.llvm.org/D130788 this is the patch fyi. Great, the patch works for us. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D12

<    1   2