[PATCH] D128621: [clangd] Do not try to use $0 as a placeholder in completion snippets

nridge updated this revision to Diff 447112. nridge added a comment. Address final review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128621/new/ https://reviews.llvm.org/D128621 Files: clang-tools-extra/clangd/CodeCompletionStrings.c

[clang-tools-extra] 2eba08f - [clangd] Do not try to use $0 as a placeholder in completion snippets

Author: Nathan Ridge Date: 2022-07-24T03:01:18-04:00 New Revision: 2eba08fd9a5f42efb64ee8cc5ee0edebd8ce4bc0 URL: https://github.com/llvm/llvm-project/commit/2eba08fd9a5f42efb64ee8cc5ee0edebd8ce4bc0 DIFF: https://github.com/llvm/llvm-project/commit/2eba08fd9a5f42efb64ee8cc5ee0edebd8ce4bc0.diff

[PATCH] D128621: [clangd] Do not try to use $0 as a placeholder in completion snippets

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2eba08fd9a5f: [clangd] Do not try to use $0 as a placeholder in completion snippets (authored by nridge). Repository: rG LLVM Github Monorepo CHA

[PATCH] D130299: [clang-format] FIX: Misannotation 'auto' as trailing return type in lambdas

denis-fatkulin updated this revision to Diff 447115. denis-fatkulin added a comment. Test cases for `auto &` and `auto *` are added CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130299/new/ https://reviews.llvm.org/D130299 Files: clang/lib/Format/UnwrappedLineParser.cpp clang/unitt

[PATCH] D130417: [clang-format] Missing space between trailing return type 'auto' and left brace

denis-fatkulin updated this revision to Diff 447116. denis-fatkulin added a comment. Test cases for `auto &` and `auto *` are added CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130417/new/ https://reviews.llvm.org/D130417 Files: clang/lib/Format/TokenAnnotator.cpp clang/unittests/

[PATCH] D130437: [clang] Fix incorrect constant folding of `if consteval`

cor3ntin updated this revision to Diff 447118. cor3ntin added a comment. Fix test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130437/new/ https://reviews.llvm.org/D130437 Files: clang/docs/ReleaseNotes.rst clang/lib/AST/ExprConstant.cpp cl

[PATCH] D127284: [clang-repl] Support statements on global scope in incremental mode.

v.g.vassilev updated this revision to Diff 447120. v.g.vassilev retitled this revision from "[WIP] [clang-repl] Support statements on global scope in incremental mode." to "[clang-repl] Support statements on global scope in incremental mode.". v.g.vassilev edited the summary of this revision. v.g

[PATCH] D129891: [test-suite] Update the test suite for changes to -Wint-conversion

RKSimon added a comment. @aaron.ballman It looks like this broke the clang-ppc64-aix buildbot https://lab.llvm.org/buildbot/#/builders/214 /home/powerllvm/powerllvm_env/aix-ppc64/clang-ppc64-aix/test/sandbox/test-suite/tools/timeit --summary MultiSource/Applications/siod/CMakeFiles/siod.dir/

[clang] 94c3b16 - Fix crash in ObjC codegen introduced with 5ab6ee75994d645725264e757d67bbb1c96fb2b6

Author: David Chisnall Date: 2022-07-24T13:59:45+01:00 New Revision: 94c3b169785c0a0ae650c724dcf2c22ff65f5e24 URL: https://github.com/llvm/llvm-project/commit/94c3b169785c0a0ae650c724dcf2c22ff65f5e24 DIFF: https://github.com/llvm/llvm-project/commit/94c3b169785c0a0ae650c724dcf2c22ff65f5e24.diff

[PATCH] D123898: Fix crash in ObjC codegen introduced with 5ab6ee75994d645725264e757d67bbb1c96fb2b6

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG94c3b169785c: Fix crash in ObjC codegen introduced with… (authored by theraven). Changed prior to commit: https://reviews.llvm.org/D123898?vs=4232

[PATCH] D128190: [WinEH] Apply funclet operand bundles to nounwind intrinsics that lower to function calls

theraven accepted this revision. theraven added a comment. This revision is now accepted and ready to land. LGTM, a couple of extra comments would help. Comment at: llvm/include/llvm/IR/IntrinsicInst.h:110 + // Check if this intrinsic might lower into a regular function call

[PATCH] D129891: [test-suite] Update the test suite for changes to -Wint-conversion

aaron.ballman added a comment. In D129891#3674373 , @RKSimon wrote: > @aaron.ballman It looks like this broke the clang-ppc64-aix buildbot > https://lab.llvm.org/buildbot/#/builders/214 > > > /home/powerllvm/powerllvm_env/aix-ppc64/clang-ppc64-aix/tes

[PATCH] D129881: [C] Strengthen -Wint-conversion to default to an error

aaron.ballman added a comment. In D129881#3674159 , @augusto2112 wrote: > Actually, never mind, I think I can fix the tests. Thank you for the fix, and sorry for the trouble! In D129881#3674157 , @augusto2112

[PATCH] D130421: [Clang] De-deprecate volatile compound operations

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Comment at: clang/docs/ReleaseNotes.rst:519-523 - Implemented `P2290 Delimited escape sequences `_. This feature is availab

[PATCH] D130437: [clang] Fix incorrect constant folding of `if consteval`

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130437/new/ https://reviews.llvm.org/D130437

[clang] 0ba128f - [Clang] De-deprecate volatile compound operations

Author: Corentin Jabot Date: 2022-07-24T16:16:52+02:00 New Revision: 0ba128f7c8c2b6c0842cdfebcc1db0d11ce57dd9 URL: https://github.com/llvm/llvm-project/commit/0ba128f7c8c2b6c0842cdfebcc1db0d11ce57dd9 DIFF: https://github.com/llvm/llvm-project/commit/0ba128f7c8c2b6c0842cdfebcc1db0d11ce57dd9.diff

[PATCH] D130421: [Clang] De-deprecate volatile compound operations

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0ba128f7c8c2: [Clang] De-deprecate volatile compound operations (authored by cor3ntin). Changed prior to commit: https://reviews.llvm.org/D130421?

[clang] c68baa7 - [clang] Fix incorrect constant folding of `if consteval`

Author: Corentin Jabot Date: 2022-07-24T16:18:12+02:00 New Revision: c68baa73eb437556cd8abe40902182a6034930ac URL: https://github.com/llvm/llvm-project/commit/c68baa73eb437556cd8abe40902182a6034930ac DIFF: https://github.com/llvm/llvm-project/commit/c68baa73eb437556cd8abe40902182a6034930ac.diff

[PATCH] D130437: [clang] Fix incorrect constant folding of `if consteval`

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc68baa73eb43: [clang] Fix incorrect constant folding of `if consteval` (authored by cor3ntin). Repository: rG LLVM Github Monorepo CHANGES SINCE

[clang] fa8a189 - [Clang] Add missing paper revisions in the release notes [NFC]

Author: Corentin Jabot Date: 2022-07-24T16:24:11+02:00 New Revision: fa8a1896a784a771153d60cdf05da0fdff86d23c URL: https://github.com/llvm/llvm-project/commit/fa8a1896a784a771153d60cdf05da0fdff86d23c DIFF: https://github.com/llvm/llvm-project/commit/fa8a1896a784a771153d60cdf05da0fdff86d23c.diff

[PATCH] D130421: [Clang] De-deprecate volatile compound operations

cor3ntin added a comment. @aaron.ballman Thanks a lot for the review. I made a separate nfc commit to address the missing revision numbers. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130421/new/ https://reviews.llvm.org/D130421 ___

[PATCH] D130419: Use `` with MSVC and C++

Mordante added a comment. Can you add a dummy file in the libc++ subdirectory? That should trigger the libc++ pre-commit CI. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130419/new/ https://reviews.llvm.org/D130419 __

[clang] 46ae26e - [clang-tidy] implement new check 'misc-const-correctness' to add 'const' to unmodified variables

Author: Jonas Toth Date: 2022-07-24T19:37:54+02:00 New Revision: 46ae26e7eb7095faeda6d6c15470c256f9294c48 URL: https://github.com/llvm/llvm-project/commit/46ae26e7eb7095faeda6d6c15470c256f9294c48 DIFF: https://github.com/llvm/llvm-project/commit/46ae26e7eb7095faeda6d6c15470c256f9294c48.diff LO

[PATCH] D54943: [clang-tidy] implement new check 'misc-const-correctness' to add 'const' to unmodified variables

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG46ae26e7eb70: [clang-tidy] implement new check 'misc-const-correctness' to add 'const' to… (authored by JonasToth). Repo

[PATCH] D54943: [clang-tidy] implement new check 'misc-const-correctness' to add 'const' to unmodified variables

JonasToth added a comment. Thank you very much for all you patience, reviews and tests! I hope that the following improvements are now simpler to integrate and that the test matures well. :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54943/new/

[clang] 92df59c - [Driver] Enable some sanitizers on FreeBSD AArch64

Author: Andrew Turner Date: 2022-07-24T10:41:21-07:00 New Revision: 92df59c83d0de3d963a61ddc39dc3cd2c44e8304 URL: https://github.com/llvm/llvm-project/commit/92df59c83d0de3d963a61ddc39dc3cd2c44e8304 DIFF: https://github.com/llvm/llvm-project/commit/92df59c83d0de3d963a61ddc39dc3cd2c44e8304.diff

[PATCH] D130063: [Driver] Enable sanitizers on FreeBSD AArch64

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG92df59c83d0d: [Driver] Enable some sanitizers on FreeBSD AArch64 (authored by andrew, committed by MaskRay). Repository: rG LLVM Github Monorepo

[PATCH] D130443: [CGDebugInfo] Access the current working directory from the `VFS`

akyrtzi created this revision. Herald added a project: All. akyrtzi requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. ...instead of calling `llvm::sys::fs::current_path()` directly. Repository: rG LLVM Github Monorepo https://reviews.llv

[clang-tools-extra] 87d627b - Remove redundant string initialization (NFC)

Author: Kazu Hirata Date: 2022-07-24T12:27:11-07:00 New Revision: 87d627b623eb392610c073e6334782982373959a URL: https://github.com/llvm/llvm-project/commit/87d627b623eb392610c073e6334782982373959a DIFF: https://github.com/llvm/llvm-project/commit/87d627b623eb392610c073e6334782982373959a.diff L

[PATCH] D129048: Rewording the "static_assert" to static assertion

Mordante accepted this revision. Mordante added a comment. This revision is now accepted and ready to land. In D129048#3674500 , @Codesbyusman wrote: > updated the libcxx all files FYI for libcxx you can ignore the red format CI step. So the libcxx buil

[PATCH] D129048: Rewording the "static_assert" to static assertion

Codesbyusman added a comment. In D129048#3674582 , @Mordante wrote: > In D129048#3674500 , @Codesbyusman > wrote: > >> updated the libcxx all files > > FYI for libcxx you can ignore the red format CI step. So the

[PATCH] D130299: [clang-format] FIX: Misannotation 'auto' as trailing return type in lambdas

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. Do you have commit access, or do you want to apply for it, or do you need someone to push the change(s)? If the latter we need a name and mail for the commit. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D13

[PATCH] D130417: [clang-format] Missing space between trailing return type 'auto' and left brace

HazardyKnusperkeks added a comment. You should mark comments as done, if so. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130417/new/ https://reviews.llvm.org/D130417 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm

[PATCH] D130299: [clang-format] FIX: Misannotation 'auto' as trailing return type in lambdas

denis-fatkulin added a comment. In D130299#3674586 , @HazardyKnusperkeks wrote: > Do you have commit access, or do you want to apply for it, or do you need > someone to push the change(s)? If the latter we need a name and mail for the > commit. I have

[PATCH] D130417: [clang-format] Missing space between trailing return type 'auto' and left brace

denis-fatkulin marked 2 inline comments as done. denis-fatkulin added a comment. They marked done. Thanks! Comment at: clang/unittests/Format/FormatTest.cpp:23555-23556 + FormatStyle Style = getLLVMStyle(); + verifyFormat("[]() -> auto { return Val; }", Style); + verifyForma

[clang] 9e88cbc - Use any_of (NFC)

Author: Kazu Hirata Date: 2022-07-24T14:48:11-07:00 New Revision: 9e88cbcc403bdf82f29259ad60ff60a8fc4434a1 URL: https://github.com/llvm/llvm-project/commit/9e88cbcc403bdf82f29259ad60ff60a8fc4434a1 DIFF: https://github.com/llvm/llvm-project/commit/9e88cbcc403bdf82f29259ad60ff60a8fc4434a1.diff L

[PATCH] D129138: [clang] [docs] Update the changes of C++20 Modules in clang15

iains added a comment. In D129138#3670708 , @ChuanqiXu wrote: > @iains I'm going to land this in next Monday if all the dependent patch > landed. Do you feel good with this? I am not sure if we will get p1815 part 1 landed (effectively today) - and, of

[PATCH] D122768: [Clang][C++20] Support capturing structured bindings in lambdas

shafik added inline comments. Comment at: clang/lib/AST/StmtPrinter.cpp:2166 if (Node->isInitCapture(C)) { + VarDecl *D = cast(C->getCapturedVar()); I wonder if it is worth commenting that only a `VarDecl` can be an init capture and therefore we can

[PATCH] D125272: [clang] Add -fcheck-new support

MaskRay requested changes to this revision. MaskRay added inline comments. This revision now requires changes to proceed. Herald added a subscriber: StephenFan. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:4117 + if (const Arg *A = Args.getLastArg(OPT_fcheck_new)) +

[PATCH] D127189: [clang][AIX] Add option to control quadword lock free atomics ABI on AIX

shchenz added a comment. Thanks for the explanation. I am more clear now about the background. Comment at: clang/include/clang/Driver/Options.td:3611 HelpText<"Enable the default Altivec ABI on AIX (AIX only). Uses only volatile vector registers.">; +def maix_quadword_atomi

[PATCH] D130419: Use `` with MSVC and C++

fsb4000 updated this revision to Diff 447163. fsb4000 added a comment. Herald added a subscriber: libcxx-commits. Herald added 1 blocking reviewer(s): libc++. added a dummy.txt in libcxx directory Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130419

[PATCH] D130446: [apinotes] Upstream changes to `APINotesYAMLCompiler.cpp`.

zoecarver created this revision. zoecarver added a reviewer: compnerd. Herald added a project: All. zoecarver requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D130446 Files:

[PATCH] D127189: [clang][AIX] Add option to control quadword lock free atomics ABI on AIX

lkail added inline comments. Comment at: clang/include/clang/Driver/Options.td:3611 HelpText<"Enable the default Altivec ABI on AIX (AIX only). Uses only volatile vector registers.">; +def maix_quadword_atomics : Flag<["-"], "maix64-quadword-atomics">, + Group, Flags<[CC1Opt

[PATCH] D128955: [WPD] Use new llvm.public.type.test intrinsic for potentially publicly visible classes

aeubanks updated this revision to Diff 447170. aeubanks marked an inline comment as done. aeubanks added a comment. update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128955/new/ https://reviews.llvm.org/D128955 Files: clang/lib/CodeGen/CGClas

[PATCH] D128955: [WPD] Use new llvm.public.type.test intrinsic for potentially publicly visible classes

aeubanks added a comment. random question, if the old API is "legacy", are there any plans to remove it? Comment at: llvm/test/LTO/X86/public-type-test.ll:3 + +; RUN: opt -module-summary %s -o %t.bc +; RUN: llvm-lto --thinlto-action=run -exported-symbol=_main %t.bc --thinlto-s

[PATCH] D129174: [C++20][Modules] Update ADL to handle basic.lookup.argdep p4 [P1815R2 part 1]

ChuanqiXu added inline comments. Comment at: clang/lib/Sema/SemaLookup.cpp:3864-3878 + for (auto *E : AssociatedClasses) { +// and have the same innermost enclosing non-inline namespace +// scope as a declaration of an associated entit

[PATCH] D125272: [clang] Add -fcheck-new support

jrtc27 added inline comments. Comment at: clang/test/CodeGenCXX/fcheck-new.cpp:3 +// RUN: %clang_cc1 -fcheck-new -triple x86_64-linux-gnu -S -disable-O0-optnone \ +// RUN: -emit-llvm -o - %s | opt -S -mem2reg | FileCheck %s + MaskRay wrote: > Please remove `opt`

[PATCH] D130331: [C++20] [Modules] Disable preferred_name when writing a C++20 Module interface

ChuanqiXu updated this revision to Diff 447185. ChuanqiXu added a comment. Add more tests. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130331/new/ https://reviews.llvm.org/D130331 Files: clang/include/clang/Serialization/ASTWriter.h clang/lib/Serialization/ASTReaderDecl.cpp cla

[PATCH] D130331: [C++20] [Modules] Disable preferred_name when writing a C++20 Module interface

ChuanqiXu added inline comments. Comment at: clang/lib/Serialization/ASTReaderDecl.cpp:2925-2926 for (unsigned I = 0, E = readInt(); I != E; ++I) -Attrs.push_back(readAttr()); +if (auto *Attr = readAttr()) + Attrs.push_back(Attr); } tahonermann w

[clang] edaae25 - [clang] better error message for while loops outside of control flow

Author: inclyc Date: 2022-07-25T11:48:24+08:00 New Revision: edaae251cca07c34c55905c424a8f677623d0bd0 URL: https://github.com/llvm/llvm-project/commit/edaae251cca07c34c55905c424a8f677623d0bd0 DIFF: https://github.com/llvm/llvm-project/commit/edaae251cca07c34c55905c424a8f677623d0bd0.diff LOG: [

[PATCH] D129573: [clang] better error message for while loops outside of control flow

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGedaae251cca0: [clang] better error message for while loops outside of control flow (authored by inclyc). Repository: rG LLVM Github Monorepo CHAN

[clang] 3650615 - [clang] Remove unused forward declarations (NFC)

Author: Kazu Hirata Date: 2022-07-24T20:51:06-07:00 New Revision: 3650615fb28aad3730c33cc26d23a6836743e305 URL: https://github.com/llvm/llvm-project/commit/3650615fb28aad3730c33cc26d23a6836743e305 DIFF: https://github.com/llvm/llvm-project/commit/3650615fb28aad3730c33cc26d23a6836743e305.diff L

[PATCH] D129311: [clang-format] Update return code

owenpan added inline comments. Comment at: clang/tools/clang-format/git-clang-format:201 if opts.diff: -print_diff(old_tree, new_tree) - elif opts.diffstat: -print_diffstat(old_tree, new_tree) - else: -changed_files = apply_changes(old_tree, new_tree, force=opts.

[PATCH] D127189: [clang][AIX] Add option to control quadword lock free atomics ABI on AIX

shchenz added inline comments. Comment at: clang/include/clang/Driver/Options.td:3611 HelpText<"Enable the default Altivec ABI on AIX (AIX only). Uses only volatile vector registers.">; +def maix_quadword_atomics : Flag<["-"], "maix64-quadword-atomics">, + Group, Flags<[CC1O

[PATCH] D127189: [clang][AIX] Add option to control quadword lock free atomics ABI on AIX

lkail added inline comments. Comment at: clang/include/clang/Driver/Options.td:3611 HelpText<"Enable the default Altivec ABI on AIX (AIX only). Uses only volatile vector registers.">; +def maix_quadword_atomics : Flag<["-"], "maix64-quadword-atomics">, + Group, Flags<[CC1Opt

[clang] a210f40 - [clang] Remove redundant virtual specifies (NFC)

Author: Kazu Hirata Date: 2022-07-24T22:02:58-07:00 New Revision: a210f404da04ff4db60cdf1a7f4060c82c59c360 URL: https://github.com/llvm/llvm-project/commit/a210f404da04ff4db60cdf1a7f4060c82c59c360 DIFF: https://github.com/llvm/llvm-project/commit/a210f404da04ff4db60cdf1a7f4060c82c59c360.diff L

[clang] 95a932f - Remove redundaunt override specifiers (NFC)

Author: Kazu Hirata Date: 2022-07-24T22:28:11-07:00 New Revision: 95a932fb15960e66fdc43dc9821685addd5ee44d URL: https://github.com/llvm/llvm-project/commit/95a932fb15960e66fdc43dc9821685addd5ee44d DIFF: https://github.com/llvm/llvm-project/commit/95a932fb15960e66fdc43dc9821685addd5ee44d.diff L

[clang-tools-extra] 95a932f - Remove redundaunt override specifiers (NFC)

Author: Kazu Hirata Date: 2022-07-24T22:28:11-07:00 New Revision: 95a932fb15960e66fdc43dc9821685addd5ee44d URL: https://github.com/llvm/llvm-project/commit/95a932fb15960e66fdc43dc9821685addd5ee44d DIFF: https://github.com/llvm/llvm-project/commit/95a932fb15960e66fdc43dc9821685addd5ee44d.diff L

[PATCH] D125693: [DebugInfo] Support types, imports and static locals declared in a lexical block (3/5)

krisb added a comment. In D125693#3653631 , @dblaikie wrote: > In D125693#3648942 , @krisb wrote: > >> In D125693#3644029 , @dblaikie >> wrote: >> >>> In D125693#3641742

[PATCH] D128667: [WIP] Add Zstd ELF support

MaskRay added inline comments. Comment at: llvm/tools/llvm-objcopy/ObjcopyOptions.cpp:1015 + } else { +if (Config.DecompressDebugSections && !compression::zstd::isAvailable()) + return createStringError( For --decompress-debug-sections, the zstd error s

[PATCH] D127189: [clang][AIX] Add option to control quadword lock free atomics ABI on AIX

shchenz accepted this revision as: shchenz. shchenz added a comment. This revision is now accepted and ready to land. LGTM. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127189/new/ https://reviews.llvm.org/D127189

[PATCH] D119792: [Clang] [P2025] Analyze only potential scopes for NRVO

rusyaev-roman added a comment. @ChuanqiXu , could you take a look again? I've updated the original implementation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119792/new/ https://reviews.llvm.org/D119792 ___