[PATCH] D129348: [clang-format] Fix an assertion failure on -lines=0:n

owenpan created this revision. owenpan added reviewers: curdeius, HazardyKnusperkeks, MyDeveloperDay. owenpan added a project: clang-format. Herald added a project: All. owenpan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Also fixed the

[PATCH] D129348: [clang-format] Fix an assertion failure on -lines=0:n

curdeius accepted this revision. curdeius added a comment. This revision is now accepted and ready to land. 👍 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129348/new/ https://reviews.llvm.org/D129348 __

[PATCH] D129100: [clangd] Support external throttler for preamble builds

kadircet added inline comments. Comment at: clang-tools-extra/clangd/TUScheduler.cpp:499 // Build the preamble and let the waiters know about it. build(std::move(*CurrentReq)); } regarding the flakiness, what about resetting the `Throttle

[PATCH] D128328: [C++20][Modules] Improve handing of Private Module Fragment diagnostics.

iains added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:11155 +def err_export_inline_not_defined : Error< + "exported inline functions must be defined within the module purview" + " and before any private module fragment">; Chu

[PATCH] D126694: [C++20][Modules] Implementation of GMF decl elision.

iains added a comment. In D126694#3637690 , @ChuanqiXu wrote: > In D126694#3635207 , @iains wrote: > >> @rsmith, @ChuanqiXu apologies for the multiple revisions, this has turned >> out to be much more involved th

[PATCH] D128328: [C++20][Modules] Improve handing of Private Module Fragment diagnostics.

ChuanqiXu added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:11155 +def err_export_inline_not_defined : Error< + "exported inline functions must be defined within the module purview" + " and before any private module fragment">;

[PATCH] D126694: [C++20][Modules] Implementation of GMF decl elision.

ChuanqiXu added a comment. In D126694#3638069 , @iains wrote: > In D126694#3637690 , @ChuanqiXu > wrote: > >> In D126694#3635207 , @iains wrote: >> >>> @rsmith, @ChuanqiX

[PATCH] D128977: [clangd] Support "usedAsMutableReference" in member initializations

nridge accepted this revision. nridge added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128977/new/ https://reviews.llvm.org/D128977

[PATCH] D129353: [clang-tidy] Improve check cert-dcl58-cpp.

balazske created this revision. Herald added subscribers: carlosgalvezp, steakhal, martong, gamesh411, Szelethus, dkrupp, xazax.hun. Herald added a project: All. balazske requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Detect t

[PATCH] D128977: [clangd] Support "usedAsMutableReference" in member initializations

ckandeler added a comment. Can you please merge it as well? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128977/new/ https://reviews.llvm.org/D128977 ___ cfe-commits mailing list cfe-commits@lists.llvm.

[PATCH] D128977: [clangd] Support "usedAsMutableReference" in member initializations

nridge added a comment. Yes, I plan to. I'm just building it locally to verify the tests are passing. (And sometimes, for reasons I don't understand, LLVM's build system triggers a full rebuild even though I've only applied a patch that touches a couple of files...) Repository: rG LLVM Gith

[PATCH] D128977: [clangd] Support "usedAsMutableReference" in member initializations

ckandeler added a comment. In D128977#3638198 , @nridge wrote: > Yes, I plan to. I'm just building it locally to verify the tests are passing. > (And sometimes, for reasons I don't understand, LLVM's build system triggers > a full rebuild even though I'

[PATCH] D128411: [syntax] Introduce a BaseToken class.

hokein updated this revision to Diff 443173. hokein marked 9 inline comments as done. hokein added a comment. Herald added a subscriber: mgorny. address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128411/new/ https://reviews.llvm

[PATCH] D129280: [analyzer] PlacementNewChecker, properly handle array overhead (cookie)

martong updated this revision to Diff 443174. martong added a comment. - Replace "might" with "unspecified value" Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129280/new/ https://reviews.llvm.org/D129280 Files: clang/lib/StaticAnalyzer/Checkers

[PATCH] D129280: [analyzer] PlacementNewChecker, properly handle array overhead (cookie)

martong marked an inline comment as done. martong added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/CheckPlacementNew.cpp:157 "Storage provided to placement new is only {0} bytes, " -"whereas the allocated array type requires more space

[PATCH] D128411: [syntax] Introduce a BaseToken class.

hokein added inline comments. Comment at: clang/include/clang/Tooling/Syntax/TokenManager.h:37 + + // FIXME: add an interface for getting token kind. +}; sammccall wrote: > I wouldn't want to prejudge this: this is a very basic attribute similar to > kind/role,

[PATCH] D129202: [clang] Add a fixit for warn-self-assign if LHS is a field with the same name as parameter on RHS

njames93 updated this revision to Diff 443180. njames93 added a comment. Attach fix directly to the warning. Extend checking to also work with move assignments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129202/new/ https://reviews.llvm.org/D129

[PATCH] D126864: [clang] Introduce -fstrict-flex-arrays= for stricter handling of flexible arrays

serge-sans-paille updated this revision to Diff 443185. serge-sans-paille marked 4 inline comments as done. serge-sans-paille added a comment. Take reviews into account, basically spreading a lot of FIXME across the codebase :'( Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D129100: [clangd] Support external throttler for preamble builds

sammccall added inline comments. Comment at: clang-tools-extra/clangd/TUScheduler.cpp:499 // Build the preamble and let the waiters know about it. build(std::move(*CurrentReq)); } kadircet wrote: > regarding the flakiness, what about rese

[PATCH] D129170: [Sema] Add deprecation warnings for some compiler provided __has_* type traits

royjacobson added inline comments. Comment at: clang/lib/Sema/SemaExprCXX.cpp:5400-5401 +SourceLocation KWLoc) { + if (!S.getLangOpts().CPlusPlus11) +return; + aaron.ballman wrote: > erichkeane wrote: > > royjacobs

[PATCH] D129359: [pseudo] Generate an enum type for identifying grammar rules.

hokein created this revision. hokein added a reviewer: sammccall. Herald added a project: All. hokein requested review of this revision. Herald added a subscriber: alextsao1999. Herald added a project: clang-tools-extra. The Rule enum type enables us to identify a grammar rule within C++'s type sy

[PATCH] D129222: [pseudo] Implement a guard to determine function declarator.

hokein added inline comments. Comment at: clang-tools-extra/pseudo/gen/Main.cpp:114 + const clang::pseudo::Rule &R = G.table().Rules[RID]; + // lhs$$rhs$rhs$rhs + std::string EnumName = symbolName(R.Target, G) + "$"; sammccall wrote: > hokein wrote

[PATCH] D129174: [C++20][Modules] Update ADL to handle basic.lookup.argdep p4 [P1815R2 part 1]

iains updated this revision to Diff 443194. iains retitled this revision from "[C++20][Modules] Invalidate internal-linkage functions in overload sets [P1815R2 part 1]" to "[C++20][Modules] Update ADL to handle basic.lookup.argdep p4 [P1815R2 part 1]". iains edited the summary of this revision. i

[PATCH] D128119: [clang] enforce instantiation of constexpr template functions

aaron.ballman added a comment. Pinging about updates to this, because if this really does fix https://github.com/llvm/llvm-project/issues/55560, I think we want to get that fix into Clang 15. The release branch point is coming up pretty soon (https://discourse.llvm.org/t/llvm-15-0-0-release-sch

[PATCH] D128697: [clang-tidy] Add new check `bugprone-unhandled-exception-at-sto`

Sockke added a comment. In D128697#3615404 , @Eugene.Zelenko wrote: > I think will be good idea to make check more generic and allow user-defined > list of unsafe functions. I understand that user-defined is implemented through the config, but some ty

[PATCH] D128697: [clang-tidy] Add new check `bugprone-unhandled-exception-at-sto`

Sockke added a comment. In D128697#3619310 , @LegalizeAdulthood wrote: > This whole check seems weird to me. I mean, almost every use of a standard > container could throw `std::bad_alloc` but we don't insist on a local `catch` > for `bad_alloc` at ev

[PATCH] D127293: [clang-tidy] Ignore other members in a union if any member of it is initialized in cppcoreguidelines-pro-type-member-init

Sockke added a comment. Friendly ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127293/new/ https://reviews.llvm.org/D127293 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm

[PATCH] D129362: Undeprecate ATOMIC_FLAG_INIT in C++

aaron.ballman created this revision. aaron.ballman added reviewers: clang-language-wg, erichkeane, cor3ntin, tambre, ldionne. Herald added a project: All. aaron.ballman requested review of this revision. Herald added a project: clang. C++20 deprecated ATOMIC_FLAG_INIT thinking it was deprecated i

[PATCH] D125095: [Clang][AIX] Add .ref in frontend for AIX XCOFF to support `-bcdtors:csect` linker option

tingwang updated this revision to Diff 443201. tingwang added a comment. Add guards against TLS variables. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125095/new/ https://reviews.llvm.org/D125095 Files: clang/lib/CodeGen/CGDecl.cpp clang/lib

[PATCH] D129362: Undeprecate ATOMIC_FLAG_INIT in C++

tambre accepted this revision. tambre added a comment. This revision is now accepted and ready to land. Makes sense to me, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129362/new/ https://reviews.llvm.org/D129362 _

[clang] 35f4857 - Fix the Clang sphinx bot

Author: Aaron Ballman Date: 2022-07-08T07:23:40-04:00 New Revision: 35f48572e3c752cea281ba62292f682bfd98ff18 URL: https://github.com/llvm/llvm-project/commit/35f48572e3c752cea281ba62292f682bfd98ff18 DIFF: https://github.com/llvm/llvm-project/commit/35f48572e3c752cea281ba62292f682bfd98ff18.diff

[clang] fee77a2 - Disable clang-format entirely for test directories

Author: Aaron Ballman Date: 2022-07-08T07:34:18-04:00 New Revision: fee77a20732cb629629c52123643fa5928ebfc1c URL: https://github.com/llvm/llvm-project/commit/fee77a20732cb629629c52123643fa5928ebfc1c DIFF: https://github.com/llvm/llvm-project/commit/fee77a20732cb629629c52123643fa5928ebfc1c.diff

[PATCH] D128706: [Clang] Disable clang-format entirely for clang/test tree.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGfee77a20732c: Disable clang-format entirely for test directories (authored by aaron.ballman). Repository: rG LLVM Github Monorepo CHANGES SINCE L

[PATCH] D129202: [clang] Add a fixit for warn-self-assign if LHS is a field with the same name as parameter on RHS

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM with some minor stuff you can fix when landing. Thank you for this! Comment at: clang/include/clang/Sema/Sema.h:5170-5171 + FieldDecl * + getSelfAssign

[PATCH] D124447: [clang-tidy] Add infrastructure support for running on project-level information

kadircet added a comment. The idea looks great in general, I didn't get a chance to look at all the details but this also creates some concerns for integrations of clang-tidy checks in other environments (like clangd or tidy running in distributed systems) as the workflow actually needs to be r

[PATCH] D128059: [Clang] Add a warning on invalid UTF-8 in comments.

cor3ntin updated this revision to Diff 443222. cor3ntin added a comment. Fix bound check in the non vectorized case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128059/new/ https://reviews.llvm.org/D128059 Files: clang/docs/ReleaseNotes.rst c

[PATCH] D128059: [Clang] Add a warning on invalid UTF-8 in comments.

aaron.ballman accepted this revision. aaron.ballman added a comment. I only spotted one thing I think is actually an issue, the rest is style related. LGTM with the one issue fixed. Comment at: clang/lib/Lex/Lexer.cpp:2707-2709 +if (!isASCII(C)) { + goto Multi

[PATCH] D128059: [Clang] Add a warning on invalid UTF-8 in comments.

cor3ntin updated this revision to Diff 443225. cor3ntin marked 19 inline comments as done. cor3ntin added a comment. Remove superfuous braces. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128059/new/ https://reviews.llvm.org/D128059 Files: clan

[PATCH] D129359: [pseudo] Generate an enum type for identifying grammar rules.

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/pseudo/include/clang-pseudo/grammar/Grammar.h:172 + // terminal `,` becomes `comma`; + // terminal `INT` becomes `int`; + std::

[PATCH] D128119: [clang] Enforce instantiation of constexpr template functions during non-constexpr evaluation

serge-sans-paille updated this revision to Diff 443230. serge-sans-paille retitled this revision from "[clang] enforce instantiation of constexpr template functions" to "[clang] Enforce instantiation of constexpr template functions during non-constexpr evaluation". serge-sans-paille edited the su

[PATCH] D128119: [clang] Enforce instantiation of constexpr template functions during non-constexpr evaluation

serge-sans-paille added a comment. @shafik: I've implemented your patch which indeed looks closer to the original intent @aaron.ballman : test case and code updated. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128119/new/ https://reviews.llvm.or

[PATCH] D129298: Add denormal-fp-math attribute for f16

dcandler added a comment. There are currently no Arm specific changes, this is just being able to more accurately describe the floating point environment via attributes in the case where singles and doubles should be flushed, but not halves. With three precisions to control, an alternative may

[PATCH] D124446: [clang-tidy] Add the misc-discarded-return-value check

aaron.ballman added reviewers: alexfh, LegalizeAdulthood. aaron.ballman added a subscriber: alexfh. aaron.ballman added a comment. Precommit CI has found some build errors with the changes that should be addressed. Thank you for all the timing measurement information, that's really helpful! It

[PATCH] D128119: [clang] Enforce instantiation of constexpr template functions during non-constexpr evaluation

serge-sans-paille updated this revision to Diff 443243. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128119/new/ https://reviews.llvm.org/D128119 Files: clang/lib/Sema/SemaTemplateInstantiateDecl.cpp clang/test/CodeGenCXX/constexpr-late-instantiation.cpp clang/test/SemaCXX/constex

[PATCH] D129362: Undeprecate ATOMIC_FLAG_INIT in C++

aaron.ballman added a comment. In D129362#3638485 , @tambre wrote: > Makes sense to me, thanks! Thanks! Would you mind handling the libc++ side like last time, or do you prefer I handle it as part of the changes in this patch? Repository: rG LLVM Gi

[PATCH] D129373: [NFC] Minor cleanup of usage of FloatModeKind with bitmask enums

jolanta.jensen created this revision. Herald added a project: All. jolanta.jensen requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D129373 Files: clang/include/clang/Basic/Ta

[PATCH] D128119: [clang] Enforce instantiation of constexpr template functions during non-constexpr evaluation

aaron.ballman added a comment. Can you also add a release note for the fix? Comment at: clang/test/SemaCXX/constexpr-late-instantiation.cpp:2 +// Make sure foo is instantiated and we don't get a link error +// RUN: not %clang_cc1 -S -emit-llvm %s -fsyntax-only 2>&1 | FileCheck

[PATCH] D129353: [clang-tidy] Improve check cert-dcl58-cpp.

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/cert/DontModifyStdNamespaceCheck.cpp:29 + continue; +ArrayRef List1 = Arg.getPackAsArray(); +if (matchesFirstInRange(InnerMatcher, List1.begin(), List1.end(), Finder, Might

[PATCH] D129231: [Builtins] Do not claim all libfuncs are readnone with trapping math.

john.brawn added a comment. Looking at the descriptions of maths functions in C99 (and I expect C11 will be the same) it looks like there are three kinds: - Those that can report error by errno and floating-point exeption, and may also raise the inexact exception - Those that don't set errno, b

[PATCH] D129277: [clang] [Serialization] Fix swapped PPOpts/ExistingPPOpts parameters. NFC.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. In D129277#3637317 , @mstorsjo wrote: > In D129277#3636795 , @aaron.ballman > wrote: > >> In D

[PATCH] D128927: [libc++] Always build c++experimental.a

ldionne marked an inline comment as done. ldionne added a comment. Thanks @mstorsjo! Regarding `_LIBCPP_EXPERIMENTAL_FUNC_VIS`, yes I think it would make sense to use a different visibility macro for symbols that we know are provided only as part of a static library. I would not call it `_LIBCP

[PATCH] D128927: [libc++] Always build c++experimental.a

ldionne updated this revision to Diff 443252. ldionne marked an inline comment as done. ldionne added a comment. Windows fixes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128927/new/ https://reviews.llvm.org/D128927 Files: clang/cmake/caches/

[clang] d2ead9e - [LinkerWrapper][NFC] Rework command line argument handling in the linker wrapper

Author: Joseph Huber Date: 2022-07-08T11:18:38-04:00 New Revision: d2ead9e324d4d268e8c0634849d6081e177c9dd7 URL: https://github.com/llvm/llvm-project/commit/d2ead9e324d4d268e8c0634849d6081e177c9dd7 DIFF: https://github.com/llvm/llvm-project/commit/d2ead9e324d4d268e8c0634849d6081e177c9dd7.diff

[clang] e0de264 - [LinkerWrapper][NFC] Move error handling to a common function

Author: Joseph Huber Date: 2022-07-08T11:18:38-04:00 New Revision: e0de264f6355c397e91927827a9cbb940c903607 URL: https://github.com/llvm/llvm-project/commit/e0de264f6355c397e91927827a9cbb940c903607 DIFF: https://github.com/llvm/llvm-project/commit/e0de264f6355c397e91927827a9cbb940c903607.diff

[PATCH] D129373: [NFC] Minor cleanup of usage of FloatModeKind with bitmask enums

jolanta.jensen updated this revision to Diff 443258. jolanta.jensen added a comment. Removing a tab. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129373/new/ https://reviews.llvm.org/D129373 Files: clang/include/clang/Basic/TargetInfo.h clang

[PATCH] D129170: [Sema] Add deprecation warnings for some compiler provided __has_* type traits

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaExprCXX.cpp:5400-5401 +SourceLocation KWLoc) { + if (!S.getLangOpts().CPlusPlus11) +return; + royjacobson wrote: > aaron.ballman wrote: > > erichk

[PATCH] D128449: [clang] Introduce -Warray-parameter

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, thank you for the new diagnostic! Comment at: clang/lib/Sema/SemaDecl.cpp:3213 +static bool EquivalentArrayTypes(QualType Old, QualType New, +

[clang] 74a8fce - [LinkerWrapper] Fix save-temps and argument name

Author: Joseph Huber Date: 2022-07-08T11:38:33-04:00 New Revision: 74a8fce6e87e81802b4fe69769daec19504753bf URL: https://github.com/llvm/llvm-project/commit/74a8fce6e87e81802b4fe69769daec19504753bf DIFF: https://github.com/llvm/llvm-project/commit/74a8fce6e87e81802b4fe69769daec19504753bf.diff

[PATCH] D128182: [NFC] Switch FloatModeKind enum class to use bitmask enums

jolanta.jensen added a comment. @tahonermann, I addressed your comments in https://reviews.llvm.org/D129373. I just need to remove a tab that crept in and it seems to be more difficult than I thought as my code does not seem to have any tab and reformatting the code does not change the file.

[clang] 0d7161a - [Clang] Fix test failing due to renamed arg

Author: Joseph Huber Date: 2022-07-08T11:50:56-04:00 New Revision: 0d7161af89f91db798f7be2a521568a4cd754214 URL: https://github.com/llvm/llvm-project/commit/0d7161af89f91db798f7be2a521568a4cd754214 DIFF: https://github.com/llvm/llvm-project/commit/0d7161af89f91db798f7be2a521568a4cd754214.diff

[PATCH] D75788: [OpenMP] Provide math functions in OpenMP device code via OpenMP variants

jdoerfert added inline comments. Comment at: clang/lib/Headers/CMakeLists.txt:145 set(openmp_wrapper_files openmp_wrappers/math.h chapuni wrote: > It doesn't contain , intentional? We don't wrap that yet. Do you need it? Repository: rG LLVM Github Monor

[PATCH] D129362: Undeprecate ATOMIC_FLAG_INIT in C++

tambre added a comment. In D129362#3638896 , @aaron.ballman wrote: > In D129362#3638485 , @tambre wrote: > >> Makes sense to me, thanks! > > Thanks! Would you mind handling the libc++ side like last time, or do y

[PATCH] D121141: [Clang] Add `-funstable` flag to enable unstable and experimental features: follow-up fixes

MaskRay added inline comments. Comment at: clang/docs/ClangCommandLineReference.rst:276 + +Enable unstable and experimental language and library features. + The doc is auto-generated by tablegen (https://discourse.llvm.org/t/clang-driver-options-td-docs-usersman

[PATCH] D119051: Extend the C++03 definition of POD to include defaulted functions

dblaikie added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119051/new/ https://reviews.llvm.org/D119051 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[PATCH] D129362: Undeprecate ATOMIC_FLAG_INIT in C++

aaron.ballman added a comment. In D129362#3639193 , @tambre wrote: > In D129362#3638896 , @aaron.ballman > wrote: > >> In D129362#3638485 , @tambre wrote: >> >>> Makes se

[PATCH] D128119: [clang] Enforce instantiation of constexpr template functions during non-constexpr evaluation

serge-sans-paille updated this revision to Diff 443276. serge-sans-paille added a comment. + release note + take review into account Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128119/new/ https://reviews.llvm.org/D128119 Files: clang/docs/Rel

[PATCH] D111617: [RISCV] Lazily add RVV C intrinsics.

craig.topper added inline comments. Comment at: clang/test/Sema/riscv-bad-intrnisic-pragma.c:1 +// RUN: %clang_cc1 -triple riscv64 -target-feature +v %s -emit-llvm -o - \ +// RUN:2>&1 | FileCheck %s this test file name is misspelled

[PATCH] D111617: [RISCV] Lazily add RVV C intrinsics.

craig.topper added inline comments. Comment at: clang/include/clang/Support/RISCVVIntrinsicUtils.h:17 #include "llvm/ADT/StringRef.h" +#include "llvm/Support/raw_ostream.h" #include Do we need the header or is a forward declaration enough? Repository: rG L

[PATCH] D128119: [clang] Enforce instantiation of constexpr template functions during non-constexpr evaluation

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from some test changes, assuming that precommit CI comes back green. Comment at: clang/docs/ReleaseNotes.rst:184 initializer is not allowed this i

[PATCH] D129301: [clang-offload-bundler][NFC] Library-ize ClangOffloadBundler (1/4)

yaxunl added a comment. In D129301#3637664 , @jhuber6 wrote: > In D129301#3637642 , @jdoerfert > wrote: > >> Isn't the offload bundler on it's "way out" (=replaced and then deleted >> soon)? > > HIP still uses i

[PATCH] D129301: [clang-offload-bundler][NFC] Library-ize ClangOffloadBundler (1/4)

yaxunl added a comment. In D129301#3637641 , @lamb-j wrote: > @yaxunl Are you recommending I combine all 4 patches down into 1 patch? Or > combine a subset of patches? I recommend combining all patches as one. Repository: rG LLVM Github Monorepo CH

[PATCH] D129383: [LinkerWrapper] Fix use of string savers and correctly pass bitcode libraries

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, ye-luo. Herald added a project: All. jhuber6 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch removes some uses of string savers that are no-longer needed. We also

[PATCH] D129301: [clang-offload-bundler][NFC] Library-ize ClangOffloadBundler (1/4)

jhuber6 added a comment. In D129301#3639318 , @yaxunl wrote: > I think before the new binary format supports Windows and -fno-gpu-rdc and > HIP runtime support the new binary format, we cannot deprecate > clang-offload-bundler. I expect that would take

[PATCH] D129384: [objcxx] Fix `std::addressof` for `id`.

zoecarver created this revision. Herald added a project: All. zoecarver requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D129384 Files: clang/lib/Sema/SemaChecking.cpp clan

[PATCH] D128830: [Pipelines] Introduce DAE after ArgumentPromotion

aeubanks added a comment. moving DAE after the function simplification pipeline makes sense In D128830#3622736 , @psamolysov wrote: > In D128830#3622467 , @fhahn wrote: > >> Do we need to retain the run of `Dead

[clang] bc2a6de - [C++20][Modules] Allow for redeclarations in partitions.

Author: Iain Sandoe Date: 2022-07-08T19:02:59+01:00 New Revision: bc2a6defc853553b3896cb853bb84fe663f6bfd0 URL: https://github.com/llvm/llvm-project/commit/bc2a6defc853553b3896cb853bb84fe663f6bfd0 DIFF: https://github.com/llvm/llvm-project/commit/bc2a6defc853553b3896cb853bb84fe663f6bfd0.diff L

[PATCH] D127624: [C++20][Modules] Allow for redeclarations in partitions.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGbc2a6defc853: [C++20][Modules] Allow for redeclarations in partitions. (authored by iains). Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[clang] eb1ffd8 - Update references to Discourse instead of the mailing lists.

Author: tlattner Date: 2022-07-08T11:16:47-07:00 New Revision: eb1ffd817c3ce5120c3f9d4152de65954314a8d5 URL: https://github.com/llvm/llvm-project/commit/eb1ffd817c3ce5120c3f9d4152de65954314a8d5 DIFF: https://github.com/llvm/llvm-project/commit/eb1ffd817c3ce5120c3f9d4152de65954314a8d5.diff LOG:

[PATCH] D128766: Update references to Discourse instead of the mailing lists.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGeb1ffd817c3c: Update references to Discourse instead of the mailing lists. (authored by tonic). Changed prior to commit: https://reviews.llvm.org/

[clang-tools-extra] ea61750 - [NFC] Refactor llvm::zlib namespace

Author: Cole Kissane Date: 2022-07-08T11:19:07-07:00 New Revision: ea61750c35a11140e9245bd9cbeb383c37f6e031 URL: https://github.com/llvm/llvm-project/commit/ea61750c35a11140e9245bd9cbeb383c37f6e031 DIFF: https://github.com/llvm/llvm-project/commit/ea61750c35a11140e9245bd9cbeb383c37f6e031.diff

[clang] ea61750 - [NFC] Refactor llvm::zlib namespace

Author: Cole Kissane Date: 2022-07-08T11:19:07-07:00 New Revision: ea61750c35a11140e9245bd9cbeb383c37f6e031 URL: https://github.com/llvm/llvm-project/commit/ea61750c35a11140e9245bd9cbeb383c37f6e031 DIFF: https://github.com/llvm/llvm-project/commit/ea61750c35a11140e9245bd9cbeb383c37f6e031.diff

[PATCH] D128953: [NFC] Refactor llvm::zlib namespace

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGea61750c35a1: [NFC] Refactor llvm::zlib namespace (authored by ckissane). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:/

[PATCH] D128754: [llvm] Remove unused and redundant crc32 funcction from llvm::compression::zlib namespace

This revision was automatically updated to reflect the committed changes. Closed by commit rG96063bfa9088: [llvm] Remove unused and redundant crc32 funcction from llvm::compression::zlib… (authored by ckissane). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[clang] 22c7a6d - [objcxx] Fix `std::addressof` for `id`.

Author: zoecarver Date: 2022-07-08T11:29:30-07:00 New Revision: 22c7a6ec6d62e627ca66b886b60ba1ce1e7c URL: https://github.com/llvm/llvm-project/commit/22c7a6ec6d62e627ca66b886b60ba1ce1e7c DIFF: https://github.com/llvm/llvm-project/commit/22c7a6ec6d62e627ca66b886b60ba1ce1e7c.diff LOG

[PATCH] D129384: [objcxx] Fix `std::addressof` for `id`.

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG22c7a6ec: [objcxx] Fix `std::addressof` for `id`. (authored by zoecarver). Repository: rG LLVM Github Monorepo CHA

[clang] 7ecec30 - [Clang][Docs] Update the clang-linker-wrapper documentation.

Author: Joseph Huber Date: 2022-07-08T14:30:07-04:00 New Revision: 7ecec30e43987f4851130fc08423ab23fec234a4 URL: https://github.com/llvm/llvm-project/commit/7ecec30e43987f4851130fc08423ab23fec234a4 DIFF: https://github.com/llvm/llvm-project/commit/7ecec30e43987f4851130fc08423ab23fec234a4.diff

[PATCH] D102107: [OpenMP] Codegen aggregate for outlined function captures

dhruvachak added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntimeGPU.cpp:3541 .getPointerType(CGF.getContext().getPointerType( CGF.getContext().VoidPtrTy)) .castAs()); Th

[PATCH] D128465: [llvm] cmake config groundwork to have ZSTD in LLVM

ckissane updated this revision to Diff 443308. ckissane added a comment. - Merge remote-tracking branch 'origin/main' into ckissane.add-zstd.0-cmake - added have_zstd to compiler-rt/test/lit.common.cfg.py, clang-tools-extra/clangd/test/lit.cfg.py and several lit.site.cfg.py.in files Repository:

[PATCH] D128465: [llvm] cmake config groundwork to have ZSTD in LLVM

ckissane marked 2 inline comments as done. ckissane added a comment. marked fixed comments as done Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128465/new/ https://reviews.llvm.org/D128465 ___ cfe-commi

[PATCH] D128465: [llvm] cmake config groundwork to have ZSTD in LLVM

ckissane updated this revision to Diff 443310. ckissane added a comment. - Merge remote-tracking branch 'origin/main' into ckissane.add-zstd.0-cmake Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128465/new/ https://reviews.llvm.org/D128465 Files:

[PATCH] D128550: [OpenMP] Change OpenMP code generation for target region entries

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1fff116645b3: [OpenMP] Change OpenMP code generation for target region entries (authored by jhuber6). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D128816: [OpenMP] Add loop tripcount argument to kernel launch and remove push function

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5300263c70da: [OpenMP] Add loop tripcount argument to kernel launch and remove push function (authored by jhuber6). Repository: rG LLVM Github Mon

[PATCH] D128465: [llvm] cmake config groundwork to have ZSTD in LLVM

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf07caf20b9d3: [llvm] cmake config groundwork to have ZSTD in LLVM (authored by ckissane). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D102107: [OpenMP] Codegen aggregate for outlined function captures

dhruvachak added a comment. Is there an llvm/utils script to update clang tests that have RUN lines at the top? An example is clang/test/OpenMP/debug_threadprivate_copyin.c. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102107/new/ https://reviews

[PATCH] D102107: [OpenMP] Codegen aggregate for outlined function captures

jdoerfert added a comment. In D102107#3639551 , @dhruvachak wrote: > Is there an llvm/utils script to update clang tests that have RUN lines at > the top? An example is clang/test/OpenMP/debug_threadprivate_copyin.c. You can create the run lines with t

[PATCH] D129389: [clang][deps] Override dependency and serialized diag files for modules

benlangmuir created this revision. benlangmuir added reviewers: jansvoboda11, Bigcheese. Herald added a project: All. benlangmuir requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. When building modules, override secondary outputs (dependency

[PATCH] D102107: [OpenMP] Codegen aggregate for outlined function captures

dhruvachak added a comment. In D102107#3639556 , @jdoerfert wrote: > In D102107#3639551 , @dhruvachak > wrote: > >> Is there an llvm/utils script to update clang tests that have RUN lines at >> the top? An examp

[PATCH] D129393: [Clang] Fix the wrong features being derivec in the offload packager

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, tianshilei1992, ye-luo, tra. Herald added a project: All. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits, sstefan1, MaskRay. Herald added a project: clang. The offload packager embeds the features

[PATCH] D128927: [libc++] Always build c++experimental.a

mstorsjo added a comment. In D128927#3638973 , @ldionne wrote: > Thanks @mstorsjo! Regarding `_LIBCPP_EXPERIMENTAL_FUNC_VIS`, yes I think it > would make sense to use a different visibility macro for symbols that we know > are provided only as part of a

[PATCH] D102107: [OpenMP] Codegen aggregate for outlined function captures

jdoerfert added a comment. In D102107#3639615 , @dhruvachak wrote: > In D102107#3639556 , @jdoerfert > wrote: > >> In D102107#3639551 , @dhruvachak >> wrote: >> >>> Is

  1   2   >