[PATCH] D129016: [PowerPC] implemented @llvm.ppc.kill.canary to corrupt stack guard

pscoro updated this revision to Diff 442640. pscoro added a comment. trying to get patch to apply Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129016/new/ https://reviews.llvm.org/D129016 Files: clang/include/clang/Basic/BuiltinsPPC.def clang

[PATCH] D129198: [clang] Correct the macOS version that supports aligned allocation

ldionne accepted this revision as: libc++. ldionne added a comment. I looked at the CI failures and they look like flukes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129198/new/ https://reviews.llvm.org/D129198 _

[PATCH] D128059: [Clang] Add a warning on invalid UTF-8 in comments.

cor3ntin updated this revision to Diff 442642. cor3ntin added a comment. Fix the test of a newly landed commit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128059/new/ https://reviews.llvm.org/D128059 Files: clang/docs/ReleaseNotes.rst clang/

[PATCH] D129016: [PowerPC] implemented @llvm.ppc.kill.canary to corrupt stack guard

pscoro updated this revision to Diff 442643. pscoro added a comment. patch application Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129016/new/ https://reviews.llvm.org/D129016 Files: clang/include/clang/Basic/BuiltinsPPC.def clang/lib/Basic/

[PATCH] D129198: [clang] Correct the macOS version that supports aligned allocation

ahatanak accepted this revision. ahatanak added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129198/new/ https://reviews.llvm.org/D129198 ___

[PATCH] D119296: KCFI sanitizer

samitolvanen added a comment. In D119296#3625796 , @MaskRay wrote: >> It uses LLVM prefix data to store a type identifier for each function and >> injects verification code before indirect calls. > > Is "prefix data" stale now? Yes, I forgot to update t

[clang] 548f3f9 - Update the status & add tests for some more C99 DRs

Author: Aaron Ballman Date: 2022-07-06T14:34:36-04:00 New Revision: 548f3f906148c821cd30d61921b6aa2e2c866f1c URL: https://github.com/llvm/llvm-project/commit/548f3f906148c821cd30d61921b6aa2e2c866f1c DIFF: https://github.com/llvm/llvm-project/commit/548f3f906148c821cd30d61921b6aa2e2c866f1c.diff

[clang] 96515df - [PowerPC] Fix the check for scalar MASS conversion

Author: Masoud Ataei Date: 2022-07-06T11:44:00-07:00 New Revision: 96515df816ebc3af2a632669a26374745e98b0c5 URL: https://github.com/llvm/llvm-project/commit/96515df816ebc3af2a632669a26374745e98b0c5 DIFF: https://github.com/llvm/llvm-project/commit/96515df816ebc3af2a632669a26374745e98b0c5.diff

[PATCH] D118409: [OpenMPIRBuilder] Remove ContinuationBB argument from Body callback.

jdoerfert added inline comments. Herald added subscribers: anlunx, bzcheeseman. Comment at: llvm/include/llvm/Frontend/OpenMP/OMPIRBuilder.h:70 +BasicBlock *splitBBWithSuffix(IRBuilderBase &Builder, bool CreateBranch, + llvm::Twine Suffix = ".split");

[PATCH] D129220: [clang] Cleanup ASTContext before output files in crash recovery for modules

benlangmuir created this revision. benlangmuir added reviewers: steven_wu, akyrtzi. Herald added a project: All. benlangmuir requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. When we recover from a crash in a module compilation thread, we nee

[PATCH] D129149: [OMPIRBuilder] Add support for simdlen clause

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LG, let's update the test script first though. See below. Comment at: clang/test/OpenMP/irbuilder_simdlen.cpp:1 +// RUN: %clang_cc1 -no-opaque-pointers -fopenmp-enable-

[clang] 4722b5d - [clang] Correct the macOS version that supports aligned allocation

Author: Louis Dionne Date: 2022-07-06T15:04:53-04:00 New Revision: 4722b5d1330a1104a0aa256804b9537c4d2c39d4 URL: https://github.com/llvm/llvm-project/commit/4722b5d1330a1104a0aa256804b9537c4d2c39d4 DIFF: https://github.com/llvm/llvm-project/commit/4722b5d1330a1104a0aa256804b9537c4d2c39d4.diff

[PATCH] D129198: [clang] Correct the macOS version that supports aligned allocation

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4722b5d1330a: [clang] Correct the macOS version that supports aligned allocation (authored by ldionne). Repository: rG LLVM Github Monorepo CHANG

[PATCH] D129202: [clang] Add a fixit for warn-self-assign if LHS is a field with the same name as parameter on RHS

aaron.ballman added a comment. Thank you for working on this, I think it's a nice new diagnostic. You should add a release note to describe it. One question I have is about how chatty this is over real world code, especially older code bases. There used to be two prevailing ways to silence the

[PATCH] D129149: [OMPIRBuilder] Add support for simdlen clause

Meinersbur added a comment. Why not have `simdlen` an argument to `applySimd` (which can be null if not used)? In this case it happens to be just adding some metadata, but for others such as `unrollLoopPartial` it does not make sense to have the unroll factor set by a different method. It would

[clang] 4174f0c - [Clang] Add a warning on invalid UTF-8 in comments.

Author: Corentin Jabot Date: 2022-07-06T21:18:29+02:00 New Revision: 4174f0ca618b467571b43cff12cbe4c4239670f8 URL: https://github.com/llvm/llvm-project/commit/4174f0ca618b467571b43cff12cbe4c4239670f8 DIFF: https://github.com/llvm/llvm-project/commit/4174f0ca618b467571b43cff12cbe4c4239670f8.diff

[PATCH] D128059: [Clang] Add a warning on invalid UTF-8 in comments.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4174f0ca618b: [Clang] Add a warning on invalid UTF-8 in comments. (authored by cor3ntin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D122255: Meta directive runtime support

abidmalikwaterloo updated this revision to Diff 442661. abidmalikwaterloo marked 14 inline comments as done. abidmalikwaterloo added a comment. Updated and clean the code based on the comments from the reviewer! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[PATCH] D129222: [pseudo] Implement a guard to determine function declarator.

hokein created this revision. hokein added a reviewer: sammccall. Herald added a project: All. hokein requested review of this revision. Herald added a subscriber: alextsao1999. Herald added a project: clang-tools-extra. - emit an enum type to identify each grammar rule (in lhs$$rhs$rhs$ form); -

[PATCH] D128653: [PowerPC] Fix the check for scalar MASS conversion

dyung added a comment. Hi @masoud.ataei, the test you added in this commit is failing on the PS4 bot, can you take a look? https://lab.llvm.org/buildbot/#/builders/139/builds/24469 clang (LLVM option parsing): Unknown command line argument '-enable-ppc-gen-scalar-mass'. Try: 'clang (LLVM op

[PATCH] D129149: [OMPIRBuilder] Add support for simdlen clause

jdoerfert added a comment. In D129149#3633627 , @Meinersbur wrote: > Why not have `simdlen` an argument to `applySimd` (which can be null if not > used)? In this case it happens to be just adding some metadata, but for > others such as `unrollLoopParti

[PATCH] D128927: [libc++] Always build c++experimental.a

ldionne updated this revision to Diff 442667. ldionne added a comment. Rebase onto main and temporarily disable experimental tests on Windows Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128927/new/ https://reviews.llvm.org/D128927 Files: clang

[PATCH] D102107: [OpenMP] Codegen aggregate for outlined function captures

dhruvachak added a comment. I rebased and resolved conflicts just now and got the compiler built. I did not update the tests, hence not updating this review. I see the following outstanding issues: (1) make check-libomptarget produces a bunch of failures with the following compile-time asserti

[clang] d34315e - Removing this test temporarily beacuse of a failure in x86_64

Author: Masoud Ataei Date: 2022-07-06T12:41:13-07:00 New Revision: d34315e71adf2d460770a7d1f8b916c4ff4f9ccd URL: https://github.com/llvm/llvm-project/commit/d34315e71adf2d460770a7d1f8b916c4ff4f9ccd DIFF: https://github.com/llvm/llvm-project/commit/d34315e71adf2d460770a7d1f8b916c4ff4f9ccd.diff

[PATCH] D128653: [PowerPC] Fix the check for scalar MASS conversion

masoud.ataei added a comment. Just took it down temporarily. -- Looking at it... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128653/new/ https://reviews.llvm.org/D128653 ___ cfe-commits mailing list cf

[PATCH] D128653: [PowerPC] Fix the check for scalar MASS conversion

lenary added a comment. You likely need `// REQUIRES: powerpc-registered-target` in the top of the test, as `-enable-ppc-gen-scalar-mass` is only present if the PowerPC target has been compiled into LLVM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D102107: [OpenMP] Codegen aggregate for outlined function captures

jdoerfert added a comment. Also, make sure to remove all deviceRTL files and probably reset the autogenerated tests to upstream (and re-generate) before you merge (or reupload). In D102107#3633678 , @dhruvachak wrote: > I rebased and resolved conflict

[PATCH] D128653: [PowerPC] Fix the check for scalar MASS conversion

masoud.ataei added a comment. In D128653#3633704 , @lenary wrote: > You likely need `// REQUIRES: powerpc-registered-target` in the top of the > test, as `-enable-ppc-gen-scalar-mass` is only present if the PowerPC target > has been compiled into LLVM.

[clang] fe06b9f - Bringing back the test with the required target related to commit 96515df816ebc3af2a632669a26374745e98b0c5

Author: Masoud Ataei Date: 2022-07-06T13:04:17-07:00 New Revision: fe06b9f02ccddc2843505927fbd38a712d06822d URL: https://github.com/llvm/llvm-project/commit/fe06b9f02ccddc2843505927fbd38a712d06822d DIFF: https://github.com/llvm/llvm-project/commit/fe06b9f02ccddc2843505927fbd38a712d06822d.diff

[PATCH] D129223: [Clang] Fix invalid utf-8 detection

cor3ntin created this revision. Herald added a subscriber: hiraditya. Herald added a project: All. cor3ntin requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. The length of valid codepoints was incorrectly calculated which wa

[clang] bf45e27 - [Clang] Fix invalid utf-8 detection

Author: Corentin Jabot Date: 2022-07-06T22:20:04+02:00 New Revision: bf45e27a676d87944f1f13d5f0d0f39935fc4010 URL: https://github.com/llvm/llvm-project/commit/bf45e27a676d87944f1f13d5f0d0f39935fc4010 DIFF: https://github.com/llvm/llvm-project/commit/bf45e27a676d87944f1f13d5f0d0f39935fc4010.diff

[PATCH] D129223: [Clang] Fix invalid utf-8 detection

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGbf45e27a676d: [Clang] Fix invalid utf-8 detection (authored by cor

[clang] a60360f - [clang][NFC] Re-generate CommandLineReference.rst

Author: Louis Dionne Date: 2022-07-06T16:21:14-04:00 New Revision: a60360f99a6c04f88d223628ed8c6fade195b86b URL: https://github.com/llvm/llvm-project/commit/a60360f99a6c04f88d223628ed8c6fade195b86b DIFF: https://github.com/llvm/llvm-project/commit/a60360f99a6c04f88d223628ed8c6fade195b86b.diff

[PATCH] D128059: [Clang] Add a warning on invalid UTF-8 in comments.

cor3ntin added a comment. The bots found a further issue which i committed a fix for directly https://reviews.llvm.org/D129223 - I should have caught that sooner Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128059/new/ https://reviews.llvm.org/D1

[PATCH] D129223: [Clang] Fix invalid utf-8 detection

thakis added a comment. This breaks check-clang: http://45.33.8.238/linux/80462/step_7.txt Please take a look and revert for now if it takes a while to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129223/new/ https://reviews.llvm.org/D129223

[clang-tools-extra] a638648 - [clangd] add inlay hints for std::forward-ed parameter packs

Author: Tobias Ribizel Date: 2022-07-06T22:23:18+02:00 New Revision: a638648fef76146634c2199ce7b90c4bc6bfed01 URL: https://github.com/llvm/llvm-project/commit/a638648fef76146634c2199ce7b90c4bc6bfed01 DIFF: https://github.com/llvm/llvm-project/commit/a638648fef76146634c2199ce7b90c4bc6bfed01.diff

[PATCH] D124690: [clangd] add inlay hints for std::forward-ed parameter packs

This revision was automatically updated to reflect the committed changes. Closed by commit rGa638648fef76: [clangd] add inlay hints for std::forward-ed parameter packs (authored by upsj). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124690/new/ htt

[PATCH] D125916: [PowerPC] Defined and lowered llvm.ppc.kill.canary intrinsic

pscoro updated this revision to Diff 442677. pscoro added a comment. patch fix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125916/new/ https://reviews.llvm.org/D125916 Files: clang/include/clang/Basic/BuiltinsPPC.def clang/lib/Basic/Targets/

[PATCH] D129016: [PowerPC] implemented @llvm.ppc.kill.canary to corrupt stack guard

pscoro updated this revision to Diff 442678. pscoro added a comment. patch fix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129016/new/ https://reviews.llvm.org/D129016 Files: clang/include/clang/Basic/BuiltinsPPC.def clang/lib/Basic/Targets/

[PATCH] D129226: [clang/mac] Make -mmacos-version-min the canonical spelling over -mmacosx-version-min

thakis created this revision. thakis added reviewers: arphaman, dexonsmith. Herald added a project: All. thakis requested review of this revision. Herald added a subscriber: MaskRay. This was promised 5 years ago in https://reviews.llvm.org/D32796, let's do it. Both flags are still accepted. No b

[PATCH] D129170: [Sema] Add deprecation warnings for some compiler provided __has_* type traits

royjacobson updated this revision to Diff 442680. royjacobson added a comment. Address CR comments. Make the switch case slightly more concise. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129170/new/ https://reviews.llvm.org/D129170 Files: cla

[PATCH] D128652: [PowerPC] Finished kill_canary implementation and debugging

pscoro updated this revision to Diff 442682. pscoro added a comment. patch fix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128652/new/ https://reviews.llvm.org/D128652 Files: clang/include/clang/Basic/BuiltinsPPC.def clang/lib/Basic/Targets/

[PATCH] D129170: [Sema] Add deprecation warnings for some compiler provided __has_* type traits

royjacobson marked 9 inline comments as done and 2 inline comments as done. royjacobson added inline comments. Comment at: clang/include/clang/Basic/DiagnosticGroups.td:190 : DiagGroup<"deprecated-dynamic-exception-spec">; +def DeprecatedHasBuiltins : DiagGroup<"deprecated-h

[clang] e9fe20d - Revert "[Clang] Add a warning on invalid UTF-8 in comments."

Author: Nico Weber Date: 2022-07-06T22:51:52+02:00 New Revision: e9fe20dab39edb911afacdb6ed9ec2c7499a59cf URL: https://github.com/llvm/llvm-project/commit/e9fe20dab39edb911afacdb6ed9ec2c7499a59cf DIFF: https://github.com/llvm/llvm-project/commit/e9fe20dab39edb911afacdb6ed9ec2c7499a59cf.diff LO

[PATCH] D129223: [Clang] Fix invalid utf-8 detection

thakis added a comment. Reverted in e9fe20dab39edb911afacdb6ed9ec2c7499a59cf for now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129223/new/ https://reviews.llvm.org/D129223 ___ cfe-commits mailing li

[PATCH] D129170: [Sema] Add deprecation warnings for some compiler provided __has_* type traits

erichkeane added inline comments. Comment at: clang/lib/Sema/SemaExprCXX.cpp:5400-5401 +SourceLocation KWLoc) { + if (!S.getLangOpts().CPlusPlus11) +return; + royjacobson wrote: > aaron.ballman wrote: > > I think w

[PATCH] D129016: [PowerPC] implemented @llvm.ppc.kill.canary to corrupt stack guard

pscoro added inline comments. Comment at: llvm/include/llvm/Debuginfod/Debuginfod.h:34 #include +#include #include Im really unsure how this change got in here, this is not added by me and on a freshly created branch and pull Any ideas? I'll look into this

[PATCH] D129223: [Clang] Fix invalid utf-8 detection

thakis added a comment. In D129223#3633754 , @thakis wrote: > This breaks check-clang: http://45.33.8.238/linux/80462/step_7.txt (Also on all other bots, e.g. https://lab.llvm.org/buildbot/#/builders/171/builds/17060 – did you run tests locally before

[PATCH] D129223: [Clang] Fix invalid utf-8 detection

cor3ntin added a comment. In D129223#3633849 , @thakis wrote: > Reverted in e9fe20dab39edb911afacdb6ed9ec2c7499a59cf > for now. Thanks, I was going to do that when I noticed you alrea

[PATCH] D126864: [clang] Introduce -fstrict-flex-arrays= for stricter handling of flexible arrays

serge-sans-paille updated this revision to Diff 442686. serge-sans-paille edited the summary of this revision. serge-sans-paille added a comment. Take into account @jyknight review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126864/new/ https://

[PATCH] D111081: [clang] [MinGW] Fix paths on Gentoo

mstorsjo accepted this revision. mstorsjo added a comment. This revision is now accepted and ready to land. LGTM, thanks, and sorry for losing track of it earlier. Do you need someone to push the patch for you? In that case, can you provide your preferred git author line for the patch? CHANGES

[PATCH] D123319: Change how we handle auto return types for lambda operator() to be consistent with gcc

dblaikie added a comment. @aprantl ^ ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123319/new/ https://reviews.llvm.org/D123319 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llv

[PATCH] D127189: [clang][AIX] Add option to control quadword lock free atomics ABI on AIX

lkail added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127189/new/ https://reviews.llvm.org/D127189 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-

[PATCH] D128569: Start support for HLSL `RWBuffer`

beanz updated this revision to Diff 442690. beanz added a comment. Updating with some minor tweaks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128569/new/ https://reviews.llvm.org/D128569 Files: clang/include/clang/Sema/HLSLExternalSemaSource

[PATCH] D126864: [clang] Introduce -fstrict-flex-arrays= for stricter handling of flexible arrays

serge-sans-paille updated this revision to Diff 442692. serge-sans-paille edited the summary of this revision. serge-sans-paille added a comment. Remove debug code CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126864/new/ https://reviews.llvm.org/D126864 Files: clang/docs/ClangComman

[PATCH] D128921: [Sema] Merge C++20 concept definitions from different modules in same TU

rsmith added inline comments. Comment at: clang/lib/Sema/SemaTemplate.cpp:8694-8696 + Diag(NewDecl->getLocation(), isa(Old) + ? diag::err_redefinition + : diag::err_redefinition_different_kind)

[PATCH] D129231: [Builtins] Do not claim all libfuncs are readnone with trapping math.

fhahn created this revision. fhahn added reviewers: kpn, efriedma, scanon, john.brawn, sepavloff. Herald added a project: All. fhahn requested review of this revision. Herald added a project: clang. At the moment, Clang only considers errno when deciding if a builtin is const. This ignores the fac

[PATCH] D127287: clang: Introduce -fexperimental-max-bitint-width

mgehre-amd closed this revision. mgehre-amd added a comment. Merged Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127287/new/ https://reviews.llvm.org/D127287 ___ cfe-commits mailing list cfe-commits@lis

[PATCH] D128750: [c++20] Implement P2113R0: Changes to the Partial Ordering of Constrained Functions

ychen added inline comments. Comment at: clang/lib/Sema/SemaTemplateDeduction.cpp:5119 - while (--NumParams > 0) { -if (Function->getParamDecl(NumParams - 1)->isParameterPack()) - return false; royjacobson wrote: > Curious, why was this removed? I think

[PATCH] D128059: [Clang] Add a warning on invalid UTF-8 in comments.

cor3ntin updated this revision to Diff 442702. cor3ntin added a comment. Deploying that turned out to reveal a few critical issues - `getUTF8SequenceSize` never reported a non-zero length for valid UTF-8 sequences. - In *some* circumstances (depending on the size of comment), Unicode codepoint

[PATCH] D128059: [Clang] Add a warning on invalid UTF-8 in comments.

cor3ntin added a comment. @aaron.ballman Ok, this didn't turn out great, and given the changes + the fact it was completely broken (twice!), I'd love if you could take a look at it again. Thanks :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128

[PATCH] D129008: [Clang][OpenMP] Fix the issue that globalization doesn't work with byval struct function argument

jdoerfert added a comment. cleanup/destructor test missing. @ABataev WDYT? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129008/new/ https://reviews.llvm.org/D129008 ___ cfe-commits mailing list cfe-com

[PATCH] D125693: [DebugInfo] Support types, imports and static locals declared in a lexical block (3/5)

krisb added inline comments. Comment at: llvm/test/Instrumentation/InstrProfiling/debug-info-correlate.ll:23 call void @llvm.instrprof.increment(i8* getelementptr inbounds ([3 x i8], [3 x i8]* @__profn_foo, i32 0, i32 0), i64 12345678, i32 2, i32 0) - ret void + ret void, !

[PATCH] D129220: [clang] Cleanup ASTContext before output files in crash recovery for modules

benlangmuir updated this revision to Diff 442706. benlangmuir added a comment. Updated per out-of-band feedback from @steven_wu : - Added an assert to `clearOutputFiles` that the `ASTConsumer` is removed. Normally this would be done in `FrontendAction::EndSourceFile`. This should help avoid re

[PATCH] D125693: [DebugInfo] Support types, imports and static locals declared in a lexical block (3/5)

ellis added inline comments. Comment at: llvm/test/Instrumentation/InstrProfiling/debug-info-correlate.ll:23 call void @llvm.instrprof.increment(i8* getelementptr inbounds ([3 x i8], [3 x i8]* @__profn_foo, i32 0, i32 0), i64 12345678, i32 2, i32 0) - ret void + ret void, !

[PATCH] D128745: [Sema] fix trailing parameter pack handling for function template partial ordering

ychen added a comment. In D128745#3632850 , @aaron.ballman wrote: > Thank you for working on this! Can you please add more details to the patch > summary about the changes? Thanks for taking a look. This was intended to correctly implement https://ee

[PATCH] D128745: [Sema] fix trailing parameter pack handling for function template partial ordering

ychen added inline comments. Comment at: clang/lib/Sema/SemaTemplateDeduction.cpp:5184 - // FIXME: This mimics what GCC implements, but doesn't match up with the - // proposed resolution for core issue 692. This area needs to be sorted out, aaron.ballman wrot

[PATCH] D128750: [c++20] Implement P2113R0: Changes to the Partial Ordering of Constrained Functions

ychen added a comment. In D128750#3627085 , @royjacobson wrote: > Thanks for working on this! I like the approach, but two comments: Thanks for the review. > I would like more tests for the different forms of template argument > deduction. Some sugges

[PATCH] D129149: [OMPIRBuilder] Add support for simdlen clause

psoni2628 updated this revision to Diff 442715. psoni2628 marked 4 inline comments as done. psoni2628 added a comment. Herald added subscribers: bzcheeseman, awarzynski, sdasgup3, wenzhicui, wrengr, dcaballe, cota, teijeong, rdzhabarov, tatianashp, msifontes, jurahul, Kayjukh, grosul1, Joonsoo, s

[PATCH] D78038: [clangd] WIP: fix several bugs relating to include insertion

nridge added a comment. Herald added projects: LLVM, clang-tools-extra, All. Herald added a subscriber: llvm-commits. @sammccall should we get this patch landed? The issue of #ifndef-guarded header files that include each other recursively is still tripping up some users. Repository: rG LLVM

[PATCH] D127643: [Static Analyzer] Structured bindings to data members

NoQ added a comment. In D127643#3595731 , @steakhal wrote: > I missed this commit because it was not tagged by "[analyzer]". > What is the community preference about tagging CSA commits? I think [analyzer] is a good tag, no need to change anything. I als

[PATCH] D129138: [clang] [docs] Update the changes of C++20 Modules in clang15

ChuanqiXu updated this revision to Diff 442761. ChuanqiXu added a comment. Update cxx_status.html CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129138/new/ https://reviews.llvm.org/D129138 Files: clang/docs/ReleaseNotes.rst clang/www/cxx_status.html Index: clang/www/cxx_status.ht

[PATCH] D129138: [clang] [docs] Update the changes of C++20 Modules in clang15

ChuanqiXu marked an inline comment as done. ChuanqiXu added a comment. In D129138#3632128 , @iains wrote: > I would not expect to add all this information to the release notes, or any > of the phab links - just single lines to say that paper numbers are

[PATCH] D125095: [Clang][AIX] Add .ref in frontend for AIX XCOFF to support `-bcdtors:csect` linker option

tingwang updated this revision to Diff 442773. tingwang added a comment. Drop TLS related .ref for now Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125095/new/ https://reviews.llvm.org/D125095 Files: clang/lib/CodeGen/CGDecl.cpp clang/lib/Cod

[PATCH] D129100: [clangd] Support external throttler for preamble builds

vitalybuka added a comment. This looks flaky https://lab.llvm.org/buildbot/#/builders/5/builds/25929 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129100/new/ https://reviews.llvm.org/D129100 ___ cfe-com

[PATCH] D129174: [C++20][Modules] Invalidate internal-linkage functions in overload sets [P1815R2 part 1]

ChuanqiXu added inline comments. Comment at: clang/lib/Sema/SemaOverload.cpp:6406 +if (Function->getFormalLinkage() <= Linkage::InternalLinkage && +getLangOpts().CPlusPlus20 && MF != getCurrentModule()) { + Candidate.Viable = false; iains wrote:

[PATCH] D128921: [Sema] Merge C++20 concept definitions from different modules in same TU

ChuanqiXu added inline comments. Comment at: clang/lib/Sema/SemaTemplate.cpp:8679 + Previous.isSingleResult() ? Previous.getAsSingle() : nullptr; + if (PrevDef && !hasVisibleDefinition(PrevDef) && + Context.isSameEntity(NewDecl, PrevDef)) { rsmith wro

[clang] 0826a56 - [NFC] make ASTContext:isSame* methods const

Author: Chuanqi Xu Date: 2022-07-07T13:34:15+08:00 New Revision: 0826a5617885bef2559c8213ec52685786ff0506 URL: https://github.com/llvm/llvm-project/commit/0826a5617885bef2559c8213ec52685786ff0506 DIFF: https://github.com/llvm/llvm-project/commit/0826a5617885bef2559c8213ec52685786ff0506.diff LO

[clang-tools-extra] 011d2bf - [clang-tidy] Fix confusable identifier interaction with unavailable class def

Author: serge-sans-paille Date: 2022-07-07T08:02:29+02:00 New Revision: 011d2bf86487520c3515f16e0b1d32994bf2b48f URL: https://github.com/llvm/llvm-project/commit/011d2bf86487520c3515f16e0b1d32994bf2b48f DIFF: https://github.com/llvm/llvm-project/commit/011d2bf86487520c3515f16e0b1d32994bf2b48f.d

[PATCH] D129250: [clang-repl][NFC] Split weak symbol test to a new test

junaire created this revision. junaire added a reviewer: v.g.vassilev. Herald added a project: All. junaire requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Windows has some issues when we try to use `__attribute__((weak))` in JIT, so we dis

[PATCH] D129202: [clang] Add a fixit for warn-self-assign if LHS is a field with the same name as parameter on RHS

njames93 marked 3 inline comments as done. njames93 added a comment. In D129202#3633618 , @aaron.ballman wrote: > Thank you for working on this, I think it's a nice new diagnostic. You should > add a release note to describe it. One question I have is a

[PATCH] D129202: [clang] Add a fixit for warn-self-assign if LHS is a field with the same name as parameter on RHS

njames93 updated this revision to Diff 442788. njames93 marked an inline comment as done. njames93 added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129202/new/ https://reviews.llvm.org/D129202 Files: clang/docs/Re

[PATCH] D128974: [AST] [Modules] Handle full cases of DefaultArgStorage::setInherited

ChuanqiXu updated this revision to Diff 442791. ChuanqiXu added a comment. Rebase CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128974/new/ https://reviews.llvm.org/D128974 Files: clang/include/clang/AST/ASTContext.h clang/include/clang/AST/DeclTemplate.h clang/lib/AST/ASTContext

[PATCH] D129068: [AST] Profiling on constraint expression instead of arguments for TypeConstraint in ASTContext::isSameTemplateParameter

ChuanqiXu updated this revision to Diff 442792. ChuanqiXu added a comment. Minor changes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129068/new/ https://reviews.llvm.org/D129068 Files: clang/lib/AST/ASTContext.cpp clang/test/Modules/concept.cppm Index: clang/test/Modules/conce

[PATCH] D128974: [AST] [Modules] Handle full cases of DefaultArgStorage::setInherited

ChuanqiXu updated this revision to Diff 442795. ChuanqiXu added a comment. Update tests. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128974/new/ https://reviews.llvm.org/D128974 Files: clang/include/clang/AST/ASTContext.h clang/include/clang/AST/DeclTemplate.h clang/lib/AST/AST

<    1   2