[PATCH] D127125: [clangd] Improve ObjC protocol suggestions from the index

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks, lgtm! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127125/new/ https://reviews.llvm.org/D127125 __

[PATCH] D126291: [flang][Driver] Update link job on windows

rovka added inline comments. Comment at: flang/test/Driver/linker-flags.f90:51 +! MSVC-NOT: libcmt +! MSVC-NOT: oldnames +! MSVC-SAME: "[[object_file]]" awarzynski wrote: > rovka wrote: > > awarzynski wrote: > > > rovka wrote: > > > > mmuetzel wrote: > > > > > Li

[clang] 665da18 - [Clang] Add the `annotate_type` attribute

Author: Martin Boehme Date: 2022-06-15T09:47:28+02:00 New Revision: 665da187ccf338bad1560e8a960e8feaebb5c9d9 URL: https://github.com/llvm/llvm-project/commit/665da187ccf338bad1560e8a960e8feaebb5c9d9 DIFF: https://github.com/llvm/llvm-project/commit/665da187ccf338bad1560e8a960e8feaebb5c9d9.diff

[PATCH] D111548: [Clang] Add the `annotate_type` attribute

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. mboehme marked an inline comment as done. Closed by commit rG665da187ccf3: [Clang] Add the `annotate_type` attribute (authored by mboehme). Repository: rG LLVM Githu

[PATCH] D127742: [analyzer][NFC] Prefer using isa<> instead getAs<> in conditions

martong accepted this revision. martong added a comment. This revision is now accepted and ready to land. In D127742#3582236 , @steakhal wrote: > In D127742#3581874 , @martong wrote: > >> Why not replace all `getA

[PATCH] D127306: [analyzer] Treat system globals as mutable if they are not const

martong accepted this revision. martong added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127306/new/ https://reviews.llvm.org/D127306 _

[PATCH] D127763: [analyzer] Relax constraints on const qualified regions

martong accepted this revision. martong added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127763/new/ https://reviews.llvm.org/D127763

[PATCH] D125291: Introduce @llvm.threadlocal.address intrinsic to access TLS variable

ChuanqiXu added a comment. In D125291#3581064 , @nikic wrote: > In D125291#3548671 , @jyknight > wrote: > >> Anyhow -- I think the prototype I'm fiddling with is also along the path to >> the ideal long-term sta

[PATCH] D127799: [StaticAnalyzer] Remove dead code (DO NOT COMMIT)

martong added a comment. Thanks! What was your method to discover the unused code? Did you use an automated tool? Comment at: clang/lib/StaticAnalyzer/Checkers/ArrayBoundCheckerV2.cpp:66 - void dump() const; void dumpToStream(raw_ostream &os) const; We s

[PATCH] D111521: [DebugInfo] Mark OpenMP generated functions as artificial

alok updated this revision to Diff 437064. alok added a comment. Herald added a project: All. Re-based and updated to include one negative testcase. I could not find a test for VarDecl with DynamicInitKind::NoStub. There are constructors for other DynamicInitKind but not for NoStub. Please help m

[PATCH] D127832: [clangd] Always desugar type aliases in hover

kadircet created this revision. kadircet added a reviewer: hokein. Herald added subscribers: jeroen.dobbelaere, usaxena95, arphaman. Herald added a project: All. kadircet requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-

[PATCH] D127833: [clangd] Enable AKA type printing by default

kadircet created this revision. kadircet added a reviewer: hokein. Herald added subscribers: usaxena95, arphaman. Herald added a project: All. kadircet requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. This

[PATCH] D127629: [clang] Use correct visibility parameters when following a Using declaration

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks, lgtm! do you have commit access or should i land this for you? if i should, can you provide an email address for attribution of the commit Repository: rG LLVM Github Monorepo

[PATCH] D124690: [clangd] add inlay hints for std::forward-ed parameter packs

nridge added a comment. Finished looking through the patch; I found it nicely organized and fairly easy to understand (as easy as code involving the analysis of C++ variadic templates can be, anyways :-D)! Comment at: clang-tools-extra/clangd/AST.cpp:682 + if (const auto

[PATCH] D126956: [tbaa] Handle base classes in struct tbaa

brunodf added a comment. Anyone? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126956/new/ https://reviews.llvm.org/D126956 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/

[PATCH] D126864: [clang] Introduce -fstrict-flex-arrays for stricter handling of flexible arrays

serge-sans-paille added a comment. https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101836 does toward `-fstrict-flex-arrays=` with - `n=0` ⇒ `-fno-strict-flex-arrays`, current state (the default) - `n=1` ⇒ only consider `[ 0]`, `[1}` and `[ ]` as flex array member - `n=2` ⇒ only consider `[ 0]` and

[PATCH] D126907: Deferred Concept Instantiation Implementation Take 2

ChuanqiXu added a comment. I finally found some time to look at the crash. Although I haven't get an idea, I found it crash at the following one too: template concept Constraint = true; template class completion_handler_async_result { public: template static void init

[PATCH] D127460: Rename GCCBuiltin into ClangBuiltin

RKSimon accepted this revision. RKSimon added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127460/new/ https://reviews.llvm.org/D127460 ___ cfe-commits mailing list cfe-commits@lists.llv

[PATCH] D127833: [clangd] Enable AKA type printing by default

This revision was automatically updated to reflect the committed changes. Closed by commit rGa67beef3acac: [clangd] Enable AKA type printing by default (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127833/new/ https://reviews

[clang-tools-extra] a67beef - [clangd] Enable AKA type printing by default

Author: Kadir Cetinkaya Date: 2022-06-15T10:43:17+02:00 New Revision: a67beef3acac4ab4fc009f492d5b3f510c48420b URL: https://github.com/llvm/llvm-project/commit/a67beef3acac4ab4fc009f492d5b3f510c48420b DIFF: https://github.com/llvm/llvm-project/commit/a67beef3acac4ab4fc009f492d5b3f510c48420b.dif

[PATCH] D127460: Rename GCCBuiltin into ClangBuiltin

RKSimon added a comment. I don't think this is really blocked on the libc team any more? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127460/new/ https://reviews.llvm.org/D127460 ___ cfe-commits mailing

[clang] 1784fe7 - [Clang] Fix signed-unsigned comparison warning that breaks the ppc64 build.

Author: Martin Boehme Date: 2022-06-15T10:53:14+02:00 New Revision: 1784fe7be782ce34bf4a06529a89f47d1ec0e6f4 URL: https://github.com/llvm/llvm-project/commit/1784fe7be782ce34bf4a06529a89f47d1ec0e6f4 DIFF: https://github.com/llvm/llvm-project/commit/1784fe7be782ce34bf4a06529a89f47d1ec0e6f4.diff

[clang] 4c2bccf - [Clang] Documentation-only: Add missing closing `>` in AttrDocs.td

Author: Martin Boehme Date: 2022-06-15T10:59:07+02:00 New Revision: 4c2bccfda3892ae13e97b6bfdbc99ec8cf5d095d URL: https://github.com/llvm/llvm-project/commit/4c2bccfda3892ae13e97b6bfdbc99ec8cf5d095d DIFF: https://github.com/llvm/llvm-project/commit/4c2bccfda3892ae13e97b6bfdbc99ec8cf5d095d.diff

[PATCH] D126956: [tbaa] Handle base classes in struct tbaa

jeroen.dobbelaere accepted this revision. jeroen.dobbelaere added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126956/new/ https://reviews.llvm.org/D126956 _

[PATCH] D127836: [analyzer][NFC] Remove dead code and modernize surroundings

steakhal created this revision. steakhal added reviewers: kazu, martong, xazax.hun, gamesh411. Herald added subscribers: abrachet, manas, ASDenysPetrov, phosek, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware. Herald added a reviewer: Szelethus. Her

[PATCH] D127799: [StaticAnalyzer] Remove dead code (DO NOT COMMIT)

steakhal added a comment. Thanks @kazu. I evaluated your results and made a patch as D127836 . I think we can abandon this one. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127799/new/ https://reviews.llvm.org/D1

[PATCH] D125931: [clang][dataflow] Add support for correlated branches to optional model

sgatev updated this revision to Diff 437088. sgatev marked 3 inline comments as done. sgatev added a comment. Herald added a subscriber: martong. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125931/new/ https://reviews.llvm.org/D

[PATCH] D125931: [clang][dataflow] Add support for correlated branches to optional model

sgatev added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/Models/UncheckedOptionalAccessModel.cpp:288 +bool isEngagedOptionalValue(const Value &OptionalVal, const Environment &env) { + auto *HasValueVal = xazax.hun wrote: > I wonder whether `

[PATCH] D127838: [analyzer][NFC] Remove dead field of UnixAPICheckers

steakhal created this revision. steakhal added reviewers: kazu, martong. Herald added subscribers: manas, ASDenysPetrov, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun. Herald added a reviewer: Szelethus. Herald added a project: All. stea

[PATCH] D127839: [analyzer] Fix StreamErrorState hash bug

steakhal created this revision. steakhal added reviewers: kazu, martong, balazske. Herald added subscribers: manas, ASDenysPetrov, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun. Herald added a reviewer: Szelethus. Herald added a project:

[clang] 7acc88b - [OpenCL] Reword unknown extension pragma diagnostic

Author: Sven van Haastregt Date: 2022-06-15T10:54:46+01:00 New Revision: 7acc88be0312c721bc082ed9934e381d297f4707 URL: https://github.com/llvm/llvm-project/commit/7acc88be0312c721bc082ed9934e381d297f4707 DIFF: https://github.com/llvm/llvm-project/commit/7acc88be0312c721bc082ed9934e381d297f4707.

[PATCH] D126660: [OpenCL] Reword unknown extension pragma diagnostic

This revision was automatically updated to reflect the committed changes. Closed by commit rG7acc88be0312: [OpenCL] Reword unknown extension pragma diagnostic (authored by svenvh). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126660/new/ https://re

[clang] 8fcdd62 - [clang][dataflow] Add support for correlated branches to optional model

Author: Stanislav Gatev Date: 2022-06-15T10:00:44Z New Revision: 8fcdd625856b2e7df2fdb3a4c57efedb35e4d7c1 URL: https://github.com/llvm/llvm-project/commit/8fcdd625856b2e7df2fdb3a4c57efedb35e4d7c1 DIFF: https://github.com/llvm/llvm-project/commit/8fcdd625856b2e7df2fdb3a4c57efedb35e4d7c1.diff LO

[PATCH] D125931: [clang][dataflow] Add support for correlated branches to optional model

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8fcdd625856b: [clang][dataflow] Add support for correlated branches to optional model (authored by sgatev). Repository: rG LLVM Github Monorepo C

[clang] 170ca11 - [Sema] Remove unused function after 8c7b64b5ae2a

Author: Benjamin Kramer Date: 2022-06-15T12:20:44+02:00 New Revision: 170ca11aeff25735006ca51e5ed3005b672e8f97 URL: https://github.com/llvm/llvm-project/commit/170ca11aeff25735006ca51e5ed3005b672e8f97 DIFF: https://github.com/llvm/llvm-project/commit/170ca11aeff25735006ca51e5ed3005b672e8f97.dif

[clang] 43e7ba6 - Fix signed/unsigned comparison warning

Author: Simon Pilgrim Date: 2022-06-15T11:53:08+01:00 New Revision: 43e7ba6495359bcc14580725468e7736e97edcc6 URL: https://github.com/llvm/llvm-project/commit/43e7ba6495359bcc14580725468e7736e97edcc6 DIFF: https://github.com/llvm/llvm-project/commit/43e7ba6495359bcc14580725468e7736e97edcc6.diff

[PATCH] D127832: [clangd] Always desugar type aliases in hover

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM. Please take a look the NIT about landing this as two commits. Comment at: clang-tools-extra/clangd/Hover.cpp:581 HoverInfo HI; - const ASTContext &Ctx

[PATCH] D127844: [clangd] Pull suppression logic into common path, apply for driver diagnostics

kadircet created this revision. kadircet added a reviewer: ilya-biryukov. Herald added subscribers: usaxena95, arphaman. Herald added a project: All. kadircet requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang-tools-extra. Fixes https:/

[PATCH] D127844: [clangd] Pull suppression logic into common path, apply for driver diagnostics

kadircet updated this revision to Diff 437109. kadircet added a comment. Just pass optional directly Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127844/new/ https://reviews.llvm.org/D127844 Files: clang-tools-extra/clangd/Diagnostics.cpp cla

[PATCH] D127629: [clang] Use correct visibility parameters when following a Using declaration

furkanusta added a comment. I don't think I have a commit access this is my first contribution. I appreciate if you can do it for me. My mail address is: furkanust...@gmail.com I had my github account linked and expecting for my mail to get fetched automatically. To make things easier should

[PATCH] D127836: [analyzer][NFC] Remove dead code and modernize surroundings

martong added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/MallocChecker.cpp:931-934 + // void *getTag() const { + // static int Tag = 0; + // return static_cast(&Tag); + // } Why should we keep this? Repository: rG LLVM Github Monor

[PATCH] D127839: [analyzer] Fix StreamErrorState hash bug

martong accepted this revision. martong added a comment. This revision is now accepted and ready to land. Nice catch! LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127839/new/ https://reviews.llvm.org/D127839 _

[PATCH] D127746: [clang][dataflow] Convert `PointeeLoc` of `PointerValue` from reference to pointer.

ymandel added a comment. Herald added a subscriber: martong. Overall, this seems to be an important API change, and I'm having trouble seeing the big picture here. I think it would be great if you could expand (in the CL description) on the motivation behind the change and the thinking behind

[PATCH] D127838: [analyzer][NFC] Remove dead field of UnixAPICheckers

martong added a comment. Umm, why this can't be part of D127836 ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127838/new/ https://reviews.llvm.org/D127838 ___ cfe-com

[PATCH] D127163: [clang] Add -fsanitize=memtag-globals (no-op).

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127163/new/ https://reviews.llvm.org/D127163 ___ cfe-commits mailing list cfe-commi

[PATCH] D127649: [analyzer][NFC][test] Add new RUN line with support-symbolic-integer-casts=true to expr-inspection.cpp

martong updated this revision to Diff 437112. martong marked an inline comment as done. martong added a comment. - Use template declarations Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127649/new/ https://reviews.llvm.org/D127649 Files: clang/

[PATCH] D127649: [analyzer][NFC][test] Add new RUN line with support-symbolic-integer-casts=true to expr-inspection.cpp

martong added inline comments. Comment at: clang/test/Analysis/expr-inspection.cpp:11-13 void clang_analyzer_denote(int x, const char *str); +void clang_analyzer_denote(unsigned x, const char *str); void clang_analyzer_express(int x); steakhal wrote: > Ok, don

[PATCH] D122150: [clang][analyzer] Add checker for bad use of 'errno'.

steakhal added a comment. I believe `evalAssume` would be a better fit for diagnosing such issues, but I can see your point that we don't have `CheckerContext` there to emit reports. That being said, the `check::Location` is the best alternative. Please also check the not `done` comments. ===

[clang] 3605ebc - [analyzer][NFC][test] Add new RUN lint with support-symbolic-integer-casts=true to svalbuilder-rearrange-comparisons.c

Author: Gabor Marton Date: 2022-06-15T13:52:18+02:00 New Revision: 3605ebca32fc42d01a54eea00bb4bf8049dca214 URL: https://github.com/llvm/llvm-project/commit/3605ebca32fc42d01a54eea00bb4bf8049dca214 DIFF: https://github.com/llvm/llvm-project/commit/3605ebca32fc42d01a54eea00bb4bf8049dca214.diff

[PATCH] D127646: [analyzer][NFC][test] Add new RUN lint with support-symbolic-integer-casts=true to svalbuilder-rearrange-comparisons.c

martong marked an inline comment as done. martong added inline comments. Comment at: clang/test/Analysis/svalbuilder-rearrange-comparisons.cpp:16-17 + +template +void clang_analyzer_eval(T x); +template steakhal wrote: > Ok, thx, done. Repository: rG LLVM

[PATCH] D127646: [analyzer][NFC][test] Add new RUN lint with support-symbolic-integer-casts=true to svalbuilder-rearrange-comparisons.c

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. martong marked an inline comment as done. Closed by commit rG3605ebca32fc: [analyzer][NFC][test] Add new RUN lint with support-symbolic-integer-casts=true… (authored by

[PATCH] D125400: [clang][Analyzer] Add errno state to standard functions modeling.

steakhal added a comment. It looks everything fine, given that the `alpha.unix.Errno` will depend on the `apimodeling.StdCLibraryFunctions`. This should do the expected errno state propagation by which the `Errno` checker can report diagnostics - WHILE the `StdCLibraryFunctions` still won't rep

[PATCH] D122215: [WebAssembly] Initial support for reference type externref in clang

pmatos updated this revision to Diff 437119. pmatos retitled this revision from "[WebAssembly] Initial support for reference types in clang" to "[WebAssembly] Initial support for reference type externref in clang". pmatos edited the summary of this revision. pmatos added a comment. Update revisi

[PATCH] D123064: [Clang][C++23] P2071 Named universal character escapes

aaron.ballman added a comment. Some likely final coding style nits. The only thing of substance I'm waiting on is an answer to whether we need to update a license file in order to comply with the Unicode license requirements. @tstellar, any chance you can help there? Comment

[PATCH] D127798: [AArch64] Define __ARM_FEATURE_RCPC

tyb0807 added a comment. The patch looks correct to me, but looking at https://github.com/ARM-software/acle/blob/main/main/acle.md where all the ACLE macros are defined, I'm not sure that `__ARM_FEATURE_RCPC` is there currently. Maybe you also want to submit a patch there, or at least explain t

[PATCH] D127836: [analyzer][NFC] Remove dead code and modernize surroundings

steakhal updated this revision to Diff 437120. steakhal added a comment. remove dead code from MallocChecker Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127836/new/ https://reviews.llvm.org/D127836 Files: clang/lib/StaticAnalyzer/Checkers/Basi

[PATCH] D127836: [analyzer][NFC] Remove dead code and modernize surroundings

steakhal added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/MallocChecker.cpp:931-934 + // void *getTag() const { + // static int Tag = 0; + // return static_cast(&Tag); + // } martong wrote: > Why should we keep this? Accident xD Repo

[PATCH] D127838: [analyzer][NFC] Remove dead field of UnixAPICheckers

steakhal added a comment. In D127838#3584911 , @martong wrote: > Umm, why this can't be part of D127836 ? It can be, but I wanted to still do this separately. The reasoning in the summary should nominate this to a sepa

[PATCH] D127454: [OpenMP] Initial parsing and sema for 'parallel masked' construct

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127454/new/ https://reviews.llvm.org/D127454 ___

[PATCH] D123064: [Clang][C++23] P2071 Named universal character escapes

aaron.ballman added inline comments. Comment at: clang/lib/Lex/LiteralSupport.cpp:509-511 +if (std::max(Distance, Match.Distance) - +std::min(Distance, Match.Distance) > +3) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[PATCH] D127593: [clang] Fix trivially copyable for copy constructor and copy assignment operator

erichkeane added a comment. In D127593#3583125 , @royjacobson wrote: > Thank you! LGTM. I see the CI still has those OpenMP failures - could you try > to rebase on main to get it green? > > @erichkeane is this good to go? Should I ping some ABI people a

[PATCH] D123064: [Clang][C++23] P2071 Named universal character escapes

aaron.ballman added a comment. I had a discussion about the license file on IRC (but not with @tstellar) and the thinking there was: add the license file. It seems to either be required or would be harmless to add. So if we don't hear something different from @tstellar on this, I think you shou

[PATCH] D127803: Generate the capture for field when the field is used with implicit default.

ABataev added a comment. Why do we need to insert new implicit DSA? Only explicit DSAs are expected to be stored, implicit ones can be deduced using the rules. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127803/new/ https://reviews.llvm.org/D12

[PATCH] D125723: [MSVC] Add initial support for MSVC pragma optimize

aaron.ballman added inline comments. Comment at: clang/docs/ReleaseNotes.rst:301 C linkage. +- Added support for a nonempty optimization list for MSVC's ``#pragma optimize``. + The pragma takes a list of optimizations to turn on or off which applies to ==

[PATCH] D126907: Deferred Concept Instantiation Implementation Take 2

erichkeane added a comment. In D126907#3584555 , @ChuanqiXu wrote: > I finally found some time to look at the crash. Although I haven't get an > idea, I found it crash at the following one too: > > template > concept Constraint = true; > > temp

[PATCH] D127856: [clangd] Support multiline semantic tokens

kadircet created this revision. kadircet added reviewers: sammccall, nridge. Herald added subscribers: usaxena95, arphaman. Herald added a project: All. kadircet requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-ext

Re: [PATCH] D127629: [clang] Use correct visibility parameters when following a Using declaration

thanks! you're right, it was already included in the arcanist metadata, i was too lazy to check beforehand, sorry. On Wed, Jun 15, 2022 at 1:30 PM Furkan via Phabricator < revi...@reviews.llvm.org> wrote: > furkanusta added a comment. > > I don't think I have a commit access this is my first cont

[PATCH] D109701: [clang] Emit SARIF Diagnostics: Create `clang::SarifDocumentWriter` interface

aaron.ballman added a comment. Aside from some minor nits and the open question about validation, I think this is getting pretty close. I'm curious about the next steps with this though, given that there are no in-tree uses for it currently. You had mentioned you planned to work on an adapter s

[clang-tools-extra] 462def2 - [clang] Use correct visibility parameters when following a Using declaration

Author: Furkan Usta Date: 2022-06-15T15:52:59+02:00 New Revision: 462def25ec134d30aade4ffbf1ddc4185f2ec616 URL: https://github.com/llvm/llvm-project/commit/462def25ec134d30aade4ffbf1ddc4185f2ec616 DIFF: https://github.com/llvm/llvm-project/commit/462def25ec134d30aade4ffbf1ddc4185f2ec616.diff L

[PATCH] D127629: [clang] Use correct visibility parameters when following a Using declaration

This revision was automatically updated to reflect the committed changes. Closed by commit rG462def25ec13: [clang] Use correct visibility parameters when following a Using declaration (authored by furkanusta, committed by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D127802: [HLSL] Support HLSL vector initializers

beanz added inline comments. Comment at: clang/test/SemaHLSL/BuiltIns/vector-constructors-erros.hlsl:8 +void entry() { + float2 LilVec = float2(1.0, 2.0); + float2 BrokenVec = float2(1.0, 2.0, 3.0); // expected-error{{excess elements in vector initializer}} py

[PATCH] D127812: [AArch64] Function multiversioning support added.

erichkeane added a comment. I'm concerned as to the design of this addition, I don't particularly appreciate the reasons for making 'target_clones' different, nor the purpose for adding a new attribute instead of using 'target' for what seems like exactly that? IF the new spelling is THAT nece

[PATCH] D127838: [analyzer][NFC] Remove dead field of UnixAPICheckers

martong accepted this revision. martong added a comment. This revision is now accepted and ready to land. Ok. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127838/new/ https://reviews.llvm.org/D127838 _

[PATCH] D127836: [analyzer][NFC] Remove dead code and modernize surroundings

martong accepted this revision. martong added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127836/new/ https://reviews.llvm.org/D127836 _

[PATCH] D127638: [clang][sema] Provide better diagnostic for missing template parameters

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc149fa1f5fda: [clang][sema] Provide better diagnostic for missing template arguments (authored by tbaeder). Changed prior to commit: https://revie

[clang] bce55d0 - [clang][NFC] Remove unused parameter from ActOnCXXNestedNameSpecifier

Author: Timm Bäder Date: 2022-06-15T16:06:06+02:00 New Revision: bce55d06904c2b121e8eb94c340f16a6bb020860 URL: https://github.com/llvm/llvm-project/commit/bce55d06904c2b121e8eb94c340f16a6bb020860 DIFF: https://github.com/llvm/llvm-project/commit/bce55d06904c2b121e8eb94c340f16a6bb020860.diff LO

[clang] c149fa1 - [clang][sema] Provide better diagnostic for missing template arguments

Author: Timm Bäder Date: 2022-06-15T16:06:06+02:00 New Revision: c149fa1f5fdaf62aa1db4bc52d72a34f0a92dd4f URL: https://github.com/llvm/llvm-project/commit/c149fa1f5fdaf62aa1db4bc52d72a34f0a92dd4f DIFF: https://github.com/llvm/llvm-project/commit/c149fa1f5fdaf62aa1db4bc52d72a34f0a92dd4f.diff LO

[PATCH] D127748: Adds a warning for aligned new in MSVC before C++17

luken-google abandoned this revision. luken-google added a comment. Probably better to address this in the Driver. See also https://reviews.llvm.org/D127641. I'm going to close this for now and see if we want to revisit after that lands or as part of that change. Repository: rG LLVM Github M

[clang] f7a38ee - [analyzer][NFC][test] Add new RUN line with support-symbolic-integer-casts=true to expr-inspection.cpp

Author: Gabor Marton Date: 2022-06-15T16:06:53+02:00 New Revision: f7a38eeccb03a8076e298fd6c0baed7d171f07b6 URL: https://github.com/llvm/llvm-project/commit/f7a38eeccb03a8076e298fd6c0baed7d171f07b6 DIFF: https://github.com/llvm/llvm-project/commit/f7a38eeccb03a8076e298fd6c0baed7d171f07b6.diff

[PATCH] D127649: [analyzer][NFC][test] Add new RUN line with support-symbolic-integer-casts=true to expr-inspection.cpp

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf7a38eeccb03: [analyzer][NFC][test] Add new RUN line with support-symbolic-integer-casts=true… (authored by martong). Repository: rG LLVM Github M

[PATCH] D127832: [clangd] Always desugar type aliases in hover

kadircet updated this revision to Diff 437148. kadircet marked 2 inline comments as done. kadircet added a comment. - Leave the Ctx refactoring out of the patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127832/new/ https://reviews.llvm.org/D12

[clang] 8f2ba36 - Revert "[ARM][Thumb] Command-line option to ensure AAPCS compliant Frame Records AND [NFC][Thumb] Update frame-chain codegen test to use thumbv6m"

Author: Krasimir Georgiev Date: 2022-06-15T16:10:02+02:00 New Revision: 8f2ba3633646d0c67a1442c6508d02d93571b344 URL: https://github.com/llvm/llvm-project/commit/8f2ba3633646d0c67a1442c6508d02d93571b344 DIFF: https://github.com/llvm/llvm-project/commit/8f2ba3633646d0c67a1442c6508d02d93571b344.d

[clang-tools-extra] 7212977 - [clangd] Always desugar type aliases in hover

Author: Kadir Cetinkaya Date: 2022-06-15T16:10:49+02:00 New Revision: 7212977fbb41bcffaf28a33a70c2df2b40492524 URL: https://github.com/llvm/llvm-project/commit/7212977fbb41bcffaf28a33a70c2df2b40492524 DIFF: https://github.com/llvm/llvm-project/commit/7212977fbb41bcffaf28a33a70c2df2b40492524.dif

[clang-tools-extra] 0473530 - [clangd][NFC] Use the existing ASTContext from scope

Author: Kadir Cetinkaya Date: 2022-06-15T16:10:49+02:00 New Revision: 04735302814e4df1cf37caeff3406fa5523901eb URL: https://github.com/llvm/llvm-project/commit/04735302814e4df1cf37caeff3406fa5523901eb DIFF: https://github.com/llvm/llvm-project/commit/04735302814e4df1cf37caeff3406fa5523901eb.dif

[PATCH] D127832: [clangd] Always desugar type aliases in hover

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7212977fbb41: [clangd] Always desugar type aliases in hover (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D125723: [MSVC] Add initial support for MSVC pragma optimize

steplong updated this revision to Diff 437153. steplong added a comment. - Fix docs - Clean up code Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125723/new/ https://reviews.llvm.org/D125723 Files: clang/docs/ReleaseNotes.rst clang/include/cla

[clang] e180cc5 - [Driver][test] Make RISCV tests robust with PATH=

Author: Shao-Ce SUN Date: 2022-06-15T22:25:22+08:00 New Revision: e180cc5ff1a133c533e68bb92024d2455d5e6978 URL: https://github.com/llvm/llvm-project/commit/e180cc5ff1a133c533e68bb92024d2455d5e6978 DIFF: https://github.com/llvm/llvm-project/commit/e180cc5ff1a133c533e68bb92024d2455d5e6978.diff L

[PATCH] D127589: [Driver][test] Make RISCV tests robust with PATH=

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe180cc5ff1a1: [Driver][test] Make RISCV tests robust with PATH= (authored by sunshaoce). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[PATCH] D123064: [Clang][C++23] P2071 Named universal character escapes

cor3ntin updated this revision to Diff 437160. cor3ntin marked 17 inline comments as done. cor3ntin added a comment. Address more style issues found by Aaron Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123064/new/ https://reviews.llvm.org/D123064

[PATCH] D126540: PowerPC] Emit warning for incompatible vector types that are currently diagnosed with -fno-lax-vector-conversions

maryammo updated this revision to Diff 437161. maryammo added a comment. Tune the logic to emit warning when at least one of the vectors is altivec one and overloading resolution is done Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126540/new/ ht

[PATCH] D127839: [analyzer] Fix StreamErrorState hash bug

steakhal added a comment. This change introduces a single new report: F23459650: image.png This makes me believe that this bug was not that important after all. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1278

[PATCH] D127859: [clangd] Don't add inlay hints on std::move/forward

upsj created this revision. upsj added a reviewer: nridge. Herald added subscribers: usaxena95, kadircet, arphaman. Herald added a project: All. upsj requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. This re

[PATCH] D127807: [clang-tidy] Properly forward clang-tidy output when running tests

nicovank updated this revision to Diff 437163. nicovank added a comment. Looks like this causes the `misc-misleading-identifier` test to fail on the BuildKite Windows setup because it uses cp1252 and not utf-8. I think this is why the encode was added in the first place. This workaround should h

[PATCH] D127860: [msan] Allow KMSAN to use -fsanitize-memory-param-retval

glider created this revision. Herald added a project: All. glider requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. Let -fsanitize-memory-param-retval be used together with -fsanitize=kernel-memory, so that it can be applied when buil

[PATCH] D127306: [analyzer] Treat system globals as mutable if they are not const

steakhal marked an inline comment as done. steakhal added a comment. According to my measurements, this commit will change some reports, but nothing significant (<20) on our testset (except llvm which I did not include). But more importantly, no taint reports disappeared nor were introduced. Re

[PATCH] D127579: [clang][WIP] add option to keep types of ptr args for non-kernel functions in metadata

Anastasia added a comment. The patch seems very straight forward. I wonder though if we should always enable this for SPIR-V w/o adding any flag until the untyped pointers are added to SPIR-V so it will become a target setting controlled instead of a flag? Also is there anything that we don't

[PATCH] D127763: [analyzer] Relax constraints on const qualified regions

steakhal added a comment. According to my measurements, this change has minor effects (1 new, 20 disappeared reports). The interesting reports had really long bug paths, so I think there were some default eval called functions down the line which made this patch surface this way. Repository:

[PATCH] D127579: [clang][WIP] add option to keep types of ptr args for non-kernel functions in metadata

beanz added a comment. There are numerous changes floating around that boil down to "we need pointer types". Most are SPIR-V & DXIL related. I'm a little concerned that we are generally building a bunch of different approaches to tracking pointer types and not considering a more general solutio

[clang] f1b18a7 - [analyzer][NFC] Remove dead code and modernize surroundings

Author: Balazs Benics Date: 2022-06-15T16:50:12+02:00 New Revision: f1b18a79b7f4c81ef67e83f5d1a02ded139df02d URL: https://github.com/llvm/llvm-project/commit/f1b18a79b7f4c81ef67e83f5d1a02ded139df02d DIFF: https://github.com/llvm/llvm-project/commit/f1b18a79b7f4c81ef67e83f5d1a02ded139df02d.diff

[PATCH] D127836: [analyzer][NFC] Remove dead code and modernize surroundings

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf1b18a79b7f4: [analyzer][NFC] Remove dead code and modernize surroundings (authored by steakhal). Repository: rG LLVM Github Monorepo CHANGES SIN

  1   2   3   >