[PATCH] D120540: [Driver] Enable to use C++20 modules standalone by -fcxx-modules

ChuanqiXu added a comment. @aprantl Thanks for the reverting. I never image `-fcxx-modules` would refer to Clang C++ modules. So the problem becomes more complicated. In D120540#3551169 , @iains wrote: > I guess Chuanqi's TZ is in sleep mode at the mome

[PATCH] D125291: Introduce @llvm.threadlocal.address intrinsic to access TLS variable (1/3)

ChuanqiXu marked an inline comment as done. ChuanqiXu added a comment. In D125291#3535196 , @nhaehnle wrote: > You can use the "Edit Related Revisions" option in the right-hand side menu > of Phabricator to link this revision with the others of the serie

[PATCH] D112661: [clangd] reuse preambles from other files when possible

nridge added a comment. @qchateau How should I interpret the abandoning of this patch -- did you run into a problem with the approach, or just don't have the time / interest to pursue it further? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D11266

[PATCH] D127005: [clang-format][NFC] Clean up the unwrapped line parser

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127005/new/ https://reviews.llvm.org/D127005 ___ cfe-commits mailing li

[PATCH] D126845: [clang-format] Handle Verilog numbers and operators

MyDeveloperDay added inline comments. Comment at: clang/lib/Format/FormatToken.h:1417 // Workaround for hashes and backticks in Verilog. IdentifierInfo *verilogHash; IdentifierInfo *verilogHashHash; maybe `kw_verilogHash` and `kw_verilogHashHash` and `kw

[PATCH] D127054: [clang-format] Handle attributes for for/while loops

MyDeveloperDay added a comment. nice! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127054/new/ https://reviews.llvm.org/D127054 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm

[PATCH] D126364: Fix interaction of pragma FENV_ACCESS with other pragmas

sepavloff added a comment. In D126364#3556943 , @efriedma wrote: > Given we have getEffectiveRoundingMode(), I think the calls to > setRoundingModeOverride shouldn't be necessary? And if we drop those calls, > we can also drop the IsRoundingModeSet var

[PATCH] D126959: [C++20][Modules] Introduce an implementation module.

iains planned changes to this revision. iains added a comment. thanks for the reviews, I need to figure out why the implementation passes clang tests but gives fails for clangd. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126959/new/ https://rev

[PATCH] D118034: [C++20] [Modules] Don't complain about duplicated default template argument across modules

ChuanqiXu updated this revision to Diff 434411. ChuanqiXu added a comment. Address comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118034/new/ https://reviews.llvm.org/D118034 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td clang/include/clang/Sema/Sema.h clang/li

[PATCH] D127093: [clang][pseudo] Add missing Support lib to cxx

DavidSpickett created this revision. Herald added subscribers: jsji, pengfei, mgorny. Herald added a project: All. DavidSpickett requested review of this revision. Herald added subscribers: cfe-commits, alextsao1999. Herald added a project: clang-tools-extra. Without this the following build confi

[PATCH] D127093: [clang][pseudo] Add missing Support lib to cxx

DavidSpickett added reviewers: sammccall, MaskRay. DavidSpickett added a comment. Herald added a subscriber: StephenFan. I'm basing this on what `psuedo/lib/grammar` does, so I'm not totally sure this is the place to fix it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[PATCH] D127093: [clang][pseudo] Add missing Support lib to cxx

DavidSpickett added a comment. `DBUILD_SHARED_LIBS` being the key setting in the config that causes the issue. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127093/new/ https://reviews.llvm.org/D127093 _

[PATCH] D118034: [C++20] [Modules] Don't complain about duplicated default template argument across modules

ChuanqiXu marked 10 inline comments as done. ChuanqiXu added inline comments. Comment at: clang/lib/Sema/SemaTemplate.cpp:2762 SawDefaultArgument = true; -RedundantDefaultArg = true; +if (!OldTypeParm->getImportedOwningModule()) + RedundantDefaul

[PATCH] D118034: [C++20] [Modules] Don't complain about duplicated default template argument across modules

ChuanqiXu updated this revision to Diff 434415. ChuanqiXu marked an inline comment as done. ChuanqiXu added a comment. Remove unused header ODRHash.h CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118034/new/ https://reviews.llvm.org/D118034 Files: clang/include/clang/Basic/Diagnostic

[PATCH] D126694: [C++20][Modules] Initial implementation of GMF decl elision.

iains updated this revision to Diff 434417. iains added a comment. Herald added a reviewer: aaron.ballman. this is a re-write - please see additional comments on the revised direction. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126694/new/ https

[PATCH] D126694: [C++20][Modules] Initial implementation of GMF decl elision.

iains added a comment. @chuanqiXu, thanks for reviewing - but it seems I need to find the right direction before dealing with the details. @rsmith - So here is a revised strategy - it is incomplete, and the code contains debug - so I am posting only for a review of the direction taken.

[PATCH] D126694: [C++20][Modules] Initial implementation of GMF decl elision.

ChuanqiXu added a comment. Given it touches ModuleOwnershipKind too and some codes looks similar to me (I haven't look into the it yet), I want to know if it is possible to make D113545 a parent revision of this one? I feel like reachability might be more impo

[PATCH] D126479: [Clang] Allow 'Complex float __attribute__((mode(HC)))'

jolanta.jensen added inline comments. Comment at: clang/include/clang/Basic/TargetInfo.h:60 + Ibm128, + Half }; tahonermann wrote: > The existing enumerators were ordered according to precision. Consider moving > `Half` to before `Float` if doing so doesn't c

[PATCH] D126694: [C++20][Modules] Initial implementation of GMF decl elision.

iains added a comment. on the serialisation-front; maybe it would be better just to stream the 3 bits of the ownership and then we only need to check on deserialisation that the owning module exists for anything other than !owned. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

[PATCH] D109977: LLVM Driver Multicall tool

thakis added inline comments. Comment at: llvm/test/lit.cfg.py:142 tools = [ +ToolSubst('%llvm', FindTool('llvm')), ToolSubst('%lli', FindTool('lli'), post='.', extra_args=lli_args), This causes `llvm-lit: /Users/thakis/src/llvm-project/llvm/utils/lit/

[clang] 881125a - Allow use of an elaborated type specifier in a _Generic association in C++

Author: Aaron Ballman Date: 2022-06-06T07:17:35-04:00 New Revision: 881125ad9178120acef186f579e36ced0888dfdb URL: https://github.com/llvm/llvm-project/commit/881125ad9178120acef186f579e36ced0888dfdb DIFF: https://github.com/llvm/llvm-project/commit/881125ad9178120acef186f579e36ced0888dfdb.diff

[PATCH] D126969: Allow use of an elaborated type specifier in a _Generic association in C++

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG881125ad9178: Allow use of an elaborated type specifier in a _Generic association in C++ (authored by aaron.ballman). Repository: rG LLVM Github M

[clang] cc30d43 - Fix a -Wlogical-op-parentheses warning; NFC

Author: Aaron Ballman Date: 2022-06-06T07:52:12-04:00 New Revision: cc30d43ce49c253e0274ca2679d42c2f706bfc3b URL: https://github.com/llvm/llvm-project/commit/cc30d43ce49c253e0274ca2679d42c2f706bfc3b DIFF: https://github.com/llvm/llvm-project/commit/cc30d43ce49c253e0274ca2679d42c2f706bfc3b.diff

[PATCH] D127066: [clang] Remove some `U+00AD`s in `__cpp_multidimensional_subscript`

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. It took me a moment, but this actually removes a 0xC2AD and not a 0x00AD. It's still correct, but I was wondering why no character was printed in the text -- 0xC2AD is not a defi

[PATCH] D126377: [clang][AArch64][SVE] Improve diagnostics for SVE operators

c-rhodes accepted this revision. c-rhodes added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126377/new/ https://reviews.llvm.org/D126377 ___

[PATCH] D119646: [clang] Allow consteval functions in default arguments

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM with some small fixes to the release note. Thanks @ChuanqiXu! Comment at: clang/docs/ReleaseNotes.rst:166 type. +- Clang will allow constexpr function in default argument. This fixes + `Issue 48230

[PATCH] D126380: [clang][AArch64][SVE] Implicit conversions for vector-scalar operations

DavidTruby added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:13582 +// Need the original target type for vector type checks +const Type *OriginalTarget = S.Context.getCanonicalType(T).getTypePtr(); +// Handle conversion from scalable to fixed when msv

[PATCH] D127105: [analyzer] Fix null pointer deref in CastValueChecker

vabridgers created this revision. vabridgers added reviewers: martong, steakhal, NoQ. Herald added subscribers: manas, ASDenysPetrov, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun. Herald added a project: All. vabridgers requested review

[PATCH] D126380: [clang][AArch64][SVE] Implicit conversions for vector-scalar operations

DavidTruby updated this revision to Diff 434445. DavidTruby added a comment. Clean up code based on review comments Move additional tests to existing file Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126380/new/ https://reviews.llvm.org/D126380 F

[PATCH] D126183: Implement soft reset of the diagnostics engine.

v.g.vassilev accepted this revision. v.g.vassilev added a comment. This revision is now accepted and ready to land. This looks good to me, modulo the inline comment. Let's wait for @rsmith's green light. Comment at: clang/lib/Interpreter/IncrementalParser.cpp:201 // FIXME

[PATCH] D126781: [CodeGen] Keep track info of lazy-emitted symbols in ModuleBuilder

v.g.vassilev added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.h:1506 + + struct KeepLazyEmiitedSymRAII { +std::unique_ptr OldBuilder; Would it make sense to make the RAII a friend to avoid adding the accessors of various structures?

[PATCH] D88780: Allow interfaces to operate on in-memory buffers with no source location info.

v.g.vassilev added a comment. This looks reasonable to me... @shafik, @teemperor what do you think? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88780/new/ https://reviews.llvm.org/D88780 ___ cfe-comm

[PATCH] D126719: [clang-cl] Add support for /kernel

steplong updated this revision to Diff 434459. steplong added a comment. - Clang-formatted patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126719/new/ https://reviews.llvm.org/D126719 Files: clang/include/clang/Basic/LangOptions.def clang/

[PATCH] D126984: [clang] Add initial support for gcc's optimize function attribute

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/Attr.td:2265 + let Spellings = [GCC<"optimize">]; + let Args = [StringArgument<"Level">]; + let Subjects = SubjectList<[Function]>; Something along these lines adds a "fake" argument to

[PATCH] D109977: LLVM Driver Multicall tool

abrachet marked an inline comment as done. abrachet added inline comments. Comment at: llvm/test/lit.cfg.py:142 tools = [ +ToolSubst('%llvm', FindTool('llvm')), ToolSubst('%lli', FindTool('lli'), post='.', extra_args=lli_args), thakis wrote: > This caus

[PATCH] D32199: [TySan] A Type Sanitizer (Clang)

fhahn updated this revision to Diff 434471. fhahn added a comment. Rebase & address comments, thanks! Also update the code to link tysan runtime with static linking. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D32199/new/ https://reviews.llvm.org

[PATCH] D127114: new clang-tidy checker for assignments within condition clause of if statement

dodohand created this revision. Herald added subscribers: carlosgalvezp, mgorny. Herald added a project: All. dodohand requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. new clang-tidy checker for assignments with the condition cla

[PATCH] D126781: [CodeGen] Keep track info of lazy-emitted symbols in ModuleBuilder

junaire updated this revision to Diff 434473. junaire added a comment. friend class comes to the rescue! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126781/new/ https://reviews.llvm.org/D126781 Files: clang/lib/CodeGen/CodeGenModule.h clang/

[PATCH] D126781: [CodeGen] Keep track info of lazy-emitted symbols in ModuleBuilder

junaire updated this revision to Diff 434474. junaire marked an inline comment as done. junaire added a comment. fix a typo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126781/new/ https://reviews.llvm.org/D126781 Files: clang/lib/CodeGen/CodeG

[PATCH] D126781: [CodeGen] Keep track info of lazy-emitted symbols in ModuleBuilder

junaire added inline comments. Comment at: clang/lib/CodeGen/ModuleBuilder.cpp:138 + { +CodeGenModule::KeepLazyEmiitedSymRAII RAIIKeeper(Builder); +M.reset(new llvm::Module(ExpandModuleName(ModuleName, CodeGenOpts), C)); v.g.vassilev wrote:

[PATCH] D127114: new clang-tidy checker for assignments within condition clause of if statement

gribozavr2 added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/misc-assignment-in-if-clause.rst:9 +Finds these assignments even within multiple sets of parentheses which is often appropriate to structure multi-part condition statements. +Finds these assi

[PATCH] D126781: [CodeGen] Keep track info of lazy-emitted symbols in ModuleBuilder

junaire updated this revision to Diff 434479. junaire added a comment. Remove extra brackets Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126781/new/ https://reviews.llvm.org/D126781 Files: clang/lib/CodeGen/CodeGenModule.h clang/lib/CodeGen/

[PATCH] D127116: [clangd] Add flags to symbol requests to restrict to ObjC symbols

dgoldman created this revision. Herald added subscribers: usaxena95, kadircet, arphaman. Herald added a project: All. dgoldman requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. clangd will set this flag for

[PATCH] D127114: new clang-tidy checker for assignments within condition clause of if statement

dodohand added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/misc-assignment-in-if-clause.rst:9 +Finds these assignments even within multiple sets of parentheses which is often appropriate to structure multi-part condition statements. +Finds these assign

[PATCH] D126781: [CodeGen] Keep track info of lazy-emitted symbols in ModuleBuilder

rjmccall added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.h:1482 + + struct KeepLazyEmiitedSymRAII { +std::unique_ptr OldBuilder; I think a RAII object is an odd way to express this API; there's not really a natural reason you would scope

[PATCH] D125742: Minor refactor of CanonicalIncludes::addSystemHeadersMapping.

ppluzhnikov added a comment. Ping x2? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125742/new/ https://reviews.llvm.org/D125742 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm

[PATCH] D121733: Clean pathnames in FileManager.

ppluzhnikov abandoned this revision. ppluzhnikov added a comment. This proved to be too hard :-( A smaller change: https://reviews.llvm.org/D126396 fixed one aspect of this problem. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121733/new/ https:/

[PATCH] D127114: new clang-tidy checker for assignments within condition clause of if statement

gribozavr2 added inline comments. Comment at: clang-tools-extra/clang-tidy/misc/AssignmentInIfClauseCheck.cpp:39 + diag(MatchedDecl->getBeginLoc(), + "Assignment detected within if statement. Fix to equality check if this " + "was accidental. Consider moving out of

[PATCH] D125919: Drop qualifiers from return types in C (DR423)

aaron.ballman added a comment. In D125919#3556754 , @rsmith wrote: > In D125919#3556418 , @aaron.ballman > wrote: > >> In D125919#3556319 , @rjmccall >> wrote: >> >>> No

[PATCH] D127114: new clang-tidy checker for assignments within condition clause of if statement

dodohand added inline comments. Comment at: clang-tools-extra/clang-tidy/misc/AssignmentInIfClauseCheck.cpp:39 + diag(MatchedDecl->getBeginLoc(), + "Assignment detected within if statement. Fix to equality check if this " + "was accidental. Consider moving out of if

[PATCH] D126781: [CodeGen] Keep track info of lazy-emitted symbols in ModuleBuilder

junaire added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.h:1482 + + struct KeepLazyEmiitedSymRAII { +std::unique_ptr OldBuilder; rjmccall wrote: > I think a RAII object is an odd way to express this API; there's not really a > natural reas

[PATCH] D127082: [clangd] Add Macro Expansion to Hover

daiyousei-qz added a comment. To elaborate on known situation where expansion isn't available: 1. expansion doesn't work on site of #define 2. expansion doesn't work for _Pragma(...) and alike 3. expansion doesn't work with builtin macro 4. expansion doesn't work for macros as arguments of functi

[PATCH] D126781: [CodeGen] Keep track info of lazy-emitted symbols in ModuleBuilder

rjmccall added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.h:1482 + + struct KeepLazyEmiitedSymRAII { +std::unique_ptr OldBuilder; junaire wrote: > rjmccall wrote: > > I think a RAII object is an odd way to express this API; there's not real

[PATCH] D126694: [C++20][Modules] Initial implementation of GMF decl elision.

iains added a comment. In D126694#3559818 , @ChuanqiXu wrote: > Given it touches ModuleOwnershipKind too and some codes looks similar to me > (I haven't look into the it yet), I want to know if it is possible to make > D113545

[PATCH] D127125: [clangd] Improve ObjC protocol suggestions from the index

dgoldman created this revision. Herald added subscribers: usaxena95, kadircet, arphaman. Herald added a project: All. dgoldman requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. When querying the index during

[PATCH] D126183: Implement soft reset of the diagnostics engine.

v.g.vassilev added inline comments. Comment at: clang/lib/Interpreter/IncrementalParser.cpp:200 // FIXME: Do not reset the pragma handlers. +Diags.Reset(true); We should remove this fixme, too. Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[PATCH] D127075: [clang] P2266: apply move elision rules on throw expr nested in function prototypes

rsmith accepted this revision. rsmith added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Sema/SemaExprCXX.cpp:848 (Scope::FnScope | Scope::ClassScope | Scope::BlockScope | - Scope::FunctionPrototypeScope

[PATCH] D126871: [clang] [MinGW] Use SEH for unwind info on ARM by default

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126871/new/ https://reviews.llvm.org/D126871 ___

[PATCH] D126364: Fix interaction of pragma FENV_ACCESS with other pragmas

efriedma added a comment. Shouldn't the rounding mode be FE_DYNAMIC by default? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126364/new/ https://reviews.llvm.org/D126364 ___ cfe-commits mailing list cfe

[PATCH] D126871: [clang] [MinGW] Use SEH for unwind info on ARM by default

efriedma added a comment. Oh, just remembered, we should probably release-note this. (You can post that as a followup.) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126871/new/ https://reviews.llvm.org/D126871 __

[PATCH] D113545: [C++20] [Module] Support reachable definition initially/partially

iains added a comment. I'm going to try rebasing my GMF elision code on top of this. the test-suite changes could be made easier to read by using the file-split stuff we've been using for recent changes (I guess this is an older patch)? Comment at: clang/include/clang/AST/Dec

[PATCH] D126651: [clang-diff] Fix getStmtValue when dealing with wide chars

johannes requested changes to this revision. johannes added a comment. This revision now requires changes to proceed. I've suggested some more refactorings but otherwise this should be good to go Comment at: clang/lib/Tooling/ASTDiff/ASTDiff.cpp:497 + return str; +}

[PATCH] D125695: [clang][DebugInfo] Allow function-local type-like entities to be scoped within a lexical block (5/5)

krisb updated this revision to Diff 434541. krisb marked an inline comment as done. krisb added a comment. Applied review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125695/new/ https://reviews.llvm.org/D125695 Files: clang/lib/CodeG

[PATCH] D126364: Fix interaction of pragma FENV_ACCESS with other pragmas

sepavloff added a comment. In D126364#3560877 , @efriedma wrote: > Shouldn't the rounding mode be FE_DYNAMIC by default? According to the standard it must be FE_TONEAREST: F.8.3p1: At program startup the dynamic floating-point environment is initial

[PATCH] D126364: Fix interaction of pragma FENV_ACCESS with other pragmas

efriedma added a comment. In D126364#3560984 , @sepavloff wrote: > In D126364#3560877 , @efriedma > wrote: > >> Shouldn't the rounding mode be FE_DYNAMIC by default? > > According to the standard it must be FE_TO

[PATCH] D126364: Fix interaction of pragma FENV_ACCESS with other pragmas

sepavloff added a comment. In D126364#3560997 , @efriedma wrote: > In D126364#3560984 , @sepavloff > wrote: > >> In D126364#3560877 , @efriedma >> wrote: >> >>> Shouldn'

[PATCH] D126929: Add sanitizer metadata attributes to clang IR gen.

hctim updated this revision to Diff 434546. hctim added a comment. Rebased. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126929/new/ https://reviews.llvm.org/D126929 Files: clang/lib/CodeGen/CGDecl.cpp clang/lib/CodeGen/CodeGenModule.cpp cl

[PATCH] D127105: [analyzer] Fix null pointer deref in CastValueChecker

vabridgers planned changes to this revision. vabridgers added a comment. I know this will need a reproducer, and I'm working on that. That work is still in progress. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127105/new/ https://reviews.llvm.or

[PATCH] D126871: [clang] [MinGW] Use SEH for unwind info on ARM by default

mstorsjo added a comment. In D126871#3560924 , @efriedma wrote: > Oh, just remembered, we should probably release-note this. (You can post > that as a followup.) Sure, can do. Btw, thanks a lot for your reviews, you've spent a lot of time on them! The

[PATCH] D126364: Fix interaction of pragma FENV_ACCESS with other pragmas

efriedma added inline comments. Comment at: clang/include/clang/Basic/LangOptions.h:622 setFPContractMode(LangOptions::FPM_Off); setRoundingMode(static_cast(LangOptions::FPR_ToNearest)); setFPExceptionMode(LangOptions::FPE_Ignore); I'm suggesting t

[PATCH] D126364: Fix interaction of pragma FENV_ACCESS with other pragmas

sepavloff added inline comments. Comment at: clang/include/clang/Basic/LangOptions.h:622 setFPContractMode(LangOptions::FPM_Off); setRoundingMode(static_cast(LangOptions::FPR_ToNearest)); setFPExceptionMode(LangOptions::FPE_Ignore); efriedma wrote:

[PATCH] D127142: [HIP] Link with clang_rt.builtins

yaxunl created this revision. yaxunl added a reviewer: tra. Herald added a project: All. yaxunl requested review of this revision. Herald added a subscriber: MaskRay. HIP supports _Float16 by default in host programs, which may cause calls of conversion functions for _Float16 emitted e.g. `__trunc

[PATCH] D126364: Fix interaction of pragma FENV_ACCESS with other pragmas

efriedma added inline comments. Comment at: clang/include/clang/Basic/LangOptions.h:622 setFPContractMode(LangOptions::FPM_Off); setRoundingMode(static_cast(LangOptions::FPR_ToNearest)); setFPExceptionMode(LangOptions::FPE_Ignore); sepavloff wrote:

[PATCH] D127142: [HIP] Link with clang_rt.builtins

MaskRay added inline comments. Comment at: clang/lib/Driver/ToolChains/MSVC.cpp:485 "amdhip64.lib"}); + CmdArgs.push_back(Args.MakeArgString("clang_rt.builtins-" + + getTriple().getArchName() + ".lib")); N

[PATCH] D126871: [clang] [MinGW] Use SEH for unwind info on ARM by default

efriedma added a comment. > Btw, thanks a lot for your reviews, you've spent a lot of time on them! You're welcome. > But for MSVC style (C++ exceptions and __try/__except) there's still a couple > backend things that need to be implemented. Do you happen to know roughly how > much effort that

[PATCH] D126871: [clang] [MinGW] Use SEH for unwind info on ARM by default

mstorsjo added a comment. In D126871#3561243 , @efriedma wrote: >> But for MSVC style (C++ exceptions and __try/__except) there's still a >> couple backend things that need to be implemented. Do you happen to know >> roughly how much effort that is? > >

[PATCH] D126694: [C++20][Modules] Initial implementation of GMF decl elision.

iains updated this revision to Diff 434563. iains added a comment. reworked to use D113545 as a parent revision which resolves the issue of needing to make module ownership 'visible' to satisfy lookup. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D126871: [clang] [MinGW] Use SEH for unwind info on ARM by default

efriedma added a comment. Funclets are necessary for both C++ and SEH exception handling, yes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126871/new/ https://reviews.llvm.org/D126871 ___ cfe-commits m

[PATCH] D126694: [C++20][Modules] Initial implementation of GMF decl elision.

iains added a comment. so standard 10.4 ex 2 gives the expected output with this patch stack note that there's a query to core about whether that example is fully correct (but that does not affect the skeleton of these implements - only the detail of what is included / excluded in the `markReac

[PATCH] D127142: [HIP] Link with clang_rt.builtins

tra added a reviewer: MaskRay. tra added a comment. Herald added a subscriber: StephenFan. Looks OK syntax-wise. Library path should probably be fixed, though it appears to be a somewhat separate issue and could be done in its own patch, if the required change is not trivial. ==

[clang] d1346e2 - [gmodules] Skip CXXDeductionGuideDecls when visiting FunctionDecls in

Author: Akira Hatanaka Date: 2022-06-06T12:51:36-07:00 New Revision: d1346e2ee2741919a8cc1b1ffe41e76a6d06 URL: https://github.com/llvm/llvm-project/commit/d1346e2ee2741919a8cc1b1ffe41e76a6d06 DIFF: https://github.com/llvm/llvm-project/commit/d1346e2ee2741919a8cc1b1ffe41e76a6d06.diff

[PATCH] D125839: [gmodules] Skip CXXDeductionGuideDecls when visiting FunctionDecls in DebugTypeVisitor

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd1346e2ee274: [gmodules] Skip CXXDeductionGuideDecls when visiting FunctionDecls in (authored by ahatanak). Repository: rG LLVM Github Monorepo C

[PATCH] D127145: [Driver] add -lresolv for all but Android.

kda created this revision. kda added reviewers: vitalybuka, eugenis. Herald added subscribers: Enna1, danielkiss. Herald added a project: All. kda requested review of this revision. Herald added subscribers: Sanitizers, cfe-commits, MaskRay. Herald added projects: clang, Sanitizers. Repository:

[PATCH] D127145: [Driver] add -lresolv for all but Android.

MaskRay added a comment. The description needs to mention the motivation. Is this meant for `isOSLinux() && isGNUEnvironment()` targets? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127145/new/ https://reviews.llvm.org/D127145 __

[clang] 2293d46 - [clang] [Headers] Check __SEH__, when checking if ARM EHABI is implied

Author: Martin Storsjö Date: 2022-06-06T23:21:05+03:00 New Revision: 2293d46a01752e312a0796d044a25a49b2fd17f5 URL: https://github.com/llvm/llvm-project/commit/2293d46a01752e312a0796d044a25a49b2fd17f5 DIFF: https://github.com/llvm/llvm-project/commit/2293d46a01752e312a0796d044a25a49b2fd17f5.diff

[libunwind] 7c0e93c - [libunwind] Fix SEH unwinding on ARM

Author: Martin Storsjö Date: 2022-06-06T23:23:35+03:00 New Revision: 7c0e93cb89e6aa74881411213abf83faae7c58ee URL: https://github.com/llvm/llvm-project/commit/7c0e93cb89e6aa74881411213abf83faae7c58ee DIFF: https://github.com/llvm/llvm-project/commit/7c0e93cb89e6aa74881411213abf83faae7c58ee.diff

[libunwind] 64778c0 - [libunwind] Remove unused ARM SEH placeholder code

Author: Martin Storsjö Date: 2022-06-06T23:24:22+03:00 New Revision: 64778c002a77046e15a7ce7a7206f5c15355fc26 URL: https://github.com/llvm/llvm-project/commit/64778c002a77046e15a7ce7a7206f5c15355fc26 DIFF: https://github.com/llvm/llvm-project/commit/64778c002a77046e15a7ce7a7206f5c15355fc26.diff

[PATCH] D126865: [clang] [Headers] Check __SEH__, when checking if ARM EHABI is implied

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2293d46a0175: [clang] [Headers] Check __SEH__, when checking if ARM EHABI is implied (authored by mstorsjo). Repository: rG LLVM Github Monorepo

[libunwind] 08d30c6 - [libunwind] Don't store a predecremented PC when using SEH

Author: Martin Storsjö Date: 2022-06-06T23:25:24+03:00 New Revision: 08d30c602bcf3bc25a02938f2663a1b9e96a7cbe URL: https://github.com/llvm/llvm-project/commit/08d30c602bcf3bc25a02938f2663a1b9e96a7cbe DIFF: https://github.com/llvm/llvm-project/commit/08d30c602bcf3bc25a02938f2663a1b9e96a7cbe.diff

[clang] fcb784d - [clang] [MinGW] Default to WinEH (SEH) exception handling instead of Dwarf

Author: Martin Storsjö Date: 2022-06-06T23:27:31+03:00 New Revision: fcb784db496137fa29a11b7e106efe89c7550e11 URL: https://github.com/llvm/llvm-project/commit/fcb784db496137fa29a11b7e106efe89c7550e11 DIFF: https://github.com/llvm/llvm-project/commit/fcb784db496137fa29a11b7e106efe89c7550e11.diff

[PATCH] D126871: [clang] [MinGW] Use SEH for unwind info on ARM by default

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGfcb784db4961: [clang] [MinGW] Default to WinEH (SEH) exception handling instead of Dwarf (authored by mstorsjo). Changed prior to commit: https://

[PATCH] D127145: [Driver] add -lresolv for all but Android.

vitalybuka added a comment. yes, however I have no idea if we need !TC.getTriple().isOSFreeBSD() !TC.getTriple().isOSNetBSD() !TC.getTriple().isOSOpenBSD()) etc. I guess if make mistake it will be noticed and fixed. Please update clang/test/Driver/sanitizer-ld.c Repository: rG LLVM Gi

[PATCH] D127145: [Driver] add -lresolv for all but Android.

MaskRay accepted this revision. MaskRay added inline comments. This revision is now accepted and ready to land. Herald added a subscriber: StephenFan. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:843 + if (!TC.getTriple().isAndroid()) { +CmdArgs.push_back("-lresolv

[PATCH] D127150: [doc] Add release notes about SEH unwind information on ARM

mstorsjo created this revision. mstorsjo added reviewers: efriedma, MaskRay. Herald added subscribers: StephenFan, kristof.beyls. Herald added a project: All. mstorsjo requested review of this revision. Herald added projects: clang, LLVM. Repository: rG LLVM Github Monorepo https://reviews.llvm

[PATCH] D127145: [Driver] add -lresolv for all but Android.

eugenis added a comment. The interceptor (dn_expand) is only defined on linux && !android, while this code links libresolv on *bsd and others, too. I think it's ok, as long as all platforms with the interceptor are covered. It would be great to mention the actual reason we do this in the commit

[PATCH] D75277: [WebAssembly] Remove restriction on main name mangling

sbc100 updated this revision to Diff 434605. sbc100 added a comment. - rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75277/new/ https://reviews.llvm.org/D75277 Files: clang/lib/AST/Mangle.cpp clang/lib/CodeGen/CodeGenModule.cpp Index:

[PATCH] D127150: [doc] Add release notes about SEH unwind information on ARM

MaskRay added inline comments. Comment at: clang/docs/ReleaseNotes.rst:357 + +- Switched MinGW mode on ARM to use SEH instead of Dwarf for unwind information. + The official spelling is `DWARF`. The official way to name the version is `DWARF version 5`. If abbr

[PATCH] D75277: [WebAssembly] Remove restriction on main name mangling

sbc100 added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:6360 + auto *GA = llvm::GlobalAlias::create("__main_void", F); + GA->setVisibility(F->getVisibility()); +} sbc100 wrote: > sunfish wrote: > > sbc100 wrote: > > > sunfish w

[clang] 47039a1 - [WebAssembly] Remove restriction on main name mangling

Author: Sam Clegg Date: 2022-06-06T14:04:27-07:00 New Revision: 47039a1a4b299c01dfa0ec531fbc0d24718bb8eb URL: https://github.com/llvm/llvm-project/commit/47039a1a4b299c01dfa0ec531fbc0d24718bb8eb DIFF: https://github.com/llvm/llvm-project/commit/47039a1a4b299c01dfa0ec531fbc0d24718bb8eb.diff LOG

[PATCH] D75277: [WebAssembly] Remove restriction on main name mangling

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG47039a1a4b29: [WebAssembly] Remove restriction on main name mangling (authored by sbc100). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

  1   2   >