[PATCH] D126974: [scan-build-py] Fix exception on shutdown with sarif-html output format

wanders created this revision. wanders added reviewers: phosek, isthismyaccount. Herald added a subscriber: whisperity. Herald added a project: All. wanders requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. When running scan-build-py's analyz

[PATCH] D126969: Allow use of an elaborated type specifier in a _Generic association in C++

aaron.ballman marked an inline comment as done. aaron.ballman added inline comments. Comment at: clang/include/clang/Sema/DeclSpec.h:2068 case DeclaratorContext::TrailingReturnVar: +case DeclaratorContext::Association: return false; erichkeane wro

[PATCH] D126291: [flang][Driver] Update link job on windows

mstorsjo added a comment. In D126291#3556096 , @mmuetzel wrote: > The error message I get without `-lc++`: > > ld.lld: error: undefined symbol: std::__1::mutex::lock() > >>> referenced by > libFortranRuntime.a(io-api.cpp.obj):(Fortran::runtime::io::I

[PATCH] D126972: [clang][dataflow] Modify `optional` model to handle type aliases.

ymandel added a comment. In D126972#3556230 , @xazax.hun wrote: > This patch looks good to me. On the other hand, I was wondering whether > functions like this would be handled: > > pair f(); > array g(); > MyStructWithOptionals h(); > > And so on.

[PATCH] D126969: Allow use of an elaborated type specifier in a _Generic association in C++

erichkeane accepted this revision. erichkeane added inline comments. This revision is now accepted and ready to land. Comment at: clang/include/clang/Sema/DeclSpec.h:2068 case DeclaratorContext::TrailingReturnVar: +case DeclaratorContext::Association: return false

[PATCH] D126973: [clang][dataflow] Relax assumption that `AggregateStorageLocations` correspond to struct type.

xazax.hun added a comment. Does this mean you want to use `StructValue`s for non-struct types to have access to properties? I wonder if it would be a cleaner approach to be able to assign properties to any type of values instead of weakening the type system. E.g., properties could be a table on

[PATCH] D115844: [ubsan] Using metadata instead of prologue data for function sanitizer

ychen added inline comments. Herald added subscribers: jsji, Enna1. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:1843 + + auto *FTRTTIProxy = new llvm::GlobalVariable( + TheModule, Addr->getType(), pcc wrote: > ychen wrote: > > pcc wrote: > > > Are these

[PATCH] D125919: Drop qualifiers from return types in C (DR423)

rjmccall added a comment. Are you now arguing that C was wrong to drop qualifiers in return types and so we shouldn't implement that rule, or...? Because your argument is much broader than just `_Atomic`. I don't understand the analogy you're making to `_Complex` at all. Values of type `_Com

[PATCH] D126396: Clean "./" from __FILE__ expansion.

MaskRay added a comment. Is it feasible to add a test? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126396/new/ https://reviews.llvm.org/D126396 ___ cfe-commits mailing list cfe-commits@lists.llvm.org h

[PATCH] D126291: [flang][Driver] Update link job on windows

mmuetzel added a comment. With this additional change, I no longer need the `-lc++` flag: From 62920169c43de27569ecae9ba0ec0fe4ec01633a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Markus=20M=C3=BCtzel?= Date: Fri, 3 Jun 2022 19:17:34 +0200 Subject: [PATCH] lock without on Windows ---

[PATCH] D126973: [clang][dataflow] Relax assumption that `AggregateStorageLocations` correspond to struct type.

ymandel added a comment. In D126973#3556312 , @xazax.hun wrote: > Does this mean you want to use `StructValue`s for non-struct types to have > access to properties? I wonder if it would be a cleaner approach to be able > to assign properties to any type

[PATCH] D125919: Drop qualifiers from return types in C (DR423)

delcypher added a comment. @aaron.ballman >> Sorry if these are silly questions and if I've misunderstood something, I >> saw n1863 say "functions return unqualified types" and I was very surprised. > > These are not at all silly questions, so thank you for asking them! Thanks for taking the ti

[PATCH] D125919: Drop qualifiers from return types in C (DR423)

aaron.ballman added a comment. In D125919#3556319 , @rjmccall wrote: > Are you now arguing that C was wrong to drop qualifiers in return types and > so we shouldn't implement that rule, or...? Because your argument is much > broader than just `_Atomic`

[PATCH] D125919: Drop qualifiers from return types in C (DR423)

delcypher added a comment. @rjmccall >> Sorry if these are silly questions and if I've misunderstood something, I >> saw n1863 say "functions return unqualified types" and I was very surprised. > > Just to be clear, you understand that this is only about top-level qualifiers > on the return typ

[PATCH] D125919: Drop qualifiers from return types in C (DR423)

aaron.ballman added a comment. In D125919#3556405 , @delcypher wrote: > @aaron.ballman > >>> Sorry if these are silly questions and if I've misunderstood something, I >>> saw n1863 say "functions return unqualified types" and I was very surprised. >> >>

[PATCH] D126892: [NFC] Fix issue on CMake Xcode build configuration.

rastogishubham added a comment. Hi! This seems to work just fine. LGTM! Shubham Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126892/new/ https://reviews.llvm.org/D126892 ___ cfe-commits mailing list

[clang] 436fef2 - [NFC] Fix issue on CMake Xcode build configuration.

Author: python3kgae Date: 2022-06-03T11:03:02-07:00 New Revision: 436fef21efe35833622c71da705a9a50db246294 URL: https://github.com/llvm/llvm-project/commit/436fef21efe35833622c71da705a9a50db246294 DIFF: https://github.com/llvm/llvm-project/commit/436fef21efe35833622c71da705a9a50db246294.diff L

[PATCH] D126892: [NFC] Fix issue on CMake Xcode build configuration.

This revision was automatically updated to reflect the committed changes. Closed by commit rG436fef21efe3: [NFC] Fix issue on CMake Xcode build configuration. (authored by python3kgae). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126892/new/ https

[PATCH] D126929: Add sanitizer metadata attributes to clang IR gen.

kstoimenov added inline comments. Comment at: clang/lib/CodeGen/SanitizerMetadata.cpp:48-50 + GVSanitizerMetadata Meta; + if (GV->hasSanitizerMetadata()) +Meta = GV->getSanitizerMetadata(); Would it make sense to create two separate functions something like

[PATCH] D126973: [clang][dataflow] Relax assumption that `AggregateStorageLocations` correspond to struct type.

xazax.hun accepted this revision. xazax.hun added a comment. This revision is now accepted and ready to land. In D126973#3556383 , @ymandel wrote: > I'm generally hesitant about assertions that don't enforce necessary > properties (only "nice"). I think

[PATCH] D126944: [Clang] Fix memory leak due to TemplateArgumentListInfo used in AST node.

browneee updated this revision to Diff 434075. browneee added a comment. Remove auto used under clang/. Format. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126944/new/ https://reviews.llvm.org/D126944 Files: clang-tools-extra/clangd/AST.cpp

[PATCH] D126969: Allow use of an elaborated type specifier in a _Generic association in C++

aaron.ballman marked an inline comment as done. aaron.ballman added a comment. Thanks for the reviews @erichkeane! I'll probably land this on Monday just in case @jyknight has comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126969/new/ htt

[PATCH] D126984: [clang] Add initial support for gcc's optimize function attribute

steplong created this revision. Herald added a reviewer: aaron.ballman. Herald added a project: All. steplong requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. At the moment, it only supports a string argument that refers to the optimization

[PATCH] D126731: [pseudo] Eliminate dependencies from clang-pseudo-gen. NFC

sammccall added inline comments. Comment at: clang-tools-extra/pseudo/lib/grammar/Grammar.cpp:10 #include "clang-pseudo/Grammar.h" #include "clang/Basic/TokenKinds.h" #include "llvm/ADT/ArrayRef.h" hokein wrote: > Add a trailing comment `// for clang::tok::Tok

[PATCH] D126984: [clang] Add initial support for gcc's optimize function attribute

steplong added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:2169 +HasOptnone = TargetDecl->hasAttr() || + (TargetDecl->hasAttr() && + TargetDecl->getAttr()->getLevel() == "0"); I don't think this is the most ergon

[clang-tools-extra] dc63ad8 - [pseudo] Eliminate dependencies from clang-pseudo-gen. NFC

Author: Sam McCall Date: 2022-06-03T20:42:38+02:00 New Revision: dc63ad8878de6d0b5dc1268691f48035e9234763 URL: https://github.com/llvm/llvm-project/commit/dc63ad8878de6d0b5dc1268691f48035e9234763 DIFF: https://github.com/llvm/llvm-project/commit/dc63ad8878de6d0b5dc1268691f48035e9234763.diff LO

[PATCH] D126731: [pseudo] Eliminate dependencies from clang-pseudo-gen. NFC

This revision was automatically updated to reflect the committed changes. Closed by commit rGdc63ad8878de: [pseudo] Eliminate dependencies from clang-pseudo-gen. NFC (authored by sammccall). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126731/new/

[clang-tools-extra] a43fef0 - [pseudo] rename pseudo-gen -> clang-pseudo-gen. NFC

Author: Sam McCall Date: 2022-06-03T20:45:48+02:00 New Revision: a43fef05d4fae32f02365c7b8fef2aa631d23628 URL: https://github.com/llvm/llvm-project/commit/a43fef05d4fae32f02365c7b8fef2aa631d23628 DIFF: https://github.com/llvm/llvm-project/commit/a43fef05d4fae32f02365c7b8fef2aa631d23628.diff LO

[PATCH] D126725: [pseudo] rename pseudo-gen -> clang-pseudo-gen. NFC

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa43fef05d4fa: [pseudo] rename pseudo-gen -> clang-pseudo-gen. NFC (authored by sammccall). Changed prior to commit: https://reviews.llvm.org/D1267

[PATCH] D126717: [pseudo] Add PSEUDO_GEN cmake cache variable to avoid nested CMake invocation

sammccall added a comment. Renamed to CLANG_PSEUDO_GEN, landing now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126717/new/ https://reviews.llvm.org/D126717 ___ cfe-commits mailing list cfe-commits@li

[clang-tools-extra] 830d158 - [pseudo] Add CLANG_PSEUDO_GEN cmake cache variable to avoid nested CMake invocation

Author: Sam McCall Date: 2022-06-03T20:48:55+02:00 New Revision: 830d158d2b7d2fa45f39fe12aa0b2ffc70c7e771 URL: https://github.com/llvm/llvm-project/commit/830d158d2b7d2fa45f39fe12aa0b2ffc70c7e771 DIFF: https://github.com/llvm/llvm-project/commit/830d158d2b7d2fa45f39fe12aa0b2ffc70c7e771.diff LO

[PATCH] D126717: [pseudo] Add PSEUDO_GEN cmake cache variable to avoid nested CMake invocation

This revision was automatically updated to reflect the committed changes. Closed by commit rG830d158d2b7d: [pseudo] Add CLANG_PSEUDO_GEN cmake cache variable to avoid nested CMake… (authored by sammccall). Changed prior to commit: https://reviews.llvm.org/D126717?vs=433164&id=434094#toc Reposi

[clang] 6adfc64 - [clang][dataflow] Modify `optional` model to handle type aliases.

Author: Yitzhak Mandelbaum Date: 2022-06-03T18:57:43Z New Revision: 6adfc64e709cc8b7b7a06b0e9afc60f6903f3cab URL: https://github.com/llvm/llvm-project/commit/6adfc64e709cc8b7b7a06b0e9afc60f6903f3cab DIFF: https://github.com/llvm/llvm-project/commit/6adfc64e709cc8b7b7a06b0e9afc60f6903f3cab.diff

[PATCH] D126972: [clang][dataflow] Modify `optional` model to handle type aliases.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6adfc64e709c: [clang][dataflow] Modify `optional` model to handle type aliases. (authored by ymandel). Repository: rG LLVM Github Monorepo CHANGE

[PATCH] D126291: [flang][Driver] Update link job on windows

awarzynski added a comment. In D126291#3556324 , @mmuetzel wrote: > With this additional change, I no longer need the `-lc++` flag: Great find, thanks for digging! > Someone should check if that change is sane. But it seems to work for me > (with the "

[PATCH] D126991: [pseudo] Fix the member-specification grammar rule.

hokein created this revision. hokein added a reviewer: sammccall. Herald added a project: All. hokein requested review of this revision. Herald added a subscriber: alextsao1999. Herald added a project: clang-tools-extra. The grammar rule is not right, doesn't match the standard one. Repository:

[PATCH] D125517: [Frontend] [Coroutines] Emit error when we found incompatible allocation function in promise_type

rsmith added inline comments. Comment at: clang/lib/Sema/SemaCoroutine.cpp:1312 + + bool PromiseContainNew = [this, &PromiseType]() -> bool { +DeclarationName NewName = Nit, should be `PromiseContainsNew`. Comment at: clang/lib/Sema/SemaCo

[PATCH] D126723: [pseudo] GC GSS nodes, reuse them with a freelist

sammccall updated this revision to Diff 434103. sammccall marked 6 inline comments as done. sammccall added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126723/new/ https://reviews.llvm.org/D126723 Files: clang-tools

[PATCH] D126723: [pseudo] GC GSS nodes, reuse them with a freelist

sammccall marked an inline comment as done. sammccall added inline comments. Comment at: clang-tools-extra/pseudo/lib/GLR.cpp:391 + llvm::ArrayRef Parents) { + ++NodeCount; + Node *Result = new (allocate(Parents.size())) hokein wrot

[PATCH] D126291: [flang][Driver] Update link job on windows

mstorsjo added a comment. In D126291#3556324 , @mmuetzel wrote: > With this additional change, I no longer need the `-lc++` flag: > > From 965343d8b05bf3cf7a9a3873ea4d2ddcc00a3703 Mon Sep 17 00:00:00 2001 > From: =?UTF-8?q?Markus=20M=C3=BCtzel?= >

[PATCH] D126992: [pseudo] Fix noptr-abstract-declarator rule.

hokein created this revision. hokein added a reviewer: sammccall. Herald added a project: All. hokein requested review of this revision. Herald added a subscriber: alextsao1999. Herald added a project: clang-tools-extra. The const-expression in the [] can be empty. Repository: rG LLVM Github M

[PATCH] D126992: [pseudo] Fix noptr-abstract-declarator rule.

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/pseudo/test/cxx/abstract-declarator.cpp:1 +// RUN: clang-pseudo -grammar=%cxx-bnf-file -source=%s --print-forest | FileCheck %s +void

[PATCH] D125919: Drop qualifiers from return types in C (DR423)

rsmith added a comment. In D125919#3556418 , @aaron.ballman wrote: > In D125919#3556319 , @rjmccall > wrote: > >> Now, the standard has chosen not to talk about `_Atomic` as a qualifier, I >> assume because the

[PATCH] D126719: [clang-cl] Add support for /kernel

steplong updated this revision to Diff 434107. steplong added a comment. - Change to SupportedArches.insert() - Add logic that errors if /kernel and /GR - Add test for /kernel and /EHsc (silently override /EHsc. Only errors when trying to use exceptions in src code) and /kernel and /GR (fails wit

[PATCH] D126781: [CodeGen] Keep track info of lazy-emitted symbols in ModuleBuilder

rsmith added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.h:1480-1482 + llvm::SmallPtrSetImpl &getEmittedDeferredDecls() { +return EmittedModuleInitializers; + } This function name doesn't match its implementation. Comment

[PATCH] D126996: [pseudo] Handle the language predefined identifier __func__

hokein created this revision. hokein added a reviewer: sammccall. Herald added a project: All. hokein requested review of this revision. Herald added a subscriber: alextsao1999. Herald added a project: clang-tools-extra. The clang lexer lexes it as a dedicated token kind (rather than identifier),

[PATCH] D126341: Order implicitly instantiated global variable's initializer by the reverse instantiation order

ychen added a comment. In D126341#3554286 , @rnk wrote: > Well, I guess we're out of luck, but that seems like a very poorly considered > requirement from the standard. If we can't use comdats for inline variables, > every time you include a header with

[PATCH] D125919: Drop qualifiers from return types in C (DR423)

jyknight added a comment. In D125919#3556754 , @rsmith wrote: > That assumption does not hold. Given `struct A { char c[3]; };`, `struct A` > has size 3 and align 1, but `_Atomic struct A` has size 4 and align 4 across > many (perhaps all?) of our targe

[PATCH] D126998: [pseudo] Fix the type-parameter rule.

hokein created this revision. hokein added a reviewer: sammccall. Herald added a project: All. hokein requested review of this revision. Herald added a subscriber: alextsao1999. Herald added a project: clang-tools-extra. The IDENTIFIER should be optional. Repository: rG LLVM Github Monorepo h

[PATCH] D113107: Support of expression granularity for _Float16.

zahiraam added a comment. In D113107#3554538 , @rjmccall wrote: > Hmm. I'm sorry, seeing the impact of this, I think it's not great to have > this `PromotionTy` field; it's too hard to get the invariants right. Let's do > this instead: > > 1. Add an `E

[PATCH] D126291: [flang][Driver] Update link job on windows

mmuetzel added a comment. In D126291#3556725 , @mstorsjo wrote: > This looks mostly reasonable, but I'd recommend using a windows critical > section instead of a mutex - a critical section doesn't invoke the kernel > when there's no contention of the lo

[PATCH] D124749: [clang-format] Handle Verilog preprocessor directives

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/FormatTokenLexer.cpp:1121 + const char *Start = Lex->getBufferLocation(); + if (!VerilogToken.match(StringRef(Start, Lex->getBuffer().end() - Start), + &Matches)) Ad

[PATCH] D126719: [clang-cl] Add support for /kernel

steplong updated this revision to Diff 434122. steplong added a comment. - Whoops missed a "/" in the test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126719/new/ https://reviews.llvm.org/D126719 Files: clang/include/clang/Basic/LangOptions.de

[PATCH] D126364: Fix interaction of pragma FENV_ACCESS with other pragmas

efriedma added a comment. Given we have getEffectiveRoundingMode(), I think the calls to setRoundingModeOverride shouldn't be necessary? And if we drop those calls, we can also drop the IsRoundingModeSet variable. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revi

[PATCH] D126998: [pseudo] Fix the type-parameter rule.

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/pseudo/test/cxx/template-noid-type-parameter.cpp:1 +// RUN: clang-pseudo -grammar=%cxx-bnf-file -source=%s --print-forest | FileCheck

[PATCH] D125165: [Clang] Introduce clang-offload-packager tool to bundle device files

tra added a comment. @jhuber6 -- @MaskRay has found that `ninja install` is failing in a clean build with: clang: error: unable to execute command: Executable "clang-offload-packager" doesn't exist! It looks like a missing dependency somewhere. Repository: rG LLVM Github Monorepo CHANG

[PATCH] D126944: [Clang] Fix memory leak due to TemplateArgumentListInfo used in AST node.

browneee updated this revision to Diff 434135. browneee marked 3 inline comments as done. browneee added a comment. Formatting. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126944/new/ https://reviews.llvm.org/D126944 Files: clang-tools-extra/c

[PATCH] D126944: [Clang] Fix memory leak due to TemplateArgumentListInfo used in AST node.

browneee added inline comments. Comment at: clang/include/clang/AST/DeclTemplate.h:2776 void setTemplateArgsInfo(const TemplateArgumentListInfo &ArgsInfo); + void setTemplateArgsInfo(const ASTTemplateArgumentListInfo *ArgsInfo); aaron.ballman wrote: > Can w

[PATCH] D125165: [Clang] Introduce clang-offload-packager tool to bundle device files

jhuber6 added a comment. In D125165#3557015 , @tra wrote: > @jhuber6 -- @MaskRay has found that `ninja install` is failing in a clean > build with: > > clang: error: unable to execute command: Executable > "clang-offload-packager" doesn't exist! > >

[PATCH] D126929: Add sanitizer metadata attributes to clang IR gen.

hctim marked an inline comment as done. hctim added inline comments. Comment at: clang/lib/CodeGen/SanitizerMetadata.cpp:48-50 + GVSanitizerMetadata Meta; + if (GV->hasSanitizerMetadata()) +Meta = GV->getSanitizerMetadata(); kstoimenov wrote: > Would it mak

[PATCH] D126929: Add sanitizer metadata attributes to clang IR gen.

kstoimenov added inline comments. Comment at: clang/lib/CodeGen/SanitizerMetadata.cpp:48-50 + GVSanitizerMetadata Meta; + if (GV->hasSanitizerMetadata()) +Meta = GV->getSanitizerMetadata(); hctim wrote: > kstoimenov wrote: > > Would it make sense to create

[PATCH] D126158: [MLIR][GPU] Replace fdiv on fp16 with promoted (fp32) multiplication with reciprocal plus one (conditional) Newton iteration.

csigg updated this revision to Diff 434142. csigg added a comment. Fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126158/new/ https://reviews.llvm.org/D126158 Files: mlir/include/mlir/Dialect/LLVMIR/NVVMOps.td mlir/include/mlir/Dialect/LLV

[PATCH] D125936: [Sema] Relax an assertion in BuildStmtExpr

ahatanak updated this revision to Diff 434144. ahatanak added a comment. Add a flag to `StmtExpr` that indicates whether it needs cleanup. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125936/new/ https://reviews.llvm.org/D125936 Files: clang/in

[PATCH] D126929: Add sanitizer metadata attributes to clang IR gen.

hctim updated this revision to Diff 434145. hctim marked 2 inline comments as done. hctim added a comment. Herald added subscribers: llvm-commits, ormris, jdoerfert, steven_wu, hiraditya. Herald added a project: LLVM. Add TODO() comments from Kirill's notes. Repository: rG LLVM Github Monorepo

[clang] 1257fe1 - [Clang] Change the offload packager build to be a clang tool

Author: Joseph Huber Date: 2022-06-03T17:35:26-04:00 New Revision: 1257fe193a35b3b3ee8ccc5987f376b0b6dc21ea URL: https://github.com/llvm/llvm-project/commit/1257fe193a35b3b3ee8ccc5987f376b0b6dc21ea DIFF: https://github.com/llvm/llvm-project/commit/1257fe193a35b3b3ee8ccc5987f376b0b6dc21ea.diff

[PATCH] D125165: [Clang] Introduce clang-offload-packager tool to bundle device files

jhuber6 added a comment. In D125165#3557015 , @tra wrote: > @jhuber6 -- @MaskRay has found that `ninja install` is failing in a clean > build with: > > clang: error: unable to execute command: Executable > "clang-offload-packager" doesn't exist! > >

[PATCH] D126324: [clang] Allow const variables with weak attribute to be overridden

This revision was automatically updated to reflect the committed changes. wanders marked 2 inline comments as done. Closed by commit rGdd2362a8bab3: [clang] Allow const variables with weak attribute to be overridden (authored by wanders). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang] dd2362a - [clang] Allow const variables with weak attribute to be overridden

Author: Anders Waldenborg Date: 2022-06-03T23:44:15+02:00 New Revision: dd2362a8bab312dffc42bfcb30ad1340840ef581 URL: https://github.com/llvm/llvm-project/commit/dd2362a8bab312dffc42bfcb30ad1340840ef581 DIFF: https://github.com/llvm/llvm-project/commit/dd2362a8bab312dffc42bfcb30ad1340840ef581.d

[PATCH] D127005: [clang-format][NFC] Clean up the unwrapped line parser

owenpan created this revision. owenpan added reviewers: curdeius, HazardyKnusperkeks, MyDeveloperDay. owenpan added a project: clang-format. Herald added a project: All. owenpan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Change the int

[PATCH] D127006: [pseudo] Invert rows/columns of LRTable storage for speedup. NFC

sammccall created this revision. sammccall added a reviewer: hokein. Herald added a project: All. sammccall requested review of this revision. Herald added subscribers: cfe-commits, alextsao1999. Herald added a project: clang-tools-extra. There are more states than symbols. This means first partio

[PATCH] D126929: Add sanitizer metadata attributes to clang IR gen.

kstoimenov accepted this revision. kstoimenov added a comment. This revision is now accepted and ready to land. Please get approval from vitalybuka@ before submitting. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126929/new/ https://reviews.llvm.o

[PATCH] D127008: [clang][dataflow] Fix filename typos in tests

samestep created this revision. Herald added subscribers: tschuett, steakhal, xazax.hun. Herald added a project: All. samestep requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D

[PATCH] D126100: Add sanitizer-specific GlobalValue attributes.

vitalybuka added inline comments. Comment at: llvm/include/llvm/AsmParser/LLToken.h:429 + // Extra sanitizer attributes that are used for global variables (GV's). + // GV's mentioned in -fsanitize-ignorelist=. + kw_no_sanitize, it should be next to other kw_ s

[PATCH] D126929: Add sanitizer metadata attributes to clang IR gen.

vitalybuka requested changes to this revision. vitalybuka added a comment. This revision now requires changes to proceed. Can you please rebase this patch onto others two? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126929/new/ https://reviews.ll

[PATCH] D127009: Modify test case so it verifies the fix from D126396.

ppluzhnikov created this revision. ppluzhnikov added a reviewer: MaskRay. Herald added a subscriber: StephenFan. Herald added a project: All. ppluzhnikov requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo

[PATCH] D126396: Clean "./" from __FILE__ expansion.

ppluzhnikov added a comment. In D126396#3556321 , @MaskRay wrote: > Is it feasible to add a test? Sure. I extended the existing tests added in https://reviews.llvm.org/D122766 to cover this. https://reviews.llvm.org/D127009 Repository: rG LLVM Githu

[PATCH] D126536: [pseudo] Add grammar annotations support.

sammccall added a comment. Thanks, this looks better. Sorry about confusion with the names - I think annotation is a great name, and we should only use "extension" for the narrower "opaque thing that an annotation value refers to". Happy to chat about this offline if you like

[PATCH] D125165: [Clang] Introduce clang-offload-packager tool to bundle device files

MaskRay added a comment. Add openmp to `LLVM_ENABLE_PROJECTS` to trigger the issue: cmake -GNinja -Sllvm -B/tmp/out/play -DCMAKE_BUILD_TYPE=Release -DLLVM_ENABLE_PROJECTS='clang;openmp' -DCMAKE_CXX_COMPILER=~/Stable/bin/clang++ -DCMAKE_C_COMPILER=~/Stable/bin/clang -DCMAKE_INSTALL_PREFIX=/tmp

[PATCH] D127008: [clang][dataflow] Fix filename typos in tests

ymandel accepted this revision. ymandel added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127008/new/ https://reviews.llvm.org/D127008 __

[PATCH] D127009: Modify test case so it verifies the fix from D126396.

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. Thanks! The convention is to add `[test] ` to test-only patches. You can change the Phabricator title, then run `arc amend` to amend the local commit. I believe on Debian testing `arc` is so

[PATCH] D126757: Fix clang RecursiveASTVisitor for definition of XXXTemplateSpecializationDecl

daiyousei-qz updated this revision to Diff 434196. daiyousei-qz marked an inline comment as done. daiyousei-qz added a comment. squashed commits. updated comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126757/new/ https://reviews.llvm.org/D

[PATCH] D127009: Modify test case so it verifies the fix from D126396.

ppluzhnikov updated this revision to Diff 434198. ppluzhnikov marked an inline comment as done. ppluzhnikov added a comment. Add comment and suppress clang-format. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127009/new/ https://reviews.llvm.org/D

[PATCH] D125165: [Clang] Introduce clang-offload-packager tool to bundle device files

jhuber6 added a comment. In D125165#3557441 , @MaskRay wrote: > Add openmp to `LLVM_ENABLE_PROJECTS` to trigger the issue: > > cmake -GNinja -Sllvm -B/tmp/out/play -DCMAKE_BUILD_TYPE=Release > -DLLVM_ENABLE_PROJECTS='clang;openmp' > -DCMAKE_CXX_COMPIL

[PATCH] D127009: Modify test case so it verifies the fix from D126396.

ppluzhnikov updated this revision to Diff 434199. ppluzhnikov added a comment. Make comment better. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127009/new/ https://reviews.llvm.org/D127009 Files: clang/test/Preprocessor/file_test.c Index: cl

[PATCH] D126757: Fix clang RecursiveASTVisitor for definition of XXXTemplateSpecializationDecl

rsmith added inline comments. Comment at: clang/include/clang/AST/RecursiveASTVisitor.h:2040 + /* Traverse base definition for explicit specializations */ \ + TRY_TO(Traverse##DECLKIND##Helper(D)); \ +} else {

[libunwind] 53c1584 - [NFC] [libunwind] turn assert into static_assert

Author: Florian Mayer Date: 2022-06-03T16:32:42-07:00 New Revision: 53c1584063e8f3225bfe71724cc7de79576ea61a URL: https://github.com/llvm/llvm-project/commit/53c1584063e8f3225bfe71724cc7de79576ea61a DIFF: https://github.com/llvm/llvm-project/commit/53c1584063e8f3225bfe71724cc7de79576ea61a.diff

[PATCH] D127009: [test] Modify test case so it verifies the fix from D126396

ppluzhnikov updated this revision to Diff 434202. ppluzhnikov added a comment. Update. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127009/new/ https://reviews.llvm.org/D127009 Files: clang/test/Preprocessor/file_test.c Index: clang/test/Prep

[PATCH] D127009: [test] Modify test case so it verifies the fix from D126396

ppluzhnikov added a comment. I think I've done the cleanups requested. If this looks good, please push it (I don't have commit rights). Thanks, Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127009/new/ https://reviews.llvm.org/D127009 __

[PATCH] D125847: LTO: Add option to initialize with opaque/non-opaque pointer types

Jake-Egan added a comment. In D125847#3554706 , @MatzeB wrote: > In D125847#3554569 , @Jake-Egan > wrote: > >> Hi, this caused `arm-float-abi-lto.c` to fail on AIX. The failure went away >> for a few builds, the

[PATCH] D126757: Fix clang RecursiveASTVisitor for definition of XXXTemplateSpecializationDecl

rsmith added inline comments. Comment at: clang/include/clang/AST/RecursiveASTVisitor.h:2040 + /* Traverse base definition for explicit specializations */ \ + TRY_TO(Traverse##DECLKIND##Helper(D)); \ +} else {

[PATCH] D127036: [clang-tidy] Warn about arrays in `bugprone-undefined-memory-manipulation`

fwolff created this revision. fwolff added reviewers: aaron.ballman, njames93, alexfh. fwolff added a project: clang-tools-extra. Herald added subscribers: carlosgalvezp, xazax.hun. Herald added a project: All. fwolff requested review of this revision. Herald added a subscriber: cfe-commits. Fixes

[PATCH] D125165: [Clang] Introduce clang-offload-packager tool to bundle device files

MaskRay added a comment. In D125165#3557693 , @jhuber6 wrote: > In D125165#3557441 , @MaskRay wrote: > >> Add openmp to `LLVM_ENABLE_PROJECTS` to trigger the issue: >> >> cmake -GNinja -Sllvm -B/tmp/out/play -DC

[PATCH] D127009: [test] Modify test case so it verifies the fix from D126396

This revision was automatically updated to reflect the committed changes. Closed by commit rG490990bb1f65: [test] Modify test to verify D126396 (Clean "./" from __FILE__ expansion) (authored by ppluzhnikov, committed by MaskRay). Changed prior to commit: https://reviews.llvm.org/D127009?vs=434

[clang] 490990b - [test] Modify test to verify D126396 (Clean "./" from __FILE__ expansion)

Author: Paul Pluzhnikov Date: 2022-06-03T17:54:03-07:00 New Revision: 490990bb1f6578276ae7675f09e26e6c6bd3f59a URL: https://github.com/llvm/llvm-project/commit/490990bb1f6578276ae7675f09e26e6c6bd3f59a DIFF: https://github.com/llvm/llvm-project/commit/490990bb1f6578276ae7675f09e26e6c6bd3f59a.dif

[PATCH] D127040: [InstrProf][WIP] Implement boolean counters in coverage

gulfem created this revision. Herald added subscribers: ellis, wenlei, hiraditya. Herald added a project: All. gulfem requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. This patch inserts 1-byte boolean counters instead of an

[PATCH] D126586: [InstrProf][WIP] Implement boolean counters in coverage

gulfem updated this revision to Diff 434224. gulfem added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Describe the high-level changes to adding and subtracting counters. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[clang] c3c75d8 - [clang][test] Mark test arm-float-abi-lto.c unsupported on AIX

Author: Jake Egan Date: 2022-06-03T21:04:56-04:00 New Revision: c3c75d805c2174388417080f762230961b3433d6 URL: https://github.com/llvm/llvm-project/commit/c3c75d805c2174388417080f762230961b3433d6 DIFF: https://github.com/llvm/llvm-project/commit/c3c75d805c2174388417080f762230961b3433d6.diff LOG

[PATCH] D126100: Add sanitizer-specific GlobalValue attributes.

hctim marked 7 inline comments as done. hctim added inline comments. Comment at: llvm/include/llvm/AsmParser/LLToken.h:429 + // Extra sanitizer attributes that are used for global variables (GV's). + // GV's mentioned in -fsanitize-ignorelist=. + kw_no_sanitize, --

[PATCH] D126100: Add sanitizer-specific GlobalValue attributes.

hctim updated this revision to Diff 434228. hctim marked 4 inline comments as done. hctim added a comment. Update from Vitaly's comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126100/new/ https://reviews.llvm.org/D126100 Files: llvm/incl

[PATCH] D127042: [Clang][OpenMP] Enable floating-point operation for `atomic compare` series

tianshilei1992 created this revision. tianshilei1992 added reviewers: jdoerfert, ABataev. Herald added subscribers: guansong, hiraditya, yaxunl. Herald added a project: All. tianshilei1992 requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, sstefan1. Herald added

<    1   2   3   >