[PATCH] D120540: [Driver] Enable to use C++20 modules standalone by -fcxx-modules

aprantl added a comment. I think the problem might be that previously on Darwin `-fcxx-modules` was used to turn on C++ Clang modules (which was not implied by `-fmodules`) without turning of C++20 (ts) modules, and after this patch `-fcxx-modules` implies `-fmodules-ts`. Does that sound plausi

[PATCH] D120540: [Driver] Enable to use C++20 modules standalone by -fcxx-modules

aprantl added a comment. Should we introduce a `-fno-modules-ts` option on top? Any better suggestions? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120540/new/ https://reviews.llvm.org/D120540 ___ cfe-

[PATCH] D120540: [Driver] Enable to use C++20 modules standalone by -fcxx-modules

aprantl added a comment. In any case, I would appreciate it if we could revert this patch until we found a solution! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120540/new/ https://reviews.llvm.org/D120540 __

[PATCH] D120540: [Driver] Enable to use C++20 modules standalone by -fcxx-modules

iains added a comment. as noted before, IMO this is all a bit tangled at the moment. Probably, a good start would be to make the driver and the FE behave the same way for the flags -- at the moment C++20 jams on fmodules and fcxx-modules (meaning that there's no way to decouple them in the FE)

[PATCH] D126719: [clang-cl] Add support for /kernel

steplong added a comment. In D126719#3548469 , @thakis wrote: > It also says `/kernel` is passed on to the linker. Do you know how the linker distinguishes objects created by /kernel vs non-/kernel? At the moment, we are just using MSVC's linker to link

[PATCH] D126796: [clang][driver] adds `-print-diagnostics`

cjdb created this revision. cjdb added a reviewer: aaron.ballman. Herald added a project: All. cjdb requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. Prints a list of all the warnings that Clang offers. Repository: rG LLVM Github

[PATCH] D126796: [clang][driver] adds `-print-diagnostics`

cjdb added a comment. I haven't added a test because I'm not sure how we can reasonably test this without keeping a file that holds all the warnings and using FileCheck. I'm okay with that, but want to make sure it's the best thing to do. Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[PATCH] D126084: [Sema] Reject implicit conversions between different scoped enum types in list initialization

aaron.ballman added a reviewer: erichkeane. aaron.ballman added a subscriber: erichkeane. aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaInit.cpp:4506 !S.Context.hasSameUnqualifiedType(E->getType(), DestType) && -(E->getType()->isIntegralOrEn

[PATCH] D126796: [clang][driver] adds `-print-diagnostics`

MaskRay added a comment. FYI `diagtool tree` dumps the diagnostics. You can even provide -W options and observe the differences. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126796/new/ https://reviews.llvm.org/D126796 __

[PATCH] D126764: [clang] [ARM] Add __builtin_sponentry like on aarch64

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126764/new/ https://reviews.llvm.org/D126764 ___

[clang] 86f9cf8 - [clang] Add tests for (const) weak variables

Author: Anders Waldenborg Date: 2022-06-01T20:18:54+02:00 New Revision: 86f9cf88cb06d36e37ef8de006b2a0b651c9b7e9 URL: https://github.com/llvm/llvm-project/commit/86f9cf88cb06d36e37ef8de006b2a0b651c9b7e9 DIFF: https://github.com/llvm/llvm-project/commit/86f9cf88cb06d36e37ef8de006b2a0b651c9b7e9.d

[PATCH] D126578: [clang] Add tests for (const) weak variables

This revision was automatically updated to reflect the committed changes. Closed by commit rG86f9cf88cb06: [clang] Add tests for (const) weak variables (authored by wanders). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126578/new/ https://reviews.

[clang] aaf04c7 - Fix an incorrect bit-width for storing attribute syntax information

Author: Aaron Ballman Date: 2022-06-01T14:24:51-04:00 New Revision: aaf04c72159109f37507589ba13ff034b73403c2 URL: https://github.com/llvm/llvm-project/commit/aaf04c72159109f37507589ba13ff034b73403c2 DIFF: https://github.com/llvm/llvm-project/commit/aaf04c72159109f37507589ba13ff034b73403c2.diff

[PATCH] D119051: Extend the C++03 definition of POD to include defaulted functions

dblaikie updated this revision to Diff 433472. dblaikie added a comment. Generalize to handle PS5 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119051/new/ https://reviews.llvm.org/D119051 Files: clang/include/clang/Basic/LangOptions.def clang

[PATCH] D119051: Extend the C++03 definition of POD to include defaulted functions

dblaikie marked 5 inline comments as done. dblaikie added a comment. In D119051#3550653 , @probinson wrote: > I'm in the middle of upstreaming PS5 support and I still didn't think of > this... doh! Ah, right - done! Repository: rG LLVM Github Monore

[PATCH] D125723: [MSVC] Add support for MSVC pragma optimize

steplong added a comment. Appreciate the help! It's not clear to me how to go from the strings "Os", "foo1", "foo2", "foo3" to adding "-Os -ffoo1 -ffoo2 -ffoo3" to the compilation line for that function Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D126291: [flang][Driver] Update link job on windows

mmuetzel added a comment. Just wondering if those changes are correct for MinGW. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:753 + llvm::opt::ArgStringList &CmdArgs) { + if (TC.getTriple().isOSWindows()) { +CmdArgs.push_back("For

[PATCH] D126801: [analyzer][NFC] Add partial specializations for ProgramStateTraits

steakhal created this revision. steakhal added reviewers: NoQ, martong, balazske, ASDenysPetrov. Herald added subscribers: manas, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun. Herald added a reviewer: Szelethus. Herald added a project:

[PATCH] D126802: [analyzer][NFC] Uplift checkers after D126801

steakhal created this revision. steakhal added reviewers: NoQ, martong, ASDenysPetrov. Herald added subscribers: manas, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun. Herald added a reviewer: Szelethus. Herald added a project: All. steak

[PATCH] D126803: [llvm][analyzer][NFC] Introduce SFINAE for specializing FoldingSetTraits

steakhal created this revision. steakhal added reviewers: NoQ, martong, ASDenysPetrov, bzcheeseman. Herald added subscribers: manas, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun. Herald added a reviewer: Szelethus. Herald added a projec

[PATCH] D126804: [scan-build-py] Change scripts to explicitly require python3

wanders created this revision. wanders added reviewers: phosek, sylvestre.ledru. Herald added a subscriber: whisperity. Herald added a project: All. wanders requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The "#!" line in all scan-build-py

[PATCH] D122150: [clang][analyzer] Add checker for bad use of 'errno'.

steakhal added a comment. D126801 should simplify the reinterpret casts. Comment at: clang/include/clang/StaticAnalyzer/Checkers/Checkers.td:558 + InAlpha, + Hide>, // ?? + ]>, I think we ha

[PATCH] D126758: [clang-format] Handle do-while loops for RemoveBracesLLVM

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.h:118-119 TokenType NextLBracesType = TT_Unknown, + bool *HasDoWhile = nullptr, bool *HasLabel = n

[PATCH] D120540: [Driver] Enable to use C++20 modules standalone by -fcxx-modules

aprantl added a comment. I'm going to revert the patch now. This is not just breaking LLDb, but also clang itself on Darwin platforms. I think we need to be more careful to separate out the enabling of Clang C++ modules and C++20 modules. Either by having `-fmodules-ts` control the `HaveModules

[clang] 128ffb3 - Revert "[Driver][Modules] Remove dependence on linking support from clang/test/Driver/modules.cpp"

Author: Adrian Prantl Date: 2022-06-01T12:11:56-07:00 New Revision: 128ffb332bca2c3efae82665b2b557f9b481b83f URL: https://github.com/llvm/llvm-project/commit/128ffb332bca2c3efae82665b2b557f9b481b83f DIFF: https://github.com/llvm/llvm-project/commit/128ffb332bca2c3efae82665b2b557f9b481b83f.diff

[clang] c84b9bb - Revert "[NFC] Use %clang instead of %clang++ in tests"

Author: Adrian Prantl Date: 2022-06-01T12:11:56-07:00 New Revision: c84b9bbac1ecaafb34daa7618b035f063ef1094e URL: https://github.com/llvm/llvm-project/commit/c84b9bbac1ecaafb34daa7618b035f063ef1094e DIFF: https://github.com/llvm/llvm-project/commit/c84b9bbac1ecaafb34daa7618b035f063ef1094e.diff

[clang-tools-extra] d951ca5 - Revert "[Driver] Enable to use C++20 standalne by -fcxx-modules"

Author: Adrian Prantl Date: 2022-06-01T12:11:57-07:00 New Revision: d951ca5439bb8726cfe1ceb2d12e220f29fe5125 URL: https://github.com/llvm/llvm-project/commit/d951ca5439bb8726cfe1ceb2d12e220f29fe5125 DIFF: https://github.com/llvm/llvm-project/commit/d951ca5439bb8726cfe1ceb2d12e220f29fe5125.diff

[PATCH] D126806: Add an overload to ASTUnit::LoadFromASTFile that accepts a virtual file system.

asoffer created this revision. Herald added a project: All. asoffer requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D126806 Files: clang/include/clang/Frontend/ASTUnit.h c

[PATCH] D120540: [Driver] Enable to use C++20 modules standalone by -fcxx-modules

iains added a comment. I guess Chuanqi's TZ is in sleep mode at the moment, so the revert makes sense. Please let's not use -fmodules-ts to mean anything - we want to phase it out and make it a NOP (we are implementing the standardised modules; I do not see anyone putting effort into finishing

[PATCH] D126719: [clang-cl] Add support for /kernel

thakis added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:7620 + else if (Arch == llvm::Triple::x86_64) + UnsupportedArches = {"AVX", "AVX2", "AVX512"}; + Making this list opt-in instead of opt-out (ie "SupportedArchs") seems a bit

[PATCH] D102122: Support warn_unused_result on typedefs

dblaikie updated this revision to Diff 433492. dblaikie marked 4 inline comments as done. dblaikie added a comment. Check through multiple typedef layers to find the warn_unused_result attribute Rephrase unsupported syntax warning Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D126806: Add an overload to ASTUnit::LoadFromASTFile that accepts a virtual file system.

ymandel added a comment. Why add an overload rather than adding it before `UseDebugInfo` and defaulting it to `getRealFileSystem()`? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126806/new/ https://reviews.llvm.org/D126806 __

[PATCH] D126806: Add an overload to ASTUnit::LoadFromASTFile that accepts a virtual file system.

ymandel added a comment. To be clear, I'm fine with the change either way, just want to understand a bit better first. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126806/new/ https://reviews.llvm.org/D126806

[PATCH] D102122: Support warn_unused_result on typedefs

dblaikie updated this revision to Diff 433499. dblaikie added a comment. Fix/update the unsupported syntax warning Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102122/new/ https://reviews.llvm.org/D102122 Files: clang/include/clang/Basic/Attr.t

[PATCH] D102122: Support warn_unused_result on typedefs

dblaikie marked an inline comment as done. dblaikie added a comment. In D102122#3550590 , @aaron.ballman wrote: > In D102122#3544655 , @dblaikie > wrote: > >> How's this look now, then? > > I think it's heading

[PATCH] D126796: [clang][driver] adds `-print-diagnostics`

cjdb added a comment. In D126796#3550848 , @MaskRay wrote: > FYI `diagtool tree` dumps the diagnostics. You can even provide -W options > and observe the differences. Is `diagtool tree` something that users widely know about? Repository: rG LLVM Git

[PATCH] D126812: [Binary] Promote OffloadBinary to inherit from Binary

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, tra, JonChesterfield, MaskRay. Herald added a reviewer: deadalnix. Herald added subscribers: ormris, StephenFan, hiraditya. Herald added a project: All. jhuber6 requested review of this revision. Herald added subscribers: llvm-commi

[PATCH] D126796: [clang][driver] adds `-print-diagnostics`

MaskRay added a comment. In D126796#3551261 , @cjdb wrote: > In D126796#3550848 , @MaskRay wrote: > >> FYI `diagtool tree` dumps the diagnostics. You can even provide -W options >> and observe the differences. >

[PATCH] D126796: [clang][driver] adds `-print-diagnostics`

aaron.ballman added a comment. In D126796#3551261 , @cjdb wrote: > In D126796#3550848 , @MaskRay wrote: > >> FYI `diagtool tree` dumps the diagnostics. You can even provide -W options >> and observe the differenc

[PATCH] D126719: [clang-cl] Add support for /kernel

steplong updated this revision to Diff 433502. steplong added a comment. - Change UnsupportedArches to SupportedArches Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126719/new/ https://reviews.llvm.org/D126719 Files: clang/include/clang/Basic/La

[PATCH] D126796: [clang][driver] adds `-print-diagnostics`

aaron.ballman added a comment. In D126796#3551280 , @MaskRay wrote: > In D126796#3551261 , @cjdb wrote: > >> In D126796#3550848 , @MaskRay >> wrote: >> >>> FYI `diagtool

[PATCH] D126812: [Binary] Promote OffloadBinary to inherit from Binary

jhuber6 updated this revision to Diff 433504. jhuber6 added a comment. Fix test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126812/new/ https://reviews.llvm.org/D126812 Files: clang/lib/CodeGen/BackendUtil.cpp llvm/include/llvm-c/Object.h

[PATCH] D125802: Fix std::has_unique_object_representations for _BitInt types with padding bits

browneee added inline comments. Comment at: clang/test/SemaCXX/has_unique_object_reps_bitint.cpp:1 +// RUN: %clang_cc1 -triple x86_64-unknown-unknown -fsyntax-only -verify -std=c++17 -Wno-bitfield-width %s +// expected-no-diagnostics This unit test appears to t

[PATCH] D126796: [clang][driver] adds `-print-diagnostics`

tschuett added a comment. Would a JSON dump help you for your tools? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126796/new/ https://reviews.llvm.org/D126796 ___ cfe-commits mailing list cfe-commits@li

[PATCH] D125802: Fix std::has_unique_object_representations for _BitInt types with padding bits

aaron.ballman added inline comments. Comment at: clang/test/SemaCXX/has_unique_object_reps_bitint.cpp:1 +// RUN: %clang_cc1 -triple x86_64-unknown-unknown -fsyntax-only -verify -std=c++17 -Wno-bitfield-width %s +// expected-no-diagnostics browneee wrote: > This

[PATCH] D126759: [clang][dataflow] Model calls returning optionals

xazax.hun accepted this revision. xazax.hun added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/Models/UncheckedOptionalAccessModel.cpp:161 +auto possiblyAliasedOptionalType() { + return hasUnqualifiedDesugaredType( Does alias refers to a type

[PATCH] D126816: Only issue warning for subtraction involving null pointers on live code paths

jamieschmeiser created this revision. jamieschmeiser added reviewers: anarazel, efriedma. Herald added a project: All. jamieschmeiser requested review of this revision. Herald added a project: clang. Change the warning produced for subtraction from (or with) a null pointer to only be produced when

[PATCH] D126818: Itanium ABI: Implement mangling for constrained friends

erichkeane created this revision. erichkeane added reviewers: rjmccall, clang-language-wg. Herald added a project: All. erichkeane requested review of this revision. Thanks to concepts, C++ can now have friends that differ by their containing function. Because of this, we need to differentiate on

[PATCH] D126812: [Binary] Promote OffloadBinary to inherit from Binary

tra added a comment. LGTM in principle, with new nits. Comment at: llvm/include/llvm/Object/OffloadBinary.h:121 const Entry *TheEntry) - : Buffer(Buffer), TheHeader(TheHeader), TheEntry(TheEntry) { - + : Binary(Binary::ID_Offload, Source), Buffer(Sour

[PATCH] D126816: Only issue warning for subtraction involving null pointers on live code paths

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126816/new/ https://reviews.llvm.org/D126816 ___

[clang] 5d005d8 - Refactor PS4OSTargetInfo into a base class and PS4 subclass; prep for PS5

Author: Paul Robinson Date: 2022-06-01T13:30:29-07:00 New Revision: 5d005d8256ecd7d57c72e24e7169c4e3d40a773a URL: https://github.com/llvm/llvm-project/commit/5d005d8256ecd7d57c72e24e7169c4e3d40a773a DIFF: https://github.com/llvm/llvm-project/commit/5d005d8256ecd7d57c72e24e7169c4e3d40a773a.diff

[clang] 8869ba3 - [PS5] Add PS5OSTargetInfo class, update affected tests

Author: Paul Robinson Date: 2022-06-01T13:30:29-07:00 New Revision: 8869ba366268c644200784b15c4e6b8efe891397 URL: https://github.com/llvm/llvm-project/commit/8869ba366268c644200784b15c4e6b8efe891397 DIFF: https://github.com/llvm/llvm-project/commit/8869ba366268c644200784b15c4e6b8efe891397.diff

[PATCH] D126818: Itanium ABI: Implement mangling for constrained friends

erichkeane added a subscriber: rsmith. erichkeane added a comment. Note this was mentioned as a 'must also do' in my discussion on deferred constraints with @rsmith, however as this already fails, I don't see this as a prerequisite. However, I think this is easy enough to just do. THAT SAID: T

[PATCH] D126804: [scan-build-py] Change scripts to explicitly require python3

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126804/new/ https://reviews.llvm.org/D126804 ___

[PATCH] D126812: [Binary] Promote OffloadBinary to inherit from Binary

jhuber6 added a comment. Thanks for the comments, I'll address them real quick. Comment at: llvm/include/llvm/Object/OffloadBinary.h:121 const Entry *TheEntry) - : Buffer(Buffer), TheHeader(TheHeader), TheEntry(TheEntry) { - + : Binary(Binary::ID_Offl

[PATCH] D126172: [clang] Fix comparison of TemplateArgument when they are of template kind

roberteg16 added a comment. @rsmith polite ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126172/new/ https://reviews.llvm.org/D126172 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://

[PATCH] D126812: [Binary] Promote OffloadBinary to inherit from Binary

jhuber6 updated this revision to Diff 433534. jhuber6 added a comment. Addressing comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126812/new/ https://reviews.llvm.org/D126812 Files: clang/lib/CodeGen/BackendUtil.cpp llvm/include/llvm-c

[PATCH] D126816: Only issue warning for subtraction involving null pointers on live code paths

anarazel added a comment. So far the tests in pointer-subtraction.c are mirrored in pointer-subtraction.cpp - worth continuing to do? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126816/new/ https://reviews.llvm.org/D126816 _

[PATCH] D126812: [Binary] Promote OffloadBinary to inherit from Binary

tra accepted this revision. tra added inline comments. This revision is now accepted and ready to land. Comment at: llvm/lib/Object/OffloadBinary.cpp:28 + if (identify_magic(Buf.getBuffer()) != file_magic::offload_binary) return errorCodeToError(llvm::object::object_error::

[PATCH] D126602: [Clang][OpenMP] Replace IgnoreImpCasts with IgnoreImplicitAsWritten in atomic compare

tianshilei1992 added a comment. In D126602#3548997 , @ABataev wrote: > Can you add the test? I don't have a good test off the top of my head. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126602/new/ http

[PATCH] D124699: [DeadArgElim] Set unused arguments for internal functions

qcolombet added a comment. > But that's not a problem of this patch, and we will address that later if > needed. Thanks for looking into it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124699/new/ https://reviews.llvm.org/D124699 _

[PATCH] D120007: [OMPIRBuilder] Add the support for compare capture

tianshilei1992 updated this revision to Diff 433558. tianshilei1992 added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120007/new/ https://reviews.llvm.org/D1

[clang] 8c8a267 - [clang][AIX] add option mdefault-visibility-export-mapping

Author: David Tenty Date: 2022-06-01T18:07:17-04:00 New Revision: 8c8a2679a20f621994fa904bcfc68775e7345edc URL: https://github.com/llvm/llvm-project/commit/8c8a2679a20f621994fa904bcfc68775e7345edc DIFF: https://github.com/llvm/llvm-project/commit/8c8a2679a20f621994fa904bcfc68775e7345edc.diff L

[PATCH] D126340: [clang][AIX] add option -mdefault-visibility-export-mapping

This revision was automatically updated to reflect the committed changes. Closed by commit rG8c8a2679a20f: [clang][AIX] add option mdefault-visibility-export-mapping (authored by daltenty). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorep

[PATCH] D126796: [clang][driver] adds `-print-diagnostics`

cjdb added a comment. In D126796#3551312 , @tschuett wrote: > Would a JSON dump help you for your tools? Do you think a JSON dump would be more appropriate? I was just going for something not unlike `--help` here. Repository: rG LLVM Github Monorepo

[PATCH] D126832: [clang][tablegen] adds human documentation to `WarningOption`

cjdb created this revision. cjdb added a reviewer: aaron.ballman. Herald added subscribers: usaxena95, arphaman. Herald added a project: All. cjdb requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Building on D126796

[PATCH] D126084: [Sema] Reject list-initialization of a scoped enum variable from an element of a different scoped enum type

ahatanak added inline comments. Comment at: clang/lib/Sema/SemaInit.cpp:4506 !S.Context.hasSameUnqualifiedType(E->getType(), DestType) && -(E->getType()->isIntegralOrEnumerationType() || +(E->getType()->isIntegralOrUnscopedEnumerationType() || E

[PATCH] D126758: [clang-format] Handle do-while loops for RemoveBracesLLVM

owenpan added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.h:118-119 TokenType NextLBracesType = TT_Unknown, + bool *HasDoWhile = nullptr, bool *HasLabel = nullptr);

[PATCH] D126796: [clang][driver] adds `-print-diagnostics`

tschuett added a comment. In D126796#3551781 , @cjdb wrote: > In D126796#3551312 , @tschuett > wrote: > >> Would a JSON dump help you for your tools? > > Do you think a JSON dump would be more appropriate? I was

[clang] afd2f7e - [Binary] Promote OffloadBinary to inherit from Binary

Author: Joseph Huber Date: 2022-06-01T18:40:57-04:00 New Revision: afd2f7e9919737e30f9fae2d3cff892189301a55 URL: https://github.com/llvm/llvm-project/commit/afd2f7e9919737e30f9fae2d3cff892189301a55 DIFF: https://github.com/llvm/llvm-project/commit/afd2f7e9919737e30f9fae2d3cff892189301a55.diff

[PATCH] D125847: LTO: Decide upfront whether to use opaque/non-opaque pointer types

MatzeB updated this revision to Diff 433577. MatzeB added a comment. address review feedback. I assume this is accepted and good to push when the buildkit builds look reasonable. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125847/new/ https://re

[PATCH] D126812: [Binary] Promote OffloadBinary to inherit from Binary

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGafd2f7e99197: [Binary] Promote OffloadBinary to inherit from Binary (authored by jhuber6). Changed prior to commit: https://reviews.llvm.org/D1268

[PATCH] D126172: [clang] Fix comparison of TemplateArgument when they are of template kind

mizvekov added a reviewer: mizvekov. mizvekov added inline comments. Comment at: clang/lib/AST/TemplateBase.cpp:373-374 case TemplateExpansion: -return TemplateArg.Name == Other.TemplateArg.Name && +return getAsTemplateOrTemplatePattern().getAsTemplateDecl() == +

[PATCH] D125847: LTO: Decide upfront whether to use opaque/non-opaque pointer types

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. > LTO: Decide upfront whether to use opaque/non-opaque pointer types This may need to mention "add options" to decide <...> Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D125847: LTO: Decide upfront whether to use opaque/non-opaque pointer types

MaskRay added inline comments. Comment at: llvm/tools/gold/gold-plugin.cpp:966 + Config.OpaquePointers = options.opaque_pointers; + `Conf`? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125847/new/ https://re

[PATCH] D125847: LTO: Decide upfront whether to use opaque/non-opaque pointer types

MatzeB added inline comments. Comment at: llvm/tools/gold/gold-plugin.cpp:966 + Config.OpaquePointers = options.opaque_pointers; + MaskRay wrote: > `Conf`? > > Ouch, good catch. Guess we have no form of direct testing of the gold plugin in LLVM... Reposit

[PATCH] D125847: LTO: Decide upfront whether to use opaque/non-opaque pointer types

MaskRay added a comment. In D125847#3551841 , @MatzeB wrote: > address review feedback. I assume this is accepted and good to push when the > buildkit builds look reasonable. (I changed myself to a blocking review to check the component I mostly care a

[PATCH] D125847: LTO: Decide upfront whether to use opaque/non-opaque pointer types

MatzeB updated this revision to Diff 433591. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125847/new/ https://reviews.llvm.org/D125847 Files: clang/lib/Driver/ToolChains/CommonArgs.cpp clang/test/CodeGen/thinlto-inline-asm2.c clang/test/Drive

[PATCH] D126757: Fix clang RecursiveASTVisitor for definition of XXXTemplateSpecializationDecl

daiyousei-qz updated this revision to Diff 433590. daiyousei-qz added a comment. Herald added a subscriber: arphaman. Herald added a project: clang-tools-extra. added unit test moved redundant visit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1267

[PATCH] D125847: LTO: Decide upfront whether to use opaque/non-opaque pointer types

MaskRay added inline comments. Comment at: llvm/tools/gold/gold-plugin.cpp:966 + Config.OpaquePointers = options.opaque_pointers; + MatzeB wrote: > MaskRay wrote: > > `Conf`? > > > > > Ouch, good catch. Guess we have no form of direct testing of the gold plu

[PATCH] D125847: LTO: Decide upfront whether to use opaque/non-opaque pointer types

MatzeB added a comment. In D125847#3551972 , @MaskRay wrote: > In D125847#3551841 , @MatzeB wrote: > >> address review feedback. I assume this is accepted and good to push when the >> buildkit builds look reasona

[clang] eb673be - [OMPIRBuilder] Add the support for compare capture

Author: Shilei Tian Date: 2022-06-01T19:53:43-04:00 New Revision: eb673be5ac8510646692f82a606a1f2c10f24828 URL: https://github.com/llvm/llvm-project/commit/eb673be5ac8510646692f82a606a1f2c10f24828 DIFF: https://github.com/llvm/llvm-project/commit/eb673be5ac8510646692f82a606a1f2c10f24828.diff L

[PATCH] D120007: [OMPIRBuilder] Add the support for compare capture

This revision was automatically updated to reflect the committed changes. Closed by commit rGeb673be5ac85: [OMPIRBuilder] Add the support for compare capture (authored by tianshilei1992). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120007/new/ htt

[PATCH] D126796: [clang][driver] adds `-print-diagnostics`

cjdb added a comment. In D126796#3551834 , @tschuett wrote: > In D126796#3551781 , @cjdb wrote: > >> In D126796#3551312 , @tschuett >> wrote: >> >>> Would a JSON dump hel

[PATCH] D126812: [Binary] Promote OffloadBinary to inherit from Binary

MaskRay added inline comments. Comment at: llvm/lib/Object/OffloadBinary.cpp:18 - -namespace llvm { tra wrote: > tra wrote: > > Nit: `using namespace` seems a bit too heavy-handed when you only need one > > enum > > `using object_error = llvm::object::object_e

[PATCH] D125802: Fix std::has_unique_object_representations for _BitInt types with padding bits

browneee added a comment. It looks like the leak is rooted at the allocation here: https://github.com/llvm/llvm-project/blob/1a155ee7de3b62a2fabee86fb470a1554fadc54d/clang/lib/Sema/SemaTemplateInstantiateDecl.cpp#L3857 The VarTemplateSpecializationDecl is allocated using placement new which uses

[PATCH] D125624: [gold] Remove an external dependency to GNU binutils' header file

ruiu added inline comments. Herald added a subscriber: Enna1. Comment at: llvm/tools/gold/gold-plugin.cpp:44-52 // FIXME: remove this declaration when we stop maintaining Ubuntu Quantal and // Precise and Debian Wheezy (binutils 2.23 is required) #define LDPO_PIE 3 #define

[PATCH] D125624: [gold] Remove an external dependency to GNU binutils' header file

MaskRay added a comment. It's better to remove LLVM_BINUTILS_INCDIR for test directories in another patch. This change may expose some failures. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125624/new/ https://reviews.llvm.org/D125624 __

[clang] 850d53a - LTO: Decide upfront whether to use opaque/non-opaque pointer types

Author: Matthias Braun Date: 2022-06-01T18:05:53-07:00 New Revision: 850d53a197f9ffbf5708b7bd795056335e81e9b7 URL: https://github.com/llvm/llvm-project/commit/850d53a197f9ffbf5708b7bd795056335e81e9b7 DIFF: https://github.com/llvm/llvm-project/commit/850d53a197f9ffbf5708b7bd795056335e81e9b7.diff

[PATCH] D125847: LTO: Add option to initialize with opaque/non-opaque pointer types

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG850d53a197f9: LTO: Decide upfront whether to use opaque/non-opaque pointer types (authored by MatzeB). Repository: rG LLVM Github Monorepo CHANGE

[PATCH] D125624: [gold] Remove an external dependency to GNU binutils' header file

ruiu added a comment. Does it? What is your test command? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125624/new/ https://reviews.llvm.org/D125624 ___ cfe-commits mailing list cfe-commits@lists.llvm.or

[PATCH] D126781: [CodeGen] Correctly handle weak symbols in the codegen

junaire updated this revision to Diff 433607. junaire added a comment. Fix the broken build Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126781/new/ https://reviews.llvm.org/D126781 Files: clang/lib/CodeGen/CodeGenModule.cpp clang/lib/CodeGen

[PATCH] D126781: [CodeGen] Correctly handle weak symbols in the codegen

junaire updated this revision to Diff 433610. junaire added a comment. Only use heplers Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126781/new/ https://reviews.llvm.org/D126781 Files: clang/lib/CodeGen/CodeGenModule.cpp clang/lib/CodeGen/Cod

[PATCH] D124749: [clang-format] Handle Verilog preprocessor directives

sstwcw marked 5 inline comments as done. sstwcw added inline comments. Comment at: clang/unittests/Format/FormatTestVerilog.cpp:179 + verifyFormat("`x = (`x1 + `x2 + x);"); + // Lines starting with a preprocessor directive should not be indented. + std::string Directives[] = {

[PATCH] D108189: [RISCV] Support experimental 'P' extension 0.96

Jim updated this revision to Diff 433612. Jim added a comment. Herald added subscribers: sunshaoce, StephenFan, arichardson. Herald added a project: All. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108189/new/ https://reviews.llvm.org/D108

[PATCH] D125624: [gold] Remove an external dependency to GNU binutils' header file

ruiu added a comment. I'm not sure if my credential is still valid. Do you mind if I ask you to submit this for me? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125624/new/ https://reviews.llvm.org/D125624 ___

[PATCH] D124749: [clang-format] Handle Verilog preprocessor directives

sstwcw updated this revision to Diff 433614. sstwcw added a comment. - use raw string for regex - use default style in test - remove parentheses - use seek now that skipOver no longer exists Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124749/new/

[PATCH] D125624: [gold] Remove an external dependency to GNU binutils' header file

tstellar requested changes to this revision. tstellar added a comment. This revision now requires changes to proceed. What is the motivation for this change? I really don't like bundling external headers like this, because it can lead to subtle hard to catch bugs. It also makes it harder to di

[PATCH] D126845: [clang-format] Handle Verilog numbers and operators

sstwcw created this revision. sstwcw added reviewers: HazardyKnusperkeks, MyDeveloperDay, curdeius, owenpan. Herald added a project: All. sstwcw requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://

[PATCH] D126781: [CodeGen] Correctly handle weak symbols in the codegen

junaire updated this revision to Diff 433623. junaire added a comment. Fix the build Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126781/new/ https://reviews.llvm.org/D126781 Files: clang/lib/CodeGen/CodeGenModule.cpp clang/lib/CodeGen/CodeGe

<    1   2   3   >