[clang] fad6e37 - [Lex] Fix crash during dependency scanning while skipping an unmatched `#if`

Author: Argyrios Kyrtzidis Date: 2022-05-27T23:59:30-07:00 New Revision: fad6e37995b461a7750bdc203aad37eca9532fd5 URL: https://github.com/llvm/llvm-project/commit/fad6e37995b461a7750bdc203aad37eca9532fd5 DIFF: https://github.com/llvm/llvm-project/commit/fad6e37995b461a7750bdc203aad37eca9532fd5.

[PATCH] D126183: Implement soft reset of the diagnostics engine.

tapaswenipathak updated this revision to Diff 432711. tapaswenipathak added a comment. Addresses review comment by @rsmith: https://reviews.llvm.org/D126183#3534846. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126183/new/ https://reviews.llvm.org

[PATCH] D126183: Implement soft reset of the diagnostics engine.

tapaswenipathak updated this revision to Diff 432712. tapaswenipathak added a comment. runs clang-format on the diff. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126183/new/ https://reviews.llvm.org/D126183 Files: include/clang/Basic/Diagnosti

[PATCH] D116593: Fix `performance-unnecessary-value-param` for template specialization

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM aside from a very minor nit that can be corrected when landing. Comment at: clang-tools-extra/clang-tidy/performance/UnnecessaryValueParamCheck.cpp:143 isReferencedOutsideOfCallExpr(*Function, *Re

[PATCH] D125802: Fix std::has_unique_object_representations for _BitInt types with padding bits

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM as well -- do you need someone to commit on your behalf? If so, what name and email address would you like used for patch attribution? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[PATCH] D126084: [Sema] Reject implicit conversions between different scoped enum types in list initialization

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaInit.cpp:4506 !S.Context.hasSameUnqualifiedType(E->getType(), DestType) && -(E->getType()->isIntegralOrEnumerationType() || +(E->getType()->isIntegralOrUnscopedEnumerationType() ||

[PATCH] D126183: Implement soft reset of the diagnostics engine.

tapaswenipathak updated this revision to Diff 432723. tapaswenipathak added a comment. Fixes F23230194: Screenshot 2022-05-28 at 7.18.51 PM.png . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126183/new/ https:/

[PATCH] D120495: [clang][dataflow] Add transfer functions for structured bindings

sgatev updated this revision to Diff 432728. sgatev added a comment. Rebase main. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120495/new/ https://reviews.llvm.org/D120495 Files: clang/lib/Analysis/FlowSensitive/Transfer.cpp clang/unittests/A

[PATCH] D120495: [clang][dataflow] Add transfer functions for structured bindings

sgatev updated this revision to Diff 432731. sgatev added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120495/new/ https://reviews.llvm.org/D120495 Files: clang/lib/Analysis/FlowSensitive/Transfer.cpp clang/unitte

[PATCH] D120495: [clang][dataflow] Add transfer functions for structured bindings

sgatev marked 2 inline comments as done. sgatev added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/Transfer.cpp:80 +/// +/// FIXME: Consider adding support for structured bindings to the CFG builder. +class DecompositionVisitor : public ConstStmtVisitor { ---

[PATCH] D126183: Implement soft reset of the diagnostics engine.

tapaswenipathak updated this revision to Diff 432730. tapaswenipathak added a comment. Fixes: https://buildkite.com/llvm-project/premerge-checks/builds/95001#01810b0b-6313-400f-aaf0-35855916ec93 I pasted the wrong diff. sorry! (have multiple build repository in local) F23230857: Screenshot 202

[PATCH] D126578: [clang] Add tests for (const) weak variables

aaron.ballman added a comment. Thanks for looking to improve our test coverage here! However, precommit CI looks to be failing: Failed Tests (1): Clang :: CodeGenCXX/weak-init.cpp Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D126597: [clang] Remove `rm` script which is no longer necessary

JohnTitor created this revision. Herald added a project: All. JohnTitor requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. 8b4fa2c98e07997469f53bee30c0d24a61dc7c8c added t

[PATCH] D126598: # Enter a commit message. # # Changes: # # clang/utils/hmaptool/CMakeLists.txt Fixed typo in hmaptool CMakeLists.txt

danielh2942 created this revision. Herald added a subscriber: mgorny. Herald added a project: All. danielh2942 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. There was a typo in the CMakeLists.txt for hmap tool that installed it to the wr

[PATCH] D126599: [docs][clang] Fix a broken link on the APINotes doc

JohnTitor created this revision. Herald added a project: All. JohnTitor requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch replaces a link with a GitHub one. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D126599

[PATCH] D126598: Fixed typo in hmaptool CMakeLists.txt

This revision was automatically updated to reflect the committed changes. Closed by commit rG50f2e4992456: [clang][cmake] Fixed typo in hmaptool CMakeLists.txt (authored by danielh2942, committed by keith). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[clang] 50f2e49 - [clang][cmake] Fixed typo in hmaptool CMakeLists.txt

Author: Daniel Hannon Date: 2022-05-28T10:10:57-07:00 New Revision: 50f2e49924566330ea9aa731908f2864603bf4fb URL: https://github.com/llvm/llvm-project/commit/50f2e49924566330ea9aa731908f2864603bf4fb DIFF: https://github.com/llvm/llvm-project/commit/50f2e49924566330ea9aa731908f2864603bf4fb.diff

[PATCH] D125802: Fix std::has_unique_object_representations for _BitInt types with padding bits

MitalAshok added a comment. @aaron.ballman yes, with the author "Mital Ashok ". (replacing the [AT]) Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125802/new/ https://reviews.llvm.org/D125802 __

[PATCH] D126597: [clang] Remove `rm` script which is no longer necessary

thakis accepted this revision. thakis added a comment. This revision is now accepted and ready to land. Thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126597/new/ https://reviews.llvm.org/D126597 _

[PATCH] D126578: [clang] Add tests for (const) weak variables

wanders updated this revision to Diff 432742. wanders added a comment. Added explicit triple to hopefully make it pass on win. Made the new files clang-format clean. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126578/new/ https://reviews.llvm.org

[PATCH] D126600: Allow interfaces to operate on in-memory buffers with no source location info.

tapaswenipathak created this revision. tapaswenipathak added a reviewer: v.g.vassilev. tapaswenipathak added a project: clang. Herald added a project: All. tapaswenipathak requested review of this revision. Herald added a subscriber: cfe-commits. Allow interfaces to operate on in-memory buffers wi

[PATCH] D88780: Allow interfaces to operate on in-memory buffers with no source location info.

tapaswenipathak commandeered this revision. tapaswenipathak added a reviewer: reikdas. tapaswenipathak added a comment. Herald added a project: All. Ref: https://reviews.llvm.org/D126600. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88780/new/ htt

[PATCH] D88780: Allow interfaces to operate on in-memory buffers with no source location info.

tapaswenipathak updated this revision to Diff 432746. tapaswenipathak added a comment. Allow interfaces to operate on in-memory buffers with no source location info. This patch avoids an assert PresumedLoc::getFilename if it is invalid. Add unit tests for allowing the interface t

[PATCH] D126600: Allow interfaces to operate on in-memory buffers with no source location info.

tapaswenipathak abandoned this revision. tapaswenipathak added a comment. Ref: dup: https://reviews.llvm.org/D88780. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126600/new/ https://reviews.llvm.org/D126600 ___

[PATCH] D126183: Implement soft reset of the diagnostics engine.

tapaswenipathak updated this revision to Diff 432747. tapaswenipathak added a comment. runs `make check-clang`, `check-clang-tools`, `check-all`. prev ran: `make check-clang-unit`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126183/new/ https://

[PATCH] D126578: [clang] Add tests for (const) weak variables

wanders added a comment. In D126578#3543994 , @aaron.ballman wrote: > Thanks for looking to improve our test coverage here! However, precommit CI > looks to be failing: Thanks for notifying me. It should be green now. Repository: rG LLVM Github Mo

[PATCH] D123674: Clang-Repl Error Recovery Bug Fix

v.g.vassilev accepted this revision. v.g.vassilev added a comment. This revision is now accepted and ready to land. LGTM! Apologies for the delay. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123674/new/ https://reviews.llvm.org/D123674 ___

[PATCH] D126602: [Clang][OpenMP] Replace IgnoreImpCasts with IgnoreImplicitAsWritten in atomic compare

tianshilei1992 created this revision. tianshilei1992 added reviewers: jdoerfert, ABataev. Herald added subscribers: guansong, yaxunl. Herald added a project: All. tianshilei1992 requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. This

[clang] 41a054e - [clang] Remove `rm` script which is no longer necessary

Author: Yuki Okushi Date: 2022-05-29T08:49:45+09:00 New Revision: 41a054ef78856b789acfafca92eb8f79b8129ac0 URL: https://github.com/llvm/llvm-project/commit/41a054ef78856b789acfafca92eb8f79b8129ac0 DIFF: https://github.com/llvm/llvm-project/commit/41a054ef78856b789acfafca92eb8f79b8129ac0.diff L

[PATCH] D126597: [clang] Remove `rm` script which is no longer necessary

This revision was automatically updated to reflect the committed changes. Closed by commit rG41a054ef7885: [clang] Remove `rm` script which is no longer necessary (authored by JohnTitor). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126597/new/ htt

[PATCH] D126607: [docs] Remove some unavailable modindex links

JohnTitor created this revision. Herald added a subscriber: arphaman. Herald added projects: Flang, All. JohnTitor requested review of this revision. Herald added subscribers: cfe-commits, jdoerfert. Herald added a project: clang. These return 404 and I think it's fine to remove them until we can

[PATCH] D126608: [clangd] Remove a test with a duplicate of FileCacheTests

JohnTitor created this revision. Herald added subscribers: usaxena95, kadircet, arphaman. Herald added a project: All. JohnTitor requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. FIXME says it should be remo

[clang] 5ff27fe - [clang-repl] Recover the lookup tables of the primary context.

Author: Purva-Chaudhari Date: 2022-05-29T04:59:40Z New Revision: 5ff27fe1ff03d5aeaf8567c97618170f0cef8f58 URL: https://github.com/llvm/llvm-project/commit/5ff27fe1ff03d5aeaf8567c97618170f0cef8f58 DIFF: https://github.com/llvm/llvm-project/commit/5ff27fe1ff03d5aeaf8567c97618170f0cef8f58.diff LO

[PATCH] D123674: Clang-Repl Error Recovery Bug Fix

This revision was automatically updated to reflect the committed changes. Closed by commit rG5ff27fe1ff03: [clang-repl] Recover the lookup tables of the primary context. (authored by Purva-Chaudhari, committed by v.g.vassilev). Herald added a project: clang. Changed prior to commit: https://rev

[PATCH] D125946: Handles failing driver tests of clang

v.g.vassilev added reviewers: rsmith, lhames, dblaikie, sgraenitz. v.g.vassilev added a subscriber: rsmith. v.g.vassilev added a comment. Herald added a subscriber: StephenFan. @Purva-Chaudhari, this looks reasonable to me. I am adding more reviewers to discuss the way we refer other tests from `

[PATCH] D125944: Template instantiation error recovery

v.g.vassilev added a reviewer: rsmith. v.g.vassilev added a subscriber: rsmith. v.g.vassilev added a comment. @Purva-Chaudhari, can you rebase this patch, seems that it is not buildable. @rsmith, we need to do something similar in cling to handle pending template instantiations, I guess the ques