[PATCH] D123952: [FPEnv] Allow CompoundStmt to keep FP options

sepavloff updated this revision to Diff 431294. sepavloff added a comment. Update after D125635 and rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123952/new/ https://reviews.llvm.org/D123952 Files: clang

[clang] 32f189b - [analyzer] Implement assumeInclusiveRange in terms of assumeInclusiveRangeDual

Author: Gabor Marton Date: 2022-05-23T09:32:44+02:00 New Revision: 32f189b0d9a881341e19e17a459f5b9cac4b0484 URL: https://github.com/llvm/llvm-project/commit/32f189b0d9a881341e19e17a459f5b9cac4b0484 DIFF: https://github.com/llvm/llvm-project/commit/32f189b0d9a881341e19e17a459f5b9cac4b0484.diff

[clang] 96fba64 - [analyzer][NFC] Factor out the copy-paste code repetition of assumeDual and assumeInclusiveRangeDual

Author: Gabor Marton Date: 2022-05-23T09:32:44+02:00 New Revision: 96fba640cf58402b1015924f6582b14c6ac8cc32 URL: https://github.com/llvm/llvm-project/commit/96fba640cf58402b1015924f6582b14c6ac8cc32 DIFF: https://github.com/llvm/llvm-project/commit/96fba640cf58402b1015924f6582b14c6ac8cc32.diff

[PATCH] D125892: [analyzer] Implement assumeInclusiveRange in terms of assumeInclusiveRangeDual

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG32f189b0d9a8: [analyzer] Implement assumeInclusiveRange in terms of assumeInclusiveRangeDual (authored by martong). Repository: rG LLVM Github Mon

[PATCH] D125954: [analyzer][NFC] Factor out the copy-paste code repetition of assumeDual and assumeInclusiveRangeDual

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG96fba640cf58: [analyzer][NFC] Factor out the copy-paste code repetition of assumeDual and… (authored by martong). Repository: rG LLVM Github Monor

[clang] 1b89a25 - [C++20] [Coroutines] Conform the updates for CWG issue 2585

Author: Chuanqi Xu Date: 2022-05-23T15:49:17+08:00 New Revision: 1b89a25a9b960886e486eb20b755634613c088f8 URL: https://github.com/llvm/llvm-project/commit/1b89a25a9b960886e486eb20b755634613c088f8 DIFF: https://github.com/llvm/llvm-project/commit/1b89a25a9b960886e486eb20b755634613c088f8.diff LO

[PATCH] D119544: Deferred Concept Instantiation Implementation

ChuanqiXu added a comment. In D119544#3527556 , @erichkeane wrote: > In D119544#3526810 , @ChuanqiXu > wrote: > >> In D119544#3494281 , @erichkeane >> wrote: >> >>> Upd

[PATCH] D124750: [MLIR] Add a utility to sort the operands of commutative ops

srishti-pm added a comment. Herald added a subscriber: bzcheeseman. @Mogball @mehdi_amini @jpienaar, sorry there haven't been any updates from my side here for the past 10 or so days. I had been busy in some other tasks. I have started working on this again. Repository: rG LLVM Github Monore

[PATCH] D126186: [clang-tidy] Extend cert-oop57-cpp to check non-zero memset values

gamesh411 created this revision. gamesh411 added reviewers: steakhal, martong, whisperity. gamesh411 added a project: clang-tools-extra. Herald added subscribers: carlosgalvezp, Szelethus, dkrupp, rnkovacs, xazax.hun. Herald added a project: All. gamesh411 requested review of this revision. Herald

[clang] 9e9cf3f - Revert "[C++20] [Coroutines] Conform the updates for CWG issue 2585"

Author: Chuanqi Xu Date: 2022-05-23T16:21:42+08:00 New Revision: 9e9cf3fa3d282644dd6802cbdf84f4ca6f932fa0 URL: https://github.com/llvm/llvm-project/commit/9e9cf3fa3d282644dd6802cbdf84f4ca6f932fa0 DIFF: https://github.com/llvm/llvm-project/commit/9e9cf3fa3d282644dd6802cbdf84f4ca6f932fa0.diff LO

[PATCH] D126137: [X86] Add support for `-mharden-sls=all`

kristof.beyls added a comment. See https://gcc.gnu.org/onlinedocs/gcc/AArch64-Options.html, documentation for "mharden-sls": For AArch64, the options available on the command line are "retbr", "blr", "none" and "all". I don't think the options necessarily have to be the same for x86. But assumin

[PATCH] D126187: [C++20] [Coroutines] Conform the updates for CWG issue 2585

ChuanqiXu created this revision. ChuanqiXu added a reviewer: erichkeane. ChuanqiXu added a project: clang. Herald added a project: All. ChuanqiXu requested review of this revision. Herald added a subscriber: cfe-commits. This is the following update for the update in CWG issue 2585: https://cplu

[PATCH] D126186: [clang-tidy] Extend cert-oop57-cpp to check non-zero memset values

steakhal added reviewers: njames93, aaron.ballman, alexfh. steakhal added a comment. Looks reasonable to me. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126186/new/ https://reviews.llvm.org/D126186 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D125911: [pseudo] (trivial) bracket-matching

hokein added inline comments. Comment at: clang-tools-extra/pseudo/unittests/BracketTest.cpp:103 +TEST(Bracket, SimplePair) { + verifyBrackets("^{ ^[ ^( ^) ^( ^) ^] ^}"); + verifyBrackets(") ^{ ^[ ^] ^} ("); sammccall wrote: > hokein wrote: > > For this simple

[PATCH] D125862: [clang][driver] Add gcc-toolset/devtoolset 12 to prefixes

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8717b492dfcd: [clang][driver] Dynamically select gcc-toolset/devtoolset version (authored by tbaeder). Changed prior to commit: https://reviews.ll

[clang] 8717b49 - [clang][driver] Dynamically select gcc-toolset/devtoolset version

Author: Timm Bäder Date: 2022-05-23T11:34:38+02:00 New Revision: 8717b492dfcd12d6387543a2f8322e0cf9059982 URL: https://github.com/llvm/llvm-project/commit/8717b492dfcd12d6387543a2f8322e0cf9059982 DIFF: https://github.com/llvm/llvm-project/commit/8717b492dfcd12d6387543a2f8322e0cf9059982.diff LO

[PATCH] D123235: [OpenMP] atomic compare fail : Parser & AST support

koops updated this revision to Diff 431315. koops added a comment. Fixing a minor error : clang formatting of variable names to avoid build errors. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123235/new/ https://reviews.llvm.org/D123235 Files: clang/include/clang/AST/ASTNodeTravers

[PATCH] D124690: [clangd] add inlay hints for std::forward-ed parameter packs

sammccall added a comment. In D124690#3530272 , @upsj wrote: > I will update this to split up the control flow into a visitor just > collecting a single recursion level and the high-level mapping. A general > question here would be whether we should do

[PATCH] D126186: [clang-tidy] Extend cert-oop57-cpp to check non-zero memset values

gamesh411 added a comment. F23163926: CSA_20testbench_20report.zip There is no change in the results as far as these OS are concerned. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126186/new/ https://reviews.llvm.org/D126186 ___

[PATCH] D124690: [clangd] add inlay hints for std::forward-ed parameter packs

upsj added a comment. Yes, I think that's a good summary. Only a small clarification: > we could query separately where each arg is forwarded to. For multiple > forwards, the recursive step is "what param is arg N of this callee > ultimately bound to" I was thinking of implementing this as "wh

[PATCH] D126186: [clang-tidy] Extend cert-oop57-cpp to check non-zero memset values

njames93 added a comment. Please upload diff with full context. Can you add a note about this in the release notes. As a side point I'm not sure this change really follows what the rule is trying to before. The rule is about not using std::memset to reinitialise objects that aren't trivial. Hav

[PATCH] D126186: [clang-tidy] Extend cert-oop57-cpp to check non-zero memset values

gamesh411 updated this revision to Diff 431319. gamesh411 added a comment. Added a release note Also generated the full context (arcanist could validate the site certificate, that's why I had to resort to manual diff creation. Was there a certificate change on the reviews.llmv.org site maybe?)

[PATCH] D126137: [X86] Add support for `-mharden-sls=all`

pengfei updated this revision to Diff 431322. pengfei added a comment. Replaced `isIndirectBranch` with `isUnconditionalBranch` + `isReturn`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126137/new/ https://reviews.llvm.org/D126137 Files: clang

[PATCH] D126191: [Clang][CodeGen] Fix the cmse-clear-return.c test.

kosarev created this revision. Herald added a project: All. kosarev requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Caught with D125604 . Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D1

[PATCH] D126192: [Driver] Support linking with lld for target AVR

benshi001 created this revision. benshi001 added reviewers: aykevl, MaskRay. Herald added subscribers: StephenFan, Jim, dylanmckay. Herald added a project: All. benshi001 requested review of this revision. Herald added subscribers: cfe-commits, jacquesguan. Herald added a project: clang. Repositor

[PATCH] D126186: [clang-tidy] Extend cert-oop57-cpp to check non-zero memset values

steakhal added a comment. In D126186#3530967 , @gamesh411 wrote: > Was there a certificate change on the reviews.llmv.org site maybe?) Yes, AFAIK. Please redo the measurement, it doesn't look right. F23164509: image.png

[PATCH] D126137: [X86] Add support for `-mharden-sls=all`

pengfei added a comment. In D126137#3530777 , @kristof.beyls wrote: > See https://gcc.gnu.org/onlinedocs/gcc/AArch64-Options.html, documentation > for "mharden-sls": For AArch64, the options available on the command line are > "retbr", "blr", "none" an

[PATCH] D126186: [clang-tidy] Extend cert-oop57-cpp to check non-zero memset values

njames93 added a comment. This diff looks like it's rooted on the clang-tools-extra directory which is why the pre-merge bot is failing to build. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126186/new/ https://reviews.llvm.org/D126186 ___

[PATCH] D126126: [analyzer][NFC] Inline and simplify nonloc::ConcreteInt functions

martong added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/SimpleSValBuilder.cpp:90 -SVal SimpleSValBuilder::evalMinus(NonLoc val) { - switch (val.getSubKind()) { - case nonloc::ConcreteIntKind: I'd rather keep the `switch` because in D125318 we a

[PATCH] D126194: [Concepts] Implement overload resolution for destructors (P0848)

royjacobson created this revision. Herald added a project: All. royjacobson requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch implements a necessary part of P0848, the overload resolution for destructors. It is now possible to ove

[PATCH] D126192: [Driver] Support linking with lld for target AVR

benshi001 updated this revision to Diff 431332. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126192/new/ https://reviews.llvm.org/D126192 Files: clang/lib/Driver/ToolChains/AVR.cpp clang/test/Driver/Inputs/basic_avr_tree/usr/bin/ld.lld clang/test/Driver/Inputs/basic_avr_tree/usr/l

[PATCH] D126192: [Driver] Support linking with lld for target AVR

benshi001 added inline comments. Comment at: clang/lib/Driver/ToolChains/AVR.cpp:461 << CPU; - } else if (TC.getGCCInstallPath().empty()) { -// We can not link since there is no avr-ld. This check is no longer needed, since we will check

[PATCH] D126194: [Concepts] Implement overload resolution for destructors (P0848)

royjacobson updated this revision to Diff 431333. royjacobson added a comment. Fix typo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126194/new/ https://reviews.llvm.org/D126194 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Basic/Dia

[PATCH] D126127: [analyzer][NFC] Relocate unary transfer functions

martong added a comment. > This is an initial step of removing the SimpleSValBuilder abstraction. The > SValBuilder alone should be enough. Perhaps this should be part of another patch stack? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126127/ne

[clang] a020006 - Add support of the next Debian (Debian 13 - Trixie)

Author: Sylvestre Ledru Date: 2022-05-23T13:47:13+02:00 New Revision: a02000611a8fc4843f7a3077d8bb4840ef08de8b URL: https://github.com/llvm/llvm-project/commit/a02000611a8fc4843f7a3077d8bb4840ef08de8b DIFF: https://github.com/llvm/llvm-project/commit/a02000611a8fc4843f7a3077d8bb4840ef08de8b.dif

[clang] 6f4dc5d - Add support of the next Ubuntu (Ubuntu 22.10 - Kinetic Kudu)

Author: Sylvestre Ledru Date: 2022-05-23T13:49:34+02:00 New Revision: 6f4dc5dae60598e71c8211b0c1a705474b0a223f URL: https://github.com/llvm/llvm-project/commit/6f4dc5dae60598e71c8211b0c1a705474b0a223f DIFF: https://github.com/llvm/llvm-project/commit/6f4dc5dae60598e71c8211b0c1a705474b0a223f.dif

[PATCH] D126128: [analyzer][NFC] Inline loc::ConcreteInt::evalBinOp

martong accepted this revision. martong added a comment. This revision is now accepted and ready to land. Looks, good, but it was a struggle to follow if you did the inlining right or not. TBH, someone else should also check it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D126130: [analyzer][NFC] Remove unused SVal::hasConjuredSymbol

martong added a comment. > Remove unused SVal::hasConjuredSymbol The title seems to be off with the changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126130/new/ https://reviews.llvm.org/D126130 __

[PATCH] D126189: [C++20][Modules] Build module static initializers per P1874R1.

iains created this revision. Herald added a project: All. iains added reviewers: urnathan, Bigcheese, ChuanqiXu, jansvoboda11. iains added a subscriber: clang-modules. iains edited the summary of this revision. iains edited the summary of this revision. iains edited the summary of this revision. ia

[PATCH] D126123: [analyzer][NFC] MemRegion::getRegion() never returns null

martong added a comment. Is it documented with `getRegion`? Could we decorate that with `returns-nonnull` https://clang.llvm.org/docs/AttributeReference.html#returns-nonnull ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126123/new/ https://rev

[PATCH] D126077: Fix stack crash in classIsDerivedFrom triggered by clang-tidy

datacompboy updated this revision to Diff 431339. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126077/new/ https://reviews.llvm.org/D126077 Files: clang/lib/ASTMatchers/ASTMatchFinder.cpp clang/unittests/ASTMatchers/ASTMatchersTraversalTest.cpp

[PATCH] D125693: [DebugInfo][WIP] Support types, imports and static locals declared in a lexical block (3/5)

krisb added a comment. Thank you, @asavonic for your comments! I've added some more details about the issues this is going to fix, hope it'll help to review the patchset. In D125693#3523278 , @asavonic wrote: > Thanks a lot for the patch! It would be g

[PATCH] D125487: [Tooling/DependencyScanning] Refactor dependency scanning to produce pre-lexed preprocessor directive tokens, instead of minimized sources

jansvoboda11 accepted this revision. jansvoboda11 added a comment. This revision is now accepted and ready to land. LGTM, nice cleanup! Left a couple of nits. Comment at: clang/lib/Lex/DependencyDirectivesScanner.cpp:153 + + SmallVector CurDirToks; + SmallVector DirsWithToks;

[PATCH] D126198: [analyzer][NFCi] Annotate major nonnull returning functions

steakhal created this revision. steakhal added reviewers: NoQ, martong, Szelethus. Herald added subscribers: manas, ASDenysPetrov, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun. Herald added a project: All. steakhal requested review of this revisio

[PATCH] D126198: [analyzer][NFCi] Annotate major nonnull returning functions

steakhal updated this revision to Diff 431343. steakhal added a comment. fix typo `migth` -> `might` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126198/new/ https://reviews.llvm.org/D126198 Files: clang/include/clang/Analysis/AnalysisDeclConte

[PATCH] D126123: [analyzer][NFC] MemRegion::getRegion() never returns null

steakhal added a comment. In D126123#3531112 , @martong wrote: > Is it documented with `getRegion`? Could we decorate that with > `returns-nonnull` > https://clang.llvm.org/docs/AttributeReference.html#returns-nonnull ? Ah, I thought one of my changes

[PATCH] D126130: [analyzer][NFC] Remove unused SVal::hasConjuredSymbol

steakhal updated this revision to Diff 431344. steakhal added a comment. upload the right diff Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126130/new/ https://reviews.llvm.org/D126130 Files: clang/include/clang/StaticAnalyzer/Core/PathSensitiv

[PATCH] D126130: [analyzer][NFC] Remove unused SVal::hasConjuredSymbol

steakhal added a comment. In D126130#3531108 , @martong wrote: >> Remove unused SVal::hasConjuredSymbol > > The title seems to be off with the changes. Ah, right. Once I tried using `arc`, and I get everything messed up. Never again! Repository: rG

[PATCH] D125488: [Preprocessor] Make the special lexing for dependency scanning a first-class feature of the `Preprocessor` and `Lexer`

jansvoboda11 accepted this revision. jansvoboda11 added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125488/new/ https://reviews.llvm.org/D125488 __

[PATCH] D126126: [analyzer][NFC] Inline and simplify nonloc::ConcreteInt functions

steakhal abandoned this revision. steakhal added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/SimpleSValBuilder.cpp:90 -SVal SimpleSValBuilder::evalMinus(NonLoc val) { - switch (val.getSubKind()) { - case nonloc::ConcreteIntKind: martong wrote: >

[PATCH] D126191: [Clang][CodeGen] Fix the cmse-clear-return.c test.

nikic accepted this revision. nikic added a comment. This revision is now accepted and ready to land. Not familiar with this test, but the change looks reasonable. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126191/new/ https://reviews.llvm.org/D

[PATCH] D126198: [analyzer][NFCi] Annotate major nonnull returning functions

martong accepted this revision. martong added a comment. This revision is now accepted and ready to land. Looks good, with minor revisions. Comment at: clang/include/clang/Analysis/AnalysisDeclContext.h:233 + : Kind(k), Ctx(ctx), Parent(parent), ID(ID) { +assert(Ctx);

[PATCH] D126186: [clang-tidy] Extend cert-oop57-cpp to check non-zero memset values

aaron.ballman added a comment. In D126186#3530938 , @njames93 wrote: > As a side point I'm not sure this change really follows what the rule is > trying to enforce. The rule is about not using std::memset to reinitialise > objects that aren't trivial. H

[PATCH] D126186: [clang-tidy] Extend cert-oop57-cpp to check non-zero memset values

gamesh411 updated this revision to Diff 431348. gamesh411 added a comment. Add full diff with arcanist Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126186/new/ https://reviews.llvm.org/D126186 Files: clang-tools-extra/clang-tidy/cert/NonTrivial

[PATCH] D126189: [C++20][Modules] Build module static initializers per P1874R1.

urnathan added inline comments. Comment at: clang/lib/CodeGen/CGDeclCXX.cpp:626-627 + // We create the function, even if it is empty, since an importer of this + // module will refer to it unconditionally (there is no way for an importer + // to know if the function could be o

[PATCH] D126198: [analyzer][NFCi] Annotate major nonnull returning functions

steakhal added inline comments. Comment at: clang/include/clang/Analysis/AnalysisDeclContext.h:233 + : Kind(k), Ctx(ctx), Parent(parent), ID(ID) { +assert(Ctx); + } martong wrote: > To be consistent with the other hunks, where you assert on the paramete

[clang] 0eccc92 - Revert "[clang][driver] Dynamically select gcc-toolset/devtoolset version"

Author: Timm Bäder Date: 2022-05-23T15:22:27+02:00 New Revision: 0eccc92fa0fd1794988cd6bfeca2314107567fdb URL: https://github.com/llvm/llvm-project/commit/0eccc92fa0fd1794988cd6bfeca2314107567fdb DIFF: https://github.com/llvm/llvm-project/commit/0eccc92fa0fd1794988cd6bfeca2314107567fdb.diff LO

[PATCH] D124776: [SPIR-V] Allow setting SPIR-V version via target triple

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG72832efc941a: [SPIR-V] Allow setting SPIR-V version via target triple. (authored by Anastasia). Changed prior to commit: https://reviews.llvm.org/

[PATCH] D126127: [analyzer][NFC] Relocate unary transfer functions

steakhal updated this revision to Diff 431354. steakhal added a comment. Pull out of the original patch stack Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126127/new/ https://reviews.llvm.org/D126127 Files: clang/include/clang/StaticAnalyzer/Co

[PATCH] D126187: [C++20] [Coroutines] Conform the updates for CWG issue 2585

erichkeane added a comment. Also needs some release notes. Comment at: clang/lib/Sema/SemaCoroutine.cpp:1293 // that just takes the requested size. - - FunctionDecl *OperatorNew = nullptr; - FunctionDecl *OperatorDelete = nullptr; - FunctionDecl *UnusedResult = nullptr; -

[PATCH] D126194: [Concepts] Implement overload resolution for destructors (P0848)

erichkeane added a comment. How much of P0848 is missing after this? If nothing/not much, should we update cxx_status.html as well? Comment at: clang/lib/Sema/SemaTemplateInstantiate.cpp:2330 + /// To achieve that, we remove all non-selected destructors from the AST, + ///

[PATCH] D126134: [clang-tidy] Improve add_new_check.py to recognize more checks

aaron.ballman added a comment. Thanks for this! It generally LGTM (though my Python skills are not particularly awesome, so take it with a grain of salt). Just a few questions at this point. Comment at: clang-tools-extra/clang-tidy/add_new_check.py:335-336 +module_file =

[PATCH] D126194: [Concepts] Implement overload resolution for destructors (P0848)

cor3ntin added a comment. In D126194#3531267 , @erichkeane wrote: > How much of P0848 is missing after this? If nothing/not much, should we > update cxx_status.html as well? P0848 applies to all special member function. At best we could mark it partia

[PATCH] D126172: [clang] Fix comparison of TemplateArgument when they are of template kind

roberteg16 updated this revision to Diff 431356. roberteg16 added a comment. Stricten comparison Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126172/new/ https://reviews.llvm.org/D126172 Files: clang/lib/AST/TemplateBase.cpp clang/test/CXX/dc

[clang] 3e0be56 - [MSVC, ARM64] Add __writex18 intrinsics

Author: Stephen Long Date: 2022-05-23T07:01:11-07:00 New Revision: 3e0be5610ff0e9d5bb15f2872bac8cd17bfcc34a URL: https://github.com/llvm/llvm-project/commit/3e0be5610ff0e9d5bb15f2872bac8cd17bfcc34a DIFF: https://github.com/llvm/llvm-project/commit/3e0be5610ff0e9d5bb15f2872bac8cd17bfcc34a.diff

[PATCH] D126023: [MSVC, ARM64] Add __writex18 intrinsics

This revision was automatically updated to reflect the committed changes. Closed by commit rG3e0be5610ff0: [MSVC, ARM64] Add __writex18 intrinsics (authored by steplong). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126023/new/ https://reviews.llvm

[PATCH] D126186: [clang-tidy] Extend cert-oop57-cpp to check non-zero memset values

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:201 +- Made :doc:`cert-oop57-cpp ` more sensitive + by checking for non-zero integer literal memset arguments as well. Please sort entries in section alphabetically. =

[PATCH] D125904: [Cuda] Use fallback method to mangle externalized decls if no CUID given

jhuber6 added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125904/new/ https://reviews.llvm.org/D125904 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D126198: [analyzer][NFCi] Annotate major nonnull returning functions

xazax.hun added a comment. I prefer references to annotations, but this is also a step in the right direction :l Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126198/new/ https://reviews.llvm.org/D126198 __

[PATCH] D126134: [clang-tidy] Improve add_new_check.py to recognize more checks

LegalizeAdulthood marked 2 inline comments as done. LegalizeAdulthood added inline comments. Comment at: clang-tools-extra/clang-tidy/add_new_check.py:335-336 +module_file = get_module_filename(module_path, module_name) +if not os.path.isfile(module_file): + return '

[PATCH] D126194: [Concepts] Implement overload resolution for destructors (P0848)

royjacobson added a comment. In D126194#3531280 , @cor3ntin wrote: > In D126194#3531267 , @erichkeane > wrote: > >> How much of P0848 is missing after this? If nothing/not much, should we >> update cxx_status.h

[PATCH] D126162: [clang-tidy] Extend SimplifyBooleanExpr demorgan support.

LegalizeAdulthood accepted this revision. LegalizeAdulthood added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126162/new/ https://reviews.llvm.org/D126162 _

[PATCH] D126194: [Concepts] Implement overload resolution for destructors (P0848)

erichkeane added inline comments. Comment at: clang/lib/Sema/SemaTemplateInstantiate.cpp:2330 + /// To achieve that, we remove all non-selected destructors from the AST, + /// which is a bit unusual. We can't let those declarations be in AST and rely + /// on LookupSpecialMem

[PATCH] D126134: [clang-tidy] Improve add_new_check.py to recognize more checks

LegalizeAdulthood marked 2 inline comments as done. LegalizeAdulthood added a comment. Another observation: If some new pattern comes up and fixits aren't recognized for a check, it might be better to switch to a whitelist for checks with fixits rather than going crazier on the file scraping.

[PATCH] D126194: [Concepts] Implement overload resolution for destructors (P0848)

royjacobson added inline comments. Comment at: clang/lib/Sema/SemaTemplateInstantiate.cpp:2330 + /// To achieve that, we remove all non-selected destructors from the AST, + /// which is a bit unusual. We can't let those declarations be in AST and rely + /// on LookupSpecialMe

[PATCH] D126198: [analyzer][NFCi] Annotate major nonnull returning functions

steakhal updated this revision to Diff 431379. steakhal marked an inline comment as done. steakhal added a comment. `assert(ctx)` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126198/new/ https://reviews.llvm.org/D126198 Files: clang/include/cla

[PATCH] D126134: [clang-tidy] Improve add_new_check.py to recognize more checks

LegalizeAdulthood added inline comments. Comment at: clang-tools-extra/clang-tidy/add_new_check.py:352 + stmt = code[stmt_start_pos+1:stmt_end_pos] + matches = re.search('registerCheck<([^>:]*)>\(\s*"([^"]*)"\s*\)', stmt) + if matches and matches[2] == full_check_n

[PATCH] D126194: [Concepts] Implement overload resolution for destructors (P0848)

erichkeane added inline comments. Comment at: clang/lib/Sema/SemaTemplateInstantiate.cpp:2330 + /// To achieve that, we remove all non-selected destructors from the AST, + /// which is a bit unusual. We can't let those declarations be in AST and rely + /// on LookupSpecialMem

[PATCH] D126134: [clang-tidy] Improve add_new_check.py to recognize more checks

LegalizeAdulthood updated this revision to Diff 431383. LegalizeAdulthood added a comment. Update from review comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126134/new/ https://reviews.llvm.org/D126134 Files: clang-tools-extra/clang-tidy/add_new_check.py clang-tools-extra/d

[PATCH] D126134: [clang-tidy] Improve add_new_check.py to recognize more checks

LegalizeAdulthood added inline comments. Comment at: clang-tools-extra/clang-tidy/add_new_check.py:335-336 +module_file = get_module_filename(module_path, module_name) +if not os.path.isfile(module_file): + return '' +with io.open(module_file, 'r') as f:

[PATCH] D126134: [clang-tidy] Improve add_new_check.py to recognize more checks

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, thank you! Comment at: clang-tools-extra/clang-tidy/add_new_check.py:335-336 +module_file = get_module_filename(module_path, module_name) +if not

[PATCH] D123235: [OpenMP] atomic compare fail : Parser & AST support

koops updated this revision to Diff 431385. koops added a comment. Clang formatting for variables in ParseOpenMP.cpp CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123235/new/ https://reviews.llvm.org/D123235 Files: clang/include/clang/AST/ASTNodeTraverser.h clang/include/clang/AST/

[PATCH] D101471: [clang-tidy] Add proper emplace checks to modernize-use-emplace

nicovank updated this revision to Diff 431387. nicovank added a comment. Update! 1. Rebased. 2. Fixed a minor bug which occasionaly caused false negatives. 3. Cleared up fix/hint generation and another nit following comments. 4. Re-organized and added a couple tests. 5. Made a note of this extens

[PATCH] D126172: [clang] Fix comparison of TemplateArgument when they are of template kind

roberteg16 updated this revision to Diff 431389. roberteg16 added a comment. Try fix clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126172/new/ https://reviews.llvm.org/D126172 Files: clang/lib/AST/TemplateBase.cpp clang/test/CXX/d

[PATCH] D125848: [clang-format] Handle attributes in enum declaration.

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. This looks good to me, but let the others chime in.. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125848/new/ https://reviews.l

[clang-tools-extra] 89e663c - [clang-tidy] Improve add_new_check.py to recognize more checks

Author: Richard Date: 2022-05-23T09:47:54-06:00 New Revision: 89e663c4f83a6736fc74a01ec48cb4f01210f86f URL: https://github.com/llvm/llvm-project/commit/89e663c4f83a6736fc74a01ec48cb4f01210f86f DIFF: https://github.com/llvm/llvm-project/commit/89e663c4f83a6736fc74a01ec48cb4f01210f86f.diff LOG:

[PATCH] D126134: [clang-tidy] Improve add_new_check.py to recognize more checks

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG89e663c4f83a: [clang-tidy] Improve add_new_check.py to recognize more checks (authored by LegalizeAdulthood). Repository: rG LLVM Github Monorepo

[PATCH] D126157: [clang-format][NFC] Insert/remove braces in clang/lib/Format/

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. LGTM too.. @owenpan this is one of my favourite features!! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126157/new/ https://reviews.llvm.org/D126157 __

[PATCH] D125667: [pseudo] A basic implementation of compiling cxx grammar at build time.

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/pseudo/lib/cxx/CXX.cpp:17 +static const char *CxxBNF = +#include "CXXBNF.inc" +; this is worth a try, but I think

[PATCH] D126132: [clang-format] Fix a crash on lambda trailing return type

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. LGTM (sorry I've been slow on the reviews, my day job keeps getting in the way ;-)) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126132/new/ https://reviews.llvm.org/D126132

[PATCH] D125970: [amdgpu] Add amdgpu_kernel calling conv attribute to clang

aaron.ballman added a comment. In D125970#3527685 , @JonChesterfield wrote: > If it was adding a calling convention, sure - caution warranted. There's no > llvm change here though, an existing CC is exposed to C++. No change to the > type system either

[PATCH] D125961: [clang-format] Don't break lines after pragma region

MyDeveloperDay added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:19604 + + EXPECT_EQ("#pragma region TEST(FOO : BAR)", format("#pragma region TEST(FOO : BAR)", Style)); +} do we need to consider endregion at all? it would be nice to have

[PATCH] D123235: [OpenMP] atomic compare fail : Parser & AST support

koops updated this revision to Diff 431391. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123235/new/ https://reviews.llvm.org/D123235 Files: clang/include/clang/AST/ASTNodeTraverser.h clang/include/clang/AST/OpenMPClause.h clang/include/clang/AST/RecursiveASTVisitor.h clang/incl

[PATCH] D126024: [MSVC, ARM64] Add __readx18 intrinsics

steplong updated this revision to Diff 431392. steplong added a comment. - Rebased patch on top of main Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126024/new/ https://reviews.llvm.org/D126024 Files: clang/include/clang/Basic/BuiltinsAArch64.d

[PATCH] D126132: [clang-format] Fix a crash on lambda trailing return type

curdeius closed this revision. curdeius added a comment. Closing as it landed in https://github.com/llvm/llvm-project/commit/130a9cc0a5e25e3be8ff3738518e86ae3ae0b5ba. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126132/new/ https://reviews.llvm.o

[clang] a1dcfb7 - [clang] Module global init mangling

Author: Nathan Sidwell Date: 2022-05-23T09:03:10-07:00 New Revision: a1dcfb75ea8c31dd39edb6bdab6f54cde81cad85 URL: https://github.com/llvm/llvm-project/commit/a1dcfb75ea8c31dd39edb6bdab6f54cde81cad85 DIFF: https://github.com/llvm/llvm-project/commit/a1dcfb75ea8c31dd39edb6bdab6f54cde81cad85.diff

[PATCH] D122741: [clang] Module global init mangling

This revision was automatically updated to reflect the committed changes. Closed by commit rGa1dcfb75ea8c: [clang] Module global init mangling (authored by urnathan). Herald added a project: clang. Herald added a subscriber: cfe-commits. Changed prior to commit: https://reviews.llvm.org/D122741

[PATCH] D125848: [clang-format] Handle attributes in enum declaration.

curdeius added a comment. Could you please add test cases with non-empty enums both with and without comments please like in the bug report? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125848/new/ https://reviews.llvm.org/D125848 __

[PATCH] D125970: [amdgpu] Add amdgpu_kernel calling conv attribute to clang

JonChesterfield added a comment. In D125970#3531645 , @aaron.ballman wrote: > In D125970#3527685 , > @JonChesterfield wrote: > >> If it was adding a calling convention, sure - caution warranted. There's no >> l

[PATCH] D117616: GCC ABI Compatibility: Preserve alignment of non-pod members in packed structs

tstellar added inline comments. Comment at: clang/docs/ReleaseNotes.rst:239-243 +- GCC doesn't pack non-POD members in packed structs unless the packed + attribute is also specified on the member. Clang historically did perform + such packing. Clang now matches the gcc behavior

  1   2   3   >