[PATCH] D123612: [Driver] Support linking to compiler-rt on AVR

benshi001 updated this revision to Diff 427821. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123612/new/ https://reviews.llvm.org/D123612 Files: clang/lib/Driver/ToolChains/AVR.cpp clang/lib/Driver/ToolChains/AVR.h clang/test/Driver/Inputs/basic_avr_tree/usr/lib/gcc/avr/5.4.0/avr5

[PATCH] D123612: [Driver] Support linking to compiler-rt on AVR

benshi001 added inline comments. Comment at: clang/lib/Driver/ToolChains/AVR.cpp:430 + // libgcc distributed with avr-gcc always named 'libgcc.a' even on windows. + return (Twine("libclang_rt.") + Component + Arch + ".a").str(); +} MaskRay wrote: > benshi001 wr

[PATCH] D123612: [Driver] Support linking to compiler-rt on AVR

benshi001 added inline comments. Comment at: clang/lib/Driver/ToolChains/AVR.cpp:430 + // libgcc distributed with avr-gcc always named 'libgcc.a' even on windows. + return (Twine("libclang_rt.") + Component + Arch + ".a").str(); +} benshi001 wrote: > MaskRay wr

[PATCH] D124816: [LibTooling] use ToolFileManager to store file managers for each CWD

Kale updated this revision to Diff 427822. Kale added a comment. Herald added subscribers: carlosgalvezp, usaxena95, kadircet, arphaman. Herald added a project: clang-tools-extra. Fix tests & runInvocation in clang-tools-extra. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[PATCH] D124534: [clang] Add a diagnostic for line directive of a gnu extension

ken-matsui added a comment. @aaron.ballman Thank you for your review and sorry to have missed those directives! I also found additional directives that I might have to diagnose. Could you please tell me if these are also required? Comment at: clang/test/Preprocessor/line-dire

[PATCH] D125157: [RISCV][NFC] Add more tests for clang driver.

Pretty-box updated this revision to Diff 427825. Pretty-box edited the summary of this revision. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125157/new/ https://reviews.llvm.org/D125157 Files: clang/test/Driver/riscv-arch.c Index: clang/test/D

[PATCH] D124534: [clang] Add a diagnostic for line directive of a gnu extension

ken-matsui added a comment. After some investigations, some directives behave weirdly. I will continue investigating, but do you have any suggestions here? Comment at: clang/test/Preprocessor/line-directive.c:33 # 42 "foo" 2 // expected-error {{invalid line marker flag '2': ca

[PATCH] D124726: Suggest typoed directives in preprocessor conditionals

ken-matsui added inline comments. Comment at: clang/include/clang/Basic/DiagnosticLexKinds.td:362-365 +def warn_pp_typo_directive : Warning< + "'#%0' directive not found, did you mean '#%1'?">, + InGroup; aaron.ballman wrote: > ken-matsui wrote: > > aaron.bal

[PATCH] D124715: Add ThreadPriority::Low, and use QoS class Utility on Mac

stefanhaller added a comment. @sammccall I addressed your last change requests with a revised patch, do you want to have a final look? Also, I don't have commit rights, could somebody please land this for me once everybody is happy with it? Repository: rG LLVM Github Monorepo CHANGES SINCE

[clang-tools-extra] 1c5e85b - [FuzzMutate] Split out FuzzerCLI library that doesn't depend on IR.

Author: Sam McCall Date: 2022-05-07T12:11:51+02:00 New Revision: 1c5e85b3da649c89db87abecc53b42f6eaa574c2 URL: https://github.com/llvm/llvm-project/commit/1c5e85b3da649c89db87abecc53b42f6eaa574c2 DIFF: https://github.com/llvm/llvm-project/commit/1c5e85b3da649c89db87abecc53b42f6eaa574c2.diff LO

[clang] 1c5e85b - [FuzzMutate] Split out FuzzerCLI library that doesn't depend on IR.

Author: Sam McCall Date: 2022-05-07T12:11:51+02:00 New Revision: 1c5e85b3da649c89db87abecc53b42f6eaa574c2 URL: https://github.com/llvm/llvm-project/commit/1c5e85b3da649c89db87abecc53b42f6eaa574c2 DIFF: https://github.com/llvm/llvm-project/commit/1c5e85b3da649c89db87abecc53b42f6eaa574c2.diff LO

[PATCH] D125081: [FuzzMutate] Split out FuzzerCLI library that doesn't depend on IR.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1c5e85b3da64: [FuzzMutate] Split out FuzzerCLI library that doesn't depend on IR. (authored by sammccall). Repository: rG LLVM Github Monorepo CH

[PATCH] D124836: [AArch64] Add support for -fzero-call-used-regs

void added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64FrameLowering.cpp:682 +// The called routine is expected to preserve r19-r28 +// r29 and r30 are used as frame pointer and link register resp. +return 0; nickdesaulniers wrote: > W

[PATCH] D125137: [clang-format] Don't remove braces if a 1-statement body would wrap

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:465 + +bool UnwrappedLineParser::mightFitOnOneLine() const { + const auto ColumnLimit = Style.ColumnLimit; A bit explanation what it means that something //might// fit

[PATCH] D125162: [clang-format] fix alignment w/o binpacked args

cha5on created this revision. Herald added a project: All. cha5on requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The combination of - AlignConsecutiveAssignments.Enabled = true - BinPackArguments = false would result in the first continu

[clang-tools-extra] 8614674 - Fix underlining in docs to fix the sphinx build

Author: Aaron Ballman Date: 2022-05-07T07:21:43-04:00 New Revision: 8614674b55669025e349324f31eb11505becede1 URL: https://github.com/llvm/llvm-project/commit/8614674b55669025e349324f31eb11505becede1 DIFF: https://github.com/llvm/llvm-project/commit/8614674b55669025e349324f31eb11505becede1.diff

[PATCH] D125164: [X86] Fix some signedness errors in x86 headers

RKSimon created this revision. RKSimon added reviewers: pengfei, craig.topper. Herald added a subscriber: StephenFan. Herald added a project: All. RKSimon requested review of this revision. Herald added a project: clang. Another step toward enabling -Wsystem-headers testing across all x86 headers

[PATCH] D125164: [X86] Fix some signedness errors in x86 headers

RKSimon updated this revision to Diff 427844. RKSimon added a comment. Remove a couple of superfluous casts Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125164/new/ https://reviews.llvm.org/D125164 Files: clang/lib/Headers/avx512bwintrin.h cl

[clang] a1bb952 - Revert "[FuzzMutate] Split out FuzzerCLI library that doesn't depend on IR."

Author: Aaron Ballman Date: 2022-05-07T07:29:57-04:00 New Revision: a1bb952e833b34fdf03bd571e7f8c948191be018 URL: https://github.com/llvm/llvm-project/commit/a1bb952e833b34fdf03bd571e7f8c948191be018 DIFF: https://github.com/llvm/llvm-project/commit/a1bb952e833b34fdf03bd571e7f8c948191be018.diff

[clang-tools-extra] a1bb952 - Revert "[FuzzMutate] Split out FuzzerCLI library that doesn't depend on IR."

Author: Aaron Ballman Date: 2022-05-07T07:29:57-04:00 New Revision: a1bb952e833b34fdf03bd571e7f8c948191be018 URL: https://github.com/llvm/llvm-project/commit/a1bb952e833b34fdf03bd571e7f8c948191be018 DIFF: https://github.com/llvm/llvm-project/commit/a1bb952e833b34fdf03bd571e7f8c948191be018.diff

[PATCH] D125164: [X86] Fix some signedness errors in x86 headers

RKSimon added inline comments. Comment at: clang/lib/Headers/cetintrin.h:26 #ifdef __x86_64__ static __inline__ void __DEFAULT_FN_ATTRS _incsspq(unsigned long long __a) { __builtin_ia32_incsspq(__a); @pengfei The Intel Intrisics guide has this taking a int ?

[PATCH] D125081: [FuzzMutate] Split out FuzzerCLI library that doesn't depend on IR.

aaron.ballman added a comment. Sorry for the trouble, but I had to revert in a1bb952e833b34fdf03bd571e7f8c948191be018 because this broke a lot of bots: https://lab.llvm.org/buildbot/#/builders/171/builds/14222 https://lab.ll

[PATCH] D125081: [FuzzMutate] Split out FuzzerCLI library that doesn't depend on IR.

sammccall added a comment. Thanks for reverting, looks like I missed a target, sorry about that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125081/new/ https://reviews.llvm.org/D125081 ___ cfe-commits

[PATCH] D125162: [clang-format] fix alignment w/o binpacked args

HazardyKnusperkeks added a comment. For me there needs no bug report, but could you comment on the misformatting without the patch? Comment at: clang/unittests/Format/FormatTest.cpp:17289 + Alignment.BinPackArguments = false; + { +const char *Expected = "struct A {\n" --

[PATCH] D125162: [clang-format] fix alignment w/o binpacked args

curdeius requested changes to this revision. curdeius added a comment. This revision now requires changes to proceed. Thanks for working on this! Is there a bug report somewhere? If not, may you create one please? Comment at: clang/lib/Format/WhitespaceManager.cpp:398 +

[PATCH] D125162: [clang-format] fix alignment w/o binpacked args

curdeius added a comment. FYI, I like to have a bug report because people that encounter the same problem (in an older release) can find it easily, and see if/when it was fixed. It also avoid working on the same thing by different people. Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[clang-tools-extra] e571e1a - Reland "[FuzzMutate] Split out FuzzerCLI library that doesn't depend on IR."

Author: Sam McCall Date: 2022-05-07T13:49:54+02:00 New Revision: e571e1a6c356ef045a69220cb8a96e6e26a72209 URL: https://github.com/llvm/llvm-project/commit/e571e1a6c356ef045a69220cb8a96e6e26a72209 DIFF: https://github.com/llvm/llvm-project/commit/e571e1a6c356ef045a69220cb8a96e6e26a72209.diff LO

[clang] e571e1a - Reland "[FuzzMutate] Split out FuzzerCLI library that doesn't depend on IR."

Author: Sam McCall Date: 2022-05-07T13:49:54+02:00 New Revision: e571e1a6c356ef045a69220cb8a96e6e26a72209 URL: https://github.com/llvm/llvm-project/commit/e571e1a6c356ef045a69220cb8a96e6e26a72209 DIFF: https://github.com/llvm/llvm-project/commit/e571e1a6c356ef045a69220cb8a96e6e26a72209.diff LO

[PATCH] D124658: [analyzer] Canonicalize SymIntExpr so the RHS is positive when possible

steakhal added a comment. The patch doesn't apply to me. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124658/new/ https://reviews.llvm.org/D124658 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman

[PATCH] D125165: [Clang] Introduce clang-offload-binary tool to bundle device files

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, JonChesterfield, saiislam, yaxunl, tra. Herald added subscribers: ormris, kerbowa, mgorny, jvesely. Herald added a project: All. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits, sstefan1, MaskRay. He

[PATCH] D125165: [Clang] Introduce clang-offload-binary tool to bundle device files

jhuber6 updated this revision to Diff 427849. jhuber6 added a comment. Fix test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125165/new/ https://reviews.llvm.org/D125165 Files: clang/docs/ClangOffloadBinary.rst clang/include/clang/Basic/Code

[clang] 6e34542 - [X86] Remove unused 'hint' argument from prefetch tests

Author: Simon Pilgrim Date: 2022-05-07T13:38:40+01:00 New Revision: 6e345426de370479c322962f7aa1dd1cde817adf URL: https://github.com/llvm/llvm-project/commit/6e345426de370479c322962f7aa1dd1cde817adf DIFF: https://github.com/llvm/llvm-project/commit/6e345426de370479c322962f7aa1dd1cde817adf.diff

[PATCH] D124690: [clangd] add inlay hints for std::forward-ed parameter packs

upsj updated this revision to Diff 427851. upsj added a comment. Herald added a subscriber: javed.absar. use an RecursiveASTVisitor instead of ASTMatcher Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124690/new/ https://reviews.llvm.org/D124690 Fi

[PATCH] D125164: [X86] Fix some signedness errors in x86 headers

pengfei added a comment. One question: is it better to change the define of builtins than explicit casts? Comment at: clang/lib/Headers/cetintrin.h:26 #ifdef __x86_64__ static __inline__ void __DEFAULT_FN_ATTRS _incsspq(unsigned long long __a) { __builtin_ia32_incsspq(__a)

[PATCH] D124690: [clangd] add inlay hints for std::forward-ed parameter packs

upsj marked 10 inline comments as done. upsj added a comment. This almost works now, the only thing that needs to be fixed is `isExpandedParameter`, which for some reason picks up the first call, but not the second: (Compare `ParameterHints.Forwarded` and `ParameterHints.VariadicPlain`) cpp

[PATCH] D124688: [clangd] parse all make_unique-like functions in preamble

upsj updated this revision to Diff 427852. upsj added a comment. Work around the currently broken isExpandedParameter, also fix the broken diff Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124688/new/ https://reviews.llvm.org/D124688 Files: cla

[PATCH] D124690: [clangd] add inlay hints for std::forward-ed parameter packs

upsj updated this revision to Diff 427853. upsj marked an inline comment as done. upsj added a comment. Work around the currently broken isExpandedParameter, also fix the broken diff Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124690/new/ https:/

[PATCH] D124688: [clangd] parse all make_unique-like functions in preamble

upsj updated this revision to Diff 427854. upsj added a comment. accidentally pushed to the wrong revision, this is the previous version Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124688/new/ https://reviews.llvm.org/D124688 Files: clang-tool

[PATCH] D125164: [X86] Fix some signedness errors in x86 headers

RKSimon added a comment. In D125164#3498723 , @pengfei wrote: > One question: is it better to change the define of builtins than explicit > casts? I can fix the signedness of the cet / rdseed / xbgen / tzcnt x86 builtins if there's a consensus. What d

[PATCH] D124977: [NFC][Clang] Modify expect of fail test or XFAIL because CSKY align is different

rengolin added inline comments. Comment at: clang/test/Sema/builtin-alloca-with-align.c:32 void test8(void) { +#if defined(__csky__) __builtin_alloca_with_align(sizeof(__INT64_TYPE__), __alignof__(__INT64_TYPE__)); // expected-warning {{second argument to __builtin_alloca_w

[PATCH] D124690: [clangd] add inlay hints for std::forward-ed parameter packs

upsj updated this revision to Diff 427855. upsj added a comment. updated patch baseline Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124690/new/ https://reviews.llvm.org/D124690 Files: clang-tools-extra/clangd/InlayHints.cpp clang-tools-extra

[PATCH] D125166: [clang-fuzzer] Add a tiny tool to generate a fuzzing dictionary for clang

sammccall created this revision. sammccall added reviewers: hokein, morehouse. Herald added a subscriber: mgorny. Herald added a project: All. sammccall requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. It should be useful clang-fuzzer itself

[PATCH] D125164: [X86] Fix some signedness errors in x86 headers

RKSimon added a comment. Actually the ia32_tzcnt builtins should stay the way they are - other C/C++ intrinsics return unsigned so we'd still end up with adding explicit casts Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125164/new/ https://revie

[clang] 2cd080c - [X86] rdrand-builtins.c - add 32-bit target coverage and enable -Wall/-Werror

Author: Simon Pilgrim Date: 2022-05-07T14:35:42+01:00 New Revision: 2cd080c884a3dd1fc673f02afd48bfe9ba01ce89 URL: https://github.com/llvm/llvm-project/commit/2cd080c884a3dd1fc673f02afd48bfe9ba01ce89 DIFF: https://github.com/llvm/llvm-project/commit/2cd080c884a3dd1fc673f02afd48bfe9ba01ce89.diff

[PATCH] D125165: [Clang] Introduce clang-offload-binary tool to bundle device files

jhuber6 updated this revision to Diff 427858. jhuber6 added a comment. Fix missing file in test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125165/new/ https://reviews.llvm.org/D125165 Files: clang/docs/ClangOffloadBinary.rst clang/include/

[PATCH] D125164: [X86] Fix some signedness errors in x86 headers

RKSimon updated this revision to Diff 427860. RKSimon added a comment. Fix signedness on 32-bit cet tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125164/new/ https://reviews.llvm.org/D125164 Files: clang/lib/Headers/avx512bwintrin.h clan

[PATCH] D124690: [clangd] add inlay hints for std::forward-ed parameter packs

upsj updated this revision to Diff 427861. upsj added a comment. fix iterator invalidation issue, handle UnresolvedLookupExpr and test recursive and split variadic lookup Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124690/new/ https://reviews.ll

[clang] 4750be4 - [X86] Add 32-bit target test coverage to clean header tests

Author: Simon Pilgrim Date: 2022-05-07T15:23:46+01:00 New Revision: 4750be4907bc22c1b7575fa53c3568628d6cbbe4 URL: https://github.com/llvm/llvm-project/commit/4750be4907bc22c1b7575fa53c3568628d6cbbe4 DIFF: https://github.com/llvm/llvm-project/commit/4750be4907bc22c1b7575fa53c3568628d6cbbe4.diff

[PATCH] D124147: [clang][cmake] correct grammar and style inconsistency

VoltrexMaster updated this revision to Diff 427862. VoltrexMaster added a comment. Rebase and add upstream changes to resolve conflicts. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124147/new/ https://reviews.llvm.org/D124147 Files: clang/CMakeLists.txt Index: clang/CMakeLists.txt

[PATCH] D125164: [X86] Fix some signedness errors in x86 headers

RKSimon updated this revision to Diff 427863. RKSimon added a comment. Move the exhaustive headers checks into x86-intrinsics-headers-clean.cpp as that's what its for Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125164/new/ https://reviews.llvm.o

[PATCH] D125167: Fix member access of anonymous struct/union fields in C

aaron.ballman created this revision. aaron.ballman added reviewers: rsmith, nickdesaulniers, erichkeane, jyknight, clang-language-wg. Herald added a project: All. aaron.ballman requested review of this revision. Herald added a project: clang. We were accepting invalid code where the qualifiers of

[PATCH] D125164: [X86] Fix some signedness errors in x86 headers

pengfei added a comment. > What do you want to do about _mm512_maskz_srli_epi16 ? The Intel Intrinsic > guide has the same mismatch. These intrinsics are interesting. The descriptions on Intrinsic guide are for immediate variant, but all compilers' implementations are register variant. What's

[PATCH] D124688: [clangd] parse all make_unique-like functions in preamble

sammccall added a comment. Thanks, this looks good! - the plumbing can be simplified by moving the option into ParseOptions, sorry about the churn! - we need to add some tests, probably easiest by checking for the diagnostics that are now produced. In `unittests/DiagnosticsTests.cpp` there's `

[PATCH] D125164: [X86] Fix some signedness errors in x86 headers

pengfei added a comment. In D125164#3498752 , @RKSimon wrote: > Actually the ia32_tzcnt builtins should stay the way they are - other C/C++ > intrinsics return unsigned so we'd still end up with adding explicit casts No problem, adding explicit casts lo

[PATCH] D124715: Add ThreadPriority::Low, and use QoS class Utility on Mac

sammccall added a comment. Looks great! I'm happy to land it, will do so on Tuesday unless anyone has further comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124715/new/ https://reviews.llvm.org/D124715 ___

[PATCH] D125164: [X86] Fix some signedness errors in x86 headers

pengfei added a comment. > These intrinsics are interesting. The descriptions on Intrinsic guide are for > immediate variant, but all compilers' implementations are register variant. > What's more, the codegen from Clang and GCC don't seem correct according to > the description of `vpsrlw zmm0

[clang] e7806c0 - [Headers][X86] amxintrin.h - fixed unknown parameter Wdocumentation warning. NFC

Author: Simon Pilgrim Date: 2022-05-07T16:20:39+01:00 New Revision: e7806c08dc1b1c80104029b7a28f748f7123593f URL: https://github.com/llvm/llvm-project/commit/e7806c08dc1b1c80104029b7a28f748f7123593f DIFF: https://github.com/llvm/llvm-project/commit/e7806c08dc1b1c80104029b7a28f748f7123593f.diff

[PATCH] D125164: [X86] Fix some signedness errors in x86 headers

RKSimon added inline comments. Comment at: clang/lib/Headers/cetintrin.h:37 static __inline__ void __DEFAULT_FN_ATTRS _inc_ssp(unsigned int __a) { - __builtin_ia32_incsspd((int)__a); + __builtin_ia32_incsspd((unsigned int)__a); } pengfei wrote: > Unnecessary

[PATCH] D125164: [X86] Fix some signedness errors in x86 headers

RKSimon updated this revision to Diff 427868. RKSimon added a comment. Remove superflouous cast from "_inc_ssp" Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125164/new/ https://reviews.llvm.org/D125164 Files: clang/lib/Headers/avx512bwintrin.h

[PATCH] D125169: [clangd] Skip extra round-trip in parsing args in debug builds. NFC

sammccall created this revision. sammccall added a reviewer: ilya-biryukov. Herald added subscribers: usaxena95, kadircet, arphaman. Herald added a project: All. sammccall requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang-tools-extra.

[PATCH] D124909: Fix issues with using clangd with C++ modules

kuganv added a comment. @sammccall, What are the first steps that is needed for supporting modules with clangd. From what I see, options related to handling comments that are specifically added to the compile options by clangd needs handling. This RFC diff is on that note. AFIK, since, clang

[PATCH] D125167: [WIP] Fix member access of anonymous struct/union fields in C

aaron.ballman added a comment. I'm marking this as a WIP -- the content is ready to go, but I'm no longer convinced we want to implement this for GCC compatibility as GCC is the only C compiler I can find that cares about the qualifiers: https://godbolt.org/z/hTqY8zMb5 Repository: rG LLVM G

[PATCH] D125170: [Headers][X86] Replace \operation with \verbatim

RKSimon created this revision. RKSimon added reviewers: pengfei, craig.topper, tianqing, xiangzhangllvm, LiuChen3. Herald added a subscriber: StephenFan. Herald added a project: All. RKSimon requested review of this revision. Herald added a project: clang. \operation ... \endoperation are not val

[PATCH] D125170: [Headers][X86] Replace \operation with \verbatim

RKSimon added a comment. If people prefer we can alternatively use \code{.unparsed} .. \endcode blocks - I'm unsure if these operation blocks are being used in a particular way downstream Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125170/new/

[PATCH] D125171: Add a new clang-format option AlwaysBreakBeforeFunctionParameters

jrmolin created this revision. Herald added a project: All. jrmolin requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Add the definition, documentation, and implementation for a new clang-format option. Repository: rG LLVM Github Monorep

[PATCH] D125172: [clangd] Disable predefined macros in tests. NFC

sammccall created this revision. sammccall added a reviewer: ilya-biryukov. Herald added subscribers: usaxena95, kadircet, arphaman. Herald added a project: All. sammccall requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang-tools-extra.

[PATCH] D125142: [clang][auto-init] Remove -enable flag for "zero" mode

brooks added a comment. It would be somewhat helpful as a transition aid if `-enable-trivial-auto-var-init-zero-knowing-it-will-be-removed-from-clang` remained as a no-op producing a warning (a generic unused argument warning would be fine). Repository: rG LLVM Github Monorepo CHANGES SINC

[PATCH] D125137: [clang-format] Don't remove braces if a 1-statement body would wrap

owenpan planned changes to this revision. owenpan added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:465 + +bool UnwrappedLineParser::mightFitOnOneLine() const { + const auto ColumnLimit = Style.ColumnLimit; HazardyKnusperkeks wrote: > A

[PATCH] D125177: Recognize scope of thread local variables in CFGBuilder

kparzysz created this revision. kparzysz added a reviewer: rsmith. Herald added subscribers: pengfei, krytarowski, arichardson, emaste. Herald added a project: All. kparzysz requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Compiling the foll

[PATCH] D125178: Warn if using `elifdef` & `elifndef` in not C2x mode

ken-matsui created this revision. ken-matsui added a reviewer: aaron.ballman. Herald added a project: All. ken-matsui requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch resolves https://github.com/llvm/llvm-project/issues/55306. R

[PATCH] D125179: [clangd] Skip (most) predefined macros when scanning for preamble patching.

sammccall created this revision. sammccall added a reviewer: kadircet. Herald added subscribers: usaxena95, arphaman. Herald added a project: All. sammccall requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra.

[PATCH] D125179: [clangd] Skip (most) predefined macros when scanning for preamble patching.

sammccall added a comment. (yes, there's a perverse pleasure in writing 20 lines of commit message for one line of code with no comments. I think in *hindsight* this is obvious enough that it's not worth describing in the code) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D106888: [RISC-V] Implement jump tables for CFI-icall

twd2 updated this revision to Diff 427901. twd2 added a comment. Herald added subscribers: sunshaoce, StephenFan, arichardson. Herald added a project: All. Add tests as suggested. Use `tail xxx@plt` instruction instead of manually `auipc` + `jr`, which eliminates issues when linking dynamically-l

[PATCH] D125180: [Frontend] when attaching a preamble, don't generate the long predefines buffer.

sammccall created this revision. sammccall added a reviewer: kadircet. Herald added a project: All. sammccall requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. We know we're going to overwrite it anyway. It'd be a bit of work to coordinate no

[clang] 6bbf51f - [Frontend] Move, don't copy the predefines buffer into PP. NFC.

Author: Sam McCall Date: 2022-05-08T01:04:46+02:00 New Revision: 6bbf51f3ed59ae37f0fec729f25af002111c9e74 URL: https://github.com/llvm/llvm-project/commit/6bbf51f3ed59ae37f0fec729f25af002111c9e74 DIFF: https://github.com/llvm/llvm-project/commit/6bbf51f3ed59ae37f0fec729f25af002111c9e74.diff LO

[PATCH] D125177: Recognize scope of thread local variables in CFGBuilder

efriedma added a comment. Can we just use VarDecl::hasLocalStorage()? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125177/new/ https://reviews.llvm.org/D125177 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D125164: [X86] Fix some signedness errors in x86 headers

pengfei accepted this revision. pengfei added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125164/new/ https://reviews.llvm.org/D125164

[PATCH] D125170: [Headers][X86] Replace \operation with \verbatim

pengfei added a comment. In D125170#3498913 , @RKSimon wrote: > If people prefer we can alternatively use \code{.unparsed} .. \endcode blocks > - I'm unsure if these operation blocks are being used in a particular way > downstream We have used \code ..

[PATCH] D125142: [clang][auto-init] Remove -enable flag for "zero" mode

kees planned changes to this revision. kees added a comment. In D125142#3499010 , @brooks wrote: > It would be somewhat helpful as a transition aid if > `-enable-trivial-auto-var-init-zero-knowing-it-will-be-removed-from-clang` > remained as a no-op pro