[clang] e75d8b7 - Revert "Treat `std::move`, `forward`, and `move_if_noexcept` as builtins."

Author: Vitaly Buka Date: 2022-04-16T00:27:51-07:00 New Revision: e75d8b70370435b0ad10388afba0df45fcf9bfcc URL: https://github.com/llvm/llvm-project/commit/e75d8b70370435b0ad10388afba0df45fcf9bfcc DIFF: https://github.com/llvm/llvm-project/commit/e75d8b70370435b0ad10388afba0df45fcf9bfcc.diff L

[PATCH] D123345: Treat `std::move`, `forward`, and `move_if_noexcept` as builtins.

vitalybuka reopened this revision. vitalybuka added a comment. This revision is now accepted and ready to land. Reverted with e75d8b70370435b0ad10388afba0df45fcf9bfcc to recover bots Repository: rG LLVM Github Monorepo CH

[PATCH] D123896: [clang-format] fix nested angle brackets parse inside concept definition

predelnik created this revision. Herald added a project: All. predelnik requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Due to how parseBracedList always stopped on the first closing angle bracket and was used in parsing angle bracketed exp

[PATCH] D122768: [Clang][C++20] Support capturing structured bindings in lambdas

cor3ntin updated this revision to Diff 423228. cor3ntin added a comment. Fix several conflicrs with the recently committed change to lambda captures (D119136 ). Also add to rewrite the code gen test. I'm not sure what, if anything changed there, and the generated

[PATCH] D123896: [clang-format] fix nested angle brackets parse inside concept definition

curdeius added a comment. Is there an issue report for this bug already? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123896/new/ https://reviews.llvm.org/D123896 ___ cfe-commits mailing list cfe-commit

[PATCH] D123896: [clang-format] fix nested angle brackets parse inside concept definition

curdeius added a comment. Could you please add an annotator test as well? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123896/new/ https://reviews.llvm.org/D123896 ___ cfe-commits mailing list cfe-commi

[PATCH] D123182: [Concepts] Fix overload resolution bug with constrained candidates

royjacobson updated this revision to Diff 423229. royjacobson added a comment. Rebase again (HEAD CI was broken) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123182/new/ https://reviews.llvm.org/D123182 Files: clang/docs/ReleaseNotes.rst clan

[PATCH] D123896: [clang-format] fix nested angle brackets parse inside concept definition

predelnik added a comment. In D123896#3455299 , @curdeius wrote: > Is there an issue report for this bug already? I could create an issue if that is required. In D123896#3455301 , @curdeius wrote: > Could you p

[PATCH] D97121: [clang-tidy] Add a Standalone diagnostics mode to clang-tidy

njames93 updated this revision to Diff 423230. njames93 added a comment. Added clangd release notes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97121/new/ https://reviews.llvm.org/D97121 Files: clang-tools-extra/clang-tidy/ClangTidyCheck.h

[PATCH] D123182: [Concepts] Fix overload resolution bug with constrained candidates

royjacobson added a comment. Thanks @erichkeane! I will land this on Monday if there are no further comments and the CI looks good. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123182/new/ https://reviews.llvm.org/D123182 ___

[PATCH] D123896: [clang-format] fix nested angle brackets parse inside concept definition

predelnik updated this revision to Diff 423231. predelnik added a comment. Added annotator test, checked that it fails without a patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123896/new/ https://reviews.llvm.org/D123896 Files: clang/lib/Fo

[PATCH] D123896: [clang-format] fix nested angle brackets parse inside concept definition

predelnik added a comment. I've created the issue here: https://github.com/llvm/llvm-project/issues/54943 It also seems to fix the other issue I reported which was partially fixed before this change in master: https://github.com/llvm/llvm-project/issues/54837 Repository: rG LLVM Github Monore

[PATCH] D97121: [clang-tidy] Add a Standalone diagnostics mode to clang-tidy

This revision was automatically updated to reflect the committed changes. Closed by commit rGb859c39c40a7: [clang-tidy] Add a Standalone diagnostics mode to clang-tidy (authored by njames93). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97121/new/

[clang-tools-extra] b859c39 - [clang-tidy] Add a Standalone diagnostics mode to clang-tidy

Author: Nathan James Date: 2022-04-16T09:53:35+01:00 New Revision: b859c39c40a79ff74033f67d807a18130b9afe30 URL: https://github.com/llvm/llvm-project/commit/b859c39c40a79ff74033f67d807a18130b9afe30 DIFF: https://github.com/llvm/llvm-project/commit/b859c39c40a79ff74033f67d807a18130b9afe30.diff

[PATCH] D123896: [clang-format] fix nested angle brackets parse inside concept definition

predelnik updated this revision to Diff 423234. predelnik edited the summary of this revision. predelnik added a comment. Added issue links to commit message Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123896/new/ https://reviews.llvm.org/D123896

[clang] 5a4980c - Revert "[randstruct] Force errors for all platforms"

Author: Aaron Ballman Date: 2022-04-16T11:10:57-04:00 New Revision: 5a4980cc954faa6e39538bfcf62fe7c449d468d3 URL: https://github.com/llvm/llvm-project/commit/5a4980cc954faa6e39538bfcf62fe7c449d468d3 DIFF: https://github.com/llvm/llvm-project/commit/5a4980cc954faa6e39538bfcf62fe7c449d468d3.diff

[clang] 7692fc8 - Revert "[randstruct] Enforce using a designated init for a randomized struct"

Author: Aaron Ballman Date: 2022-04-16T11:11:32-04:00 New Revision: 7692fc81e016a5674464fa77732bd1c7a3903f17 URL: https://github.com/llvm/llvm-project/commit/7692fc81e016a5674464fa77732bd1c7a3903f17 DIFF: https://github.com/llvm/llvm-project/commit/7692fc81e016a5674464fa77732bd1c7a3903f17.diff

[PATCH] D123898: Fix crash in ObjC codegen introduced with 5ab6ee75994d645725264e757d67bbb1c96fb2b6

theraven created this revision. theraven added reviewers: rjmccall, triplef. Herald added a project: All. theraven requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. 5ab6ee75994d645725264e757d67bbb1c96fb2b6

[PATCH] D122865: [HLSL][clang][Driver] Support target profile command line option.

wolfgangp added a comment. Seems to be fine now. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122865/new/ https://reviews.llvm.org/D122865 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D119136: [clang] Implement Change scope of lambda trailing-return-type

grandinj added a comment. I note that building on Ubuntu, I am now seeing failures like: env/gbuildtojson/gbuildtojson.cxx:10: In file included from /usr/lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/algorithm:74: In file included from /usr/lib/gcc/x86_64-linux-gnu/11/../../../../inclu

[PATCH] D116203: [clang] adds unary type transformations as compiler built-ins

cjdb marked an inline comment as done. cjdb added inline comments. Comment at: clang/lib/Sema/SemaType.cpp:9113 + BaseType.isReferenceable() || BaseType->isVoidType() + ? BuildPointerType(BaseType.getNonReferenceType(), Loc, EntityName) + : BaseType; --

[PATCH] D121370: [clang-format] SortIncludes should support "@import" lines in Objective-C

kwk updated this revision to Diff 423254. kwk added a comment. - Put shared code for finding include names HeaderIncludes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121370/new/ https://reviews.llvm.org/D121370 Files: clang/include/clang/Tooli

[PATCH] D121370: [clang-format] SortIncludes should support "@import" lines in Objective-C

kwk updated this revision to Diff 423255. kwk added a comment. - Added llvm:: namespace Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121370/new/ https://reviews.llvm.org/D121370 Files: clang/include/clang/Tooling/Inclusions/HeaderIncludes.h c

[PATCH] D121370: [clang-format] SortIncludes should support "@import" lines in Objective-C

kwk updated this revision to Diff 423256. kwk added a comment. - Use proposed reverse loop Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121370/new/ https://reviews.llvm.org/D121370 Files: clang/include/clang/Tooling/Inclusions/HeaderIncludes.h

[PATCH] D121370: [clang-format] SortIncludes should support "@import" lines in Objective-C

kwk updated this revision to Diff 423257. kwk marked an inline comment as done. kwk added a comment. - Make function static Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121370/new/ https://reviews.llvm.org/D121370 Files: clang/include/clang/Too

[PATCH] D121370: [clang-format] SortIncludes should support "@import" lines in Objective-C

kwk marked 3 inline comments as done. kwk added inline comments. Comment at: clang/lib/Format/Format.cpp:2692-2695 + for (int i = Matches.size() - 1; i > 0; i--) { +if (!Matches[i].empty()) + return Matches[i]; + } owenpan wrote: > I think you missed `

[PATCH] D123889: [clang-tidy] Improve macro handling in modernize-macro-to-enum

LegalizeAdulthood updated this revision to Diff 423258. LegalizeAdulthood added a comment. Add more test cases CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123889/new/ https://reviews.llvm.org/D123889 Files: clang-tools-extra/clang-tidy/modernize/MacroToEnumCheck.cpp clang-tools-e

[PATCH] D123889: [clang-tidy] Improve macro handling in modernize-macro-to-enum

LegalizeAdulthood updated this revision to Diff 423259. LegalizeAdulthood added a comment. Make method names symmetric CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123889/new/ https://reviews.llvm.org/D123889 Files: clang-tools-extra/clang-tidy/modernize/MacroToEnumCheck.cpp clang

[PATCH] D123889: [clang-tidy] Improve macro handling in modernize-macro-to-enum

LegalizeAdulthood updated this revision to Diff 423265. LegalizeAdulthood added a comment. Internal methods are private CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123889/new/ https://reviews.llvm.org/D123889 Files: clang-tools-extra/clang-tidy/modernize/MacroToEnumCheck.cpp clan

[PATCH] D123898: Fix crash in ObjC codegen introduced with 5ab6ee75994d645725264e757d67bbb1c96fb2b6

rjmccall added a comment. LGTM. Could you add a test case? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123898/new/ https://reviews.llvm.org/D123898 ___ cfe-commits mailing list cfe-commits@lists.llvm.

[PATCH] D123907: [HLSL] Add shader attribute

python3kgae created this revision. python3kgae added reviewers: aaron.ballman, rnk, jdoerfert, MaskRay, rsmith. Herald added a subscriber: StephenFan. Herald added a project: All. python3kgae requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits.

[PATCH] D116280: [clang] adds unary type trait checks as compiler built-ins

cjdb updated this revision to Diff 423280. cjdb marked 3 inline comments as done. cjdb added a comment. - finishes `__is_move_constructible` and `__is_move_assignable` - fixes detecting C++ mode - clang-formats Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D116280: [clang] adds unary type trait checks as compiler built-ins

cjdb added inline comments. Comment at: clang/lib/Sema/SemaExprCXX.cpp:4889-4890 return T->isArrayType(); + case UTT_IsBoundedArray: +return T->isArrayType() && !T->isIncompleteArrayType(); + case UTT_IsUnboundedArray: aaron.ballman wrote: > Is a VLA a

[clang] 7f31b4a - [randstruct] Enforce using a designated init for a randomized struct

Author: Bill Wendling Date: 2022-04-16T23:24:48-07:00 New Revision: 7f31b4a917d8cc13df5eac4b7f0520639c3a8fff URL: https://github.com/llvm/llvm-project/commit/7f31b4a917d8cc13df5eac4b7f0520639c3a8fff DIFF: https://github.com/llvm/llvm-project/commit/7f31b4a917d8cc13df5eac4b7f0520639c3a8fff.diff