[clang] ee7fb36 - [Driver] Fix -f[no-]inline to override -f[no-]inline-functions/-finline-hint-functions

2022-04-10 Thread Fangrui Song via cfe-commits
Author: Fangrui Song Date: 2022-04-10T00:15:12-07:00 New Revision: ee7fb36ba03a75e404d1030666883e050052c5a1 URL: https://github.com/llvm/llvm-project/commit/ee7fb36ba03a75e404d1030666883e050052c5a1 DIFF: https://github.com/llvm/llvm-project/commit/ee7fb36ba03a75e404d1030666883e050052c5a1.diff

[PATCH] D123064: [Clang][C++23] P2071 Named universal character escapes

2022-04-10 Thread Corentin Jabot via Phabricator via cfe-commits
cor3ntin updated this revision to Diff 421769. cor3ntin added a comment. Fix linking on windows. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123064/new/ https://reviews.llvm.org/D123064 Files: clang/include/clang/Basic/DiagnosticLexKinds.td

[clang] d74039f - [Frontend] Simplify -finline* handling. NFC

2022-04-10 Thread Fangrui Song via cfe-commits
Author: Fangrui Song Date: 2022-04-10T00:31:25-07:00 New Revision: d74039fa8e4d3f3d9e10fd67f312d4410cc0f53d URL: https://github.com/llvm/llvm-project/commit/d74039fa8e4d3f3d9e10fd67f312d4410cc0f53d DIFF: https://github.com/llvm/llvm-project/commit/d74039fa8e4d3f3d9e10fd67f312d4410cc0f53d.diff

[PATCH] D123064: [Clang][C++23] P2071 Named universal character escapes

2022-04-10 Thread Corentin Jabot via Phabricator via cfe-commits
cor3ntin updated this revision to Diff 421771. cor3ntin added a comment. Formatting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123064/new/ https://reviews.llvm.org/D123064 Files: clang/include/clang/Basic/DiagnosticLexKinds.td clang/include

[clang] 30b1c1f - [Driver] Simplify -f[no-]diagnostics-color handling. NFC

2022-04-10 Thread Fangrui Song via cfe-commits
Author: Fangrui Song Date: 2022-04-10T01:07:44-07:00 New Revision: 30b1c1f23d4d58c3220eac6aee35fd23f109b35c URL: https://github.com/llvm/llvm-project/commit/30b1c1f23d4d58c3220eac6aee35fd23f109b35c DIFF: https://github.com/llvm/llvm-project/commit/30b1c1f23d4d58c3220eac6aee35fd23f109b35c.diff

[clang] 8e1530b - [Driver] Simplify OPT_fcolor_diagnostics claim

2022-04-10 Thread Fangrui Song via cfe-commits
Author: Fangrui Song Date: 2022-04-10T01:21:31-07:00 New Revision: 8e1530ba43f0e298c3e4821f38434479baf88227 URL: https://github.com/llvm/llvm-project/commit/8e1530ba43f0e298c3e4821f38434479baf88227 DIFF: https://github.com/llvm/llvm-project/commit/8e1530ba43f0e298c3e4821f38434479baf88227.diff

[clang] a96cbb5 - [Driver] Prepend - to option name in err_drv_unsupported_option_argument diagnostic

2022-04-10 Thread Fangrui Song via cfe-commits
Author: Fangrui Song Date: 2022-04-10T01:44:53-07:00 New Revision: a96cbb503ae3297a3e46ea4845a75f3af960d40c URL: https://github.com/llvm/llvm-project/commit/a96cbb503ae3297a3e46ea4845a75f3af960d40c DIFF: https://github.com/llvm/llvm-project/commit/a96cbb503ae3297a3e46ea4845a75f3af960d40c.diff

[PATCH] D123345: Treat `std::move`, `forward`, and `move_if_noexcept` as builtins.

2022-04-10 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added a comment. In D123345#3441262 , @joerg wrote: > As is, I think this conflicts with `-ffreestanding` assumptions or at the > very least the spirit. Why? These functions are in `` which is not required in freestanding, but implementat

[PATCH] D123464: [analyzer] Clean checker options from bool to DefaultBool (NFC)

2022-04-10 Thread Vince Bridgers via Phabricator via cfe-commits
vabridgers created this revision. vabridgers added reviewers: NoQ, steakhal. Herald added subscribers: manas, ASDenysPetrov, martong, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a project: All. vabridgers requested review of this r

[PATCH] D122983: [C11/C2x] Change the behavior of the implicit function declaration warning

2022-04-10 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman updated this revision to Diff 421786. aaron.ballman added a comment. Rebased CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122983/new/ https://reviews.llvm.org/D122983 Files: clang-tools-extra/clangd/IncludeFixer.cpp clang-tools-extra/clangd/ParsedAST.cpp clang-tool

[PATCH] D123064: [Clang][C++23] P2071 Named universal character escapes

2022-04-10 Thread Corentin Jabot via Phabricator via cfe-commits
cor3ntin updated this revision to Diff 421787. cor3ntin added a comment. A non-existing name could return an engaged value if the whole string matched the node's name, even if that node had no attached value. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D115103: Leak Sanitizer port to Windows

2022-04-10 Thread Clemens Wasser via Phabricator via cfe-commits
clemenswasser updated this revision to Diff 421790. clemenswasser added a comment. I was wrong, the Problem was, that I didn't change the exit code, when a leak gets detected. I now intercept ExitProcess and change the exit code in there, with this there are already 12 Tests passing on Windows.

[PATCH] D115103: Leak Sanitizer port to Windows

2022-04-10 Thread Clemens Wasser via Phabricator via cfe-commits
clemenswasser updated this revision to Diff 421791. clemenswasser added a comment. The CI seems to fail because of the parent revision? Retry CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115103/new/ https://reviews.llvm.org/D115103 Files: clang/lib/Driver/ToolChains/MSVC.cpp compi

[PATCH] D123460: [OpenMP] Make generating offloading entries more generic

2022-04-10 Thread Joseph Huber via Phabricator via cfe-commits
jhuber6 updated this revision to Diff 421794. jhuber6 added a comment. Change constant to just be a string since it's all we use. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123460/new/ https://reviews.llvm.org/D123460 Files: clang/lib/CodeGen

[PATCH] D115103: Leak Sanitizer port to Windows

2022-04-10 Thread Clemens Wasser via Phabricator via cfe-commits
clemenswasser updated this revision to Diff 421795. clemenswasser added a comment. Since I am currently unable to intercept the ExitProcess/TerminateProcess in the ucrt (`exit_or_terminate_process` in `Windows Kits\10\Source\10.0.22000.0\ucrt\startup\exit.cpp:143`) I inserted a call to `Die` in

[PATCH] D115103: Leak Sanitizer port to Windows

2022-04-10 Thread Clemens Wasser via Phabricator via cfe-commits
clemenswasser updated this revision to Diff 421796. clemenswasser added a comment. I always forget to change the line endings, sorry :( CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115103/new/ https://reviews.llvm.org/D115103 Files: clang/lib/Driver/ToolChains/MSVC.cpp compiler-rt

[PATCH] D123450: [clang-format] Parse Verilog if statements

2022-04-10 Thread Björn Schäpers via Phabricator via cfe-commits
HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/FormatToken.h:374 + /// Verilog we want to treat the backtick like a hash. + tok::TokenKind AliasToken = tok::unknown; + Can't we do that with a type? I'm not very happy about the alias, be

[PATCH] D123468: [Driver] Simplify hasFlag pattern with addOptInFlag/addOptOutFlag helpers

2022-04-10 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay created this revision. MaskRay added reviewers: jkorous, dexonsmith. Herald added subscribers: StephenFan, hiraditya. Herald added a project: All. MaskRay requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Repository:

[PATCH] D123471: [CUDA] Create offloading entries when using the new driver

2022-04-10 Thread Joseph Huber via Phabricator via cfe-commits
jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, JonChesterfield, ronlieb, yaxunl, tra. Herald added subscribers: carlosgalvezp, dexonsmith. Herald added a project: All. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits, sstefan1, MaskRay. Herald add

[PATCH] D114003: LiteralSupport: Don't assert() on invalid input

2022-04-10 Thread Nathan Ridge via Phabricator via cfe-commits
nridge closed this revision. nridge added a comment. Herald added a project: All. This has been committed in https://github.com/llvm/llvm-project/commit/5a6dac66db67225e2443f4e61dfe9d2f96780611. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114003/

[PATCH] D123405: [dllexport] odr-use constexpr default args for constructor closures

2022-04-10 Thread Dávid Bolvanský via Phabricator via cfe-commits
xbolva00 added subscribers: aaron.ballman, rjmccall, rsmith, xbolva00. xbolva00 added a comment. Please wait for some proper clang reviewer @rsmith @aaron.ballman @rjmccall Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123405/new/ https://reviews.

[PATCH] D123405: [dllexport] odr-use constexpr default args for constructor closures

2022-04-10 Thread Nico Weber via Phabricator via cfe-commits
thakis added a comment. What makes me an improper clang reviewer? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123405/new/ https://reviews.llvm.org/D123405 ___ cfe-commits mailing list cfe-commits@lists

[PATCH] D123405: [dllexport] odr-use constexpr default args for constructor closures

2022-04-10 Thread Dávid Bolvanský via Phabricator via cfe-commits
xbolva00 added a comment. No, I mean just second look. I believe @erichkeane is working in this area as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123405/new/ https://reviews.llvm.org/D123405 _

[clang] 4ea1d43 - [CUDA][HIP] Externalize kernels in anonymous name space

2022-04-10 Thread Yaxun Liu via cfe-commits
Author: Yaxun (Sam) Liu Date: 2022-04-10T21:56:28-04:00 New Revision: 4ea1d435099f992cc16127619b0feb64e070630d URL: https://github.com/llvm/llvm-project/commit/4ea1d435099f992cc16127619b0feb64e070630d DIFF: https://github.com/llvm/llvm-project/commit/4ea1d435099f992cc16127619b0feb64e070630d.dif

[PATCH] D123353: [CUDA][HIP] Externalize kernels in anonymous name space

2022-04-10 Thread Yaxun Liu via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. yaxunl marked an inline comment as done. Closed by commit rG4ea1d435099f: [CUDA][HIP] Externalize kernels in anonymous name space (authored by yaxunl). Herald added a p

[PATCH] D123478: [clangd] Fix incorrect operator< impl for HighlightingToken

2022-04-10 Thread Nathan Ridge via Phabricator via cfe-commits
nridge created this revision. nridge added reviewers: sammccall, kadircet. Herald added subscribers: usaxena95, arphaman. Herald added a project: All. nridge requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra.

[PATCH] D123478: [clangd] Fix incorrect operator< impl for HighlightingToken

2022-04-10 Thread Nathan Ridge via Phabricator via cfe-commits
nridge added a comment. Not sure how to write a test for this, short of writing unit tests for the operator< itself. The consequence of this bug is that the sort/unique pass on the highlighting tokens is buggy, but as of https://github.com/clangd/clangd/issues/1057 `resolveConflict()` fixes up

[clang] d16a631 - [AVR] Merge AVRRelaxMemOperations into AVRExpandPseudoInsts

2022-04-10 Thread Ben Shi via cfe-commits
Author: Patryk Wychowaniec Date: 2022-04-11T02:42:13Z New Revision: d16a631c124fdc27dd33037a826804ebf21dc582 URL: https://github.com/llvm/llvm-project/commit/d16a631c124fdc27dd33037a826804ebf21dc582 DIFF: https://github.com/llvm/llvm-project/commit/d16a631c124fdc27dd33037a826804ebf21dc582.diff

[PATCH] D122533: [AVR] Remove AVRRelaxMemOperations

2022-04-10 Thread Ben Shi via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGd16a631c124f: [AVR] Merge AVRRelaxMemOperations into AVRExpandPseudoInsts (authored by Patryk27, committed by benshi001). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews

[PATCH] D123479: [clang-tidy] Support parenthesized literals in modernize-macro-to-enum

2022-04-10 Thread Richard via Phabricator via cfe-commits
LegalizeAdulthood created this revision. LegalizeAdulthood added a reviewer: aaron.ballman. LegalizeAdulthood added a project: clang-tools-extra. Herald added subscribers: carlosgalvezp, xazax.hun. Herald added a project: All. LegalizeAdulthood requested review of this revision. When scanning a ma

[PATCH] D116280: [clang] adds unary type trait checks as compiler built-ins

2022-04-10 Thread Christopher Di Bella via Phabricator via cfe-commits
cjdb updated this revision to Diff 421836. cjdb edited the summary of this revision. cjdb added a comment. Herald added a project: All. adds `__is_copy_constructible`, `__is_copy_assignable`, `__is_move_constructible` (WIP), and `__is_move_assignable` (incomplete) Repository: rG LLVM Github M