[PATCH] D121756: [clang-format] Clean up code looking for if statements

2022-04-03 Thread sstwcw via Phabricator via cfe-commits
sstwcw updated this revision to Diff 420031. sstwcw retitled this revision from "[clang-format] Clean up code looking for if statements NFC" to "[clang-format] Clean up code looking for if statements". sstwcw edited the summary of this revision. Repository: rG LLVM Github Monorepo CHANGES SINC

[PATCH] D121756: [clang-format] Clean up code looking for if statements

2022-04-03 Thread sstwcw via Phabricator via cfe-commits
sstwcw marked 2 inline comments as done. sstwcw added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:252-256 +} else if (OpeningParen.isConditionLParen(/*IncludeFor=*/false) || + (OpeningParen.Previous && +OpeningParen.Previous-

[clang] 1f0b8ba - [C++20][Modules] Fix a testcase warning on Windows [NFC].

2022-04-03 Thread Iain Sandoe via cfe-commits
Author: Iain Sandoe Date: 2022-04-03T11:39:00+01:00 New Revision: 1f0b8ba47ab0f1dc678099d4830d0cc0d10850b6 URL: https://github.com/llvm/llvm-project/commit/1f0b8ba47ab0f1dc678099d4830d0cc0d10850b6 DIFF: https://github.com/llvm/llvm-project/commit/1f0b8ba47ab0f1dc678099d4830d0cc0d10850b6.diff L

[PATCH] D122155: Add warning when eval-method is set in the presence of value unsafe floating-point calculations.

2022-04-03 Thread Zahira Ammarguellat via Phabricator via cfe-commits
zahiraam updated this revision to Diff 420035. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122155/new/ https://reviews.llvm.org/D122155 Files: clang/include/clang/Basic/DiagnosticFrontendKinds.td clang/include/clang/Basic/DiagnosticSemaKinds.td clang/lib/Frontend/CompilerInvocati

[PATCH] D122992: Remove wrong warning. Fix for https://github.com/llvm/llvm-project/issues/54625

2022-04-03 Thread Zahira Ammarguellat via Phabricator via cfe-commits
zahiraam created this revision. zahiraam added reviewers: andrew.w.kaylor, aaron.ballman, efriedma. Herald added a project: All. zahiraam requested review of this revision. Herald added a subscriber: MaskRay. Herald added a project: clang. When driver's floating-point options change, the user is m

[libunwind] 282b3eb - [libunwind] Add missing licenses in test files

2022-04-03 Thread Louis Dionne via cfe-commits
Author: Louis Dionne Date: 2022-04-03T08:55:57-04:00 New Revision: 282b3eb72372f6a0139923d326b05fc16d86c9fa URL: https://github.com/llvm/llvm-project/commit/282b3eb72372f6a0139923d326b05fc16d86c9fa DIFF: https://github.com/llvm/llvm-project/commit/282b3eb72372f6a0139923d326b05fc16d86c9fa.diff

[PATCH] D121097: [C++20][Modules][HU 3/5] Emit module macros for header units.

2022-04-03 Thread Iain Sandoe via Phabricator via cfe-commits
iains added a comment. applied [C++20][Modules] Fix a testcase warning on Windows [NFC]. https://github.com/llvm/llvm-project/commit/1f0b8ba47ab0f1dc678099d4830d0cc0d10850b6 should be fixed now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121097/n

[clang-tools-extra] ef19de5 - [clang-tidy] Add release notes for changes made in 2b21fc5520b39fba555f4e5f2480a5651056be84

2022-04-03 Thread Danny Mösch via cfe-commits
Author: Danny Mösch Date: 2022-04-03T15:48:39+02:00 New Revision: ef19de52ed59a739b0381f2b9b41604e7fa49b59 URL: https://github.com/llvm/llvm-project/commit/ef19de52ed59a739b0381f2b9b41604e7fa49b59 DIFF: https://github.com/llvm/llvm-project/commit/ef19de52ed59a739b0381f2b9b41604e7fa49b59.diff L

[PATCH] D122248: [clang][CodeGen]Fix clang crash and add bitfield support in __builtin_dump_struct

2022-04-03 Thread Wang Yihan via Phabricator via cfe-commits
yihanaa marked an inline comment as done. yihanaa added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:2113-2117 if (CanonicalType->isRecordType()) { - TmpRes = dumpRecord(CGF, CanonicalType, FieldPtr, Align, Func, Lvl + 1); + TmpRes = dumpRecord(CGF,

[clang] 50186b6 - Revert "[GH54588]Fix ItaniumMangler for NTTP unnamed unions w/ unnamed structs"

2022-04-03 Thread Nico Weber via cfe-commits
Author: Nico Weber Date: 2022-04-03T17:21:27-04:00 New Revision: 50186b63d1807d389f31c515377d94185795ab44 URL: https://github.com/llvm/llvm-project/commit/50186b63d1807d389f31c515377d94185795ab44 DIFF: https://github.com/llvm/llvm-project/commit/50186b63d1807d389f31c515377d94185795ab44.diff LO

[PATCH] D122820: [GH54588]Fix ItaniumMangler for NTTP unnamed unions w/ unnamed structs

2022-04-03 Thread Nico Weber via Phabricator via cfe-commits
thakis added a comment. Reverted in 50186b63d1807d389f31c515377d94185795ab44 for now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122820/new/ https://reviews.llvm.org/D122820 ___ cfe-commits mailing li

[PATCH] D122965: Corrected A Command

2022-04-03 Thread Shoaib Meenai via Phabricator via cfe-commits
smeenai added a comment. Thanks for the typo fix! Comment at: clang/test/CodeGen/c-unicode.c:5 int \uaccess = 0; // ALLOWED: "곎ss": // ALLOWED-NOT: "\uaccess": ps-19 wrote: > Comment Line No: 5 is // ALLOWED: "곎ss": i think "곎ss" in istake here, > according

[PATCH] D123009: [Sema] Enum conversion warning when one signed and other unsigned.

2022-04-03 Thread Micah Weston via Phabricator via cfe-commits
red1bluelost created this revision. red1bluelost added reviewers: rsmith, lebedev.ri, aaron.ballman. Herald added a project: All. red1bluelost requested review of this revision. Herald added a project: clang. Ensures an -Wenum-conversion warning happens when one of the enums is signed and the othe

[PATCH] D116203: [clang] adds unary type transformations as compiler built-ins

2022-04-03 Thread Christopher Di Bella via Phabricator via cfe-commits
cjdb added a comment. I've noticed that libstdc++ has `using __remove_cv = typename remove_cv::type`, which causes Clang to chuck a wobbly. Changing from `KEYWORD` to `TYPE_TRAIT_1` didn't seem to fix anything. Is there a way we can work around this, or should we just rename `__remove_cv` and f

[PATCH] D122965: Corrected A Command

2022-04-03 Thread Priyansh Singh via Phabricator via cfe-commits
ps-19 updated this revision to Diff 420104. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122965/new/ https://reviews.llvm.org/D122965 Files: clang/test/CodeGen/c-unicode.c Index: clang/test/CodeGen/c-unicode.c ==

[PATCH] D115187: [clangd] Expose CoawaitExpr's operand in the AST

2022-04-03 Thread Nathan Ridge via Phabricator via cfe-commits
nridge created this revision. Herald added subscribers: usaxena95, kadircet, arphaman. sammccall added a comment. nridge updated this revision to Diff 407028. nridge updated this revision to Diff 420107. Herald added a project: All. nridge retitled this revision from "[WIP] [clangd] Attempted fix f