[PATCH] D122524: [Driver][AVR] Emit proper warnings for different options

MaskRay accepted this revision. MaskRay added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Driver/ToolChains/AVR.cpp:451 if (!Args.hasArg(options::OPT_nostdlib) && !Args.hasArg(options::OPT_nodefaultlibs)) { +if (!CPU.empty

[PATCH] D120639: [RISCV] Pass -mno-relax to assembler when -fno-integrated-as specified

StephenFan updated this revision to Diff 418774. StephenFan added a comment. Herald added a subscriber: sunshaoce. Address @MaskRay 's comments. 1. explicit default-argument to avoid error-prone 2. change riscv64 test to test the case when `-mno-relax -mrelax` specified. Is the change of riscv64

[PATCH] D122524: [Driver][AVR] Emit proper warnings for different options

benshi001 marked an inline comment as done. benshi001 added inline comments. Comment at: clang/lib/Driver/ToolChains/AVR.cpp:451 if (!Args.hasArg(options::OPT_nostdlib) && !Args.hasArg(options::OPT_nodefaultlibs)) { +if (!CPU.empty()) { MaskRay wrot

[PATCH] D122524: [Driver][AVR] Emit proper warnings for different options

benshi001 marked an inline comment as done. benshi001 added inline comments. Comment at: clang/lib/Driver/ToolChains/AVR.cpp:477 if (!LinkStdlib) D.Diag(diag::warn_drv_avr_stdlib_not_linked); We should not merge the above two `if`, due to this check

[PATCH] D122524: [Driver][AVR] Emit proper warnings for different options

MaskRay added inline comments. Comment at: clang/lib/Driver/ToolChains/AVR.cpp:477 if (!LinkStdlib) D.Diag(diag::warn_drv_avr_stdlib_not_linked); benshi001 wrote: > We should not merge the above two `if`, due to this check. > > So I will keep my or

[clang] 50de68b - [Driver][AVR] Emit proper warnings for different options

Author: Ben Shi Date: 2022-03-29T12:05:21+08:00 New Revision: 50de68bc2ffc8f6825fb5445ec179a68aa6ad219 URL: https://github.com/llvm/llvm-project/commit/50de68bc2ffc8f6825fb5445ec179a68aa6ad219 DIFF: https://github.com/llvm/llvm-project/commit/50de68bc2ffc8f6825fb5445ec179a68aa6ad219.diff LOG:

[PATCH] D122524: [Driver][AVR] Emit proper warnings for different options

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG50de68bc2ffc: [Driver][AVR] Emit proper warnings for different options (authored by benshi001). Changed prior to commit: https://reviews.llvm.org/

[PATCH] D122629: [RISCV] Add index check for vset/vget

pcwang-thead created this revision. pcwang-thead added reviewers: luismarques, asb, craig.topper, khchen. Herald added subscribers: sunshaoce, VincentWu, luke957, StephenFan, vkmr, frasercrmck, evandro, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, arphaman, the_o, bruceho

[PATCH] D122271: [Clang] -Wunused-but-set-variable warning - handle also pre/post unary operators

uabelho added a comment. Hi, I noticed these to warning when compiling libunwind/src/UnwindLevel1.c with this patch: 00:22:48 /repo/bbiswjenk/fem2s10-eiffel176/workspace/llvm/sdk_1_20_ki_dev_test/libunwind/src/UnwindLevel1.c:175:12: warning: variable 'framesWalked' set but not used [-Wunuse

[PATCH] D122554: [clangd] Handle tabs in getIncrementalChangesAfterNewline()

nridge updated this revision to Diff 418789. nridge added a comment. address review comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122554/new/ https://reviews.llvm.org/D122554 Files: clang-tools-extra/clangd/Format.cpp clang-tools-extra

[clang-tools-extra] 9325e97 - [clangd] Handle tabs in getIncrementalChangesAfterNewline()

Author: Nathan Ridge Date: 2022-03-29T01:43:09-04:00 New Revision: 9325e97a3599929a52bef3e5c8e403c98f9428ba URL: https://github.com/llvm/llvm-project/commit/9325e97a3599929a52bef3e5c8e403c98f9428ba DIFF: https://github.com/llvm/llvm-project/commit/9325e97a3599929a52bef3e5c8e403c98f9428ba.diff

[PATCH] D122554: [clangd] Handle tabs in getIncrementalChangesAfterNewline()

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9325e97a3599: [clangd] Handle tabs in getIncrementalChangesAfterNewline() (authored by nridge). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D122271: [Clang] -Wunused-but-set-variable warning - handle also pre/post unary operators

xbolva00 added a comment. In D122271#3413193 , @uabelho wrote: > Hi, > > I noticed these to warning when compiling libunwind/src/UnwindLevel1.c with > this patch: > > 00:22:48 > /repo/bbiswjenk/fem2s10-eiffel176/workspace/llvm/sdk_1_20_ki_dev_test/lib

[PATCH] D115907: [misexpect] Re-implement MisExpect Diagnostics

tonic added a comment. This is breaking the docs build with the following warning: "MisExpect.rst:document isn't included in any toctree." By default, docs warnings are treated as errors. Can you fix this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D122636: [llvm][clang][NFC] Add missing references to MisExpect in TOC

paulkirth created this revision. Herald added a subscriber: arphaman. Herald added a project: All. paulkirth requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D

[clang] 6c77972 - Revert "[docs][misexpect][NFC] Fix malformed table in docs"

Author: Paul Kirth Date: 2022-03-29T06:19:53Z New Revision: 6c77972bac7ce125110ed2baea9919fb6866db39 URL: https://github.com/llvm/llvm-project/commit/6c77972bac7ce125110ed2baea9919fb6866db39 DIFF: https://github.com/llvm/llvm-project/commit/6c77972bac7ce125110ed2baea9919fb6866db39.diff LOG: Re

[PATCH] D115907: [misexpect] Re-implement MisExpect Diagnostics

paulkirth added a comment. reverted. I will fix this tomorrow. Sorry for the trouble Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115907/new/ https://reviews.llvm.org/D115907 ___ cfe-commits mailing lis

[clang] a590040 - [RISCV][test] Make PATH empty when testing --gcc-toolchain is multilib_riscv_elf_sdk

Author: luxufan Date: 2022-03-29T14:51:23+08:00 New Revision: a5900401b1475cdf98dbd210ac4bc362563cebbf URL: https://github.com/llvm/llvm-project/commit/a5900401b1475cdf98dbd210ac4bc362563cebbf DIFF: https://github.com/llvm/llvm-project/commit/a5900401b1475cdf98dbd210ac4bc362563cebbf.diff LOG:

[PATCH] D122588: [RISCV][test] Make PATH empty when testing --gcc-toolchain is multilib_riscv_elf_sdk

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa5900401b147: [RISCV][test] Make PATH empty when testing --gcc-toolchain is… (authored by StephenFan). Repository: rG LLVM Github Monorepo CHANGE

<    1   2   3