[PATCH] D118095: [clang][AVR] Reject non assembly source files for the avr1 family

benshi001 added a comment. In D118095#3408037 , @aykevl wrote: > @MaskRay it was my suggestion to move this from the toolchain specific file > to the generic file, because it makes the implementation much simpler. See my > comment D117423#3251110

[PATCH] D122524: [clang][AVR] Eliminate link warnings when '-S' is specified

benshi001 created this revision. benshi001 added reviewers: aykevl, MaskRay. Herald added subscribers: StephenFan, Jim, dylanmckay. Herald added a project: All. benshi001 requested review of this revision. Herald added subscribers: cfe-commits, jacquesguan. Herald added a project: clang. Repositor

[clang] c37accf - [Option] Avoid using the default argument for the 3-argument hasFlag. NFC

Author: Fangrui Song Date: 2022-03-26T00:57:06-07:00 New Revision: c37accf0a207a09b80c1109eb7a114876c45f959 URL: https://github.com/llvm/llvm-project/commit/c37accf0a207a09b80c1109eb7a114876c45f959 DIFF: https://github.com/llvm/llvm-project/commit/c37accf0a207a09b80c1109eb7a114876c45f959.diff

[PATCH] D121302: [HIP] Fix -fno-gpu-sanitize

MaskRay added inline comments. Comment at: clang/lib/Driver/ToolChains/HIPAMD.cpp:165 // Diagnose unsupported sanitizer options only once. + if (!Args.hasFlag(options::OPT_fgpu_sanitize, options::OPT_fno_gpu_sanitize)) +return; Note: the third argument of

[PATCH] D122525: [clang][ASTImporter] Fix an import error handling related bug.

balazske created this revision. Herald added subscribers: steakhal, martong, gamesh411, Szelethus, dkrupp. Herald added a reviewer: a.sidorin. Herald added a reviewer: shafik. Herald added a project: All. balazske requested review of this revision. Herald added a project: clang. Herald added a subs

[clang] 0687578 - [C++20][Modules][HU 2/5] Support searching Header Units in user or system search paths.

Author: Iain Sandoe Date: 2022-03-26T10:17:17Z New Revision: 0687578728ea1985cbab0de14d4eeb4e89cdf210 URL: https://github.com/llvm/llvm-project/commit/0687578728ea1985cbab0de14d4eeb4e89cdf210 DIFF: https://github.com/llvm/llvm-project/commit/0687578728ea1985cbab0de14d4eeb4e89cdf210.diff LOG: [

[PATCH] D121096: [C++20][Modules][HU 2/5] Support searching Header Units in user or system search paths.

This revision was automatically updated to reflect the committed changes. Closed by commit rG0687578728ea: [C++20][Modules][HU 2/5] Support searching Header Units in user or system… (authored by iains). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1

[PATCH] D122425: Pass -disable-llvm-passes to avoid running llvm passes

Izaron accepted this revision. Izaron added a comment. This revision is now accepted and ready to land. Hi! I don't actually know much about llvm passes, but I see that the LLVM IR output is much more understandable now, thanks! It will look nicer when I rebase my patch D119792

[PATCH] D122524: [clang][AVR] Eliminate link warnings when '-S' is specified

benshi001 updated this revision to Diff 418387. benshi001 added a comment. 1. If '-S'/'-c' is specified, do not generate link warnings; 2. If '-S'/'-c' is not specified, '-mmcu' is specified and there is valid GCC installation, do not generate link warnings; 3. If '-S'/'-c' is not specified, and

[PATCH] D122423: [Clang][doc] Fix __builtin_assume wording.

Mordante added a comment. In D122423#3406381 , @aaron.ballman wrote: > LGTM, a second time. :-D Sorry for missing that the first time. No problem, thanks for the review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[clang] c3b672a - [Clang][doc] Fix __builtin_assume wording.

Author: Mark de Wever Date: 2022-03-26T13:02:40+01:00 New Revision: c3b672a34cdef38002016ab15454c2df432e48c8 URL: https://github.com/llvm/llvm-project/commit/c3b672a34cdef38002016ab15454c2df432e48c8 DIFF: https://github.com/llvm/llvm-project/commit/c3b672a34cdef38002016ab15454c2df432e48c8.diff

[PATCH] D122423: [Clang][doc] Fix __builtin_assume wording.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc3b672a34cde: [Clang][doc] Fix __builtin_assume wording. (authored by Mordante). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D122496: [C11] Correct the resulting type for an assignment expression

aaron.ballman marked an inline comment as done. aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:13647 // operand. - return (getLangOpts().CPlusPlus - ? LHSType : LHSType.getUnqualifiedType()); + return getLangOpts().CPlusPlus ? LHSType :

[clang] bfa2f25 - [C11] Correct the resulting type for an assignment expression

Author: Aaron Ballman Date: 2022-03-26T08:03:11-04:00 New Revision: bfa2f25d350c1015b74b8a14684e68efa6500bbc URL: https://github.com/llvm/llvm-project/commit/bfa2f25d350c1015b74b8a14684e68efa6500bbc DIFF: https://github.com/llvm/llvm-project/commit/bfa2f25d350c1015b74b8a14684e68efa6500bbc.diff

[PATCH] D122496: [C11] Correct the resulting type for an assignment expression

aaron.ballman closed this revision. aaron.ballman marked an inline comment as done. aaron.ballman added a comment. Thanks for the reviews, I've commit in bfa2f25d350c1015b74b8a14684e68efa6500bbc . Repository: rG LLVM Github

[PATCH] D122524: [clang][AVR] Eliminate link warnings when '-S' is specified

benshi001 added a comment. 1. If '-S'/'-c' is specified, do not generate link warnings; - User should be clear that he does not want link, so there is no link warning. 2. If '-S'/'-c' is not specified, '-mmcu' is specified and there is valid GCC installation, do not generate link warnings;

[PATCH] D122243: [analyzer][NFC] Introduce the checker package separator character

martong accepted this revision. martong added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122243/new/ https://reviews.llvm.org/D122243 __

[PATCH] D122244: [analyzer] Turn missing tablegen doc entry of a checker into fatal error

martong accepted this revision. martong added a comment. Good. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122244/new/ https://reviews.llvm.org/D122244 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/m

[PATCH] D121459: [analyzer] Remove HasAlphaDocumentation tablegen enum value

martong accepted this revision. martong added a comment. This revision is now accepted and ready to land. Hahh, indeed. IMHO, it does not make sense to write an "alpha" documentation, either write it properly or do not write anything. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[PATCH] D122528: [clang][ASTImporter] Not using consumeError at failed import of in-class initializer.

balazske created this revision. Herald added subscribers: steakhal, martong, gamesh411, Szelethus, dkrupp. Herald added a reviewer: a.sidorin. Herald added a reviewer: shafik. Herald added a project: All. balazske requested review of this revision. Herald added a project: clang. Herald added a subs

[PATCH] D122528: [clang][ASTImporter] Not using consumeError at failed import of in-class initializer.

balazske added a reviewer: martong. balazske added a comment. Herald added a subscriber: rnkovacs. I wanted to remove this one instance of `consumeError` because the change in D122525 , to ensure that `consumeError` is called really only from `ImportDeclContext`

[PATCH] D122529: [ASTMatchers] Output currently matching node on crash

njames93 created this revision. njames93 added reviewers: klimek, aaron.ballman, LegalizeAdulthood. Herald added a project: All. njames93 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Extend D120185 to a

[PATCH] D121097: [C++20][Modules][HU 3/5] Emit module macros for header units.

This revision was automatically updated to reflect the committed changes. Closed by commit rGf8846229c41f: [C++20][Modules][HU 3/5] Emit module macros for header units. (authored by iains). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121097/new/ h

[clang] f884622 - [C++20][Modules][HU 3/5] Emit module macros for header units.

Author: Iain Sandoe Date: 2022-03-26T16:30:40Z New Revision: f8846229c41f3e4aede3bd06921772a209b4993a URL: https://github.com/llvm/llvm-project/commit/f8846229c41f3e4aede3bd06921772a209b4993a DIFF: https://github.com/llvm/llvm-project/commit/f8846229c41f3e4aede3bd06921772a209b4993a.diff LOG: [

[PATCH] D122077: [InstCombine] Fold (ctpop(X) == 1) | (X == 0) into ctpop(X) < 2

hkmatsumoto updated this revision to Diff 418405. hkmatsumoto added a comment. Reflect code reviews - Move all added tests to ispow2.ll from icmp-or.ll since now that they contain tests for "and" operand - Add tests to confirm extra uses don't affect the optimization - Add negative tes

[PATCH] D122077: [InstCombine] Fold (ctpop(X) == 1) | (X == 0) into ctpop(X) < 2

hkmatsumoto added inline comments. Comment at: llvm/test/Transforms/InstCombine/ispow2.ll:540 - -define i1 @isnot_pow2_ctpop_wrong_pred1(i32 %x) { -; CHECK-LABEL: @isnot_pow2_ctpop_wrong_pred1( Renamed to is_pow2or0_ctpop. Comment at: llvm/test

[PATCH] D122077: [InstCombine] Fold (ctpop(X) == 1) | (X == 0) into ctpop(X) < 2

hkmatsumoto added a comment. In D122077#3405085 , @spatel wrote: > A few changes for tests suggested inline. > > There might be some generalization of ctpop analysis that we can make as a > follow-up patch. > For example, I was looking at a "wrong predic

[PATCH] D122533: [avr] Remove AVRRelaxMemOperations

Patryk27 created this revision. Herald added subscribers: Jim, hiraditya, mgorny, dylanmckay. Herald added a project: All. Patryk27 requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. This commit contains a refactoring that me

[PATCH] D122533: [AVR] Remove AVRRelaxMemOperations

Patryk27 updated this revision to Diff 418413. Patryk27 retitled this revision from "[avr] Remove AVRRelaxMemOperations" to "[AVR] Remove AVRRelaxMemOperations". Patryk27 added a comment. avr -> AVR Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122

[PATCH] D122533: [AVR] Remove AVRRelaxMemOperations

Patryk27 added a subscriber: benshi001. Patryk27 added a comment. cc @benshi001 (from https://reviews.llvm.org/D114611) 🙂 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122533/new/ https://reviews.llvm.org/D122533 __

[PATCH] D114611: [AVR] Expand STDWSPQRr & STDSPQRr, approach #2

Patryk27 marked 6 inline comments as done. Patryk27 added a comment. Thanks for the review! For the time being, I have extracted the first set of changes into: https://reviews.llvm.org/D122533 Comment at: llvm/lib/Target/AVR/AVRExpandPseudoInsts.cpp:1234 + + MachineOperand &D

[PATCH] D119409: [C++20] [Modules] Remain dynamic initializing internal-linkage variables in module interface unit

iains added a comment. I think that this problem might well be a consequence of the bug which is fixed by D122413 . We have been generating code with module internal entities (always) given the special ModuleInternalLinkage (which means that, although the linka

[PATCH] D119409: [C++20] [Modules] Remain dynamic initializing internal-linkage variables in module interface unit

iains added a comment. addendum: note we still have work to do on the module initialisers - those are not correct yet (so probably some nesting of modules might not work). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119409/new/ https://reviews.llvm.org/D119409 __

[PATCH] D122535: [clang-tidy] Never consider assignments as equivalent in `misc-redundant-expression` check

fwolff created this revision. fwolff added reviewers: aaron.ballman, njames93. fwolff added a project: clang-tools-extra. Herald added subscribers: carlosgalvezp, xazax.hun. Herald added a project: All. fwolff requested review of this revision. Herald added a subscriber: cfe-commits. Attempts to f

[PATCH] D122513: [analyzer] Fix "RhsLoc and LhsLoc bitwidth must be same"

vabridgers added a comment. Hi @NoQ, good question :) When I looked into the existing SimpleSValBuilder.cpp code, I found a few places that did width modifications so I concluded this was the correct and accepted way to handle this. A few notes to help decide if my suggestion is correct or is t

[PATCH] D122513: [analyzer] Fix "RhsLoc and LhsLoc bitwidth must be same"

vabridgers added a comment. Apparently, it's up to an implementation to determine the specific relations that can be computed between different address spaces. Perhaps a better way to deal with this for now, to avoid crashes, is follow the DereferenceChecker model. That checker punts on checkin

[PATCH] D122104: [X86][regcall] Support passing / returning structures

LuoYuanke added inline comments. Comment at: clang/include/clang/CodeGen/CGFunctionInfo.h:590 + /// Log 2 of the maximum vector width. + unsigned MaxVectorWidth : 4; + I notice some code would indicate it is log 2 size with Log2 suffix in the variable name. Do