[PATCH] D122303: [pseudo] Sort nonterminals based on their reduction order.

hokein added a comment. In D122303#3402375 , @sammccall wrote: > The extraction of TestGrammar seems unrelated to the rest of the patch and it > *isn't* actually shared between tests yet, which makes it a bit hard to > review. It is used in our previou

[PATCH] D122248: [clang][CodeGen]Fix clang crash and add bitfield support in __builtin_dump_struct

yihanaa added a comment. In D122248#3403698 , @erichkeane wrote: >> I'm sorry I misunderstood what you meant @aaron.ballman. >> >> Can we follow the lead of LLVM IR？it use 'undef' >> for example: >> >> struct T6A { >> unsigned a : 1; >> uns

[PATCH] D121765: [CUDA][HIP] Fix hostness check with -fopenmp

rsmith accepted this revision. rsmith added inline comments. This revision is now accepted and ready to land. Comment at: clang/include/clang/Sema/Sema.h:3325-3330 + /// getCurFunctionDecl - If parsing a lambda, then return the lambda + /// declaration if \p AllowLambda is true

[clang] 460fc44 - [Clang] -Wunused-but-set-variable warning - handle also pre/post unary operators

Author: Dávid Bolvanský Date: 2022-03-23T22:05:36+01:00 New Revision: 460fc440ad8d41ca2e3882987512989b1c188fbe URL: https://github.com/llvm/llvm-project/commit/460fc440ad8d41ca2e3882987512989b1c188fbe DIFF: https://github.com/llvm/llvm-project/commit/460fc440ad8d41ca2e3882987512989b1c188fbe.dif

[PATCH] D122271: [Clang] -Wunused-but-set-variable warning - handle also pre/post unary operators

This revision was automatically updated to reflect the committed changes. Closed by commit rG460fc440ad8d: [Clang] -Wunused-but-set-variable warning - handle also pre/post unary operators (authored by xbolva00). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[clang] fcca10c - [AArch64] Add support for -march=native for Apple M1 CPU

Author: Keith Smiley Date: 2022-03-23T14:06:59-07:00 New Revision: fcca10c69aaab539962d10fcc59a5f074b73b0de URL: https://github.com/llvm/llvm-project/commit/fcca10c69aaab539962d10fcc59a5f074b73b0de DIFF: https://github.com/llvm/llvm-project/commit/fcca10c69aaab539962d10fcc59a5f074b73b0de.diff

[PATCH] D119788: [AArch64] Add support for -march=native for Apple M1 CPU

This revision was automatically updated to reflect the committed changes. Closed by commit rGfcca10c69aaa: [AArch64] Add support for -march=native for Apple M1 CPU (authored by keith). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119788/new/ https:

[PATCH] D122352: [OpenMP] Do not create offloading entries for internal or hidden symbols

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, JonChesterfield, ronlieb, ABataev. Herald added subscribers: asavonic, guansong, yaxunl. Herald added a project: All. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a project

[PATCH] D122179: Serialize PragmaAssumeNonNullLoc to support preambles

sammccall added inline comments. Comment at: clang/lib/Lex/PPLexerChange.cpp:436 + if (PragmaAssumeNonNullLoc.isValid() && !this->PPOpts->GeneratePreamble && + !(CurLexer && CurLexer->getFileID() == PredefinesFileID) && !isEndOfMacro && !(CurLexer && CurLexer->Is_Pra

[clang] d90a3fc - [Clang] Added testcases for -Wunused-but-set-parameter

Author: Dávid Bolvanský Date: 2022-03-23T22:14:38+01:00 New Revision: d90a3fcacda7257b26ac32350353410f79be6d2b URL: https://github.com/llvm/llvm-project/commit/d90a3fcacda7257b26ac32350353410f79be6d2b DIFF: https://github.com/llvm/llvm-project/commit/d90a3fcacda7257b26ac32350353410f79be6d2b.dif

[PATCH] D122338: [OPENMP] Eliminate extra set of simd variant function attribute.

jyu2 added a comment. In D122338#3403414 , @ABataev wrote: > If ParamPositions grows, it means that the item is not found. Is it correct > behavior if the compiler inserts new item in the ParamPositions map? I see. Thanks! Then it seems ParamPositions

[clang] fc3cdd0 - Revert "[AArch64] Add support for -march=native for Apple M1 CPU"

Author: Keith Smiley Date: 2022-03-23T14:27:02-07:00 New Revision: fc3cdd0b295a04c38f01b391ae414553963e33b9 URL: https://github.com/llvm/llvm-project/commit/fc3cdd0b295a04c38f01b391ae414553963e33b9 DIFF: https://github.com/llvm/llvm-project/commit/fc3cdd0b295a04c38f01b391ae414553963e33b9.diff

[PATCH] D122338: [OPENMP] Eliminate extra set of simd variant function attribute.

jyu2 updated this revision to Diff 417746. jyu2 edited the summary of this revision. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122338/new/ https://reviews.llvm.org/D122338 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp clang/test/OpenMP/declare_simd_codegen.cpp Index: clang/test/

[clang] 528e6eb - [clang] Improve diagnostic for reopened inline namespace

Author: Fabian Wolff Date: 2022-03-23T22:30:45+01:00 New Revision: 528e6eba2f7906d974594b1fc50362dfad239609 URL: https://github.com/llvm/llvm-project/commit/528e6eba2f7906d974594b1fc50362dfad239609 DIFF: https://github.com/llvm/llvm-project/commit/528e6eba2f7906d974594b1fc50362dfad239609.diff

[PATCH] D122278: [clang] Improve diagnostic for reopened inline namespace

This revision was automatically updated to reflect the committed changes. Closed by commit rG528e6eba2f79: [clang] Improve diagnostic for reopened inline namespace (authored by fwolff). Changed prior to commit: https://reviews.llvm.org/D122278?vs=417455&id=417749#toc Repository: rG LLVM Gith

[PATCH] D122352: [OpenMP] Do not create offloading entries for internal or hidden symbols

jhuber6 updated this revision to Diff 417751. jhuber6 added a comment. Adding new test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122352/new/ https://reviews.llvm.org/D122352 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp clang/test/OpenMP/de

[PATCH] D121451: [clang-format] Add space to comments starting with '#'.

MyDeveloperDay added a comment. In D121451#3402167 , @curdeius wrote: > In D121451#3401947 , > @MyDeveloperDay wrote: > >> I'm a little uncomfortable with >> >> //# >> >> becoming >> >> // # >> >> At least wi

[PATCH] D122352: [OpenMP] Do not create offloading entries for internal or hidden symbols

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122352/new/ https://reviews.llvm.org/D122352 ___

[PATCH] D122335: [clang] Emit crash reproduction as a single tar file

abrachet updated this revision to Diff 417754. abrachet added a comment. Herald added a subscriber: arphaman. Fix test failures outside of Driver/ CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122335/new/ https://reviews.llvm.org/D122335 Files: clang/docs/ReleaseNotes.rst clang/lib

[PATCH] D122335: [clang] Emit crash reproduction as a single tar file

abrachet added a comment. In D122335#3403474 , @aaron.ballman wrote: > Yup, I'm okay with that compiler engineer requirement; I think our existing > requirements on Windows already pull in a useful `tar` program even though it > doesn't seem like we ha

[PATCH] D121927: [Clang] Work with multiple pragmas weak before definition

hubert.reinterpretcast updated this revision to Diff 417755. hubert.reinterpretcast added a comment. - Adjust per observation: Use DenseMapInfo for the alias pointer value Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121927/new/ https://reviews.ll

[PATCH] D122335: [clang] Emit crash reproduction as a single tar file

abrachet updated this revision to Diff 417756. abrachet added a comment. Rebase CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122335/new/ https://reviews.llvm.org/D122335 Files: clang/docs/ReleaseNotes.rst clang/lib/Driver/Driver.cpp clang/test/Driver/crash-diagnostics-dir.c cl

[PATCH] D122352: [OpenMP] Do not create offloading entries for internal or hidden symbols

JonChesterfield added a comment. Sounds good to me too, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122352/new/ https://reviews.llvm.org/D122352 ___ cfe-commits mailing list cfe-commits@lists.l

[PATCH] D121532: [Clang][WIP] Fix Unevaluated Lambdas

cor3ntin updated this revision to Diff 417761. cor3ntin added a comment. - Added a couple of tests in ASTImporterTest.cpp - Rename elements of LambdaDependencyKind - Fix ActOnStartOfLambdaDefinition to not use a boolean for LambdaDependencyKind. Repository: rG LLVM Github Monorepo CHANGES SI

[PATCH] D121532: [Clang][WIP] Fix Unevaluated Lambdas

cor3ntin updated this revision to Diff 417762. cor3ntin added a comment. Formatting. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121532/new/ https://reviews.llvm.org/D121532 Files: clang/include/clang/AST/DeclCXX.h clang/include/clang/Sema/S

[clang] 955cff8 - reland: [AArch64] Add support for -march=native for Apple M1 CPU

Author: Keith Smiley Date: 2022-03-23T15:19:17-07:00 New Revision: 955cff803e081640e149fed0742f57ae1b84db7d URL: https://github.com/llvm/llvm-project/commit/955cff803e081640e149fed0742f57ae1b84db7d DIFF: https://github.com/llvm/llvm-project/commit/955cff803e081640e149fed0742f57ae1b84db7d.diff

[clang] 0d16c23 - [OpenMP] Do not create offloading entries for internal or hidden symbols

Author: Joseph Huber Date: 2022-03-23T18:27:16-04:00 New Revision: 0d16c23af1da2e7c83c84cf64f8b76947f038044 URL: https://github.com/llvm/llvm-project/commit/0d16c23af1da2e7c83c84cf64f8b76947f038044 DIFF: https://github.com/llvm/llvm-project/commit/0d16c23af1da2e7c83c84cf64f8b76947f038044.diff

[PATCH] D122352: [OpenMP] Do not create offloading entries for internal or hidden symbols

This revision was automatically updated to reflect the committed changes. Closed by commit rG0d16c23af1da: [OpenMP] Do not create offloading entries for internal or hidden symbols (authored by jhuber6). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1

[PATCH] D121812: [clang][deps] NFC: De-duplicate clang-cl tests

gulfem added a comment. Newly added tests `ClangScanDeps/cl-output.c` and `ClangScanDeps/cl-xclang.c` started failing in our Mac toolchain builds: https://luci-milo.appspot.com/ui/p/fuchsia/builders/toolchain.ci/clang-mac-x64/b881168677577537/overview Here's the link to the log: https://logs.

[PATCH] D121733: Clean pathnames in FileManager.

rnk added a comment. Ignoring the ".." path components for the moment, is this patch good to go as is? It doesn't affect that behavior. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121733/new/ https://reviews.llvm.org/D121733 ___

[PATCH] D122303: [pseudo] Sort nonterminals based on their reduction order.

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Nice! Comment at: clang-tools-extra/pseudo/lib/GrammarBNF.cpp:55 }; for (const auto &Spec : Specs) { Consider(Spec.Target); hokein wro

[PATCH] D121736: Lower `@llvm.global_dtors` using `__cxa_atexit` on MachO

zequanwu added a comment. Herald added a subscriber: pmatos. Hi, this causes crash on Mac building bot. Here is the reduced repro: `opt -lower-global-dtors /tmp/reduced.ll -o /dev/null ` $ cat /tmp/reduced.ll %struct.mach_header = type { i32, i32, i32, i32, i32, i32, i32 } @__dso_handle

[clang] 581dc3c - Revert "Lower `@llvm.global_dtors` using `__cxa_atexit` on MachO"

Author: Zequan Wu Date: 2022-03-23T16:11:54-07:00 New Revision: 581dc3c729c619fe636325a79279fabb2acdc1ce URL: https://github.com/llvm/llvm-project/commit/581dc3c729c619fe636325a79279fabb2acdc1ce DIFF: https://github.com/llvm/llvm-project/commit/581dc3c729c619fe636325a79279fabb2acdc1ce.diff LOG

[PATCH] D121733: Clean pathnames in FileManager.

ppluzhnikov added a comment. > Ignoring the ".." path components for the moment, is this patch good to go as > is? It doesn't affect that behavior. This patch still breaks Winx64 `clang-tidy/checkers/google-upgrade-googletest-case.cpp`. The failure log here

[PATCH] D121368: [pseudo][WIP] Build Ambiguous forest node in the GLR Parser.

sammccall added inline comments. Comment at: clang/lib/Tooling/Syntax/Pseudo/GLRParser.cpp:285 +ForestChildren.push_back(PN->Parsed); + const ForestNode &ForestNode = ParsedForest.createSequence( + ReduceSymbolID, RA.ReduceRuleID, ForestChildren.front()->sta

[PATCH] D121733: Clean pathnames in FileManager.

dexonsmith added a comment. In D121733#3403995 , @rnk wrote: > Ignoring the ".." path components for the moment, is this patch good to go as > is? It doesn't affect that behavior. Besides the test failure, the other thing is considering what to do with

[PATCH] D118052: [X86] Fix CodeGen Module Flag for -mibt-seal

xiangzhangllvm added inline comments. Comment at: clang/test/CodeGen/X86/x86-cf-protection.c:4 // RUN: %clang -target i386-unknown-unknown -x c -E -dM -o - -fcf-protection=full %s | FileCheck %s --check-prefix=FULL +// RUN: %clang -target i386-unknown-unknown -o - -emit-llvm

[clang] 64902d3 - Reland "Lower `@llvm.global_dtors` using `__cxa_atexit` on MachO"

Author: Julian Lettner Date: 2022-03-23T18:36:55-07:00 New Revision: 64902d335c2126e24a9d84b7410924148959e4a9 URL: https://github.com/llvm/llvm-project/commit/64902d335c2126e24a9d84b7410924148959e4a9 DIFF: https://github.com/llvm/llvm-project/commit/64902d335c2126e24a9d84b7410924148959e4a9.diff

[PATCH] D122335: [clang] Emit crash reproduction as a single tar file

jrtc27 added a comment. As a developer who often deals with crashes locally this is more annoying; currently I can just point tools at the shell script and C file in /tmp and let them go to work reducing, but now I have to also extract the files CHANGES SINCE LAST ACTION https://reviews.llvm

[clang] 8a6b644 - [Inline asm] Fix mangle problem when variable used in inline asm.

Author: Xiang1 Zhang Date: 2022-03-24T09:41:22+08:00 New Revision: 8a6b644c79234a276fbdc840f7091d490a8cc0d7 URL: https://github.com/llvm/llvm-project/commit/8a6b644c79234a276fbdc840f7091d490a8cc0d7 DIFF: https://github.com/llvm/llvm-project/commit/8a6b644c79234a276fbdc840f7091d490a8cc0d7.diff

[PATCH] D120886: [Inline asm][1/3] Fix mangle problem when variable used in inline asm (Revert 2 history bugfix patch)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8a6b644c7923: [Inline asm] Fix mangle problem when variable used in inline asm. (authored by xiangzhangllvm). Herald added subscribers: cfe-commits,

[clang] 287dad1 - [InlineAsm] Fix mangle problem when global variable used in inline asm

Author: Xiang1 Zhang Date: 2022-03-24T09:41:23+08:00 New Revision: 287dad13abba934db5f4a62a968263eea2693b4f URL: https://github.com/llvm/llvm-project/commit/287dad13abba934db5f4a62a968263eea2693b4f DIFF: https://github.com/llvm/llvm-project/commit/287dad13abba934db5f4a62a968263eea2693b4f.diff

[PATCH] D120887: The [2/3] Fix mangle problem when variable used in inline asm （Add modifier P for ARR[BaseReg+IndexReg+..]）

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG287dad13abba: [InlineAsm] Fix mangle problem when global variable used in inline asm (authored by xiangzhangllvm). Herald added subscribers: cfe-comm

[PATCH] D121736: Lower `@llvm.global_dtors` using `__cxa_atexit` on MachO

yln added a comment. Thank you @zequanwu, for providing the minimized reproducer! It really made fixing this much easier! :) I've re-landed the change and added a test specifically for this issue: `lower-global-dtors-existing-dos_handle.ll` Repository: rG LLVM Github Monorepo CHANGES SINC

[clang] 51585aa - [clang][AVR] Implement standard calling convention for AVR and AVRTiny

Author: Ben Shi Date: 2022-03-24T02:08:22Z New Revision: 51585aa240de6ef07979345de5406483d7393b7b URL: https://github.com/llvm/llvm-project/commit/51585aa240de6ef07979345de5406483d7393b7b DIFF: https://github.com/llvm/llvm-project/commit/51585aa240de6ef07979345de5406483d7393b7b.diff LOG: [clan

[PATCH] D120720: [clang][AVR] Implement standard calling convention for AVR and AVRTiny

This revision was automatically updated to reflect the committed changes. Closed by commit rG51585aa240de: [clang][AVR] Implement standard calling convention for AVR and AVRTiny (authored by benshi001). Changed prior to commit: https://reviews.llvm.org/D120720?vs=415734&id=417811#toc Repositor

[PATCH] D122119: [C++20][Modules] Adjust handling of exports of namespaces and using-decls.

ChuanqiXu accepted this revision. ChuanqiXu added a comment. This revision is now accepted and ready to land. In D122119#3402168 , @urnathan wrote: > In D122119#3401322 , @ChuanqiXu > wrote: > >> > > > >> I thin

[PATCH] D120874: [C++20] [Modules] Use '-' as the separator of partitions when searching in filesystems

ChuanqiXu added a comment. @vsapsai @dblaikie I want to make sure if this one would affect clang modules. Or simply, would the name of clang modules contain `:`? (`:` is the separator of C++20 modules partitions.) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120874/new/ https://revie

[PATCH] D120397: [C++20] [Modules] Make the linkage consistent for template and its specialization

This revision was automatically updated to reflect the committed changes. Closed by commit rG847466860887: [C++20] [Modules] Make the linkage consistent for template and its (authored by ChuanqiXu). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D12039

[clang] 8474668 - [C++20] [Modules] Make the linkage consistent for template and its

Author: Chuanqi Xu Date: 2022-03-24T10:24:14+08:00 New Revision: 84746686088799ec9e3cc5ea0a64df81423da290 URL: https://github.com/llvm/llvm-project/commit/84746686088799ec9e3cc5ea0a64df81423da290 DIFF: https://github.com/llvm/llvm-project/commit/84746686088799ec9e3cc5ea0a64df81423da290.diff LO

[clang] f74413d - [clang-format] Fix invalid code generation with comments in lambda

Author: owenca Date: 2022-03-23T19:40:24-07:00 New Revision: f74413d16345c8815c7d1e4676d6aaf732517b8d URL: https://github.com/llvm/llvm-project/commit/f74413d16345c8815c7d1e4676d6aaf732517b8d DIFF: https://github.com/llvm/llvm-project/commit/f74413d16345c8815c7d1e4676d6aaf732517b8d.diff LOG: [

[PATCH] D122301: [clang-format] Fix invalid code generation with comments in lambda

This revision was automatically updated to reflect the committed changes. Closed by commit rGf74413d16345: [clang-format] Fix invalid code generation with comments in lambda (authored by owenpan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122301/

[PATCH] D122160: [clang][extract-api] Refactor ExtractAPI and improve docs

zixuan-wu added inline comments. Comment at: clang/lib/ExtractAPI/Serialization/SymbolGraphSerializer.cpp:159 + switch (Language) { + case Language::C: +return "c"; It's same name as `Language` variable above, and it cause compile error. @zixuw Maybe the e

[PATCH] D122089: [CUDA] Add getTargetFeatures for the NVPTX toolchain

zixuan-wu added inline comments. Comment at: clang/lib/Driver/ToolChains/Cuda.cpp:648 +#define CASE_CUDA_VERSION(CUDA_VER, PTX_VER) \ + case CudaVersion::CUDA_##CUDA_VER: \ +PtxFeature = "+ptx" #PT

[clang] d912232 - [CUDA][FIX] Fix name conflict in getNVPTXTargetFeatures

Author: Joseph Huber Date: 2022-03-23T23:07:51-04:00 New Revision: d91223274145a0c33ab01641902650b249921a43 URL: https://github.com/llvm/llvm-project/commit/d91223274145a0c33ab01641902650b249921a43 DIFF: https://github.com/llvm/llvm-project/commit/d91223274145a0c33ab01641902650b249921a43.diff

[PATCH] D122089: [CUDA] Add getTargetFeatures for the NVPTX toolchain

jhuber6 added inline comments. Comment at: clang/lib/Driver/ToolChains/Cuda.cpp:648 +#define CASE_CUDA_VERSION(CUDA_VER, PTX_VER) \ + case CudaVersion::CUDA_##CUDA_VER: \ +PtxFeature = "+ptx" #PTX_

[PATCH] D122285: [analyzer] Add path note tags to standard library function summaries.

NoQ planned changes to this revision. NoQ added a comment. Ok there's actually a huge bug in this patch, namely we can't say "Assuming..." if there's no state split (i.e., when we know from the start which branch is taken so we don't have to assume). I'll fix. In D122285#3401754

[clang] 86c1d07 - [clang][AVR] Implement standard calling convention for AVR and AVRTiny

Author: Ben Shi Date: 2022-03-24T03:41:01Z New Revision: 86c1d075bb32101fe1c403e873ce33945bfa9626 URL: https://github.com/llvm/llvm-project/commit/86c1d075bb32101fe1c403e873ce33945bfa9626 DIFF: https://github.com/llvm/llvm-project/commit/86c1d075bb32101fe1c403e873ce33945bfa9626.diff LOG: [clan

[PATCH] D122089: [CUDA] Add getTargetFeatures for the NVPTX toolchain

zixuan-wu added inline comments. Comment at: clang/lib/Driver/ToolChains/Cuda.cpp:648 +#define CASE_CUDA_VERSION(CUDA_VER, PTX_VER) \ + case CudaVersion::CUDA_##CUDA_VER: \ +PtxFeature = "+ptx" #PT

[PATCH] D120449: [RISCV][RVV] Add strict vfcvt intrinsics that have side effects for dynamically-set rounding mode

arcbbb planned changes to this revision. arcbbb added a comment. Herald added a subscriber: StephenFan. I started a discussion on how RVV clang builtins interact with FENV_ACCESS in https://github.com/riscv-non-isa/rvv-intrinsic-doc/issues/147 I would drop this patch if those builtins are going t

[PATCH] D122370: Split up large test files under clang/test/CodeGen/RISCV

4vtomat created this revision. Herald added subscribers: s, VincentWu, luke957, vkmr, frasercrmck, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, kito-cheng, niosHD, sabuasal, s

[PATCH] D122370: Split up large test files under clang/test/CodeGen/RISCV

MaskRay added a comment. I assume this is to improve test parallelism. Do you have runtime comparison? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122370/new/ https://reviews.llvm.org/D122370 ___ cfe-c

[PATCH] D122370: Split up large test files under clang/test/CodeGen/RISCV

4vtomat added a comment. In D122370#3404590 , @MaskRay wrote: > I assume this is to improve test parallelism. Do you have runtime comparison? actually, this is to prevent single file from timeout due to many test cases, such as https://reviews.llvm.org/

[clang] b8388fa - [clang][NFC] Fix warning of integer comparison

Author: Kai Luo Date: 2022-03-24T14:06:45+08:00 New Revision: b8388fa319bc68bee396a14857331fb2e7b815bd URL: https://github.com/llvm/llvm-project/commit/b8388fa319bc68bee396a14857331fb2e7b815bd DIFF: https://github.com/llvm/llvm-project/commit/b8388fa319bc68bee396a14857331fb2e7b815bd.diff LOG:

[PATCH] D100581: [Clang] -Wunused-but-set-parameter and -Wunused-but-set-variable

xbolva00 added a comment. Herald added subscribers: pcwang-thead, luke957. Herald added a project: All. @mbenfield found false positive void test(void) { static int counter = 0; counter += 5; } Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[clang] 5b6b840 - Revert "[Clang] -Wunused-but-set-variable warning - handle also pre/post unary operators"

Author: Dávid Bolvanský Date: 2022-03-24T07:44:51+01:00 New Revision: 5b6b840531fa05093a4099699b0cda881fbadef8 URL: https://github.com/llvm/llvm-project/commit/5b6b840531fa05093a4099699b0cda881fbadef8 DIFF: https://github.com/llvm/llvm-project/commit/5b6b840531fa05093a4099699b0cda881fbadef8.dif

[clang] dc46fa4 - [NFCI] Fix set-but-unused warning in ExprConstant.cpp

Author: Dávid Bolvanský Date: 2022-03-24T07:47:50+01:00 New Revision: dc46fa41d46e3cace9dbdc0b2c7b61d206b03165 URL: https://github.com/llvm/llvm-project/commit/dc46fa41d46e3cace9dbdc0b2c7b61d206b03165 DIFF: https://github.com/llvm/llvm-project/commit/dc46fa41d46e3cace9dbdc0b2c7b61d206b03165.dif

[clang] a683ba4 - [NFCI] Fix set-but-unused warning in CGOpenMPRuntime.cpp

Author: Dávid Bolvanský Date: 2022-03-24T07:49:21+01:00 New Revision: a683ba4ff5a04025ad5221ef2262195212a51577 URL: https://github.com/llvm/llvm-project/commit/a683ba4ff5a04025ad5221ef2262195212a51577 DIFF: https://github.com/llvm/llvm-project/commit/a683ba4ff5a04025ad5221ef2262195212a51577.dif

[PATCH] D122285: [analyzer] Add path note tags to standard library function summaries.

steakhal added a comment. > The notes are prunable, i.e. they won't bring-in entire stack frames worth of > notes just because they're there, but they will be always visible regardless > of whether the value is of interest to the bug report. I think this is > debatable, the arguably better solu

[PATCH] D122277: [analyzer] Fix crash in RangedConstraintManager.cpp

vabridgers updated this revision to Diff 417525. vabridgers added a comment. update comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122277/new/ https://reviews.llvm.org/D122277 Files: clang/lib/StaticAnalyzer/Core/RangedConstraintManager.c

[PATCH] D122237: [clang][lex] Fix failures with Microsoft header search rules

jansvoboda11 updated this revision to Diff 417527. jansvoboda11 added a comment. Remove slash from test to make it pass on Windows Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122237/new/ https://reviews.llvm.org/D122237 Files: clang/lib/Lex/He

[PATCH] D121824: [clang] Do not crash on arrow operator on dependent type.

hokein accepted this revision. hokein added a comment. OK, let's move forward with it. Thanks for the investigation and the fix! I will take a look on the invalid-bit problem, and monitor the crash report more closely. Comment at: clang/lib/Sema/TreeTransform.h:14708 } els

[PATCH] D70401: [RISCV] Complete RV32E/ilp32e implementation

pcwang-thead added a comment. Herald added a subscriber: StephenFan. In D70401#3391561 , @khchen wrote: > I found > https://github.com/llvm/llvm-test-suite/blob/main/SingleSource/UnitTests/2003-05-26-Shorts.c > result is mismatched with gcc's (-march=rv3

[PATCH] D122298: [clang-cl] Ignore /Wv and /Wv:17 flags

thieta created this revision. thieta added reviewers: hans, mstorsjo, rnk. Herald added a project: All. thieta requested review of this revision. Herald added a reviewer: jdoerfert. Herald added a subscriber: sstefan1. Herald added a project: clang. MSVC supports passing /Wv and /Wv:17 to ignore w

[PATCH] D122249: [Clang] Add a compatibiliy warning for non-literals in constexpr.

cor3ntin updated this revision to Diff 417534. cor3ntin added a comment. - Check That the type is dependant - Only emit the warning when Kind == Sema::CheckConstexprKind::Diagnose Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122249/new/ https://re

[PATCH] D122298: [clang-cl] Ignore /Wv and /Wv:17 flags

thieta updated this revision to Diff 417533. thieta added a comment. Added back removed blank line Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122298/new/ https://reviews.llvm.org/D122298 Files: clang/include/clang/Driver/Options.td clang/te

[PATCH] D122249: [Clang] Add a compatibiliy warning for non-literals in constexpr.

cor3ntin updated this revision to Diff 417535. cor3ntin added a comment. Formatting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122249/new/ https://reviews.llvm.org/D122249 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td clang/lib/Se

[PATCH] D122298: [clang-cl] Ignore /Wv and /Wv:17 flags

thieta added inline comments. Comment at: clang/include/clang/Driver/Options.td:2496 Group, Flags<[CC1Option, NoArgumentUnused, HelpHidden]>; -def fopenmp_assume_no_thread_state : Flag<["-"], "fopenmp-assume-no-thread-state">, Group, - Flags<[CC1Option, NoArgumentUnused, He

[PATCH] D122249: [Clang] Add a compatibiliy warning for non-literals in constexpr.

cor3ntin added inline comments. Comment at: clang/lib/Sema/SemaDeclCXX.cpp:1905 +if (SemaRef.LangOpts.CPlusPlus2b) { + if (!VD->getType()->isLiteralType(SemaRef.Context)) +SemaRef.Diag(VD->getLocation(), hubert.reinterpretcast wrote:

[PATCH] D122298: [clang-cl] Ignore /Wv and /Wv:17 flags

mstorsjo accepted this revision. mstorsjo added a comment. This revision is now accepted and ready to land. The patch itself seems sensible to me. Comment at: clang/include/clang/Driver/Options.td:2496 Group, Flags<[CC1Option, NoArgumentUnused, HelpHidden]>; -def fopenmp_ass

[PATCH] D118052: [X86] Fix CodeGen Module Flag for -mibt-seal

joaomoreira added a comment. I did track down the problem to clang/lib/Frontend/CompilerInvocation.cpp -- RoundTrip method. There, we can se the following statement: #ifndef NDEBUG bool DoRoundTripDefault = true; #else bool DoRoundTripDefault = false; #endif Comment in the file sa

[PATCH] D122231: [clang][dataflow] Add support for `value_or` in a comparison.

sgatev added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/Models/UncheckedOptionalAccessModel.cpp:119 + auto NonEmptyStringOptional = unaryOperator( + hasOperatorName("!"), + hasUnaryOperand(cxxMemberCallExpr( Why handle negation here

[PATCH] D122298: [clang-cl] Ignore /Wv and /Wv:17 flags

thieta updated this revision to Diff 417537. thieta added a comment. Split whitespace to it's own commit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122298/new/ https://reviews.llvm.org/D122298 Files: clang/include/clang/Driver/Options.td cl

[PATCH] D122278: [clang] Improve diagnostic for reopened inline namespace

cor3ntin accepted this revision. cor3ntin added a comment. This revision is now accepted and ready to land. This looks good to me, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122278/new/ https://reviews.llvm.org/D122278 _

[clang] 09c0685 - [NFC] Remove trailing whitespaces in clang/Driver/Options.td

Author: Tobias Hieta Date: 2022-03-23T10:23:33+01:00 New Revision: 09c0685a043dd4028545c134b562c2605e294855 URL: https://github.com/llvm/llvm-project/commit/09c0685a043dd4028545c134b562c2605e294855 DIFF: https://github.com/llvm/llvm-project/commit/09c0685a043dd4028545c134b562c2605e294855.diff

[PATCH] D122298: [clang-cl] Ignore /Wv and /Wv:17 flags

thieta added a comment. Pushed the whitespace fix as a NFC here: https://github.com/llvm/llvm-project/commit/09c0685a043dd4028545c134b562c2605e294855 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122298/new/ https://reviews.llvm.org/D122298 _

[clang] 27f6cee - Revert "[CodeGen] Avoid deprecated Address ctor in EmitLoadOfPointer()"

Author: Nikita Popov Date: 2022-03-23T10:24:39+01:00 New Revision: 27f6cee12d2ab52e44e78d26733ab92ced730f13 URL: https://github.com/llvm/llvm-project/commit/27f6cee12d2ab52e44e78d26733ab92ced730f13 DIFF: https://github.com/llvm/llvm-project/commit/27f6cee12d2ab52e44e78d26733ab92ced730f13.diff

[PATCH] D118052: [X86] Fix CodeGen Module Flag for -mibt-seal

joaomoreira updated this revision to Diff 417539. joaomoreira edited the summary of this revision. joaomoreira added a reviewer: nickdesaulniers. This revision is now accepted and ready to land. Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https

[clang] a451a29 - [CodeGen][OpenMP] Add alignment to test (NFC)

Author: Nikita Popov Date: 2022-03-23T10:28:04+01:00 New Revision: a451a291278b22b031b2b6d8ca4a3b2517a491f6 URL: https://github.com/llvm/llvm-project/commit/a451a291278b22b031b2b6d8ca4a3b2517a491f6 DIFF: https://github.com/llvm/llvm-project/commit/a451a291278b22b031b2b6d8ca4a3b2517a491f6.diff

[PATCH] D122189: [Clang][NeonEmitter] emit ret decl first for -Wdeclaration-after-statement

DavidSpickett accepted this revision. DavidSpickett added a comment. This revision is now accepted and ready to land. This LGTM with the test only requiring Arm. Please mention in the commit that it is possible to ignore this warning in system headers, but we chose not to because of potential fa

[PATCH] D121593: [clangd][WIP] Provide clang-include-cleaner

xbolva00 added a comment. This sounds really cool! >> Overall I suspect making this a tidy check would make it more useful to more >> people. Yup, it would be super useful addition. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121593/new/ https

[clang] eb5ecbb - [llvm][AArch64] Insert "bti j" after call to setjmp

Author: David Spickett Date: 2022-03-23T09:51:02Z New Revision: eb5ecbbcbb6ce38e29237ab5d17156fcb2e96e74 URL: https://github.com/llvm/llvm-project/commit/eb5ecbbcbb6ce38e29237ab5d17156fcb2e96e74 DIFF: https://github.com/llvm/llvm-project/commit/eb5ecbbcbb6ce38e29237ab5d17156fcb2e96e74.diff LOG

[PATCH] D121707: [llvm][AArch64] Insert "bti j" after call to setjmp

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGeb5ecbbcbb6c: [llvm][AArch64] Insert "bti j" after call to setjmp (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D121451: [clang-format] Add space to comments starting with '#'.

MyDeveloperDay added a comment. I'm a little uncomfortable with //# becoming // # Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121451/new/ https://reviews.llvm.org/D121451 ___ cfe-commits mailing

[PATCH] D122141: [clang][extract-api] Suppprt for the module name property in SymbolGraph

dang added a comment. In D122141#3400578 , @zixuw wrote: > LGTM. Need to rebase. Do you think `ProductName` should be a general property > of `APISerializer` or something specific to the `SymbolGraphSerializer`? Good question! I think I am going to make

[PATCH] D122298: [clang-cl] Ignore /Wv and /Wv:17 flags

hans accepted this revision. hans added a comment. Looks great, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122298/new/ https://reviews.llvm.org/D122298 ___ cfe-commits mailing list cfe-commits

[PATCH] D122141: [clang][extract-api] Suppprt for the module name property in SymbolGraph

dang updated this revision to Diff 417551. dang added a comment. Rebasing on top of latest main which includes https://reviews.llvm.org/rG89f6b26f1beb2c1344f5cfeb34e405128544c76b Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122141/new/ https://re

[PATCH] D118493: Set rpath on openmp executables

JonChesterfield added a comment. In D118493#3401448 , @tstellar wrote: > The rule that is broken is "standard RPATHs" Fedora installs libomp to > /usr/lib64. > > ... > > I think what we'll do in Fedora is just add -fno-openmp-implicit-rpath to > the d

[clang] ba2be80 - [CGOpenMPRuntime] Reuse getDepobjElements() (NFC)

Author: Nikita Popov Date: 2022-03-23T11:31:49+01:00 New Revision: ba2be802b04a19c2398401867de3746df1bad7d6 URL: https://github.com/llvm/llvm-project/commit/ba2be802b04a19c2398401867de3746df1bad7d6 DIFF: https://github.com/llvm/llvm-project/commit/ba2be802b04a19c2398401867de3746df1bad7d6.diff

[PATCH] D118052: [X86] Fix CodeGen Module Flag for -mibt-seal

pengfei accepted this revision. pengfei added a comment. LGTM. Comment at: clang/test/CodeGen/X86/x86-cf-protection.c:6 +// RUN: %clang -target i386-unknown-unknown -o - -emit-llvm -S -fcf-protection=branch -flto %s | FileCheck %s --check-prefix=NOIBTSEAL +// RUN: %clang -targ

<    1   2   3   4   >