[PATCH] D120639: [RISCV] Pass -mno-relax to assembler when -fno-integrated-as specified

StephenFan added a comment. Herald added subscribers: s, arichardson. Ping :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120639/new/ https://reviews.llvm.org/D120639 ___ cfe-commits mailing list cfe-c

[PATCH] D121345: [RISCV] Add +experimental-zvfh extension to cover half types in vectors.

kito-cheng accepted this revision. kito-cheng added a comment. This revision is now accepted and ready to land. Herald added subscribers: s, arichardson. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121345/new/ https://reviews.llvm.org/D12134

[PATCH] D121749: [clang-format][docs] Regenerate ClangFormatStyleOptions.rst

kuzkry added a subscriber: MyDeveloperDay. kuzkry added a comment. I removed @MyDeveloperDay, as this is a trivial PR and already got 3 approvals. Anyway, could someone please deliver this one for me? My name and email in git format is "Krystian Kuzniarek " Repository: rG LLVM Github Monorep

[PATCH] D119479: [clang][extract-api] Add global record support

uabelho added a comment. Hello, Did you see this sanitizer error when running global_record.c? https://lab.llvm.org/buildbot/#/builders/5/builds/20765/steps/13/logs/stdio Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119479/new/ https://reviews.l

[clang] 34ce42f - [clang-format] Reformat. NFC.

Author: Marek Kurdej Date: 2022-03-17T09:27:31+01:00 New Revision: 34ce42fe4de5318176e13e4cb758dfa7a0d8176b URL: https://github.com/llvm/llvm-project/commit/34ce42fe4de5318176e13e4cb758dfa7a0d8176b DIFF: https://github.com/llvm/llvm-project/commit/34ce42fe4de5318176e13e4cb758dfa7a0d8176b.diff

[clang] e2a1f8e - Reland "[clang][driver] Emit a warning if -xc/-xc++ is after the last input file"

Author: Yi Kong Date: 2022-03-17T16:31:01+08:00 New Revision: e2a1f8ec27b88be670cd867c43588f24516d2bbf URL: https://github.com/llvm/llvm-project/commit/e2a1f8ec27b88be670cd867c43588f24516d2bbf DIFF: https://github.com/llvm/llvm-project/commit/e2a1f8ec27b88be670cd867c43588f24516d2bbf.diff LOG:

[clang] dc142ea - [clang-format] Correctly recognize binary operators in template arguments with parenthesized literals.

Author: Marek Kurdej Date: 2022-03-17T09:36:25+01:00 New Revision: dc142ea184a526fb2879f84c4c82fff195d36b9d URL: https://github.com/llvm/llvm-project/commit/dc142ea184a526fb2879f84c4c82fff195d36b9d DIFF: https://github.com/llvm/llvm-project/commit/dc142ea184a526fb2879f84c4c82fff195d36b9d.diff

[PATCH] D121846: [clang-format] Correctly recognize binary operators in template arguments with parenthesized literals.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. curdeius marked an inline comment as done. Closed by commit rGdc142ea184a5: [clang-format] Correctly recognize binary operators in template arguments with… (authored by

[clang] 45cb2df - [clang-format][docs] Regenerate ClangFormatStyleOptions.rst

Author: Krystian Kuzniarek Date: 2022-03-17T09:45:43+01:00 New Revision: 45cb2df6788ca96a2ed6e9638b803563f51466f2 URL: https://github.com/llvm/llvm-project/commit/45cb2df6788ca96a2ed6e9638b803563f51466f2 DIFF: https://github.com/llvm/llvm-project/commit/45cb2df6788ca96a2ed6e9638b803563f51466f2.

[PATCH] D121749: [clang-format][docs] Regenerate ClangFormatStyleOptions.rst

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG45cb2df6788c: [clang-format][docs] Regenerate ClangFormatStyleOptions.rst (authored by kuzkry, committed by curdeius). Repository: rG LLVM Github

[clang-tools-extra] 5a62495 - [pseudo] Fix some naming-style violations.

Author: Haojian Wu Date: 2022-03-17T09:47:24+01:00 New Revision: 5a624956ced826745447dd95381624fb4bb10a7f URL: https://github.com/llvm/llvm-project/commit/5a624956ced826745447dd95381624fb4bb10a7f DIFF: https://github.com/llvm/llvm-project/commit/5a624956ced826745447dd95381624fb4bb10a7f.diff LO

[PATCH] D121890: [clang-format] Copy help options to the doc directory.

sstwcw created this revision. sstwcw added a reviewer: clang-format. sstwcw added a project: clang-format. Herald added a project: All. sstwcw requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The options listed in ClangFormat.rst lag behind

[PATCH] D121890: [clang-format] Copy help options to the doc directory.

sstwcw updated this revision to Diff 416097. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121890/new/ https://reviews.llvm.org/D121890 Files: clang/docs/ClangFormat.rst Index: clang/docs/ClangFormat.rst ==

[PATCH] D121890: [clang-format] Copy help options to the doc directory.

sstwcw added a comment. If anyone's wondering why all the lines changed. The `--qualifier-alignment` is too long so all the descriptions are moved to the right. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121890/new/ https://reviews.llvm.org/D1

[PATCH] D121792: [AArch64][SVE] InstCombine llvm.aarch64.sve.sel to select

dmgreen added a comment. Why do we have llvm.aarch64.sve.sel if we are always going to replace it with a select? Why not remove llvm.aarch64.sve.sel entirely? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121792/new/ https://reviews.llvm.org/D1217

[PATCH] D121497: Lex: add support for `{,u}i128` Microsoft extension

iains added a subscriber: vsapsai. iains added a comment. hmm that makes it quite hard to analyse what's going on ... .. however, it seems that this is a clang-modules style build (I am more familiar with the C++20 modules stuff, so probably @vsapsai will be able to throw more light on this). h

[PATCH] D121890: [clang-format] Copy help options to the doc directory.

curdeius added inline comments. Comment at: clang/docs/ClangFormat.rst:76 +--output-replacements-xml - Output replacements as XML. +--qualifier-alignment= - If set, overrides the qualifier alignment style determined by the QualifierAlignment style flag +--sort-i

[PATCH] D121792: [AArch64][SVE] InstCombine llvm.aarch64.sve.sel to select

peterwaller-arm added a comment. In D121792#3388585 , @dmgreen wrote: > Why do we have llvm.aarch64.sve.sel if we are always going to replace it with > a select? Why not remove llvm.aarch64.sve.sel entirely? I'm not the key decisionmaker here, but hopef

[PATCH] D119792: [Clang] [P2025] Analyze only potential scopes for NRVO

Izaron updated this revision to Diff 416116. Izaron added a comment. Herald added a project: All. Rebased the patch on top of D119927 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119792/new/ https://reviews.llvm.

[PATCH] D121816: [Clang][VE] Add vector mask intrinsics to clang

kaz7 added a comment. Having timeout errors on lldb-aarch64-ubuntu builder... I'm not sure what modification on this patch causes a such error. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121816/new/ https://reviews.llvm.org/D121816 __

[PATCH] D121816: [Clang][VE] Add vector mask intrinsics to clang

simoll added a comment. In D121816#3388748 , @kaz7 wrote: > Having timeout errors on lldb-aarch64-ubuntu builder... I'm not sure what > modification on this patch causes a such error. There's another commit tested in the failing run: https://lab.llvm.

[clang] 4e4f839 - [X86] Use the unaligned vector typedefs for the lddqu intrinsics pointer arguments (PR20670)

Author: Simon Pilgrim Date: 2022-03-17T10:42:29Z New Revision: 4e4f839ac2a9002df504f1bed8383c2d7d72e86e URL: https://github.com/llvm/llvm-project/commit/4e4f839ac2a9002df504f1bed8383c2d7d72e86e DIFF: https://github.com/llvm/llvm-project/commit/4e4f839ac2a9002df504f1bed8383c2d7d72e86e.diff LOG:

[PATCH] D121815: [X86] Use the unaligned vector typedefs for the lddqu intrinsics pointer arguments (PR20670)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4e4f839ac2a9: [X86] Use the unaligned vector typedefs for the lddqu intrinsics pointer… (authored by RKSimon). Repository: rG LLVM Github Monorepo

[PATCH] D121445: [Clang][CSKY] Add the CSKY target and compiler driver

rengolin added inline comments. Comment at: clang/test/Driver/csky-arch-error.c:1 +// RUN: %clang -target csky-unknown-elf -march=csky -### %s \ +// RUN: -fsyntax-only 2>&1 | FileCheck -check-prefix=CSKY %s This will error out and fail the test. You need to add a

[PATCH] D121445: [Clang][CSKY] Add the CSKY target and compiler driver

rengolin added a comment. I'm surprised these tests are passing for you. Perhaps you're not building or running them all. To make sure you're running your tests, you need to build both clang and llvm (`-DLLVM_ENABLE_PROJECTS=clang`) and run ninja/make `check-all`. You can also run `lit` direct

[PATCH] D121863: [clang][dataflow] Model the behavior of non-standard optional assignment

sgatev updated this revision to Diff 416132. sgatev marked 3 inline comments as done. sgatev added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121863/new/ https://reviews.llvm.org/D121863 Files: clang/include/clan

[PATCH] D121863: [clang][dataflow] Model the behavior of non-standard optional assignment

sgatev added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/Models/UncheckedOptionalAccessModel.cpp:81 +auto isOptionalValueOrConversionAssignment() { + return cxxOperatorCallExpr( xazax.hun wrote: > While really like the convenience matchers w

[PATCH] D121445: [Clang][CSKY] Add the CSKY target and compiler driver

DavidSpickett added a comment. > You can also run lit directly on each test, but I can't remember how to do > that now... If you're in the build dir: ./bin/llvm-lit ../llvm-project/clang/test/.. -a (-a gives you full output of what happens) Some tests are a bit odd when you do this but

[PATCH] D121497: Lex: add support for `{,u}i128` Microsoft extension

aaron.ballman added a comment. In D121497#3388024 , @compnerd wrote: > I don't have an example module sadly. It was something that I ran into with > Swift code import the WinSDK module defined in > https://github.com/apple/swift/blob/main/stdlib/public

[PATCH] D119470: [clang-tidy] Don't check decltype return types in `readability-const-return-type`

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Comment at: clang-tools-extra/clang-tidy/readability/ConstReturnTypeCheck.cpp:56-58 +AST_MATCHER(QualType, isLocalConstQualified) { + return Node.isLoca

[clang-tools-extra] 6043520 - [clang-tidy] Don't check decltype return types in `readability-const-return-type`

Author: Evgeny Shulgin Date: 2022-03-17T14:27:09+03:00 New Revision: 6043520c207269ccdbfe70e63ab48118d5735deb URL: https://github.com/llvm/llvm-project/commit/6043520c207269ccdbfe70e63ab48118d5735deb DIFF: https://github.com/llvm/llvm-project/commit/6043520c207269ccdbfe70e63ab48118d5735deb.diff

[PATCH] D119470: [clang-tidy] Don't check decltype return types in `readability-const-return-type`

This revision was automatically updated to reflect the committed changes. Closed by commit rG6043520c2072: [clang-tidy] Don't check decltype return types in `readability-const-return… (authored by Izaron). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[clang-tools-extra] 9e1f4f1 - [clang-tidy][run-clang-tidy.py] Add --config-file= option

Author: Shreyas Atre Date: 2022-03-17T07:30:28-04:00 New Revision: 9e1f4f13984186984ba37513372c1b7e0c4ba4fd URL: https://github.com/llvm/llvm-project/commit/9e1f4f13984186984ba37513372c1b7e0c4ba4fd DIFF: https://github.com/llvm/llvm-project/commit/9e1f4f13984186984ba37513372c1b7e0c4ba4fd.diff

[PATCH] D120331: [clang-tidy][run-clang-tidy.py] Add --config-file= option

aaron.ballman closed this revision. aaron.ballman added a comment. In D120331#3384889 , @SAtacker wrote: > Gentle reminder to commit on my behalf > @JonasToth > @alexfh > @aaron.ballman > @njames93 > @LegalizeAdulthood > > Thank yo

[PATCH] D121824: [clang] Do not crash on arrow operator on dependent type.

hokein added a comment. Thanks for looking at this. It seems an issue caused by https://reviews.llvm.org/D120812 (sorry), where we build a recovery-expr to model declrefexpr pointing to an invalid decl. Comment at: clang/lib/Sema/TreeTransform.h:14709 // -> is never a bu

[PATCH] D118259: [AArch64] Adjust aarch64-neon-intrinsics-constrained test and un-XFAIL

john.brawn added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118259/new/ https://reviews.llvm.org/D118259 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org

[PATCH] D115620: [AArch64] Lowering and legalization of strict FP16

john.brawn updated this revision to Diff 416141. john.brawn set the repository for this revision to rG LLVM Github Monorepo. john.brawn added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Rebase and ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[PATCH] D118259: [AArch64] Adjust aarch64-neon-intrinsics-constrained test and un-XFAIL

fhahn added a comment. In D118259#3343554 , @john.brawn wrote: > In D118259#3275297 , @fhahn wrote: > >> Does this clang test actually need to check the generated assembly? >> Shouldn't it be enough to check tha

[PATCH] D121890: [clang-format] Copy help options to the doc directory.

sstwcw added inline comments. Comment at: clang/docs/ClangFormat.rst:76 +--output-replacements-xml - Output replacements as XML. +--qualifier-alignment= - If set, overrides the qualifier alignment style determined by the QualifierAlignment style flag +--sort-inc

[PATCH] D121556: [randstruct] Add randomize structure layout support

aaron.ballman added a comment. Thank you for working on this new security feature! I like it and I think it's heading in the right direction. Can you please add a release note for the new functionality? This is missing tests for the Driver diagnostics, the Sema diagnostics (including existing

[PATCH] D120857: WIP [randstruct] Add randomize structure layout support

aaron.ballman added a comment. This seems like a duplicate of https://reviews.llvm.org/D121556 -- should this review be abandoned? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120857/new/ https://reviews.llvm.org/D120857

[clang] ab982ea - [Sema] add warning for tautological FP compare with literal

Author: Sanjay Patel Date: 2022-03-17T08:22:30-04:00 New Revision: ab982eace6e4951a2986567d29f4d6be002c1ba7 URL: https://github.com/llvm/llvm-project/commit/ab982eace6e4951a2986567d29f4d6be002c1ba7 DIFF: https://github.com/llvm/llvm-project/commit/ab982eace6e4951a2986567d29f4d6be002c1ba7.diff

[PATCH] D121906: [clang-format] Indent import statements in JavaScript.

sstwcw created this revision. sstwcw added a reviewer: clang-format. sstwcw added a project: clang-format. Herald added a project: All. sstwcw requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. [clang-format] Indent import statements in JavaSc

[PATCH] D121306: [Sema] add warning for tautological FP compare with literal

This revision was automatically updated to reflect the committed changes. Closed by commit rGab982eace6e4: [Sema] add warning for tautological FP compare with literal (authored by spatel). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo

[PATCH] D121907: [clang-format] Use an enum for context types.

sstwcw created this revision. sstwcw added a reviewer: clang-format. sstwcw added a project: clang-format. Herald added a project: All. sstwcw requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. We currently have all those fields in AnnotatingP

[PATCH] D121678: [pseudo] Split greatergreater token.

hokein updated this revision to Diff 416153. hokein added a comment. Herald added a project: clang-tools-extra. rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121678/new/ https://reviews.llvm.org/D121678 Files: clang-tools-extra/pseudo/in

[clang-tools-extra] f66d375 - [pseudo] Split greatergreater token.

Author: Haojian Wu Date: 2022-03-17T13:46:58+01:00 New Revision: f66d3758bda99e9f57bfdad168212feda18792ae URL: https://github.com/llvm/llvm-project/commit/f66d3758bda99e9f57bfdad168212feda18792ae DIFF: https://github.com/llvm/llvm-project/commit/f66d3758bda99e9f57bfdad168212feda18792ae.diff LO

[PATCH] D121678: [pseudo] Split greatergreater token.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf66d3758bda9: [pseudo] Split greatergreater token. (authored by hokein). Changed prior to commit: https://reviews.llvm.org/D121678?vs=416153&id=41

[PATCH] D121890: [clang-format] Copy help options to the doc directory.

MyDeveloperDay requested changes to this revision. MyDeveloperDay added a comment. This revision now requires changes to proceed. 1. Please log a github issue showing us what you are fixing. 2. Please add the main clang-formatter developers as reviewers and not the clang-format project (I think w

[PATCH] D121757: [clang-format] Take out common code for parsing blocks

sstwcw marked an inline comment as done. sstwcw added a comment. This patch is only intended to reduce the number of times the functionality gets implemented separately. Any change in behavior would be unintended. And we also use the `parseIndentedBlock` in Verilog stuff, so it's not just two

[PATCH] D121758: [clang-format] Add support for formatting Verilog code

MyDeveloperDay added a comment. Abandoned? huh? are you breaking it apart? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121758/new/ https://reviews.llvm.org/D121758 ___ cfe-commits mailing list cfe-comm

[clang-tools-extra] eb265e3 - [clangd] Re-enable clang-tidy's nolint blocks

Author: Haojian Wu Date: 2022-03-17T13:48:55+01:00 New Revision: eb265e3ba28dbac6d6c18674ae603428753559e9 URL: https://github.com/llvm/llvm-project/commit/eb265e3ba28dbac6d6c18674ae603428753559e9 DIFF: https://github.com/llvm/llvm-project/commit/eb265e3ba28dbac6d6c18674ae603428753559e9.diff LO

[PATCH] D119701: [clangd] Re-enable clang-tidy's nolint blocks

This revision was automatically updated to reflect the committed changes. Closed by commit rGeb265e3ba28d: [clangd] Re-enable clang-tidy's nolint blocks (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119701/new/ https://reviews.

[PATCH] D121757: [clang-format] Take out common code for parsing blocks

MyDeveloperDay added a comment. Just an observation, I have this in my Day Job all the time.. 1. Developer A develops a piece of code 2. Over the years the developers in our group learn that code and become familiar with it 3. Developer B arrives in our group, telling us we are doing it all wron

[clang-tools-extra] 30de15e - [pseudo] Tweak some docs, NFC

Author: Haojian Wu Date: 2022-03-17T13:58:42+01:00 New Revision: 30de15e100ccb8a53f73f8c826902d67eced50ec URL: https://github.com/llvm/llvm-project/commit/30de15e100ccb8a53f73f8c826902d67eced50ec DIFF: https://github.com/llvm/llvm-project/commit/30de15e100ccb8a53f73f8c826902d67eced50ec.diff LO

[PATCH] D121749: [clang-format][docs] Regenerate ClangFormatStyleOptions.rst

MyDeveloperDay added inline comments. Comment at: clang/docs/ClangFormatStyleOptions.rst:361 - * ``bool AlignCompound`` Only for ``AlignConsecutiveAssignments``. Whether compound -assignments like ``+=`` are aligned along with ``=``. + * ``bool AlignCompound`` Only for

[PATCH] D119792: [Clang] [P2025] Analyze only potential scopes for NRVO

erichkeane added a comment. So P2025 has not successfully made it through EWG, so this would have to be under a 'flag'. Also, I believe this will end up being applied to C++23, so it would have to be under a C++23 flag, even when we make it a default behavior.

[PATCH] D117522: [clang-tidy] Add modernize-macro-to-enum check

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/modernize/MacroToEnumCheck.cpp:47 +CRLF, +CRLFCR, + }; LegalizeAdulthood wrote: > aaron.ballman wrote: > > I'm a bit confused by this one as this is not a valid line ending (it

[PATCH] D121096: [C++20][Modules][HU 2/5] Support searching Header Units in user or system search paths.

iains updated this revision to Diff 416162. iains marked an inline comment as done. iains added a comment. match windows path delimiters in testcase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121096/new/ https://reviews.llvm.org/D121096 Files:

[PATCH] D121096: [C++20][Modules][HU 2/5] Support searching Header Units in user or system search paths.

iains added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:2855-2857 + assert((DashX.getHeaderUnit() == InputKind::HeaderUnit_None || + Inputs.size() == 1) && + "Expected only one input file for header unit"); ChuanqiXu w

[PATCH] D118259: [AArch64] Adjust aarch64-neon-intrinsics-constrained test and un-XFAIL

john.brawn added a comment. llvm/test/CodeGen/AArch64/fp-intrinsics-vector.ll is testing the asm generation, so it probably is fine to remove that here so I will. This test is specifically testing arm_neon.h intrinsics though, so wouldn't make sense unifying with other architectures. Reposito

[PATCH] D121890: [clang-format] Copy help options to the doc directory.

sstwcw marked an inline comment as done. sstwcw added a comment. The issue is #54418. Actually I don't know who I should add as reviewers. The patches for clang-format don't always seem to have the same reviewers. Who are the main developers and how do you decide who you add each time? I give

[PATCH] D121578: [RISCV][NFC] Add tests to address invalid arch dependencies.

asb accepted this revision. asb added a comment. This revision is now accepted and ready to land. Herald added subscribers: s, arichardson. Thanks, this looks good to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121578/new/ https://reviews.llv

[PATCH] D121758: [clang-format] Add support for formatting Verilog code

sstwcw added a comment. Yes. I am surprised that you asked since everyone asked me to break it apart. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121758/new/ https://reviews.llvm.org/D121758 ___ cfe-c

[PATCH] D118370: [clang-tidy] bugprone-signal-handler: Message improvement and code refactoring.

whisperity added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/SignalHandlerCheck.cpp:159-160 Itr != ItrE; ++Itr) { const auto *CallF = dyn_cast((*Itr)->getDecl()); -if (CallF && !isFunctionAsyncSafe(CallF)) { - assert(Itr.getPathLength(

[PATCH] D121749: [clang-format][docs] Regenerate ClangFormatStyleOptions.rst

sstwcw added inline comments. Comment at: clang/docs/ClangFormatStyleOptions.rst:361 - * ``bool AlignCompound`` Only for ``AlignConsecutiveAssignments``. Whether compound -assignments like ``+=`` are aligned along with ``=``. + * ``bool AlignCompound`` Only for ``AlignC

[PATCH] D121749: [clang-format][docs] Regenerate ClangFormatStyleOptions.rst

curdeius added inline comments. Comment at: clang/docs/ClangFormatStyleOptions.rst:361 - * ``bool AlignCompound`` Only for ``AlignConsecutiveAssignments``. Whether compound -assignments like ``+=`` are aligned along with ``=``. + * ``bool AlignCompound`` Only for ``Alig

[PATCH] D121749: [clang-format][docs] Regenerate ClangFormatStyleOptions.rst

curdeius added inline comments. Comment at: clang/docs/ClangFormatStyleOptions.rst:361 - * ``bool AlignCompound`` Only for ``AlignConsecutiveAssignments``. Whether compound -assignments like ``+=`` are aligned along with ``=``. + * ``bool AlignCompound`` Only for ``Alig

[PATCH] D120639: [RISCV] Pass -mno-relax to assembler when -fno-integrated-as specified

asb accepted this revision. asb added a comment. This revision is now accepted and ready to land. It would be good to have someone else who's reviewed earlier versions of this patch to confirm, but this LGTM. Thanks. If you were editing it anyway, you could change "has passed" to "is passed" (t

[PATCH] D116385: [clangd] Code action for creating an ObjC initializer

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Thanks, and sorry for the long delay. Comment at: clang-tools-extra/clangd/refactor/tweaks/ObjCMemberwiseInitializer.cpp:282 + Anchor::Above}}; + llvm::SmallVec

[PATCH] D121757: [clang-format] Take out common code for parsing blocks

sstwcw added a comment. For the new stuff I have the option of still adding the function `parseIndentedBlock` but only using it in new code. Please be more blunt about whether I should close this revision and do it that way. I guess I might have misunderstood you before from how you reacted w

[PATCH] D121911: [Clang] Add DriverKit support

egorzhdan created this revision. egorzhdan added a reviewer: arphaman. Herald added a reviewer: aaron.ballman. Herald added subscribers: dexonsmith, zzheng. Herald added a project: All. egorzhdan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commit

[clang] 799643f - [CGObjCGNU] Remove pointer element type uses

Author: Nikita Popov Date: 2022-03-17T14:53:34+01:00 New Revision: 799643f7f0bebbc4e45767cfea5e8e227af7ef9c URL: https://github.com/llvm/llvm-project/commit/799643f7f0bebbc4e45767cfea5e8e227af7ef9c DIFF: https://github.com/llvm/llvm-project/commit/799643f7f0bebbc4e45767cfea5e8e227af7ef9c.diff

[PATCH] D118259: [AArch64] Adjust aarch64-neon-intrinsics-constrained test and un-XFAIL

kpn added a comment. It's been a while, but I think the aarch64-neon-intrinsics-constrained.c test is trimmed down from the aarch64-neon-intrinsics.c test. Shouldn't the constrained and non-constrained end-to-end tests be treated the same? Repository: rG LLVM Github Monorepo CHANGES SINCE L

[PATCH] D117829: [Clang] Add integer add/mul reduction builtins

RKSimon added a comment. In D117829#3386398 , @fhahn wrote: > @RKSimon are you planning on pushing this patch through? From my perspective, > it looks good with splitting off `__builtin_reduce_mul` and adding a TODO to > also implement it for floating p

[PATCH] D121122: Set FLT_EVAL_METHOD to -1 when fast-math is enabled.

zahiraam updated this revision to Diff 416168. zahiraam marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121122/new/ https://reviews.llvm.org/D121122 Files: clang/include/clang/Lex/Preprocessor.h clang/lib/Lex/PPMacroExpansion.cpp clang/lib/Sema/Sema.

[PATCH] D121757: [clang-format] Take out common code for parsing blocks

MyDeveloperDay added a comment. In D121757#3389218 , @sstwcw wrote: > For the new stuff I have the option of still adding the function > `parseIndentedBlock` but only using it in new code. Please be more blunt > about whether I should close this revisi

[PATCH] D118259: [AArch64] Adjust aarch64-neon-intrinsics-constrained test and un-XFAIL

fhahn added a comment. In D118259#3389235 , @kpn wrote: > It's been a while, but I think the aarch64-neon-intrinsics-constrained.c test > is trimmed down from the aarch64-neon-intrinsics.c test. Shouldn't the > constrained and non-constrained end-to-end

[PATCH] D121736: Lower `@llvm.global_dtors` using `__cxa_atexit` on MachO

RKSimon accepted this revision. RKSimon added a comment. This revision is now accepted and ready to land. LGTM - but please hang around after you commit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121736/new/ https://reviews.llvm.org/D121736 ___

[PATCH] D118259: [AArch64] Adjust aarch64-neon-intrinsics-constrained test and un-XFAIL

kpn added a comment. In D118259#3389246 , @fhahn wrote: > In D118259#3389235 , @kpn wrote: > >> It's been a while, but I think the aarch64-neon-intrinsics-constrained.c >> test is trimmed down from the aarch64-ne

[clang] bf1a998 - [CodeGen] Avoid some pointer element type accesses

Author: Nikita Popov Date: 2022-03-17T15:25:55+01:00 New Revision: bf1a99861c2e98cfd85792fdefe2ef9c7ec11f52 URL: https://github.com/llvm/llvm-project/commit/bf1a99861c2e98cfd85792fdefe2ef9c7ec11f52 DIFF: https://github.com/llvm/llvm-project/commit/bf1a99861c2e98cfd85792fdefe2ef9c7ec11f52.diff

[PATCH] D121915: [RISCV][1/2]Add IR intrinsic for Zbb extension

joker881 created this revision. joker881 added a reviewer: craig.topper. Herald added subscribers: s, VincentWu, luke957, vkmr, frasercrmck, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng

[PATCH] D121122: Set FLT_EVAL_METHOD to -1 when fast-math is enabled.

zahiraam updated this revision to Diff 416180. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121122/new/ https://reviews.llvm.org/D121122 Files: clang/include/clang/Lex/Preprocessor.h clang/lib/Lex/PPMacroExpansion.cpp clang/lib/Sema/Sema.cpp clang/lib/Sema/SemaAttr.cpp clang/t

[PATCH] D121916: [clang-format] [doc] Add script to automatically update help output in ClangFormat.rst.

curdeius created this revision. curdeius added reviewers: MyDeveloperDay, HazardyKnusperkeks, owenpan. Herald added a project: All. curdeius requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://revi

[PATCH] D121916: [clang-format] [doc] Add script to automatically update help output in ClangFormat.rst.

curdeius added a comment. This is an alternative to D121890 . This patch goes a step further and adds a script to update the .rst file. It isn't invoked during the build, one needs to run it manually (just as `dump_format_style.py`). There's also a validation op

[PATCH] D121916: [clang-format] [doc] Add script to automatically update help output in ClangFormat.rst.

curdeius updated this revision to Diff 416185. curdeius added a comment. Update file comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121916/new/ https://reviews.llvm.org/D121916 Files: clang/docs/ClangFormat.rst clang/docs/tools/dump_fo

[PATCH] D116385: [clangd] Code action for creating an ObjC initializer

dgoldman updated this revision to Diff 416186. dgoldman marked 3 inline comments as done. dgoldman added a comment. Fixes for review Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116385/new/ https://reviews.llvm.org/D116385 Files: clang-tools-ex

[clang] cb2f2fe - [Clang] Added info about noinline/always_inline statement attributes to release notes

Author: Dávid Bolvanský Date: 2022-03-17T16:29:23+01:00 New Revision: cb2f2fecc151999a7892a9d1325a34f85dabcecb URL: https://github.com/llvm/llvm-project/commit/cb2f2fecc151999a7892a9d1325a34f85dabcecb DIFF: https://github.com/llvm/llvm-project/commit/cb2f2fecc151999a7892a9d1325a34f85dabcecb.dif

[PATCH] D121896: [Clang] Added info about noinline/always_inline statement attributes to release notes

This revision was automatically updated to reflect the committed changes. Closed by commit rGcb2f2fecc151: [Clang] Added info about noinline/always_inline statement attributes to release… (authored by xbolva00). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE L

[clang-tools-extra] 1af5fbd - [clangd] Code action for creating an ObjC initializer

Author: David Goldman Date: 2022-03-17T11:31:14-04:00 New Revision: 1af5fbd5c605372963f78351f721fa28ee5ba60e URL: https://github.com/llvm/llvm-project/commit/1af5fbd5c605372963f78351f721fa28ee5ba60e DIFF: https://github.com/llvm/llvm-project/commit/1af5fbd5c605372963f78351f721fa28ee5ba60e.diff

[PATCH] D116385: [clangd] Code action for creating an ObjC initializer

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1af5fbd5c605: [clangd] Code action for creating an ObjC initializer (authored by dgoldman). Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[clang] 2edac9d - [CodeGen] Avoid some pointer element type accesses

Author: Nikita Popov Date: 2022-03-17T16:32:45+01:00 New Revision: 2edac9d962b9ee06d14a74886fb8aaa85d5256ee URL: https://github.com/llvm/llvm-project/commit/2edac9d962b9ee06d14a74886fb8aaa85d5256ee DIFF: https://github.com/llvm/llvm-project/commit/2edac9d962b9ee06d14a74886fb8aaa85d5256ee.diff

[clang] 6c0af92 - [CodeGen] Avoid some pointer element type accesses

Author: Nikita Popov Date: 2022-03-17T16:36:14+01:00 New Revision: 6c0af92612d0730a039226d67cfa08f4d6db5be9 URL: https://github.com/llvm/llvm-project/commit/6c0af92612d0730a039226d67cfa08f4d6db5be9 DIFF: https://github.com/llvm/llvm-project/commit/6c0af92612d0730a039226d67cfa08f4d6db5be9.diff

[PATCH] D121915: [RISCV] CLZ Instruction

craig.topper added a comment. These were intentionally not added because llvm has generic leading and trailing zero builtins. __builtin_clz and __builtin_ctz Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121915/new/ https://reviews.llvm.org/D12191

[PATCH] D118935: [SYCL] Disallow explicit casts between mismatching address spaces

hvdijk added a comment. Herald added a project: All. Hi, what is the rationale here? This reuses the logic that was written for OpenCL mode, but in OpenCL mode, it was made an error with the idea that a new keyword `addrspace_cast` could be used in those cases where the user actually wants an a

[PATCH] D121097: [C++20][Modules][HU 3/5] Emit module macros for header units.

iains updated this revision to Diff 416194. iains marked 4 inline comments as done. iains added a comment. Herald added a subscriber: dexonsmith. address review comments, match windows path separators in tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D121097: [C++20][Modules][HU 3/5] Emit module macros for header units.

iains added inline comments. Comment at: clang/include/clang/Serialization/ASTWriter.h:127-128 + /// The module is a header unit. + bool IsHeaderUnit = false; + ChuanqiXu wrote: > I think the member is redundant. I thought we could use > `WritingModule->isHe

[clang] 6e1e99d - [CodeGen] Avoid pointer element type access for blocks

Author: Nikita Popov Date: 2022-03-17T16:56:31+01:00 New Revision: 6e1e99dc07f4f847a5dc8ad80d25ecce40690489 URL: https://github.com/llvm/llvm-project/commit/6e1e99dc07f4f847a5dc8ad80d25ecce40690489 DIFF: https://github.com/llvm/llvm-project/commit/6e1e99dc07f4f847a5dc8ad80d25ecce40690489.diff

[PATCH] D121749: [clang-format][docs] Regenerate ClangFormatStyleOptions.rst

owenpan added inline comments. Comment at: clang/docs/ClangFormatStyleOptions.rst:361 - * ``bool AlignCompound`` Only for ``AlignConsecutiveAssignments``. Whether compound -assignments like ``+=`` are aligned along with ``=``. + * ``bool AlignCompound`` Only for ``Align

[PATCH] D116385: [clangd] Code action for creating an ObjC initializer

thakis added a comment. Looks like this breaks tests: http://45.33.8.238/linux/71327/step_9.txt Please take a look and revert for now if it takes a while to fix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116385/new/ https://reviews.llvm.org/D11

  1   2   3   >