[PATCH] D121602: [clang][dataflow] Model the behavior of non-standard optional constructors

sgatev updated this revision to Diff 415349. sgatev marked 3 inline comments as done. sgatev added a comment. Address reviewers' comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121602/new/ https://reviews.llvm.org/D121602 Files: clang/in

[PATCH] D121602: [clang][dataflow] Model the behavior of non-standard optional constructors

sgatev added inline comments. Comment at: clang/include/clang/Analysis/FlowSensitive/MatchSwitch.h:146 + std::vector> + Actions; xazax.hun wrote: > Nit: looks like we need to repeat the action type. Should we restore the > using above? It's not the same. T

[clang] 092a530 - [clang][dataflow] Model the behavior of non-standard optional constructors

Author: Stanislav Gatev Date: 2022-03-15T08:13:13Z New Revision: 092a530ca1878df08dc616cb43072044a39fb132 URL: https://github.com/llvm/llvm-project/commit/092a530ca1878df08dc616cb43072044a39fb132 DIFF: https://github.com/llvm/llvm-project/commit/092a530ca1878df08dc616cb43072044a39fb132.diff LO

[PATCH] D121602: [clang][dataflow] Model the behavior of non-standard optional constructors

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG092a530ca187: [clang][dataflow] Model the behavior of non-standard optional constructors (authored by sgatev). Repository: rG LLVM Github Monorepo

[PATCH] D111400: [Clang] Implement P2242R3

cor3ntin updated this revision to Diff 415353. cor3ntin added a comment. Fix test messed up by automatic formatting. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111400/new/ https://reviews.llvm.org/D111400 Files: clang/docs/ReleaseNotes.rst

[PATCH] D120527: [OpaquePtr][AArch64] Use elementtype on ldxr/stxr

nikic added a comment. @aeubanks Do you plan to take care of the corresponding arm intrinsics as well? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120527/new/ https://reviews.llvm.org/D120527 ___ cfe-c

[PATCH] D120540: [Driver] Enable to use C++20 modules standalone by -fcxx-modules

iains added a comment. I am still concerned that there is an expectation that. the fcxx-modules option is connected with clang modules. .. see, for example: https://github.com/llvm/llvm-project/blob/d90d45fc9029cc7dbb6d44798f51131df6b2eef1/clang/lib/Driver/ToolChains/Clang.cpp#L3579 and https:

[PATCH] D121576: [clang-format] Don't unwrap lines preceded by line comments

MyDeveloperDay added a comment. Please do, to be honest I spent enough time on this and I got to the same conclusion, it needs a rethink. Please go ahead, I don't use this feature myself so I'm not likely to see all the issues. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D121588: [C++20][Modules][Driver][HU 1/N] Initial handling for -xc++-{system,user}-header.

iains added a comment. note: I do not plan to fix the formatting issue in clang/lib/Driver/Types.cpp, since I am adding one line and the format change would mean ≈ 110 lines of changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121588/new/ ht

[PATCH] D121678: [pseudo] Split greatergreater token.

hokein created this revision. hokein added a reviewer: sammccall. Herald added a project: All. hokein requested review of this revision. Herald added a subscriber: alextsao1999. Herald added a project: clang. For a >> token (a right shift operator, or a nested template?), the clang lexer always re

[PATCH] D121327: Lower `@llvm.global_dtors` using `__cxa_atexit` on MachO

Orlando added a comment. Hi @yln, the test you added `llvm/test/Transforms/LowerGlobalDestructors/lower-global-dtors.ll` is failing on some bots, e.g. https://lab.llvm.org/buildbot/#/builders/139/builds/18527 (builder `llvm-clang-x86_64-sie-ubuntu-fast`). Please can you take a look? Reposito

[PATCH] D121589: [C++20][Modules][Driver][HU 2/N] Add fmodule-header, fmodule-header=

iains added a comment. In D121589#3381343 , @ChuanqiXu wrote: >> It's not practical to recognise a header without any suffix so > > -fmodule-header=system foo isn't going to happen. > > May I ask the reason? It looks not so good with `-fmodule-header=syst

[PATCH] D121593: [clangd][WIP] Provide clang-include-cleaner

sammccall added a comment. This is exciting! We weren't sure how much effort to put into decoupling this from clangd, whether there'd be interest in such a standalone tool. Some thoughts at a high level: --- Eventually we should separate this from clangd. I don't think it necessarily needs to

[PATCH] D121550: [clang-format] Fix crash on invalid requires expression

owenpan added a comment. Nvm. See https://github.com/llvm/llvm-project/issues/54384. Comment at: clang/lib/Format/TokenAnnotator.cpp:216 FormatToken &OpeningParen = *CurrentToken->Previous; assert(OpeningParen.is(tok::l_paren)); FormatToken *PrevNonComment = Open

[PATCH] D120540: [Driver] Enable to use C++20 modules standalone by -fcxx-modules

jansvoboda11 added a comment. I agree. My understanding is that `-fcxx-modules` enables Clang modules that don't interact with C++20 modules. @Bigcheese, any thoughts? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120540/new/ https://reviews.llvm.

[PATCH] D120540: [Driver] Enable to use C++20 modules standalone by -fcxx-modules

ChuanqiXu added a comment. In D120540#3381905 , @jansvoboda11 wrote: > I agree. My understanding is that `-fcxx-modules` enables Clang modules that > don't interact with C++20 modules. @Bigcheese, any thoughts? Oh, if it is true, then it is in a chaos

[PATCH] D119701: [clangd] Re-enable clang-tidy's nolint blocks

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. Herald added a project: All. thanks, sorry for missing this! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119701/new/ https://reviews.llvm.

[PATCH] D120305: [Driver] Default CLANG_DEFAULT_PIE_ON_LINUX to ON

xbolva00 added a comment. Herald added a project: All. In D120305#3347191 , @MaskRay wrote: > In D120305#3347177 , @nikic wrote: > >> Yes, because you reverted the change for that one buildbot, of course it is >>

[PATCH] D121589: [C++20][Modules][Driver][HU 2/N] Add fmodule-header, fmodule-header=

ChuanqiXu accepted this revision. ChuanqiXu added a comment. This revision is now accepted and ready to land. In D121589#3381894 , @iains wrote: > In D121589#3381343 , @ChuanqiXu > wrote: > >>> It's not practical

[clang] 126b37a - [clang-format] Correctly recognize arrays in template parameter list.

Author: Marek Kurdej Date: 2022-03-15T11:33:13+01:00 New Revision: 126b37a713dc1c67cbc7dc8b5288b2f907c906a9 URL: https://github.com/llvm/llvm-project/commit/126b37a713dc1c67cbc7dc8b5288b2f907c906a9 DIFF: https://github.com/llvm/llvm-project/commit/126b37a713dc1c67cbc7dc8b5288b2f907c906a9.diff

[PATCH] D121584: [clang-format] Correctly recognize arrays in template parameter list.

This revision was automatically updated to reflect the committed changes. Closed by commit rG126b37a713dc: [clang-format] Correctly recognize arrays in template parameter list. (authored by curdeius). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121

[PATCH] D121682: [clang-format] Fix crashes due to missing l_paren

owenpan created this revision. owenpan added reviewers: HazardyKnusperkeks, curdeius, MyDeveloperDay. owenpan added a project: clang-format. Herald added a project: All. owenpan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fixes https://

[PATCH] D121588: [C++20][Modules][Driver][HU 1/N] Initial handling for -xc++-{system,user}-header.

ChuanqiXu added a subscriber: MyDeveloperDay. ChuanqiXu added a comment. In D121588#3381872 , @iains wrote: > note: I do not plan to fix the formatting issue in > clang/lib/Driver/Types.cpp, since I am adding one line and the format change > would mean

[PATCH] D121678: [pseudo] Split greatergreater token.

hokein updated this revision to Diff 415377. hokein added a comment. define a greatergreater nonterminal per discussion. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121678/new/ https://reviews.llvm.org/D121678 Files: clang/include/clang/Toolin

[PATCH] D121678: [pseudo] Split greatergreater token.

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. This seems like the right approach to me. It seems a bit strange to be doing this whether we're parsing C++ or not, but I guess we're not going to want low-level grammar differences betw

[PATCH] D121533: [clang][deps] Fix traversal of precompiled dependencies

jansvoboda11 updated this revision to Diff 415380. jansvoboda11 added a comment. Throw away recursive implementation, add reproducer Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121533/new/ https://reviews.llvm.org/D121533 Files: clang/lib/Tool

[PATCH] D121533: [clang][deps] Fix traversal of precompiled dependencies

jansvoboda11 added a comment. Fair enough, iterative implementation will be better. I simplified it a bit by using the in-out parameter `ModuleFiles` to keep track of visited files. I also switched to using `SmallVector` for the newly discovered (not-yet-visited) imports, which allows using the

[PATCH] D121295: [clang][deps] Modules don't contribute to search path usage

jansvoboda11 updated this revision to Diff 415381. jansvoboda11 added a comment. Undo unrelated changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121295/new/ https://reviews.llvm.org/D121295 Files: clang/lib/Lex/HeaderSearch.cpp clang/test

[PATCH] D121685: [clang][deps] NFC: Use range-based for loop instead of iterators

jansvoboda11 created this revision. jansvoboda11 added reviewers: Bigcheese, dexonsmith. Herald added a project: All. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The iterator is needed after the loop body, meaning we can us

[PATCH] D120540: [Driver] Enable to use C++20 modules standalone by -fcxx-modules

iains added a comment. I'm not sure it is exactly chaos, but it is certainly fragile and somewhat hard(er than necessary) to maintain. We (@ChuanqiXu and I at least) agree that there should be some way to make "which modules mode" unambiguous in both the driver and the compiler (I think we're

[PATCH] D120952: [clang][AST matchers] adding submatchers under cudaKernelCallExpr to match kernel launch config

aaron.ballman added a comment. In D120952#3381224 , @ajohnson-uoregon wrote: > I still need to write tests but: I do have a use case for these over here: > https://github.com/ajohnson-uoregon/llvm-project/blob/feature-ajohnson/clang-tools-extra/clang-re

[PATCH] D121687: [clang-tidy] Don't try to build CTTestTidyModule for Windows with dylibs

mstorsjo created this revision. mstorsjo added a reviewer: rnk. Herald added subscribers: xazax.hun, mgorny. Herald added a project: All. mstorsjo requested review of this revision. Herald added a project: clang-tools-extra. In MinGW mode, it's possible to build LLVM/Clang with LLVM_LINK_LLVM_DYLI

[PATCH] D121678: [pseudo] Split greatergreater token.

hokein updated this revision to Diff 415387. hokein marked 4 inline comments as done. hokein added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121678/new/ https://reviews.llvm.org/D121678 Files: clang/include/clang/

[clang] e60defb - [clang-format] Add regression tests for function ref qualifiers on operator definition. NFC.

Author: Marek Kurdej Date: 2022-03-15T12:58:08+01:00 New Revision: e60defb931cfc333d143f6000a6a65ae4dc106a2 URL: https://github.com/llvm/llvm-project/commit/e60defb931cfc333d143f6000a6a65ae4dc106a2 DIFF: https://github.com/llvm/llvm-project/commit/e60defb931cfc333d143f6000a6a65ae4dc106a2.diff

[clang] 3227aa3 - [clang-format] Correctly format variable templates.

Author: Marek Kurdej Date: 2022-03-15T13:16:56+01:00 New Revision: 3227aa3aa83440ff94a3b13a29623e03b05098f2 URL: https://github.com/llvm/llvm-project/commit/3227aa3aa83440ff94a3b13a29623e03b05098f2 DIFF: https://github.com/llvm/llvm-project/commit/3227aa3aa83440ff94a3b13a29623e03b05098f2.diff

[PATCH] D121456: [clang-format] Correctly format variable templates.

This revision was not accepted when it landed; it landed in state "Changes Planned". This revision was automatically updated to reflect the committed changes. Closed by commit rG3227aa3aa834: [clang-format] Correctly format variable templates. (authored by curdeius). Changed prior to commit: h

[PATCH] D88905: [Clang] Allow "ext_vector_type" applied to Booleans

simoll updated this revision to Diff 415392. simoll added a comment. Blocking of arithmetic on bool vectors extends to the case where only one operand is a bool vector (and the other is, eg, a vector of int). This was still caught before during sema because the integer vector operand would have

[PATCH] D121646: [Concepts] Fix an assertion failure while diagnosing constrained function candidates

erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land. In D121646#3380902 , @royjacobson wrote: > In D121646#3380893 , @erichkeane > wrote: > >> This seem

[PATCH] D88905: [Clang] Allow "ext_vector_type" applied to Booleans

simoll updated this revision to Diff 415400. simoll added a comment. Make the sema check for bool vector arithmetic specific to ext_vector_type bool. This assures that we do not interfere with scalar bool + int vector arithmetic sema (`vector.cpp` test was failing before). Repository: rG LLV

[clang] 7262eac - Revert rG9c542a5a4e1ba36c24e48185712779df52b7f7a6 "Lower `@llvm.global_dtors` using `__cxa_atexit` on MachO"

Author: Simon Pilgrim Date: 2022-03-15T13:01:35Z New Revision: 7262eacd41997d7ca262d83367e28998662c1b21 URL: https://github.com/llvm/llvm-project/commit/7262eacd41997d7ca262d83367e28998662c1b21 DIFF: https://github.com/llvm/llvm-project/commit/7262eacd41997d7ca262d83367e28998662c1b21.diff LOG:

[PATCH] D121327: Lower `@llvm.global_dtors` using `__cxa_atexit` on MachO

RKSimon added a comment. Herald added a subscriber: asb. @yln I've reverted your commit at rG7262eacd41997d7ca262d83367e28998662c1b21 to try and get the buildbots green again Repository: rG LLVM Github Monorepo CHANGES SI

[PATCH] D88905: [Clang] Allow "ext_vector_type" applied to Booleans

aaron.ballman added a comment. Thanks! Sema bits now LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88905/new/ https://reviews.llvm.org/D88905 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D121637: [PowerPC] Fix EmitPPCBuiltinExpr to emit arguments once

quinnp updated this revision to Diff 415412. quinnp added a comment. Minor formatting update. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121637/new/ https://reviews.llvm.org/D121637 Files: clang/lib/CodeGen/CGBuiltin.cpp clang/test/CodeGen/

[PATCH] D121576: [clang-format] Don't unwrap lines preceded by line comments

curdeius added a comment. In D121576#3381295 , @owenpan wrote: > Right. I think we should have a specification (including when not to align > the cells) and re-design the entire thing. It's not maintainable as is. I > have some ideas but need to remove/

[PATCH] D111587: re-land: [clang] Fix absolute file paths with -fdebug-prefix-map

probinson added a comment. In D111587#3381369 , @keith wrote: > Fix tests with dwarf 6 Do you mean dwarf 5 here? There is no v6 yet. Comment at: clang/test/Modules/module-debuginfo-prefix.m:24 -// Dir should always be empty, but on

[clang] 3524535 - [AARCH64] ssbs should be enabled by default for cortex-x1, cortex-x1c, cortex-a77

Author: Ties Stuij Date: 2022-03-15T13:44:20Z New Revision: 352453569b2b044ddd5bd4df0074ff9863828b6f URL: https://github.com/llvm/llvm-project/commit/352453569b2b044ddd5bd4df0074ff9863828b6f DIFF: https://github.com/llvm/llvm-project/commit/352453569b2b044ddd5bd4df0074ff9863828b6f.diff LOG: [A

[PATCH] D121206: [AARCH64] ssbs should be enabled by default for cortex-x1, cortex-x1c, cortex-a77

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG352453569b2b: [AARCH64] ssbs should be enabled by default for cortex-x1, cortex-x1c, cortex… (authored by stuij). Repository: rG LLVM Github Monor

[PATCH] D119479: [clang][extract-api] Add global record support

dang requested changes to this revision. dang added a comment. This revision now requires changes to proceed. You should fix the test to take into account the serializer feedback I left behind Comment at: clang/include/clang/SymbolGraph/API.h:33 + +struct APIRecord { + String

[PATCH] D121694: [clang][dataflow] Allow disabling built-in transfer functions for CFG terminators

ymandel created this revision. ymandel added reviewers: sgatev, xazax.hun. Herald added subscribers: tschuett, steakhal, rnkovacs. Herald added a project: All. ymandel requested review of this revision. Herald added a project: clang. Terminators are handled specially in the transfer functions so w

[PATCH] D111400: [Clang] Implement P2242R3

aaron.ballman added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:5128-5130 + if (!CheckLocalVariableDeclaration(Info, VD)) { +return ESR_Failed; + } Comment at: clang/lib/AST/ExprConstant.cpp:5174-5

[PATCH] D111400: [Clang] Implement P2242R3

cor3ntin updated this revision to Diff 415425. cor3ntin marked 6 inline comments as done. cor3ntin added a comment. Address formatting and style issues Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111400/new/ https://reviews.llvm.org/D111400 File

[PATCH] D111400: [Clang] Implement P2242R3

cor3ntin added inline comments. Comment at: clang/lib/Sema/SemaDeclCXX.cpp:2132-2136 +for (Stmt *SubStmt : S->children()) + if (SubStmt && + !CheckConstexprFunctionStmt(SemaRef, Dcl, SubStmt, ReturnStmts, + Cxx1yLoc, Cxx2aLoc

[PATCH] D119479: [clang][extract-api] Add global record support

dang added inline comments. Comment at: clang/lib/SymbolGraph/Serialization.cpp:237 +case GVKind::Variable: + Kind["identifier"] = (getLanguageName(LangOpts) + ".variable").str(); + Kind["displayName"] = "Variable"; dang wrote: > ".variable" ".var"

[PATCH] D111400: [Clang] Implement P2242R3

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaDeclCXX.cpp:2132-2136 +for (Stmt *SubStmt : S->children()) + if (SubStmt && + !CheckConstexprFunctionStmt(SemaRef, Dcl, SubStmt, ReturnStmts, + Cxx1yLoc, Cxx

[PATCH] D111400: [Clang] Implement P2242R3

cor3ntin added inline comments. Comment at: clang/test/SemaCXX/constant-expression-cxx2b.cpp:60-61 + +constexpr int ke = k_evaluated(1); //expected-error {{constexpr variable 'ke' must be initialized by a constant expression}} \ + //expected-not

[PATCH] D111400: [Clang] Implement P2242R3

cor3ntin added inline comments. Comment at: clang/lib/Sema/SemaDeclCXX.cpp:2132-2136 +for (Stmt *SubStmt : S->children()) + if (SubStmt && + !CheckConstexprFunctionStmt(SemaRef, Dcl, SubStmt, ReturnStmts, + Cxx1yLoc, Cxx2aLoc

[PATCH] D111400: [Clang] Implement P2242R3

aaron.ballman added inline comments. Comment at: clang/test/SemaCXX/constant-expression-cxx2b.cpp:60-61 + +constexpr int ke = k_evaluated(1); //expected-error {{constexpr variable 'ke' must be initialized by a constant expression}} \ + //expecte

[PATCH] D111400: [Clang] Implement P2242R3

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaDeclCXX.cpp:2132-2136 +for (Stmt *SubStmt : S->children()) + if (SubStmt && + !CheckConstexprFunctionStmt(SemaRef, Dcl, SubStmt, ReturnStmts, + Cxx1yLoc, Cxx

[PATCH] D121694: [clang][dataflow] Allow disabling built-in transfer functions for CFG terminators

xazax.hun accepted this revision. xazax.hun added a comment. The change itself looks good. But out of curiosity, could you give me an example when we do not want to use the builtin transfer functions? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1

[PATCH] D121694: [clang][dataflow] Allow disabling built-in transfer functions for CFG terminators

ymandel added a comment. In D121694#3382473 , @xazax.hun wrote: > The change itself looks good. But out of curiosity, could you give me an > example when we do not want to use the builtin transfer functions? Sure! Pretty much any plain-vanilla dataflow

[PATCH] D111400: [Clang] Implement P2242R3

cor3ntin updated this revision to Diff 415438. cor3ntin added a comment. Restore the C++14 tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111400/new/ https://reviews.llvm.org/D111400 Files: clang/docs/ReleaseNotes.rst clang/include/clang/

[PATCH] D120272: [CUDA] Add driver support for compiling CUDA with the new driver

jhuber6 updated this revision to Diff 415439. jhuber6 added a comment. We shouldn't need to restrict this to RDC only if implemented properly. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120272/new/ https://reviews.llvm.org/D120272 Files: clan

[clang] 4633c02 - [clang][dataflow] Allow disabling built-in transfer functions for CFG terminators

Author: Yitzhak Mandelbaum Date: 2022-03-15T15:10:32Z New Revision: 4633c02eb0013ed38319b3fd708f59251bcd2aaf URL: https://github.com/llvm/llvm-project/commit/4633c02eb0013ed38319b3fd708f59251bcd2aaf DIFF: https://github.com/llvm/llvm-project/commit/4633c02eb0013ed38319b3fd708f59251bcd2aaf.diff

[PATCH] D121694: [clang][dataflow] Allow disabling built-in transfer functions for CFG terminators

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4633c02eb001: [clang][dataflow] Allow disabling built-in transfer functions for CFG… (authored by ymandel). Repository: rG LLVM Github Monorepo C

[PATCH] D121707: [llvm][AArch64] Insert "bti j" after call to setjmp

DavidSpickett created this revision. Herald added subscribers: hiraditya, kristof.beyls. Herald added a project: All. DavidSpickett requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Some implementations of setjmp will end wi

[PATCH] D121694: [clang][dataflow] Allow disabling built-in transfer functions for CFG terminators

xazax.hun added a comment. In D121694#3382587 , @ymandel wrote: > In D121694#3382473 , @xazax.hun > wrote: > >> The change itself looks good. But out of curiosity, could you give me an >> example when we do not

[PATCH] D120296: [Attr] Fix a btf_type_tag AST generation bug

aaron.ballman added a comment. I think we're pretty close; it looks like there's still one unresolved conversation about template instantiation needs and whether we can remove that code or not. Comment at: clang/include/clang/AST/TypeLoc.h:923 + void initializeLocal(ASTConte

[PATCH] D120527: [OpaquePtr][AArch64] Use elementtype on ldxr/stxr

aeubanks added a comment. In D120527#3381835 , @nikic wrote: > @aeubanks Do you plan to take care of the corresponding arm intrinsics as > well? yes I'll do those Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D121709: [NFC][AIX] Disable precompiled module file test on AIX

Jake-Egan created this revision. Herald added a project: All. Jake-Egan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D121709 Files: clang/test/ClangScanDeps/modules-no-un

[PATCH] D120272: [CUDA] Add driver support for compiling CUDA with the new driver

jhuber6 updated this revision to Diff 415460. jhuber6 added a comment. Accidentally clang formatted an entire file. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120272/new/ https://reviews.llvm.org/D120272 Files: clang/include/clang/Basic/Cuda.

[PATCH] D111400: [Clang] Implement P2242R3

cor3ntin updated this revision to Diff 415464. cor3ntin added a comment. Fix test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111400/new/ https://reviews.llvm.org/D111400 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Basic/Diagnosti

[PATCH] D121694: [clang][dataflow] Allow disabling built-in transfer functions for CFG terminators

ymandel added a comment. In D121694#3382683 , @xazax.hun wrote: > In D121694#3382587 , @ymandel wrote: > >> In D121694#3382473 , @xazax.hun >> wrote: >> >>> The change it

[PATCH] D111587: re-land: [clang] Fix absolute file paths with -fdebug-prefix-map

keith added a comment. I actually mean dwarf 6, which appears to be partially implemented according to https://lists.llvm.org/pipermail/llvm-dev/2020-April/141055.html I discovered the issue from the failed tests on https://reviews.llvm.org/D113718 where you can see the test output contains a

[PATCH] D111587: re-land: [clang] Fix absolute file paths with -fdebug-prefix-map

keith added inline comments. Comment at: clang/test/Modules/module-debuginfo-prefix.m:24 -// Dir should always be empty, but on Windows we can't recognize /var -// as being an absolute path. -// CHECK: !DIFile(filename: "/OVERRIDE/DebugObjC.h", directory: "{{()|(.*:.*)}}") +//

[PATCH] D121712: [clangd] Track time spent in filesystem ops during preamble builds

adamcz created this revision. adamcz added a reviewer: kadircet. Herald added subscribers: usaxena95, arphaman, javed.absar. Herald added a project: All. adamcz requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extr

[PATCH] D121245: [clang][parser] Allow GNU attributes before namespace identifier

ArcsinX updated this revision to Diff 415470. ArcsinX added a comment. Update release notes Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121245/new/ https://reviews.llvm.org/D121245 Files: clang/docs/ReleaseNotes.rst clang/lib/Parse/Pa

[PATCH] D88905: [Clang] Allow "ext_vector_type" applied to Booleans

simoll added a comment. In D88905#3382309 , @aaron.ballman wrote: > Thanks! Sema bits now LGTM Awesome! Who would be a good fit for the codegen parts of this patch? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D120949: [clang][AST matchers] adding attributedStmt AST matcher

aaron.ballman added inline comments. Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:2733 +/// \endcode +AST_MATCHER_P(AttributedStmt, isAttr, attr::Kind, AttrKind) { + return llvm::any_of(Node.getAttrs(), ajohnson-uoregon wrote: > aaron.ballman wrote:

[PATCH] D121245: [clang][parser] Allow GNU attributes before namespace identifier

ArcsinX added a comment. In D121245#3380346 , @aaron.ballman wrote: > LGTM! Might be worth adding a release note for it (does this close any bugs > in the bug database? If so, it'd be worth mentioning those in the commit > message and release note). T

[PATCH] D88905: [Clang] Allow "ext_vector_type" applied to Booleans

aaron.ballman added a comment. In D88905#3382881 , @simoll wrote: > In D88905#3382309 , @aaron.ballman > wrote: > >> Thanks! Sema bits now LGTM > > Awesome! Who would be a good fit for the codegen parts of this pat

[PATCH] D121245: [clang][parser] Allow GNU attributes before namespace identifier

aaron.ballman accepted this revision. aaron.ballman added a comment. In D121245#3382887 , @ArcsinX wrote: > In D121245#3380346 , @aaron.ballman > wrote: > >> LGTM! Might be worth adding a release note for it (doe

[PATCH] D121715: [Clang] Fix an unused-but-set-variable warning with compond assignment

yonghong-song created this revision. yonghong-song added a reviewer: eli.friedman. Herald added a project: All. yonghong-song requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. For the following code, void test() { int j = 0; fo

[PATCH] D117522: [clang-tidy] Add modernize-macro-to-enum check

LegalizeAdulthood marked 2 inline comments as done. LegalizeAdulthood added inline comments. Comment at: clang-tools-extra/clang-tidy/modernize/MacroToEnumCheck.cpp:47 +CRLF, +CRLFCR, + }; aaron.ballman wrote: > I'm a bit confused by this one as this is

[PATCH] D121715: [Clang] Fix an unused-but-set-variable warning with compond assignment

yonghong-song added a comment. @eli.friedman Please feel free adding other reviewers if needed. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121715/new/ https://reviews.llvm.org/D121715 ___ cfe-

[PATCH] D88905: [Clang] Allow "ext_vector_type" applied to Booleans

erichkeane added a comment. Everything in the CodeGen looks fine, but I didn't see anything for constant evaluation? Can you ensure that the ExprConstant evaluation for Vectors still works for this type (or, exclude it from participating in constant expressions entirely)? Repository: rG LL

[PATCH] D120187: [clang-tidy] Allow newline characters as separators for checks in Clang-Tidy configurations

SimplyDanny added a comment. In D120187#3375610 , @aaron.ballman wrote: > LGTM, but please wait a day or two before landing in case @njames93 has > further concerns. Would you merge the changes, @aaron.ballman? Seems like there are no objections from

[PATCH] D120296: [Attr] Fix a btf_type_tag AST generation bug

yonghong-song added inline comments. Comment at: clang/lib/Sema/TreeTransform.h:6872 + const BTFTagAttributedType *oldType = TL.getTypePtr(); + StringRef Tag = oldType->getTag(); + QualType modifiedType = getDerived().TransformType(TLB, TL.getModifiedLoc()); a

[PATCH] D111400: [Clang] Implement P2242R3

hubert.reinterpretcast added a comment. @aaron.ballman @cor3ntin, are we confident that testing the non-lambda cases is sufficient to cover the lambda cases as well? I suggest using a pattern such as: int (*test_cxx2b_constexpr_label_in_body())() { auto qq = []() { label: return 42;

[PATCH] D121283: [Clang] Support multiple attributes in a single pragma

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. Aside from a minor testing nit, this LGTM. Thank you for the new functionality! Comment at: clang/test/Parser/pragma-multiple-attributes.cpp:1-11 +// RUN: %clan

[PATCH] D120296: [Attr] Fix a btf_type_tag AST generation bug

aaron.ballman added inline comments. Comment at: clang/lib/Sema/TreeTransform.h:6872 + const BTFTagAttributedType *oldType = TL.getTypePtr(); + StringRef Tag = oldType->getTag(); + QualType modifiedType = getDerived().TransformType(TLB, TL.getModifiedLoc()); y

[clang] 1c1a4b9 - [clang][driver] Emit a warning if -xc/-xc++ is after the last input file

Author: Yi Kong Date: 2022-03-16T01:08:00+08:00 New Revision: 1c1a4b9556db8579f7428605ac2c351bddde9ad5 URL: https://github.com/llvm/llvm-project/commit/1c1a4b9556db8579f7428605ac2c351bddde9ad5 DIFF: https://github.com/llvm/llvm-project/commit/1c1a4b9556db8579f7428605ac2c351bddde9ad5.diff LOG:

[PATCH] D121683: Emit a warning if -xc/-xc++ is after the last input file

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1c1a4b9556db: [clang][driver] Emit a warning if -xc/-xc++ is after the last input file (authored by kongyi). Herald added a project: clang. Herald ad

[PATCH] D121370: [clang-format] SortIncludes should support "@import" lines in Objective-C

kwk updated this revision to Diff 415487. kwk added a comment. Changed the strategy of how includes are sorted by increasing the priority if an include is of the "new" type: `@import Foundation;`. This will sort these includes after everything else just as requested in https://github.com/llvm/l

[PATCH] D121370: [clang-format] SortIncludes should support "@import" lines in Objective-C

kwk updated this revision to Diff 415489. kwk edited the summary of this revision. kwk added a comment. - Fix formatting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121370/new/ https://reviews.llvm.org/D121370 Files: clang/lib/Format/Format.cp

[PATCH] D121715: [Clang] Fix an unused-but-set-variable warning with compond assignment

efriedma added inline comments. Comment at: clang/test/Sema/warn-unused-but-set-variables.c:66 + for (int i = 0; i < 1000; i++) +j += 1; + return; The handling of this testcase without your patch seems fine. Even if the value of j is technically read, it'

[clang] ba59476 - Revert "[clang][driver] Emit a warning if -xc/-xc++ is after the last input file"

Author: Yi Kong Date: 2022-03-16T01:17:17+08:00 New Revision: ba59476515cf4598dd25bcfacfbca11b4f4da3d4 URL: https://github.com/llvm/llvm-project/commit/ba59476515cf4598dd25bcfacfbca11b4f4da3d4 DIFF: https://github.com/llvm/llvm-project/commit/ba59476515cf4598dd25bcfacfbca11b4f4da3d4.diff LOG:

[PATCH] D121683: Emit a warning if -xc/-xc++ is after the last input file

MaskRay added inline comments. Comment at: clang/test/Driver/x-args.c:1 +// RUN: %clang -fsyntax-only -Werror -xc %s +// RUN: %clang -fsyntax-only -Werror %s -xc %s The first two RUN lines are unneeded Comment at: clang/test/Driver/x-args.c:8 +

[PATCH] D121683: Emit a warning if -xc/-xc++ is after the last input file

MaskRay added inline comments. Comment at: clang/include/clang/Basic/DiagnosticDriverKinds.td:369 +def warn_drv_unused_x : Warning< + "‘-x %0’ after last input file has no effect">, + InGroup; Use ASCII punctuation marks Repository: rG LLVM Github Monorepo

[PATCH] D121683: Emit a warning if -xc/-xc++ is after the last input file

MaskRay added inline comments. Comment at: clang/lib/Driver/Driver.cpp:2316 +if (LastInputArg->getIndex() < LastXArg->getIndex()) { + Diag(clang::diag::warn_drv_unused_x) << LastXArg->getValue(); +} https://llvm.org/docs/CodingStandards.html#don-t-us

[PATCH] D111587: re-land: [clang] Fix absolute file paths with -fdebug-prefix-map

probinson added a comment. In D111587#3382834 , @keith wrote: > I actually mean dwarf 6, which appears to be partially implemented according > to https://lists.llvm.org/pipermail/llvm-dev/2020-April/141055.html > > I discovered the issue from the failed

  1   2   3   >