[PATCH] D120992: [analyzer] ReverseNull: New checker to warn for pointer value conditions, if the pointer value is unconditionally non-null

xazax.hun added a comment. In D120992#3368118 , @NoQ wrote: > I guess there's the usual direction that I occasionally suggest: develop a > way to verify that all possible paths were explored during symbolic execution > (`CoreEngine::hasWorkRemaining()`

[PATCH] D121176: [ASTStructuralEquivalence] Add support for comparing ObjCCategoryDecl.

a_sidorin added a comment. Hi Volodymyr, Unfortunately, I'm not familiar with Objective-C and its frontend but I have a question. Comment at: clang/lib/AST/ASTStructuralEquivalence.cpp:1989 + ++ParamT1, ++ParamT2) { +if (!IsStructurallyEquivalent(Context, *ParamT1, *

[PATCH] D121122: Set FLT_EVAL_METHOD to -1 when fast-math is enabled.

zahiraam updated this revision to Diff 413936. zahiraam marked 3 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121122/new/ https://reviews.llvm.org/D121122 Files: clang/lib/Lex/PPMacroExpansion.cpp clang/lib/Sema/Sema.cpp clang/lib/Sema/SemaAttr.cpp clang

[PATCH] D121122: Set FLT_EVAL_METHOD to -1 when fast-math is enabled.

zahiraam added inline comments. Comment at: clang/lib/Lex/PPMacroExpansion.cpp:1600 +} else { + OS << getTUFPEvalMethod(); + // __FLT_EVAL_METHOD__ expands to a simple numeric value. andrew.w.kaylor wrote: > It looks like you've got tabs in the code

[PATCH] D121078: Replace links to archived mailing lists by links to Discourse forums

tonic added a comment. In D121078#3367950 , @aaron.ballman wrote: > In D121078#3367289 , @tonic wrote: > >> In D121078#3366825 , >> @aaron.ballman wrote: >> >>> In D1210

[PATCH] D119479: [clang][extract-api] Add global record support

zixuw updated this revision to Diff 413947. zixuw added a comment. Herald added a project: All. Move ExtractAPIConsumer which references clangIndex USR generation methods out of clangFrontend to resolve a cycle between clangFrontend and clangIndex when building shared libs. Repository: rG LL

[PATCH] D119479: [clang][extract-api] Add global record support

zixuw added a comment. I've moved things around to resolve the cycle, but sadly it seems that shared lib builds are already broken and I could not test it: Linking CXX shared library lib/libLLVMTransformUtils.dylib FAILED: lib/libLLVMTransformUtils.dylib : Undefined symbols for arc

[PATCH] D121259: [clang] Fix CodeGenAction for LLVM IR MemBuffers

RSenApps created this revision. RSenApps added reviewers: jlebar, mkuper, dcastagna, shangwuyao. Herald added a project: All. RSenApps requested review of this revision. Herald added a project: clang. Replaces use of getCurrentFile with getCurrentFileOrBufferName in CodeGenAction. This avoids an a

[PATCH] D120936: [Sema][Windows] Don't special-case void* in __unaligned conversions.

rnk added a comment. I remember writing up feedback on this patch, but it's gone now, oh well. I wasn't able to find any history for why `void*` was special here. I see that MSVC doesn't warn when converting from `__unaligned int*` to `int*`, but that seems dangerous. Our team has an active fea

[PATCH] D121259: [clang] Fix CodeGenAction for LLVM IR MemBuffers

jlebar accepted this revision. jlebar added a comment. This revision is now accepted and ready to land. Congrats on your first patch! Can Daniele or Shangwu land this for you, or do you need me to? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1212

[PATCH] D120949: [clang][AST matchers] adding attributedStmt AST matcher

ajohnson-uoregon updated this revision to Diff 413962. ajohnson-uoregon added a comment. Figuring out git-clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120949/new/ https://reviews.llvm.org/D120949 Files: clang/docs/LibASTMatchersRef

[PATCH] D121259: [clang] Fix CodeGenAction for LLVM IR MemBuffers

dcastagna added a comment. I'll land it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121259/new/ https://reviews.llvm.org/D121259 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.l

[PATCH] D119479: [clang][extract-api] Add global record support

zixuw added a comment. Wait that's just a current linking issue on `main`, I suppose not specific to shared lib builds. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119479/new/ https://reviews.llvm.org/D119479 ___

[PATCH] D119479: [clang][extract-api] Add global record support

zixuw updated this revision to Diff 413967. zixuw added a comment. Fix reference to vtable of ExtractAPIAction from clang/FrontendTools/ExecuteCompilerInstance Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119479/new/ https://reviews.llvm.org/D119

[PATCH] D121176: [ASTStructuralEquivalence] Add support for comparing ObjCCategoryDecl.

vsapsai added a comment. Thanks for the reviews! I'm going to address the comments, `check-lldb`, check tests failing on Debian. Comment at: clang/lib/AST/ASTStructuralEquivalence.cpp:1971 +return false; + unsigned SlotsToCheck = NumArgs > 0 ? NumArgs : 1; + for (unsigne

[clang] b3dae59 - [clang] Fix CodeGenAction for LLVM IR MemBuffers

Author: Ryan Senanayake Date: 2022-03-09T00:39:48Z New Revision: b3dae59b9dfb579d396bd97ca1b5a16529daac75 URL: https://github.com/llvm/llvm-project/commit/b3dae59b9dfb579d396bd97ca1b5a16529daac75 DIFF: https://github.com/llvm/llvm-project/commit/b3dae59b9dfb579d396bd97ca1b5a16529daac75.diff LO

[PATCH] D121259: [clang] Fix CodeGenAction for LLVM IR MemBuffers

This revision was automatically updated to reflect the committed changes. Closed by commit rGb3dae59b9dfb: [clang] Fix CodeGenAction for LLVM IR MemBuffers (authored by RSenApps, committed by dcastagna). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D121197: [clang][dataflow] Add analysis that detects unsafe accesses to optionals

xazax.hun accepted this revision. xazax.hun added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/Models/UncheckedOptionalAccessModel.cpp:115 + // optional::has_value + .CaseOf(isOptionalMemberCallWithName("has_value"), + transferOptionalHasV

[PATCH] D119601: [analyzer] Refactor makeNull to makeNullWithWidth (NFC)

NoQ added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/SValBuilder.h:378 +type = type->isReferenceType() + ? Context.getPointerType(type->getPointeeType()) + : type; How do you discover the po

[PATCH] D118311: [Clang][ModuleMap] Add conditional parsing via requires block declaration

Bigcheese added inline comments. Comment at: clang/lib/Lex/ModuleMap.cpp:2355 +parseModuleMembers(); + } +} bruno wrote: > Too many curly braces? This is correct. It closes the block on line 2353. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D115907: [misexpect] Re-implement MisExpect Diagnostics

tejohnson added inline comments. Herald added a project: All. Comment at: clang/include/clang/Basic/CodeGenOptions.def:172 CODEGENOPT(NoWarn, 1, 0) ///< Set when -Wa,--no-warn is enabled. +CODEGENOPT(MisExpect , 1, 0) ///< Set -Wmisexpect is enabled CODEGENO

[PATCH] D118352: [clang][ABI] New c++20 modules mangling scheme

phosek added a comment. We're also seeing this issue on our Mac bots, is it possible to revert it? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118352/new/ https://reviews.llvm.org/D118352 ___ cfe-commi

[clang] 845f0bb - Revert "[clang][ABI] New C++20 module mangling scheme"

Author: Chuanqi Xu Date: 2022-03-09T10:15:15+08:00 New Revision: 845f0bb5fac7479b27e5327c8787ac111e9ad610 URL: https://github.com/llvm/llvm-project/commit/845f0bb5fac7479b27e5327c8787ac111e9ad610 DIFF: https://github.com/llvm/llvm-project/commit/845f0bb5fac7479b27e5327c8787ac111e9ad610.diff LO

[PATCH] D118352: [clang][ABI] New c++20 modules mangling scheme

ChuanqiXu added a comment. In D118352#3368919 , @phosek wrote: > We're also seeing this issue on our Mac bots, is it possible to revert it? I've reverted it. Since this is the new feature, I think it wouldn't so hurry to land it. BTW, I think it would b

[PATCH] D120936: [Sema][Windows] Don't special-case void* in __unaligned conversions.

efriedma updated this revision to Diff 413989. efriedma added a comment. Added warning. This roughly matches the corresponding MSVC warning, as far as I can tell. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120936/new/ https://reviews.llvm.org/

[PATCH] D121177: [modules] Merge equivalent extensions and diagnose ivar redeclarations for extensions loaded from different modules.

ChuanqiXu added a comment. I don't know about ObjC. Comments on style/name only. Comment at: clang/include/clang/Serialization/ASTReader.h:1110 + template + using DuplicateDecls = std::pair; + How about change the name to: ``` template using DuplicateO

[PATCH] D120936: [Sema][Windows] Don't special-case void* in __unaligned conversions.

efriedma added a comment. In D120936#3368566 , @rnk wrote: > I wasn't able to find any history for why `void*` was special here. As far as I can tell, nobody ever thought `void*` was special. The check was an attempt to restrict dubious conversions whi

[PATCH] D119479: [clang][extract-api] Add global record support

zixuw updated this revision to Diff 413992. zixuw added a comment. Plug clangSymbolGraph into clangFrontendTools Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119479/new/ https://reviews.llvm.org/D119479 Files: clang/include/clang/AST/RawComment

[PATCH] D121269: [clang-format] Fix namepsace format when the name is after by a macro

zequanwu created this revision. zequanwu added reviewers: thakis, MyDeveloperDay, owenpan, klimek, sammccall. Herald added a project: All. zequanwu requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Example: $ cat a.cpp namespace my_names

[PATCH] D121096: [C++20][Modules][HU 2/5] Support searching Header Units in user or system search paths.

ChuanqiXu added inline comments. Comment at: clang/include/clang/Frontend/FrontendOptions.h:157 + unsigned HeaderUnit : 3; + unsigned Header : 1; I prefer `IsHeader` Comment at: clang/include/clang/Frontend/FrontendOptions.h:252 + bool isH

[PATCH] D121096: [C++20][Modules][HU 2/5] Support searching Header Units in user or system search paths.

ChuanqiXu added a comment. BTW, all the tests uses ``clang_cc1`. How should the users do with `clang`? Could them use `-Xclang` only? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121096/new/ https://reviews.llvm.org/D121096 _

[PATCH] D120296: [Attr] Fix a btf_type_tag AST generation bug

yonghong-song updated this revision to Diff 413995. yonghong-song added a comment. - add a pch test to test serialization with btf_type_tag. - simplify the code Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120296/new/ https://reviews.llvm.org/D120

[PATCH] D121176: [ASTStructuralEquivalence] Add support for comparing ObjCCategoryDecl.

vsapsai added inline comments. Comment at: clang/lib/AST/ASTStructuralEquivalence.cpp:1240 - FieldDecl *Field1, FieldDecl *Field2) { - const auto *Owner2 = cast(Field2->getDeclContext()); By the way, the alternative to intro

[PATCH] D119609: [Clang][Sema] Prohibit expression statement in lambda default argument

junaire updated this revision to Diff 413997. junaire added a comment. - Make sure Parser can diagnostic remaining error after the expr statement. - Prohibit expression statement in template argument - Add more tests - Better diagnostic message Repository: rG LLVM Github Monorepo CHANGES SINC

[PATCH] D119609: [Clang][Sema] Prohibit expression statement in lambda default argument

junaire added a comment. I just realized that something is not very clear here. Should we prohibit expression statements in all default arguments or just in lambda and templates? I wonder how gcc folks think about it as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[PATCH] D120244: [clang][sema] Enable first-class bool support for C2x

tbaeder marked 3 inline comments as done. tbaeder added a comment. In D120244#3368216 , @aaron.ballman wrote: > Precommit CI is failing: > > Failed Tests (1): > > Clang :: Headers/stdbool.c Heh, I guess I need to make a habit of running the tests also

[PATCH] D120244: [clang][sema] Enable first-class bool support for C2x

tbaeder updated this revision to Diff 414005. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120244/new/ https://reviews.llvm.org/D120244 Files: clang/docs/ReleaseNotes.rst clang/lib/Frontend/CompilerInvocation.cpp clang/lib/Headers/stdbool.h clang/test/Headers/stdbool.c clang/t

[PATCH] D118511: Add a warning for not packing non-POD members in packed structs

tbaeder added a comment. Hey @dblaikie, seems like this has never been pushed? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118511/new/ https://reviews.llvm.org/D118511 ___ cfe-commits mailing list cfe-

[clang-tools-extra] 81f8df0 - [clangd] Make dexp command line options sticky

Author: Yevgeny Rouban Date: 2022-03-09T12:59:49+07:00 New Revision: 81f8df0c83c6a4476f5bffa6947c0e78a94138a7 URL: https://github.com/llvm/llvm-project/commit/81f8df0c83c6a4476f5bffa6947c0e78a94138a7 DIFF: https://github.com/llvm/llvm-project/commit/81f8df0c83c6a4476f5bffa6947c0e78a94138a7.diff

[clang-tools-extra] c8a3572 - [clangd] Make dexp command line options sticky

Author: Yevgeny Rouban Date: 2022-03-09T13:00:25+07:00 New Revision: c8a35727fe7cdb06bf2a081356c36a5159598e9f URL: https://github.com/llvm/llvm-project/commit/c8a35727fe7cdb06bf2a081356c36a5159598e9f DIFF: https://github.com/llvm/llvm-project/commit/c8a35727fe7cdb06bf2a081356c36a5159598e9f.diff

[PATCH] D120713: [clangd] Make dexp command line options sticky

yrouban closed this revision. yrouban added a comment. Closed by commit https://reviews.llvm.org/rG7fb39fb6d6665cd469557b43eb205cc32b0a7ac3. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120713/new/ https://reviews.llvm.org/D120713 __

[PATCH] D121269: [clang-format] Fix namepsace format when the name is after by a macro

MyDeveloperDay requested changes to this revision. MyDeveloperDay added inline comments. This revision now requires changes to proceed. Comment at: clang/lib/Format/NamespaceEndCommentsFixer.cpp:104 + } + if (!FirstNSTok->is(tok::coloncolon)) { +Name

[PATCH] D121269: [clang-format] Fix namepsace format when the name is after by a macro

MyDeveloperDay accepted this revision. MyDeveloperDay added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Format/NamespaceEndCommentsFixer.cpp:104 + } + if (!FirstNSTok->is(tok::coloncolon)) { +NameFinished =

[PATCH] D121269: [clang-format] Fix namepsace format when the name is after by a macro

MyDeveloperDay added a comment. Please wait for the other reviewers Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121269/new/ https://reviews.llvm.org/D121269 ___ cfe-commits mailing list cfe-commits@lis

[PATCH] D121096: [C++20][Modules][HU 2/5] Support searching Header Units in user or system search paths.

iains added a comment. In D121096#3368996 , @ChuanqiXu wrote: > BTW, all the tests uses ``clang_cc1`. How should the users do with `clang`? > Could them use `-Xclang` only? The driver changes are in separate patches (they will make the same user-facing

[PATCH] D121096: [C++20][Modules][HU 2/5] Support searching Header Units in user or system search paths.

ChuanqiXu added a comment. In D121096#3369277 , @iains wrote: > In D121096#3368996 , @ChuanqiXu > wrote: > >> BTW, all the tests uses ``clang_cc1`. How should the users do with `clang`? >> Could them use `-Xclan

[PATCH] D120992: [analyzer] ReverseNull: New checker to warn for pointer value conditions, if the pointer value is unconditionally non-null

steakhal added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/NullPtrInterferenceChecker.cpp:166 +/// child is a sink node. +static bool unconditionallyLeadsHere(const ExplodedNode *N) { + size_t NonSinkNodeCount = llvm::count_if( xazax.hun wrote

[clang] f2b2490 - [Sema] Mark the referenced destructor during transformation of a `CXXBindTemporaryExpr`

Author: Argyrios Kyrtzidis Date: 2022-03-08T01:00:07-08:00 New Revision: f2b24905bfede6bd047a38f5cbae352e6b845428 URL: https://github.com/llvm/llvm-project/commit/f2b24905bfede6bd047a38f5cbae352e6b845428 DIFF: https://github.com/llvm/llvm-project/commit/f2b24905bfede6bd047a38f5cbae352e6b845428.

[PATCH] D120426: [Sema] Mark the referenced destructor during transformation of a `CXXBindTemporaryExpr`

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf2b24905bfed: [Sema] Mark the referenced destructor during transformation of a… (authored by akyrtzi). Herald added a project: All. Repository: rG

[PATCH] D119842: [clangd] NFC: Cleanup IncludeCleaner API

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Herald added a project: All. Not sure how I missed this patch, sorry! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119842/new/ https://re

[PATCH] D120713: [clangd] Make dexp command line options sticky

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Thank you! Comment at: clang-tools-extra/clangd/index/dex/dexp/Dexp.cpp:417 + + // Protect IndexLocation, ExecCommand and ProjectRoot from being reset. + IndexLocatio

[PATCH] D121197: [clang][dataflow] Add analysis that detects unsafe accesses to optionals

sgatev created this revision. sgatev added reviewers: ymandel, xazax.hun, gribozavr2. Herald added subscribers: tschuett, steakhal, rnkovacs, mgorny. Herald added a project: All. sgatev requested review of this revision. Herald added a reviewer: jdoerfert. Herald added a subscriber: sstefan1. Heral

[PATCH] D120992: [analyzer] ReverseNull: New checker to warn for pointer value conditions, if the pointer value is unconditionally non-null

Szelethus added a comment. In D120992#3364804 , @NoQ wrote: > This check checks must-properties/all-paths properties. This has to be a data > flow / CFG-based warning. I don't think there's a way around. Oof. I concede on that. Do you think there is any

[PATCH] D121198: [flang][driver] Add support for `-debug-dump-pft`

awarzynski created this revision. Herald added a reviewer: sscalpone. Herald added a subscriber: dang. Herald added projects: Flang, All. awarzynski requested review of this revision. Herald added subscribers: cfe-commits, jdoerfert. Herald added a project: clang. This patch adds support for dumpi

[PATCH] D121197: [clang][dataflow] Add analysis that detects unsafe accesses to optionals

sgatev updated this revision to Diff 413743. sgatev added a comment. Mark functions as static and add TODOs. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121197/new/ https://reviews.llvm.org/D121197 Files: clang/include/clang/Analysis/FlowSens

[PATCH] D121201: [clang] Merge the SourceRange into ParsedAttributes

tbaeder created this revision. tbaeder added a reviewer: aaron.ballman. Herald added subscribers: kbarton, nemanjai. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. I wasn't 100% whether to add the range

[PATCH] D121201: [clang] Merge the SourceRange into ParsedAttributes

tbaeder updated this revision to Diff 413744. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121201/new/ https://reviews.llvm.org/D121201 Files: clang/include/clang/Parse/Parser.h clang/include/clang/Sema/DeclSpec.h clang/include/clang/Sema/ParsedAttr.h clang/include/clang/Sema/Se

[PATCH] D121201: [clang] Merge the SourceRange into ParsedAttributes

tbaeder added inline comments. Comment at: clang/test/SemaOpenCL/address-spaces.cl:261 typedef __private int private_int_t; - __private __attribute__((opencl_global)) int var1; // expected-error {{multiple address spaces specified for type}} \ + __attribute__((opencl_glob

[PATCH] D120221: [AST] Fix typos

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. Herald added a project: All. LGTM! In D120221#3334412 , @kuzkry wrote: > Can I ask you to deliver this one for me? I don't have permissions. My

[clang] 481f681 - [AST] Fix typo in assert messages

Author: Krystian Kuzniarek Date: 2022-03-08T11:06:50Z New Revision: 481f6818670aa86e426e326975aa6ea6035d72b3 URL: https://github.com/llvm/llvm-project/commit/481f6818670aa86e426e326975aa6ea6035d72b3 DIFF: https://github.com/llvm/llvm-project/commit/481f6818670aa86e426e326975aa6ea6035d72b3.diff

[PATCH] D120221: [AST] Fix typos

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG481f6818670a: [AST] Fix typo in assert messages (authored by kuzkry, committed by Anastasia). Repository: rG LLVM Github Monorepo CHANGES SINCE L

[PATCH] D121198: [flang][driver] Add support for `-debug-dump-pft`

clementval added a comment. I’m not sure this is a feature we want to expose in the main driver. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121198/new/ https://reviews.llvm.org/D121198 ___ cfe-commits

[PATCH] D120713: [clangd] Make dexp command line options sticky

kadircet added inline comments. Comment at: clang-tools-extra/clangd/index/dex/dexp/Dexp.cpp:418 + // Protect IndexLocation, ExecCommand and ProjectRoot from being reset. + IndexLocation.setValue(IndexLocation, true /* initial */); + ExecCommand.setValue(ExecCommand, true /* i

[clang] 75aca24 - [clang] Fix reference to file that was moved.

Author: Adrian Kuegel Date: 2022-03-08T12:26:02+01:00 New Revision: 75aca24d2f49a646df5a443c55bc020450fe04a7 URL: https://github.com/llvm/llvm-project/commit/75aca24d2f49a646df5a443c55bc020450fe04a7 DIFF: https://github.com/llvm/llvm-project/commit/75aca24d2f49a646df5a443c55bc020450fe04a7.diff

[PATCH] D121198: [flang][driver] Add support for `-debug-dump-pft`

awarzynski added a comment. In D121198#3366741 , @clementval wrote: > I’m not sure this is a feature we want to expose in the main driver. It's only available in `flang-new -fc1`, i.e. the frontend driver. We are not exposing it in `flang-new`. Repos

[PATCH] D121206: [AARCH64] ssbs should be enabled by default for cortex-x1c

stuij created this revision. Herald added subscribers: hiraditya, kristof.beyls. Herald added a project: All. stuij requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llv

[PATCH] D118352: [clang][ABI] New c++20 modules mangling scheme

ChuanqiXu accepted this revision. ChuanqiXu added a comment. This revision is now accepted and ready to land. LGTM, then. BTW, I see there is already no dependency with D119833 in code. But it shows dependency still in phab. CHANGES SINCE LAST ACTION https:

[PATCH] D119609: [Clang][Sema] Don't act on ReturnStmt when parsing the lambda declarator.

junaire added inline comments. Comment at: clang/test/Sema/err-expr-stmt-in-default-arg.cpp:19 + return bar(l); +} erichkeane wrote: > For completeness, I'd like to see an > in-function-defined-struct-member-function test here as well. > > As for the above que

[PATCH] D121078: Replace links to archived mailing lists by links to Discourse forums

aaron.ballman added a comment. In D121078#3366025 , @tonic wrote: > In D121078#3365542 , @SimplyDanny > wrote: > >> In D121078#3363856 , >> @aaron.ballman wrote: >> >>>

[clang] 7a54fce - [clang-format] Handle C# 9 `init` accessor specifier.

Author: Marek Kurdej Date: 2022-03-08T13:33:36+01:00 New Revision: 7a54fceb256257e3f8c8bd16ffd55531d806c96e URL: https://github.com/llvm/llvm-project/commit/7a54fceb256257e3f8c8bd16ffd55531d806c96e DIFF: https://github.com/llvm/llvm-project/commit/7a54fceb256257e3f8c8bd16ffd55531d806c96e.diff

[PATCH] D121132: [clang-format] Handle C# 9 `init` accessor specifier.

This revision was automatically updated to reflect the committed changes. Closed by commit rG7a54fceb2562: [clang-format] Handle C# 9 `init` accessor specifier. (authored by curdeius). Changed prior to commit: https://reviews.llvm.org/D121132?vs=413539&id=413763#toc Repository: rG LLVM Githu

[PATCH] D121198: [flang][driver] Add support for `-debug-dump-pft`

shraiysh accepted this revision. shraiysh added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121198/new/ https://reviews.llvm.org/D121198 __

[clang] f537a40 - [clang-format] Correctly detect `!` as TT_NonNullAssertion after `default`.

Author: Marek Kurdej Date: 2022-03-08T13:35:26+01:00 New Revision: f537a409160dc1e506445724c5256bb116c0d71a URL: https://github.com/llvm/llvm-project/commit/f537a409160dc1e506445724c5256bb116c0d71a DIFF: https://github.com/llvm/llvm-project/commit/f537a409160dc1e506445724c5256bb116c0d71a.diff

[PATCH] D121136: [clang-format] Correctly detect `!` as TT_NonNullAssertion after `default`.

This revision was automatically updated to reflect the committed changes. Closed by commit rGf537a409160d: [clang-format] Correctly detect `!` as TT_NonNullAssertion after `default`. (authored by curdeius). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[clang-tools-extra] d5106c8 - [clangd] NFC: Cleanup IncludeCleaner API

Author: Kirill Bobyrev Date: 2022-03-08T13:43:25+01:00 New Revision: d5106c8f973b76e49d64ac3d91236efafd771c7c URL: https://github.com/llvm/llvm-project/commit/d5106c8f973b76e49d64ac3d91236efafd771c7c DIFF: https://github.com/llvm/llvm-project/commit/d5106c8f973b76e49d64ac3d91236efafd771c7c.diff

[PATCH] D119842: [clangd] NFC: Cleanup IncludeCleaner API

This revision was automatically updated to reflect the committed changes. Closed by commit rGd5106c8f973b: [clangd] NFC: Cleanup IncludeCleaner API (authored by kbobyrev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119842/new/ https://reviews.llv

[PATCH] D121206: [AARCH64] ssbs should be enabled by default for cortex-x1c

dmgreen added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64.td:978 FeatureNEON, FeatureRCPC, FeaturePerfMon, FeatureSPE, FeatureFullFP16, FeatureDotProd]; list X1C = [HasV8_2aOps, FeatureCrypto

[PATCH] D112906: [PowerPC] Emit warning for ieeelongdouble on older GNU toolchain

tbaeder added a comment. Herald added a project: All. Hi @qiucf, I'm running into a problem with the testsuite that's caused by this patch. I think the comment from @jsji about newer glibc was never addressed. When running the testsuite on ppc64le with a glibc newer than 2.34, the the warning

[PATCH] D120244: [clang][sema] Enable first-class bool support for C2x

aaron.ballman added a comment. In D120244#3362215 , @tbaeder wrote: > Thanks for the links to the papers. What's the best way of updating > https://clang.llvm.org/c_status.html#c2x with the new papers? I update that page from the WG14 editor's report (o

[PATCH] D120639: [RISCV] Pass -mno-relax to assembler when -fno-integrated-as specified

StephenFan updated this revision to Diff 413774. StephenFan added a comment. Address @kito-cheng 's comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120639/new/ https://reviews.llvm.org/D120639 Files: clang/lib/Driver/ToolChains/Gnu.cpp

[PATCH] D121209: [clang][driver] Fix float128 diagnostics with glibc >= 2.32

tbaeder created this revision. tbaeder added reviewers: qiucf, jsji, kbarton. Herald added a subscriber: nemanjai. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. As explained in https://reviews.llvm.org

[PATCH] D121206: [AARCH64] ssbs should be enabled by default for cortex-x1c

DavidSpickett added inline comments. Comment at: clang/test/Preprocessor/aarch64-target-features.c:288 // CHECK-MCPU-CORTEX-A73: "-cc1"{{.*}} "-triple" "aarch64{{.*}}" "-target-feature" "+v8a" "-target-feature" "+fp-armv8" "-target-feature" "+neon" "-target-feature" "+crc" "-t

[PATCH] D119609: [Clang][Sema] Don't act on ReturnStmt when parsing the lambda declarator.

erichkeane added inline comments. Comment at: clang/test/Sema/err-expr-stmt-in-default-arg.cpp:19 + return bar(l); +} junaire wrote: > erichkeane wrote: > > For completeness, I'd like to see an > > in-function-defined-struct-member-function test here as well. >

[PATCH] D119609: [Clang][Sema] Don't act on ReturnStmt when parsing the lambda declarator.

erichkeane added a comment. Also, please update the commit-message/title to better reflect the change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119609/new/ https://reviews.llvm.org/D119609 ___ cfe-c

[PATCH] D120244: [clang][sema] Enable first-class bool support for C2x

tbaeder updated this revision to Diff 413782. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120244/new/ https://reviews.llvm.org/D120244 Files: clang/docs/ReleaseNotes.rst clang/lib/Frontend/CompilerInvocation.cpp clang/lib/Headers/stdbool.h clang/test/Headers/stdbool.c clang/t

[PATCH] D120244: [clang][sema] Enable first-class bool support for C2x

tbaeder marked 2 inline comments as done. tbaeder added inline comments. Comment at: clang/lib/Headers/stdbool.h:16 /* Don't define bool, true, and false in C++, except as a GNU extension. */ #ifndef __cplusplus #define bool _Bool aaron.ballman wrote: > We're

[PATCH] D121211: Properly diagnose constant evaluation issues at TU scope

aaron.ballman created this revision. aaron.ballman added reviewers: cor3ntin, erichkeane, bruno, rsmith. Herald added a project: All. aaron.ballman requested review of this revision. Herald added a project: clang. We were not creating an evaluation context for the TU scope, so we never popped an

[PATCH] D121209: [clang][driver] Fix float128 diagnostics with glibc >= 2.32

qiucf accepted this revision. qiucf added a comment. This revision is now accepted and ready to land. LGTM, thanks for the catch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121209/new/ https://reviews.llvm.org/D121209 __

[PATCH] D120770: [C2x] Implement literal suffixes for _BitInt

aaron.ballman added a comment. If there aren't additional review comments, I plan to land this tomorrow. Any comments that come in after that are ones I'm happy to address post-commit. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120770/new/ https://reviews.llvm.org/D120770 _

[clang] 21e16ab - [clang][ABI] New C++20 module mangling scheme

Author: Nathan Sidwell Date: 2022-03-08T06:21:50-08:00 New Revision: 21e16ab6b8ddaccb70d2344bb35419e214a32ec9 URL: https://github.com/llvm/llvm-project/commit/21e16ab6b8ddaccb70d2344bb35419e214a32ec9 DIFF: https://github.com/llvm/llvm-project/commit/21e16ab6b8ddaccb70d2344bb35419e214a32ec9.diff

[PATCH] D118352: [clang][ABI] New c++20 modules mangling scheme

This revision was automatically updated to reflect the committed changes. Closed by commit rG21e16ab6b8dd: [clang][ABI] New C++20 module mangling scheme (authored by urnathan). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D121150: [pseudo][WIP] Implement a GLR parser.

hokein updated this revision to Diff 413788. hokein added a comment. fix a subtle bug where we might leave an unremoved node in the reduce path. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121150/new/ https://reviews.llvm.org/D121150 Files: cl

[PATCH] D121211: Properly diagnose constant evaluation issues at TU scope

cor3ntin accepted this revision. cor3ntin added a comment. This revision is now accepted and ready to land. There is already an evaluation context created in Sema but it's never popped back. And because we rely heavily on there always being at least one evaluation context (`ExprEvalContexts.back

[PATCH] D121197: [clang][dataflow] Add analysis that detects unsafe accesses to optionals

ymandel added a comment. Maybe add explanation to the patch description for move of `TestingSupport.h`? Also, mention that this just a core implementation, and fuller support is coming? Comment at: clang/include/clang/Analysis/FlowSensitive/Models/UncheckedOptionalAccessMod

[PATCH] D118352: [clang][ABI] New c++20 modules mangling scheme

thakis added a comment. Looks like this breaks tests on macOS: http://45.33.8.238/macm1/29650/step_7.txt Please take a look and revert for now if it takes a while to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118352/new/ https://reviews.ll

[PATCH] D121211: Properly diagnose constant evaluation issues at TU scope

aaron.ballman updated this revision to Diff 413793. aaron.ballman added a comment. Added a comment and an additional test case. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121211/new/ https://reviews.llvm.org/D121211 Files: clang/docs/ReleaseNotes.rst clang/lib/Parse/ParseAST.cpp

[PATCH] D118352: [clang][ABI] New c++20 modules mangling scheme

thakis added a comment. (also, please don't land unused code -- land those functions when you land their callers) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118352/new/ https://reviews.llvm.org/D118352 _

[PATCH] D121214: [clang-tidy][docs][NFC] Add alias cert-mem51-cpp to bugprone-shared-ptr-array-mismatch

steakhal created this revision. steakhal added reviewers: whisperity, aaron.ballman. Herald added subscribers: jeroen.dobbelaere, martong, rnkovacs, xazax.hun. Herald added a project: All. steakhal requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscrib

[clang] 5b7941a - [clang][driver] Fix float128 diagnostics with glibc >= 2.32

Author: Timm Bäder Date: 2022-03-08T15:49:01+01:00 New Revision: 5b7941ad7c893b4bb019e3c96b760b0f2670ccfc URL: https://github.com/llvm/llvm-project/commit/5b7941ad7c893b4bb019e3c96b760b0f2670ccfc DIFF: https://github.com/llvm/llvm-project/commit/5b7941ad7c893b4bb019e3c96b760b0f2670ccfc.diff LO

[PATCH] D121209: [clang][driver] Fix float128 diagnostics with glibc >= 2.32

This revision was automatically updated to reflect the committed changes. Closed by commit rG5b7941ad7c89: [clang][driver] Fix float128 diagnostics with glibc >= 2.32 (authored by tbaeder). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121209/new/ h

  1   2   >