[PATCH] D121045: [analyzer][NFC] Merge similar conditional paths

steakhal requested changes to this revision. steakhal added a comment. This revision now requires changes to proceed. Shadowing potential names is not a good idea. BTW OpCodes are often abbreviated to `Op` in variable names in this context. Comment at: clang/lib/StaticAnalyzer/

[PATCH] D119172: [pseudo] Implement LRGraph

hokein added inline comments. Comment at: clang/include/clang/Tooling/Syntax/Pseudo/LRGraph.h:96 + uint8_t DotPos = 0; + uint8_t RuleLength = 0; // the length of rule body. +}; alextsao1999 wrote: > Can we add LookaheadSymbol here to implement LR(1)? we could d

[PATCH] D121089: [pseudo] empty parameter-declaration should be allowed in lambda declarator.

hokein created this revision. hokein added a reviewer: sammccall. Herald added a project: All. hokein requested review of this revision. Herald added a subscriber: alextsao1999. Herald added a project: clang. This was an oversight, as we did a avoild-nullable modication to parameter-declaration-cl

[PATCH] D120307: [X86] Add helper enum for ternary intrinsics

RKSimon accepted this revision. RKSimon added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120307/new/ https://reviews.llvm.org/D120307 ___ cfe-commits mailing list cfe-commits@lists.llv

[clang] 242b24c - [clang][modules] NFC: Simplify and clarify test

Author: Jan Svoboda Date: 2022-03-07T10:47:46+01:00 New Revision: 242b24c1849165bedb73fb14c8012d1d63ffd344 URL: https://github.com/llvm/llvm-project/commit/242b24c1849165bedb73fb14c8012d1d63ffd344 DIFF: https://github.com/llvm/llvm-project/commit/242b24c1849165bedb73fb14c8012d1d63ffd344.diff L

[clang] b45888e - [clang][modules] Report module maps affecting `no_undeclared_includes` modules

Author: Jan Svoboda Date: 2022-03-07T10:47:46+01:00 New Revision: b45888e959ad2d6562b8d321166e6387facdd412 URL: https://github.com/llvm/llvm-project/commit/b45888e959ad2d6562b8d321166e6387facdd412 DIFF: https://github.com/llvm/llvm-project/commit/b45888e959ad2d6562b8d321166e6387facdd412.diff L

[PATCH] D120463: [clang][modules] NFC: Simplify and clarify test

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG242b24c18491: [clang][modules] NFC: Simplify and clarify test (authored by jansvoboda11). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D120464: [clang][modules] Report module maps affecting `no_undeclared_includes` modules

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb45888e959ad: [clang][modules] Report module maps affecting `no_undeclared_includes` modules (authored by jansvoboda11). Repository: rG LLVM Githu

[PATCH] D120902: [clang-format] Fix assertion failure/crash with `AllowShortFunctionsOnASingleLine: Inline/InlineOnly`.

curdeius updated this revision to Diff 413380. curdeius added a comment. Safer condition. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120902/new/ https://reviews.llvm.org/D120902 Files: clang/lib/Format/UnwrappedLineFormatter.cpp clang/unitt

[PATCH] D121092: [pseudo] Strip comments for TokenStream.

hokein created this revision. hokein added a reviewer: sammccall. Herald added a project: All. hokein requested review of this revision. Herald added a subscriber: alextsao1999. Herald added a project: clang. Add a utility function to strip comments from a "raw" tokenstream. The derived stream wil

[PATCH] D120857: WIP [randstruct] Create basis for unit test module

void updated this revision to Diff 413383. void added a comment. Don't warn on multiple attributes. Instead, use the last one to indicate whether to randomize the layout or not. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120857/new/ https://rev

[PATCH] D120465: [clang][deps] Generate necessary "-fmodule-map-file=" arguments, disable implicit module maps

jansvoboda11 updated this revision to Diff 413384. jansvoboda11 added a comment. Review feedback (add TODO & rename function) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120465/new/ https://reviews.llvm.org/D120465 Files: clang/include/clang/T

[PATCH] D118915: [clang][deps] Generate '-fmodule-file=' only for direct dependencies

jansvoboda11 updated this revision to Diff 413386. jansvoboda11 added a comment. Herald added a project: All. Rebase on top of D120465 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118915/new/ https://reviews.llvm

[PATCH] D120474: [clang][deps] Remove '-fmodules-cache-path=' arguments

jansvoboda11 updated this revision to Diff 413387. jansvoboda11 added a comment. Update TODO instead of removing it Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120474/new/ https://reviews.llvm.org/D120474 Files: clang/lib/Tooling/DependencySca

[PATCH] D114382: [clang] Fix wrong -Wunused-local-typedef warning within a template function

krisb added a comment. Herald added a project: All. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114382/new/ https://reviews.llvm.org/D114382 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D120369: [analyzer] Add more propagations to Taint analysis

gamesh411 updated this revision to Diff 413388. gamesh411 added a comment. Herald added a project: All. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120369/new/ https://reviews.llvm.org/D120369 Files: clang/docs/analyzer/checkers.rst c

[clang] 2d26f16 - [clang][modules] Fix failing test

Author: Jan Svoboda Date: 2022-03-07T11:21:21+01:00 New Revision: 2d26f163f60ea4a466584a2347ccc09fc1595c76 URL: https://github.com/llvm/llvm-project/commit/2d26f163f60ea4a466584a2347ccc09fc1595c76 DIFF: https://github.com/llvm/llvm-project/commit/2d26f163f60ea4a466584a2347ccc09fc1595c76.diff L

[PATCH] D121093: [Driver][AArch64] Split up aarch64-cpus.c test further

tyb0807 created this revision. tyb0807 added reviewers: dmgreen, lenary, tmatheson, simon_tatham, fhahn. Herald added a subscriber: kristof.beyls. Herald added a project: All. tyb0807 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is

[PATCH] D120464: [clang][modules] Report module maps affecting `no_undeclared_includes` modules

Orlando added a comment. Hi, the test `add-remove-irrelevant-module-map.m` starts failing with this commit on the `llvm-clang-x86_64-sie-win` builder: https://lab.llvm.org/buildbot/#/builders/216/builds/929. Please can you take a look when you get the chance? Repository: rG LLVM Github Mono

[PATCH] D121100: [clang][DebugInfo] clang should not generate DW_TAG_subprogram entry without DW_AT_name

alok created this revision. alok added reviewers: aprantl, djtodoro, jini.susan. alok added a project: debug-info. Herald added a project: All. alok requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Currently Clang is generating subprograms w

[PATCH] D120464: [clang][modules] Report module maps affecting `no_undeclared_includes` modules

jansvoboda11 added a comment. In D120464#3363258 , @Orlando wrote: > Hi, the test `add-remove-irrelevant-module-map.m` starts failing with this > commit on the `llvm-clang-x86_64-sie-win` builder: > https://lab.llvm.org/buildbot/#/builders/216/builds/92

[PATCH] D120464: [clang][modules] Report module maps affecting `no_undeclared_includes` modules

Orlando added a comment. In D120464#3363274 , @jansvoboda11 wrote: > In D120464#3363258 , @Orlando wrote: > >> Hi, the test `add-remove-irrelevant-module-map.m` starts failing with this >> commit on the `llvm-cl

[PATCH] D121093: [Driver][AArch64] Split up aarch64-cpus.c test further

simon_tatham added inline comments. Comment at: clang/test/Driver/aarch64-cpus.c:2 +// Check target CPUs are correctly passed. +// TODO: The files should be split up by categories, e.g. by architecture versions, to avoid excessive test // times for large single test files.

[PATCH] D121045: [analyzer][NFC] Merge similar conditional paths

phyBrackets updated this revision to Diff 413402. phyBrackets added a comment. used the correct name for Opcodes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121045/new/ https://reviews.llvm.org/D121045 Files: clang/docs/DataFlowAnalysisIntro.m

[PATCH] D121093: [Driver][AArch64] Split up aarch64-cpus.c test further

tyb0807 marked an inline comment as done. tyb0807 added inline comments. Comment at: clang/test/Driver/aarch64-cpus.c:2 +// Check target CPUs are correctly passed. +// TODO: The files should be split up by categories, e.g. by architecture versions, to avoid excessive test // ti

[PATCH] D121093: [Driver][AArch64] Split up aarch64-cpus.c test further

tmatheson accepted this revision. tmatheson added a comment. This revision is now accepted and ready to land. Thanks for picking this up, LGTM Comment at: clang/test/Driver/aarch64-archs.c:296 -// NO-LS64-NOT: "-target-feature" "+ls64" -// LS64: "-target-feature" "+ls64" -

[PATCH] D121101: [clang] Fix OpenMP critical hint parameter check

peixin created this revision. peixin added a reviewer: ABataev. peixin added a project: OpenMP. Herald added subscribers: guansong, yaxunl. Herald added a project: All. peixin requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: cfe-commits, sstefan1. Her

[PATCH] D121103: [clang] Adjust LookupTest for UsingTypeLocs

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added a project: All. kadircet requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. We no longer traverse the underlying RecordTypeLoc directly, but rather visit the Us

[PATCH] D119040: Fix LookupTest where it was missing an assertion

kadircet added a comment. Thanks for the change, but the test is actually checking for rename in presence of using-decls. I beleive https://reviews.llvm.org/D121103 is the proper fix here. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119040/new/ https://reviews.llvm.org/D119040

[PATCH] D121101: [clang] Fix OpenMP critical hint parameter check

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121101/new/ https://reviews.llvm.org/D121101 ___

[PATCH] D121077: Simplify OpenMP Lambda use

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121077/new/ https://reviews.llvm.org/D121077 ___

[PATCH] D121093: [Driver][AArch64] Split up aarch64-cpus.c test further

simon_tatham accepted this revision. simon_tatham added inline comments. Comment at: clang/test/Driver/aarch64-cpus.c:2 +// Check target CPUs are correctly passed. +// TODO: The files should be split up by categories, e.g. by architecture versions, to avoid excessive test // ti

[clang] 4fd6c6e - [analyzer] Add more propagations to Taint analysis

Author: Endre Fülöp Date: 2022-03-07T13:18:54+01:00 New Revision: 4fd6c6e65ab59f82284d8272aa3bec8d5084511e URL: https://github.com/llvm/llvm-project/commit/4fd6c6e65ab59f82284d8272aa3bec8d5084511e DIFF: https://github.com/llvm/llvm-project/commit/4fd6c6e65ab59f82284d8272aa3bec8d5084511e.diff L

[PATCH] D120369: [analyzer] Add more propagations to Taint analysis

This revision was automatically updated to reflect the committed changes. Closed by commit rG4fd6c6e65ab5: [analyzer] Add more propagations to Taint analysis (authored by gamesh411). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120369/new/ https://

[PATCH] D121093: [Driver][AArch64] Split up aarch64-cpus.c test further

fhahn added a comment. Thanks! Comment at: clang/test/Driver/aarch64-cpus.c:2 +// Check target CPUs are correctly passed. +// TODO: The files should be split up by categories, e.g. by architecture versions, to avoid excessive test // times for large single test files. ---

[PATCH] D120984: [clang][dataflow] Extend flow conditions from block terminators

sgatev updated this revision to Diff 413426. sgatev marked 5 inline comments as done. sgatev added a comment. Address reviewers' comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120984/new/ https://reviews.llvm.org/D120984 Files: clang/in

[PATCH] D120984: [clang][dataflow] Extend flow conditions from block terminators

sgatev added inline comments. Comment at: clang/include/clang/Analysis/FlowSensitive/DataflowEnvironment.h:99 + const Environment &Env2, Value &MergedVal, + Environment &Env) { return false; xazax.hun wrote: > `M

[PATCH] D120774: [clang-format] Handle builtins in constraint expression

HazardyKnusperkeks updated this revision to Diff 413430. HazardyKnusperkeks marked 3 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120774/new/ https://reviews.llvm.org/D120774 Files: clang/lib/Format/UnwrappedLineParser.cpp clang/unittests/Format/FormatTest.c

[PATCH] D120774: [clang-format] Handle builtins in constraint expression

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:3090-3093 +#define TYPE_TRAIT(N, I, K) case tok::kw_##I: +#define ARRAY_TYPE_TRAIT(I, E, K) case tok::kw_##I: +#define EXPRESSION_TRAIT(I, E, K) case tok::kw_##I: +#include "clang/Basic

[PATCH] D121095: [C++20][Modules][HU 1/5] Introduce header units as a module type.

iains created this revision. Herald added subscribers: dexonsmith, dang. Herald added a project: All. iains added reviewers: rsmith, urnathan, ChuanqiXu. iains added a subscriber: clang-modules. iains edited the summary of this revision. iains added a comment. iains published this revision for revi

[PATCH] D121096: [C++20][Modules][HU 2/5] Support searching Header Units in user or system search paths.

iains created this revision. Herald added a project: All. iains added reviewers: rsmith, urnathan, ChuanqiXu. iains published this revision for review. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is support for the user-facing options to create importable header uni

[PATCH] D121097: [C++20][Modules][HU 3/5] Emit module macros for header units.

iains created this revision. Herald added a project: All. iains added reviewers: rsmith, urnathan, ChuanqiXu. iains published this revision for review. Herald added a project: clang. Herald added a subscriber: cfe-commits. For header units we build the top level module directly from the header tha

[PATCH] D121098: [C++20][Modules][HU 4/5] Handle pre-processed header units.

iains created this revision. Herald added a project: All. iains added reviewers: rsmith, urnathan, ChuanqiXu. iains published this revision for review. Herald added a project: clang. Herald added a subscriber: cfe-commits. We wish to support emitting a pre-processed output for an importable header

[PATCH] D121099: [C++20][Modules][HU 5/5] Add fdirectives-only mode for preprocessing output.

iains created this revision. Herald added a subscriber: dang. Herald added a project: All. iains added reviewers: rsmith, urnathan, ChuanqiXu. iains published this revision for review. Herald added a project: clang. Herald added a subscriber: cfe-commits. When the -fdirectives-only option is used

[PATCH] D121108: [pseudo] Add readme

sammccall created this revision. sammccall added a reviewer: hokein. Herald added a project: All. sammccall requested review of this revision. Herald added subscribers: cfe-commits, alextsao1999. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D121108

[PATCH] D121092: [pseudo] Strip comments for TokenStream.

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang/include/clang/Tooling/Syntax/Pseudo/Preprocess.h:144 +/// Drops comment tokens. +TokenStream stripComments(const TokenStream &); ---

[PATCH] D121108: [pseudo] Add readme

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. Thanks! Comment at: clang/lib/Tooling/Syntax/Pseudo/README.md:8 +The result is a strict syntactic tree whose structure follows the C++ grammar. +There is no syntactic analysi

[PATCH] D121093: [Driver][AArch64] Split up aarch64-cpus.c test further

tmatheson added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121093/new/ https://reviews.llvm.org/D121093 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/c

[PATCH] D121093: [Driver][AArch64] Split up aarch64-cpus.c test further

tyb0807 marked 2 inline comments as done. tyb0807 added inline comments. Comment at: clang/test/Driver/aarch64-archs.c:296 -// NO-LS64-NOT: "-target-feature" "+ls64" -// LS64: "-target-feature" "+ls64" - tmatheson wrote: > Looks like these were duplicate tests? B

[PATCH] D121092: [pseudo] Strip comments for TokenStream.

hokein added inline comments. Comment at: clang/include/clang/Tooling/Syntax/Pseudo/Preprocess.h:144 +/// Drops comment tokens. +TokenStream stripComments(const TokenStream &); sammccall wrote: > I think this fits more naturally into Token.h next to cook(). >

[PATCH] D121093: [Driver][AArch64] Split up aarch64-cpus.c test further

tyb0807 added a comment. > Yeah that sounds good. Maybe aarch64-cortex-cpus.c might be a good start, to > avoid having too many small files. Oops, I went ahead and split to many small cortex test files. Not really sure what would be better. What do you think @simon_tatham @fhahn @tmatheson ?

[PATCH] D121093: [Driver][AArch64] Split up aarch64-cpus.c test further

simon_tatham added a comment. I like this version! This definitely says to me "nobody is going to just thoughtlessly append to an existing file". Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121093/new/ https://reviews.llvm.org/D121093 _

[PATCH] D119172: [pseudo] Implement LRGraph

alextsao1999 added inline comments. Comment at: clang/include/clang/Tooling/Syntax/Pseudo/LRGraph.h:96 + uint8_t DotPos = 0; + uint8_t RuleLength = 0; // the length of rule body. +}; hokein wrote: > alextsao1999 wrote: > > Can we add LookaheadSymbol here to imp

[clang] bfc40b1 - [analyzer] Fix buildbot failure for D120369

Author: Endre Fülöp Date: 2022-03-07T14:56:04+01:00 New Revision: bfc40b1a1a2c6149e2ebcdc47ffac7d018e2b78d URL: https://github.com/llvm/llvm-project/commit/bfc40b1a1a2c6149e2ebcdc47ffac7d018e2b78d DIFF: https://github.com/llvm/llvm-project/commit/bfc40b1a1a2c6149e2ebcdc47ffac7d018e2b78d.diff L

[PATCH] D118259: [AArch64] Adjust aarch64-neon-intrinsics-constrained test and un-XFAIL

john.brawn added a comment. Herald added a project: All. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118259/new/ https://reviews.llvm.org/D118259 ___ cfe-commits mailing list cfe-commits@lists.ll

[PATCH] D121063: [AST] Make the last element in the linked list null

urnathan resigned from this revision. urnathan added a comment. Huh? this web interface is confusing. How did this ever work -- doesn't the decl's ctor set this to null? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121063/new/ https://reviews.ll

[PATCH] D121092: [pseudo] Strip comments for TokenStream.

hokein updated this revision to Diff 413446. hokein marked an inline comment as done. hokein added a comment. address comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121092/new/ https://reviews.llvm.org/D121092 Files: clang/include/clang/

[PATCH] D119407: [PowerPC] [Clang] Add SSE4 and BMI compatible intrinsics implementation for PowerPC

jsji accepted this revision as: jsji. jsji added a comment. This revision is now accepted and ready to land. LGTM. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119407/new/ https://reviews.llvm.org/D119407 _

[PATCH] D121112: [clang-format] Fix namespace end comments in ObjC++ files too

thakis created this revision. thakis added reviewers: MyDeveloperDay, zequanwu. Herald added a project: All. thakis requested review of this revision. See also d96ae867351ec. https://reviews.llvm.org/D121112 Files: clang/lib/Format/Format.cpp clang/unittests/Format/FormatTest.cpp clang/un

[PATCH] D119172: [pseudo] Implement LRGraph

sammccall added inline comments. Comment at: clang/include/clang/Tooling/Syntax/Pseudo/LRGraph.h:96 + uint8_t DotPos = 0; + uint8_t RuleLength = 0; // the length of rule body. +}; alextsao1999 wrote: > hokein wrote: > > alextsao1999 wrote: > > > Can we add Look

[PATCH] D121019: [clang-tools-extra] Document clang tidy unit tests target

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM! Comment at: clang-tools-extra/docs/clang-tidy/Contributing.rst:369 +Test targets in LLVM and Clang are excluded from the "build all" style action of +IDE based CMake generators, so you need to explicitl

[PATCH] D107141: [Inline-asm] Add structure type handling when they are tied in input and output constraints

pengfei updated this revision to Diff 413453. pengfei added a comment. Herald added a project: All. Refactor. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107141/new/ https://reviews.llvm.org/D107141 Files: clang/include/clang/Basic/DiagnosticS

[clang] 68b4e2d - [pseudo] Add readme

Author: Sam McCall Date: 2022-03-07T15:54:00+01:00 New Revision: 68b4e2d703e3b89b44084825786106e32b456c9c URL: https://github.com/llvm/llvm-project/commit/68b4e2d703e3b89b44084825786106e32b456c9c DIFF: https://github.com/llvm/llvm-project/commit/68b4e2d703e3b89b44084825786106e32b456c9c.diff LO

[PATCH] D121108: [pseudo] Add readme

This revision was automatically updated to reflect the committed changes. sammccall marked an inline comment as done. Closed by commit rG68b4e2d703e3: [pseudo] Add readme (authored by sammccall). Changed prior to commit: https://reviews.llvm.org/D121108?vs=413432&id=413456#toc Repository: rG

[PATCH] D121078: Replace links to archived mailing lists by links to Discourse forums

ldionne requested changes to this revision. ldionne added a comment. This revision now requires changes to proceed. Thanks for doing this! We need to fix a few undefined references, though. Comment at: libcxx/docs/index.rst:223 * `libcxx-commits Mailing List`_ * `libcxx-dev M

[PATCH] D121063: [AST] Make the last element in the linked list null

erichkeane added a comment. I suspect this works because we never really treated this as a LL, just as a pair of iterators. Two things: 1- Can you produce some situation where this is valuable to do? 2- Can you switch this over so that the NextInContextAndBits initializes to nullptr/0 so that

[PATCH] D121019: [clang-tools-extra] Document clang tidy unit tests target

LegalizeAdulthood updated this revision to Diff 413464. LegalizeAdulthood added a comment. Update from review comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121019/new/ https://reviews.llvm.org/D121019 Files: clang-tools-extra/docs/clang-tidy/Contributing.rst Index: clang-t

[PATCH] D121078: Replace links to archived mailing lists by links to Discourse forums

aaron.ballman added a comment. I think we need to retain *some* references to the existing mailing list archives. The migration to Discourse worked fairly well, but there were still data migration issues. For example: https://discourse.llvm.org/t/memory-barrier-problem/57493 https://lists.llvm

[clang-tools-extra] de29719 - [clang-tools-extra] Document clang tidy unit tests target

Author: Richard Date: 2022-03-07T08:24:08-07:00 New Revision: de29719af2c7d1772e14b45f8da75626735246e6 URL: https://github.com/llvm/llvm-project/commit/de29719af2c7d1772e14b45f8da75626735246e6 DIFF: https://github.com/llvm/llvm-project/commit/de29719af2c7d1772e14b45f8da75626735246e6.diff LOG:

[clang] d65952b - [clang] Adjust LookupTest for UsingTypeLocs

Author: Kadir Cetinkaya Date: 2022-03-07T16:22:03+01:00 New Revision: d65952b9bd8099b7405a4168d501596256a49f87 URL: https://github.com/llvm/llvm-project/commit/d65952b9bd8099b7405a4168d501596256a49f87 DIFF: https://github.com/llvm/llvm-project/commit/d65952b9bd8099b7405a4168d501596256a49f87.dif

[PATCH] D121019: [clang-tools-extra] Document clang tidy unit tests target

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGde29719af2c7: [clang-tools-extra] Document clang tidy unit tests target (authored by LegalizeAdulthood). Repository: rG LLVM Github Monorepo CHAN

[PATCH] D121103: [clang] Adjust LookupTest for UsingTypeLocs

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd65952b9bd80: [clang] Adjust LookupTest for UsingTypeLocs (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D120323: [clang][SVE] Add support for arithmetic operators on SVE types

DavidTruby updated this revision to Diff 413470. DavidTruby added a comment. Add tests for in-place operators Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120323/new/ https://reviews.llvm.org/D120323 Files: clang/include/clang/AST/Type.h clan

[PATCH] D120296: [Attr] Fix a btf_type_tag AST generation bug

erichkeane added a comment. I only looked at the 'new type' code, and it generally looks correct with the exception of the comments below. Comment at: clang/include/clang/AST/Type.h:4793 + + QualType ModifiedType; + QualType EquivalentType; I suspect both of

[PATCH] D118352: [clang][ABI] New c++20 modules mangling scheme

urnathan updated this revision to Diff 413472. urnathan added a comment. added partition tests CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118352/new/ https://reviews.llvm.org/D118352 Files: clang/include/clang/AST/Mangle.h clang/lib/AST/Decl.cpp clang/lib/AST/ItaniumMangle.cpp

[PATCH] D118352: [clang][ABI] New c++20 modules mangling scheme

urnathan added a comment. In D118352#3362694 , @ChuanqiXu wrote: > In D118352#3359626 , @urnathan > wrote: > >> >> Correct, it is not called as the global initializer pieces are not yet >> implemented. Let'

[PATCH] D121122: Set FLT_EVAL_METHOD to -1 when fast-math is enabled.

zahiraam created this revision. zahiraam added reviewers: andrew.w.kaylor, aaron.ballman, thakis, rjmccall, fhahn. Herald added a project: All. zahiraam requested review of this revision. Herald added a project: clang. Currently the control of the eval-method is mixed with fast-math. FLT_EVAL_M

[PATCH] D119609: [Clang][Sema] Don't act on ReturnStmt when parsing the lambda declarator.

erichkeane added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:4366 +def err_expr_statement_in_default_arg : Error< + "can't use expression statement in default argument">; I'm not a fan of this text here(for 1, contractions are

[clang] d03e342 - [clang-format] Fix assertion failure/crash with `AllowShortFunctionsOnASingleLine: Inline/InlineOnly`.

Author: Marek Kurdej Date: 2022-03-07T16:54:08+01:00 New Revision: d03e342803df7a75fb86c5a5c07cd84f3683bef9 URL: https://github.com/llvm/llvm-project/commit/d03e342803df7a75fb86c5a5c07cd84f3683bef9 DIFF: https://github.com/llvm/llvm-project/commit/d03e342803df7a75fb86c5a5c07cd84f3683bef9.diff

[PATCH] D120902: [clang-format] Fix assertion failure/crash with `AllowShortFunctionsOnASingleLine: Inline/InlineOnly`.

This revision was automatically updated to reflect the committed changes. Closed by commit rGd03e342803df: [clang-format] Fix assertion failure/crash with… (authored by curdeius). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120902/new/ https://rev

[PATCH] D120301: clang-tools-extra: Make test dependency on LLVMHello optional

tstellar added a comment. Herald added a project: All. @vtjnash There hasn't been consensus on removing support for standalone builds yet, and I'm in favor of keeping them as are some other distribution maintainers. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://r

[PATCH] D118352: [clang][ABI] New c++20 modules mangling scheme

iains added a comment. In D118352#3363909 , @urnathan wrote: > In D118352#3362694 , @ChuanqiXu > wrote: > >> In D118352#3359626 , @urnathan >> wrote: >> >>> > > > >>> C

[PATCH] D106184: [BPF] Use elementtype attribute for preserve.array/struct.index intrinsics

nikic added inline comments. Herald added a project: All. Comment at: llvm/lib/Target/BPF/BPFAbstractMemberAccess.cpp:303 CInfo.RecordAlignment = DL->getABITypeAlign(CInfo.Base->getType()->getPointerElementType()); return true; yonghong-song wr

[PATCH] D114382: [clang] Fix wrong -Wunused-local-typedef warning within a template function

thakis accepted this revision. thakis added a comment. This revision is now accepted and ready to land. Seems like a progression :) Do you have commit permissoins? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114382/new/ https://reviews.llvm.org/

[clang] 90a6e35 - [analyzer][NFC] Merge similar conditional paths

Author: phyBrackets Date: 2022-03-07T22:05:27+05:30 New Revision: 90a6e3547863922ede7e2df1a1a650d1ef7d040a URL: https://github.com/llvm/llvm-project/commit/90a6e3547863922ede7e2df1a1a650d1ef7d040a DIFF: https://github.com/llvm/llvm-project/commit/90a6e3547863922ede7e2df1a1a650d1ef7d040a.diff L

[PATCH] D121045: [analyzer][NFC] Merge similar conditional paths

This revision was automatically updated to reflect the committed changes. Closed by commit rG90a6e3547863: [analyzer][NFC] Merge similar conditional paths (authored by phyBrackets). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121045/new/ https://r

[PATCH] D121045: [analyzer][NFC] Merge similar conditional paths

phyBrackets added a comment. Thanks @steakhal ! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121045/new/ https://reviews.llvm.org/D121045 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://

[clang] 54d6b5b - [pseudo] Rename {Preprocess,PPStructure} -> DirectiveMap. NFC

Author: Sam McCall Date: 2022-03-07T17:41:35+01:00 New Revision: 54d6b5b67fb3106eaf560261920df682eafa860f URL: https://github.com/llvm/llvm-project/commit/54d6b5b67fb3106eaf560261920df682eafa860f DIFF: https://github.com/llvm/llvm-project/commit/54d6b5b67fb3106eaf560261920df682eafa860f.diff LO

[PATCH] D121076: [MLIR][Python] Add SCFIfOp Python binding

chhzh123 updated this revision to Diff 413518. chhzh123 added a comment. Herald added subscribers: cfe-commits, llvm-commits, libc-commits, libcxx-commits, pcwang-thead, awarzynski, arjunp, luke957, abrachet, Groverkss, ormris, foad, mravishankar, frasercrmck, dexonsmith, ecnelises, ThomasRaoux,

[PATCH] D121076: [MLIR][Python] Add SCFIfOp Python binding

chhzh123 added a comment. Oh seems I made a wrong merge from the master branch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121076/new/ https://reviews.llvm.org/D121076 ___ cfe-commits mailing list cfe

[PATCH] D117522: [clang-tidy] Add modernize-macro-to-enum check

LegalizeAdulthood added a comment. Herald added a project: All. Ping. Another week waiting for reviews... CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117522/new/ https://reviews.llvm.org/D117522 ___ cfe-commits mailing list cfe-commits@lis

[PATCH] D120984: [clang][dataflow] Extend flow conditions from block terminators

xazax.hun accepted this revision. xazax.hun added a comment. Thanks, with the new comments it is much clearer what is going on! Comment at: clang/lib/Analysis/FlowSensitive/TypeErasedDataflowAnalysis.cpp:90 + void VisitBinaryOperator(const BinaryOperator *S) { +auto *LHS =

[PATCH] D121076: [MLIR][Python] Add SCFIfOp Python binding

chhzh123 updated this revision to Diff 413520. chhzh123 added a comment. Revert Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121076/new/ https://reviews.llvm.org/D121076 Files: mlir/python/mlir/dialects/_scf_ops_ext.py Index: mlir/python/mlir

[PATCH] D121132: [clang-format] Handle C# 9 `init` accessor specifier.

curdeius created this revision. curdeius added reviewers: MyDeveloperDay, HazardyKnusperkeks, owenpan. Herald added a project: All. curdeius requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Before, the code: int Value { get; } = 0; int

[PATCH] D120989: Support debug info for alias variable

dblaikie added a comment. In D120989#3362912 , @kavitha-natarajan wrote: > In D120989#3362491 , @dblaikie > wrote: > >> In D120989#3362490 , @dblaikie >> wrote: >> >>>

[PATCH] D120984: [clang][dataflow] Extend flow conditions from block terminators

sgatev updated this revision to Diff 413523. sgatev marked an inline comment as done. sgatev added a comment. Address reviewers' comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120984/new/ https://reviews.llvm.org/D120984 Files: clang/in

[PATCH] D120989: Support debug info for alias variable

dblaikie added subscribers: JDevlieghere, aprantl. dblaikie added a comment. Maybe APple folks would want to move forward with this only when targeting lldb, though - which might unblock this patch. @aprantl @JDevlieghere ? What do you folks think? Repository: rG LLVM Github Monorepo CHANGE

[PATCH] D120984: [clang][dataflow] Extend flow conditions from block terminators

sgatev added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/TypeErasedDataflowAnalysis.cpp:90 + void VisitBinaryOperator(const BinaryOperator *S) { +auto *LHS = S->getLHS()->IgnoreParenImpCasts(); +assert(LHS != nullptr); xazax.hun wrote:

[PATCH] D121132: [clang-format] Handle C# 9 `init` accessor specifier.

curdeius updated this revision to Diff 413525. curdeius added a comment. Rename. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121132/new/ https://reviews.llvm.org/D121132 Files: clang/lib/Format/FormatToken.h clang/lib/Format/UnwrappedLinePar

[PATCH] D119172: [pseudo] Implement LRGraph

alextsao1999 added inline comments. Comment at: clang/include/clang/Tooling/Syntax/Pseudo/LRGraph.h:96 + uint8_t DotPos = 0; + uint8_t RuleLength = 0; // the length of rule body. +}; sammccall wrote: > alextsao1999 wrote: > > hokein wrote: > > > alextsao1999 wr

  1   2   3   >