[PATCH] D118879: [clang-format] Avoid merging macro definitions.

curdeius updated this revision to Diff 405539. curdeius added a comment. Force CI after changing parent revision. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118879/new/ https://reviews.llvm.org/D118879 Files: clang/lib/Format/UnwrappedLineFor

[PATCH] D118104: Make run-clang-tidy.py print the configured checks correctly

JesApp added a comment. Well, since this was more of source of confusion than actual incorrect behaviour, I don't think there should be a test for it. In general though, I think the script is complex enough to warrant some testing. That being said: I don't think they should be part of this patc

[clang] bb1b53d - [clang-format] Remove unnecessary non-null check and assert instead. NFC.

Author: Marek Kurdej Date: 2022-02-03T09:50:36+01:00 New Revision: bb1b53da6eeb90d3c101719f569abce1d689a959 URL: https://github.com/llvm/llvm-project/commit/bb1b53da6eeb90d3c101719f569abce1d689a959 DIFF: https://github.com/llvm/llvm-project/commit/bb1b53da6eeb90d3c101719f569abce1d689a959.diff

[clang] 7cc3e02 - [clang-format] Use back() instead of rbegin(). NFC.

Author: Marek Kurdej Date: 2022-02-03T10:07:02+01:00 New Revision: 7cc3e0204210a8c9c12f29fddbfec9dfe786e931 URL: https://github.com/llvm/llvm-project/commit/7cc3e0204210a8c9c12f29fddbfec9dfe786e931 DIFF: https://github.com/llvm/llvm-project/commit/7cc3e0204210a8c9c12f29fddbfec9dfe786e931.diff

[clang] 564f9be - Remove -Wweak-template-vtables

Author: Hans Wennborg Date: 2022-02-03T10:15:16+01:00 New Revision: 564f9be11c9cb8d131f48df07538fab7a19b41a7 URL: https://github.com/llvm/llvm-project/commit/564f9be11c9cb8d131f48df07538fab7a19b41a7 DIFF: https://github.com/llvm/llvm-project/commit/564f9be11c9cb8d131f48df07538fab7a19b41a7.diff

[PATCH] D118762: Remove -Wweak-template-vtables

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG564f9be11c9c: Remove -Wweak-template-vtables (authored by hans). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[PATCH] D118880: [analyzer] Improve NoOwnershipChangeVisitor's understanding of deallocators

Szelethus created this revision. Szelethus added reviewers: NoQ, steakhal, martong, balazske, ASDenysPetrov. Szelethus added a project: clang. Herald added subscribers: manas, gamesh411, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun, yaxunl. Szele

[PATCH] D118428: [clang-cl] Support the /JMC flag

hans added a comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118428/new/ https://reviews.llvm.org/D118428 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/ma

[clang] 768a619 - [clang-format] Reserve vectors when the number of items is known beforehand. NFC.

Author: Marek Kurdej Date: 2022-02-03T10:38:23+01:00 New Revision: 768a6192dfc680c0c941e713c824b9046429538d URL: https://github.com/llvm/llvm-project/commit/768a6192dfc680c0c941e713c824b9046429538d DIFF: https://github.com/llvm/llvm-project/commit/768a6192dfc680c0c941e713c824b9046429538d.diff

[PATCH] D118428: [clang-cl] Support the /JMC flag

hans added a comment. It seems Phabricator ate my comment, but I meant to say: My understanding is still that IR passes generally live in Transforms/ and that CodeGen/ deals with lower levels such as MachineInstrs, SelectionDAG, etc. with CodegenPrepare as the big exception. Thinking about it

[PATCH] D118873: [clang-format] Revert a feature in RemoveBracesLLVM

curdeius accepted this revision. curdeius added a comment. Ok, so now (until a new fix), it will always remove the braces for a single statement even if it's multi-line. That's fine. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118873/new/ https:

[PATCH] D114790: [syntax][pseudo] Add grammar facilities for the pseudo-parser

hokein updated this revision to Diff 405550. hokein marked 12 inline comments as done. hokein added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114790/new/ https://reviews.llvm.org/D114790 Files: clang/include/clang

[PATCH] D114790: [syntax][pseudo] Add grammar facilities for the pseudo-parser

hokein added inline comments. Comment at: clang/include/clang/Tooling/Syntax/Pseudo/Grammar.h:85 + static constexpr unsigned SizeBits = 4; + static_assert(SizeBits + SymbolBits <= 16, +"Must be able to store symbol ID + size efficiently"); sammc

[PATCH] D118792: [lld][clang][cmake] Clean up a few things

nikic accepted this revision. nikic added a comment. This revision is now accepted and ready to land. Not very familiar with cmake, but this looks reasonable to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118792/new/ https://reviews.llvm.org/

[clang] d15e7dd - [clang][Hexagon] Match -lc option more specifically in toolchain test

Author: David Spickett Date: 2022-02-03T10:08:20Z New Revision: d15e7dd1238df20e9c09cc91930f716e0d3d5b05 URL: https://github.com/llvm/llvm-project/commit/d15e7dd1238df20e9c09cc91930f716e0d3d5b05 DIFF: https://github.com/llvm/llvm-project/commit/d15e7dd1238df20e9c09cc91930f716e0d3d5b05.diff LOG

[PATCH] D114790: [syntax][pseudo] Add grammar facilities for the pseudo-parser

sammccall accepted this revision. sammccall added inline comments. Comment at: clang/include/clang/Tooling/Syntax/Pseudo/Grammar.h:85 + static constexpr unsigned SizeBits = 4; + static_assert(SizeBits + SymbolBits <= 16, +"Must be able to store symbol ID + size

[PATCH] D118700: Add support to --gcc-toolchain flag for GCC compiled with --enable-version-specific-runtime-libs.

rpenacob added a comment. That is an interesting case. It looks like we're hitting https://gcc.gnu.org/bugzilla/show_bug.cgi?id=32415 , so gcc doesn't seem to search for its own libgcc_s.so when configured with --enable-version-specific-runtime-libs Most users don't notice this issue because a

[clang] 20e05b9 - [syntax][pseudo] Add Grammar for the clang pseudo-parser

Author: Haojian Wu Date: 2022-02-03T11:28:27+01:00 New Revision: 20e05b9f0ebea35076b96c89257becd35d6de859 URL: https://github.com/llvm/llvm-project/commit/20e05b9f0ebea35076b96c89257becd35d6de859 DIFF: https://github.com/llvm/llvm-project/commit/20e05b9f0ebea35076b96c89257becd35d6de859.diff LO

[PATCH] D114790: [syntax][pseudo] Add grammar facilities for the pseudo-parser

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG20e05b9f0ebe: [syntax][pseudo] Add Grammar for the clang pseudo-parser (authored by hokein). Changed prior to commit: https://reviews.llvm.org/D11

[PATCH] D118873: [clang-format] Revert a feature in RemoveBracesLLVM

owenpan added a comment. In D118873#3292956 , @curdeius wrote: > Ok, so now (until a new fix), it will always remove the braces for a single > statement even if it's multi-line. That's fine. Yep. Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[PATCH] D118882: [clangd] IncludeCleaner: Decrease API dependency on clangd

kbobyrev created this revision. kbobyrev added a reviewer: sammccall. Herald added subscribers: usaxena95, kadircet, arphaman. kbobyrev requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Repository: rG LLVM

[clang] eaef54f - [clang-format] Revert a feature in RemoveBracesLLVM

Author: Owen Pan Date: 2022-02-03T02:56:09-08:00 New Revision: eaef54f21388350ca72d4dadf33728f70566e531 URL: https://github.com/llvm/llvm-project/commit/eaef54f21388350ca72d4dadf33728f70566e531 DIFF: https://github.com/llvm/llvm-project/commit/eaef54f21388350ca72d4dadf33728f70566e531.diff LOG:

[PATCH] D118873: [clang-format] Revert a feature in RemoveBracesLLVM

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGeaef54f21388: [clang-format] Revert a feature in RemoveBracesLLVM (authored by owenpan). Changed prior to commit: https://reviews.llvm.org/D118873

[PATCH] D118882: [clangd] IncludeCleaner: Decrease API dependency on clangd

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/IncludeCleaner.h:55 +ASTContext &Ctx, Preprocessor &PP, +

[clang] d97a4df - [OpenCL] Move most _explicit atomics into multiclass; NFC

Author: Sven van Haastregt Date: 2022-02-03T11:09:41Z New Revision: d97a4dfea6c2781494f6fe54ce265128f5c08dc2 URL: https://github.com/llvm/llvm-project/commit/d97a4dfea6c2781494f6fe54ce265128f5c08dc2 DIFF: https://github.com/llvm/llvm-project/commit/d97a4dfea6c2781494f6fe54ce265128f5c08dc2.diff

[PATCH] D118196: [syntax][pseudo] Implement LR parsing table.

sammccall added a comment. OK, a bunch of random notes but I'm getting a higher level picture. I'm not sure about the split between LRAutomaton and LRTable. I suppose doing it in two stages simplifies the implementation, but I don't think the first stage particularly needs to be public. Also I

[PATCH] D118608: [NFC] Increase initial size of FoldingSets used in ASTContext and CodeGenTypes

yurai007 added a comment. In D118608#3290086 , @serge-sans-paille wrote: > Thanks, that's helpful. Any hint about why this particular values? Sure, let me elaborate on this. Initial capacities were empirically chosen to reduce number of internal hashta

[PATCH] D118700: Add support to --gcc-toolchain flag for GCC compiled with --enable-version-specific-runtime-libs.

rpenacob updated this revision to Diff 405567. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118700/new/ https://reviews.llvm.org/D118700 Files: clang/lib/Driver/ToolChains/Gnu.cpp clang/test/Driver/Inputs/gcc_version_parsing_rt_libs/lib/gcc/x86_64-redhat-linux/10.2.0/crtbegin.o

[PATCH] D118887: [OpenMP][Clang] Allow ancestor device modifier only with reverse offloading

saiislam created this revision. saiislam added reviewers: ABataev, jdoerfert, JonChesterfield. Herald added subscribers: guansong, yaxunl. saiislam requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. OpenMP Spec 5.0 [2.12.5, Restrictio

[clang-tools-extra] c39969e - [clangd] NFC, remove an unused local varaiable.

Author: Haojian Wu Date: 2022-02-03T12:52:24+01:00 New Revision: c39969ef252e7b285a9ef87e9a14d701acdced7b URL: https://github.com/llvm/llvm-project/commit/c39969ef252e7b285a9ef87e9a14d701acdced7b DIFF: https://github.com/llvm/llvm-project/commit/c39969ef252e7b285a9ef87e9a14d701acdced7b.diff LO

[clang-tools-extra] 2f8da95 - [clangd][nfc] cleanup of remaining clang-tidy findings

Author: Christian Kühnel Date: 2022-02-03T12:05:25Z New Revision: 2f8da95e070e0f6b8c3d3310de51b016176e840a URL: https://github.com/llvm/llvm-project/commit/2f8da95e070e0f6b8c3d3310de51b016176e840a DIFF: https://github.com/llvm/llvm-project/commit/2f8da95e070e0f6b8c3d3310de51b016176e840a.diff L

[PATCH] D118698: [clangd][nfc] cleanup of remaining clang-tidy findings

This revision was automatically updated to reflect the committed changes. Closed by commit rG2f8da95e070e: [clangd][nfc] cleanup of remaining clang-tidy findings (authored by kuhnel). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118698/new/ https:/

[clang] 9694332 - [clang-format] Add missing newline in -style help

Author: Sven van Haastregt Date: 2022-02-03T12:12:29Z New Revision: 9694332b81dd14a0a2ab5d9ea9977558fd5f53be URL: https://github.com/llvm/llvm-project/commit/9694332b81dd14a0a2ab5d9ea9977558fd5f53be DIFF: https://github.com/llvm/llvm-project/commit/9694332b81dd14a0a2ab5d9ea9977558fd5f53be.diff

[PATCH] D118879: [clang-format] Avoid merging macro definitions.

owenpan accepted this revision. owenpan added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:1812 + Style.BraceWrapping.AfterFunction = true; + // Test that a macro definition gets never merged with the following + // definition. ===

[PATCH] D118887: [OpenMP][Clang] Allow ancestor device modifier only with reverse offloading

ABataev added inline comments. Comment at: clang/test/OpenMP/target_device_codegen.cpp:43-47 - // CHECK-NOT: call i32 @__tgt_target_mapper(%struct.ident_t* @{{.+}}, - // CHECK: call void @__omp_offloading_{{.+}}_l46() - // CHECK-NOT: call i32 @__tgt_target_mapper(%st

[PATCH] D118520: [clang-tidy] Output currently processing check and nodes on crash

njames93 updated this revision to Diff 405581. njames93 added a comment. Herald added a subscriber: mgorny. Add testing infrastructure to verify stack trace output Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118520/new/ https://reviews.llvm.org/D

[PATCH] D118890: [clang][deps] Disable global module index

jansvoboda11 created this revision. Herald added a subscriber: arphaman. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. While scanning dependencies of a TU that depends on a PCH, the scanner basically performs mixed implicit/

[PATCH] D118520: [clang-tidy] Output currently processing check and nodes on crash

njames93 added inline comments. Comment at: clang-tools-extra/test/CMakeLists.txt:100 + + llvm_add_library( + CTCrashTestTrace Fairly certain llvm_add_library isnt the correct function to use as that will put the test module in the build/lib directory. How

[PATCH] D118044: [ARM] Undeprecate complex IT blocks

MarkMurrayARM marked 3 inline comments as done. MarkMurrayARM added inline comments. Comment at: llvm/test/CodeGen/ARM/ifcvt-branch-weight.ll:22 +; CHECK: bb.1.bb2: +; CHECK: successors: %bb.2(0x4000) dmgreen wrote: > I'm not sure this is still checking any

[PATCH] D117306: [clang-tidy] Add new check 'shared-ptr-array-mismatch'.

njames93 added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/SmartPtrArrayMismatchCheck.cpp:41-47 + const Decl *ParentDecl = ConstructParents.begin()->get(); + if (!ParentDecl) +return nullptr; + if (const auto *ParentVar = dyn_cast(ParentDecl)) +

[PATCH] D118887: [OpenMP][Clang] Allow ancestor device modifier only with reverse offloading

saiislam added inline comments. Comment at: clang/test/OpenMP/target_device_codegen.cpp:43-47 - // CHECK-NOT: call i32 @__tgt_target_mapper(%struct.ident_t* @{{.+}}, - // CHECK: call void @__omp_offloading_{{.+}}_l46() - // CHECK-NOT: call i32 @__tgt_target_mapper(%s

[PATCH] D118887: [OpenMP][Clang] Allow ancestor device modifier only with reverse offloading

ABataev added inline comments. Comment at: clang/test/OpenMP/target_device_codegen.cpp:43-47 - // CHECK-NOT: call i32 @__tgt_target_mapper(%struct.ident_t* @{{.+}}, - // CHECK: call void @__omp_offloading_{{.+}}_l46() - // CHECK-NOT: call i32 @__tgt_target_mapper(%st

[PATCH] D118887: [OpenMP][Clang] Allow ancestor device modifier only with reverse offloading

saiislam updated this revision to Diff 405591. saiislam marked an inline comment as done. saiislam added a comment. Restored device ancestor codegen unit test with requires reverese_offload. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118887/new/

[PATCH] D118887: [OpenMP][Clang] Allow ancestor device modifier only with reverse offloading

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118887/new/ https://reviews.llvm.org/D118887 ___

[PATCH] D118882: [clangd] IncludeCleaner: Decrease API dependency on clangd

kbobyrev updated this revision to Diff 405598. kbobyrev marked 3 inline comments as done. kbobyrev added a comment. Resolve review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118882/new/ https://reviews.llvm.org/D118882 Files: clang-

[clang-tools-extra] 089d9c5 - [clangd] IncludeCleaner: Decrease API dependency on clangd

Author: Kirill Bobyrev Date: 2022-02-03T14:40:53+01:00 New Revision: 089d9c50b29e8e0eb18884edf17451e11a84a80f URL: https://github.com/llvm/llvm-project/commit/089d9c50b29e8e0eb18884edf17451e11a84a80f DIFF: https://github.com/llvm/llvm-project/commit/089d9c50b29e8e0eb18884edf17451e11a84a80f.diff

[PATCH] D118882: [clangd] IncludeCleaner: Decrease API dependency on clangd

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG089d9c50b29e: [clangd] IncludeCleaner: Decrease API dependency on clangd (authored by kbobyrev). Repository: rG LLVM Github Monorepo CHANGES SINC

[PATCH] D112774: [RISCV] Support k-ext clang intrinsics

achieveartificialintelligence updated this revision to Diff 405605. achieveartificialintelligence added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112774/new/ https://reviews.llvm.org/D112774 Files: clang/include/clang/Basic

[PATCH] D78491: Avoid relying on address space zero default parameter in llvm/IR

carlos4242 added a comment. Herald added a subscriber: dexonsmith. Can I just add a +1 on something like this. My swift compiler build just broke at runtime because of this. Would it be possible to change the default so it reads the address space from the target data layout so it's all automati

[PATCH] D114439: [Annotation] Allow parameter pack expansions and initializer lists in annotate attribute

aaron.ballman added a comment. I think this is heading in the right direction! I've got a few more comments and questions though. Comment at: clang/include/clang/Basic/Attr.td:545 + // Set to true if this attribute accepts parameter pack expansion expressions. + bit Accepts

[PATCH] D114439: [Annotation] Allow parameter pack expansions and initializer lists in annotate attribute

erichkeane added inline comments. Comment at: clang/lib/Sema/SemaDeclAttr.cpp:4203 + if (AllArgs.size() && AllArgs[0]->isValueDependent()) { +auto *Attr = AnnotateAttr::CreateWithDelayedArgs( +S.getASTContext(), AllArgs.data(), AllArgs.size(), AL); a

[clang] 6f2c956 - [clang][docs] Regenerate ASTMatchers documentation

Author: Nathan James Date: 2022-02-03T14:11:30Z New Revision: 6f2c95657b083063039065cc9729d0a428e44140 URL: https://github.com/llvm/llvm-project/commit/6f2c95657b083063039065cc9729d0a428e44140 DIFF: https://github.com/llvm/llvm-project/commit/6f2c95657b083063039065cc9729d0a428e44140.diff LOG:

[PATCH] D114439: [Annotation] Allow parameter pack expansions and initializer lists in annotate attribute

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaDeclAttr.cpp:4203 + if (AllArgs.size() && AllArgs[0]->isValueDependent()) { +auto *Attr = AnnotateAttr::CreateWithDelayedArgs( +S.getASTContext(), AllArgs.data(), AllArgs.size(), AL); ---

[PATCH] D118900: [ASTMatchers] Expand isInline matcher to VarDecl

njames93 created this revision. njames93 added reviewers: klimek, aaron.ballman. njames93 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Add support to the `isInline` matcher for C++17's inline variables. Repository: rG LLVM Github Mon

[PATCH] D117929: [XRay] Add support for RISCV

ashwin98 updated this revision to Diff 405621. ashwin98 added a comment. Removed extra triples from the test. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117929/new/ https://reviews.llvm.org/D117929 Files: clang/lib/Driver/XRayArgs.cpp compiler-rt/cmake/Modules/AllSupportedArchDe

[PATCH] D118876: [HIPSPV] Fix literals are mapped to Generic address space

yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. LGTM. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118876/new/ https://reviews.llvm.org/D118876 __

[PATCH] D118904: [clang][CodeGen] Use memory type representation in `va_arg`

jansvoboda11 created this revision. jansvoboda11 added a reviewer: t.p.northover. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Some types (e.g. `_Bool`) have different scalar and memory representations. CodeGen for `va_arg`

[PATCH] D118904: [clang][CodeGen] Use memory type representation in `va_arg`

jansvoboda11 added a comment. Should we add tests for other targets besides arm64? Comment at: clang/test/CodeGen/arm64-arguments.c:203 + __builtin_va_start(ap, i); + // TODO: Add proper checks here. + _Bool b = __builtin_va_arg(ap, _Bool); Not sure what to

[PATCH] D118520: [clang-tidy] Output currently processing check and nodes on crash

njames93 updated this revision to Diff 405636. njames93 edited the summary of this revision. njames93 added a comment. Ignore the CTCrashTestTrace implementation file in the lit tests, Fixes 'Test has no 'RUN'' error. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://re

[PATCH] D117391: [AST] Ignore implicit nodes in CastExpr::getConversionFunction

kimgr added inline comments. Comment at: clang/lib/AST/Expr.cpp:1949-1950 if (E->getCastKind() == CK_ConstructorConversion) return cast(SubExpr)->getConstructor(); kimgr wrote: > davrec wrote: > > I think the errors prove we should fall back to th

[PATCH] D118196: [syntax][pseudo] Implement LR parsing table.

sammccall added a comment. OK, I think I understand it now! Sorry for so many comments, happy to chat offline about which ones to address/where to start. Comment at: clang/include/clang/Tooling/Syntax/Pseudo/LRTable.h:39 +public: + struct Action { +enum class Kind : uint8

[clang] b5787a0 - [clang][driver][wasm] Support -stdlib=libstdc++ for WebAssembly

Author: Timm Bäder Date: 2022-02-03T16:37:52+01:00 New Revision: b5787a0c6cc4da47b7d7b218e23f780076ad2f5f URL: https://github.com/llvm/llvm-project/commit/b5787a0c6cc4da47b7d7b218e23f780076ad2f5f DIFF: https://github.com/llvm/llvm-project/commit/b5787a0c6cc4da47b7d7b218e23f780076ad2f5f.diff LO

[PATCH] D117888: [clang][driver][wasm] Support -stdlib=libstdc++ for WebAssembly

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb5787a0c6cc4: [clang][driver][wasm] Support -stdlib=libstdc++ for WebAssembly (authored by tbaeder). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D114790: [syntax][pseudo] Add grammar facilities for the pseudo-parser

thakis added a comment. Is there any background information anywhere what this pseudo parser is? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114790/new/ https://reviews.llvm.org/D114790 ___ cfe-commits

[PATCH] D114790: [syntax][pseudo] Add grammar facilities for the pseudo-parser

thakis added inline comments. Comment at: clang/lib/Tooling/Syntax/Pseudo/CMakeLists.txt:3 + +add_clang_library(clangSyntaxPseudo + Grammar.cpp (i think the usual name would be "clangToolingSyntaxPseudo") Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[PATCH] D118904: [clang][CodeGen] Use memory type representation in `va_arg`

jansvoboda11 updated this revision to Diff 405644. jansvoboda11 added a comment. Add proper check Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118904/new/ https://reviews.llvm.org/D118904 Files: clang/lib/CodeGen/TargetInfo.cpp clang/test/Cod

[clang] 2dd35e9 - [clang][driver][wasm] Remove unneeded default labels

Author: Timm Bäder Date: 2022-02-03T16:52:41+01:00 New Revision: 2dd35e98d3ffa1327df8261077958b47b2bdbb15 URL: https://github.com/llvm/llvm-project/commit/2dd35e98d3ffa1327df8261077958b47b2bdbb15 DIFF: https://github.com/llvm/llvm-project/commit/2dd35e98d3ffa1327df8261077958b47b2bdbb15.diff LO

[PATCH] D114790: [syntax][pseudo] Add grammar facilities for the pseudo-parser

sammccall added a comment. In D114790#3293764 , @thakis wrote: > Is there any background information anywhere what this pseudo parser is? Design doc: https://docs.google.com/document/d/1eGkTOsFja63wsv8v0vd5JdoTonj-NlN3ujGF0T7xDbM/edit RFC: https://disco

[PATCH] D114790: [syntax][pseudo] Add grammar facilities for the pseudo-parser

thakis added inline comments. Comment at: clang/unittests/Tooling/Syntax/Pseudo/CMakeLists.txt:6 +add_clang_unittest(ClangPseudoTests + GrammarTests.cpp +) ``` thakis@thakis:~/src/llvm-project$ ls clang/unittests/**/*Test.cpp | wc -l 127 thakis@thakis:~/src/llvm

[PATCH] D114790: [syntax][pseudo] Add grammar facilities for the pseudo-parser

thakis added a comment. In D114790#3293777 , @sammccall wrote: > In D114790#3293764 , @thakis wrote: > >> Is there any background information anywhere what this pseudo parser is? > > Design doc: > https://docs.go

[PATCH] D116637: [Clang][Sema][OpenMP] Sema support for `atomic compare`

tianshilei1992 updated this revision to Diff 405645. tianshilei1992 added a comment. Fix template instantiation and add one test. More tests are on the way. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116637/new/ https://reviews.llvm.org/D116637

[PATCH] D114790: [syntax][pseudo] Add grammar facilities for the pseudo-parser

sammccall added a comment. In D114790#3293783 , @thakis wrote: > In D114790#3293777 , @sammccall > wrote: > >> In D114790#3293764 , @thakis wrote: >> >>> Is there any bac

[PATCH] D118911: [clang-format] regression from clang-format v13

MyDeveloperDay created this revision. MyDeveloperDay added reviewers: curdeius, HazardyKnusperkeks, owenpan. MyDeveloperDay added projects: clang, clang-format. MyDeveloperDay requested review of this revision. https://github.com/llvm/llvm-project/issues/53567 The following source namespace A

[PATCH] D117888: [clang][driver][wasm] Support -stdlib=libstdc++ for WebAssembly

tbaeder added a comment. In D117888#3290628 , @sbc100 wrote: > Great! Thanks for working on this.I'm curious what toolchain you are > working that uses GNU libstdc++? I'm looking at libstdc++ enablement in a wasm/emscripten toolchain, so nothing

[PATCH] D118815: [Clang][Docs] Add documention for new OpenMP offloading driver

jhuber6 updated this revision to Diff 405654. jhuber6 added a comment. Some additions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118815/new/ https://reviews.llvm.org/D118815 Files: clang/docs/ClangCommandLineReference.rst clang/docs/ClangL

[PATCH] D118815: [Clang][Docs] Add documention for new OpenMP offloading driver

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG with nits Comment at: clang/docs/OffloadingDesign.rst:25 +Clang supports OpenMP target offloading to several different architectures such +as NVPTX, AMDGPU, X86_64. ARM,

[PATCH] D118913: [clang-tidy] Fix LLVM include order check policy

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: carlosgalvezp, xazax.hun. kadircet requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Clang-format LLVM style has a custom include cate

[PATCH] D118913: [clang-tidy] Fix LLVM include order check policy

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Thank you! Seems strange to me that we have both forms of test here, but I'm sure there's a reason... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[clang-tools-extra] 0447ec2 - [clang-tidy] Fix LLVM include order check policy

Author: Kadir Cetinkaya Date: 2022-02-03T17:32:43+01:00 New Revision: 0447ec2fb050eb37ed1f5991a1562dea6e228f9e URL: https://github.com/llvm/llvm-project/commit/0447ec2fb050eb37ed1f5991a1562dea6e228f9e DIFF: https://github.com/llvm/llvm-project/commit/0447ec2fb050eb37ed1f5991a1562dea6e228f9e.dif

[PATCH] D118913: [clang-tidy] Fix LLVM include order check policy

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0447ec2fb050: [clang-tidy] Fix LLVM include order check policy (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACT

[PATCH] D118911: [clang-format] regression from clang-format v13

curdeius accepted this revision. curdeius added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:3084 +if (!Previous || (Previous->isNot(tok::r_paren) && + !Previous->isTypeOrId

[PATCH] D118915: [clang][deps] Generate '-fmodule-file=' only for direct dependencies

jansvoboda11 created this revision. jansvoboda11 added a reviewer: Bigcheese. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The `clang-scan-deps` tool currently generates `-fmodule-file=` command-line arguments for the whole

[PATCH] D118890: [clang][deps] Disable global module index

jansvoboda11 added a comment. I'd like to add a test case, but actually creating a minimal one is proving to be difficult. This is most likely caused by the interaction between the global module index and explicit+implicit modules. Since we want to move off of the implicit build in dependency s

[PATCH] D103395: PR45879: Keep evaluated expression in LValue object

sepavloff abandoned this revision. sepavloff added a comment. @rsmith, thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103395/new/ https://reviews.llvm.org/D103395 ___ cfe-commits mailing list c

[PATCH] D115523: [OpenCL] Set external linkage for block enqueue kernels

Anastasia added a comment. In D115523#3284446 , @yaxunl wrote: > In D115523#3266584 , @Anastasia > wrote: > >> In D115523#3240870 , @yaxunl wrote: >> >>> In D115523#32378

[PATCH] D110869: [X86] Implement -fzero-call-used-regs option

nathanchance added a comment. The latest revision allows me to boot a kernel in QEMU now but that same kernel does not boot on bare metal. I'll see if I can narrow down the problematic translation unit with Nick's `subdir-ccflags-y` trick. Repository: rG LLVM Github Monorepo CHANGES SINCE L

[PATCH] D112774: [RISCV] Support k-ext clang intrinsics

craig.topper added inline comments. Comment at: clang/include/clang/Basic/BuiltinsRISCV.def:74 +// zbkb extension +TARGET_BUILTIN(__builtin_riscv_brev8, "ZiZi", "nc", "zbkb") Capital Z Comment at: clang/lib/Basic/Targets/RISCV.cpp:198 +

[PATCH] D118921: [Format] Don't derive pointers right based on space before method ref-qualifiers

sammccall created this revision. sammccall added a reviewer: benhamilton. sammccall requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The second space in `void foo() &` is always produced by clang-format, and isn't evidence of any particular

[PATCH] D118921: [Format] Don't derive pointers right based on space before method ref-qualifiers

sammccall updated this revision to Diff 405682. sammccall added a comment. clean up formatting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118921/new/ https://reviews.llvm.org/D118921 Files: clang/lib/Format/Format.cpp clang/unittests/Format

[PATCH] D118922: [ASTMatchers] The `isInline` matcher now accepts inline variables

Izaron created this revision. Izaron added reviewers: klimek, aaron.ballman. Izaron requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Inline variables is a feature from C++17. It makes sense to extend the `isInline` matcher in order to suppor

[PATCH] D118922: [ASTMatchers] The `isInline` matcher now accepts inline variables

Izaron added a comment. I am planning to reuse this matcher in my new checker (https://reviews.llvm.org/D118743, under development now), removing this line: AST_MATCHER(VarDecl, isVarInline) { return Node.isInline(); } //P.S. If this review is eventually approved, kindly please merge the comm

[PATCH] D118804: Revert "[Clang] Propagate guaranteed alignment for malloc and others"

xbolva00 requested changes to this revision. xbolva00 added inline comments. This revision now requires changes to proceed. Comment at: clang/test/CodeGen/alloc-fns-alignment.c:37 - -void *aligned_alloc_large_constant_test(size_t n) { - return aligned_alloc(4096, n); ---

[PATCH] D113359: [Libomptarget][WIP] Introduce VGPU Plugin

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LG, with some things to address before the merge though. Didn't we have a pass to expand shared memory (and such)? Comment at: clang/lib/Basic/TargetInfo.cpp:155 + +

[PATCH] D118922: [ASTMatchers] The `isInline` matcher now accepts inline variables

Izaron added inline comments. Comment at: clang/unittests/ASTMatchers/ASTMatchersInternalTest.cpp:195-201 -TEST(IsInlineMatcher, IsInline) { - EXPECT_TRUE(matches("void g(); inline void f();", - functionDecl(isInline(), hasName("f"; - EXPECT_TRUE(matche

[PATCH] D118921: [Format] Don't derive pointers right based on space before method ref-qualifiers

benhamilton requested changes to this revision. benhamilton added inline comments. This revision now requires changes to proceed. Comment at: clang/lib/Format/Format.cpp:1949 continue; +// Don't treat space in `void foo() &&` as evidence. +if (const aut

[PATCH] D113359: [Libomptarget][WIP] Introduce VGPU Plugin

tianshilei1992 added a comment. Not sure if it's good to merge such a large patch. We could potentially split the patch to three independent patches: tool chain, device runtime, and the OpenMPOpt pass to support expansion of shared variable (which for some reason is not included in this patch.

[PATCH] D113359: [Libomptarget][WIP] Introduce VGPU Plugin

jdoerfert added a comment. We can merge runtime first, build it in isolation, then libomptarget host runtime, then clang. Also make sure to adjust the commit messages Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113359/new/ https://reviews.llvm.

[PATCH] D117924: [compiler_rt] Add a seperate runtime for Mac Catalyst

tschuett added a comment. https://reviews.llvm.org/D118862 https://reviews.llvm.org/D118875 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117924/new/ https://reviews.llvm.org/D117924 ___ cfe-commits mail

[clang] 529aa4b - [clang-format] Avoid adding space after the name of a function-like macro when the name is a keyword.

Author: Marek Kurdej Date: 2022-02-03T18:45:51+01:00 New Revision: 529aa4b011c4ae808d658022ef643c44dd9b2c9c URL: https://github.com/llvm/llvm-project/commit/529aa4b011c4ae808d658022ef643c44dd9b2c9c DIFF: https://github.com/llvm/llvm-project/commit/529aa4b011c4ae808d658022ef643c44dd9b2c9c.diff

[PATCH] D118844: [clang-format] Avoid adding space after the name of a function-like macro when the name is a keyword.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG529aa4b011c4: [clang-format] Avoid adding space after the name of a function-like macro when… (authored by curdeius). Repository: rG LLVM Github M

  1   2   3   >