[PATCH] D110869: [X86] Implement -fzero-call-used-regs option

void updated this revision to Diff 403906. void added a comment. WIP: Modify the zeroing of GPRs to be less gross. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110869/new/ https://reviews.llvm.org/D110869 Files: clang/include/clang/Basic/Attr.t

[PATCH] D118152: [clang][deps] Adapt test to be compatible when the assembler is called by default

jansvoboda11 accepted this revision. jansvoboda11 added a comment. This revision is now accepted and ready to land. Thanks for the explanation and update. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118152/new/ https://reviews.llvm.org/D118

[PATCH] D118104: Make run-clang-tidy.py print the configured checks correctly

carlosgalvezp added a comment. In D118104#3278493 , @JesApp wrote: > Anyone have an idea why it's still building? Very strange, I have no clue :/ CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118104/new/ https://reviews.llvm.org/D118104 _

[PATCH] D116203: [clang] adds unary type transformations as compiler built-ins

lebedev.ri added a comment. The patch's description still only says what is being added, but provides zero motivation as to why it does what it does. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116203/new/ https://reviews.llvm.org/D116203 _

[PATCH] D114639: Raise the minimum Visual Studio version to VS2019

RKSimon updated this revision to Diff 403924. RKSimon added a comment. update lldb cmake command Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114639/new/ https://reviews.llvm.org/D114639 Files: clang/docs/ClangFormatStyleOptions.rst clang/doc

[PATCH] D106674: Runtime for Interop directive

mstorsjo added inline comments. Comment at: openmp/runtime/src/dllexports:553 +omp_get_interop_ptr 761 +omp_get_interop_str 762 jdoerfert wrote: > Those values are taken by now, you need new values that are not ta

[PATCH] D118050: [analyzer] Different address spaces cannot overlap

steakhal added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/SimpleSValBuilder.cpp:718 +static uint64_t getLocBitwidth(ProgramStateRef State, Loc loc) { + uint64_t LocBitwidth = 0; Why don't you simply call `loc->getType()` end delegate the heavy

[PATCH] D106674: Runtime for Interop directive

mstorsjo added inline comments. Comment at: openmp/runtime/src/dllexports:553 +omp_get_interop_ptr 761 +omp_get_interop_str 762 mstorsjo wrote: > jdoerfert wrote: > > Those values are taken by now, you need new va

[PATCH] D115501: [clang][ARM] Emit warnings when PACBTI-M is used with unsupported architectures

amilendra added a comment. The CI errors seem unrelated. Failed Tests (9): libarcher :: races/critical-unrelated.c libarcher :: races/lock-nested-unrelated.c libarcher :: races/lock-unrelated.c libarcher :: races/parallel-simple.c libarcher :: races/task-dependency.c lib

[PATCH] D117898: [Clang] Add elementwise saturated add/sub builtins

fhahn added inline comments. Comment at: clang/test/CodeGen/builtins-elementwise-math.c:117 + // CHECK-NEXT: call <4 x i32> @llvm.usub.sat.v4i32(<4 x i32> [[VU1]], <4 x i32> [[VU2]]) + vu1 = __builtin_elementwise_sub_sat(vu1, vu2); + It might be good to have t

[clang] 1f08b08 - [clang][ARM] Emit warnings when PACBTI-M is used with unsupported architectures

Author: Amilendra Kodithuwakku Date: 2022-01-28T09:59:58Z New Revision: 1f08b0867412d5696ed624a2da78bdba2cc672c3 URL: https://github.com/llvm/llvm-project/commit/1f08b0867412d5696ed624a2da78bdba2cc672c3 DIFF: https://github.com/llvm/llvm-project/commit/1f08b0867412d5696ed624a2da78bdba2cc672c3.d

[PATCH] D115501: [clang][ARM] Emit warnings when PACBTI-M is used with unsupported architectures

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1f08b0867412: [clang][ARM] Emit warnings when PACBTI-M is used with unsupported architectures (authored by amilendra). Repository: rG LLVM Github

[PATCH] D118445: [clang][AVR] Fix a crash in AVRTargetCodeGenInfo::getGlobalVarAddressSpace

benshi001 created this revision. benshi001 added reviewers: aykevl, MaskRay, dylanmckay. Herald added a subscriber: Jim. benshi001 requested review of this revision. Herald added subscribers: cfe-commits, jacquesguan. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://re

[PATCH] D118445: [clang][AVR] Fix a crash in AVRTargetCodeGenInfo::getGlobalVarAddressSpace

benshi001 added a comment. clang crashes when compling some c++ for for AVR targets with `clang++ test.cc --target=avr -mmcu=atmega328 -S`, and the test.cc is volatile char *p = (volatile char *) 0x4000; class test { int v; public: test(int q): v(q) {} int get

[PATCH] D118446: clang-format: [JS] sort import aliases. Users can define aliases for long symbols using import aliases:

mprobst created this revision. mprobst added a reviewer: jankuehle. Herald added a subscriber: jeroen.dobbelaere. mprobst requested review of this revision. Herald added a project: clang. import X = A.B.C; Previously, these were unhandled and would terminate import sorting. With this change, al

[clang] 249a21a - [clang-format] Remove useless npos parameter from substr. NFC.

Author: Marek Kurdej Date: 2022-01-28T11:23:29+01:00 New Revision: 249a21ab188419b019adea21716f5c779c063de3 URL: https://github.com/llvm/llvm-project/commit/249a21ab188419b019adea21716f5c779c063de3 DIFF: https://github.com/llvm/llvm-project/commit/249a21ab188419b019adea21716f5c779c063de3.diff

[PATCH] D106674: Runtime for Interop directive

AndreyChurbanov added inline comments. Comment at: openmp/runtime/src/dllexports:553 +omp_get_interop_ptr 761 +omp_get_interop_str 762 mstorsjo wrote: > mstorsjo wrote: > > jdoerfert wrote: > > > Those values are

[clang] bfd8210 - [OpenCL] opencl-c.h: refactor named addrspace builtins

Author: Sven van Haastregt Date: 2022-01-28T10:24:47Z New Revision: bfd8210f6f470d79a78f57ebe02650bbb5a79129 URL: https://github.com/llvm/llvm-project/commit/bfd8210f6f470d79a78f57ebe02650bbb5a79129 DIFF: https://github.com/llvm/llvm-project/commit/bfd8210f6f470d79a78f57ebe02650bbb5a79129.diff

[PATCH] D118158: [OpenCL] opencl-c.h: refactor named addrspace builtins

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGbfd8210f6f47: [OpenCL] opencl-c.h: refactor named addrspace builtins (authored by svenvh). Changed prior to commit: https://reviews.llvm.org/D1181

[clang] 03c5976 - clang-format: [JS] sort import aliases. Users can define aliases for long symbols using import aliases:

Author: Martin Probst Date: 2022-01-28T11:51:28+01:00 New Revision: 03c59765b3eb2f2233728da8e16637f802147d66 URL: https://github.com/llvm/llvm-project/commit/03c59765b3eb2f2233728da8e16637f802147d66 DIFF: https://github.com/llvm/llvm-project/commit/03c59765b3eb2f2233728da8e16637f802147d66.diff

[PATCH] D118446: clang-format: [JS] sort import aliases. Users can define aliases for long symbols using import aliases:

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG03c59765b3eb: clang-format: [JS] sort import aliases. Users can define aliases for long… (authored by mprobst). Repository: rG LLVM Github Monorep

[clang] f4d5195 - [clang-format] Move irrelevant code from getRangeLength to getRemainingLength. NFC.

Author: Marek Kurdej Date: 2022-01-28T12:01:02+01:00 New Revision: f4d5195d2fff06e2e3daad136f909143324d0485 URL: https://github.com/llvm/llvm-project/commit/f4d5195d2fff06e2e3daad136f909143324d0485 DIFF: https://github.com/llvm/llvm-project/commit/f4d5195d2fff06e2e3daad136f909143324d0485.diff

[PATCH] D118448: clang-format: [JS] fix uninitialized memory.

mprobst created this revision. mprobst added reviewers: jankuehle, krasimir. mprobst requested review of this revision. Herald added a project: clang. SortJavaScriptImports attempts to set its currently parsed token to an invalid token when it reaches the end of the line. However in doing so, it u

[PATCH] D118385: [NFC] Optimize FoldingSet usage where it matters

yurai007 updated this revision to Diff 403951. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118385/new/ https://reviews.llvm.org/D118385 Files: clang/include/clang/AST/ASTContext.h clang/lib/AST/ASTContext.cpp clang/lib/CodeGen/CodeGenTypes.h

[PATCH] D118385: [NFC] Optimize FoldingSet usage where it matters

yurai007 marked 3 inline comments as done. yurai007 added inline comments. Comment at: llvm/include/llvm/ADT/FoldingSet.h:328 /// Add* - Add various data types to Bit data. - void AddPointer(const void *Ptr); - void AddInteger(signed I); - void AddInteger(unsigned I); - vo

[PATCH] D118385: [NFC] Optimize FoldingSet usage where it matters

xbolva00 added inline comments. Comment at: llvm/include/llvm/ADT/FoldingSet.h:328 /// Add* - Add various data types to Bit data. - void AddPointer(const void *Ptr); - void AddInteger(signed I); - void AddInteger(unsigned I); - void AddInteger(long I); - void AddInteger(u

[clang] c267292 - clang-format: [JS] fix uninitialized memory.

Author: Martin Probst Date: 2022-01-28T12:37:45+01:00 New Revision: c26729251588cb6e9e20c3edf67d14ac9b549f9b URL: https://github.com/llvm/llvm-project/commit/c26729251588cb6e9e20c3edf67d14ac9b549f9b DIFF: https://github.com/llvm/llvm-project/commit/c26729251588cb6e9e20c3edf67d14ac9b549f9b.diff

[PATCH] D118448: clang-format: [JS] fix uninitialized memory.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc26729251588: clang-format: [JS] fix uninitialized memory. (authored by mprobst). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D91607: [clang][Sparc] Fix __builtin_extract_return_addr etc.

ro added a comment. Ping. This hasn't been reviewed in more than a year and is still required for D91608 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91607/new/ https://reviews.llvm.org/D91607

[clang] b6d9ca1 - Do not crash when trying to encode a _BitInt type

Author: Aaron Ballman Date: 2022-01-28T08:38:01-05:00 New Revision: b6d9ca14c20f6f982a9fee4bebccf4761400f6aa URL: https://github.com/llvm/llvm-project/commit/b6d9ca14c20f6f982a9fee4bebccf4761400f6aa DIFF: https://github.com/llvm/llvm-project/commit/b6d9ca14c20f6f982a9fee4bebccf4761400f6aa.diff

[PATCH] D118385: [NFC] Optimize FoldingSet usage where it matters

serge-sans-paille added inline comments. Comment at: llvm/include/llvm/ADT/FoldingSet.h:328 /// Add* - Add various data types to Bit data. - void AddPointer(const void *Ptr); - void AddInteger(signed I); - void AddInteger(unsigned I); - void AddInteger(long I); - void Add

[PATCH] D118402: [C2x][ObjC] Do not crash when trying to encode a _BitInt type

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. Thanks for the reviews! I've landed in b6d9ca14c20f6f982a9fee4bebccf4761400f6aa (with the FIXME removed). Se

[PATCH] D117376: Remove reference type when checking const structs

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. Looks good. Thanks for the fix! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117376/new/ https://reviews.llvm.org/D117376

[PATCH] D118104: Make run-clang-tidy.py print the configured checks correctly

aaron.ballman added a comment. In D118104#3278493 , @JesApp wrote: > Anyone have an idea why it's still building? Hmmm, it looks like an infrastructure issue with the CI builder. https://buildkite.com/organizations/llvm-project/pipelines/diff-checks/bui

[PATCH] D118464: [Sema] Add signed/unsigned integer mismatch tests for min/max elementwise builtins

RKSimon created this revision. RKSimon added reviewers: fhahn, scanon, craig.topper, aaron.ballman. RKSimon requested review of this revision. Herald added a project: clang. As suggested on D117898 Repository: rG LLVM Github Monorepo https://reviews.llvm.org

[PATCH] D118464: [Sema] Add signed/unsigned integer mismatch tests for min/max elementwise builtins

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM assuming that CI passes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118464/new/ https://reviews.llvm.org/D118464

[PATCH] D118464: [Sema] Add signed/unsigned integer mismatch tests for min/max elementwise builtins

fhahn added a comment. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118464/new/ https://reviews.llvm.org/D118464 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.

[PATCH] D117929: [XRay] Add support for RISCV

ashwin98 added inline comments. Comment at: compiler-rt/lib/xray/xray_riscv.cpp:122-123 + //lui t2, %highest(__xray_FunctionEntry/Exit) + //slli t2, t2, 32 ;lui sign extends values + //srli t2, t2, 32

[clang] 9d75ee1 - [Sema] Add signed/unsigned integer mismatch tests for min/max elementwise builtins

Author: Simon Pilgrim Date: 2022-01-28T14:31:36Z New Revision: 9d75ee1cd597a762c75e6b680e5af8039850a522 URL: https://github.com/llvm/llvm-project/commit/9d75ee1cd597a762c75e6b680e5af8039850a522 DIFF: https://github.com/llvm/llvm-project/commit/9d75ee1cd597a762c75e6b680e5af8039850a522.diff LOG:

[PATCH] D118464: [Sema] Add signed/unsigned integer mismatch tests for min/max elementwise builtins

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9d75ee1cd597: [Sema] Add signed/unsigned integer mismatch tests for min/max elementwise… (authored by RKSimon). Repository: rG LLVM Github Monorep

[PATCH] D118153: [CUDA][HIP] Do not treat host var address as constant in device compilation

yaxunl marked 4 inline comments as done. yaxunl added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:2227 +!Var->hasAttr() && +!Var->hasAttr() && +!Var->getType()->isCUDADeviceBuiltinSurfaceType() && tra wrote: > D

[PATCH] D118153: [CUDA][HIP] Do not treat host var address as constant in device compilation

yaxunl updated this revision to Diff 404010. yaxunl marked 3 inline comments as done. yaxunl added a comment. Revised by Artem's comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118153/new/ https://reviews.llvm.org/D118153 Files: clang/include/clang/AST/ASTContext.h clang/li

[PATCH] D114439: [Annotation] Allow parameter pack expansions and initializer lists in annotate attribute

erichkeane added a comment. Took a look, it doesn't seem that this reflects the discussion we had yesterday. Comment at: clang/include/clang/AST/Attr.h:51 unsigned Implicit : 1; + unsigned ArgsDelayed : 1; // FIXME: These are properties of the attribute kind, not state f

[PATCH] D117898: [Clang] Add elementwise saturated add/sub builtins

RKSimon updated this revision to Diff 404013. RKSimon added a comment. rebase and add signed/unsigned integer mismatch tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117898/new/ https://reviews.llvm.org/D117898 Files: clang/docs/LanguageExt

[PATCH] D107290: [RISCV] Add support for the vscale_range attribute

frasercrmck updated this revision to Diff 404016. frasercrmck added a comment. rebase check for zvl feature strings alongside vscale_range Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107290/new/ https://reviews.llvm.org/D107290 Files: clang/li

[PATCH] D107290: [RISCV] Add support for the vscale_range attribute

frasercrmck added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVTargetMachine.cpp:101 + } else { +RVVBitsMin = RVVVectorBitsMinOpt; +RVVBitsMax = RVVVectorBitsMaxOpt; craig.topper wrote: > frasercrmck wrote: > > frasercrmck wrote: > > > craig.t

[PATCH] D114439: [Annotation] Allow parameter pack expansions and initializer lists in annotate attribute

aaron.ballman added a comment. I agree with the comments left by @erichkeane regarding some still needed tweaks to the approach. Comment at: clang/include/clang/Basic/Attr.td:208 class VariadicUnsignedArgument : Argument; -class VariadicExprArgument : Argument; +class Variadi

[PATCH] D118104: Make run-clang-tidy.py print the configured checks correctly

JesApp added a comment. I can (re)start a build manually. Let's see how that goes, before we start doing workarounds like that. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118104/new/ https://reviews.llvm.org/D118104 ___ cfe-commits mailin

[PATCH] D118471: [clang][Lexer] Make raw and normal lexer behave the same for line comments

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added a subscriber: usaxena95. kadircet requested review of this revision. Herald added subscribers: cfe-commits, ilya-biryukov. Herald added a project: clang. Normally there are heruistics in lexer to treat `//*` special

[PATCH] D117898: [Clang] Add elementwise saturated add/sub builtins

aaron.ballman added inline comments. Comment at: clang/docs/LanguageExtensions.rst:549 + T __builtin_elementwise_add_sat(T x, T y) return the sum of x and y, clamped to the range of signed or integer types + values representable by t

[PATCH] D116542: [OpenMP] Add a flag for embedding a file into the module

JonChesterfield added a comment. This might be OK. If multiple translation units still get fed to llvm-link it'll be broken, which might be what we get on amdgpu at present. Not totally clear to me whether this should be compiler.used or .used, as it's used by something after clang but before t

[PATCH] D118475: [clang-format] Fix misaligned trailing comments in the presence of an empty block comment.

curdeius created this revision. curdeius added reviewers: MyDeveloperDay, HazardyKnusperkeks, owenpan. curdeius requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fixes https://github.com/llvm/llvm-project/issues/53441. Expected code: /**/

[PATCH] D116542: [OpenMP] Add a flag for embedding a file into the module

jhuber6 added inline comments. Comment at: clang/lib/CodeGen/BackendUtil.cpp:1774 + SectionName += "."; + SectionName += *BinarySection; +} JonChesterfield wrote: > jhuber6 wrote: > > JonChesterfield wrote: > > > This looks lossy - if two files use

[PATCH] D116542: [OpenMP] Add a flag for embedding a file into the module

jhuber6 added inline comments. Comment at: clang/test/Frontend/embed-object.ll:2 +; RUN: %clang_cc1 -triple x86_64-unknown-linux-gnu -emit-llvm \ +; RUN:-fembed-offload-object=%S/Inputs/empty.h,section -x ir %s -o - \ +; RUN:| FileCheck %s -check-prefix=CHECK

[PATCH] D118477: [NFC][AIX]Disable new pcm tests on AIX

stevewan created this revision. stevewan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Same as D114481 , the PCH reader looks for a `__clangast` section in the precompiled module file, which isn't presen

[PATCH] D118104: Make run-clang-tidy.py print the configured checks correctly

njames93 added a comment. In D118104#3279524 , @JesApp wrote: > I can (re)start a build manually. Let's see how that goes, before we start > doing workarounds like that. I think there's just some serious latency problems with the pre merge checks atm

[PATCH] D116543: [OpenMP] Embed device files into the host IR

jhuber6 updated this revision to Diff 404030. jhuber6 added a comment. Adding test for multiple input files to embed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116543/new/ https://reviews.llvm.org/D116543 Files: clang/lib/Driver/ToolChains/C

[PATCH] D118350: [Clang][Sema][AIX][PowerPC] Emit byval alignment warning only when struct member is passed to a function

daltenty added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:5204 /// Warn if a pointer or reference argument passed to a function points to an /// object that is less aligned than the parameter. This can happen when This function definitely se

[PATCH] D118477: [NFC][AIX]Disable new pcm tests on AIX

Jake-Egan accepted this revision. Jake-Egan added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118477/new/ https://reviews.llvm.org/D118477

[PATCH] D116543: [OpenMP] Embed device files into the host IR

jhuber6 updated this revision to Diff 404033. jhuber6 added a comment. Add input filename to the section name to prevent it from being merged if the user does a link. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116543/new/ https://reviews.llvm.o

[PATCH] D116545: [OpenMP] Add support for extracting device code in linker wrapper

jhuber6 updated this revision to Diff 404035. jhuber6 added a comment. Changing section embedding after adding filenames previously. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116545/new/ https://reviews.llvm.org/D116545 Files: clang/tools/cl

[PATCH] D118474: [NFC][AIX][clang] un-XFAIL gcc profile flag compat test

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9939bb668212: [NFC][AIX][clang] un-XFAIL gcc profile flag compat t

[clang] 9939bb6 - [NFC][AIX][clang] un-XFAIL gcc profile flag compat test

Author: David Tenty Date: 2022-01-28T11:18:55-05:00 New Revision: 9939bb6682128235c9f0f6076d15ae5191d2dd05 URL: https://github.com/llvm/llvm-project/commit/9939bb6682128235c9f0f6076d15ae5191d2dd05 DIFF: https://github.com/llvm/llvm-project/commit/9939bb6682128235c9f0f6076d15ae5191d2dd05.diff L

[PATCH] D116542: [OpenMP] Add a flag for embedding a file into the module

jhuber6 updated this revision to Diff 404037. jhuber6 added a comment. Adding test for multiple files (added it to wrong commit). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116542/new/ https://reviews.llvm.org/D116542 Files: clang/include/cla

[PATCH] D116543: [OpenMP] Embed device files into the host IR

jhuber6 updated this revision to Diff 404038. jhuber6 added a comment. Remove test that was intended for previous commit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116543/new/ https://reviews.llvm.org/D116543 Files: clang/lib/Driver/ToolChai

[PATCH] D117137: [Driver] Add CUDA support for --offload param

yaxunl added a comment. In D117137#3274035 , @dcastagna wrote: > @yaxunl Are you OK landing this change as it is, without the check for OS and > environment in getHIPOffloadTargetTriple? > We can follow up with patch that adds checks for in OS and enviro

[PATCH] D118480: [clang][dataflow] Merge distinct pointer values in Environment::join

sgatev created this revision. sgatev added reviewers: ymandel, xazax.hun, gribozavr2. Herald added subscribers: tschuett, steakhal, rnkovacs. sgatev requested review of this revision. Herald added a project: clang. This is part of the implementation of the dataflow analysis framework. See "[RFC] A

[PATCH] D118370: [clang-tidy] bugprone-signal-handler: Code refactor (NFC)

balazske updated this revision to Diff 404040. balazske added a comment. Even more simplification, added documentation. Text of bug reports is more detailed, no NFC now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118370/new/ https://reviews.llvm

[PATCH] D118477: [NFC][AIX]Disable new pcm tests on AIX

daltenty accepted this revision. daltenty added a comment. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118477/new/ https://reviews.llvm.org/D118477 ___ cfe-commits mailing list cfe-commit

[PATCH] D118370: [clang-tidy] bugprone-signal-handler: Code refactor (NFC)

balazske marked 2 inline comments as done. balazske added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/SignalHandlerCheck.cpp:151 CallGraphNode *HandlerNode = CG.getNode(HandlerDecl); - // Signal handler can be external but not unsafe, no call graph in t

[clang] 6f4f745 - [clang][deps] Adapt test to be compatible when the assembler is called by default

Author: Jake Egan Date: 2022-01-28T11:40:16-05:00 New Revision: 6f4f745668eccf460ec1e0d34df4692f8e883b07 URL: https://github.com/llvm/llvm-project/commit/6f4f745668eccf460ec1e0d34df4692f8e883b07 DIFF: https://github.com/llvm/llvm-project/commit/6f4f745668eccf460ec1e0d34df4692f8e883b07.diff LOG

[PATCH] D118152: [clang][deps] Adapt test to be compatible when the assembler is called by default

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6f4f745668ec: [clang][deps] Adapt test to be compatible when the assembler is called by… (authored by Jake-Egan). Repository: rG LLVM Github Monor

[PATCH] D117593: [clang-tidy] Change google-explicit-constructor to ignore conversions and operators marked `explicit(false)`

aaron.ballman added a comment. In D117593#3274408 , @njames93 wrote: > In D117593#3273562 , @aaron.ballman > wrote: > >> Hmmm, this is a rule for checking a specific style guide. >> https://google.github.io/styl

[PATCH] D107769: [OpenCL] Make generic addrspace optional for -fdeclare-opencl-builtins

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM. Thanks for changing this. I have no issues with this patch as it doesn't change the behavior for OpenCL 2.0 but I did create an issue for OpenCL-Docs to fix this problem somehow:

[PATCH] D118474: [NFC][AIX][clang] un-XFAIL gcc profile flag compat test

sfertile added a comment. Thanks David. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118474/new/ https://reviews.llvm.org/D118474 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.ll

[PATCH] D118477: [NFC][AIX]Disable new pcm tests on AIX

sfertile accepted this revision. sfertile added a comment. Thanks Steven. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118477/new/ https://reviews.llvm.org/D118477 ___ cfe-commits mailing list cfe

[PATCH] D116542: [OpenMP] Add a flag for embedding a file into the module

jhuber6 updated this revision to Diff 404047. jhuber6 added a comment. Changing the name to be the section name. This ensures that if the sections get merged we will get a linker error without failing silently. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.l

[PATCH] D109977: LLVM Driver Multicall tool

MaskRay added a comment. Ping @beanz Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109977/new/ https://reviews.llvm.org/D109977 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.

[clang] 760e692 - [NFC][AIX]Disable new pcm tests on AIX

Author: Steven Wan Date: 2022-01-28T12:39:09-05:00 New Revision: 760e69223d83860ed4758f86a0de4686a8d51fd7 URL: https://github.com/llvm/llvm-project/commit/760e69223d83860ed4758f86a0de4686a8d51fd7 DIFF: https://github.com/llvm/llvm-project/commit/760e69223d83860ed4758f86a0de4686a8d51fd7.diff LO

[PATCH] D118477: [NFC][AIX]Disable new pcm tests on AIX

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG760e69223d83: [NFC][AIX]Disable new pcm tests on AIX (authored by stevewan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION http

[PATCH] D114639: Raise the minimum Visual Studio version to VS2019

stella.stamenova added inline comments. Comment at: lldb/docs/resources/build.rst:296 - $ cmake -G "Visual Studio 15 2017 Win64" -Thost=x64 + $ cmake -G "Visual Studio 16 2019" -A x64 -T host=x64 -Thost=x64 You accidentally added `-T host=x64` twice now

[PATCH] D118493: [WIP]Set rpath on openmp executables

JonChesterfield created this revision. JonChesterfield added reviewers: jdoerfert, jhuber6, tianshilei1992, ye-luo. Herald added subscribers: guansong, yaxunl. JonChesterfield requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. Openmp

[PATCH] D118493: [WIP]Set rpath on openmp executables

JonChesterfield added a comment. Testing manually looks good, provided there's no command line argument involved. -rpath even composes sanely, so doing this plus passing -Wl,rpath= results in multiple embedded rpaths. At a loss as to why changing Options.td is working so poorly, though it may b

[PATCH] D114639: Raise the minimum Visual Studio version to VS2019

RKSimon updated this revision to Diff 404076. RKSimon added a comment. fix cut+paste typo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114639/new/ https://reviews.llvm.org/D114639 Files: clang/docs/ClangFormatStyleOptions.rst clang/docs/Users

[PATCH] D101759: [PowerPC] Scalar IBM MASS library conversion pass

masoud.ataei marked 7 inline comments as done. masoud.ataei added inline comments. Comment at: llvm/lib/Target/PowerPC/PPCISelLowering.cpp:386 + if (TM.getOptLevel() == CodeGenOpt::Aggressive){ +setOperationAction(ISD::FSIN , MVT::f64, Custom); +setOperationAction(ISD::F

[PATCH] D117935: [AIX][clang] include_next through clang provided float.h

daltenty updated this revision to Diff 404083. daltenty added a comment. Use more unique macro name CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117935/new/ https://reviews.llvm.org/D117935 Files: clang/lib/Headers/float.h clang/test/Headers/Inputs/include/float.h clang/test/Hea

[PATCH] D117935: [AIX][clang] include_next through clang provided float.h

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG27ee91162dd3: [AIX][clang] include_next through clang provided float.h (authored by daltenty). Changed prior to commit: https://reviews.llvm.org/D

[clang] 27ee911 - [AIX][clang] include_next through clang provided float.h

Author: David Tenty Date: 2022-01-28T13:27:10-05:00 New Revision: 27ee91162dd3f01d692e8f092903dd79f4e54348 URL: https://github.com/llvm/llvm-project/commit/27ee91162dd3f01d692e8f092903dd79f4e54348 DIFF: https://github.com/llvm/llvm-project/commit/27ee91162dd3f01d692e8f092903dd79f4e54348.diff L

[PATCH] D109977: LLVM Driver Multicall tool

beanz added a comment. Sorry for disappearing on this. I'm working right now on adding support for multi-entry tools (like objcopy). I'll get an update in today. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109977/new/ https://reviews.llvm.org/D1

[PATCH] D118495: [OpenMP] Accept shortened triples for -Xopenmp-target=

jhuber6 created this revision. jhuber6 added reviewers: JonChesterfield, jdoerfert, tianshilei1992. Herald added subscribers: guansong, yaxunl. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. This patch builds on the change

[PATCH] D118350: [Clang][Sema][AIX][PowerPC] Emit byval alignment warning only when struct member is passed to a function

ZarkoCA updated this revision to Diff 404090. ZarkoCA added a comment. Addressing comments: - Change comment before checkArgAlignment() - Add missing RUN lines Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118350/new/ https://reviews.llvm.org/D118

[PATCH] D118495: [OpenMP] Accept shortened triples for -Xopenmp-target=

JonChesterfield added a comment. Do we have this same expansion logic in two places now? If so, probably want to factor it out to a function Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118495/new/ https://reviews.llvm.org/D118495 __

[PATCH] D101759: [PowerPC] Scalar IBM MASS library conversion pass

masoud.ataei added a comment. Ready for another round of review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101759/new/ https://reviews.llvm.org/D101759 ___ cfe-commits mailing list cfe-commits@lists.

[PATCH] D118350: [Clang][Sema][AIX][PowerPC] Emit byval alignment warning only when struct member is passed to a function

aaron.ballman added inline comments. Comment at: clang/include/clang/Sema/Sema.h:12693-12695 void CheckArgAlignment(SourceLocation Loc, NamedDecl *FDecl, - StringRef ParamName, QualType ArgTy, QualType ParamTy); + StringRef Para

[clang] 2771233 - GCC ABI Compatibility: Preserve alignment of non-pod members in packed structs

Author: David Blaikie Date: 2022-01-28T11:04:20-08:00 New Revision: 277123376ce08c98b07c154bf83e4092a5d4d3c6 URL: https://github.com/llvm/llvm-project/commit/277123376ce08c98b07c154bf83e4092a5d4d3c6 DIFF: https://github.com/llvm/llvm-project/commit/277123376ce08c98b07c154bf83e4092a5d4d3c6.diff

[PATCH] D117616: GCC ABI Compatibility: Preserve alignment of non-pod members in packed structs

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG277123376ce0: GCC ABI Compatibility: Preserve alignment of non-pod members in packed structs (authored by dblaikie). Repository: rG LLVM Github Mo

[PATCH] D118495: [OpenMP] Accept shortened triples for -Xopenmp-target=

jdoerfert added a comment. and test pls Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118495/new/ https://reviews.llvm.org/D118495 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.ll

[PATCH] D118493: [WIP]Set rpath on openmp executables

jdoerfert added a comment. Can we test this somehow? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118493/new/ https://reviews.llvm.org/D118493 ___ cfe-commits mailing list cfe-commits@lists.llvm.org htt

[PATCH] D118493: [WIP]Set rpath on openmp executables

JonChesterfield added a comment. My plan is to feed executables to readelf -d. Commandline problems seem to be solvable by clean builds between changes, slow but feasible. Might upset the incremental buildbot Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D118050: [analyzer] Different address spaces cannot overlap

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/SimpleSValBuilder.cpp:728 +const MemRegion *R = loc.castAs().getRegion(); +if (const auto *SR = dyn_cast(R)) { + QualType Ty = SR->getSymbol()->getType(); That's a pretty big "if".

  1   2   >