[PATCH] D93298: [RISCV] add the MC layer support of Zfinx extension

achieveartificialintelligence updated this revision to Diff 401528. achieveartificialintelligence added a comment. Address @craig.topper's comments. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93298/new/ https://reviews.llvm.org/D93298 F

[clang] 0be3da1 - [RISCV] Add intrinsic for Zbt extension

Author: Chenbing.Zheng Date: 2022-01-20T08:27:05Z New Revision: 0be3da1fab5a88d497081026fbcab7c0f6c88ef4 URL: https://github.com/llvm/llvm-project/commit/0be3da1fab5a88d497081026fbcab7c0f6c88ef4 DIFF: https://github.com/llvm/llvm-project/commit/0be3da1fab5a88d497081026fbcab7c0f6c88ef4.diff LOG

[PATCH] D117468: [RISCV] Add intrinsic for Zbt extension

This revision was automatically updated to reflect the committed changes. Closed by commit rG0be3da1fab5a: [RISCV] Add intrinsic for Zbt extension (authored by Chenbing.Zheng, committed by benshi001). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117

[clang-tools-extra] baa08d1 - [clang-tidy] Revert documentation change (NFC)

Author: Richard Date: 2022-01-20T01:27:23-07:00 New Revision: baa08d1ec3e20dc9107099119e7f27e3fbdc780d URL: https://github.com/llvm/llvm-project/commit/baa08d1ec3e20dc9107099119e7f27e3fbdc780d DIFF: https://github.com/llvm/llvm-project/commit/baa08d1ec3e20dc9107099119e7f27e3fbdc780d.diff LOG:

[PATCH] D117753: [AArch64] Support for memset tagged intrinsic

tyb0807 created this revision. Herald added a subscriber: kristof.beyls. tyb0807 requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. This introduces a new ACLE intrinsic for memset tagged (see https://github.com/ARM-software/a

[PATCH] D117753: [AArch64] Support for memset tagged intrinsic

tyb0807 updated this revision to Diff 401534. tyb0807 edited the summary of this revision. tyb0807 added a comment. Update commit message to clarify context. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117753/new/ https://reviews.llvm.org/D117753

[PATCH] D116386: [clang-tidy] Narrow cppguidelines-macro-usage to actual constants

carlosgalvezp added inline comments. Comment at: clang-tools-extra/clang-tidy/cppcoreguidelines/MacroUsageCheck.cpp:23 -namespace { - -bool isCapsOnly(StringRef Name) { - return std::all_of(Name.begin(), Name.end(), [](const char C) { -if (std::isupper(C) || std::isdigit(

[clang] 794b1ee - [clang-format] Add tests for aligning `operator=` with `=delete`. NFC.

Author: Marek Kurdej Date: 2022-01-20T09:39:08+01:00 New Revision: 794b1eebe749d739a0c530ca53cadc8925fbfec2 URL: https://github.com/llvm/llvm-project/commit/794b1eebe749d739a0c530ca53cadc8925fbfec2 DIFF: https://github.com/llvm/llvm-project/commit/794b1eebe749d739a0c530ca53cadc8925fbfec2.diff

[PATCH] D113336: [RISCV] Imply extensions in RISCVTargetInfo::initFeatureMap

eopXD added a comment. This patch needs to be landed before D112613 because clang_cc1 needs to do correct implication from `v`, `zve32f`, `zve64f` and `zve64d` and this patch fixes the issue. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D113336: [RISCV] Imply extensions in RISCVTargetInfo::initFeatureMap

kito-cheng accepted this revision. kito-cheng added a comment. This revision is now accepted and ready to land. Otherwise LGTM. Comment at: clang/lib/Basic/Targets/RISCV.cpp:220 - return TargetInfo::initFeatureMap(Features, Diags, CPU, FeaturesVec); + unsigned XLen = Featur

[PATCH] D113336: [RISCV] Imply extensions in RISCVTargetInfo::initFeatureMap

eopXD updated this revision to Diff 401541. eopXD marked an inline comment as done. eopXD added a comment. Update code based on @kito-cheng 's comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113336/new/ https://reviews.llvm.org/D113336 File

[PATCH] D112987: [RISCV] Bump rvv-related extensions from 0.10 to 1.0

eopXD updated this revision to Diff 401546. eopXD added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112987/new/ https://reviews.llvm.org/D112987 Files: clang/lib/Basic/Targets/RISCV.cpp clang/utils/TableGen/RISCVVEmitter.c

[PATCH] D117754: [clang][dataflow] Intersect ExprToLoc when joining environments

sgatev created this revision. sgatev added reviewers: ymandel, xazax.hun, gribozavr2. Herald added subscribers: steakhal, rnkovacs. sgatev requested review of this revision. Herald added a project: clang. This is part of the implementation of the dataflow analysis framework. See "[RFC] A dataflow

[PATCH] D112613: [RISCV] Change TARGET_BUILTIN require to zve32x for vector instruction

eopXD updated this revision to Diff 401549. eopXD added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112613/new/ https://reviews.llvm.org/D112613 Files: clang/utils/TableGen/RISCVVEmitter.cpp Index: clang/utils/TableGen/RIS

[clang] 60b6e73 - [RISCV] Imply extensions in RISCVTargetInfo::initFeatureMap

Author: eopXD Date: 2022-01-20T01:47:10-08:00 New Revision: 60b6e73769f84110f2cc0a2dbbf610c8671aa696 URL: https://github.com/llvm/llvm-project/commit/60b6e73769f84110f2cc0a2dbbf610c8671aa696 DIFF: https://github.com/llvm/llvm-project/commit/60b6e73769f84110f2cc0a2dbbf610c8671aa696.diff LOG: [R

[PATCH] D113336: [RISCV] Imply extensions in RISCVTargetInfo::initFeatureMap

This revision was automatically updated to reflect the committed changes. Closed by commit rG60b6e73769f8: [RISCV] Imply extensions in RISCVTargetInfo::initFeatureMap (authored by eopXD). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113336/new/ htt

[PATCH] D105169: [Clang/Test]: Rename enable_noundef_analysis to disable-noundef-analysis and turn it off by default

nlopes added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:2535 ArgAttrs[FirstIRArg + i] = llvm::AttributeSet::get(getLLVMContext(), Attrs); } fhahn wrote: > nlopes wrote: > > ab wrote: > > > Hmm, if I'm reading this right,

[PATCH] D112613: [RISCV] Change TARGET_BUILTIN require to zve32x for vector instruction

eopXD updated this revision to Diff 401554. eopXD added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112613/new/ https://reviews.llvm.org/D112613 Files: clang/utils/TableGen/RISCVVEmitter.cpp Index: clang/utils/TableGen/RIS

[PATCH] D116085: [clang-tidy] Performance improvements for NOLINTBEGIN/END blocks

salman-javed-nz added a comment. In D116085#3257210 , @carlosgalvezp wrote: > Amazing job @salman-javed-nz ! Here's some initial comments. Reviewing the > `NoLintPragmaHandler.cpp` will take some more time from me. It would have > been easier to see th

[PATCH] D117759: [clang-format][NFC] Clean up tryMergeLessLess()

owenpan created this revision. owenpan added reviewers: MyDeveloperDay, curdeius, HazardyKnusperkeks, pjessesco. owenpan added a project: clang-format. owenpan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Mo

[PATCH] D116221: [AArch64][ARM][Clang] Unaligned Access Warning Added

lenary accepted this revision. lenary added a comment. LGTM. I've looked a lot closer at the tests this time around, and am happy with them, and I think the message is phrased better, and there shouldn't be warnings with `-cc1as`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116221/ne

[PATCH] D117202: [ARM] Add Cortex-X1C Support for Clang and LLVM

stuij marked 2 inline comments as done. stuij added inline comments. Comment at: llvm/include/llvm/Support/AArch64TargetParser.def:205 +AARCH64_CPU_NAME("cortex-x1c", ARMV8_2A, FK_CRYPTO_NEON_FP_ARMV8, false, + (AArch64::AEK_RAS)) AARCH64_CPU_NAME("cortex-x2", AR

[PATCH] D105169: [Clang/Test]: Rename enable_noundef_analysis to disable-noundef-analysis and turn it off by default

fhahn added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:2535 ArgAttrs[FirstIRArg + i] = llvm::AttributeSet::get(getLLVMContext(), Attrs); } nlopes wrote: > fhahn wrote: > > nlopes wrote: > > > ab wrote: > > > > Hmm, if I'm

[PATCH] D115856: [syntax][pseudo] Introduce the spec C++ grammar.

hokein updated this revision to Diff 401559. hokein marked 7 inline comments as done. hokein added a comment. address comments and add lit test to verify cxx.bnf Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115856/new/ https://reviews.llvm.org/D11

[PATCH] D115856: [syntax][pseudo] Introduce the spec C++ grammar.

hokein updated this revision to Diff 401561. hokein marked an inline comment as done. hokein added a comment. add new line to eof Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115856/new/ https://reviews.llvm.org/D115856 Files: clang/lib/Tooling

[PATCH] D115856: [syntax][pseudo] Introduce the spec C++ grammar.

hokein added inline comments. Comment at: clang/lib/Tooling/Syntax/Pseudo/cxx.bnf:27 +# FIXME: +# - support annotations (lazy parsing, contextual identifiers) +# - empty input should be parsed successfully (special-case it?) sammccall wrote: > I think we shou

[clang] 782c0dd - [IRBuilder] Migrate and-folding to value-based FoldAnd.

Author: Florian Hahn Date: 2022-01-20T10:22:21Z New Revision: 782c0dd1a1c235afb09a34e7da4a1267ead14765 URL: https://github.com/llvm/llvm-project/commit/782c0dd1a1c235afb09a34e7da4a1267ead14765 DIFF: https://github.com/llvm/llvm-project/commit/782c0dd1a1c235afb09a34e7da4a1267ead14765.diff LOG:

[PATCH] D117431: [IRBuilder] Migrate and-folding to value-based FoldAnd.

This revision was automatically updated to reflect the committed changes. Closed by commit rG782c0dd1a1c2: [IRBuilder] Migrate and-folding to value-based FoldAnd. (authored by fhahn). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117431/new/ https:/

[PATCH] D112987: [RISCV] Bump rvv-related extensions from 0.10 to 1.0

eopXD updated this revision to Diff 401564. eopXD added a comment. Update code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112987/new/ https://reviews.llvm.org/D112987 Files: clang/test/Driver/riscv-arch.c clang/test/Preprocessor/riscv-targ

[PATCH] D117202: [ARM] Add Cortex-X1C Support for Clang and LLVM

stuij updated this revision to Diff 401569. stuij marked an inline comment as done. stuij added a comment. addressed review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117202/new/ https://reviews.llvm.org/D117202 Files: clang/test/Dri

[PATCH] D117759: [clang-format][NFC] Clean up tryMergeLessLess()

curdeius accepted this revision. curdeius added a comment. This revision is now accepted and ready to land. LGTM. Comment at: clang/lib/Format/FormatTokenLexer.cpp:440-441 - if (First[2]->is(tok::less) || First[1]->isNot(tok::less) || - First[0]->isNot(tok::less) || Fou

[PATCH] D117754: [clang][dataflow] Intersect ExprToLoc when joining environments

xazax.hun added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/TypeErasedDataflowAnalysis.cpp:49 + // in tests. + std::set Preds; Preds.insert(Block.pred_begin(), Block.pred_end()); Are we sure that the memory addresses of CFGBlocks are stable

[PATCH] D117754: [clang][dataflow] Intersect ExprToLoc when joining environments

xazax.hun added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/TypeErasedDataflowAnalysis.cpp:49 + // in tests. + std::set Preds; Preds.insert(Block.pred_begin(), Block.pred_end()); xazax.hun wrote: > Are we sure that the memory addresses of C

[PATCH] D117405: [AArch64] CodeGen for Armv8.8/9.3 MOPS

tyb0807 added a comment. Following Dave's comments above, this patch is now split to 4 different patches https://reviews.llvm.org/D117753 https://reviews.llvm.org/D117757 https://reviews.llvm.org/D117763 https://reviews.llvm.org/D117764 and may now be abandoned. Repository: rG LLVM Github Mon

[PATCH] D105169: [Clang/Test]: Rename enable_noundef_analysis to disable-noundef-analysis and turn it off by default

sammccall added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:2535 ArgAttrs[FirstIRArg + i] = llvm::AttributeSet::get(getLLVMContext(), Attrs); } fhahn wrote: > nlopes wrote: > > fhahn wrote: > > > nlopes wrote: > > > > ab w

[PATCH] D116085: [clang-tidy] Performance improvements for NOLINTBEGIN/END blocks

salman-javed-nz updated this revision to Diff 401576. salman-javed-nz edited the summary of this revision. salman-javed-nz added a comment. Update according to review (rename NoLintPragmaHandler class to NoLintDirectiveHandler) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D112613: [RISCV] Change TARGET_BUILTIN require to zve32x for vector instruction

frasercrmck added a comment. LGTM but I don't have full scope on the builtins side of things. I'd also add a missing word to the title: "Change TARGET_BUILTIN //to// require ..." Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112613/new/ https://re

[PATCH] D117769: [clang-format] Refactor: add FormatToken::hasWhitespaceBefore(). NFC.

curdeius created this revision. curdeius added reviewers: MyDeveloperDay, HazardyKnusperkeks, owenpan. curdeius requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This factors out a pattern that comes up from time to time. Repository: rG L

[PATCH] D117405: [AArch64] CodeGen for Armv8.8/9.3 MOPS

tyb0807 marked 8 inline comments as done. tyb0807 added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64ExpandPseudoInsts.cpp:836 + // inside a bundle to prevent other passes to moving things in between. + MIBundleBuilder Bundler(MBB, MBBI); + auto &MF = *MBB.getPa

[PATCH] D117759: [clang-format][NFC] Clean up tryMergeLessLess()

owenpan updated this revision to Diff 401579. owenpan added a comment. Further cleanup. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117759/new/ https://reviews.llvm.org/D117759 Files: clang/lib/Format/FormatTokenLexer.cpp Index: clang/lib/Format/FormatTokenLexer.cpp =

[PATCH] D117759: [clang-format][NFC] Clean up tryMergeLessLess()

owenpan requested review of this revision. owenpan marked an inline comment as done. owenpan added inline comments. Comment at: clang/lib/Format/FormatTokenLexer.cpp:440-441 - if (First[2]->is(tok::less) || First[1]->isNot(tok::less) || - First[0]->isNot(tok::less) || Fou

[PATCH] D117769: [clang-format] Refactor: add FormatToken::hasWhitespaceBefore(). NFC.

owenpan accepted this revision. owenpan added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117769/new/ https://reviews.llvm.org/D117769

[PATCH] D114439: [Annotation] Allow parameter pack expansions in annotate attribute

steffenlarsen added a comment. Thank you, @aaron.ballman ! I will update the revision in a moment with some of the suggested changes. Comment at: clang/lib/Parse/ParseDecl.cpp:436-438 +// Interpret "kw_this" as an identifier if the attributed requests it. +if (

[PATCH] D114439: [Annotation] Allow parameter pack expansions in annotate attribute

steffenlarsen updated this revision to Diff 401580. steffenlarsen added a comment. Applied suggestions. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114439/new/ https://reviews.llvm.org/D114439 Files: clang/include/clang/Basic/Attr.td clang/include/clang/Basic/DiagnosticParseKinds

[PATCH] D117613: [ASTMatchers] Add `isConsteval` matcher

cor3ntin added inline comments. Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:5179 +/// consteval int bar(); +/// void baz() { if consteval {} } +/// \endcode Izaron wrote: > aaron.ballman wrote: > > It'd be good to show an example of: > > ``` > >

[PATCH] D117759: [clang-format][NFC] Clean up tryMergeLessLess()

curdeius accepted this revision. curdeius added a comment. This revision is now accepted and ready to land. Great! Thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117759/new/ https://reviews.llvm.org/D117759 ___ cfe-commits mailing list

[PATCH] D117754: [clang][dataflow] Intersect ExprToLoc when joining environments

sgatev updated this revision to Diff 401581. sgatev marked an inline comment as done. sgatev added a comment. Address reviewers' comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117754/new/ https://reviews.llvm.org/D117754 Files: clang/li

[PATCH] D117754: [clang][dataflow] Intersect ExprToLoc when joining environments

sgatev marked an inline comment as done. sgatev added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/TypeErasedDataflowAnalysis.cpp:49 + // in tests. + std::set Preds; Preds.insert(Block.pred_begin(), Block.pred_end()); xazax.hun wrote: > xaza

[PATCH] D117754: [clang][dataflow] Intersect ExprToLoc when joining environments

xazax.hun added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/TypeErasedDataflowAnalysis.cpp:49 + // in tests. + std::set Preds; Preds.insert(Block.pred_begin(), Block.pred_end()); sgatev wrote: > xazax.hun wrote: > > xazax.hun wrote: > > > A

[PATCH] D117232: [clang] Respect -Wdeclaration-after-statement with C99 or later

melver added a comment. Hello, A quick review would be much appreciated. I intend to submit this before Feb 1 so it may be included in Clang 14. In case I have not added the appropriate reviewer(s) of the modified code, please let me know. Thank you. Repository: rG LLVM Github Monorepo C

[PATCH] D112613: [RISCV] Change TARGET_BUILTIN to require zve32x for vector instruction

eopXD added a comment. Apply @frasercrmck 's suggested title, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112613/new/ https://reviews.llvm.org/D112613 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D112986: [RISCV] Restrict zvamo, zvlsseg with zve macro-s

eopXD reclaimed this revision. eopXD added a comment. This was closed by my misunderstanding. For clang we still need to do some restrictions based on ELEN. Reopening. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112986/new/ https://reviews.llvm.o

[PATCH] D105169: [Clang/Test]: Rename enable_noundef_analysis to disable-noundef-analysis and turn it off by default

sdesmalen added a comment. In D105169#3254757 , @nlopes wrote: > In D105169#3254692 , @DavidSpickett > wrote: > >> Hi, this patch has caused a gcc test suite failure on our SVE bots: >> https://lab.llvm.org/buil

[PATCH] D117773: [clang-tidy] added JSON output to clang-tidy-diff.py

kuhnel created this revision. Herald added subscribers: carlosgalvezp, usaxena95, kadircet, xazax.hun. kuhnel requested review of this revision. Herald added subscribers: cfe-commits, ilya-biryukov. Herald added a project: clang-tools-extra. This makes it easier to process the clang-tidy output in

[PATCH] D107450: [clang-tidy] Fix wrong FixIt in performance-move-const-arg

aaron.ballman added a comment. Do you need someone to commit on your behalf? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107450/new/ https://reviews.llvm.org/D107450 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm

[PATCH] D105169: [Clang/Test]: Rename enable_noundef_analysis to disable-noundef-analysis and turn it off by default

nlopes added a comment. In D105169#3257849 , @sdesmalen wrote: > In D105169#3254757 , @nlopes wrote: > >> In D105169#3254692 , >> @DavidSpickett wrote: >> >>> Hi, this pa

[PATCH] D105169: [Clang/Test]: Rename enable_noundef_analysis to disable-noundef-analysis and turn it off by default

nlopes added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:2535 ArgAttrs[FirstIRArg + i] = llvm::AttributeSet::get(getLLVMContext(), Attrs); } sammccall wrote: > fhahn wrote: > > nlopes wrote: > > > fhahn wrote: > > > > nlop

[PATCH] D116221: [AArch64][ARM][Clang] Unaligned Access Warning Added

pbarrio accepted this revision. pbarrio added a comment. This revision is now accepted and ready to land. LGTM too. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116221/new/ https://reviews.llvm.org/D116221 ___ cfe-commits mailing list cfe-co

[PATCH] D117647: [RISCV] Add destination operand for RVV nomask load intrinsics.

frasercrmck added a comment. Is "destination operand" the terminology we want? I'd have thought "passthru" was more conventional. Comment at: llvm/lib/Target/RISCV/RISCVISelDAGToDAG.cpp:1194 Operands.push_back(Node->getOperand(CurOp++)); + if (Node->getOperand(Cu

[PATCH] D117520: [clang-format] Fix SeparateDefinitionBlocks issues

curdeius added a comment. In D117520#3251425 , @MyDeveloperDay wrote: > For > > class Test > { > public: > static void foo() > { > } > }; > > F21703157: image.png > > $ clang-format -n test

[PATCH] D112987: [RISCV] Bump rvv-related extensions from 0.10 to 1.0

frasercrmck added a comment. If we're bumping it to 1.0, does that mean it's no longer "experimental"? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112987/new/ https://reviews.llvm.org/D112987 ___ cfe-c

[PATCH] D116786: [clangd] Add designator inlay hints for initializer lists.

kadircet added a comment. > Any ideas? :-( I've got a feeling that, this should also be annoying in the case of function calls (especially when there's only one overload)? Maybe we should just debounce the inlayhint requests (by saying contents modified to the clients)? Repository: rG LLVM

[PATCH] D117776: [clangd] Fail inlayHints requests on content changes

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: usaxena95, arphaman. kadircet requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. This should improve the overall

[PATCH] D117754: [clang][dataflow] Intersect ExprToLoc when joining environments

sgatev marked 2 inline comments as done. sgatev added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/TypeErasedDataflowAnalysis.cpp:49 + // in tests. + std::set Preds; Preds.insert(Block.pred_begin(), Block.pred_end()); xazax.hun wrote: > sgat

[clang] 69ecd24 - [clang-format] Indicate source location on test failure. NFC.

Author: Marek Kurdej Date: 2022-01-20T14:10:59+01:00 New Revision: 69ecd2484f0d363537afc0157bd6a946fccf8453 URL: https://github.com/llvm/llvm-project/commit/69ecd2484f0d363537afc0157bd6a946fccf8453 DIFF: https://github.com/llvm/llvm-project/commit/69ecd2484f0d363537afc0157bd6a946fccf8453.diff

[PATCH] D117777: [OpenMP] Don't pass empty files to nvlink

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, ye-luo, lechenyu. Herald added subscribers: guansong, yaxunl. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. This patch adds and exception to the nvlink wr

[PATCH] D117613: [ASTMatchers] Add `isConsteval` matcher

aaron.ballman requested changes to this revision. aaron.ballman added inline comments. This revision now requires changes to proceed. Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:5179 +/// consteval int bar(); +/// void baz() { if consteval {} } +/// \endcode ---

[PATCH] D112987: [RISCV] Bump rvv-related extensions from 0.10 to 1.0

asb added a comment. In D112987#3257899 , @frasercrmck wrote: > If we're bumping it to 1.0, does that mean it's no longer "experimental"? Whether RVV is non-experimental or not is the big open question for 14.0. I've put it on the agenda for today's sy

[PATCH] D117754: [clang][dataflow] Intersect ExprToLoc when joining environments

xazax.hun added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/TypeErasedDataflowAnalysis.cpp:49 + // in tests. + std::set Preds; Preds.insert(Block.pred_begin(), Block.pred_end()); sgatev wrote: > xazax.hun wrote: > > sgatev wrote: > > > xaza

[PATCH] D105169: [Clang/Test]: Rename enable_noundef_analysis to disable-noundef-analysis and turn it off by default

fhahn added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:2535 ArgAttrs[FirstIRArg + i] = llvm::AttributeSet::get(getLLVMContext(), Attrs); } nlopes wrote: > sammccall wrote: > > fhahn wrote: > > > nlopes wrote: > > > > fhah

[PATCH] D117613: [ASTMatchers] Add `isConsteval` matcher

cor3ntin added inline comments. Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:5179 +/// consteval int bar(); +/// void baz() { if consteval {} } +/// \endcode aaron.ballman wrote: > cor3ntin wrote: > > Izaron wrote: > > > aaron.ballman wrote: > >

[PATCH] D117769: [clang-format] Refactor: add FormatToken::hasWhitespaceBefore(). NFC.

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117769/new/ https://reviews.llvm.org/D117769 ___ cfe-commits mailing list cfe-com

[PATCH] D117759: [clang-format][NFC] Clean up tryMergeLessLess()

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. LGTM, at first my head was confused with First[-1] but I think its ok. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117759/new/ https://reviews.llvm.org/D117759 ___ cfe-

[PATCH] D115060: [clang-format][NFC] Code Tidies in UnwrappedLineFormatter

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115060/new/ https://reviews.llvm.org/D115060 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.

[PATCH] D117613: [ASTMatchers] Add `isConsteval` matcher

aaron.ballman added inline comments. Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:5179 +/// consteval int bar(); +/// void baz() { if consteval {} } +/// \endcode cor3ntin wrote: > aaron.ballman wrote: > > cor3ntin wrote: > > > Izaron wrote: > >

[PATCH] D117754: [clang][dataflow] Intersect ExprToLoc when joining environments

sgatev updated this revision to Diff 401615. sgatev marked an inline comment as done. sgatev added a comment. Address reviewers' comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117754/new/ https://reviews.llvm.org/D117754 Files: clang/li

[PATCH] D117754: [clang][dataflow] Intersect ExprToLoc when joining environments

sgatev marked an inline comment as done. sgatev added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/TypeErasedDataflowAnalysis.cpp:49 + // in tests. + std::set Preds; Preds.insert(Block.pred_begin(), Block.pred_end()); xazax.hun wrote: > sgat

[PATCH] D117754: [clang][dataflow] Intersect ExprToLoc when joining environments

xazax.hun added a comment. Thanks, this looks good to me! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117754/new/ https://reviews.llvm.org/D117754 ___ cfe-commits mailing list cfe-commits@lists.llvm.or

[PATCH] D116786: [clangd] Add designator inlay hints for initializer lists.

sammccall added a comment. In D116786#3257932 , @kadircet wrote: >> Any ideas? :-( > > I've got a feeling that, this should also be annoying in the case of function > calls (especially when there's only one overload)? Maybe we should just > debounce the

[clang] 35737df - [Clang][AArch64][ARM] Unaligned Access Warning Added

Author: Mubashar Ahmad Date: 2022-01-20T14:12:49Z New Revision: 35737df4dcd28534bd3090157c224c19b501278a URL: https://github.com/llvm/llvm-project/commit/35737df4dcd28534bd3090157c224c19b501278a DIFF: https://github.com/llvm/llvm-project/commit/35737df4dcd28534bd3090157c224c19b501278a.diff LOG

[PATCH] D116221: [AArch64][ARM][Clang] Unaligned Access Warning Added

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG35737df4dcd2: [Clang][AArch64][ARM] Unaligned Access Warning Added (authored by mubashar_). Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[PATCH] D116088: [compiler-rt] Implement ARM atomic operations for architectures without SMP support

kpdev42 added a comment. In D116088#3254400 , @joerg wrote: > Correct me if I'm wrong, but I don't think this stubs are async signal safe > nor will they work for preemptive multitasking systems? Those stubs are basically cas loops (https://en.wikipedi

[PATCH] D117613: [ASTMatchers] Add `isConsteval` matcher

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM with a minor adjustment to the documentation. Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:5173 +/// Matches consteval function declarations

[clang] c95cb4d - [clang][dataflow] Intersect ExprToLoc when joining environments

Author: Stanislav Gatev Date: 2022-01-20T14:30:17Z New Revision: c95cb4de1b6674e52aebdb7d02c6431843001282 URL: https://github.com/llvm/llvm-project/commit/c95cb4de1b6674e52aebdb7d02c6431843001282 DIFF: https://github.com/llvm/llvm-project/commit/c95cb4de1b6674e52aebdb7d02c6431843001282.diff LO

[PATCH] D117754: [clang][dataflow] Intersect ExprToLoc when joining environments

This revision was automatically updated to reflect the committed changes. Closed by commit rGc95cb4de1b66: [clang][dataflow] Intersect ExprToLoc when joining environments (authored by sgatev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117754/new/

[PATCH] D112613: [Clang][RISCV] Change TARGET_BUILTIN to require zve32x for vector instruction

kito-cheng accepted this revision. kito-cheng added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112613/new/ https://reviews.llvm.org/D112613 ___

[PATCH] D117717: [clang] Ignore -fconserve-stack

aaron.ballman added reviewers: steakhal, NoQ, martong, Szelethus. aaron.ballman added a comment. Herald added a subscriber: rnkovacs. Adding some reviewers from the Clang Static Analyzer side of things. In D117717#3256243 , @nathanchance wrote: > Should

[clang] 14c5fd9 - [Clang][RISCV] Change TARGET_BUILTIN to require zve32x for vector instruction

Author: eopXD Date: 2022-01-20T06:53:48-08:00 New Revision: 14c5fd920b0e4e05c5deed358af47707e579dd6d URL: https://github.com/llvm/llvm-project/commit/14c5fd920b0e4e05c5deed358af47707e579dd6d DIFF: https://github.com/llvm/llvm-project/commit/14c5fd920b0e4e05c5deed358af47707e579dd6d.diff LOG: [C

[PATCH] D112613: [Clang][RISCV] Change TARGET_BUILTIN to require zve32x for vector instruction

This revision was automatically updated to reflect the committed changes. Closed by commit rG14c5fd920b0e: [Clang][RISCV] Change TARGET_BUILTIN to require zve32x for vector instruction (authored by eopXD). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D117777: [OpenMP] Don't pass empty files to nvlink

jdoerfert added a comment. test? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D11/new/ https://reviews.llvm.org/D11 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/

[PATCH] D117232: [clang] Respect -Wdeclaration-after-statement with C99 or later

aaron.ballman added a comment. Can you also add a release note about the change? Comment at: clang/test/Sema/warn-mixed-decls-code.c:1-3 +// RUN: %clang_cc1 -std=c89 -fsyntax-only -verify -Wall -Wno-comment -DSILENCE %s +// RUN: %clang_cc1 -std=c99 -fsyntax-only -verify -Wall

[PATCH] D117787: [NVPTX] abs, neg, min, max intrinsics for half types

jchlanda created this revision. jchlanda added reviewers: jholewinski, steffenlarsen, asavonic, sebastian-ne. Herald added a subscriber: hiraditya. jchlanda requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, jdoerfert. Herald added projects: clang, LLVM. This p

[clang] 3da69fb - [Clang][AArch64][ARM] Unaligned Access Test Fix

Author: Mubashar Ahmad Date: 2022-01-20T15:29:53Z New Revision: 3da69fb5a26c7bf83320b3b4ad0859be9b47b3fb URL: https://github.com/llvm/llvm-project/commit/3da69fb5a26c7bf83320b3b4ad0859be9b47b3fb DIFF: https://github.com/llvm/llvm-project/commit/3da69fb5a26c7bf83320b3b4ad0859be9b47b3fb.diff LOG

[PATCH] D117566: [clang][lex] Introduce `SearchDirIterator`

jansvoboda11 updated this revision to Diff 401640. jansvoboda11 added a comment. Rename the new iterator type. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117566/new/ https://reviews.llvm.org/D117566 Files: clang/include/clang/Lex/HeaderSearch

[PATCH] D117753: [AArch64] Support for memset tagged intrinsic

SjoerdMeijer added inline comments. Comment at: clang/lib/Headers/arm_acle.h:734 +/* Memory Operations Intrinsics */ +#if __ARM_FEATURE_MOPS && __ARM_FEATURE_MEMORY_TAGGING +#define __arm_mops_memset_tag(tagged_address, value, size) \ Why doe

[PATCH] D117569: Constexpr not supported with __declspec(dllimport).

zahiraam added a comment. In D117569#3257121 , @majnemer wrote: > I have a question regarding how this work with respect to the dllimport > semantics known by the linker. > IIUC, we will now allow a program like: > > extern int __declspec(dllimport) dl

[PATCH] D117232: [clang] Respect -Wdeclaration-after-statement with C99 or later

melver added a comment. Looks like https://reviews.llvm.org/D114787 does the same thing and was submitted a week ago. I'll try to integrate the additional testing you suggested and change this patch to improve the implementation to not do the checking if not required as it doesn't look entirel

[PATCH] D117787: [NVPTX] abs, neg, min, max intrinsics for half types

jchlanda abandoned this revision. jchlanda added a comment. I need to update this to the upstream, as it was based on intel's fork. Abandoning for now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117787/new/ https://reviews.llvm.org/D117787 ___

[PATCH] D117232: [clang] Respect -Wdeclaration-after-statement with C99 or later

aaron.ballman added a comment. In D117232#3258309 , @melver wrote: > Looks like https://reviews.llvm.org/D114787 does the same thing and was > submitted a week ago. > > I'll try to integrate the additional testing you suggested and change this > patch t

[PATCH] D117569: Constexpr not supported with __declspec(dllimport).

zahiraam updated this revision to Diff 401644. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117569/new/ https://reviews.llvm.org/D117569 Files: clang/lib/AST/ExprConstant.cpp clang/test/CodeGenCXX/PR19955.cpp clang/test/CodeGenCXX/dllimport.cpp clang/test/SemaCXX/PR19955.cpp c

  1   2   3   >