[clang] 4f61749 - [clang] support relative roots to vfs overlays

Author: Richard Howell Date: 2022-01-19T10:13:06-08:00 New Revision: 4f61749e16f63b0c9ebd9bdd1f8bf4f570a31692 URL: https://github.com/llvm/llvm-project/commit/4f61749e16f63b0c9ebd9bdd1f8bf4f570a31692 DIFF: https://github.com/llvm/llvm-project/commit/4f61749e16f63b0c9ebd9bdd1f8bf4f570a31692.diff

[PATCH] D116174: [clang] support relative roots to vfs overlays

This revision was automatically updated to reflect the committed changes. Closed by commit rG4f61749e16f6: [clang] support relative roots to vfs overlays (authored by rmaz, committed by ellis). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116174/new

[PATCH] D113507: [clang-tidy] Include constructor initializers in `bugprone-exception-escape` check

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, thanks for the fix! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113507/new/ https://reviews.llvm.org/D113507 ___ cfe

[PATCH] D116386: [clang-tidy] Narrow cppguidelines-macro-usage to actual constants

carlosgalvezp accepted this revision. carlosgalvezp added a comment. This revision is now accepted and ready to land. Looks reasonable to me! I'm fairly new here so I might not be the most "authoritative reviewer", let me know if you'd like someone else to give the final approval

[PATCH] D117246: [OpenMP] Add support for linking AMDGPU images

JonChesterfield added a comment. A bit nervous about the automatic appending of host library search paths for the device link but I see that's pre-existing in nvptx. I'll check whether -### changes behaviour as expected and approve if it does Comment at: clang/lib/Driver/Tool

[PATCH] D117468: [RISCV] Add intrinsic for Zbt extension

craig.topper added a comment. In D117468#3253879 , @Chenbing.Zheng wrote: > In D117468#3253493 , @craig.topper > wrote: > >> Out of curiosity, what is your interest in Zbt? Do you work for a company >> that is

[PATCH] D116386: [clang-tidy] Narrow cppguidelines-macro-usage to actual constants

carlosgalvezp added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/cppcoreguidelines-macro-usage.rst:11 +`ES.31 `_, and +`ES.32

[PATCH] D117246: [OpenMP] Add support for linking AMDGPU images

jhuber6 added inline comments. Comment at: clang/lib/Driver/ToolChains/AMDGPUOpenMP.cpp:297 + +std::string Arch = DAL->getLastArgValue(options::OPT_march_EQ).str(); +if (Arch.empty()) { JonChesterfield wrote: > This part is valuable as-is and probably ind

[clang-tools-extra] a4bdeb9 - [clang-tidy][NFC] replace some redundant std::string creations

Author: Nathan James Date: 2022-01-19T18:36:35Z New Revision: a4bdeb9a563475fd989d97138971895f606f45d3 URL: https://github.com/llvm/llvm-project/commit/a4bdeb9a563475fd989d97138971895f606f45d3 DIFF: https://github.com/llvm/llvm-project/commit/a4bdeb9a563475fd989d97138971895f606f45d3.diff LOG:

[PATCH] D116386: [clang-tidy] Narrow cppguidelines-macro-usage to actual constants

LegalizeAdulthood marked 2 inline comments as done. LegalizeAdulthood added inline comments. Comment at: clang-tools-extra/clang-tidy/cppcoreguidelines/MacroUsageCheck.cpp:23 -namespace { - -bool isCapsOnly(StringRef Name) { - return std::all_of(Name.begin(), Name.end(), [](c

[PATCH] D116386: [clang-tidy] Narrow cppguidelines-macro-usage to actual constants

LegalizeAdulthood marked 3 inline comments as done. LegalizeAdulthood added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/cppcoreguidelines-macro-usage.rst:11 +`ES.31

[PATCH] D116155: [clang][AST][ASTImporter] Set record to complete during import of its members.

teemperor added a comment. I'm really sorry @martong , but I no longer work on LLDB (or the ASTImporter) and I'm not really in the loop regarding LLDB development. (Having said that, I still happy to answer questions about my own patches/reviews that I did in the past in case there are question

[PATCH] D117706: [openmp] Unconditionally set march commandline argument

JonChesterfield created this revision. JonChesterfield added a reviewer: jhuber6. Herald added subscribers: kerbowa, guansong, tpr, yaxunl, nhaehnle, jvesely. JonChesterfield requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: cfe-commits, sstefan1. Hera

[PATCH] D113837: Sema: Let InitListExpr have dependent type instead of 'void'

aaron.ballman added a comment. FWIW, I think this direction seems reasonable to me. Before semantic analysis, we can't know the type, it depends on the context that we haven't analyzed yet. However, I'd ultimately like to hear from @rsmith just in case I am missing some concerns with the change

[PATCH] D117706: [openmp] Unconditionally set march commandline argument

jhuber6 accepted this revision. jhuber6 added a comment. This revision is now accepted and ready to land. LGTM, with this you should be able to replace calls for the AMDGPU arch with querying the ToolChain args, e.g. `TCArgs.getLastArgValue(options::OPT_march_EQ)` Repository: rG LLVM Github

[clang] a9935b5 - [openmp] Unconditionally set march commandline argument

Author: Joseph Huber Date: 2022-01-19T19:14:47Z New Revision: a9935b5db706c89182fa3a3e10f30237fb6c4ec5 URL: https://github.com/llvm/llvm-project/commit/a9935b5db706c89182fa3a3e10f30237fb6c4ec5 DIFF: https://github.com/llvm/llvm-project/commit/a9935b5db706c89182fa3a3e10f30237fb6c4ec5.diff LOG:

[PATCH] D117706: [openmp] Unconditionally set march commandline argument

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa9935b5db706: [openmp] Unconditionally set march commandline argument (authored by jhuber6, committed by JonChesterfield). Repository: rG LLVM Git

[PATCH] D117706: [openmp] Unconditionally set march commandline argument

JonChesterfield added a comment. Landed with you as author and me as reviewer as that seems a more accurate statement than the default. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117706/new/ https://reviews.llvm.org/D117706 ___

[PATCH] D117049: [OpenMP] Add support for embedding bitcode images in wrapper tool

saiislam added a comment. It seems that this patch along with D117156 and D117246 is giving `patch application failed` error [https://buildkite.com/llvm-project/diff-checks/builds/82688]. `arc patch` is also giving the same er

[PATCH] D117049: [OpenMP] Add support for embedding bitcode images in wrapper tool

jhuber6 added a comment. In D117049#3255748 , @saiislam wrote: > It seems that this patch along with D117156 > and D117246 > is giving `patch application failed` error > [https://bui

[clang-tools-extra] d83ecd7 - [clang-tidy] Narrow cppguidelines-macro-usage to actual constants

Author: Richard Date: 2022-01-19T12:28:22-07:00 New Revision: d83ecd77cc0f16cb5fbabe03d37829893ac8b56d URL: https://github.com/llvm/llvm-project/commit/d83ecd77cc0f16cb5fbabe03d37829893ac8b56d DIFF: https://github.com/llvm/llvm-project/commit/d83ecd77cc0f16cb5fbabe03d37829893ac8b56d.diff LOG:

[PATCH] D116386: [clang-tidy] Narrow cppguidelines-macro-usage to actual constants

This revision was automatically updated to reflect the committed changes. LegalizeAdulthood marked an inline comment as done. Closed by commit rGd83ecd77cc0f: [clang-tidy] Narrow cppguidelines-macro-usage to actual constants (authored by LegalizeAdulthood). Changed prior to commit: https://revi

[PATCH] D112408: [RISCV] Add the zve extension according to the v1.0 spec

craig.topper added inline comments. Comment at: llvm/lib/Target/RISCV/RISCV.td:186 + "with maximal 32 EEW and F extension)", + [FeatureStdExtZve32x, FeatureStdExtF]>; +def HasStdExtZve32f : Predicate<"SubTarget->hasStdExtZve32f()">; ---

[PATCH] D117634: [OpenMP] Expand short verisions of OpenMP offloading triples

jhuber6 updated this revision to Diff 401357. jhuber6 edited the summary of this revision. jhuber6 added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Changing approach to simply expand the triple where we parse it for OpenMP. Repository: rG LLVM Github Mono

[PATCH] D114732: [clang] Mark `trivial_abi` types as "trivially relocatable".

devin.jeanpierre updated this revision to Diff 401358. devin.jeanpierre added a comment. Clarify Windows comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114732/new/ https://reviews.llvm.org/D114732 Files: clang/docs/LanguageExtensions.rs

[PATCH] D117520: [clang-format] Fix SeparateDefinitionBlocks issues

MyDeveloperDay added a comment. Works nicely now... LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117520/new/ https://reviews.llvm.org/D117520 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailma

[PATCH] D114732: [clang] Mark `trivial_abi` types as "trivially relocatable".

devin.jeanpierre added a comment. CI test finished successfully before windows setup did 😢. My workplace's Windows VMs are a bit hosed at the moment... In D114732#3253416 , @Quuxplusone wrote: > In D114732#3253142

[PATCH] D117520: [clang-format] Fix SeparateDefinitionBlocks issues

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/DefinitionBlockSeparator.cpp:120 const auto MayPrecedeDefinition = [&](const int Direction = -1) { + assert(Direction >= -1 && Direction <= 1); const size_t OperateIndex = OpeningLineIndex + D

[PATCH] D105169: [Clang/Test]: Rename enable_noundef_analysis to disable-noundef-analysis and turn it off by default

fhahn added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:2535 ArgAttrs[FirstIRArg + i] = llvm::AttributeSet::get(getLLVMContext(), Attrs); } nlopes wrote: > ab wrote: > > Hmm, if I'm reading this right, this overwrites the

[PATCH] D114439: [Annotation] Allow parameter pack expansions in annotate attribute

aaron.ballman added a comment. Thanks for this, I think it's shaping up well! Comment at: clang/include/clang/Basic/DiagnosticParseKinds.td:723 +def err_attribute_argument_parm_pack_not_supported : Error< + "attribute %0 does not support pack expansion in arguments">; +def err

[PATCH] D117613: [ASTMatchers] Add `isConsteval` matcher

Izaron updated this revision to Diff 401363. Izaron added a comment. Fixed commit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117613/new/ https://reviews.llvm.org/D117613 Files: clang/docs/LibASTMatchersReference.html clang/include/clang/AST

[PATCH] D117520: [clang-format] Fix SeparateDefinitionBlocks issues

ksyx added inline comments. Comment at: clang/lib/Format/DefinitionBlockSeparator.cpp:134 + OperateIndex + 1 < Lines.size()) { +// UnwrappedLineParser's recognition of free-standing macro like +// Q_OBJECT may also recognize some uppercased type names tha

[PATCH] D117613: [ASTMatchers] Add `isConsteval` matcher

Izaron updated this revision to Diff 401365. Izaron added a comment. Fixed commit (with clang-format) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117613/new/ https://reviews.llvm.org/D117613 Files: clang/docs/LibASTMatchersReference.html cla

[PATCH] D117613: [ASTMatchers] Add `isConsteval` matcher

Izaron marked 4 inline comments as done. Izaron added inline comments. Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:5179 +/// consteval int bar(); +/// void baz() { if consteval {} } +/// \endcode aaron.ballman wrote: > It'd be good to show an ex

[PATCH] D117634: [OpenMP] Expand short verisions of OpenMP offloading triples

JonChesterfield accepted this revision. JonChesterfield added a comment. This revision is now accepted and ready to land. LG, thanks! Comment at: clang/lib/Driver/Driver.cpp:778 + // We want to normalize the shortened versions of triples passed in to + // the

[PATCH] D114732: [clang] Mark `trivial_abi` types as "trivially relocatable".

Quuxplusone added inline comments. Comment at: clang/test/SemaCXX/attr-trivial-abi.cpp:9-11 +// On Windows, trivial relocatability depends only on a trivial copy constructor existing. +// In this case, it is implicitly deleted. Similar concerns apply to later tests. +static_ass

[PATCH] D114732: [clang] Mark `trivial_abi` types as "trivially relocatable".

devin.jeanpierre added a comment. Sorry, I missed your other comments. Let me know if there's anything else I didn't address. Comment at: clang/test/SemaCXX/attr-trivial-abi.cpp:146 +#ifdef _WIN32 +static_assert(!__is_trivially_relocatable(CopyDeleted), ""); +#else ---

[PATCH] D114732: [clang] Mark `trivial_abi` types as "trivially relocatable".

devin.jeanpierre updated this revision to Diff 401379. devin.jeanpierre added a comment. Fix copy-paste error. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114732/new/ https://reviews.llvm.org/D114732 Files: clang/docs/LanguageExtensions.rst

[PATCH] D70549: [OPENMP]Fix PR41826: symbols visibility in device code.

JonChesterfield added subscribers: jhuber6, JonChesterfield. JonChesterfield added a comment. Herald added subscribers: asavonic, sstefan1, yaxunl. @ABataev @jhuber6 and I would like to change this to annotate variables with whatever visibility the user asked for. Can you recall if the concern a

[PATCH] D117717: [clang] Ignore -fconserve-stack

nathanchance created this revision. nathanchance added reviewers: aaron.ballman, MaskRay, srhines. Herald added a subscriber: dang. nathanchance requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This flag is used when building the Linux kerne

[PATCH] D114732: [clang] Mark `trivial_abi` types as "trivially relocatable".

devin.jeanpierre added a comment. In D114732#3256046 , @devin.jeanpierre wrote: > Sorry, I missed your other comments. Let me know if there's anything else I > didn't address. I just noticed that there's a "Done" checkbox next to each comment, and it

[PATCH] D70549: [OPENMP]Fix PR41826: symbols visibility in device code.

ABataev added a comment. In D70549#3256063 , @JonChesterfield wrote: > @ABataev @jhuber6 and I would like to change this to annotate variables with > whatever visibility the user asked for. > > Can you recall if the concern about premption here was for t

[PATCH] D114966: [clang][deps] Split stat and file content caches

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114966/new/ https://reviews.llvm.org/D114966 __

[PATCH] D117348: [Preprocessor] Reduce the memory overhead of `#define` directives

dexonsmith added inline comments. Comment at: clang/lib/Lex/MacroInfo.cpp:33 + +// MacroInfo is expected to take 40 bytes on platforms with an 8 byte pointer. +template class MacroInfoSizeChecker { aaron.ballman wrote: > dexonsmith wrote: > > aaron.ballman wrote

[PATCH] D117717: [clang] Ignore -fconserve-stack

MaskRay added a comment. Clang has a long list of ignored options but most were added during the catch-up phase when Clang strove to be a competitor compiler. I think for new ignored options there needs to be some higher standard. From Debian Code Search https://codesearch.debian.net/search?q=fc

[PATCH] D117717: [clang] Ignore -fconserve-stack

nathanchance added a comment. In D117717#3256180 , @MaskRay wrote: > Clang has a long list of ignored options but most were added during the > catch-up phase when Clang strove to be a competitor compiler. > I think for new ignored options there needs to

[libunwind] 429a717 - [cmake] Move HandleOutOfTreeLLVM to common cmake utils

Author: John Ericson Date: 2022-01-19T22:05:23Z New Revision: 429a717ea5ec141b5c0c93c2c53097dccf67e05a URL: https://github.com/llvm/llvm-project/commit/429a717ea5ec141b5c0c93c2c53097dccf67e05a DIFF: https://github.com/llvm/llvm-project/commit/429a717ea5ec141b5c0c93c2c53097dccf67e05a.diff LOG:

[PATCH] D114732: [clang] Mark `trivial_abi` types as "trivially relocatable".

rsmith added inline comments. Comment at: clang/test/SemaCXX/attr-trivial-abi.cpp:9-11 +// On Windows, trivial relocatability depends only on a trivial copy constructor existing. +// In this case, it is implicitly deleted. Similar concerns apply to later tests. +static_assert(!

[PATCH] D117717: [clang] Ignore -fconserve-stack

MaskRay added a comment. Assuming scan-build is clang/tools/scan-build, which is in tree and can be fixed instead. I am not familiar with it, but from > However, this caused issues with scan-build, as GCC is used as the compiler > but clang is invoked after it with all the -f options that GCC w

[clang-tools-extra] 058d212 - [clang-tidy] Use literal block instead of code block (NFC)

Author: Richard Date: 2022-01-19T15:23:48-07:00 New Revision: 058d2123792da54ae7460fea0946d2c90a032e1c URL: https://github.com/llvm/llvm-project/commit/058d2123792da54ae7460fea0946d2c90a032e1c DIFF: https://github.com/llvm/llvm-project/commit/058d2123792da54ae7460fea0946d2c90a032e1c.diff LOG:

[PATCH] D116786: [clangd] Add designator inlay hints for initializer lists.

sammccall updated this revision to Diff 401410. sammccall marked 8 inline comments as done. sammccall added a comment. Address comments, rebase. This category is *off* by default. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116786/new/ https://re

[PATCH] D116786: [clangd] Add designator inlay hints for initializer lists.

sammccall added a comment. In D116786#3247800 , @kadircet wrote: > a drive by concern around possible flakiness of the interaction. have you > checked how does it look like when the user is still forming the initializer? > it might be annoying if their

[PATCH] D117522: [clang-tidy] Add modernize-macro-to-enum check

LegalizeAdulthood updated this revision to Diff 401414. LegalizeAdulthood added a comment. - Tweak documentation, make sure sphinx runs without errors CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117522/new/ https://reviews.llvm.org/D117522 Files: clang-tools-extra/clang-tidy/modern

[PATCH] D117569: Constexpr not supported with __declspec(dllimport).

zahiraam updated this revision to Diff 401415. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117569/new/ https://reviews.llvm.org/D117569 Files: clang/lib/AST/ExprConstant.cpp clang/test/CodeGenCXX/PR19955.cpp clang/test/CodeGenCXX/dllimport.cpp clang/test/SemaCXX/PR19955.cpp c

[PATCH] D117717: [clang] Ignore -fconserve-stack

nathanchance added a comment. In D117717#3256293 , @MaskRay wrote: > Assuming scan-build is clang/tools/scan-build, which is in tree and can be > fixed instead. Yes, that is the one. > I am not familiar with it, but from > >> However, this caused issue

[PATCH] D114732: [clang] Mark `trivial_abi` types as "trivially relocatable".

devin.jeanpierre updated this revision to Diff 401419. devin.jeanpierre added a comment. pull/rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114732/new/ https://reviews.llvm.org/D114732 Files: clang/docs/LanguageExtensions.rst clang/incl

[PATCH] D117647: [RISCV] Add destination operand for RVV nomask load intrinsics.

craig.topper added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVISelDAGToDAG.cpp:1238 unsigned CurOp = 2; + bool IsTU = false; + if ((IntNo != Intrinsic::riscv_vlm && ``` bool IsTU = IntNo != Intrinsic::riscv_vlm && (!Node->getOperand

[PATCH] D117056: [clangd] Properly compute framework-style include spelling

dgoldman updated this revision to Diff 401422. dgoldman marked 18 inline comments as done. dgoldman added a comment. Changes for review Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117056/new/ https://reviews.llvm.org/D117056 Files: clang-tools

[PATCH] D117056: [clangd] Properly compute framework-style include spelling

dgoldman added inline comments. Comment at: clang-tools-extra/clangd/index/SymbolCollector.cpp:295 +if (!R.second && !R.first->second.empty()) { + // Framework has known umbrella spelling, cache it for this header as + // well. sammccall wrote: > Wh

[PATCH] D117681: [RISCV] Add the policy operand for some masked RVV ternary IR intrinsics.

craig.topper added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVInstrInfoVPseudos.td:2187 +multiclass VPseudoTernaryNoMaskNoPolicyhttps://reviews.llvm.org/D117681/new/ https://reviews.llvm.org/D117681 ___ cfe-commits mailin

[PATCH] D117724: [RISCV] Remove Zvlsseg extension.

khchen added inline comments. Comment at: llvm/test/MC/RISCV/rvv/zvlsseg.s:11 # RUN: llvm-mc -triple=riscv64 -filetype=obj --mattr=+experimental-v \ # RUN: --mattr=+experimental-zvlsseg %s \ # RUN: | llvm-objdump -d - | FileCheck %s --check-prefix=CHECK-UNKNOWN ---

[PATCH] D114732: [clang] Mark `trivial_abi` types as "trivially relocatable".

devin.jeanpierre added a comment. @rsmith I've pulled+rebased again to avoid the (looks like pre-existing) failure. Copy-pasting the wording on https://llvm.org/docs/MyFirstTypoFix.html#commit-by-proxy: I don’t have commit access, can you land this patch for me? Please use “Devin Jeanpierre je

[PATCH] D117724: [RISCV] Remove Zvlsseg extension.

craig.topper added inline comments. Comment at: llvm/test/MC/RISCV/rvv/zvlsseg.s:11 # RUN: llvm-mc -triple=riscv64 -filetype=obj --mattr=+experimental-v \ # RUN: --mattr=+experimental-zvlsseg %s \ # RUN: | llvm-objdump -d - | FileCheck %s --check-prefix=CHECK-UNKNOWN -

[PATCH] D117056: [clangd] Properly compute framework-style include spelling

dgoldman added inline comments. Comment at: clang/lib/Lex/HeaderSearch.cpp:1052 HFI.IndexHeaderMapHeader = 1; +} else if (CurDir->isFramework()) { + size_t SlashPos = Filename.find('/'); sammccall wrote: > This looks like a separate change, and

[PATCH] D116385: [clangd] Code action for creating an ObjC initializer

dgoldman added a comment. PTAL, let me know what you think regarding the edits, had to make sure it works even if we generate multiple edits in the same file. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116385/new/ https://reviews.llvm.org/D1163

[PATCH] D117056: [clangd] Properly compute framework-style include spelling

sammccall added a comment. This looks good now, only blocker is dropping the change to LookupFile somehow. Is it valuable to land this before the imminent 14 branch cut? I think it's OK but as an indexing change a crash has the possibility to be really disruptive, and most of the rest of us are

[PATCH] D117730: [DNM][VFS] Do not overwrite the path when nesting RedirectingFileSystems

bnbarham created this revision. Herald added subscribers: dexonsmith, hiraditya. bnbarham requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. 86e2af8043c7728710a711b623f27425801a36c3

[PATCH] D80833: [CodeView] Add full repro to LF_BUILDINFO record

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGaba5b91b699c: Re-land [CodeView] Add full repro to LF_BUILDINFO record (authored by aganea). Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[clang] aba5b91 - Re-land [CodeView] Add full repro to LF_BUILDINFO record

Author: Alexandre Ganea Date: 2022-01-19T19:44:37-05:00 New Revision: aba5b91b699c556da0ee04418321b581bd33611e URL: https://github.com/llvm/llvm-project/commit/aba5b91b699c556da0ee04418321b581bd33611e DIFF: https://github.com/llvm/llvm-project/commit/aba5b91b699c556da0ee04418321b581bd33611e.dif

[PATCH] D117520: [clang-format] Fix SeparateDefinitionBlocks issues

ksyx updated this revision to Diff 401445. ksyx marked an inline comment as done. ksyx added a comment. - Apply suggestions from clangfmt - Split assertion conditions CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117520/new/ https://reviews.llvm.org/D117520 Files: clang/lib/Format/De

[PATCH] D117647: [RISCV] Add destination operand for RVV nomask load intrinsics.

khchen updated this revision to Diff 401446. khchen added a comment. Address Craig's comments, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117647/new/ https://reviews.llvm.org/D117647 Files: clang/include/clang/Basic/riscv_vector.td

[PATCH] D117681: [RISCV] Add the policy operand for some masked RVV ternary IR intrinsics.

khchen updated this revision to Diff 401447. khchen added a comment. Address Craig's comment. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117681/new/ https://reviews.llvm.org/D117681 Files: clang/include/clang/Basic/riscv_vector.td c

[clang] 28d7186 - [OpenMP] Expand short verisions of OpenMP offloading triples

Author: Joseph Huber Date: 2022-01-19T20:26:37-05:00 New Revision: 28d718602ad2bddbfcb445fff46bcbbdd0788471 URL: https://github.com/llvm/llvm-project/commit/28d718602ad2bddbfcb445fff46bcbbdd0788471 DIFF: https://github.com/llvm/llvm-project/commit/28d718602ad2bddbfcb445fff46bcbbdd0788471.diff

[PATCH] D117634: [OpenMP] Expand short verisions of OpenMP offloading triples

This revision was automatically updated to reflect the committed changes. Closed by commit rG28d718602ad2: [OpenMP] Expand short verisions of OpenMP offloading triples (authored by jhuber6). Changed prior to commit: https://reviews.llvm.org/D117634?vs=401357&id=401454#toc Repository: rG LLVM

[PATCH] D112903: [C++20] [Module] Fix bug47116 and implement [module.interface]/p6

ChuanqiXu added a comment. @aaron.ballman @urnathan gentle ping~ CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112903/new/ https://reviews.llvm.org/D112903 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin

[PATCH] D117520: [clang-format] Fix SeparateDefinitionBlocks issues

ksyx updated this revision to Diff 401460. ksyx added a comment. Apply suggestion from clangfmt CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117520/new/ https://reviews.llvm.org/D117520 Files: clang/lib/Format/DefinitionBlockSeparator.cpp clang/lib/Format/DefinitionBlockSeparator.

[PATCH] D115610: [C++20] [Modules] Don't create multiple global module fragment

ChuanqiXu added a comment. @rsmith gentle ping~ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115610/new/ https://reviews.llvm.org/D115610 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://

[PATCH] D115867: [C++20] [Coroutines] Warning for always_inline coroutine

ChuanqiXu added a comment. @Quuxplusone @aaron.ballman gentle ping~ CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115867/new/ https://reviews.llvm.org/D115867 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-

[PATCH] D117087: [C++20] [Coroutines] Implement return value optimization for get_return_object

ChuanqiXu added a comment. gentle ping~ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117087/new/ https://reviews.llvm.org/D117087 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.ll

[PATCH] D117137: [Driver] Add CUDA support for --offline param

dcastagna updated this revision to Diff 401461. dcastagna retitled this revision from "[Driver] Add a flag cuda-device-triple" to "[Driver] Add CUDA support for --offline param". dcastagna edited the summary of this revision. dcastagna added a comment. Using already existing --offload parameters

[PATCH] D117137: [Driver] Add CUDA support for --offline param

dcastagna added a comment. In D117137#3238275 , @tra wrote: > I think instead of setting the triple directly from the command line, we > should start with adding another `--cuda-gpu-arch` (AKA --offload-arch) > variant and derive the triple and other p

[PATCH] D117246: [OpenMP] Add support for linking AMDGPU images

jhuber6 updated this revision to Diff 401466. jhuber6 added a comment. Updating after upstreaming a portion of this patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117246/new/ https://reviews.llvm.org/D117246 Files: clang/tools/clang-linker

[PATCH] D117468: [RISCV] Add intrinsic for Zbt extension

Chenbing.Zheng updated this revision to Diff 401468. Chenbing.Zheng added a comment. modify tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117468/new/ https://reviews.llvm.org/D117468 Files: clang/include/clang/Basic/BuiltinsRISCV.def cla

[PATCH] D117468: [RISCV] Add intrinsic for Zbt extension

Chenbing.Zheng marked 8 inline comments as done. Chenbing.Zheng added a comment. In D117468#3255546 , @craig.topper wrote: > In D117468#3253879 , > @Chenbing.Zheng wrote: > >> In D117468#3253493

[PATCH] D117724: [RISCV] Remove Zvlsseg extension.

kito-cheng added a comment. Few more grep result (by `grep zvlsseg * -Rin`), I think should remove: clang/include/clang/Basic/riscv_vector.td:218: // Sub extension of vector spec. Currently only support Zvlsseg. clang/include/clang/Basic/riscv_vector.td:221: // Number of fields for Zvlss

[PATCH] D107450: [clang-tidy] Fix wrong FixIt in performance-move-const-arg

Sockke updated this revision to Diff 401470. Sockke added a comment. Improve some description. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107450/new/ https://reviews.llvm.org/D107450 Files: clang-tools-extra/clang-tidy/performance/MoveConstArgCheck.cpp clang-tools-extra/clang-ti

[PATCH] D117740: [NFC][clang] Simplify `isOneOf` function

achieveartificialintelligence created this revision. achieveartificialintelligence added reviewers: alexfh, danielmarjamaki. achieveartificialintelligence requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo

[PATCH] D93298: [RISCV] add the MC layer support of Zfinx extension

achieveartificialintelligence added a comment. Ping. Any other suggestions? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93298/new/ https://reviews.llvm.org/D93298 ___ cfe-commits mailing list cfe-commi

[PATCH] D110663: [Driver] Support Debian multiarch style lib/clang/14.0.0/x86_64-linux-gnu runtime path and include/x86_64-linux-gnu/c++/v1 libc++ path

MaskRay added a comment. Ping:) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110663/new/ https://reviews.llvm.org/D110663 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/c

[PATCH] D117724: [RISCV] Remove Zvlsseg extension.

eopXD added a comment. Thank you for doing this patch, I was about to do it after I land zve. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117724/new/ https://reviews.llvm.org/D117724 ___ cfe-commits ma

[PATCH] D116015: [PowerPC] Add generic fnmsub intrinsic

qiucf added a comment. In D116015#3203067 , @nemanjai wrote: > Converting more generic code to target-specific intrinsics is sometimes > necessary to ensure the generic IR doesn't get transformed in a way that is > disadvantageous. I believe that the de

[PATCH] D115848: tidy-llvm

beanz added a comment. Sorry I’m a bit late here. If you want to use clang-tidy on a CMake built project (like LLVM) you can use CMake’s built-in support for clang-tidy: https://cmake.org/cmake/help/latest/variable/CMAKE_LANG_CLANG_TIDY.html This will run clang-tidy during the project build wit

[PATCH] D117744: [Driver] Remove obsoleted -gz=zlib-gnu

MaskRay created this revision. MaskRay added reviewers: compnerd, yaxunl. Herald added subscribers: dang, jvesely. Herald added a reviewer: ctetreau. MaskRay requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. GCC added -gz=zlib-gnu in 2014 for

[PATCH] D117744: [Driver] Remove obsoleted -gz=zlib-gnu

MaskRay updated this revision to Diff 401498. MaskRay added a comment. fix a comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117744/new/ https://reviews.llvm.org/D117744 Files: clang/include/clang/Driver/Options.td clang/lib/Driver/ToolC

[PATCH] D117746: [CMake] Pass CMAKE_C/CXX_COMPILER_LAUNCHER down to cross-compile and runtime build

ychen created this revision. ychen added a reviewer: dexonsmith. Herald added a subscriber: mgorny. ychen requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Similar to D59032 . Repository:

[clang] 6f2ee1c - [OpenMP][AMDGPU] Optimize the linked in math libraries

Author: Johannes Doerfert Date: 2022-01-19T23:36:36-06:00 New Revision: 6f2ee1ca5e39b4286f7eb1aeb63b408f952f93c9 URL: https://github.com/llvm/llvm-project/commit/6f2ee1ca5e39b4286f7eb1aeb63b408f952f93c9 DIFF: https://github.com/llvm/llvm-project/commit/6f2ee1ca5e39b4286f7eb1aeb63b408f952f93c9.d

[PATCH] D116906: [OpenMP][AMDGPU] Optimize the linked in math libraries

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6f2ee1ca5e39: [OpenMP][AMDGPU] Optimize the linked in math libraries (authored by jdoerfert). Repository: rG LLVM Github Monorepo CHANGES SINCE L

[PATCH] D117569: Constexpr not supported with __declspec(dllimport).

majnemer requested changes to this revision. majnemer added a comment. This revision now requires changes to proceed. I have a question regarding how this work with respect to the dllimport semantics known by the linker. IIUC, we will now allow a program like: extern int __declspec(dllimport)

[PATCH] D117569: Constexpr not supported with __declspec(dllimport).

majnemer added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:2219 + Info.getLangOpts().CPlusPlus && !isForManglingOnly(Kind) && + Var->hasAttr()) // FIXME: Diagnostic! The summary and the bug both mention dllimport but

[PATCH] D112408: [RISCV] Add the zve extension according to the v1.0 spec

craig.topper added inline comments. Comment at: llvm/lib/Support/RISCVISAInfo.cpp:744 static const char *ImpliedExtsZfh[] = {"zfhmin"}; +static const char *ImpliedExtsZve64d[] = {"zve64f", "d"}; +static const char *ImpliedExtsZve64f[] = {"zve64x", "zve32f"}; I t

<    1   2   3   >