[PATCH] D117416: [clang-format] Handle C variables with name that matches c++ access specifier

MyDeveloperDay added a comment. I actually thought you were on the right lines with your change to parseAccessSpecifier() surely if you see "private:" "public:" or "protected:" but not `public::` that's when you call parseAccessSpecifier() I think mostly I believe clang-format is a 96% done de

[PATCH] D117407: [clang] Add include path for cppwinrt on Windows SDK 10.0.17134+

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9c195bae31c4: [clang] Add include path for cppwinrt on Windows SDK 10.0.17134+ (authored by saschanaz, committed by hans). Repository: rG LLVM Git

[clang] 9c195ba - [clang] Add include path for cppwinrt on Windows SDK 10.0.17134+

Author: Kagami Sascha Rosylight Date: 2022-01-18T09:14:23+01:00 New Revision: 9c195bae31c4eefc3e5360cefb4f601388a4f6d9 URL: https://github.com/llvm/llvm-project/commit/9c195bae31c4eefc3e5360cefb4f601388a4f6d9 DIFF: https://github.com/llvm/llvm-project/commit/9c195bae31c4eefc3e5360cefb4f601388a4

[PATCH] D117416: [clang-format] Handle C variables with name that matches c++ access specifier

MyDeveloperDay added a comment. For me the push back on the second language and having to pass it on the command line for the .h case is about VS Code, Vim, Visual Studio, Emacs having to recognize what language they are in and having to pass the -language=XXX flag, now we are pushing the inte

[PATCH] D117500: [clang] Mention MS on-demand TLS initialization in release notes

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117500/new/ https://reviews.llvm.org/D117500 ___ cfe

[PATCH] D116216: Prevent adding module flag - amdgpu_hostcall multiple times.

pvellien updated this revision to Diff 400750. pvellien added a comment. Removed amdgpu-asan-noprintf.cu and added amdgpu-asan-printf.cu testcase. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116216/new/ https://reviews.llvm.org/D116216 Files: clang/lib/CodeGen/CodeGenModule.cpp c

[PATCH] D117491: [clangd] Remove redundant check for renamed symbol origin

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. Thanks for the cleanup! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117491/new/ https://reviews.llvm.org/D117491

[PATCH] D117416: [clang-format] Handle C variables with name that matches c++ access specifier

MyDeveloperDay added a comment. Isn't the reality that developers using `delete/new/try/catch/interface/public/protected/private/async/var/let` as variables the real problem? I'm slightly averse to pandering to them, and I definitely don't want to make my world more complex just to accommodate

[PATCH] D117520: [clang-format] Fix SeparateDefinitionBlocks issues

MyDeveloperDay added inline comments. Comment at: clang/lib/Format/DefinitionBlockSeparator.cpp:44 + if (CurrentToken->isOneOf(tok::kw_class, tok::kw_struct) || (Style.isJavaScript() && CurrentToken->TokenText == "function")) return true;

[PATCH] D117398: [clang-format] Fix bug in parsing `operator<` with template

curdeius accepted this revision. curdeius added a comment. This revision is now accepted and ready to land. LGTM. Thanks for working on this! Do you have commit rights or do you need that someone lands it for you? If you need help, please indicate your name and email to be used for the commit. A

[PATCH] D117398: [clang-format] Fix bug in parsing `operator<` with template

MyDeveloperDay requested changes to this revision. MyDeveloperDay added inline comments. This revision now requires changes to proceed. Comment at: clang/unittests/Format/FormatTest.cpp:9468 "typename ();"); verifyFormat("auto aa

[PATCH] D117398: [clang-format] Fix bug in parsing `operator<` with template

MyDeveloperDay added a comment. run git clang-format before submitting (if making the patch from staged files) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117398/new/ https://reviews.llvm.org/D117398 ___ cfe-commits mailing list cfe-commits

[clang-tools-extra] 2d9198c - [clangd] Remove redundant check for renamed symbol origin

Author: Kirill Bobyrev Date: 2022-01-18T09:43:53+01:00 New Revision: 2d9198cec994b91fc13ef6cdd6983c61aaa1f726 URL: https://github.com/llvm/llvm-project/commit/2d9198cec994b91fc13ef6cdd6983c61aaa1f726 DIFF: https://github.com/llvm/llvm-project/commit/2d9198cec994b91fc13ef6cdd6983c61aaa1f726.diff

[PATCH] D117491: [clangd] Remove redundant check for renamed symbol origin

This revision was automatically updated to reflect the committed changes. Closed by commit rG2d9198cec994: [clangd] Remove redundant check for renamed symbol origin (authored by kbobyrev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117491/new/ ht

[PATCH] D117416: [clang-format] Handle C variables with name that matches c++ access specifier

curdeius added a comment. As MyDeveloperDay justly pointed out, adding a new language enum LK_C doesn't seem to be the way to go, as you mostly duplicate all the conditions (probably missing some of them). For the usability, it would be really painful to specify the language for each file that

[PATCH] D117421: [clang-format] Fix incorrect alignment of operator= overloads.

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. I think this LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117421/new/ https://reviews.llvm.org/D117421 ___ cfe-commits mailing

[PATCH] D117472: [clangd] Bring back early-claim approach to fix a selection-tree regression.

hokein updated this revision to Diff 400763. hokein added a comment. refine the comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117472/new/ https://reviews.llvm.org/D117472 Files: clang-tools-extra/clangd/Selection.cpp clang-tools-extra

[PATCH] D117416: [clang-format] Handle C variables with name that matches c++ access specifier

MyDeveloperDay added inline comments. Comment at: .arclint:15-16 } -} +} \ No newline at end of file curdeius wrote: > Please don't change unrelated files. I don't know about others but I personally don't use arcanist... I stage my files, make a patch and up

[PATCH] D117472: [clangd] Bring back early-claim approach to fix a selection-tree regression.

hokein marked an inline comment as done. hokein added inline comments. Comment at: clang-tools-extra/clangd/Selection.cpp:758 + // ranges of children are not overlapped with their parent's. + // But there are some AST-weird cases, e.g. + //auto fun = [bar = foo

[clang-tools-extra] fd598e1 - [clangd] Bring back early-claim approach to fix a selection-tree regression.

Author: Haojian Wu Date: 2022-01-18T10:22:26+01:00 New Revision: fd598e185972f76a50c45e1402ab3b0fd70664b9 URL: https://github.com/llvm/llvm-project/commit/fd598e185972f76a50c45e1402ab3b0fd70664b9 DIFF: https://github.com/llvm/llvm-project/commit/fd598e185972f76a50c45e1402ab3b0fd70664b9.diff LO

[PATCH] D117472: [clangd] Bring back early-claim approach to fix a selection-tree regression.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. hokein marked an inline comment as done. Closed by commit rGfd598e185972: [clangd] Bring back early-claim approach to fix a selection-tree regression. (authored by hoke

[PATCH] D117398: [clang-format] Fix bug in parsing `operator<` with template

owenpan added inline comments. Comment at: clang/lib/Format/FormatTokenLexer.cpp:433-446 bool FourthTokenIsLess = false; - if (Tokens.size() > 3) -FourthTokenIsLess = (Tokens.end() - 4)[0]->is(tok::less); - auto First = Tokens.end() - 3; + if (Tokens.size() > 3) { +

[PATCH] D117468: [RISCV] Add intrinsic for Zbt extension

Chenbing.Zheng updated this revision to Diff 400768. Chenbing.Zheng edited the summary of this revision. Chenbing.Zheng added a comment. del cmov，cmix，fsri in clang Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117468/new/ https://reviews.llvm.or

[PATCH] D117468: [RISCV] Add intrinsic for Zbt extension

Chenbing.Zheng marked 2 inline comments as done. Chenbing.Zheng added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVInstrInfoZb.td:907 (FSR GPR:$rs1, GPR:$rs2, GPR:$rs3)>; +def : Pat<(riscv_fsr GPR:$rs3, GPR:$rs1, uimmlog2xlen:$shamt), + (FSRI GPR:$r

[PATCH] D117520: [clang-format] Fix SeparateDefinitionBlocks issues

curdeius added a comment. Could you explain more in details the before/after of the fixed bugs, please? The best would be to develop the patch description. Comment at: clang/lib/Format/DefinitionBlockSeparator.cpp:37 + auto LikelyDefinition = [this](const AnnotatedLine *Line,

[PATCH] D117416: [clang-format] Handle C variables with name that matches c++ access specifier

curdeius added inline comments. Comment at: .arclint:15-16 } -} +} \ No newline at end of file MyDeveloperDay wrote: > curdeius wrote: > > Please don't change unrelated files. > I don't know about others but I personally don't use arcanist... > > I stage my

[PATCH] D117549: [clangd] Sort targets before printing for tests

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: usaxena95, arphaman, mgrang. kadircet requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Targets are not necessa

[PATCH] D114837: format: Remove redundant calls to guessIsObjC to speed up clang-format on unknown file types

curdeius added a comment. I see indeed that this change fixes the superlinear complexity when formatting code from stdin: cat test.cpp | time clang-format --style=LLVM 0:01.44 == 1.44s // 9 returns 0:13.17 == 13s // 10 returns 1:56.63 == 116s // 11 returns time clang

[PATCH] D117398: [clang-format] Fix bug in parsing `operator<` with template

pjessesco updated this revision to Diff 400782. pjessesco added a comment. Fix revision after running `git clang-format`. Sorry for annoying, I thought I did not make any changes at that line. :( name : Jino Park email : pjesse...@gmail.com CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D117496: [clang][dataflow] Add transfer function for addrof

sgatev marked an inline comment as done. sgatev added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/Transfer.cpp:190 Env.setValue(Loc, Env.takeOwnership(std::make_unique( SubExprVal->getPointeeLoc(; + break; ---

[PATCH] D117535: [clang-tidy] Force LF newlines when writing files

Quuxplusone accepted this revision. Quuxplusone added a comment. This revision is now accepted and ready to land. LGTM FWIW. I might even wonder why this code is using `io.open` instead of just plain `open`. (I didn't know `io.open` was a thing; StackOverflow tells me that it was something in Py

[PATCH] D116025: [analyzer][NFC] Refactor GenericTaintChecker to use CallDescriptionMap

gamesh411 updated this revision to Diff 400790. gamesh411 added a comment. Remove explicit template keyword for MSVC compatibility Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116025/new/ https://reviews.llvm.org/D116025 Files: clang/include/cl

[PATCH] D117306: [clang-tidy] Add new check 'shared-ptr-array-mismatch'.

balazske updated this revision to Diff 400791. balazske added a comment. - Moved to bugprone module. - Introduced a common base class, it is possible to add similar check for unique_ptr. - Documentation changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[PATCH] D117306: [clang-tidy] Add new check 'shared-ptr-array-mismatch'.

balazske added a comment. Possible improvement: Add the check for `reset` too. Comment at: clang-tools-extra/test/clang-tidy/checkers/modernize-make-shared.cpp:48 void basic() { + std::shared_ptr Pt1(new int[22]); + This change was not intentional (should be

[clang] 59e031f - [clang][dataflow] Add transfer function for addrof

Author: Stanislav Gatev Date: 2022-01-18T11:23:08Z New Revision: 59e031ff9057b103c73f22bebc32304ee79fa139 URL: https://github.com/llvm/llvm-project/commit/59e031ff9057b103c73f22bebc32304ee79fa139 DIFF: https://github.com/llvm/llvm-project/commit/59e031ff9057b103c73f22bebc32304ee79fa139.diff LO

[PATCH] D117496: [clang][dataflow] Add transfer function for addrof

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. sgatev marked an inline comment as done. Closed by commit rG59e031ff9057: [clang][dataflow] Add transfer function for addrof (authored by sgatev). Repository: rG LLV

[PATCH] D116155: [clang][AST][ASTImporter] Set record to complete during import of its members.

balazske added a comment. Ping. I want to see opinion of @shafik (or others) about change of test `CompleteRecordBeforeImporting` (turn on minimal import mode in this test). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116155/new/ https://reviews

[PATCH] D117496: [clang][dataflow] Add transfer function for addrof

xazax.hun added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/Transfer.cpp:190 Env.setValue(Loc, Env.takeOwnership(std::make_unique( SubExprVal->getPointeeLoc(; + break; sgatev wrote: > xazax.hun wrote:

[PATCH] D93164: [AST] Add generator for source location introspection

andrew-wja added a comment. In D93164#3048130 , @lancethepants wrote: > In D93164#2653067 , @mgorny wrote: > >> This change breaks cross-compilation now, as it tries running an executable >> built for the target s

[PATCH] D115634: [clangd] Cleanup of readability-identifier-naming

kuhnel added a comment. Discussion in team sync, work for myself: - most changes are in unittests --> propose something for the matchers - cleaning up constants makes sense - clean up this patch, then do another round of reviews Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D112646: [clang-tidy] Add `readability-container-contains` check

avogelsgesang updated this revision to Diff 400813. avogelsgesang marked an inline comment as done. avogelsgesang added a comment. Properly support macros as requested by @xazax.hun Added test cases for +#define COUNT_ONES(SET) SET.count(1) + // CHECK-FIXES: #define COUNT_ONES(SET) SET.count(1)

[PATCH] D113898: [NFC][clangd] cleaning up llvm-qualified-auto

kuhnel added a comment. TODO: check for remaining `const` then submit. Comment at: clang-tools-extra/clangd/unittests/FileIndexTests.cpp:252 TEST(FileIndexTest, TemplateParamsInLabel) { - auto Source = R"cpp( + const auto *Source = R"cpp( template remove c

[PATCH] D112646: [clang-tidy] Add `readability-container-contains` check

xazax.hun accepted this revision. xazax.hun added a comment. This revision is now accepted and ready to land. LGTM! Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112646/new/ https://reviews.llvm.org/D112646

[PATCH] D112646: [clang-tidy] Add `readability-container-contains` check

xazax.hun added a comment. Oh wait, I think if the call is coming from a macro we still want to warn, we just want to skip the FIXIT part and leave it to the user. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112646/new/ https://reviews.llvm.org/

[PATCH] D112646: [clang-tidy] Add `readability-container-contains` check

avogelsgesang updated this revision to Diff 400820. avogelsgesang added a comment. Still warn for issues in macros even if not offering a fix-it Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112646/new/ https://reviews.llvm.org/D112646 Files: cl

[PATCH] D112646: [clang-tidy] Add `readability-container-contains` check

avogelsgesang added a comment. @xazax.hun Can you please merge this to `main` on my behalf? (I don't have commit rights) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112646/new/ https://reviews.llvm.org/D112646 __

[PATCH] D117535: [clang-tidy] Force LF newlines when writing files

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117535/new/ https://reviews.llvm.org/D117535 ___ cfe-commits mailing list

[PATCH] D116514: [clangd] Add code action to generate a constructor for a C++ class

avogelsgesang added inline comments. Comment at: clang-tools-extra/clangd/refactor/tweaks/MemberwiseConstructor.cpp:26-28 +// struct S { +// S(int x, unique_ptr y) : x(x), y(std::move(y)) {} +// }; ``` // e.g. given `struct S{ int x; unique_ptr y; };`, p

[PATCH] D117520: [clang-format] Fix SeparateDefinitionBlocks issues

ksyx updated this revision to Diff 400821. ksyx marked 3 inline comments as done. ksyx edited the summary of this revision. ksyx added a comment. - Use function keyword for JavaScript instead of comparing strings - Apply review suggestions CHANGES SINCE LAST ACTION https://reviews.llvm.org/D11

[clang] 67ac3f1 - [Driver] Pass the flag -dI to cc1 invocation

Author: Qichao Gu Date: 2022-01-18T06:16:44-08:00 New Revision: 67ac3f1fbeec6ac53a2e32014fe277e49c77b182 URL: https://github.com/llvm/llvm-project/commit/67ac3f1fbeec6ac53a2e32014fe277e49c77b182 DIFF: https://github.com/llvm/llvm-project/commit/67ac3f1fbeec6ac53a2e32014fe277e49c77b182.diff LOG

[PATCH] D117292: [Driver] Pass the flag -dI to cc1 invocation

This revision was automatically updated to reflect the committed changes. Closed by commit rG67ac3f1fbeec: [Driver] Pass the flag -dI to cc1 invocation (authored by qichaogu, committed by erichkeane). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D116216: Prevent adding module flag - amdgpu_hostcall multiple times.

yaxunl accepted this revision. yaxunl added a comment. LGTM. Thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116216/new/ https://reviews.llvm.org/D116216 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D116221: [AArch64][ARM][Clang] Unaligned Access Warning Added

mubashar_ updated this revision to Diff 400827. mubashar_ added a comment. Addressed comments from @lenary. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116221/new/ https://reviews.llvm.org/D116221 Files: clang/include/clang/Basic/DiagnosticASTKinds.td clang/include/clang/Basic/Di

[PATCH] D117560: [C++20][Concepts] Fix a failed assertion on an invalid typename requirement

aaron.ballman created this revision. aaron.ballman added reviewers: rsmith, erichkeane, rjmccall. aaron.ballman requested review of this revision. Herald added a project: clang. The parsing code for a typename requirement currently asserts when given something which is not a valid type-requiremen

[PATCH] D116514: [clangd] Add code action to generate a constructor for a C++ class

njames93 added inline comments. Comment at: clang-tools-extra/clangd/refactor/tweaks/MemberwiseConstructor.cpp:26-28 +// struct S { +// S(int x, unique_ptr y) : x(x), y(std::move(y)) {} +// }; avogelsgesang wrote: > ``` > // e.g. given `struct S{ int x;

[PATCH] D117423: [AVR][clang] Reject non assembly source files for the avr1 family

aykevl added a comment. I'm not sure this is the correct location for these checks. You're essentially checking whether the compilation looks like a C/C++ compilation or an assembly compilation based on the flags and the file name. However, the Clang driver already does something like this: it

[PATCH] D117520: [clang-format] Fix SeparateDefinitionBlocks issues

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. LGTM, I'll pull it down and try it here.. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117520/new/ https://reviews.llvm.org/D117520 _

[PATCH] D114379: [OMPIRBuilder] Add support for simd (loop) directive.

arnamoy10 updated this revision to Diff 400830. arnamoy10 added a comment. 1. Trying to tackle a test failure 2. Adding `any_of()` as per reviewer's suggestion. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114379/new/ https://reviews.llvm.org/D114379 Files: clang/lib/CodeGen/CGStmtO

[PATCH] D115982: [clang][AVR] Implement '__flashN' for variables on different flash banks

aykevl accepted this revision. aykevl added a comment. This revision is now accepted and ready to land. Herald added a subscriber: jacquesguan. Looks good to me! Comment at: clang/lib/Basic/Targets/AVR.cpp:27 const char *DefineName; + const int MaxFlashBank; // -1 means the

[PATCH] D117468: [RISCV] Add intrinsic for Zbt extension

craig.topper added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVInstrInfoZb.td:907 (FSR GPR:$rs1, GPR:$rs2, GPR:$rs3)>; +def : Pat<(riscv_fsr GPR:$rs3, GPR:$rs1, uimmlog2xlen:$shamt), + (FSRI GPR:$rs1, GPR:$rs3, uimmlog2xlen:$shamt)>; --

[clang] 8b21e07 - [clang] NFC: Remove unused `DirectoryLookup`

Author: Jan Svoboda Date: 2022-01-18T16:02:18+01:00 New Revision: 8b21e074dbdf79062505f28b700bd4502acf3096 URL: https://github.com/llvm/llvm-project/commit/8b21e074dbdf79062505f28b700bd4502acf3096 DIFF: https://github.com/llvm/llvm-project/commit/8b21e074dbdf79062505f28b700bd4502acf3096.diff L

[clang-tools-extra] 105c913 - [clang][lex] NFC: Simplify calls to `LookupFile`

Author: Jan Svoboda Date: 2022-01-18T16:02:18+01:00 New Revision: 105c913156e94163c937d812992fe3a56210998c URL: https://github.com/llvm/llvm-project/commit/105c913156e94163c937d812992fe3a56210998c DIFF: https://github.com/llvm/llvm-project/commit/105c913156e94163c937d812992fe3a56210998c.diff L

[PATCH] D117309: [clang] NFC: Remove unused `DirectoryLookup`

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8b21e074dbdf: [clang] NFC: Remove unused `DirectoryLookup` (authored by jansvoboda11). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACT

[PATCH] D117312: [clang][lex] NFC: Simplify calls to `LookupFile`

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG105c913156e9: [clang][lex] NFC: Simplify calls to `LookupFile` (authored by jansvoboda11). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D116025: [analyzer][NFC] Refactor GenericTaintChecker to use CallDescriptionMap

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG17f74240e6c3: [analyzer][NFC] Refactor GenericTaintChecker to use CallDescriptionMap (authored by gamesh411). Repository: rG LLVM Github Monorepo

[clang] 17f7424 - [analyzer][NFC] Refactor GenericTaintChecker to use CallDescriptionMap

Author: Endre Fülöp Date: 2022-01-18T16:04:04+01:00 New Revision: 17f74240e6c3bb64fe741f12d67903e6b7fc38cb URL: https://github.com/llvm/llvm-project/commit/17f74240e6c3bb64fe741f12d67903e6b7fc38cb DIFF: https://github.com/llvm/llvm-project/commit/17f74240e6c3bb64fe741f12d67903e6b7fc38cb.diff L

[PATCH] D117563: [clang][dataflow] Remove obsolete FIXME

sgatev created this revision. sgatev added reviewers: ymandel, xazax.hun, gribozavr2. Herald added subscribers: steakhal, rnkovacs. sgatev requested review of this revision. Herald added a project: clang. The FIXME is no longer relevant as ControlFlowContext centralizes the construction of the CFG

[PATCH] D117563: [clang][dataflow] Remove obsolete FIXME

xazax.hun added a comment. I think for trivial changes like this you do not need to create a review, you can commit it directly :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117563/new/ https://reviews.llvm.org/D117563

[PATCH] D117563: [clang][dataflow] Remove obsolete FIXME

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd7c19f947e0c: [clang][dataflow] Remove obsolete FIXME (authored by sgatev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https

[clang] d7c19f9 - [clang][dataflow] Remove obsolete FIXME

Author: Stanislav Gatev Date: 2022-01-18T15:16:44Z New Revision: d7c19f947e0c93369e71404c33db836e3b6ac3f7 URL: https://github.com/llvm/llvm-project/commit/d7c19f947e0c93369e71404c33db836e3b6ac3f7 DIFF: https://github.com/llvm/llvm-project/commit/d7c19f947e0c93369e71404c33db836e3b6ac3f7.diff LO

[PATCH] D117421: [clang-format] Fix incorrect alignment of operator= overloads.

glotchimo added a comment. Amazing, thank you. This is my first patch so I will need help landing, but I will also apply for commit access as I intend to keep contributing. Here is my name and email for this commit: Elliott Maguire Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACT

[PATCH] D117566: [clang][lex] Introduce `DirectoryLookupIterator`

jansvoboda11 created this revision. jansvoboda11 added a reviewer: ahoppen. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The `const DirectoryLookup *` out-parameter of `{HeaderSearch,Preprocessor}::LookupFile()` is assigned

[PATCH] D117362: [OpenMP] Remove hidden visibility for declare target variables

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LG, let's hope this solves all the AMDGPU issues we've seen. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117362/new/ https://reviews.llv

[PATCH] D116750: [clang][lex] Keep references to `DirectoryLookup` objects up-to-date

jansvoboda11 updated this revision to Diff 400852. jansvoboda11 added a comment. Rebase on top of D117566 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116750/new/ https://reviews.llvm.org/D116750 Files: clang

[PATCH] D116750: [clang][lex] Keep references to `DirectoryLookup` objects up-to-date

jansvoboda11 added inline comments. Comment at: clang/include/clang/Lex/HeaderSearch.h:415 StringRef Filename, SourceLocation IncludeLoc, bool isAngled, - const DirectoryLookup *FromDir, const DirectoryLookup **CurDir, + maybe_search_dir_iterator FromDir, maybe_s

[PATCH] D49864: [clang-tidy] The script clang-tidy-diff.py doesn't accept 'pass by' options (--)

janosimas updated this revision to Diff 400854. janosimas added a comment. I changed the wording and added an example as suggested. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D49864/new/ https://reviews.llvm.org/D49864 Files: clang-tools-extra/

[PATCH] D49864: [clang-tidy] The script clang-tidy-diff.py doesn't accept 'pass by' options (--)

janosimas marked 2 inline comments as done. janosimas added a comment. Yes, I'll need help landing it Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D49864/new/ https://reviews.llvm.org/D49864 ___ cfe-commi

[PATCH] D99134: Lambdas are not necessarily locals. This resolves DR48250.

davidstone added a comment. Is there anything else I need to do to help move this forward? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99134/new/ https://reviews.llvm.org/D99134 ___ cfe-commits mailing

[PATCH] D117567: [clang][dataflow] Add a test to justify skipping past references in UO_Deref

sgatev created this revision. sgatev added reviewers: ymandel, xazax.hun, gribozavr2. Herald added subscribers: steakhal, rnkovacs. sgatev requested review of this revision. Herald added a project: clang. This is part of the implementation of the dataflow analysis framework. See "[RFC] A dataflow

[PATCH] D114379: [OMPIRBuilder] Add support for simd (loop) directive.

Meinersbur added inline comments. Comment at: llvm/unittests/Frontend/OpenMPIRBuilderTest.cpp:1691-1696 + bool Found = false; + if (llvm::any_of(*LoopBody, [](Instruction &I) { +return I.getMetadata("llvm.access.group") != nullptr; + })) +Found = true; + EXPEC

[PATCH] D116216: Prevent adding module flag - amdgpu_hostcall multiple times.

pvellien added a comment. In D116216#3251066 , @yaxunl wrote: > LGTM. Thanks. Could you please commit on my behalf? I don't have a commit access to llvm trunk CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116216/new/ https://reviews.llvm.org/D

[PATCH] D117520: [clang-format] Fix SeparateDefinitionBlocks issues

MyDeveloperDay added a comment. I'm getting some sort of seemingly empty replacements going on, after `public:` I can't quite put my finger on what's happening. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117520/new/ https://reviews.llvm.org/D117520 _

[clang-tools-extra] e598913 - [clang-tidy] Force LF newlines when writing files

Author: Richard Date: 2022-01-18T09:39:42-07:00 New Revision: e598913a4734ce682732703bb362dc3c5c0079c0 URL: https://github.com/llvm/llvm-project/commit/e598913a4734ce682732703bb362dc3c5c0079c0 DIFF: https://github.com/llvm/llvm-project/commit/e598913a4734ce682732703bb362dc3c5c0079c0.diff LOG:

[PATCH] D117535: [clang-tidy] Force LF newlines when writing files

This revision was automatically updated to reflect the committed changes. Closed by commit rGe598913a4734: [clang-tidy] Force LF newlines when writing files (authored by LegalizeAdulthood). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117535/new/ h

[PATCH] D117520: [clang-format] Fix SeparateDefinitionBlocks issues

ksyx added a comment. In D117520#3251376 , @MyDeveloperDay wrote: > I'm getting some sort of seemingly empty replacements going on, after > `public:` I can't quite put my finger on what's happening. Not so sure what empty means here. Is it removing emp

[PATCH] D117568: [Analyzer] Add docs to StdCLibraryFunctionArgsChecker

martong created this revision. martong added reviewers: steakhal, gamesh411, NoQ. Herald added subscribers: manas, ASDenysPetrov, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun. Herald added a reviewer: Szelethus. martong requested review

[PATCH] D117468: [RISCV] Add intrinsic for Zbt extension

craig.topper added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVISelLowering.cpp:4246 + case Intrinsic::riscv_fsl: +return DAG.getNode(RISCVISD::FSL, DL, XLenVT, Op.getOperand(1), + Op.getOperand(2), Op.getOperand(3)); The op

[PATCH] D117569: Constexpr not supported with __declspec(dllimport).

zahiraam created this revision. zahiraam added reviewers: JVApen, rsmith. zahiraam requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fix for issue https://github.com/llvm/llvm-project/issues/53182 Repository: rG LLVM Github Monorepo http

[PATCH] D117520: [clang-format] Fix SeparateDefinitionBlocks issues

MyDeveloperDay added a comment. For class Test { public: static void foo() { } }; F21703157: image.png $ clang-format -n test.cxx test.cxx:3:8: warning: code should be clang-formatted [-Wclang-format-violations ] public:

[clang] fa596fb - Fix a failed assertion on an invalid typename requirement

Author: Aaron Ballman Date: 2022-01-18T11:59:08-05:00 New Revision: fa596fb0779ae9029edbcff80ff95e9d1a816206 URL: https://github.com/llvm/llvm-project/commit/fa596fb0779ae9029edbcff80ff95e9d1a816206 DIFF: https://github.com/llvm/llvm-project/commit/fa596fb0779ae9029edbcff80ff95e9d1a816206.diff

[PATCH] D117520: [clang-format] Fix SeparateDefinitionBlocks issues

ksyx added a comment. In D117520#3251425 , @MyDeveloperDay wrote: > For > > class Test > { > public: > static void foo() > { > } > }; > > F21703157: image.png > > $ clang-format -n test.cxx

[clang-tools-extra] c6fb636 - [clangd][clang-tidy] Remove uses of `std::vector`

Author: Jan Svoboda Date: 2022-01-18T17:59:40+01:00 New Revision: c6fb636667b879bfc8329d2c9ca5873871b46a7b URL: https://github.com/llvm/llvm-project/commit/c6fb636667b879bfc8329d2c9ca5873871b46a7b DIFF: https://github.com/llvm/llvm-project/commit/c6fb636667b879bfc8329d2c9ca5873871b46a7b.diff L

[PATCH] D117119: [clangd][clang-tidy] Remove uses of `std::vector`

This revision was automatically updated to reflect the committed changes. Closed by commit rGc6fb636667b8: [clangd][clang-tidy] Remove uses of `std::vector` (authored by jansvoboda11). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117119/new/

[PATCH] D117560: [C++20][Concepts] Fix a failed assertion on an invalid typename requirement

aaron.ballman closed this revision. aaron.ballman added a comment. I've commit in fa596fb0779ae9029edbcff80ff95e9d1a816206 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117560/n

[clang] 262cc74 - Fix pair construction with an implicit constructor inside.

Author: Tres Popp Date: 2022-01-18T18:01:52+01:00 New Revision: 262cc74e0b699071ff3e2627140b02d01ae2aa7e URL: https://github.com/llvm/llvm-project/commit/262cc74e0b699071ff3e2627140b02d01ae2aa7e DIFF: https://github.com/llvm/llvm-project/commit/262cc74e0b699071ff3e2627140b02d01ae2aa7e.diff LOG

[PATCH] D117120: [Doc] Add documentation for the clang-offload-wrapper tool (NFC)

saiislam added a comment. Ping :-) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117120/new/ https://reviews.llvm.org/D117120 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.or

[PATCH] D117567: [clang][dataflow] Add a test to justify skipping past references in UO_Deref

xazax.hun added a comment. Is it planned to support templated code this way? I'm not entirely sure if this is worth pursuing as opposed to checking instantiations. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117567/new/ https://reviews.llvm.org

[PATCH] D117348: [Preprocessor] Reduce the memory overhead of `#define` directives

aaron.ballman added a comment. Just some minor nits from me, but generally LG. Comment at: clang/include/clang/Lex/MacroInfo.h:243 - using tokens_iterator = SmallVectorImpl::const_iterator; + using tokens_iterator = const Token *; + I think this should be a

[PATCH] D116514: [clangd] Add code action to generate a constructor for a C++ class

avogelsgesang added inline comments. Comment at: clang-tools-extra/clangd/refactor/tweaks/MemberwiseConstructor.cpp:49 + Class = N->ASTNode.get(); +if (!Class || !Class->isThisDeclarationADefinition() || Class->isUnion()) + return false; njames93 w

[PATCH] D117129: [clang-tidy] Extract Class IncluderClangTidyCheck

aaron.ballman added a comment. In D117129#3246403 , @njames93 wrote: > In D117129#3239514 , > @LegalizeAdulthood wrote: > >> In D117129#3239143 , @njames93 >> wrote: >>

  1   2   >