[PATCH] D116721: [Tooling] When transferring compile commands between files, always use '--'

sammccall created this revision. sammccall added a reviewer: kadircet. Herald added subscribers: usaxena95, arphaman. sammccall requested review of this revision. Herald added projects: clang, clang-tools-extra. Herald added a subscriber: cfe-commits. "driver -- " is a particularly convenient for

[PATCH] D115921: [RISCV] Refactor the RISCV ISA extension info and target features to support multiple extension version

zixuan-wu added a comment. ping... CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115921/new/ https://reviews.llvm.org/D115921 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D115921: [RISCV] Refactor the RISCV ISA extension info and target features to support multiple extension version

jrtc27 added a comment. I'm unconvinced about landing something like this until there's an actual use case in the tree. How do we know this will actually work the way we want it to if there's nothing proving it? It's still unclear to me how exactly this is going to be represented in the target

[PATCH] D116722: [clang] Verify ssp buffer size is a valid integer

alextsao1999 created this revision. alextsao1999 added a reviewer: compnerd. alextsao1999 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch adds to verify whether the ssp buffer size is a legal integer and a new diagnostic driver

[PATCH] D116316: [clang-format] Add an experimental option to remove optional control statement braces in LLVM C++ code

owenpan updated this revision to Diff 397783. owenpan added a comment. Fixing a couple of major bugs found by running check-clang plus minor bug fixes and cleanup: - In `parseLevel()`, `HasOpeningBrace` and `case tok::r_brace:` don't necessarily mean the tokens are `{` and `}`, respectively. -

[PATCH] D108694: [RISCV] Add the zvl extension according to the v1.0 spec

eopXD added a comment. ping again, thank you. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108694/new/ https://reviews.llvm.org/D108694 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://li

[PATCH] D115921: [RISCV] Refactor the RISCV ISA extension info and target features to support multiple extension version

zixuan-wu added a comment. In D115921#3224284 , @jrtc27 wrote: > but also with RISC-V extensions not being changed once ratified any more > (changes mean new extensions entirely, not new versions) I don't think so. Or why is there version in RISC-V spec

[PATCH] D115921: [RISCV] Refactor the RISCV ISA extension info and target features to support multiple extension version

zixuan-wu added inline comments. Comment at: llvm/lib/Support/RISCVISAInfo.cpp:48 {"v", RISCVExtensionVersion{0, 10}}, +//{"v", RISCVExtensionVersion{0, 7}}, {"zba", RISCVExtensionVersion{1, 0}}, jrtc27 wrote: > Don't do this This nit will be remove

[PATCH] D115921: [RISCV] Refactor the RISCV ISA extension info and target features to support multiple extension version

jrtc27 added a comment. In D115921#3224324 , @zixuan-wu wrote: > In D115921#3224284 , @jrtc27 wrote: > >> but also with RISC-V extensions not being changed once ratified any more >> (changes mean new extensions e

[PATCH] D115921: [RISCV] Refactor the RISCV ISA extension info and target features to support multiple extension version

jrtc27 added inline comments. Comment at: llvm/lib/Support/RISCVISAInfo.cpp:61 {"zvlsseg", RISCVExtensionVersion{0, 10}}, +//{"zvlsseg", RISCVExtensionVersion{0, 7}}, This one too?.. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115921/new/

[PATCH] D55134: [CTU] Add triple/lang mismatch handling

ychen added a comment. Herald added a reviewer: Szelethus. Herald added a subscriber: steakhal. FWIW, ASTUnit seems to save an effective triple while the current AST uses the nominal triple. (for example, `armv7a-xx-xx-eabihf` vs `armv7a-xx-xx-eabi`). I'm not sure if there is a good solution oth

[PATCH] D116636: [WIP] Enable `-Wstrict-calls-without-prototype` by default

NoQ added a comment. Ooof you fixed a lot of static analyzer tests. If you ever get tired of this, feel free to `-w` them entirely because the driver's `--analyze` flag implies `-w` anyway. Hmm, maybe we should even change `%clang_analyze_cc1` to include `-w`. Repository: rG LLVM Github Mon

[PATCH] D116597: [analyzer] Don't track function calls as control dependencies

NoQ added a comment. Interesting. Might it be that in this scenario in order to be of interest to the user the condition value has to be trackable back to the current stack frame? > the popular feedback we hear from some of our users, namely that they can > never have too much information The

[PATCH] D116025: [analyzer][NFC] Refactor GenericTaintChecker to use CallDescriptionMap

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. I haven't read this whole patch with full scrutiny but it sure looks lovely. I now also see what the problem is with non-static strings in call descriptions. Repository: rG LLVM Github Monorepo

[PATCH] D115921: [RISCV] Refactor the RISCV ISA extension info and target features to support multiple extension version

zixuan-wu added a comment. In D115921#3224329 , @jrtc27 wrote: > In D115921#3224324 , @zixuan-wu > wrote: > >> In D115921#3224284 , @jrtc27 wrote: >> >>> but also with RI

[PATCH] D88833: [clang-tidy] Do not warn on pointer decays in system macros

carlosgalvezp added a comment. Please note: I have a patch that disables warnings from system macros for all clang-tidy warnings, it would be good to review it so we don't need to implement the same mechanism in all 400+ checks :) https://reviews.llvm.org/D116378 Repository: rG LLVM Github

<    1   2   3