[PATCH] D116351: Update Bug report URL to Github Issues

ChuanqiXu marked an inline comment as done. ChuanqiXu added inline comments. Comment at: llvm/docs/CommandGuide/llvm-objcopy.rst:539 -To report bugs, please visit . +To report bugs, please visit . -

[PATCH] D116368: [clang][dataflow] Add transfer function for VarDecl statements

sgatev updated this revision to Diff 396660. sgatev marked 12 inline comments as done. sgatev added a comment. Address reviewers' comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116368/new/ https://reviews.llvm.org/D116368 Files: clang/i

[PATCH] D116368: [clang][dataflow] Add transfer function for VarDecl statements

sgatev added inline comments. Comment at: clang/include/clang/Analysis/FlowSensitive/DataflowAnalysisContext.h:61 + /// `D` must not be assigned a storage location. + void setStorageLocation(const VarDecl &D, StorageLocation &Loc) { +assert(VarDeclToLoc.find(&D) == VarDec

[PATCH] D113752: [Parse] Use empty RecoveryExpr when if/while/do/switch conditions fail to parse

sammccall marked 6 inline comments as done. sammccall added a comment. In D113752#3188486 , @hokein wrote: > since we're now preserving more invalid code, we should check whether > const-evaluator is cable of handling these newly-added invalid case. > >

[PATCH] D113752: [Parse] Use empty RecoveryExpr when if/while/do/switch conditions fail to parse

sammccall updated this revision to Diff 396662. sammccall marked an inline comment as done. sammccall added a comment. Add constant-evaluation for broken switches, and a bunch of evaluation tests. Address other comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://

[PATCH] D116412: [Clang][Sema] Fix attribute mismatch warning for ObjC class properties

egorzhdan created this revision. egorzhdan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. If a class declares an instance property, and an inheritor class declares a class property with the same name, Clang Sema currently treats the latte

[PATCH] D115604: [Support] Expand `` as the base directory in configuration files.

jackoalan updated this revision to Diff 396667. jackoalan marked 5 inline comments as done. jackoalan added a comment. Update ReadConfigFile test with additional `` expansion contexts (non-prefixed, non-suffixed, escaped in middle). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115604/n

[PATCH] D116368: [clang][dataflow] Add transfer function for VarDecl statements

sgatev updated this revision to Diff 396668. sgatev added a comment. Canonicalize types. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116368/new/ https://reviews.llvm.org/D116368 Files: clang/include/clang/Analysis/FlowSensitive/DataflowAnalysi

[PATCH] D115604: [Support] Expand `` as the base directory in configuration files.

jackoalan marked an inline comment as done. jackoalan added inline comments. Comment at: llvm/lib/Support/CommandLine.cpp:1099 +else + llvm::sys::path::append(ResponseFile, LHS); +ResponseFile.append(BasePath); sepavloff wrote: > What happens if `` i

[PATCH] D115604: [Support] Expand `` as the base directory in configuration files.

jackoalan updated this revision to Diff 396670. jackoalan added a comment. Add ReadConfigFile test case for multiple `` in one arg. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115604/new/ https://reviews.llvm.org/D115604 Files: clang/docs/Rele

[PATCH] D115501: [clang][ARM] Emit warnings when PACBTI-M is used with unsupported architectures

amilendra updated this revision to Diff 396671. amilendra added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115501/new/ https://reviews.llvm.org/D115501 Files: clang/include/clang/Basic/DiagnosticCommonKinds

[PATCH] D49482: Haiku: add a test for haiku driver

kallisti5 updated this revision to Diff 396674. kallisti5 added a comment. Herald added subscribers: luke957, s.egerton, simoncook. Herald added a project: clang. I've reworked these tests to be a lot more in-depth. Both c and c++ are passing. I plan on trying to get more of our clang / llvm p

[PATCH] D115604: [Support] Expand `` as the base directory in configuration files.

jackoalan added a comment. Actually, I just thought of a possible limitation of using path-append when suffixing with something that isn't actually a path component. However, I cannot say how critical this limitation is. -Wl,-rpath,,foo.o This will cause a trailing `/` to be inserted after `

[PATCH] D49482: Haiku: add a test for haiku driver

kallisti5 added a comment. I should mention that there are no crt checks since the Haiku toolchain driver doesn't actually look for our crt's yet. https://github.com/llvm/llvm-project/blob/main/clang/lib/Driver/ToolChains/Haiku.cpp vs https://github.com/llvm/llvm-project/blob/main/clang/lib/Driv

[PATCH] D116385: [clangd] Code action for creating an ObjC initializer

dgoldman updated this revision to Diff 396676. dgoldman added a comment. Minor change to how we get the loc of `@end` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116385/new/ https://reviews.llvm.org/D116385 Files: clang-tools-extra/clangd/refa

[PATCH] D116414: [AST] Produce ReturnStmt containing RecoveryExpr when type is wrong

sammccall created this revision. sammccall added a reviewer: hokein. sammccall requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Previously we just drop the ReturnStmt and its argument from the AST, which blocks analysis of broken code. Fixe

[PATCH] D116159: [ARM][AArch64] clang support for Armv9.3-A

tmatheson updated this revision to Diff 396679. tmatheson marked 2 inline comments as done. tmatheson added a comment. Remove redundancies in arm tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116159/new/ https://reviews.llvm.org/D116159 File

[PATCH] D116414: [AST] Produce ReturnStmt containing RecoveryExpr when type is wrong

sammccall updated this revision to Diff 396680. sammccall added a comment. Add evaluation test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116414/new/ https://reviews.llvm.org/D116414 Files: clang/include/clang/Sema/Sema.h clang/lib/Sema/Sem

[PATCH] D116414: [AST] Produce ReturnStmt containing RecoveryExpr when type is wrong

sammccall added a comment. No changes to evaluation makes sense as these patterns already exist today: `return undef();` produces a RecoveryExpr and `return;` is preserved in the AST with no value even for non-void functions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[PATCH] D116415: [Arm] Remove duplicate CPU tests

tmatheson created this revision. Herald added a subscriber: kristof.beyls. tmatheson requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. There are some duplicate test lines in clang/test/Driver/arm-cortex-cpus.c. Looks like these were duplicate

[PATCH] D116159: [ARM][AArch64] clang support for Armv9.3-A

tmatheson added inline comments. Comment at: clang/test/Driver/arm-cortex-cpus.c:445 +// RUN: %clang -target armv9.3a -mlittle-endian -### -c %s 2>&1 | FileCheck -check-prefix=CHECK-V93A %s +// RUN: %clang -target arm -march=armv9.3a -mlittle-endian -### -c %s 2>&1 | FileCheck

[PATCH] D116370: [clang][dataflow] Add multi-variable constant propagation example.

sgatev added inline comments. Comment at: clang/unittests/Analysis/FlowSensitive/MultiVarConstantPropagationTest.cpp:9 +// +// This file defines a simplistic version of Constant Propagation as an example +// of a forward, monotonic dataflow analysis. The analysis tracks all

[PATCH] D116386: [clang-tidy] Narrow cppguidelines-macro-usage to actual constants

LegalizeAdulthood updated this revision to Diff 396683. LegalizeAdulthood marked an inline comment as not done. LegalizeAdulthood added a comment. Improve name of predicate function. Use standard algorithms instead of raw loops CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116386/new/ h

[PATCH] D116283: [clang-format] Add an option to add a space between operator overloading and opening parentheses

rajatbajpai added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:14545 verifyFormat("auto lambda = []() { return 0; };", SomeSpace2); + + FormatStyle SpaceAfterOperatorOverloading = getLLVMStyle(); MyDeveloperDay wrote: > There should be a

[PATCH] D116370: [clang][dataflow] Add multi-variable constant propagation example.

ymandel added inline comments. Comment at: clang/unittests/Analysis/FlowSensitive/MultiVarConstantPropagationTest.cpp:162 + } + Vars[Var] = ValueLattice::top(); + return Vars; sgatev wrote: > I believe this should be `bottom` as `ValueLattice::bot

[PATCH] D116370: [clang][dataflow] Add multi-variable constant propagation example.

ymandel updated this revision to Diff 396684. ymandel added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116370/new/ https://reviews.llvm.org/D116370 Files: clang/unittests/Analysis/FlowSensitive/CMakeLists.txt cla

[PATCH] D116370: [clang][dataflow] Add multi-variable constant propagation example.

xazax.hun accepted this revision. xazax.hun added a comment. This revision is now accepted and ready to land. In D116370#3213191 , @ymandel wrote: > In D116370#3213120 , @xazax.hun > wrote: > >> Does it make sens

[PATCH] D116369: [clang][dataflow] Add parameterized map lattice.

xazax.hun accepted this revision. xazax.hun added inline comments. This revision is now accepted and ready to land. Comment at: clang/include/clang/Analysis/FlowSensitive/MapLattice.h:92 + /// entry as it was in the source map. + LatticeJoinEffect join(const MapLattice &Other)

[PATCH] D116417: [clang][ObjC] Add fix it for missing methods in impl

dgoldman created this revision. dgoldman requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. We suggest inserting the method with an empty body at the end of the implementation decl. Repository: rG LLVM Github Monorepo https://reviews.llvm

[PATCH] D116368: [clang][dataflow] Add transfer function for VarDecl statements

xazax.hun accepted this revision. xazax.hun added a comment. This revision is now accepted and ready to land. I have one nit inline, and some topics that should probably be deferred to follow-up PRs. Overall, looks good to me, thanks! Comment at: clang/include/clang/Analysis/

[PATCH] D115604: [Support] Expand `` as the base directory in configuration files.

sepavloff accepted this revision. sepavloff added a comment. This revision is now accepted and ready to land. LGTM Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115604/new/ https://reviews.llvm.org/D115604

[PATCH] D116417: [clang][ObjC] Add fix it for missing methods in impl

dgoldman updated this revision to Diff 396690. dgoldman added a comment. Add a test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116417/new/ https://reviews.llvm.org/D116417 Files: clang/lib/Sema/SemaDeclObjC.cpp clang/test/FixIt/fixit-objc-m

[PATCH] D116415: [Arm] Remove duplicate CPU tests

nickdesaulniers accepted this revision. nickdesaulniers added inline comments. This revision is now accepted and ready to land. Comment at: clang/test/Driver/arm-cortex-cpus.c:217 // RUN: %clang -target arm -march=armv8.1-a -### -c %s 2>&1 | FileCheck -check-prefix=CHECK-V81A %

[PATCH] D115501: [clang][ARM] Emit warnings when PACBTI-M is used with unsupported architectures

amilendra updated this revision to Diff 396695. amilendra added a comment. Fix clang-format errors. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115501/new/ https://reviews.llvm.org/D115501 Files: clang/include/clang/Basic/DiagnosticCommonKinds

[clang] 9d37d0e - [Support] Expand `` as the base directory in configuration files.

Author: Jack Andersen Date: 2021-12-30T13:43:47-05:00 New Revision: 9d37d0ea34858288faf6351b9bdc0a0b91107c82 URL: https://github.com/llvm/llvm-project/commit/9d37d0ea34858288faf6351b9bdc0a0b91107c82 DIFF: https://github.com/llvm/llvm-project/commit/9d37d0ea34858288faf6351b9bdc0a0b91107c82.diff

[PATCH] D115604: [Support] Expand `` as the base directory in configuration files.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9d37d0ea3485: [Support] Expand `` as the base directory in configuration files. (authored by jackoalan). Repository: rG LLVM Github Monore

[PATCH] D116314: [clang-format] Add style to separate definition blocks

HazardyKnusperkeks added inline comments. Comment at: clang/include/clang/Format/Format.h:3104-3105 + /// + ///class C {} + ///}; + /// \endcode Comment at: clang/lib/

[PATCH] D116316: [clang-format] Add an experimental option to remove optional control statement braces in LLVM C++ code

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:2303 + assert(IfRightBrace->MatchingParen == IfLeftBrace); + IfLeftBrace->MatchingParen = nullptr; + IfRightBrace->MatchingParen = nullptr; owenpan wrote

[PATCH] D116283: [clang-format] Add an option to add a space between operator overloading and opening parentheses

HazardyKnusperkeks added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:14545 verifyFormat("auto lambda = []() { return 0; };", SomeSpace2); + + FormatStyle SpaceAfterOperatorOverloading = getLLVMStyle(); rajatbajpai wrote: > MyDeveloperDa

[PATCH] D107275: [Sema] a[x] has type T when a has type T* or T[], even when T is dependent

sammccall added a comment. In D107275#3182906 , @kadircet wrote: > I am more worried about creating "incorrect" nodes in some cases. I think it > isn't valid in C/C++ for both LHS && RHS to be pointers/arrays in a subscript > expression, but I've got no

[PATCH] D116385: [clangd] Code action for creating an ObjC initializer

dgoldman updated this revision to Diff 396706. dgoldman added a comment. Add another minor test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116385/new/ https://reviews.llvm.org/D116385 Files: clang-tools-extra/clangd/refactor/tweaks/CMake

[PATCH] D116314: [clang-format] Add style to separate definition blocks

ksyx updated this revision to Diff 396709. ksyx marked 2 inline comments as done. ksyx added a comment. minor fixes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116314/new/ https://reviews.llvm.org/D116314 Files: clang/docs/ClangFormatStyleOptions.rst clang/include/clang/Format/F

[PATCH] D116280: [clang] adds unary type trait checks as compiler built-ins

cjdb updated this revision to Diff 396711. cjdb edited the summary of this revision. cjdb added a comment. rebases to activate CI Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116280/new/ https://reviews.llvm.org/D116280 Files: clang/include/cla

[PATCH] D116314: [clang-format] Add style to separate definition blocks

HazardyKnusperkeks requested changes to this revision. HazardyKnusperkeks added a comment. This revision now requires changes to proceed. Only some small changes, then it looks good to me. And I will definitely use it, once it is landed. Comment at: clang/include/clang/Format/

[PATCH] D116425: [clang-tidy] Improve modernize-redundant-void-arg to recognize macro uses

LegalizeAdulthood created this revision. LegalizeAdulthood added a reviewer: alexfh. LegalizeAdulthood added a project: clang-tools-extra. Herald added subscribers: carlosgalvezp, xazax.hun. LegalizeAdulthood requested review of this revision. Sometimes a macro invocation will look like an argumen

[PATCH] D116316: [clang-format] Add an experimental option to remove optional control statement braces in LLVM C++ code

owenpan added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:2303 + assert(IfRightBrace->MatchingParen == IfLeftBrace); + IfLeftBrace->MatchingParen = nullptr; + IfRightBrace->MatchingParen = nullptr; HazardyKnusperkeks wrote

[PATCH] D107275: [Sema] a[x] has type T when a has type T* or T[], even when T is dependent

sammccall added a comment. In D107275#3214272 , @sammccall wrote: > In the motivating case, the subscript is a known integer type and the LHS is > an array or pointer. In this case we don't have the above concern, and we > also don't have my #1 above. S

[PATCH] D116314: [clang-format] Add style to separate definition blocks

ksyx updated this revision to Diff 396727. ksyx marked 9 inline comments as done. ksyx added a comment. - Apply review suggestions. - Assert the style is not `SDS_Leave` in private method, while return no change in public method if so. - Rename loop variable `Line` to `CurrentLine` CHANGES SINC

[PATCH] D116314: [clang-format] Add style to separate definition blocks

ksyx added inline comments. Comment at: clang/include/clang/Format/Format.h:4097 + ArrayRef Ranges, + StringRef FileName = ""); + HazardyKnusperkeks wrote: > The only use

[PATCH] D107275: [Sema] a[x] has type T when a has type T* or T[], even when T is dependent

sammccall updated this revision to Diff 396730. sammccall added a comment. Restrict to array/pointer + index, insist on a dependent type. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107275/new/ https://reviews.llvm.org/D107275 Files: clang/lib

[PATCH] D107275: [Sema] a[x] has type T when a has type T* or T[], even when T is dependent

sammccall added a comment. I'm going to land this now in its conservative version based on: > if you think we're covered for those and others don't chime in this week I > suppose we can consider this as good to go. Happy to address any more comments and/or make it less conservative. Repositor

[clang] 09f8315 - [Sema] a[x] has type T when a has type T* or T[], even when T is dependent

Author: Sam McCall Date: 2021-12-31T01:30:39+01:00 New Revision: 09f8315bba391eac1dbdfbdc3fd654c0c0cbe3e7 URL: https://github.com/llvm/llvm-project/commit/09f8315bba391eac1dbdfbdc3fd654c0c0cbe3e7 DIFF: https://github.com/llvm/llvm-project/commit/09f8315bba391eac1dbdfbdc3fd654c0c0cbe3e7.diff LO

[PATCH] D107275: [Sema] a[x] has type T when a has type T* or T[], even when T is dependent

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG09f8315bba39: [Sema] a[x] has type T when a has type T* or T[], ev

[PATCH] D116280: [clang] adds unary type trait checks as compiler built-ins

cjdb updated this revision to Diff 396748. cjdb edited the summary of this revision. cjdb added a comment. adds `__is_unbounded_array` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116280/new/ https://reviews.llvm.org/D116280 Files: clang/includ

[PATCH] D114077: [clangd] Basic IncludeCleaner support for c/c++ standard library

sammccall updated this revision to Diff 396635. sammccall added a comment. (rebase before addressing comments) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114077/new/ https://reviews.llvm.org/D114077 Files: clang-tools-extra/clangd/Headers.cpp

[PATCH] D114077: [clangd] Basic IncludeCleaner support for c/c++ standard library

sammccall updated this revision to Diff 396639. sammccall marked 4 inline comments as done. sammccall added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114077/new/ https://reviews.llvm.org/D114077 Files: clang-tools

[PATCH] D114077: [clangd] Basic IncludeCleaner support for c/c++ standard library

sammccall added inline comments. Comment at: clang-tools-extra/clangd/Headers.h:32 namespace clang { +class NamespaceDecl; namespace clangd { kbobyrev wrote: > Do we need a forward decl here? Decl/NamespaceDecl are needed for the interface of the stdlib symbol

[PATCH] D116386: [clang-tidy] Narrow cppguidelines-macro-usage to actual constants

LegalizeAdulthood added inline comments. Comment at: clang-tools-extra/clang-tidy/cppcoreguidelines/MacroUsageCheck.cpp:83-105 +bool isConstantToken(const MacroDirective *MD) { + for (const auto &Token : MD->getMacroInfo()->tokens()) { +switch (Token.getKind()) { +case

[PATCH] D116369: [clang][dataflow] Add parameterized map lattice.

ymandel marked an inline comment as done. ymandel added inline comments. Comment at: clang/include/clang/Analysis/FlowSensitive/MapLattice.h:92 + /// entry as it was in the source map. + LatticeJoinEffect join(const MapLattice &Other) { +LatticeJoinEffect Effect = LatticeJo

[PATCH] D116351: Update Bug report URL to Github Issues

MaskRay added a subscriber: jhenderson. MaskRay added a comment. @jhenderson Comment at: libunwind/docs/index.rst:101 * `LLVM Homepage `_ -* `LLVM Bugzilla `_ +* `LLVM Issues `_ * `cfe-co

[PATCH] D116351: Update Bug report URL to Github Issues

MaskRay added inline comments. Comment at: libcxx/docs/index.rst:220 * `libc++abi Homepage `_ -* `LLVM Bugzilla `_ +* `LLVM Issues `_ * `libcxx-commits Mailing List`_ -

[PATCH] D72326: [clang-format] Add option to explicitly specify a config file

zwliew updated this revision to Diff 396578. zwliew added a comment. Herald added subscribers: llvm-commits, openmp-commits, libcxx-commits, lldb-commits, Sanitizers, arjunp, sdasgup3, luke957, asavonic, jeroen.dobbelaere, wenzhicui, wrengr, Chia-hungDuan, armkevincheng, ormris, foad, eric-k256,

[PATCH] D72326: [clang-format] Add option to explicitly specify a config file

zwliew added a comment. Herald added a subscriber: JDevlieghere. Oh no...I'm so sorry. Didn't mean to cause this large diff. Trying to fix it now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72326/new/ https://reviews.llvm.org/D72326 __

[PATCH] D72326: [clang-format] Add option to explicitly specify a config file

zwliew updated this revision to Diff 396579. zwliew added a comment. Fixed rebase and diff. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72326/new/ https://reviews.llvm.org/D72326 Files: clang/docs/ClangFormat.rst clang/docs/ClangFormatStyleO

[PATCH] D116351: Update Bug report URL to Github Issues

ChuanqiXu updated this revision to Diff 396589. ChuanqiXu marked 2 inline comments as done. ChuanqiXu added a comment. Address comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116351/new/ https://reviews.llvm.org/D116351 Files: clang-tools-extra/docs/clang-doc.rst clang/docs

[PATCH] D116351: Update Bug report URL to Github Issues

ChuanqiXu marked 14 inline comments as done. ChuanqiXu added inline comments. Comment at: clang/www/c_status.html:75-76 -The https://bugs.llvm.org/";>LLVM bug tracker contains a -Clang C component that tracks known bugs with Clang's language +The https://github.com/llvm/llvm-pr

[PATCH] D116351: Update Bug report URL to Github Issues

MaskRay added inline comments. Comment at: llvm/docs/CommandGuide/llvm-objcopy.rst:539 -To report bugs, please visit . +To report bugs, please visit . https://github.com/llvm/llvm-project/l

[PATCH] D116351: Update Bug report URL to Github Issues

ChuanqiXu updated this revision to Diff 396627. ChuanqiXu marked 2 inline comments as done. ChuanqiXu added a comment. Address comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116351/new/ https://reviews.llvm.org/D116351 Files: clang-tools-extra/docs/clang-doc.rst clang/docs