[PATCH] D115503: [DebugInfo][Clang] record the access flag for class/struct/union types.

dblaikie accepted this revision. dblaikie added a comment. Got any data on how much this (combined with the LLVM patch) increases debug info size of, say, a clang self-host build? I assume not much, but wouldn't hurt to know. (does GCC produce this sort of debug info, or does it skip the access

[PATCH] D115567: [Sema] Add FixIt when a C++ out-of-line method has extra/missing const

hokein accepted this revision. hokein added inline comments. This revision is now accepted and ready to land. Comment at: clang/test/FixIt/member-mismatch.cpp:9 + +// CHECK: fix-it:"{{.*}}":{10:15-10:15}:" const" +int Foo::get() {} // expected-error {{does not match any declarati

[PATCH] D112903: [C++20] [Module] Fix bug47116 and implement [module.interface]/p6

ChuanqiXu added a comment. @rsmith @aaron.ballman @urnathan gentle ping~ CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112903/new/ https://reviews.llvm.org/D112903 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org

[PATCH] D108189: [RISCV] Support experimental 'P' extension 0.96

zixuan-wu added a comment. Herald added subscribers: VincentWu, luke957, achieveartificialintelligence. Hi, @Jim. What time is P extension going to upstream to community since it's been no update for some months? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews

[PATCH] D70401: [WIP][RISCV] Implement ilp32e ABI

lenary marked an inline comment as done. lenary added a comment. In D70401#3188138 , @zixuan-wu wrote: > In D70401#3175266 , @khchen wrote: > >>> Is it (D70401 ) good enough to solve

[PATCH] D112410: [SPIR-V] Add a toolchain for SPIR-V in clang

svenvh added inline comments. Comment at: clang/test/Driver/spirv-toolchain.cl:10 +// SPV64-SAME: "-o" [[BC:".*bc"]] +// SPV64: {{".*llvm-spirv.*"}} [[BC]] "-o" {{".*o"}} + Anastasia wrote: > svenvh wrote: > > Any reason to not just check for `llvm-spirv{{.*}}`,

[PATCH] D115604: [Support] Expand `<@>` as the base directory in response files.

kadircet added a comment. IIUC, the new behavior being introduced by this patch is not the ability of having a way to refer to other files in a config/response file relative way, but rather extending that ability from only the options that start with `@` to options that contain `@` as a sub-str

[PATCH] D114583: [clang-format] Adjust braced list detection

krasimir added a comment. It appears that this regressed the formatting of initializer lists in some cases: # Before % cat ~/test.cc class A { A() : a{} {} A(int b) : b(b) {} A(int a, int b) : a(a), bs{{bs...}} { f(); } int a, b; }; # After % bui

[PATCH] D115149: [analyzer][solver] Fix assertion on (NonLoc, Op, Loc) expressions

steakhal marked an inline comment as done. steakhal added a comment. In D115149#3182196 , @ASDenysPetrov wrote: > @steakhal > Please provide a case which asserts before your patch. I don't get this one. I've provided a bunch of tests, even annotated wit

[PATCH] D113752: [Parse] Use empty RecoveryExpr when if/while/do/switch conditions fail to parse

hokein added a comment. since we're now preserving more invalid code, we should check whether const-evaluator is cable of handling these newly-added invalid case. I have played around it, it seems that if, do/while, while cases are already handled well. `switch` case need some work: - the AST

[PATCH] D115441: [X86][MS] Add 80bit long double support for Windows

mstorsjo added a comment. In D115441#3188172 , @pengfei wrote: >> In GCC on Windows (and clang in mingw mode), long double is always 80 bit on >> x86. (On i386, sizeof(long double) == 12, while on x86_64 it's 16.) > > How about the alignment? I can see o

[PATCH] D102669: [analyzer][ctu] Fix wrong 'multiple definitions' errors caused by space characters in lookup names when parsing the ctu index file

steakhal accepted this revision. steakhal added a comment. This revision is now accepted and ready to land. I think it looks great. Thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102669/new/ https://reviews.llvm.org/D102669 ___ cfe-com

[clang] 41def32 - [AArch64][SVE][NEON] Add NEON-SVE-Bridge intrinsics

Author: Matt Devereau Date: 2021-12-13T11:31:57Z New Revision: 41def32040787e917b52279cc30231b27f2f02f7 URL: https://github.com/llvm/llvm-project/commit/41def32040787e917b52279cc30231b27f2f02f7 DIFF: https://github.com/llvm/llvm-project/commit/41def32040787e917b52279cc30231b27f2f02f7.diff LOG:

[PATCH] D114713: [AArch64][SVE][NEON] Add NEON-SVE-Bridge intrinsics

MattDevereau closed this revision. MattDevereau added a comment. 41def32040787e917b52279cc30231b27f2f02f7 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114713/new/ https://revie

[PATCH] D114095: [clang][lex] Include tracking: simplify and move to preprocessor

jansvoboda11 added a comment. You're right, I measured only this patch, not per-submodule include tracking (D112915 ). With per-submodule tracking, the results look like this: +--+--+--+---+

[PATCH] D115622: [Debugify] Optimize debugify original mode

djtodoro created this revision. djtodoro added reviewers: Orlando, StephenTozer. djtodoro added projects: debug-info, LLVM. Herald added subscribers: ormris, hiraditya. djtodoro requested review of this revision. Herald added a project: clang. Herald added subscribers: llvm-commits, cfe-commits. B

[clang] 7c51a12 - [NFC] format .cppm files in test

Author: Chuanqi Xu Date: 2021-12-13T19:52:31+08:00 New Revision: 7c51a128339184c64307f3862e4cd36bf996189b URL: https://github.com/llvm/llvm-project/commit/7c51a128339184c64307f3862e4cd36bf996189b DIFF: https://github.com/llvm/llvm-project/commit/7c51a128339184c64307f3862e4cd36bf996189b.diff LO

[PATCH] D115625: [clang-format] add support for cppm files

MyDeveloperDay created this revision. MyDeveloperDay added reviewers: ChuanqiXu, HazardyKnusperkeks, curdeius, krasimir. MyDeveloperDay added projects: clang, clang-format. MyDeveloperDay requested review of this revision. C++20 Modules current style is to assign a new file suffix .cppm instead o

[PATCH] D115625: [clang-format] add support for cppm files

ChuanqiXu accepted this revision. ChuanqiXu added a comment. This revision is now accepted and ready to land. Thanks for the quick respond! A note in the summary: - C++20 Modules current style is to assign a new file suffix .cppm instead of .cpp and .h + C++20 Modules current style is to as

[PATCH] D114583: [clang-format] Adjust braced list detection

MyDeveloperDay added a comment. We might want to revert this until we get a solution to avoid flip flopping peoples formats, but this to me comes down to what we've been saying before about using the TT_ types to labels the types of `() {} []` I think in hindsight adding l_brace here just too g

[PATCH] D112890: headers: optionalise some generated resource headers

thakis added a comment. In D112890#3119897 , @jrtc27 wrote: > This change seems pretty counter to Clang's ability to spit out IR for > anything regardless of what backends you have. The right fix should be to > shrink the headers, not mask the problem b

[clang] b6f317d - [gn build] Make arm_neon_sve_bridge.h header auto-syncable

Author: Nico Weber Date: 2021-12-13T07:04:45-05:00 New Revision: b6f317d94d894142f5ab9a9e3e942acbfff1dc4b URL: https://github.com/llvm/llvm-project/commit/b6f317d94d894142f5ab9a9e3e942acbfff1dc4b DIFF: https://github.com/llvm/llvm-project/commit/b6f317d94d894142f5ab9a9e3e942acbfff1dc4b.diff LO

[PATCH] D112890: headers: optionalise some generated resource headers

thakis added a comment. (…at least for the arm headers, which 1. didn't use to do this 2. are a lot smaller than the risc-v headers ) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112890/new/ https://reviews.llvm.org/D112890

[clang] 45158b1 - Revert "[NFC] format .cppm files in test"

Author: Nico Weber Date: 2021-12-13T07:13:17-05:00 New Revision: 45158b18041584e0056f85c04057d5098956257d URL: https://github.com/llvm/llvm-project/commit/45158b18041584e0056f85c04057d5098956257d DIFF: https://github.com/llvm/llvm-project/commit/45158b18041584e0056f85c04057d5098956257d.diff LO

[PATCH] D115628: [clang][deps] Remove hard-coded resource directory from tests

jansvoboda11 created this revision. jansvoboda11 added reviewers: Bigcheese, dexonsmith, arphaman, mgorny. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Dependency scanner test for resource directory deduction doesn't account

[PATCH] D115625: [clang-format] add support for cppm files

MyDeveloperDay added inline comments. Comment at: clang/tools/clang-format/git-clang-format:81 'mm', # ObjC++ - 'cc', 'cp', 'cpp', 'c++', 'cxx', 'hh', 'hpp', 'hxx', # C++ + 'cc', 'cp', 'cpp', 'c++', 'cxx', 'hh', 'hpp', 'hxx', 'cppm' # C++ 'cu', 'cuh',

[PATCH] D108366: [clang][deps] Make resource directory deduction configurable

jansvoboda11 added a comment. In D108366#3188028 , @mgorny wrote: > This change causes a test regression on Gentoo (where > `CLANG_RESOURCE_DIR="../../../../lib/clang/${clang_version}"`): Thanks for reporting this. Should be fixed in D115628

[PATCH] D115625: [clang-format] add support for cppm files

MyDeveloperDay updated this revision to Diff 393851. MyDeveloperDay added a comment. Missed a comma CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115625/new/ https://reviews.llvm.org/D115625 Files: clang/tools/clang-format/clang-format-diff.py clang/tools/clang-format/git-clang-for

[PATCH] D115094: Fix -Wdeclaration-after-statement doesn't work when used with -std=c99

aaron.ballman added a comment. In D115094#3187152 , @xgupta wrote: > There is already a revision uploaded for this: > https://reviews.llvm.org/D114787 by @zero9178. Thanks for pointing this out! I thought this seemed familiar. :-D The patch author shou

[PATCH] D114787: [clang][PR51931] Enable `-Wdeclaration-after-statement` for all C versions

aaron.ballman added a comment. https://reviews.llvm.org/D115094 is a review for doing effectively the same fix. Can you coordinate with the other patch author to determine who will drive this fix? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1147

[PATCH] D115625: [clang-format] add support for cppm files

curdeius accepted this revision. curdeius added a comment. LGTM. Comment at: clang/tools/clang-format/clang-format-diff.py:51 r'.*\.(cpp|cc|c\+\+|cxx|c|cl|h|hh|hpp|hxx|m|mm|inc|js|ts' - r'|proto|protodevel|java|cs|json)', +

[PATCH] D115149: [analyzer][solver] Fix assertion on (NonLoc, Op, Loc) expressions

ASDenysPetrov added a comment. > @steakhal > I don't get this one. I've provided a bunch of tests, even annotated with > `no-crash` comments where we crashed prior to this change. I wasn't able to catch any crashes with your tests file //(symbol-simplification-nonloc-loc.cpp)// on the baseline

[PATCH] D115625: [clang-format] add support for cppm files

MyDeveloperDay updated this revision to Diff 393858. MyDeveloperDay added a comment. Move cppm to be with other cxx extensions CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115625/new/ https://reviews.llvm.org/D115625 Files: clang/tools/clang-format/clang-format-diff.py clang/tools

[PATCH] D108367: [NFC] computeSPIRKernelABIInfo(): use SPIRABInfo

linjamaki abandoned this revision. linjamaki added a comment. D109818 includes the change in this patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108367/new/ https://reviews.llvm.org/D108367

[PATCH] D115604: [Support] Expand `<@>` as the base directory in response files.

jackoalan added a comment. In D115604#3188392 , @kadircet wrote: > IIUC, the new behavior being introduced by this patch is not the ability of > having a way to refer to other files in a config/response file relative way, > but rather extending that abi

Re: [clang] 9791b58 - [C++20 Modules] Don't create global module fragment for extern linkage declaration in GMF already

Hi Richard, Thanks for reporting this! I found the reason that why it didn't get tested previously is that we didn't use `extern "C"/"C++"` actually since we implemented partitions internally. Sorry for confusing. I would try to work on it. Thanks, Chuanqi ---

[PATCH] D115566: Quote some more destination paths with variables

ldionne accepted this revision. ldionne added a comment. This revision is now accepted and ready to land. This looks reasonable to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115566/new/ https://reviews.llvm.org/D115566 _

[PATCH] D115628: [clang][deps] Remove hard-coded resource directory from tests

mgorny accepted this revision. mgorny added a comment. This revision is now accepted and ready to land. I can confirm that the test failure is gone with this patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115628/new/ https://reviews.llvm.org/

[PATCH] D115628: [clang][deps] Remove hard-coded resource directory from tests

mgorny added a comment. I can confirm that the test failure is gone with this patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115628/new/ https://reviews.llvm.org/D115628 ___ cfe-commits mailing lis

[clang-tools-extra] a47af1a - [clangd][Dex] Fix crashes when building trigrams for empty identifier

Author: Kadir Cetinkaya Date: 2021-12-13T15:58:33+01:00 New Revision: a47af1ac343faba5581dfd243a8d8c56cb7f74b4 URL: https://github.com/llvm/llvm-project/commit/a47af1ac343faba5581dfd243a8d8c56cb7f74b4 DIFF: https://github.com/llvm/llvm-project/commit/a47af1ac343faba5581dfd243a8d8c56cb7f74b4.dif

[PATCH] D112646: [clang-tidy] Add `readability-container-contains` check

avogelsgesang added a comment. gentle ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112646/new/ https://reviews.llvm.org/D112646 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists

[PATCH] D113898: [NFC][clangd] cleaning up llvm-qualified-auto

kuhnel added a comment. In D113898#3167215 , @kbobyrev wrote: > In D113898#3167050 , @kuhnel wrote: > >> Looking at the documentation, this looks like a bug in the clang-tidy check: >> https://releases.llvm.org/13

[PATCH] D113898: [NFC][clangd] cleaning up llvm-qualified-auto

kuhnel updated this revision to Diff 393890. kuhnel added a comment. reverted the `const` as advised in Sam's comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113898/new/ https://reviews.llvm.org/D113898 Files: clang-tools-extra/clangd/AST.

[PATCH] D112024: [clang] diagnose_as attribute for Fortify diagnosing like builtins.

aaron.ballman accepted this revision. aaron.ballman added a comment. In D112024#3180347 , @mbenfield wrote: > @aaron.ballman Look to you like this is ready to land? > > EDIT: oops sorry, missed your latest comments, will address them shortly. Thanks for

[PATCH] D113898: [NFC][clangd] cleaning up llvm-qualified-auto

kuhnel updated this revision to Diff 393892. kuhnel added a comment. fixed more const ClangdTests.cpp Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113898/new/ https://reviews.llvm.org/D113898 Files: clang-tools-extra/clangd/AST.cpp clang-tool

[clang] 9db8162 - [NFC] Format .cppm files in tests

Author: Chuanqi Xu Date: 2021-12-13T23:32:25+08:00 New Revision: 9db8162820c49b2b9f17f3542b3cc2e05d8c00ea URL: https://github.com/llvm/llvm-project/commit/9db8162820c49b2b9f17f3542b3cc2e05d8c00ea DIFF: https://github.com/llvm/llvm-project/commit/9db8162820c49b2b9f17f3542b3cc2e05d8c00ea.diff LO

[PATCH] D113898: [NFC][clangd] cleaning up llvm-qualified-auto

kuhnel updated this revision to Diff 393894. kuhnel added a comment. more reverts of consts Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113898/new/ https://reviews.llvm.org/D113898 Files: clang-tools-extra/clangd/AST.cpp clang-tools-extra/cl

[PATCH] D115199: [X86][AMX] Support amxpreserve attribute in clang.

aaron.ballman added a comment. I'm worried about the extra overhead imposed on all users by this change. This appears to be adding another calling convention to Clang (despite the claim that it's not); can you share a motivation for why everyone should pay the price for adding it? ==

[PATCH] D113898: [NFC][clangd] cleaning up llvm-qualified-auto

kuhnel marked 3 inline comments as done. kuhnel added inline comments. Comment at: clang-tools-extra/clangd/unittests/HoverTests.cpp:2550 auto AST = TU.build(); - for (auto Comment : {"doc1", "doc2", "doc3"}) { + for (const auto *Comment : {"doc1", "doc2", "doc3"}) { fo

[PATCH] D115640: [OpenCL] Add support of __opencl_c_device_enqueue feature macro.

azabaznov created this revision. azabaznov added reviewers: Anastasia, svenvh. Herald added subscribers: Naghasan, ldrumm, yaxunl. azabaznov requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This feature requires support of __opencl_c_generic

[PATCH] D112230: [OpenCL] Add support of __opencl_c_device_enqueue feature macro.

azabaznov abandoned this revision. azabaznov added a comment. Now program scope global variables are required by device enqueue in the spec, new patch for device enqueue support: https://reviews.llvm.org/D115640 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[clang] 78b0f37 - [HIPSPV][1/4] Refactor HIP tool chain

Author: Yaxun (Sam) Liu Date: 2021-12-13T10:50:25-05:00 New Revision: 78b0f3701d441e887e92ff9feec4c226c67c334f URL: https://github.com/llvm/llvm-project/commit/78b0f3701d441e887e92ff9feec4c226c67c334f DIFF: https://github.com/llvm/llvm-project/commit/78b0f3701d441e887e92ff9feec4c226c67c334f.dif

[PATCH] D110549: [HIPSPV][1/4] Refactor HIP tool chain

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG78b0f3701d44: [HIPSPV][1/4] Refactor HIP tool chain (authored by yaxunl). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:/

[PATCH] D115561: [Clang][OpenMP] Add the support for atomic compare in parser

jdoerfert added a comment. All good but parser tests needed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115561/new/ https://reviews.llvm.org/D115561 ___ cfe-commits mailing list cfe-commits@lists.llvm

[PATCH] D115586: [NFC][Clang][OpenMP] Use switch-case statement to process clauses of atomic directive

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115586/new/ https://reviews.llvm.org/D115586 ___

[clang] 240be65 - Fix warning about unused variable in HIPAMD.cpp

Author: Yaxun (Sam) Liu Date: 2021-12-13T11:25:48-05:00 New Revision: 240be6541d49ee7c810cf60fb809409cbadd59c6 URL: https://github.com/llvm/llvm-project/commit/240be6541d49ee7c810cf60fb809409cbadd59c6 DIFF: https://github.com/llvm/llvm-project/commit/240be6541d49ee7c810cf60fb809409cbadd59c6.dif

[clang] 006fb62 - Fix build failure of HIPUtility.cpp on Windows

Author: Yaxun (Sam) Liu Date: 2021-12-13T11:53:06-05:00 New Revision: 006fb62434f58f69eb7d3d48c81975df2c002778 URL: https://github.com/llvm/llvm-project/commit/006fb62434f58f69eb7d3d48c81975df2c002778 DIFF: https://github.com/llvm/llvm-project/commit/006fb62434f58f69eb7d3d48c81975df2c002778.dif

[PATCH] D115501: [clang][ARM] Emit warnings when PACBTI-M is used with unsupported architectures

amilendra updated this revision to Diff 393917. amilendra added a comment. Address review comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115501/new/ https://reviews.llvm.org/D115501 Files: clang/lib/Basic/Targets/ARM.cpp clang/lib/Code

[PATCH] D115501: [clang][ARM] Emit warnings when PACBTI-M is used with unsupported architectures

amilendra updated this revision to Diff 393918. amilendra added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115501/new/ https://reviews.llvm.org/D115501 Files: clang/include/clang/Basic/DiagnosticCommonKinds.td clang/includ

[PATCH] D115634: [clangd] Cleanup of readability-identifier-naming

sammccall added a comment. Generally looks good with a few nits for individual names. The matcher cleanup is a problem though, because you haven't cleaned up the functions created using the macros `MATCHER`, `MATCHER_P`, `MATCHER_P2` etc. Presumably this is because names created through macros

[clang] c03c58c - Add missing textual header to module map

Author: Adrian Prantl Date: 2021-12-13T09:19:22-08:00 New Revision: c03c58c97ab8ac41c84b5269a40c0b35455e URL: https://github.com/llvm/llvm-project/commit/c03c58c97ab8ac41c84b5269a40c0b35455e DIFF: https://github.com/llvm/llvm-project/commit/c03c58c97ab8ac41c84b5269a40c0b35455e.diff

[PATCH] D115492: [LTO] Ignore unreachable virtual functions in WPD in hybrid LTO

luna updated this revision to Diff 393921. luna added a comment. Use GUID computed with exported function name as a fallback to look up index when there isn't an entry for current function GUID. - Based on feedback in https://reviews.llvm.org/D115203#inline-1104045 - The entry might be absent wh

[clang] 915d1c0 - Add missing textual header to module map

Author: Adrian Prantl Date: 2021-12-13T09:21:21-08:00 New Revision: 915d1c0b74b5e9462a9ae7cd684a70d1422c7f5a URL: https://github.com/llvm/llvm-project/commit/915d1c0b74b5e9462a9ae7cd684a70d1422c7f5a DIFF: https://github.com/llvm/llvm-project/commit/915d1c0b74b5e9462a9ae7cd684a70d1422c7f5a.diff

[PATCH] D115492: [LTO] Ignore unreachable virtual functions in WPD in hybrid LTO

luna updated this revision to Diff 393927. luna added a comment. Use type `auto` for GUID to fix a compile error. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115492/new/ https://reviews.llvm.org/D115492 Files: clang/test/CodeGen/thinlto-distri

[clang] ddcc02d - Quote some more destination paths with variables

Author: John Ericson Date: 2021-12-13T17:29:08Z New Revision: ddcc02dbcc4767b289776f73f26fe444964d0942 URL: https://github.com/llvm/llvm-project/commit/ddcc02dbcc4767b289776f73f26fe444964d0942 DIFF: https://github.com/llvm/llvm-project/commit/ddcc02dbcc4767b289776f73f26fe444964d0942.diff LOG:

[PATCH] D115647: [clang-format] FixNamespaceComments does not understand namespace aliases

MyDeveloperDay created this revision. MyDeveloperDay added reviewers: HazardyKnusperkeks, curdeius, owenpan. MyDeveloperDay added projects: clang, clang-format. Herald added a subscriber: jeroen.dobbelaere. MyDeveloperDay requested review of this revision. https://github.com/llvm/llvm-project/issu

[PATCH] D115648: [LTO] Ignore unreachable virtual functions in WPD in hybrid LTO

luna created this revision. Herald added subscribers: ormris, pengfei, arphaman, steven_wu, hiraditya, inglorion. luna requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. - In FunctionSummary, add a new bit `mustBeUnreachable

[PATCH] D112024: [clang] diagnose_as attribute for Fortify diagnosing like builtins.

mbenfield updated this revision to Diff 393942. mbenfield added a comment. Herald added a subscriber: jdoerfert. Fix test clang/test/Misc/pragma-attribute-supported-attributes-list.test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112024/new/ http

[PATCH] D115320: Avoid setting tbaa information on store of return type of call to inline assember

schittir updated this revision to Diff 393945. schittir added a comment. Changing test's CHECK lines CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115320/new/ https://reviews.llvm.org/D115320 Files: clang/lib/CodeGen/CGStmt.cpp clang/lib/CodeGen/CodeGenFunction.h clang/test/CodeG

[PATCH] D109981: [Diagnostics] Don't drop a statically set NoWarningAsError flag during option processing

wolfgangp added a comment. ping ... CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109981/new/ https://reviews.llvm.org/D109981 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D115320: Avoid setting tbaa information on store of return type of call to inline assember

schittir updated this revision to Diff 393948. schittir added a comment. Fix test format CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115320/new/ https://reviews.llvm.org/D115320 Files: clang/lib/CodeGen/CGStmt.cpp clang/lib/CodeGen/CodeGenFunction.h clang/test/CodeGen/avoidTBAA

[PATCH] D115441: [X86][MS] Add 80bit long double support for Windows

rnk added a comment. In D115441#3188526 , @mstorsjo wrote: > In D115441#3188172 , @pengfei wrote: > >>> In GCC on Windows (and clang in mingw mode), long double is always 80 bit >>> on x86. (On i386, sizeof(long

[PATCH] D114095: [clang][lex] Include tracking: simplify and move to preprocessor

vsapsai added a comment. In D114095#3188557 , @jansvoboda11 wrote: > Given that, I think we should commit this patch with ID vectors, even though > in isolation (without D112915 ) it's the > worse solution. WDYT? I ha

[PATCH] D115441: [X86][MS] Add 80bit long double support for Windows

JohnReagan added a comment. Does any of this impact the -f128 support? We use f128 x-float on OpenVMS. We've historically only aligned on 8-byte boundaries for legacy reasons (I'm not opposed to having my own mods to control the record layout and/or data layout) Repository: rG LLVM Github

[PATCH] D115650: [clangd] Disable support for clang-tidy suppression blocks (NOLINTBEGIN)

sammccall created this revision. sammccall added a reviewer: kadircet. Herald added subscribers: usaxena95, arphaman. sammccall requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. The implementation is very in

[PATCH] D115611: [X86][BF16] delete `typedef unsigned short __bfloat16`

craig.topper added inline comments. Comment at: clang/lib/Headers/avx512vlbf16intrin.h:416 ///and fraction field is truncated to 7 bits. -static __inline__ __bfloat16 __DEFAULT_FN_ATTRS128 _mm_cvtness_sbh(float __A) { +static __inline__ short __DEFAULT_FN_ATTRS128 _mm_cvtnes

[PATCH] D115647: [clang-format] FixNamespaceComments does not understand namespace aliases

curdeius added inline comments. Comment at: clang/lib/Format/NamespaceEndCommentsFixer.cpp:27 // Returns "" for anonymous namespace. -std::string computeName(const FormatToken *NamespaceTok) { +bool computeName(const FormatToken *NamespaceTok, std::string &name) { assert(Name

[PATCH] D115248: [clang] Fix PR28101

aaron.ballman added inline comments. Comment at: clang/lib/Parse/ParseDecl.cpp:6485-6488 +if (getLangOpts().CPlusPlus && !D.getIdentifier() && +D.getName().getKind() == UnqualifiedIdKind::IK_TemplateId && +D.getContext() == DeclaratorContext::Member) + D.

[PATCH] D115049: Fall back on Android triple w/o API level for runtimes search

collinbaker updated this revision to Diff 393978. collinbaker added a comment. - Address comments - Fix VEToolchain build error - Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115049/new/ https://reviews.llvm.org/D115049 Files: clang/incl

[PATCH] D115049: Fall back on Android triple w/o API level for runtimes search

collinbaker marked 2 inline comments as done. collinbaker added inline comments. Comment at: clang/lib/Driver/ToolChain.cpp:500 + if (getTriple().isAndroid() && + getTriple().getEnvironmentName() != "android") { +llvm::outs() << getTriple().getEnvironmentName() << "\n";

[PATCH] D115648: [LTO] Ignore unreachable virtual functions in WPD in hybrid LTO

luna updated this revision to Diff 393994. luna added a comment. Add unit test for thinlto. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115648/new/ https://reviews.llvm.org/D115648 Files: clang/test/CodeGen/thinlto-distributed-cfi-devirt.ll

[PATCH] D115661: [clang][amdgpu] - Choose when to promote VarDecl to address space 4.

estewart08 created this revision. estewart08 added a reviewer: JonChesterfield. Herald added subscribers: t-tye, tpr, dstuttard, yaxunl, kzhuravl. estewart08 requested review of this revision. Herald added subscribers: cfe-commits, wdng. Herald added a project: clang. There are instances where cla

[PATCH] D115661: [clang][amdgpu] - Choose when to promote VarDecl to address space 4.

estewart08 updated this revision to Diff 394002. estewart08 added a comment. Resubmit patch with lint. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115661/new/ https://reviews.llvm.org/D115661 Files: clang/lib/CodeGen/TargetInfo.cpp clang/tes

[PATCH] D108694: [RISCV] Add the zvl extension according to the v1.0 spec

craig.topper added inline comments. Comment at: llvm/lib/Support/RISCVISAInfo.cpp:714 void RISCVISAInfo::updateImplication() { + const StringMap> Implications = { + {"v", {"zvlsseg", "zvl128b"}}, I think I'd like to see this as a static data structure rath

[PATCH] D115661: [clang][amdgpu] - Choose when to promote VarDecl to address space 4.

arsenm added a comment. There's no real advantage to using addrspace(4) at all Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115661/new/ https://reviews.llvm.org/D115661 ___ cfe-commits mailing list cfe-

[PATCH] D115661: [clang][amdgpu] - Choose when to promote VarDecl to address space 4.

arsenm added a comment. In D115661#3190041 , @arsenm wrote: > There's no real advantage to using addrspace(4) at all There are a few places where it's used as an optimization hint / as a crutch where we don't have a proper analysis. Fundamentally I woul

[PATCH] D115647: [clang-format] FixNamespaceComments does not understand namespace aliases

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/NamespaceEndCommentsFixer.cpp:59 + // Namespace alias + if (Tok->isOneOf(tok::equal, tok::semi)) +return false; Should only be equal, right? Otherwise please add a test for s

[PATCH] D115647: [clang-format] FixNamespaceComments does not understand namespace aliases

MyDeveloperDay updated this revision to Diff 394010. MyDeveloperDay added a comment. Look backwards from the { rather than scanning the namespace CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115647/new/ https://reviews.llvm.org/D115647 Files: clang/lib/Format/NamespaceEndCommentsFix

[PATCH] D113372: [Driver] Add CLANG_DEFAULT_PIE_ON_LINUX to emulate GCC --enable-default-pie

MaskRay added a comment. In D113372#3188178 , @joerg wrote: > Last update introduced a lot of unrelated changes? But the actual intended > change seems fine now. The last update just did a renaming. I have checked that changes are all intended. Repos

[PATCH] D115647: [clang-format] FixNamespaceComments does not understand namespace aliases

curdeius accepted this revision. curdeius added a comment. This revision is now accepted and ready to land. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115647/new/ https://reviews.llvm.org/D115647 ___ cfe-commits mailing list cfe-comm

[PATCH] D113372: [Driver] Add CLANG_DEFAULT_PIE_ON_LINUX to emulate GCC --enable-default-pie

MaskRay updated this revision to Diff 394015. MaskRay added a comment. Rename test/Driver/default-pie.c to linux-default-pie.c clang-format a region. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113372/new/ https://reviews.llvm.org/D113372 Files

[PATCH] D115580: [clang] [unitttests] Fix linking Basic test to LLVMTestingSupport

MaskRay added a comment. > in order to fix linking when building clang against libclang I am confused by building `clang against libclang`. libclang is the C library (`libclang.so` on ELF platforms). Do you mean `CLANG_LINK_CLANG_DYLIB` `libclang-cpp.so`? What's your cmake command line to trigg

[PATCH] D113622: [wip] [analyzer] support ignoring use-after-free checking with reference_counted attribute

chrisdangelo updated this revision to Diff 394017. chrisdangelo added a comment. These changes allow the analyzer to silence an issue discovered by MallocChecker if the SymRef or Statement in question is of a struct that has been declared with the compiler attribute annotation "reference_counted

[PATCH] D115561: [Clang][OpenMP] Add the support for atomic compare in parser

mikerice added a comment. Note you'll want to add a line to flang/lib/Semantics/check-omp-structure.cpp for the new clause or the flang build will fail. CHECK_SIMPLE_CLAUSE(Compare, OMPC_compare) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D11556

[PATCH] D115580: [clang] [unitttests] Fix linking Basic test to LLVMTestingSupport

mgorny added a comment. Yes, I'm sorry, I meant libclang-cpp. FAILED: unittests/Basic/BasicTests : && /usr/lib/ccache/bin/x86_64-pc-linux-gnu-g++ -m32 -march=znver2 --param l1-cache-size=32 --param l1-cache-line-size=64 -O2 -pipe -frecord-gcc-switches -fPIC -fno-semantic-interposition -fvi

[clang] 5c23acb - [NFC][Clang][OpenMP] Use switch-case statement to process clauses of atomic directive

Author: Shilei Tian Date: 2021-12-13T16:20:10-05:00 New Revision: 5c23acbc023fbb9fdc6c56f4d2212ecb0432874e URL: https://github.com/llvm/llvm-project/commit/5c23acbc023fbb9fdc6c56f4d2212ecb0432874e DIFF: https://github.com/llvm/llvm-project/commit/5c23acbc023fbb9fdc6c56f4d2212ecb0432874e.diff L

[PATCH] D115586: [NFC][Clang][OpenMP] Use switch-case statement to process clauses of atomic directive

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5c23acbc023f: [NFC][Clang][OpenMP] Use switch-case statement to process clauses of atomic… (authored by tianshilei1992). Repository: rG LLVM Githu

[PATCH] D115670: Correct behavior of Vector boolean-operations, implement vector operator-

erichkeane created this revision. erichkeane added reviewers: RKSimon, aaron.ballman, void, efriedma. erichkeane requested review of this revision. All of our boolean operations on vector types should be using something like vcmpeqd, which results in a mask of '-1' for the 'truth' type. We are cur

[PATCH] D115670: Correct behavior of Vector boolean-operations, implement vector operator-

erichkeane added a comment. Note I am adding the folks who were added as reviewers the last time I did vector constexpr work: https://reviews.llvm.org/D79755 I again looked into operator[] to simplify things, but the 'LValueBase' stuff (seemingly required to do something like: VecTy[3] = 1;) is

[PATCH] D115661: [clang][amdgpu] - Choose when to promote VarDecl to address space 4.

JonChesterfield added a comment. Patch looks ok to me. This will fix the miscompile (we end up with a store to addrspace(4) at present) without upsetting whatever hacks rely on addrspace(4). @arsenm reasonable as a point fix? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

  1   2   >