[PATCH] D114142: [clang-format] [PR52527] can join * with /* to form an outside of comment error C4138

owenpan added a comment. In D114142#3139756 , @MyDeveloperDay wrote: > I'm thinking that those cases are handled else where I was aware of that, but I didn't see `* //` was handled and tested explicitly. IMO, using `tok::comment` and adding a test case

[PATCH] D107944: [hmaptool] Port to python3

ivanmurashko added inline comments. Comment at: clang/utils/hmaptool/hmaptool:223 with open(output_path, 'wb') as f: f.write(magic.encode()) f.write(struct.pack(header_fmt, *header)) `magic` is a bytes object that does not have `encode()` m

[PATCH] D114095: [clang][lex] Include tracking: simplify and move to preprocessor

jansvoboda11 updated this revision to Diff 388407. jansvoboda11 added a comment. Add new record into block info. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114095/new/ https://reviews.llvm.org/D114095 Files: clang/include/clang/Lex/HeaderSear

[PATCH] D114095: [clang][lex] Include tracking: simplify and move to preprocessor

jansvoboda11 marked an inline comment as done. jansvoboda11 added inline comments. Comment at: clang/lib/Lex/Preprocessor.cpp:552 +if (const FileEntry *FE = SourceMgr.getFileEntryForID(MainFileID)) { + HeaderInfo.getFileInfo(FE); + markIncluded(FE);

[PATCH] D112915: [clang][modules] Track included files per submodule

jansvoboda11 updated this revision to Diff 388409. jansvoboda11 added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112915/new/ https://reviews.llvm.org/D112915 Files: clang/include/clang/Lex/ExternalPreprocessorSource.h clan

[PATCH] D114142: [clang-format] [PR52527] can join * with /* to form an outside of comment error C4138

MyDeveloperDay added a comment. > I only now this from the tests with `-debug`. Is there a way to get "normal" > clang-format to print these? Or did you write a test for that to print the > information? I just use the --debug option to clang-format.exe? I develop on windows, using Visual Studi

[PATCH] D114173: [clang][modules] Apply local submodule visibility to includes

jansvoboda11 updated this revision to Diff 388410. jansvoboda11 added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114173/new/ https://reviews.llvm.org/D114173 Files: clang/include/clang/Lex/Preprocessor.h clang/lib/Lex/Prep

[PATCH] D113246: [clang][tests] Fix expected output of plugin-attribute test

tbaeder abandoned this revision. tbaeder added a comment. Already fixed by 50082e1882ae7fe101e563c5e18a27e0804d517b Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113246/new/ htt

[PATCH] D114162: [X86][clang] Enable floating-point type for -mno-x87 option on 32-bits

asavonic added inline comments. Comment at: clang/lib/Basic/Targets/X86.cpp:385 - if (!HasX87) { -if (LongDoubleFormat == &llvm::APFloat::x87DoubleExtended()) - HasLongDouble = false; -if (getTriple().getArch() == llvm::Triple::x86) - HasFPReturn = false; -

[clang-tools-extra] 85e03cb - [clang-tidy] fix debug-only test failure

Author: Matt Beardsley Date: 2021-11-19T10:19:07+01:00 New Revision: 85e03cb7ebac50a13a9a9ac92a0b184a3bba9be1 URL: https://github.com/llvm/llvm-project/commit/85e03cb7ebac50a13a9a9ac92a0b184a3bba9be1 DIFF: https://github.com/llvm/llvm-project/commit/85e03cb7ebac50a13a9a9ac92a0b184a3bba9be1.diff

[PATCH] D114034: [clang-tidy] fix debug-only test failure

This revision was automatically updated to reflect the committed changes. Closed by commit rG85e03cb7ebac: [clang-tidy] fix debug-only test failure (authored by mattbeardsley, committed by kbobyrev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1140

[PATCH] D114034: [clang-tidy] fix debug-only test failure

kbobyrev added a comment. In D114034#3141446 , @mattbeardsley wrote: > @dstenb Thanks for the confirmation! > > @kbobyrev Sorry about my mixup! Would you be able to help me commit this? Done! Thank you for the patch! Repository: rG LLVM Github Monor

[clang-tools-extra] 6259016 - [clang-tidy] Fix false positive in readability-identifier-naming check involving override attribute

Author: Fabian Wolff Date: 2021-11-19T22:31:11+13:00 New Revision: 6259016361345e09f0607ef4e037e00bcbe4bd40 URL: https://github.com/llvm/llvm-project/commit/6259016361345e09f0607ef4e037e00bcbe4bd40 DIFF: https://github.com/llvm/llvm-project/commit/6259016361345e09f0607ef4e037e00bcbe4bd40.diff

[PATCH] D113830: [clang-tidy] Fix false positive in `readability-identifier-naming` check involving `override` attribute

This revision was automatically updated to reflect the committed changes. Closed by commit rG625901636134: [clang-tidy] Fix false positive in readability-identifier-naming check… (authored by fwolff, committed by salman-javed-nz). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D114162: [X86][clang] Enable floating-point type for -mno-x87 option on 32-bits

pengfei added inline comments. Comment at: clang/lib/Basic/Targets/X86.cpp:385 - if (!HasX87) { -if (LongDoubleFormat == &llvm::APFloat::x87DoubleExtended()) - HasLongDouble = false; -if (getTriple().getArch() == llvm::Triple::x86) - HasFPReturn = false; - }

[PATCH] D113250: [clang][driver] Add -fplugin-arg- to pass arguments to plugins

tbaeder updated this revision to Diff 388417. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113250/new/ https://reviews.llvm.org/D113250 Files: clang/docs/ClangPlugins.rst clang/docs/ReleaseNotes.rst clang/examples/CallSuperAttribute/CallSuperAttrInfo.cpp clang/include/clang/Driv

[PATCH] D114151: [clang-format] [C++20] [Module] clang-format couldn't recognize partitions

MyDeveloperDay updated this revision to Diff 388419. MyDeveloperDay added a comment. Add yet more unit tests and cover those. Mark one test as TODO as I'm not sure if its allowed syntax CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114151/new/ https://reviews.llvm.org/D114151 Files:

[PATCH] D112913: Misleading bidirectional detection

serge-sans-paille updated this revision to Diff 388424. serge-sans-paille added a comment. Rebase on main branch CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112913/new/ https://reviews.llvm.org/D112913 Files: clang-tools-extra/clang-tidy/misc/CMakeLists.txt clang-tools-extra/clan

[PATCH] D112913: Misleading bidirectional detection

serge-sans-paille added a comment. Patch rebased on main, all comments addressed. Looks good? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112913/new/ https://reviews.llvm.org/D112913 ___ cfe-commits mailing list cfe-commits@lists.llvm.org h

[PATCH] D112913: Misleading bidirectional detection

serge-sans-paille updated this revision to Diff 388425. serge-sans-paille added a comment. Nits CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112913/new/ https://reviews.llvm.org/D112913 Files: clang-tools-extra/clang-tidy/misc/CMakeLists.txt clang-tools-extra/clang-tidy/misc/MiscT

[PATCH] D114162: [X86][clang] Enable floating-point type for -mno-x87 option on 32-bits

asavonic added inline comments. Comment at: clang/lib/Basic/Targets/X86.cpp:385 - if (!HasX87) { -if (LongDoubleFormat == &llvm::APFloat::x87DoubleExtended()) - HasLongDouble = false; -if (getTriple().getArch() == llvm::Triple::x86) - HasFPReturn = false; -

[PATCH] D114229: [clang][driver] Always add LTO options when using GNU toolchain

tbaeder created this revision. tbaeder added reviewers: MaskRay, fhahn, tejohnson. Herald added subscribers: ormris, steven_wu, hiraditya, inglorion. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is what the GCC driver does a

[PATCH] D114006: [analyzer][NFC] Enable access to CodeGenOptions from analyzer's instances

martong accepted this revision. martong added a comment. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114006/new/ https://reviews.llvm.org/D114006 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/m

[PATCH] D113118: [clang][AST] Check context of record in structural equivalence.

martong accepted this revision. martong added a comment. This revision is now accepted and ready to land. Thanks @balazske for updating the tests, I think this addresses @shafik 's questions. LGTM! Ping @shafik Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.l

[PATCH] D113558: [clang-tidy] Fix cppcoreguidelines-virtual-base-class-destructor in macros

steakhal added a comment. ping Comment at: clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines-virtual-class-destructor.cpp:288 +protected: + virtual CONCAT(~Foo, Bar2()); // no-fixit +}; whisperity wrote: > whisperity wrote: > > It is strange that t

[clang] f3753ad - [ASTImporter][NFC] Dump decl name at assertion violation

Author: Balazs Benics Date: 2021-11-19T11:31:01+01:00 New Revision: f3753ad774506804ef5df065b48268712bdaa554 URL: https://github.com/llvm/llvm-project/commit/f3753ad774506804ef5df065b48268712bdaa554 DIFF: https://github.com/llvm/llvm-project/commit/f3753ad774506804ef5df065b48268712bdaa554.diff

[PATCH] D113668: [ASTImporter][NFC] Dump decl name at assertion violation

This revision was automatically updated to reflect the committed changes. Closed by commit rGf3753ad77450: [ASTImporter][NFC] Dump decl name at assertion violation (authored by steakhal). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo

[PATCH] D46081: [analyzer] Expand conversion check to check more expressions for overflow and underflow

martong added a comment. @whisperity Thank you for pinging! This seems still feasible. Besides, this is valuable for us, as it could pass some SEI CERT test cases, notably from INT31

[PATCH] D46081: [analyzer] Expand conversion check to check more expressions for overflow and underflow

martong added inline comments. Comment at: lib/StaticAnalyzer/Checkers/ConversionChecker.cpp:102 } - } else if (isa(Parent)) { + } else if (isa(Parent) || isa(Parent)) { +if (!Cast->IgnoreParenImpCasts()->isEvaluatable(C.getASTContext())) { CHANGES

[clang] bf55b9f - [analyzer][docs] Ellaborate the docs of cplusplus.StringChecker

Author: Balazs Benics Date: 2021-11-19T11:59:46+01:00 New Revision: bf55b9f0d0e938def5d24629325b271cbfc3b04a URL: https://github.com/llvm/llvm-project/commit/bf55b9f0d0e938def5d24629325b271cbfc3b04a DIFF: https://github.com/llvm/llvm-project/commit/bf55b9f0d0e938def5d24629325b271cbfc3b04a.diff

[PATCH] D113401: [analyzer][docs] Ellaborate the docs of cplusplus.StringChecker

This revision was automatically updated to reflect the committed changes. Closed by commit rGbf55b9f0d0e9: [analyzer][docs] Ellaborate the docs of cplusplus.StringChecker (authored by steakhal). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Mo

[PATCH] D107450: [clang-tidy] Fix wrong FixIt in performance-move-const-arg

Sockke added a comment. Kindly ping. @whisperity CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107450/new/ https://reviews.llvm.org/D107450 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinf

[PATCH] D114234: [clang][dataflow] Add base types for building dataflow analyses

sgatev created this revision. sgatev added reviewers: ymandel, NoQ, xazax.hun, gribozavr. Herald added subscribers: rnkovacs, mgorny. sgatev requested review of this revision. Herald added a project: clang. This is part of the implementation of the dataflow analysis framework. See "[RFC] A dataflo

[PATCH] D113995: [clangd] Dex Trigrams: Improve query trigram generation

kbobyrev updated this revision to Diff 388461. kbobyrev added a comment. Add improvements for identifier trigram generation and make query & id generators consistent with each other. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113995/new/ https:/

[PATCH] D114235: [clang] Extend ParsedAttr to allow custom handling for type attributes

mboehme created this revision. mboehme added a reviewer: aaron.ballman. mboehme added a project: clang. mboehme requested review of this revision. Herald added a subscriber: cfe-commits. A typical use case would be to allow custom attributes for pointer types. See examples/Attribute/Attribute.cpp

[PATCH] D114234: [clang][dataflow] Add base types for building dataflow analyses

sgatev updated this revision to Diff 388465. sgatev added a comment. Fix ifndefs. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114234/new/ https://reviews.llvm.org/D114234 Files: clang/include/clang/Analysis/FlowSensitive/DataflowAnalysis.h c

[PATCH] D114234: [clang][dataflow] Add base types for building dataflow analyses

sgatev updated this revision to Diff 388469. sgatev added a comment. Use triple slash at the start of declaration comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114234/new/ https://reviews.llvm.org/D114234 Files: clang/include/clang/Ana

[PATCH] D114025: [clang][NFC] Inclusive terms: replace some uses of sanity in clang

aaron.ballman accepted this revision. aaron.ballman added a comment. In D114025#3141414 , @keryell wrote: > In D114025#3140192 , @Quuxplusone > wrote: > >> I think "sanity-check" could be reasonably replaced with

[clang] c227192 - Make clang-format fuzz through Lexing with asserts enabled.

Author: Manuel Klimek Date: 2021-11-19T14:44:06+01:00 New Revision: c2271926a4fc395e05cf75a8e57c2dfab1f02d3d URL: https://github.com/llvm/llvm-project/commit/c2271926a4fc395e05cf75a8e57c2dfab1f02d3d DIFF: https://github.com/llvm/llvm-project/commit/c2271926a4fc395e05cf75a8e57c2dfab1f02d3d.diff

[clang] 6623c02 - The _Float16 type is supported on x86 systems with SSE2 enabled.

Author: Zahira Ammarguellat Date: 2021-11-19T08:59:50-05:00 New Revision: 6623c02d70c3732dbea59c6d79c69501baf9627b URL: https://github.com/llvm/llvm-project/commit/6623c02d70c3732dbea59c6d79c69501baf9627b DIFF: https://github.com/llvm/llvm-project/commit/6623c02d70c3732dbea59c6d79c69501baf9627b

[PATCH] D103094: [analyzer] Implemented RangeSet::Factory::castTo function to perform promotions, truncations and conversions

ASDenysPetrov updated this revision to Diff 388481. ASDenysPetrov added a comment. Rebased. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103094/new/ https://reviews.llvm.org/D103094 Files: clang/include/clang/StaticAnalyzer/Core/PathSensitive/APSIntType.h clang/include/clang/Stat

[PATCH] D114206: [Clang][ScanDeps] Use the virtual path for module maps

jansvoboda11 accepted this revision. jansvoboda11 added a comment. This revision is now accepted and ready to land. LGTM provided the Windows crash gets resolved. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114206/new/ https://reviews.llvm.org/D1

[PATCH] D114099: Enable `_Float16` type support on X86 without the avx512fp16 flag

zahiraam added a comment. rG6623c02d70c3 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114099/new/ https://reviews.llvm.org/D114099 ___ cfe-commits mailing list cfe-commit

[PATCH] D114234: [clang][dataflow] Add base types for building dataflow analyses

ymandel added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/DataflowAnalysis.cpp:21-22 + +namespace clang { +namespace dataflow { + It's more common in .cpp files to use using declarations instead: ``` using clang; using dataflow; ``` Repository

[PATCH] D114229: [clang][driver] Always add LTO options when using GNU toolchain

tbaeder added a comment. The test failures are pretty obvious about when this fails. All affected builds have an implicit dependency on the `LLVMgold.so` like this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114229/new/ https://reviews.llvm.org

[clang] 8025660 - [OpenMP] support depend clause for taskwait directive, by Deepak

Author: Alexey Bataev Date: 2021-11-19T06:30:17-08:00 New Revision: 80256605f8c6aab8cb33ac3a3784aacd005087a3 URL: https://github.com/llvm/llvm-project/commit/80256605f8c6aab8cb33ac3a3784aacd005087a3 DIFF: https://github.com/llvm/llvm-project/commit/80256605f8c6aab8cb33ac3a3784aacd005087a3.diff

[PATCH] D113540: [OpenMP] support depend clause for taskwait directive

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG80256605f8c6: [OpenMP] support depend clause for taskwait directive, by Deepak (authored by ABataev). Herald added projects: clang, OpenMP. Herald ad

[PATCH] D114234: [clang][dataflow] Add base types for building dataflow analyses

sgatev updated this revision to Diff 388490. sgatev added a comment. Add using namespace declarations in the cpp file. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114234/new/ https://reviews.llvm.org/D114234 Files: clang/include/clang/Analysis

[PATCH] D114025: [clang][NFC] Inclusive terms: replace some uses of sanity in clang

ZarkoCA marked 3 inline comments as done. ZarkoCA added a comment. In D114025#3142565 , @aaron.ballman wrote: > In D114025#3141414 , @keryell wrote: > >> In D114025#3140192

[PATCH] D114025: [clang][NFC] Inclusive terms: replace some uses of sanity in clang

ZarkoCA updated this revision to Diff 388494. ZarkoCA added a comment. - Add FIXME to comments and fix grammar on one comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114025/new/ https://reviews.llvm.org/D114025 Files: clang/include/clang/A

[PATCH] D113754: [Analyzer][Core] Simplify IntSym in SValBuilder

martong added a comment. In D113754#3127245 , @steakhal wrote: > Great stuff. Have you checked the coverage? Thanks for the review! So, here are the coverage results for the new test file: 1186 2 : SVal VisitIntSymExpr(const IntSymExpr *

[PATCH] D114151: [clang-format] [C++20] [Module] clang-format couldn't recognize partitions

owenpan added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:3226 +// No space between module :. +if (Left.isOneOf(Keywords.kw_module, tok::kw_export, Keywords.kw_import) && +Right.is(TT_ModulePartitionColon)) You can remove `kw_

[PATCH] D114151: [clang-format] [C++20] [Module] clang-format couldn't recognize partitions

Quuxplusone added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:3235 +if (Left.is(TT_ModulePartitionColon) && +Right.isOneOf(tok::identifier, tok::kw_public, tok::kw_private)) + return false; owenpan wrote: > Is `module :public

[PATCH] D114229: [clang][driver] Always add LTO options when using GNU toolchain

tejohnson added inline comments. Comment at: clang/lib/Driver/ToolChains/Gnu.cpp:558 assert(!Inputs.empty() && "Must have at least one input."); addLTOOptions(ToolChain, Args, CmdArgs, Output, Inputs[0], D.getLTOMode() == LTOK_Thin);

[PATCH] D114249: [clang-tidy] performance-unnecessary-copy-initialization: Fix false negative.

courbet created this revision. courbet added reviewers: flx, aaron.ballman. Herald added subscribers: carlosgalvezp, xazax.hun. courbet requested review of this revision. Herald added a project: clang-tools-extra. `isConstRefReturningMethodCall` should be considering `CXXOperatorCallExpr` in addit

[PATCH] D113754: [Analyzer][Core] Simplify IntSym in SValBuilder

steakhal added a comment. Great news, thanks. Comment at: clang/test/Analysis/svalbuilder-simplify-intsym.cpp:18 +return; + clang_analyzer_eval(x == 77); // expected-warning{{TRUE}} + (void)(x * y); extra spaces? Repository: rG LLVM Github Mon

[PATCH] D114025: [clang][NFC] Inclusive terms: replace some uses of sanity in clang

Quuxplusone added a comment. (Re repeated thanks: You're welcome. :) For the record, I personally see nothing wrong with the phrase "sanity-check" either; but given that it's gonna happen, and we're re-wording comments on by definition the subtlest and most confusing parts of the code, I'm tryi

[PATCH] D114251: [AST] Add a sugar type for types found via UsingDecl

sammccall created this revision. Herald added subscribers: dexonsmith, usaxena95, kadircet, arphaman, martong. sammccall requested review of this revision. Herald added projects: clang, clang-tools-extra. Herald added a subscriber: cfe-commits. WIP: - needs tests of new functionality - doesn't ha

[PATCH] D114108: [NFC][clang] Inclusive language: rename master variable to controller in debug-info-block-helper.m

quinnp updated this revision to Diff 388511. quinnp added a comment. Changing master to controller in another testcase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114108/new/ https://reviews.llvm.org/D114108 Files: clang/test/CodeGenObjC/debu

[PATCH] D114116: [clang][ARM] relax -mtp=cp15 for ARMv6 non-thumb cases

peter.smith added inline comments. Comment at: clang/lib/Driver/ToolChains/Arch/ARM.cpp:155 + llvm::ARM::ArchKind AK = llvm::ARM::parseArch(Triple.getArchName()); + return Ver >= 7 || AK == llvm::ARM::ArchKind::ARMV6T2 || + (Ver == 6 && Triple.isARM());

[PATCH] D103094: [analyzer] Implemented RangeSet::Factory::castTo function to perform promotions, truncations and conversions

ASDenysPetrov updated this revision to Diff 388512. ASDenysPetrov added a comment. Fixed missed part during rebasing in the unit test. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103094/new/ https://reviews.llvm.org/D103094 Files: clang/include/clang/StaticAnalyzer/Core/PathSensiti

[Diffusion] rGc93f93b2e3f2: Revert "Revert "Recommit "Revert "[CVP] processSwitch: Remove default case when…

alexfh added subscribers: cfe-commits, alexfh, bgraur. BRANCHES main Users: junparser (Author) https://reviews.llvm.org/rGc93f93b2e3f2 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm

[PATCH] D114254: [libtooling][clang-tidy] Fix crashing on rendering invalid SourceRanges

steakhal created this revision. steakhal added reviewers: aaron.ballman, njames93, klimek, alexfh. Herald added subscribers: carlosgalvezp, martong, xazax.hun. steakhal requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Invalid Sou

[PATCH] D114256: [clang-tidy] Fix crashing altera-struct-pack-align on invalid RecordDecls

steakhal created this revision. steakhal added reviewers: ffrankies, aaron.ballman, alexfh, njames93. Herald added subscribers: carlosgalvezp, martong, xazax.hun. steakhal requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. https://

[clang] d448fcd - [analyzer][NFC] Introduce CallDescriptionSets

Author: Balazs Benics Date: 2021-11-19T18:32:13+01:00 New Revision: d448fcd9b2238377dd8832ce9e35a37b59ef5aeb URL: https://github.com/llvm/llvm-project/commit/d448fcd9b2238377dd8832ce9e35a37b59ef5aeb DIFF: https://github.com/llvm/llvm-project/commit/d448fcd9b2238377dd8832ce9e35a37b59ef5aeb.diff

[clang] 6c51270 - [analyzer][NFC] Introduce CallDescription::matches() in addition to isCalled()

Author: Balazs Benics Date: 2021-11-19T18:32:13+01:00 New Revision: 6c512703a9e6e495afa0f44528821c27f28db795 URL: https://github.com/llvm/llvm-project/commit/6c512703a9e6e495afa0f44528821c27f28db795 DIFF: https://github.com/llvm/llvm-project/commit/6c512703a9e6e495afa0f44528821c27f28db795.diff

[clang] f18da19 - [analyzer][NFC] Switch to using CallDescription::matches() instead of isCalled()

Author: Balazs Benics Date: 2021-11-19T18:32:13+01:00 New Revision: f18da190b0dba817d33ccd7727537f12304d8125 URL: https://github.com/llvm/llvm-project/commit/f18da190b0dba817d33ccd7727537f12304d8125 DIFF: https://github.com/llvm/llvm-project/commit/f18da190b0dba817d33ccd7727537f12304d8125.diff

[clang] 9ad0a90 - [analyzer][NFC] Demonstrate the use of CallDescriptionSet

Author: Balazs Benics Date: 2021-11-19T18:32:13+01:00 New Revision: 9ad0a90baa8ca8067fe65086056fffd083c86796 URL: https://github.com/llvm/llvm-project/commit/9ad0a90baa8ca8067fe65086056fffd083c86796 DIFF: https://github.com/llvm/llvm-project/commit/9ad0a90baa8ca8067fe65086056fffd083c86796.diff

[clang] de9d7e4 - [analyzer][NFC] CallDescription should own the qualified name parts

Author: Balazs Benics Date: 2021-11-19T18:32:13+01:00 New Revision: de9d7e42aca29920e9918ecaed4ad9c45fa673f1 URL: https://github.com/llvm/llvm-project/commit/de9d7e42aca29920e9918ecaed4ad9c45fa673f1 DIFF: https://github.com/llvm/llvm-project/commit/de9d7e42aca29920e9918ecaed4ad9c45fa673f1.diff

[clang] 97f1bf1 - [analyzer][NFC] Consolidate the inner representation of CallDescriptions

Author: Balazs Benics Date: 2021-11-19T18:32:13+01:00 New Revision: 97f1bf15b154ef32608fe17b82f2f312401d150c URL: https://github.com/llvm/llvm-project/commit/97f1bf15b154ef32608fe17b82f2f312401d150c DIFF: https://github.com/llvm/llvm-project/commit/97f1bf15b154ef32608fe17b82f2f312401d150c.diff

[clang] e6ef134 - [analyzer][NFC] Use enum for CallDescription flags

Author: Balazs Benics Date: 2021-11-19T18:32:13+01:00 New Revision: e6ef134f3c77005438f9fb7c1d17d3c30747844e URL: https://github.com/llvm/llvm-project/commit/e6ef134f3c77005438f9fb7c1d17d3c30747844e DIFF: https://github.com/llvm/llvm-project/commit/e6ef134f3c77005438f9fb7c1d17d3c30747844e.diff

[PATCH] D113589: [analyzer][NFC] Introduce CallDescriptionSets

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd448fcd9b223: [analyzer][NFC] Introduce CallDescriptionSets (authored by steakhal). Herald added a project: clang. Herald added a subscriber: cfe-com

[PATCH] D113590: [analyzer][NFC] Introduce CallDescription::matches() in addition to isCalled()

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6c512703a9e6: [analyzer][NFC] Introduce CallDescription::matches() in addition to isCalled() (authored by steakhal). Herald added a project: clang. H

[PATCH] D113591: [analyzer][NFC] Switch to using CallDescription::matches() instead of isCalled()

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf18da190b0db: [analyzer][NFC] Switch to using CallDescription::matches() instead of isCalled() (authored by steakhal). Herald added a project: clang.

[PATCH] D113592: [analyzer][NFC] Demonstrate the use of CallDescriptionSet

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9ad0a90baa8c: [analyzer][NFC] Demonstrate the use of CallDescriptionSet (authored by steakhal). Herald added a project: clang. Herald added a subscri

[PATCH] D113593: [analyzer][NFC] CallDescription should own the qualified name parts

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGde9d7e42aca2: [analyzer][NFC] CallDescription should own the qualified name parts (authored by steakhal). Herald added a project: clang. Herald added

[PATCH] D113594: [analyzer][NFC] Consolidate the inner representation of CallDescriptions

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG97f1bf15b154: [analyzer][NFC] Consolidate the inner representation of CallDescriptions (authored by steakhal). Herald added a project: clang. Herald

[PATCH] D113595: [analyzer][NFC] Use enum for CallDescription flags

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe6ef134f3c77: [analyzer][NFC] Use enum for CallDescription flags (authored by steakhal). Herald added a project: clang. Herald added a subscriber: cf

[Diffusion] rGc93f93b2e3f2: Revert "Revert "Recommit "Revert "[CVP] processSwitch: Remove default case when…

bgraur added a comment. Early heads up that this revision causes a large regression in compilation time for some of our internal source files: we are seeing seeing an almost 20x increase in compilation times for some files (from 42s to 728s). I'm working on a reproducer which I'm going to uploa

[clang] d5de568 - [analyzer][NFC] MaybeUInt -> MaybeCount

Author: Balazs Benics Date: 2021-11-19T18:36:55+01:00 New Revision: d5de568cc7375281b14bd2632576bff7f4afabc3 URL: https://github.com/llvm/llvm-project/commit/d5de568cc7375281b14bd2632576bff7f4afabc3 DIFF: https://github.com/llvm/llvm-project/commit/d5de568cc7375281b14bd2632576bff7f4afabc3.diff

[PATCH] D113250: [clang][driver] Add -fplugin-arg- to pass arguments to plugins

MaskRay added inline comments. Comment at: clang/docs/ClangPlugins.rst:131 + +The clang compiler driver accepts the `fplugin` option to load a plugin. +Clang plugins can receive arguments from the compiler driver command Comment at: clang/docs

[PATCH] D114025: [clang][NFC] Inclusive terms: replace some uses of sanity in clang

ZarkoCA updated this revision to Diff 388550. ZarkoCA marked 3 inline comments as done. ZarkoCA added a comment. - Address latest round of comments - Fix unrelated formatting to stop distracting clang-format linter complaints Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[PATCH] D114025: [clang][NFC] Inclusive terms: replace some uses of sanity in clang

ZarkoCA added inline comments. Comment at: clang/lib/Sema/SemaDeclCXX.cpp:9176 // Don't check the implicit member of the anonymous union type. - // This is technically non-conformant, but sanity demands it. + // This is technically non-conformant, but validation

[PATCH] D103096: [analyzer] Implement cast for ranges of symbolic integers

ASDenysPetrov updated this revision to Diff 388552. ASDenysPetrov added a comment. Rebased. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103096/new/ https://reviews.llvm.org/D103096 Files: clang/include/clang/StaticAnalyzer/Checkers/SValExplainer.h clang/include/clang/StaticAnalyz

[PATCH] D114006: [analyzer][NFC] Enable access to CodeGenOptions from analyzer's instances

ASDenysPetrov added a comment. In D114006#3142313 , @martong wrote: > LGTM! Thanks, guys! I'll load it as soon as D110927 also be ready for load(I'm working on it), as this patch is just a preparatory one. CHANGES SI

[PATCH] D114025: [clang][NFC] Inclusive terms: replace some uses of sanity in clang

Quuxplusone added inline comments. Comment at: clang/lib/Sema/SemaDeclCXX.cpp:9176 // Don't check the implicit member of the anonymous union type. - // This is technically non-conformant, but sanity demands it. + // This is technically non-conformant, but validat

[PATCH] D107944: [hmaptool] Port to python3

lanza updated this revision to Diff 388568. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107944/new/ https://reviews.llvm.org/D107944 Files: clang/utils/hmaptool/hmaptool Index: clang/utils/hmaptool/hmaptool === --- cla

[PATCH] D114268: [InstrProf] Use i32 for GEP index from lowering llvm.instrprof.increment

ellis created this revision. Herald added subscribers: wenlei, arphaman, hiraditya. ellis updated this revision to Diff 388564. ellis added a comment. ellis edited the summary of this revision. ellis added a reviewer: MaskRay. ellis retitled this revision from "[InstrProf] Use i32 for GEP index" to

[PATCH] D114095: [clang][lex] Include tracking: simplify and move to preprocessor

vsapsai added inline comments. Comment at: clang/lib/Serialization/ASTWriter.cpp:873 RECORD(PP_TOKEN); + RECORD(PP_INCLUDED_FILES); I believe `PP_INCLUDED_FILES` is located in `AST_BLOCK`. Yes, you write it in `ASTWriter::WritePreprocessor` but after `Stre

[PATCH] D71016: [SYCL] Implement OpenCL kernel function generation

zahiraam added a comment. Added in the sycl_special_class attribute. This is still work in progress as I still have a few LIT tests failing and didn't address the issue of the separating sema from codegen work. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71016/new/ https://reviews.l

[PATCH] D114231: [clang][docs][dataflow] Added an introduction to dataflow analysis

xazax.hun added a comment. Thanks for working on this! Publishing documentation alongside the feature is a great practice. I liked this documentation a lot. I have strong opinion about the ambiguous use of `path condition` in this document, otherwise I was only nitpicking. C

[PATCH] D114251: [AST] Add a sugar type for types found via UsingDecl

sammccall added inline comments. Comment at: clang/include/clang/AST/Type.h:4372 +class UsingType : public Type, public llvm::FoldingSetNode { + QualType UnderlyingTy; + NamedDecl *Found; Hmm, maybe I should be getting this from Found, rather than storing it. W

[PATCH] D114163: Use VersionTuple for parsing versions in Triple. This makes it possible to distinguish between "16" and "16.0" after parsing, which previously was not possible.

danalbert accepted this revision. danalbert added a comment. This revision is now accepted and ready to land. Nice, that's a lot of code cleaned up! LGTM, but probably should wait for someone from Apple to weigh in. I think the new formatting for those error messages is better for them too but t

[PATCH] D114234: [clang][dataflow] Add base types for building dataflow analyses

xazax.hun added inline comments. Comment at: clang/include/clang/Analysis/FlowSensitive/DataflowAnalysis.h:48 +/// Type-erased base class for dataflow analyses built on a single lattice type. +class DataflowAnalysisDynamic { +public: Does the `Dynamic` in the su

[PATCH] D114142: [clang-format] [PR52527] can join * with /* to form an outside of comment error C4138

HazardyKnusperkeks added a comment. In D114142#3142122 , @MyDeveloperDay wrote: >> I only now this from the tests with `-debug`. Is there a way to get "normal" >> clang-format to print these? Or did you write a test for that to print the >> information

[PATCH] D114025: [clang][NFC] Inclusive terms: replace some uses of sanity in clang

ZarkoCA marked an inline comment as done. ZarkoCA added a comment. Thanks @aaron.ballman and @Quuxplusone for the constructive reviews. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114025/new/ https://reviews.llvm.org/D114025

[clang] d8e5a0c - [clang][NFC] Inclusive terms: replace some uses of sanity in clang

Author: Zarko Todorovski Date: 2021-11-19T14:58:35-05:00 New Revision: d8e5a0c42bd8796cce9caa53aacab88c7cb2a3eb URL: https://github.com/llvm/llvm-project/commit/d8e5a0c42bd8796cce9caa53aacab88c7cb2a3eb DIFF: https://github.com/llvm/llvm-project/commit/d8e5a0c42bd8796cce9caa53aacab88c7cb2a3eb.di

[PATCH] D114025: [clang][NFC] Inclusive terms: replace some uses of sanity in clang

This revision was automatically updated to reflect the committed changes. Closed by commit rGd8e5a0c42bd8: [clang][NFC] Inclusive terms: replace some uses of sanity in clang (authored by ZarkoCA). Changed prior to commit: https://reviews.llvm.org/D114025?vs=388550&id=388587#toc Repository: r

[PATCH] D113946: [libc][clang-tidy] fix namespace check for externals

michaelrj updated this revision to Diff 388588. michaelrj marked 3 inline comments as done. michaelrj added a comment. address comments and rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113946/new/ https://reviews.llvm.org/D113946 Files:

[PATCH] D112773: Allow __attribute__((swift_attr)) in attribute push pragmas

arphaman added a comment. I will commit this on behalf of @beccadax as she doesn't have commit access yet. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112773/new/ https://reviews.llvm.org/D112773 ___ c

  1   2   >