[PATCH] D114105: [clang-tidy] Ignore narrowing conversions in case of bitfields

courbet added inline comments. Comment at: clang-tools-extra/clang-tidy/cppcoreguidelines/NarrowingConversionsCheck.cpp:104 + castExpr(hasCastKind(CK_LValueToRValue), + has(memberExpr(hasDeclaration(fieldDecl(isBitField(, + hasParent(

[PATCH] D114142: [clang-format] [PR52527] can join * with /* to form an outside of comment error C4138

MyDeveloperDay created this revision. MyDeveloperDay added reviewers: HazardyKnusperkeks, curdeius. MyDeveloperDay added projects: clang, clang-format. MyDeveloperDay requested review of this revision. https://bugs.llvm.org/show_bug.cgi?id=52527 The follow patch ensures there is always a space be

[PATCH] D114105: [clang-tidy] Ignore narrowing conversions in case of bitfields

whisperity added inline comments. Comment at: clang-tools-extra/clang-tidy/cppcoreguidelines/NarrowingConversionsCheck.cpp:87 + // Reading a small unsigned bitfield member will be wrapped by an implicit + // cast to 'int' triggering this checker. But this is known to be safe b

[PATCH] D114143: [OpenMP][IRBuilder] Fix createSections

shraiysh created this revision. Herald added subscribers: rogfer01, guansong, hiraditya, yaxunl. shraiysh requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: llvm-commits, cfe-commits, sstefan1. Herald added projects: clang, LLVM. Fix for the case when

[clang] b105626 - Fix Windows build after commit 49682f1.

Author: Douglas Yung Date: 2021-11-18T00:23:22-08:00 New Revision: b10562612f2e67bda7813ae9586f0afd37dc3c29 URL: https://github.com/llvm/llvm-project/commit/b10562612f2e67bda7813ae9586f0afd37dc3c29 DIFF: https://github.com/llvm/llvm-project/commit/b10562612f2e67bda7813ae9586f0afd37dc3c29.diff

[PATCH] D110215: [C++2a] [Module] Support extern C/C++ semantics

ChuanqiXu updated this revision to Diff 388125. ChuanqiXu added a comment. Change includes: - Add parent for newly created global module fragment. - Add a test. - Rename test directory. Suddenly I found that the names of the tests in CXX directory are corresponds to the standard one by one. So m

[clang-tools-extra] 7aa2ce0 - [NFC][clangd] fix clang-tidy finding on isa_and_nonnull

Author: Christian Kühnel Date: 2021-11-18T09:16:54Z New Revision: 7aa2ce0fab3c21cf87c5884f6bf8bdece1b6fe1c URL: https://github.com/llvm/llvm-project/commit/7aa2ce0fab3c21cf87c5884f6bf8bdece1b6fe1c DIFF: https://github.com/llvm/llvm-project/commit/7aa2ce0fab3c21cf87c5884f6bf8bdece1b6fe1c.diff L

[PATCH] D113899: [NFC][clangd] fix clang-tidy finding on isa_and_nonnull

This revision was automatically updated to reflect the committed changes. Closed by commit rG7aa2ce0fab3c: [NFC][clangd] fix clang-tidy finding on isa_and_nonnull (authored by kuhnel). Changed prior to commit: https://reviews.llvm.org/D113899?vs=387254&id=388127#toc Repository: rG LLVM Githu

[PATCH] D114116: [clang][ARM] relax -mtp=cp15 for ARMv6 non-thumb cases

peter.smith added a comment. Apologies had to go on a bit of a dive through the documentation. I've put some comments inline and some links to other documents that may help. Comment at: clang/lib/Driver/ToolChains/Arch/ARM.cpp:150 +// The backend does not have support for ha

[PATCH] D113250: [clang][driver] Add -fplugin-arg- to pass arguments to plugins

tbaeder updated this revision to Diff 388129. tbaeder added a comment. I already had a test but forgot to add the file to my local git commit, sorry. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113250/new/ https://reviews.llvm.org/D113250 Files: clang/docs/ClangPlugins.rst clang/

[PATCH] D113250: [clang][driver] Add -fplugin-arg- to pass arguments to plugins

tbaeder added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:6625 +auto ArgValue = StringRef(A->getValue()); +auto FirstDashIndex = ArgValue.find('-'); +auto Arg = ArgValue.substr(FirstDashIndex + 1); MaskRay wrote: > What if First

[PATCH] D113251: [analyzer][doc] Add user documenation for taint analysis

gamesh411 marked 13 inline comments as done. gamesh411 added inline comments. Comment at: clang/docs/analyzer/checkers.rst:2351 + + clang --analyze ... -Xclang -analyzer-config -Xclang alpha.security.taint.TaintPropagation:Config=taint_config.yaml + steakhal wro

[PATCH] D114120: [clang] Remove CLANG_ROUND_TRIP_CC1_ARGS and always roundtrip in +assert builds

jansvoboda11 added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:615 // May perform round-trip of command line arguments. By default, the round-trip // is enabled if CLANG_ROUND_TRIP_CC1_ARGS was defined during build. This can be // overwritten at run

[PATCH] D112903: [C++20] [Module] Fix bug47116 and implement [module.interface]/p6

ChuanqiXu added a comment. @aaron.ballman @urnathan gentle ping~ CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112903/new/ https://reviews.llvm.org/D112903 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin

[PATCH] D113251: [analyzer][doc] Add user documenation for taint analysis

gamesh411 updated this revision to Diff 388132. gamesh411 added a comment. Fix the review comments of @steakhal Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113251/new/ https://reviews.llvm.org/D113251 Files: clang/docs/analyzer/checkers.rst

[PATCH] D114142: [clang-format] [PR52527] can join * with /* to form an outside of comment error C4138

owenpan added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:3219 + // of comment. + if (Left.is(tok::star) && Right.is(TT_BlockComment)) +return true; Isn't `tok::comment` better than `TT_BlockComment` if a space is also required between

[PATCH] D114142: [clang-format] [PR52527] can join * with /* to form an outside of comment error C4138

MyDeveloperDay added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:3219 + // of comment. + if (Left.is(tok::star) && Right.is(TT_BlockComment)) +return true; owenpan wrote: > Isn't `tok::comment` better than `TT_BlockComment` if a space i

[clang] 8a4fcfc - Remove non-affecting module maps from PCM files.

Author: Ilya Kuteev Date: 2021-11-18T11:18:26+01:00 New Revision: 8a4fcfc242a0f12e346c3d6026f2ad8764b08f1e URL: https://github.com/llvm/llvm-project/commit/8a4fcfc242a0f12e346c3d6026f2ad8764b08f1e DIFF: https://github.com/llvm/llvm-project/commit/8a4fcfc242a0f12e346c3d6026f2ad8764b08f1e.diff L

[PATCH] D106876: Remove non-affecting module maps from PCM files.

This revision was automatically updated to reflect the committed changes. Closed by commit rG8a4fcfc242a0: Remove non-affecting module maps from PCM files. (authored by ilyakuteev, committed by jansvoboda11). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D104550: [analyzer] Implement getType for SVal

martong added a comment. In D104550#3139239 , @stevewan wrote: > In D104550#2849582 , @vsavchenko > wrote: > >> In D104550#2849561 , >> @DavidSpickett wrote: >> >>> @vsa

[PATCH] D114149: [clang-tidy] Fix pr48613: "llvm-header-guard uses a reserved identifier"

salman-javed-nz created this revision. salman-javed-nz added reviewers: whisperity, hokein, aaron.ballman. salman-javed-nz added a project: clang-tools-extra. Herald added subscribers: carlosgalvezp, rnkovacs, xazax.hun. salman-javed-nz requested review of this revision. Fixes https://bugs.llvm.or

[PATCH] D114142: [clang-format] [PR52527] can join * with /* to form an outside of comment error C4138

owenpan added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:3219 + // of comment. + if (Left.is(tok::star) && Right.is(TT_BlockComment)) +return true; MyDeveloperDay wrote: > owenpan wrote: > > Isn't `tok::comment` better than `TT_BlockCo

[clang] c772a9b - [clang][modules] NFC: Fix typo in test name

Author: Jan Svoboda Date: 2021-11-18T11:57:34+01:00 New Revision: c772a9b6eb1479e042105e4334f0b395fadb1462 URL: https://github.com/llvm/llvm-project/commit/c772a9b6eb1479e042105e4334f0b395fadb1462 DIFF: https://github.com/llvm/llvm-project/commit/c772a9b6eb1479e042105e4334f0b395fadb1462.diff L

[clang] 8e47b83 - [AArch64][ARM] Enablement of Cortex-A710 Support

Author: Mubashar Ahmad Date: 2021-11-18T10:58:05Z New Revision: 8e47b83ec93de6f92d077240a3665f3a03076957 URL: https://github.com/llvm/llvm-project/commit/8e47b83ec93de6f92d077240a3665f3a03076957 DIFF: https://github.com/llvm/llvm-project/commit/8e47b83ec93de6f92d077240a3665f3a03076957.diff LOG

[PATCH] D113256: [AArch64][ARM] Enablement of Cortex-A710 Support

mubashar_ closed this revision. mubashar_ added a comment. Landed as: https://reviews.llvm.org/rG8e47b83ec93de6f92d077240a3665f3a03076957 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113256/new/ https://reviews.llvm.org/D113256 ___ cfe-commi

[PATCH] D110622: [HIPSPV][3/4] Enable SPIR-V emission for HIP

linjamaki updated this revision to Diff 388146. linjamaki added a comment. - Adjust `--offload` description: reflect the current state. - Adjust enum range check in IsAMDGpuArch(). - Make `--offload` and `--offload-arch` options mutually exclusive. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D114151: [clang-format] [C++20] [Module] clang-format couldn't recognize partitions

MyDeveloperDay created this revision. MyDeveloperDay added reviewers: HazardyKnusperkeks, curdeius, owenpan, ChuanqiXu. MyDeveloperDay added projects: clang, clang-format. Herald added subscribers: jrtc27, arichardson. MyDeveloperDay requested review of this revision. https://bugs.llvm.org/show_b

[PATCH] D110622: [HIPSPV][3/4] Enable SPIR-V emission for HIP

linjamaki marked 2 inline comments as done. linjamaki added inline comments. Comment at: clang/include/clang/Basic/Cuda.h:109 + // Generic processor model is for testing only. + return A >= CudaArch::GFX600 && A <= CudaArch::GFX1035; } yaxunl wrote: > can we u

[PATCH] D112404: [SPIR-V] Add translator tool

linjamaki added a comment. Thanks for the help! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112404/new/ https://reviews.llvm.org/D112404 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://

[PATCH] D114142: [clang-format] [PR52527] can join * with /* to form an outside of comment error C4138

MyDeveloperDay added a comment. These don't seem to be issues double term = a * // first b; void foo(int* // this is the first , int second); Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114142/new/

[PATCH] D114142: [clang-format] [PR52527] can join * with /* to form an outside of comment error C4138

MyDeveloperDay added a comment. I'm thinking that those cases are handled else where as S=1 on those elements (which means space required before) M=0 C=0 T=Unknown S=1 F=0 B=0 BK=0 P=0 Name=double L=6 PPK=2 FakeLParens=2/ FakeRParens=0 II=0x1d662dd3990 Text='double' M=0 C=1 T=StartOfName S=

[PATCH] D114151: [clang-format] [C++20] [Module] clang-format couldn't recognize partitions

ChuanqiXu added a comment. There could be more tests in case we want support c++20 module more. This shouldn't be a break issue for this patch since this aims to fix the space in partitions only. export template<...>; export struct { ... }; export int func() { // ... } expo

[clang] 17ec9d1 - [clang][deps] Don't emit `-fmodule-map-file=`

Author: Jan Svoboda Date: 2021-11-18T12:31:24+01:00 New Revision: 17ec9d1f6bc1c64a3a49d16852e6f9d705371433 URL: https://github.com/llvm/llvm-project/commit/17ec9d1f6bc1c64a3a49d16852e6f9d705371433 DIFF: https://github.com/llvm/llvm-project/commit/17ec9d1f6bc1c64a3a49d16852e6f9d705371433.diff L

[PATCH] D113473: [clang][deps] Don't emit `-fmodule-map-file=`

This revision was automatically updated to reflect the committed changes. Closed by commit rG17ec9d1f6bc1: [clang][deps] Don't emit `-fmodule-map-file=` (authored by jansvoboda11). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113473/new/ https://re

[clang] 7b67908 - [clang][lex] NFC: Remove unused HeaderFileInfo member

Author: Jan Svoboda Date: 2021-11-18T12:33:26+01:00 New Revision: 7b6790850968031fe1c098ed6dcc196ddc547ea5 URL: https://github.com/llvm/llvm-project/commit/7b6790850968031fe1c098ed6dcc196ddc547ea5 DIFF: https://github.com/llvm/llvm-project/commit/7b6790850968031fe1c098ed6dcc196ddc547ea5.diff L

[PATCH] D114092: [clang][lex] NFC: Remove unused HeaderFileInfo member

This revision was automatically updated to reflect the committed changes. Closed by commit rG7b6790850968: [clang][lex] NFC: Remove unused HeaderFileInfo member (authored by jansvoboda11). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114092/new/ ht

[PATCH] D114093: [clang][lex] Refactor check for the first file include

jansvoboda11 marked 3 inline comments as done. jansvoboda11 added inline comments. Comment at: clang/include/clang/Lex/HeaderSearch.h:445-447 + bool ShouldEnterIncludeFile(bool &IsFirstIncludeOfFile, Preprocessor &PP, + const FileEntry *File, bool is

[PATCH] D110215: [C++2a] [Module] Support extern C/C++ semantics

ChuanqiXu updated this revision to Diff 388151. ChuanqiXu added a comment. Format codes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110215/new/ https://reviews.llvm.org/D110215 Files: clang/include/clang/Basic/Module.h clang/include/clang/Lex/ModuleMap.h clang/include/clang/Se

[PATCH] D114093: [clang][lex] Refactor check for the first file include

This revision was automatically updated to reflect the committed changes. jansvoboda11 marked 2 inline comments as done. Closed by commit rG197576c40986: [clang][lex] Refactor check for the first file include (authored by jansvoboda11). Changed prior to commit: https://reviews.llvm.org/D114093?

[clang] 197576c - [clang][lex] Refactor check for the first file include

Author: Jan Svoboda Date: 2021-11-18T13:01:07+01:00 New Revision: 197576c40986085cbd5250283e1e80a2679c9cf0 URL: https://github.com/llvm/llvm-project/commit/197576c40986085cbd5250283e1e80a2679c9cf0 DIFF: https://github.com/llvm/llvm-project/commit/197576c40986085cbd5250283e1e80a2679c9cf0.diff L

[PATCH] D110216: [clang] retain type sugar in auto / template argument deduction

lkail added a comment. Hi we found regression in our internal tests. It compiles with clang-13.0.0 https://godbolt.org/z/3abGrcf7o and gcc https://godbolt.org/z/K9oj3Grs1, but fails with clang-trunk https://godbolt.org/z/1Tehxa1x9. Is it an intended change? If so, do we have to document this?

[PATCH] D110215: [C++2a] [Module] Support extern C/C++ semantics

aaron.ballman added a comment. In D110215#3139589 , @ChuanqiXu wrote: > Change includes: > > - Add parent for newly created global module fragment. > - Add a test. > - Rename test directory. Suddenly I found that the names of the tests in CXX > directory

[PATCH] D114149: [clang-tidy] Fix pr48613: "llvm-header-guard uses a reserved identifier"

aaron.ballman requested changes to this revision. aaron.ballman added inline comments. This revision now requires changes to proceed. Comment at: clang-tools-extra/clang-tidy/utils/HeaderGuard.cpp:28 +/// Replace invalid characters in the identifier with '_'. +static std::string

[PATCH] D114025: [clang][NFC] Inclusive terms: replace some uses of sanity in clang

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114025/new/ https://reviews.llvm.org/D114025 _

[PATCH] D113251: [analyzer][doc] Add user documenation for taint analysis

whisperity added inline comments. Comment at: clang/docs/analyzer/checkers.rst:2341-2342 + +Default propagations defined by `GenericTaintChecker`: +``atoi``, ``atol``, ``atoll``, ``fgetc``, ``fgetln``, ``fgets``, ``fscanf``, ``sscanf``, ``getc``, ``getc_unlocked``, ``getdelim``,

[PATCH] D114149: [clang-tidy] Fix pr48613: "llvm-header-guard uses a reserved identifier"

whisperity added inline comments. Comment at: clang-tools-extra/clang-tidy/utils/HeaderGuard.cpp:42-46 +/// Remove all '_' characters at the beginning of the identifier. Only reserved +/// identifiers are allowed to start with these. +static StringRef dropLeadingUnderscores(Strin

[PATCH] D112024: [clang] diagnose_as attribute for Fortify diagnosing like builtins.

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:5973 +``mymemset(n, c, s)`` will diagnose overflows as if it were the call +``__builtin_memset(s, c, n)``; +}]; One thing that's not quite clear from the docs is how to handle

[PATCH] D114149: [clang-tidy] Fix pr48613: "llvm-header-guard uses a reserved identifier"

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/utils/HeaderGuard.cpp:42-46 +/// Remove all '_' characters at the beginning of the identifier. Only reserved +/// identifiers are allowed to start with these. +static StringRef dropLeadingUnderscores(St

[PATCH] D114120: [clang] Remove CLANG_ROUND_TRIP_CC1_ARGS and always roundtrip in +assert builds

thakis marked an inline comment as done. thakis added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:615 // May perform round-trip of command line arguments. By default, the round-trip // is enabled if CLANG_ROUND_TRIP_CC1_ARGS was defined during build.

[clang] 3950e1b - [clang] Remove CLANG_ROUND_TRIP_CC1_ARGS and always roundtrip in +assert builds

Author: Nico Weber Date: 2021-11-18T08:31:21-05:00 New Revision: 3950e1be8d6ec602fda525ea20340fd3f8e2e919 URL: https://github.com/llvm/llvm-project/commit/3950e1be8d6ec602fda525ea20340fd3f8e2e919 DIFF: https://github.com/llvm/llvm-project/commit/3950e1be8d6ec602fda525ea20340fd3f8e2e919.diff LO

[PATCH] D114120: [clang] Remove CLANG_ROUND_TRIP_CC1_ARGS and always roundtrip in +assert builds

This revision was automatically updated to reflect the committed changes. thakis marked an inline comment as done. Closed by commit rG3950e1be8d6e: [clang] Remove CLANG_ROUND_TRIP_CC1_ARGS and always roundtrip in +assert builds (authored by thakis). Herald added a project: clang. Changed prior to

[PATCH] D111318: [clang][clangd] Improve signature help for variadic functions.

adamcz updated this revision to Diff 388167. adamcz marked an inline comment as done. adamcz added a comment. addressed review comments, added new test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111318/new/ https://reviews.llvm.org/D111318 File

[PATCH] D111318: [clang][clangd] Improve signature help for variadic functions.

adamcz added a comment. Added a slightly awkward clang (not clangd) test. The output is suboptimial, because it's not clangd, but it shows things work as they should. Comment at: clang-tools-extra/clangd/CodeComplete.cpp:929 +// +// This only matters for variad

[PATCH] D111318: [clang][clangd] Improve signature help for variadic functions.

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/CodeComplete.cpp:929 +// +// This only matters for variadic functions/templates, where CurrentArg +// m

[PATCH] D114099: Enable `_Float16` type support on X86 without the avx512fp16 flag

zahiraam updated this revision to Diff 388179. zahiraam marked 7 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114099/new/ https://reviews.llvm.org/D114099 Files: clang/docs/LanguageExtensions.rst clang/docs/ReleaseNotes.rst clang/lib/Basic/Targets/X86.cpp

[PATCH] D114099: Enable `_Float16` type support on X86 without the avx512fp16 flag

tschuett added inline comments. Comment at: clang/docs/LanguageExtensions.rst:676 * SPIR -* X86 (Only available under feature AVX512-FP16) +* X86 Would something like SSE2 and up help understanding? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D11409

[PATCH] D114105: [clang-tidy] Ignore narrowing conversions in case of bitfields

steakhal added a comment. Thanks for the valuable feedback. > D114105#inline-1089282 Let me clarify my motivation, and why I'm interested in bitfields, conversions, and shift expressions. Bitfields can be quite tricky. It turns out doing anythin

[PATCH] D112091: libfuzzer: All building libfuzzer for ARM32

morehouse accepted this revision. morehouse added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112091/new/ https://reviews.llvm.org/D112091 _

[PATCH] D114162: [X86][clang] Enable floating-point type for -mno-x87 option on 32-bits

pengfei created this revision. pengfei added reviewers: asavonic, erichkeane, nickdesaulniers. pengfei requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. We should match GCC's behavior which allows floating-point type for -mno-x87 option on 3

[PATCH] D98895: [X86][clang] Disable long double type for -mno-x87 option

pengfei added a comment. @asavonic , I put a patch D114162 to enable it on 32-bits. Could you help to review it? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98895/new/ https://reviews.llvm.org/D98895 _

[PATCH] D114163: Use VersionTuple for parsing versions in Triple. This makes it possible to distinguish between "16" and "16.0" after parsing, which previously was not possible. See also https://gith

jamesfarrell created this revision. Herald added subscribers: danielkiss, dexonsmith, pengfei, hiraditya. jamesfarrell requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.

[PATCH] D114105: [clang-tidy] Ignore narrowing conversions in case of bitfields

courbet added a comment. Thanks for the details, this explains the motivation well. I think the key point is the combination of: > It turns out doing anything useful with a bitfield will eventually result in > an integral promotion, which mandates that the type must be 'int' if it fits > conv.p

[PATCH] D114099: Enable `_Float16` type support on X86 without the avx512fp16 flag

zahiraam updated this revision to Diff 388189. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114099/new/ https://reviews.llvm.org/D114099 Files: clang/docs/LanguageExtensions.rst clang/docs/ReleaseNotes.rst clang/lib/Basic/Targets/X86.cpp clang/test/CodeGen/X86/Float16-arithmetic

[clang-tools-extra] 55a7931 - [clang][clangd] Improve signature help for variadic functions.

Author: Adam Czachorowski Date: 2021-11-18T15:50:47+01:00 New Revision: 55a79318c60d8a39329195f43bf43b89da9a638e URL: https://github.com/llvm/llvm-project/commit/55a79318c60d8a39329195f43bf43b89da9a638e DIFF: https://github.com/llvm/llvm-project/commit/55a79318c60d8a39329195f43bf43b89da9a638e.d

[PATCH] D111318: [clang][clangd] Improve signature help for variadic functions.

This revision was automatically updated to reflect the committed changes. Closed by commit rG55a79318c60d: [clang][clangd] Improve signature help for variadic functions. (authored by adamcz). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111318/new/

[PATCH] D113049: [AIX] Disable tests that fail because of no 64-bit XCOFF object file support

jsji added a comment. Can we use `UNSUPPORTED` instead of `XFAIL` since it is unsupported? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113049/new/ https://reviews.llvm.org/D113049 ___ cfe-commits maili

[PATCH] D114025: [clang][NFC] Inclusive terms: replace some uses of sanity in clang

martong added a comment. Do we have a comprehensive list of non-inclusive terms and their inclusive correspondent somewhere available? I mean `master` -> `main`, `white list` -> `inclusive list`, `sanity` -> `validation`, ... I'd assume that we go through that list, and that could give me a clue

[PATCH] D113049: [AIX] Disable tests that fail because of no 64-bit XCOFF object file support

Jake-Egan added a comment. In D113049#3140160 , @jsji wrote: > Can we use `UNSUPPORTED` instead of `XFAIL` since it is unsupported? If 64-bit XCOFF object files will be supported in the future, I think it makes more sense to use `XFAIL` because these te

[PATCH] D113049: [AIX] Disable tests that fail because of no 64-bit XCOFF object file support

lkail added a comment. Is there any way to filter these tests out on AIX in `lit.local.cfg`? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113049/new/ https://reviews.llvm.org/D113049 ___ cfe-commits mai

[PATCH] D113538: OpenMP: Start calling setTargetAttributes for generated kernels

JonChesterfield added a subscriber: estewart08. JonChesterfield added a comment. Is the behaviour change in the above comments intentional? Pointed out by @estewart08 Comment at: clang/lib/CodeGen/TargetInfo.cpp:9208 - FD->hasAttr(); - if ((IsOpenCLK

[PATCH] D114025: [clang][NFC] Inclusive terms: replace some uses of sanity in clang

ZarkoCA added a comment. In D114025#3140161 , @martong wrote: > Do we have a comprehensive list of non-inclusive terms and their inclusive > correspondent somewhere available? > I mean `master` -> `main`, `white list` -> `inclusive list`, `sanity` -> >

[PATCH] D114025: [clang][NFC] Inclusive terms: replace some uses of sanity in clang

Quuxplusone requested changes to this revision. Quuxplusone added a comment. This revision now requires changes to proceed. Peanut gallery says: I'd recommend //not// taking this particular patch; it seems much less "obvious" than the whitelist/inclusionlist type of patch. Whereas "whitelist" is

[PATCH] D110549: [HIPSPV][1/4] Refactor HIP tool chain

yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. LGTM. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110549/new/ https://reviews.llvm.org/D110549 __

[PATCH] D113538: OpenMP: Start calling setTargetAttributes for generated kernels

JonChesterfield added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:9288 + + const bool IsOpenMP = M.getLangOpts().OpenMP && !FD; + if ((IsOpenCLKernel || IsHIPKernel || IsOpenMP) && JonChesterfield wrote: > Here, we do the amdgpu-implicitarg-nu

[PATCH] D114025: [clang][NFC] Inclusive terms: replace some uses of sanity in clang

lebedev.ri added a comment. In D114025#3140161 , @martong wrote: > Do we have a comprehensive list of non-inclusive terms and their inclusive > correspondent somewhere available? > I mean `master` -> `main`, `white list` -> `inclusive list`, `sanity` ->

[PATCH] D113049: [AIX] Disable tests that fail because of no 64-bit XCOFF object file support

jsji added a comment. In D113049#3140165 , @Jake-Egan wrote: > In D113049#3140160 , @jsji wrote: > >> Can we use `UNSUPPORTED` instead of `XFAIL` since it is unsupported? > > If 64-bit XCOFF object files will be s

[PATCH] D113049: [AIX] Disable tests that fail because of no 64-bit XCOFF object file support

jsji added a comment. In D113049#3140174 , @lkail wrote: > Is there any way to filter these tests out on AIX in `lit.local.cfg`? Agree, I would prefer we do something similar to https://reviews.llvm.org/rG666accf283311c5110ae4e2e5e4c4b99078eed15#change-

[PATCH] D114163: Use VersionTuple for parsing versions in Triple. This makes it possible to distinguish between "16" and "16.0" after parsing, which previously was not possible.

jamesfarrell updated this revision to Diff 388196. jamesfarrell retitled this revision from "Use VersionTuple for parsing versions in Triple. This makes it possible to distinguish between "16" and "16.0" after parsing, which previously was not possible.See also https://github.com/android/ndk/iss

[libunwind] 11982ee - [libunwind][AIX] Mark signal_frame.pass.cpp UNSUPPORTED on AIX

Author: Xing Xue Date: 2021-11-18T10:24:58-05:00 New Revision: 11982eed2bc818fdbd525e3237a77a3efeb6a497 URL: https://github.com/llvm/llvm-project/commit/11982eed2bc818fdbd525e3237a77a3efeb6a497 DIFF: https://github.com/llvm/llvm-project/commit/11982eed2bc818fdbd525e3237a77a3efeb6a497.diff LOG:

[PATCH] D114163: Use VersionTuple for parsing versions in Triple. This makes it possible to distinguish between "16" and "16.0" after parsing, which previously was not possible.

jamesfarrell updated this revision to Diff 388198. jamesfarrell added a comment. Remove an include that's no longer needed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114163/new/ https://reviews.llvm.org/D114163 Files: clang/lib/ARCMigrate/AR

[PATCH] D114025: [clang][NFC] Inclusive terms: replace some uses of sanity in clang

aaron.ballman added a comment. In D114025#3140161 , @martong wrote: > Do we have a comprehensive list of non-inclusive terms and their inclusive > correspondent somewhere available? > I mean `master` -> `main`, `white list` -> `inclusive list`, `sanity`

[PATCH] D110618: [HIPSPV][2/4] Add HIPSPV tool chain

yaxunl added a comment. LGTM. I will leave to @tra about -nohipwrapperinc Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110618/new/ https://reviews.llvm.org/D110618 ___ cfe-commits mailing list cfe-commi

[PATCH] D110622: [HIPSPV][3/4] Enable SPIR-V emission for HIP

yaxunl added a comment. LGTM. I will defer to @tra Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110622/new/ https://reviews.llvm.org/D110622 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https

[PATCH] D113538: OpenMP: Start calling setTargetAttributes for generated kernels

JonChesterfield added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:9288 + + const bool IsOpenMP = M.getLangOpts().OpenMP && !FD; + if ((IsOpenCLKernel || IsHIPKernel || IsOpenMP) && JonChesterfield wrote: > JonChesterfield wrote: > > Here, we d

[PATCH] D113538: OpenMP: Start calling setTargetAttributes for generated kernels

arsenm added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:9288 + + const bool IsOpenMP = M.getLangOpts().OpenMP && !FD; + if ((IsOpenCLKernel || IsHIPKernel || IsOpenMP) && JonChesterfield wrote: > JonChesterfield wrote: > > JonChesterfield wro

[clang] 26f5643 - [Clang][SVE] Properly enable/disable dependant SVE target features based upon +(no)sve.* options

Author: Bradley Smith Date: 2021-11-18T15:52:28Z New Revision: 26f56438e3dab44cea4c8f16d4cb16e9424b02c6 URL: https://github.com/llvm/llvm-project/commit/26f56438e3dab44cea4c8f16d4cb16e9424b02c6 DIFF: https://github.com/llvm/llvm-project/commit/26f56438e3dab44cea4c8f16d4cb16e9424b02c6.diff LOG:

[PATCH] D113776: [Clang][SVE] Properly enable/disable dependant SVE target features based upon +(no)sve.* options

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG26f56438e3da: [Clang][SVE] Properly enable/disable dependant SVE target features based upon +… (authored by bsmith). Repository: rG LLVM Github Mo

[PATCH] D99797: [analyzer] Implemented RangeSet::Factory::unite function to handle intersections and adjacency

martong added a comment. Gentle ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99797/new/ https://reviews.llvm.org/D99797 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D114025: [clang][NFC] Inclusive terms: replace some uses of sanity in clang

ZarkoCA updated this revision to Diff 388207. ZarkoCA edited the summary of this revision. ZarkoCA added a comment. - Reword comments based on suggestions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114025/new/ https://reviews.llvm.org/D114025

[PATCH] D111863: [libunwind] Add an interface for dynamic .eh_frame registration

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rGbab39816085d: [libunwind] Add an interface for dynamic .eh_frame registration (authored by housel). Repository: rG LLVM

[libunwind] bab3981 - [libunwind] Add an interface for dynamic .eh_frame registration

Author: Peter S. Housel Date: 2021-11-18T08:06:46-08:00 New Revision: bab39816085d715e52c2131fa249ccd10178764b URL: https://github.com/llvm/llvm-project/commit/bab39816085d715e52c2131fa249ccd10178764b DIFF: https://github.com/llvm/llvm-project/commit/bab39816085d715e52c2131fa249ccd10178764b.dif

[PATCH] D113898: [NFC][clangd] cleaning up llvm-qualified-auto

kuhnel added a comment. When trying to revert some of the changes, I just noticed there are a couple of `if (const auto* ...` in `CodeComplete.cpp` and `AST.cpp` (and maybe other files as well). So some folks seem to be using this right now. If we want to be consistent, we would have to remove

[PATCH] D114025: [clang][NFC] Inclusive terms: replace some uses of sanity in clang

ZarkoCA added a comment. In D114025#3140192 , @Quuxplusone wrote: > Peanut gallery says: I'd recommend //not// taking this particular patch; it > seems much less "obvious" than the whitelist/inclusionlist type of patch. > Whereas "whitelist" is just a

[PATCH] D112923: [clang][deps] Reset some benign codegen options

Bigcheese accepted this revision. Bigcheese added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112923/new/ https://reviews.llvm.org/D112923 _

[PATCH] D113880: [clang][modules] Infer framework modules in explicit builds

Bigcheese accepted this revision. Bigcheese added a comment. This revision is now accepted and ready to land. I think this makes sense to do given that you need to explicitly opt into inferred modules anyway. This isn't implicitly finding module maps, as we already have a module map with `framew

[PATCH] D114099: Enable `_Float16` type support on X86 without the avx512fp16 flag

rjmccall requested changes to this revision. rjmccall added inline comments. This revision now requires changes to proceed. Comment at: clang/test/SemaCXX/Float16.cpp:4 +// RUN: %clang_cc1 -fsyntax-only -verify -triple armv7a-linux-gnu %s +// RUN: %clang_cc1 -fsyntax-only -verify

[PATCH] D99797: [analyzer] Implemented RangeSet::Factory::unite function to handle intersections and adjacency

ASDenysPetrov added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:229-233 +// We want to keep the following invariant at all times: +// ---[ First --> +// -[ Second ---> +if (First->From() > Second->From()) + sw

[PATCH] D99797: [analyzer] Implemented RangeSet::Factory::unite function to handle intersections and adjacency

ASDenysPetrov updated this revision to Diff 388219. ASDenysPetrov added a comment. Fixed comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99797/new/ https://reviews.llvm.org/D99797 Files: clang/include/clang/StaticAnalyzer/Core/PathSensitive/RangedConstraintManager.h clang/

[PATCH] D113709: Don't consider `LinkageSpec` when calculating DeclContext `Encloses`

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. > We don't properly handle lookup through using declarations when there is a > linkage spec in the common chain. Pedantic note: you mean using *directives*. At some point, we should proba

[PATCH] D99797: [analyzer] Implemented RangeSet::Factory::unite function to handle intersections and adjacency

martong added a comment. Thanks for the update, I am okay with the `.cpp` file, now I continue the review with the tests. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99797/new/ https://reviews.llvm.org/D99797 ___ cfe-commits mailing list c

  1   2   >