[PATCH] D112768: [ARM] implement support for TLS register based stack protector

ardb updated this revision to Diff 384564. ardb added a comment. - disallow -mtp=soft when TLS based stack protector is enabled Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112768/new/ https://reviews.llvm.org/D112768 Files: clang/include/clang

[PATCH] D112768: [ARM] implement support for TLS register based stack protector

ardb marked 2 inline comments as done. ardb added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:3190-3191 + } + CmdArgs.push_back("-target-feature"); + CmdArgs.push_back("+read-tp-hard"); +} nickdesaulniers wrote: > ardb wr

[PATCH] D112768: [ARM] implement support for TLS register based stack protector

nickdesaulniers accepted this revision. nickdesaulniers added a comment. This revision is now accepted and ready to land. Looks great! Nice job! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112768/new/ https://reviews.llvm.org/D112768 ___

[clang] a55c4ec - [ASan] Process functions in Asan module pass

Author: Kirill Stoimenov Date: 2021-11-03T20:27:53Z New Revision: a55c4ec1cee7683d9095327d9d33e7137ec25292 URL: https://github.com/llvm/llvm-project/commit/a55c4ec1cee7683d9095327d9d33e7137ec25292 DIFF: https://github.com/llvm/llvm-project/commit/a55c4ec1cee7683d9095327d9d33e7137ec25292.diff L

[PATCH] D112732: [ASan] Process functions in Asan module pass

This revision was automatically updated to reflect the committed changes. Closed by commit rGa55c4ec1cee7: [ASan] Process functions in Asan module pass (authored by kstoimenov). Changed prior to commit: https://reviews.llvm.org/D112732?vs=384544&id=384571#toc Repository: rG LLVM Github Monor

[PATCH] D110833: [clang-format] Refactor SpaceBeforeParens to add options

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. This revision is now accepted and ready to land. To me this looks good, if the sorting is finalized. :) Do you need someone to push this for you? If yes please state name and email, if not please wait a few days for o

[PATCH] D112915: WIP: [clang][modules] Granular tracking of includes

dexonsmith added a comment. Just a few comments on implementation details. The only high-level piece to call out is that I wonder if `NumIncludes` could/should be simplified (semantically) to a Boolean in a prep commit. Comment at: clang/include/clang/Lex/Preprocessor.h:720-7

[PATCH] D112913: Misleading bidirectional detection

serge-sans-paille added inline comments. Comment at: clang-tools-extra/clang-tidy/misc/MisleadingBidirectional.cpp:59 +// If conversion fails, utf-8 is designed so that we can just try next char. +if (Result != llvm::conversionOK) { + ++CurPtr; rsmi

[PATCH] D112491: Add `LambdaCapture`-related matchers.

jcking1034 updated this revision to Diff 384578. jcking1034 added a comment. Rebase onto main. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112491/new/ https://reviews.llvm.org/D112491 Files: clang/docs/LibASTMatchersReference.html clang/docs

[PATCH] D112491: Add `LambdaCapture`-related matchers.

fowles added a comment. Do we also want a `forEachCapture` matcher? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112491/new/ https://reviews.llvm.org/D112491 ___ cfe-commits mailing list cfe-commits@lis

[PATCH] D113143: [clang][asan] Add test for ensuring PR52382 is fixed

leonardchan created this revision. leonardchan added reviewers: aeubanks, vitalybuka. leonardchan added a project: Sanitizers. leonardchan requested review of this revision. Herald added a project: clang. The fix for PR52382 was already introduced in D112732 whi

[PATCH] D112732: [ASan] Process functions in Asan module pass

aeubanks added a comment. can we rename "asan-module" to "asan" after this change? and remove the extra "asan-pipeline"/"asan-function-pipeline" parsing callbacks in NewPMDriver.cpp? and previously we had `-passes=require` because a function pass couldn't invoke a module analysis, but that's no

[PATCH] D112098: [ASan] Added stack safety support in address sanitizer.

kstoimenov updated this revision to Diff 384583. kstoimenov added a comment. After removing function pass. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112098/new/ https://reviews.llvm.org/D112098 Files: llvm/include/llvm/Analysis/StackSafetyAn

[PATCH] D113145: Remove two sema checkings as assertions introduced by D79719.

ychen created this revision. ychen added reviewers: hubert.reinterpretcast, Xiangling_L. ychen requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Sema layer should handle these already. Otherwise checking build of the compiler would crash for

[PATCH] D112098: [ASan] Added stack safety support in address sanitizer.

kstoimenov updated this revision to Diff 384587. kstoimenov added a comment. Restored StackSafetyAnalysis.h. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112098/new/ https://reviews.llvm.org/D112098 Files: llvm/lib/Transforms/Instrumentation/Ad

[PATCH] D113146: Fix the assertion in Sema::ActOnDependentMemberExpr

ychen created this revision. ychen added a reviewer: rsmith. ychen requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. 617007240cbfb97c introduced the use of ActOnDependent

[PATCH] D112349: [Verifier] Add verification logic for GlobalIFuncs

ibookstein added a comment. I'll first explain my thought process about the representation of aliases and ifuncs in the IR, and why I think both aliasees and resolvers must always be defined; I hope I'm not completely off track and would love it if @MaskRay could weigh in as to whether I make s

[PATCH] D113080: [Support] Improve Caching conformance with Support library behavior

noajshu updated this revision to Diff 384592. noajshu added a comment. Rebase against main. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113080/new/ https://reviews.llvm.org/D113080 Files: clang/lib/CodeGen/BackendUtil.cpp lld/COFF/LTO.cpp

[PATCH] D111639: [Sema] check PseudoObject when rebuilding CXXOperatorCallExpr in template instantiation

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm Sorry for the delay Comment at: clang/lib/Sema/TreeTransform.h:14576 !Second->getType()->isOverloadableType()) return getSema().CreateBuiltinArraySubscriptExp

[PATCH] D111443: [Driver] Fix ToolChain::getSanitizerArgs

eugenis added a comment. The approach looks reasonable to me. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111443/new/ https://reviews.llvm.org/D111443 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/ma

[PATCH] D113148: Add new clang-tidy check for string_view(nullptr)

CJ-Johnson updated this revision to Diff 384597. CJ-Johnson added a comment. Remove mistaken changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113148/new/ https://reviews.llvm.org/D113148 Files: clang-tools-extra/clang-tidy/bugprone/Bugprone

[PATCH] D113148: Add new clang-tidy check for string_view(nullptr)

CJ-Johnson updated this revision to Diff 384598. CJ-Johnson added a comment. Remove mistaken changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113148/new/ https://reviews.llvm.org/D113148 Files: clang-tools-extra/clang-tidy/bugprone/Bugprone

[PATCH] D113148: Add new clang-tidy check for string_view(nullptr)

CJ-Johnson updated this revision to Diff 384599. CJ-Johnson added a comment. Add missing newline Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113148/new/ https://reviews.llvm.org/D113148 Files: clang-tools-extra/clang-tidy/bugprone/BugproneTidy

[PATCH] D110123: [clang][objc] Speed up populating the global method pool from modules.

vsapsai updated this revision to Diff 384606. vsapsai added a comment. Rebase. Hopefully MLIR build is fixed and I'll be able to see relevant pre-merge check results. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110123/new/ https://reviews.llvm.o

[PATCH] D113096: [X86][MS-InlineAsm] Add constraint *m for memory access w/ global var

skan marked 3 inline comments as done. skan added inline comments. Comment at: clang/test/CodeGen/ms-inline-asm-static-variable.c:8 + // CHECK: @arr = internal global [10 x i32] + // CHECK: call void asm sideeffect inteldialect "mov dword ptr $0[edx * $$4],edx", "=*m,{{.*}}([1

[PATCH] D113096: [X86][MS-InlineAsm] Add constraint *m for memory access w/ global var

skan marked 2 inline comments as done. skan added inline comments. Comment at: llvm/test/CodeGen/X86/ms-inline-asm-array.ll:15-22 +!llvm.module.flags = !{!0, !1, !2} +!llvm.ident = !{!3} + +!0 = !{i32 1, !"wchar_size", i32 4} +!1 = !{i32 7, !"uwtable", i32 1} +!2 = !{i32 7, !"fra

[clang] 0a35cc4 - [clang][objc] Speed up populating the global method pool from modules.

Author: Volodymyr Sapsai Date: 2021-11-03T17:11:14-07:00 New Revision: 0a35cc40b881a35c6a7a748f5fdefac4cafc33ce URL: https://github.com/llvm/llvm-project/commit/0a35cc40b881a35c6a7a748f5fdefac4cafc33ce DIFF: https://github.com/llvm/llvm-project/commit/0a35cc40b881a35c6a7a748f5fdefac4cafc33ce.di

[PATCH] D110123: [clang][objc] Speed up populating the global method pool from modules.

This revision was automatically updated to reflect the committed changes. Closed by commit rG0a35cc40b881: [clang][objc] Speed up populating the global method pool from modules. (authored by vsapsai). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110

[PATCH] D110123: [clang][objc] Speed up populating the global method pool from modules.

vsapsai added a comment. Thanks for the review! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110123/new/ https://reviews.llvm.org/D110123 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://

[PATCH] D112285: [PowerPC] PPC backend optimization to lower int_ppc_tdw/int_ppc_tw intrinsics to TDI/TWI machine instructions

nemanjai requested changes to this revision. nemanjai added inline comments. This revision now requires changes to proceed. Comment at: llvm/lib/Target/PowerPC/PPCISelDAGToDAG.cpp:5001 + case ISD::INTRINSIC_VOID: { +if (N->getConstantOperandVal(1) == Intrinsic::ppc_tdw || +

[PATCH] D112098: [ASan] Added stack safety support in address sanitizer.

vitalybuka accepted this revision. vitalybuka added inline comments. This revision is now accepted and ready to land. Comment at: llvm/lib/Transforms/Instrumentation/AddressSanitizer.cpp:1511 + if (ClUseStackSafety && SSGI != nullptr && findAllocaForValue(Ptr) && + SSGI->

[PATCH] D113096: [X86][MS-InlineAsm] Add constraint *m for memory access w/ global var

xiangzhangllvm added inline comments. Comment at: llvm/lib/Target/X86/AsmParser/X86AsmParser.cpp:1759 // It is widely common for MS InlineAsm to use a global variable and one/two // registers in a mmory expression, and though unaccessible via rip/eip. if (IsGlobalLV && (

[PATCH] D112915: WIP: [clang][modules] Granular tracking of includes

vsapsai added a comment. In D112915#3106472 , @jansvoboda11 wrote: > That's interesting. I think `HeaderFileInfo::isImport` should definitely be > tracked in the preprocessor, not in `HeaderFileInfo`. The fact that the > header was `#import`ed is not a

[PATCH] D108696: [Coroutines] [Frontend] Lookup in std namespace first

lxfind accepted this revision. lxfind added a comment. I also agree that we should try to keep the compiler simple and not support the complicated case. It should be fairly straightforward for a codebase to update fully to use std instead of std::experimental (we have a large coroutine codebase

[PATCH] D113148: Add new clang-tidy check for string_view(nullptr)

Sockke added a comment. This seems to be an existing check. Have you compared it with **bugprone-string-constructor**? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113148/new/ https://reviews.llvm.org/D113148

[PATCH] D112903: [C++20] [Module] Fix front end crashes when trying to export a qualified entity which is already declared

ChuanqiXu updated this revision to Diff 384645. ChuanqiXu retitled this revision from "[C++20] [Module] Fix front end crashes when trying to export a type out of a module " to "[C++20] [Module] Fix front end crashes when trying to export a qualified entity which is already declared". ChuanqiXu ad

[PATCH] D111863: [libunwind] Add an interface for dynamic .eh_frame registration

lhames added a comment. In D111863#3071356 , @steven_wu wrote: > In D111863#3071328 , @housel wrote: > >> In D111863#3069279 , @lhames wrote: >> >>> I think the ORC runtim

[PATCH] D112903: [C++20] [Module] Fix front end crashes when trying to export a qualified entity which is already declared

ChuanqiXu added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:7784-7785 "because namespace %1 does not enclose namespace %2">; +def err_invalid_declarator_in_export : Error<"cannot export %0 here " + "because it had be declared in %1.">; def e

[PATCH] D112903: [C++20] [Module] Fix front end crashes when trying to export a qualified entity which is already declared

ChuanqiXu added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:5748-5750 +else if (isa(Cur)) + Diag(Loc, diag::err_invalid_declarator_in_export) + << Name << cast(DC) << SS.getRange(); ChuanqiXu wrote: > aaron.ballman wrote: > > Chuanq

[PATCH] D113096: [X86][MS-InlineAsm] Add constraint *m for memory access w/ global var

pengfei added inline comments. Comment at: clang/test/CodeGen/ms-inline-asm-static-variable.c:8 + // CHECK: @arr = internal global [10 x i32] + // CHECK: call void asm sideeffect inteldialect "mov dword ptr $0[edx * $$4],edx", "=*m,{{.*}}([10 x i32]* @arr) + __asm mov dword

[PATCH] D108696: [Coroutines] [Frontend] Lookup in std namespace first

ChuanqiXu added a comment. @lxfind @Quuxplusone @lewissbaker Thanks for looking into this! I have committed this. Since the remained problem is that whether or not should we support the case that user uses "std::coroutine*" and "std::experimental::coroutine*" at the same time. As the reason we s

[PATCH] D108482: [Clang] Fix instantiation of OpaqueValueExprs (Bug #45964)

ricejasonf added a comment. In D108482#3105889 , @tambre wrote: > I presume you lack the permissions to push this to the main repo yourself. > Would you like me to do that for you? Yes, please. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D113096: [X86][MS-InlineAsm] Add constraint *m for memory access w/ global var

skan marked 3 inline comments as done. skan added inline comments. Comment at: clang/test/CodeGen/ms-inline-asm-static-variable.c:8 + // CHECK: @arr = internal global [10 x i32] + // CHECK: call void asm sideeffect inteldialect "mov dword ptr $0[edx * $$4],edx", "=*m,{{.*}}([1

[PATCH] D110257: [CFE][Codegen] Make sure to maintain the contiguity of all the static allocas

hsmhsm updated this revision to Diff 384661. hsmhsm added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110257/new/ https://reviews.llvm.org/D110257 Files: clang/lib/CodeGen/CGExpr.cpp clang/lib/CodeGen/CodeGenFunction.cpp

[PATCH] D110257: [CFE][Codegen] Make sure to maintain the contiguity of all the static allocas

hsmhsm added a comment. This patch is waiting for an action for a long time. I am expecting at-least anyone of the reviewers to either say "yes" or "no" or "further required improvements" on this patch so that I can take further action on this patch. If you say "no" to this patch with a strong

[PATCH] D113168: [clang-tblgen] Fix non-determinism in generating AttrSubMatchRulesParserStringSwitches.inc

ikudrin created this revision. ikudrin added reviewers: arphaman, aaron.ballman, rsmith. Herald added a subscriber: mgrang. ikudrin requested review of this revision. Herald added a project: clang. `llvm::MapVector`, compared to `std::map`, guarantees the same iteration order in different runs.

[PATCH] D111199: [Clang][LLVM][Attr] support btf_type_tag attribute

yonghong-song added a comment. > That sounds reasonable to me, but one possibility would be to change > createType() and getOrCreateType() to take a TypeSourceInfo * rather than a > QualType (because you can go from the TypeSourceInfo * back to the QualType > by calling getType() on it). Howeve

[PATCH] D113096: [X86][MS-InlineAsm] Add constraint *m for memory access w/ global var

xiangzhangllvm added inline comments. Comment at: llvm/lib/Target/X86/AsmParser/X86AsmParser.cpp:1759 // It is widely common for MS InlineAsm to use a global variable and one/two // registers in a mmory expression, and though unaccessible via rip/eip. if (IsGlobalLV && (

<    1   2