[PATCH] D112987: [RISCV] Bump rvv-related extensions from 0.10 to 1.0

eopXD created this revision. eopXD added reviewers: kito.cheng, craig.topper. Herald added subscribers: VincentWu, luke957, achieveartificialintelligence, vkmr, frasercrmck, jdoerfert, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, M

[PATCH] D112987: [RISCV] Bump rvv-related extensions from 0.10 to 1.0

eopXD updated this revision to Diff 383987. eopXD added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112987/new/ https://reviews.llvm.org/D112987 Files: clang/test/Driver/riscv-arch.c clang/test/Preprocessor/riscv-target-fe

[PATCH] D110833: [clang-format] Refactor SpaceBeforeParens to add options

crayroud updated this revision to Diff 383988. crayroud retitled this revision from "[clang-format] Refactor SpaceBeforeParens to add flags" to "[clang-format] Refactor SpaceBeforeParens to add options". crayroud edited the summary of this revision. crayroud added a comment. - SpaceBeforeParensFl

[PATCH] D110833: [clang-format] Refactor SpaceBeforeParens to add options

crayroud marked 6 inline comments as done. crayroud added inline comments. Comment at: clang/docs/ClangFormatStyleOptions.rst:3708 +SpaceBeforeParens: Custom +SpaceBeforeParensFlags: + AfterFunctionDefinitionName: true MyDeveloperDay wrote: > I'm not

[PATCH] D110833: [clang-format] Refactor SpaceBeforeParens to add options

crayroud marked 10 inline comments as done. crayroud added a comment. I used the following command to verify my changes on multiple files. Thank you for the tip. clang-format -verbose -n -files clang/docs/tools/clang-formatted-files.txt CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1

[PATCH] D112864: [clang-tidy] Fix lint warnings in clang-tidy source code (NFC)

This revision was automatically updated to reflect the committed changes. Closed by commit rGade0662c51b5: [clang-tidy] Fix lint warnings in clang-tidy source code (NFC) (authored by salman-javed-nz). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112

[clang-tools-extra] ade0662 - [clang-tidy] Fix lint warnings in clang-tidy source code (NFC)

Author: Salman Javed Date: 2021-11-02T20:14:25+13:00 New Revision: ade0662c51b571ea7e80fcb53516485086032d7f URL: https://github.com/llvm/llvm-project/commit/ade0662c51b571ea7e80fcb53516485086032d7f DIFF: https://github.com/llvm/llvm-project/commit/ade0662c51b571ea7e80fcb53516485086032d7f.diff

[PATCH] D110833: [clang-format] Refactor SpaceBeforeParens to add options

MyDeveloperDay added a comment. This looks pretty good to me. Could you add a release note into docs/ReleaseNote.rst (we have a .clang-format section) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110833/new/ https://reviews.llvm.org/D110833 ___

[PATCH] D110833: [clang-format] Refactor SpaceBeforeParens to add options

MyDeveloperDay added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:3469 return true; - if (Right.is(TT_OverloadedOperatorLParen)) -return spaceRequiredBeforeParens(Right); - if (Left.is(tok::comma)) + if (Left.is(tok::comma) && !Right.is(TT_Overload

[PATCH] D110833: [clang-format] Refactor SpaceBeforeParens to add options

crayroud added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:3469 return true; - if (Right.is(TT_OverloadedOperatorLParen)) -return spaceRequiredBeforeParens(Right); - if (Left.is(tok::comma)) + if (Left.is(tok::comma) && !Right.is(TT_OverloadedOper

[PATCH] D110833: [clang-format] Refactor SpaceBeforeParens to add options

crayroud updated this revision to Diff 383995. crayroud added a comment. Add a release note into clang/docs/ReleaseNotes.rst CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110833/new/ https://reviews.llvm.org/D110833 Files: clang/docs/ClangFormatStyleOptions.rst clang/docs/ReleaseNo

[PATCH] D109215: [RISCV] Fix arch string parsing for multi-character extensions

eopXD added a reviewer: asb. eopXD added a comment. @asb @jrtc27 Hi Alex and Jessica, Although the issue on relaxing naming rules aren't resolved in riscv-isa-manual [1], the v-spec v1.0 had come out including `zve` and `zvl` extensions and is frozen [2]. I have just finished a series of patch

[clang] 6bfc85c - Fix inline builtin handling in case of redefinition

Author: serge-sans-paille Date: 2021-11-02T09:53:49+01:00 New Revision: 6bfc85c217e443ecbde37b142a01dc7925792edc URL: https://github.com/llvm/llvm-project/commit/6bfc85c217e443ecbde37b142a01dc7925792edc DIFF: https://github.com/llvm/llvm-project/commit/6bfc85c217e443ecbde37b142a01dc7925792edc.d

[PATCH] D112059: Fix inline builtin handling in case of redefinition

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6bfc85c217e4: Fix inline builtin handling in case of redefinition (authored by serge-sans-paille). Changed prior to commit: https://reviews.llvm.o

[PATCH] D95168: [clang-format] Add InsertBraces option

owenpan added a comment. In D95168#3100969 , @MyDeveloperDay wrote: > In D95168#3099920 , @owenpan wrote: > >> In D95168#3099739 , @MyDeveloperDay >> wrote: >> >>> - Look f

[PATCH] D109950: [Clang] Enable IC/IF mode for __ibm128

qiucf added a comment. In D109950#3101740 , @rjmccall wrote: > Thanks. @hubert.reinterpretcast, @qiucf, can you verify that other compilers > for PPC follow the logic for `TF` / `TC` that we now have with Elizabeth's > patch? There are three different

[PATCH] D109144: [SPIR-V] Add SPIR-V triple architecture and clang target info

linjamaki added a comment. Is this patch ready to land on the LLVM? We do not have commit rights, so can you please commit this patch for us? Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109144/new/ https://reviews.llvm.org/D109144 _

[PATCH] D112914: Misleading identifier detection

serge-sans-paille updated this revision to Diff 384006. serge-sans-paille added a comment. - fix formatting - added documentation - *not* doing the extra work wrt. unicode error recovery CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112914/new/ https://reviews.llvm.org/D112914 Files:

[PATCH] D112914: Misleading identifier detection

carlosgalvezp requested changes to this revision. carlosgalvezp added a comment. This revision now requires changes to proceed. - Add check to list of checks: https://github.com/llvm/llvm-project/blob/main/clang-tools-extra/docs/clang-tidy/checks/list.rst - Mention check in the Release Notes: ht

[PATCH] D112975: Fix complex types declared using mode TC

qiucf accepted this revision. qiucf added a comment. Thanks. This issue looks a little bit like D109943 . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112975/new/ https://reviews.llvm.org/D112975 ___ cfe-co

[PATCH] D112914: Misleading identifier detection

serge-sans-paille updated this revision to Diff 384017. serge-sans-paille added a comment. Also update clang-tidy doc index CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112914/new/ https://reviews.llvm.org/D112914 Files: clang-tools-extra/clang-tidy/misc/CMakeLists.txt clang-tools

[PATCH] D112914: Misleading identifier detection

serge-sans-paille updated this revision to Diff 384020. serge-sans-paille added a comment. Update release note too. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112914/new/ https://reviews.llvm.org/D112914 Files: clang-tools-extra/clang-tidy/misc/CMakeLists.txt clang-tools-extra/c

[PATCH] D112996: [CodeCompletion] Generally consider header files without extension

ckandeler created this revision. ckandeler added a reviewer: sammccall. ckandeler requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Real-world use case: The Qt framework's headers have the same name as the respective class defined in them, an

[PATCH] D112996: [CodeCompletion] Generally consider header files without extension

ckandeler added a comment. I hope this isn't too controversial. After all, the files are located in include directories, so there shouldn't be any random garbage getting picked up. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112996/new/ https://

[PATCH] D112926: run-clang-tidy.py analyze unique files only

salman-javed-nz added a comment. Why does the compile-commands.json have duplicate entries in the first place? Would someone do that on purpose? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112926/new/ https://reviews.llvm.org/D112926 ___ c

[clang-tools-extra] 4bcbb3d - [clang-tidy] Add check 'cert-err33-c'.

Author: Balázs Kéri Date: 2021-11-02T11:38:47+01:00 New Revision: 4bcbb3d4d7a821a4ae29ec9333fe9d4c26240286 URL: https://github.com/llvm/llvm-project/commit/4bcbb3d4d7a821a4ae29ec9333fe9d4c26240286 DIFF: https://github.com/llvm/llvm-project/commit/4bcbb3d4d7a821a4ae29ec9333fe9d4c26240286.diff L

[PATCH] D112409: [clang-tidy] Add check 'cert-err33-c'.

This revision was automatically updated to reflect the committed changes. Closed by commit rG4bcbb3d4d7a8: [clang-tidy] Add check 'cert-err33-c'. (authored by balazske). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112409/new/ https://reviews.llvm.

[PATCH] D107049: [clang-repl] Re-implement clang-interpreter as a test case.

uabelho added a comment. In D107049#3100939 , @lhames wrote: > In D107049#3096727 , @uabelho wrote: > >> Hi, >> >> We're seeing a problem with this patch in our downstream (not public) >> buildbots. With an asan-

[PATCH] D112926: run-clang-tidy.py analyze unique files only

serkazi added a comment. In D112926#3102417 , @salman-javed-nz wrote: > Why does the compile-commands.json have duplicate entries in the first place? > Would someone do that on purpose? Think of a large project where people -- for various reasons -- do

[PATCH] D100810: Use `GNUInstallDirs` to support custom installation dirs. -- LLVM

compnerd accepted this revision. compnerd added inline comments. This revision is now accepted and ready to land. Comment at: llvm/CMakeLists.txt:289 +set(LLVM_TOOLS_INSTALL_DIR "${CMAKE_INSTALL_BINDIR}" CACHE STRING +"Path for binary subdirectory (defaults to 'bin')") mark_

Re: [PATCH] D112883: [bazel] Re-introduce `copts` hacks for lib/AST includes.

SGTM If you're coming here because it breaks your build please let us know :-) smime.p7s Description: S/MIME Cryptographic Signature ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D100810: Use `GNUInstallDirs` to support custom installation dirs. -- LLVM

Ericson2314 updated this revision to Diff 383961. Ericson2314 added a comment. Fix last comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100810/new/ https://reviews.llvm.org/D100810 Files: clang/tools/scan-build/CMakeLists.txt libclc/CMak

[PATCH] D99484: Use `GNUInstallDirs` to support custom installation dirs.

Ericson2314 updated this revision to Diff 383962. Ericson2314 added a comment. Simple rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99484/new/ https://reviews.llvm.org/D99484 Files: clang-tools-extra/clang-doc/tool/CMakeLists.txt clang-

[PATCH] D95168: [clang-format] Add InsertBraces option

MyDeveloperDay added a comment. In D95168#3102247 , @owenpan wrote: > In D95168#3100969 , @MyDeveloperDay > wrote: > >> In D95168#3099920 , @owenpan wrote: >> >>> In D95168#

[PATCH] D111199: [Clang][LLVM][Attr] support btf_type_tag attribute

aaron.ballman added a comment. In D99#3101484 , @yonghong-song wrote: > Just to be sure my understanding is correct. Given an AttributedType node, we > do have a way to get the corresponding Attr, is it right? @aaron.ballman Oh yeah, now I remember

[PATCH] D113000: [clang-format] NOT FOR COMMIT - Demo of AutomaticBraces: Remove

MyDeveloperDay created this revision. MyDeveloperDay added a reviewer: HazardyKnusperkeks. MyDeveloperDay added a project: clang-format. MyDeveloperDay requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is not for committing its a clang-f

[PATCH] D95168: [clang-format] Add InsertBraces option

MyDeveloperDay added a comment. This is a demo of what I mean {https://reviews.llvm.org/D113000} you can see its pretty aggressive, I could kind of imagine people wanting a little more control Sometimes this feels inconsistent F20029866: image.png and in t

[PATCH] D112001: [Clang] Add min/max reduction builtins.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112001/new/ https://reviews.llvm.org/D112001

[PATCH] D112914: Misleading identifier detection

carlosgalvezp added a comment. Looks good, I guess the license issue still needs to be sorted out? Comment at: clang-tools-extra/docs/clang-tidy/checks/misc-misleading-identifier.rst:6 + +Finds identifiers that contain Unicode characetrs with right-to-left direction, +which ca

[PATCH] D112221: Mark ATOMIC_VAR_INIT and ATOMIC_FLAG_INIT as deprecated

aaron.ballman added a comment. ping @ldionne or @cjdb for libc++ review CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112221/new/ https://reviews.llvm.org/D112221 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/

[PATCH] D112914: Misleading identifier detection

serge-sans-paille added a comment. AKAIU, the licensing issue doesn't impact that particular review, only the one on confusable identifiers. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112914/new/ https://reviews.llvm.org/D112914 ___ cfe-c

[PATCH] D112914: Misleading identifier detection

carlosgalvezp resigned from this revision. carlosgalvezp added a comment. This revision is now accepted and ready to land. Ok! I don't really know what applies when you take //part// of a file, so I'll leave that up to people who know. I don't know how to remove the "Requested changes" from here

[PATCH] D112921: [clang] Enable sized deallocation by default in C++14 onwards

ldionne requested changes to this revision. ldionne added inline comments. This revision now requires changes to proceed. Comment at: libcxx/test/std/language.support/support.dynamic/new.delete/new.delete.array/sized_delete_array14.pass.cpp:12 // UNSUPPORTED: sanitizer-new-dele

[PATCH] D112916: Confusable identifiers detection

serge-sans-paille added subscribers: tonic, tstellar. serge-sans-paille added a comment. @tonic / @tstellar as members of the LLVM fundation board, can you tell us if it's okay to ship the `confusables.txt` file from https://www.unicode.org/Public/security/latest/confusables.txt and what are the

[PATCH] D112996: [CodeCompletion] Generally consider header files without extension

sammccall added a comment. > the files are located in include directories These are directories that **may** contain headers, not directories that **only** contain headers. (Which we mostly expect `-Isystem` to be). For example, many projects keep headers next to sources, and so have sources on

[PATCH] D112491: Add `LambdaCapture`-related matchers.

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Thanks for the changes, this looks great to me now. Comment at: clang/docs/LibASTMatchersReference.html:8368 +lambdaExpr(hasAnyCapture(lambdaCapture(capturesVar(hasName

[PATCH] D112765: [AST] injected-class-name is not a redecl, even in template specializations

sammccall marked 4 inline comments as done. sammccall added inline comments. Comment at: clang/lib/AST/ASTDumper.cpp:94 auto *Redecl = dyn_cast(RedeclWithBadType); -if (!Redecl) { - // Found the injected-class-name for a class template. This will be dumped

[clang] 6a5e08c - [AST] injected-class-name is not a redecl, even in template specializations

Author: Sam McCall Date: 2021-11-02T14:37:45+01:00 New Revision: 6a5e08cc4a5c64de08a277dd2e0a862120c5fc28 URL: https://github.com/llvm/llvm-project/commit/6a5e08cc4a5c64de08a277dd2e0a862120c5fc28 DIFF: https://github.com/llvm/llvm-project/commit/6a5e08cc4a5c64de08a277dd2e0a862120c5fc28.diff LO

[PATCH] D112765: [AST] injected-class-name is not a redecl, even in template specializations

This revision was automatically updated to reflect the committed changes. sammccall marked an inline comment as done. Closed by commit rG6a5e08cc4a5c: [AST] injected-class-name is not a redecl, even in template specializations (authored by sammccall). Changed prior to commit: https://reviews.ll

[clang] 9b5c9c4 - [analyzer] Dump checker name if multiple checkers evaluate the same call

Author: Balazs Benics Date: 2021-11-02T14:42:14+01:00 New Revision: 9b5c9c469d90227251d9da9108ee7985ba415f2b URL: https://github.com/llvm/llvm-project/commit/9b5c9c469d90227251d9da9108ee7985ba415f2b DIFF: https://github.com/llvm/llvm-project/commit/9b5c9c469d90227251d9da9108ee7985ba415f2b.diff

[PATCH] D112889: [analyzer] Dump checker name if multiple checkers evaluate the same call

This revision was automatically updated to reflect the committed changes. steakhal marked 2 inline comments as done. Closed by commit rG9b5c9c469d90: [analyzer] Dump checker name if multiple checkers evaluate the same call (authored by steakhal). Herald added a project: clang. Herald added a subsc

[PATCH] D112889: [analyzer] Dump checker name if multiple checkers evaluate the same call

steakhal added a comment. Committed with the requested changes. Comment at: clang/lib/StaticAnalyzer/Core/CheckerManager.cpp:679 +#ifndef NDEBUG + if (evaluated && evaluatorChecker.hasValue()) { +const auto dump = [](const CallEvent &Call) -> std::string {

[PATCH] D95168: [clang-format] Add InsertBraces option

MyDeveloperDay updated this revision to Diff 384070. MyDeveloperDay added a comment. Herald added a subscriber: mgorny. Move BraceInserter into its own file and tests Add experimental support for "Remove" CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95168/new/ https://reviews.llvm.org

[PATCH] D112996: [CodeCompletion] Generally consider header files without extension

ckandeler added a comment. > WDYT about detecting QT headers specifically? It seems hacky, but I don't see > a way out of this that doesn't involve hardcoding some filenames. Are they in > a directory like `"qt-11/QFoo"` that we can recognize? Even Q followed by > another capital letter might b

[clang] 7999355 - [Clang] Add min/max reduction builtins.

Author: Florian Hahn Date: 2021-11-02T15:01:42+01:00 New Revision: 7999355106fb2fcc8de243d2e34b4b73ae4f3d2f URL: https://github.com/llvm/llvm-project/commit/7999355106fb2fcc8de243d2e34b4b73ae4f3d2f DIFF: https://github.com/llvm/llvm-project/commit/7999355106fb2fcc8de243d2e34b4b73ae4f3d2f.diff

[PATCH] D112001: [Clang] Add min/max reduction builtins.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7999355106fb: [Clang] Add min/max reduction builtins. (authored by fhahn). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:

[PATCH] D108451: [Sema] Avoid crash in CheckEnumConstant with contains-error expressions

sammccall updated this revision to Diff 384084. sammccall marked 3 inline comments as done. sammccall added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108451/new/ https://reviews.llvm.org/D108451 Files: clang/lib/S

[PATCH] D112921: [clang] Enable sized deallocation by default in C++14 onwards

pcwang-thead updated this revision to Diff 384089. pcwang-thead added a comment. Makes required changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112921/new/ https://reviews.llvm.org/D112921 Files: clang-tools-extra/clangd/unittests/FindTarg

[PATCH] D108451: [Sema] Avoid crash in CheckEnumConstant with contains-error expressions

sammccall added a comment. Thanks, and sorry for sitting on this so long. Addressed comments. I think the failing windows bots were implicit `-fms-extensions` or so that sometimes makes diagnosis more lazy. Moving the test to recovery-expr-type.cpp should take care of this as that test case sp

[clang] 6fd2db0 - Use `GNUInstallDirs` to support custom installation dirs. -- LLVM

Author: John Ericson Date: 2021-11-02T10:23:30-04:00 New Revision: 6fd2db04d0f22ea22c5317d98ce2126aa64b6a73 URL: https://github.com/llvm/llvm-project/commit/6fd2db04d0f22ea22c5317d98ce2126aa64b6a73 DIFF: https://github.com/llvm/llvm-project/commit/6fd2db04d0f22ea22c5317d98ce2126aa64b6a73.diff

[libclc] 6fd2db0 - Use `GNUInstallDirs` to support custom installation dirs. -- LLVM

Author: John Ericson Date: 2021-11-02T10:23:30-04:00 New Revision: 6fd2db04d0f22ea22c5317d98ce2126aa64b6a73 URL: https://github.com/llvm/llvm-project/commit/6fd2db04d0f22ea22c5317d98ce2126aa64b6a73 DIFF: https://github.com/llvm/llvm-project/commit/6fd2db04d0f22ea22c5317d98ce2126aa64b6a73.diff

[PATCH] D112349: [Verifier] Add verification logic for GlobalIFuncs

erichkeane added a comment. So I've noticed in my downstream that this fires in the cpu-dispatch.c codegen test, though it doesn't seem to catch it here? I'm not sure how this happens, but from your description, it SEEMS like this case https://godbolt.org/z/nejWhbsxa should cause this error.

[PATCH] D112349: [Verifier] Add verification logic for GlobalIFuncs

erichkeane added a comment. I note now that asserts build fails for it: https://godbolt.org/z/r738hGoKf Should this be reverted? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112349/new/ https://reviews.llvm.org/D112349 __

[PATCH] D112914: Misleading identifier detection

serge-sans-paille added a comment. In D112914#3102728 , @carlosgalvezp wrote: > Ok! I don't really know what applies when you take //part// of a file, so > I'll leave that up to people who know. I don't know how to remove the > "Requested changes" from

[PATCH] D112647: [clang-apply-replacements] Correctly handle relative paths

avogelsgesang added a subscriber: alexfh. avogelsgesang added a comment. >> Those relative paths are meant to be resolved relative to the corresponding >> build directory. > > Is this behavior documented somewhere? I couldn't find this documented anywhere. My assumption is based on behavior whi

[clang] 5880c83 - [Sema] Avoid crash in CheckEnumConstant with contains-error expressions

Author: Sam McCall Date: 2021-11-02T15:35:53+01:00 New Revision: 5880c835bdbe50542a19c3e4065d1536db711443 URL: https://github.com/llvm/llvm-project/commit/5880c835bdbe50542a19c3e4065d1536db711443 DIFF: https://github.com/llvm/llvm-project/commit/5880c835bdbe50542a19c3e4065d1536db711443.diff LO

[PATCH] D108451: [Sema] Avoid crash in CheckEnumConstant with contains-error expressions

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5880c835bdbe: [Sema] Avoid crash in CheckEnumConstant with contains-error expressions (authored by sammccall). Repository: rG LLVM Github Monorepo

[PATCH] D111866: [RISCV] Support Zfhmin extension

asb added inline comments. Herald added a subscriber: luke957. Comment at: llvm/lib/Target/RISCV/RISCVISelLowering.cpp:1153 bool ForCodeSize) const { - if (VT == MVT::f16 && !Subtarget.hasStdExtZfh()) + if (VT == MVT::f16 && !Subtarget.ha

[PATCH] D112913: Misleading bidirectional detection

serge-sans-paille updated this revision to Diff 384111. serge-sans-paille added a comment. - recover from failed utf8 decoding - doc and release note updated - clang-formatting - more examples / testing CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112913/new/ https://reviews.llvm.org/D

[PATCH] D112491: Add `LambdaCapture`-related matchers.

jcking1034 updated this revision to Diff 384114. jcking1034 added a comment. Update documentation for `capturesVar` matcher. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112491/new/ https://reviews.llvm.org/D112491 Files: clang/docs/LibASTMatch

[PATCH] D112453: [Sema] When dereferencing a pointer of dependent type, infer the result type.

courbet added a comment. Ping ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112453/new/ https://reviews.llvm.org/D112453 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/c

[PATCH] D106823: [analyzer][solver] Iterate to a fixpoint during symbol simplification with constants

martong updated this revision to Diff 384117. martong marked 3 inline comments as done. martong added a comment. - Reach the fixpoint by recursively calling `State->assume` on the simplified symbol. - Address review nits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:

[PATCH] D106823: [analyzer][solver] Iterate to a fixpoint during symbol simplification with constants

martong added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:1699-1701 + ProgramStateRef OldState; + do { +OldState = State; steakhal wrote: > IMO we should have a `llvm::Statistic` here, tracking the maximum iteration

[PATCH] D112914: Misleading identifier detection

serge-sans-paille updated this revision to Diff 384118. serge-sans-paille added a comment. Minor typos CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112914/new/ https://reviews.llvm.org/D112914 Files: clang-tools-extra/clang-tidy/misc/CMakeLists.txt clang-tools-extra/clang-tidy/mis

[PATCH] D106823: [analyzer][solver] Iterate to a fixpoint during symbol simplification with constants

martong updated this revision to Diff 384122. martong added a comment. - Add essay about complexity. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106823/new/ https://reviews.llvm.org/D106823 Files: clang/include/clang/StaticAnalyzer/Core/PathS

[PATCH] D112768: [ARM] implement support for TLS register based stack protector

ardb updated this revision to Diff 384116. ardb added a comment. - add diagnostics to the frontend and asserts to the backend to ensure that the TLS stack protector is only used on target subarchs that implement the hardware TLS register to begin with - ensure that the offset parameter is not om

[PATCH] D112971: [NFC] Remove LinkAll*.h

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGfe364e5dc78c: [NFC] Remove LinkAll*.h (authored by aeubanks). Herald added a subscriber: awarzynski. Changed prior to commit: https://reviews.llvm.

[clang] fe364e5 - [NFC] Remove LinkAll*.h

Author: Arthur Eubanks Date: 2021-11-02T08:43:17-07:00 New Revision: fe364e5dc78c58a915986d9a44cfd65f919a00c2 URL: https://github.com/llvm/llvm-project/commit/fe364e5dc78c58a915986d9a44cfd65f919a00c2 DIFF: https://github.com/llvm/llvm-project/commit/fe364e5dc78c58a915986d9a44cfd65f919a00c2.diff

[PATCH] D100810: Use `GNUInstallDirs` to support custom installation dirs. -- LLVM

This revision was automatically updated to reflect the committed changes. Closed by commit rG6fd2db04d0f2: Use `GNUInstallDirs` to support custom installation dirs. -- LLVM (authored by Ericson2314). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1008

[clang] e2024d7 - Revert "[NFC] Remove LinkAll*.h"

Author: Arthur Eubanks Date: 2021-11-02T09:08:09-07:00 New Revision: e2024d72fae778e0369127e078a40b4d6eb6c7bd URL: https://github.com/llvm/llvm-project/commit/e2024d72fae778e0369127e078a40b4d6eb6c7bd DIFF: https://github.com/llvm/llvm-project/commit/e2024d72fae778e0369127e078a40b4d6eb6c7bd.diff

[PATCH] D112975: Fix complex types declared using mode TC

eandrews added a comment. In D112975#3101720 , @rjmccall wrote: > For posterity in case someone tracks down this review: `TC` corresponds to an > unspecified 128-bit format, which on some targets is a double-double format > (like `__ibm128_t`) and on ot

[PATCH] D112453: [Sema] When dereferencing a pointer of dependent type, infer the result type.

aaron.ballman added a comment. In D112453#3084394 , @courbet wrote: > As per the comment in BuiltinTypes.def (see below), `Dependent` is > allowed in context where the type is deducible, but is there any reason > **not** to deduce the type if we can do it

[PATCH] D113026: [ARM] reject -mtp=cp15 if target subarch does not support it

ardb created this revision. ardb added reviewers: nickdesaulniers, peter.smith, rengolin, kees, ostannard. Herald added a subscriber: kristof.beyls. ardb requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Currently, we permit -mtp=cp15 even fo

[PATCH] D113029: [clangd] Find definition of ClassTemplate without going through index.

adamcz created this revision. adamcz added a reviewer: kadircet. Herald added subscribers: usaxena95, arphaman. adamcz requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. I noticed that, while go-to-def works

[PATCH] D112577: [clang][OpenMP] Initial parsing/sema for 'align' clause

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM aside from some possible nits. Comment at: clang/lib/Serialization/ASTWriter.cpp:5018 Record.AddStmt(A->getAllocator()); +Record.AddStmt(A->getAlignment()); Record.AddSourceRange

[PATCH] D112453: [Sema] When dereferencing a pointer of dependent type, infer the result type.

rsmith added a comment. I think the idea of this change is OK. The key is that the dereference expression will still be type-dependent, even if we happen to actually know its type. (For an `Expr` that `isTypeDependent()`, the type produced by `getType()` isn't something the standard knows or ca

[PATCH] D112768: [ARM] implement support for TLS register based stack protector

ardb updated this revision to Diff 384154. ardb added a comment. - fix failure in newly added LLVM test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112768/new/ https://reviews.llvm.org/D112768 Files: clang/include/clang/Basic/DiagnosticCommonK

[clang] 98b761f - [RISCV] Rename vfredusum/vfredosum intrinsic test files. Merge some tests. NFC

Author: Craig Topper Date: 2021-11-02T10:33:20-07:00 New Revision: 98b761fce68b194674a98f347c641f8ce3e85eff URL: https://github.com/llvm/llvm-project/commit/98b761fce68b194674a98f347c641f8ce3e85eff DIFF: https://github.com/llvm/llvm-project/commit/98b761fce68b194674a98f347c641f8ce3e85eff.diff

[clang] 2d39534 - [cmake] Make LLVM_ENABLE_LLD=ON work better on macOS

Author: Nico Weber Date: 2021-11-02T13:35:21-04:00 New Revision: 2d3953499c8ca73c12e9417f5c4516c8a930a689 URL: https://github.com/llvm/llvm-project/commit/2d3953499c8ca73c12e9417f5c4516c8a930a689 DIFF: https://github.com/llvm/llvm-project/commit/2d3953499c8ca73c12e9417f5c4516c8a930a689.diff LO

[PATCH] D113021: [cmake] Make LLVM_ENABLE_LLD=ON work better on macOS

This revision was automatically updated to reflect the committed changes. Closed by commit rG2d3953499c8c: [cmake] Make LLVM_ENABLE_LLD=ON work better on macOS (authored by thakis). Herald added a project: clang. Herald added a subscriber: cfe-commits. Changed prior to commit: https://reviews.l

[clang] 5a892be - [clang] Fix cmake error

Author: Dave Lee Date: 2021-11-02T10:47:44-07:00 New Revision: 5a892be237a20002c88a80b618e6f5febfd7a4f6 URL: https://github.com/llvm/llvm-project/commit/5a892be237a20002c88a80b618e6f5febfd7a4f6 DIFF: https://github.com/llvm/llvm-project/commit/5a892be237a20002c88a80b618e6f5febfd7a4f6.diff LOG:

[PATCH] D113026: [ARM] reject -mtp=cp15 if target subarch does not support it

nickdesaulniers added a comment. Thanks for the patch! Don't forget to run `git-clang-format HEAD~`. Comment at: clang/lib/Driver/ToolChains/Arch/ARM.cpp:160-161 +if (ThreadPointer == ReadTPMode::Cp15 && +getARMSubArchVersionNumber(Triple) < 7 && +llvm::ARM:

[clang] 797b50d - Revert "Use `GNUInstallDirs` to support custom installation dirs. -- LLVM"

Author: Med Ismail Bennani Date: 2021-11-02T19:11:44+01:00 New Revision: 797b50d4be873b4662983413a06806fca544c276 URL: https://github.com/llvm/llvm-project/commit/797b50d4be873b4662983413a06806fca544c276 DIFF: https://github.com/llvm/llvm-project/commit/797b50d4be873b4662983413a06806fca544c276.

[PATCH] D95168: [clang-format] Add InsertBraces option

MyDeveloperDay updated this revision to Diff 384171. MyDeveloperDay removed a reviewer: klimek. MyDeveloperDay set the repository for this revision to rG LLVM Github Monorepo. MyDeveloperDay added a comment. Add some more testcases to catch handling removing {} from the nested if, but not the out

[PATCH] D110663: [Driver] Support Debian multiarch style lib/clang/14.0.0/x86_64-linux-gnu runtime path and include/x86_64-linux-gnu/c++/v1 libc++ path

MaskRay added a comment. Herald added a subscriber: luke957. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110663/new/ https://reviews.llvm.org/D110663 ___ cfe-commits mailing list cfe-commits@lists

[PATCH] D112768: [ARM] implement support for TLS register based stack protector

nickdesaulniers added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:3177-3179 + if (!Args.hasArg(options::OPT_mstack_protector_guard_offset_EQ)) { +D.Diag(diag::err_drv_ssp_missing_offset_argument) +<< A->getOption().getName() << Valu

[PATCH] D100810: Use `GNUInstallDirs` to support custom installation dirs. -- LLVM

mib added a comment. Hi @Ericson2314, I think this patch broke our macOS lldb-incremental bot on GreenDragon (https://green.lab.llvm.org/green/job/lldb-cmake/37560/console). Could you please take a look ? Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[PATCH] D100810: Use `GNUInstallDirs` to support custom installation dirs. -- LLVM

mib added a comment. I reverted this patch locally and try building with clang modules (`-DLLVM_ENABLE_MODULE=On`) which confirmed it was causing the build failure on the bots. I had to revert your patch upstream to fix our bots. If you need some help to reproduce the build failure, let me kno

[PATCH] D113026: [ARM] reject -mtp=cp15 if target subarch does not support it

ardb updated this revision to Diff 384175. ardb edited the summary of this revision. ardb added a comment. Fix test issue and add more test cases CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113026/new/ https://reviews.llvm.org/D113026 Files: clang/lib/Driver/ToolChains/Arch/ARM.cpp

[PATCH] D113026: [ARM] reject -mtp=cp15 if target subarch does not support it

ardb marked 2 inline comments as done. ardb added inline comments. Comment at: clang/lib/Driver/ToolChains/Arch/ARM.cpp:160-161 +if (ThreadPointer == ReadTPMode::Cp15 && +getARMSubArchVersionNumber(Triple) < 7 && +llvm::ARM::parseArch(Triple.getArchName()) !=

  1   2   >