[PATCH] D111883: [Parse] Improve diagnostic and recoveryy when there is an extra override in the outline method definition.

hokein updated this revision to Diff 380291. hokein marked 2 inline comments as done. hokein added a comment. virt-specifier => specifier Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111883/new/ https://reviews.llvm.org/D111883 Files: clang/inc

[PATCH] D111883: [Parse] Improve diagnostic and recoveryy when there is an extra override in the outline method definition.

hokein added inline comments. Comment at: clang/include/clang/Basic/DiagnosticParseKinds.td:948 +def err_virt_specifier_outside_class : Error< + "'%0' virt-specifier is not allowed outside a class definition">; + sammccall wrote: > sammccall wrote: > > `virt-spe

[PATCH] D105169: [Clang/Test]: Rename enable_noundef_analysis to disable-noundef-analysis and turn it off by default

mstorsjo added a comment. In D105169#3069220 , @aqjune wrote: > It seems the original code has a use of an uninitialized variable. > Line 4420 at seek-preproc.c (function `ff_seek_frame_binary`): > >int64_t pos_min=pos_min, pos_max=pos_max, pos, pos_l

[clang] 6e63f96 - [Parse] Improve diagnostic and recovery when there is an extra override in the outline method definition.

Author: Haojian Wu Date: 2021-10-18T10:00:21+02:00 New Revision: 6e63f96e11ee9af300b166c994980d3b80cea0c7 URL: https://github.com/llvm/llvm-project/commit/6e63f96e11ee9af300b166c994980d3b80cea0c7 DIFF: https://github.com/llvm/llvm-project/commit/6e63f96e11ee9af300b166c994980d3b80cea0c7.diff LO

[PATCH] D111883: [Parse] Improve diagnostic and recoveryy when there is an extra override in the outline method definition.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6e63f96e11ee: [Parse] Improve diagnostic and recovery when there is an extra override in the… (authored by hokein). Repository: rG LLVM Github Mon

[PATCH] D105168: [RISCV] Unify the arch string parsing logic to RISCVISAInfo.

akuegel added inline comments. Comment at: llvm/include/llvm/Support/RISCVISAInfo.h:15 +#include "llvm/ADT/StringRef.h" +#include "llvm/Option/ArgList.h" +#include "llvm/Support/Error.h" Would it be possible to avoid the usage of ArgList in a target that belongs

[PATCH] D111975: [clang-format] [PR52015] clang-format should put __attribute__((foo)) on its own line before @interface / @implementation / @protocol

MyDeveloperDay created this revision. MyDeveloperDay added reviewers: benhamilton, krasimir, HazardyKnusperkeks, curdeius. MyDeveloperDay added projects: clang, clang-format. MyDeveloperDay requested review of this revision. https://bugs.llvm.org/show_bug.cgi?id=52015 A newline should be place b

[PATCH] D105168: [RISCV] Unify the arch string parsing logic to RISCVISAInfo.

teemperor added a comment. This broke the modules build: While building module 'LLVM_Utils' imported from lvm/lib/Support/TargetParser.cpp:14: In file included from :209: llvm/include/llvm/Support/RISCVISAInfo.h:15:10: fatal error: could not build module 'LLVM_Option' #include "llvm/Opt

[PATCH] D110357: [Analyzer] Extend ConstraintAssignor to handle remainder op

steakhal accepted this revision. steakhal added a comment. I see. Now it looks correct. Next time we shall have a z3 proof about the theory. `A => B` <=> `not(A) or B`. which is SAT only if `A and not(B)` UNSAT. a = z3.BitVec('a', 32) b = z3.BitVec('b', 32) zero = z3.BitVecVal(0, 32) s =

[PATCH] D111543: [clang][modules] Delay creating `IdentifierInfo` for names of explicit modules

jansvoboda11 updated this revision to Diff 380304. jansvoboda11 retitled this revision from "[clang][modules] Stop creating `IdentifierInfo` for names of explicit modules" to "[clang][modules] Delay creating `IdentifierInfo` for names of explicit modules". jansvoboda11 edited the summary of this

[PATCH] D111543: [clang][modules] Delay creating `IdentifierInfo` for names of explicit modules

jansvoboda11 added a comment. Thanks for your analysis, Richard. You're right that we're incorrectly marking the identifier as up-to-date. I've rolled back my changes to `ModuleMap` cache and delayed the creation of `IdentifierInfo`. I'll commit if CI is happy. CHANGES SINCE LAST ACTION htt

[PATCH] D105169: [Clang/Test]: Rename enable_noundef_analysis to disable-noundef-analysis and turn it off by default

aqjune added a comment. In D105169#3069417 , @mstorsjo wrote: > Yes, I believe so. If the branch is not taken, `pos_min` and `pos_max` are > undefined when entering `ff_gen_search`. (I would assume that their value > isn't ever used within `ff_gen_searc

[PATCH] D110357: [Analyzer] Extend ConstraintAssignor to handle remainder op

ASDenysPetrov added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:1618-1627 +const SymbolRef LHS = Sym->getLHS(); +const llvm::APSInt &Zero = +Builder.getBasicValueFactory().getValue(0, Sym->getType()); +// a % b != 0 im

[PATCH] D105169: [Clang/Test]: Rename enable_noundef_analysis to disable-noundef-analysis and turn it off by default

mstorsjo added a comment. In D105169#3069555 , @aqjune wrote: > I see, the crash is happening at the line because SimplifyCFG removes the > `sti->index_entries` null pointer check (which seems valid to me). > If `stl->index_entries` was null, it would le

[clang] a2d805c - [clang][modules] Delay creating `IdentifierInfo` for names of explicit modules

Author: Jan Svoboda Date: 2021-10-18T11:50:29+02:00 New Revision: a2d805c020a1658b04ed7e606ee67e234a9d5b56 URL: https://github.com/llvm/llvm-project/commit/a2d805c020a1658b04ed7e606ee67e234a9d5b56 DIFF: https://github.com/llvm/llvm-project/commit/a2d805c020a1658b04ed7e606ee67e234a9d5b56.diff L

[PATCH] D110257: [CFE][Codegen] Make sure to maintain the contiguity of all the static allocas

hsmhsm updated this revision to Diff 380320. hsmhsm added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110257/new/ https://reviews.llvm.org/D110257 Files: clang/lib/CodeGen/CGExpr.cpp clang/lib/CodeGen/CodeGenFunction.cpp

[PATCH] D111543: [clang][modules] Delay creating `IdentifierInfo` for names of explicit modules

This revision was automatically updated to reflect the committed changes. Closed by commit rGa2d805c020a1: [clang][modules] Delay creating `IdentifierInfo` for names of explicit modules (authored by jansvoboda11). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[PATCH] D111866: [RISCV] Support Zfhmin extension

achieveartificialintelligence updated this revision to Diff 380323. achieveartificialintelligence added a comment. Herald added a subscriber: jdoerfert. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111866/new/ https://reviews.llvm.org/D1118

[PATCH] D110258: [AArch64] Always add -tune-cpu argument to -cc1 driver

david-arm updated this revision to Diff 380325. david-arm added a comment. - Added something to the ReleaseNotes file. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110258/new/ https://reviews.llvm.org/D110258 Files: clang/lib/Driver/ToolChains/Clang.cpp clang/test/Driver/aarch64-m

[PATCH] D111909: [clang-tidy] DefinitionsInHeadersCheck: Added option for checking C Code

whisperity added a comment. It would be interesting to add a test for this. I've recently came across the fact that Clang doesn't support //common linkage// definitions, namely that in **C** (but not in C++), if you do the following: int I; void f1(void) {} int I; void f2(void) {} a

[clang] c773f65 - [NFC] Remove Block-ABI-Apple.txt

Author: Shivam Gupta Date: 2021-10-18T15:42:31+05:30 New Revision: c773f6501dba6975660ce16ab73e6d86a10e6b71 URL: https://github.com/llvm/llvm-project/commit/c773f6501dba6975660ce16ab73e6d86a10e6b71 DIFF: https://github.com/llvm/llvm-project/commit/c773f6501dba6975660ce16ab73e6d86a10e6b71.diff

[PATCH] D111790: [AArch64][Driver][SVE] Allow -msve-vector-bits=+ syntax to mean no maximum vscale

bsmith updated this revision to Diff 380330. bsmith added a comment. - Avoid side-effects in assertions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111790/new/ https://reviews.llvm.org/D111790 Files: clang/include/clang/Basic/LangOptions.def

[PATCH] D107347: [Sema] haveSameParameterTypes - fix repeated isNull() test

urnathan added inline comments. Comment at: clang/lib/Sema/SemaOverload.cpp:9528 QualType T2 = NextParam(F2, I2, I == 0); -if (!T1.isNull() && !T1.isNull() && !Context.hasSameUnqualifiedType(T1, T2)) +if (!T1.isNull() && !T2.isNull() && !Context.hasSameUnqualifiedTy

[PATCH] D108696: [Coroutines] [Frontend] Lookup in std namespace first

avogelsgesang added a comment. Hi @ChuanqiXu sorry for what might be naive questions, but just to make sure I understand the context of this patch correctly: This patch fixes the look up of the `coroutine_traits`, so that clang now search both the `std` and the `std::experimental` namespace. A

[PATCH] D108301: [MSP430][Clang] Update hard-coded MCU data

jozefl added a comment. Ping. Thanks, Jozef Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108301/new/ https://reviews.llvm.org/D108301 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lis

[PATCH] D109174: [MSP430][Clang] Infer CPU type from -mcpu= or -mmcu=

jozefl added a comment. Ping. Thanks, Jozef Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109174/new/ https://reviews.llvm.org/D109174 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lis

[PATCH] D108696: [Coroutines] [Frontend] Lookup in std namespace first

ChuanqiXu added a comment. In D108696#3069723 , @avogelsgesang wrote: > Hi @ChuanqiXu > > sorry for what might be naive questions, but just to make sure I understand > the context of this patch correctly: Hi, you are welcome : ) > This patch fixes the

[PATCH] D111154: [WebAssembly] Implementation of table.get/set for reftypes in LLVM IR

pmatos updated this revision to Diff 380337. pmatos added a comment. Use reference to pointer instead of pointer to pointer as @tlively suggested. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54/new/ https://reviews.llvm.org/D54 Files:

[PATCH] D107347: [Sema] haveSameParameterTypes - fix repeated isNull() test

RKSimon added inline comments. Comment at: clang/lib/Sema/SemaOverload.cpp:9528 QualType T2 = NextParam(F2, I2, I == 0); -if (!T1.isNull() && !T1.isNull() && !Context.hasSameUnqualifiedType(T1, T2)) +if (!T1.isNull() && !T2.isNull() && !Context.hasSameUnqualifiedTyp

[PATCH] D107347: [Sema] haveSameParameterTypes - replace repeated isNull() test with assertions

RKSimon updated this revision to Diff 380338. RKSimon retitled this revision from "[Sema] haveSameParameterTypes - fix repeated isNull() test" to "[Sema] haveSameParameterTypes - replace repeated isNull() test with assertions". RKSimon edited the summary of this revision. Repository: rG LLVM G

[clang] 3b3509b - [Sema] haveSameParameterTypes - replace repeated isNull() test with assertions

Author: Simon Pilgrim Date: 2021-10-18T12:36:44+01:00 New Revision: 3b3509b3cba272c98d2235a8664ae9625ac729f8 URL: https://github.com/llvm/llvm-project/commit/3b3509b3cba272c98d2235a8664ae9625ac729f8 DIFF: https://github.com/llvm/llvm-project/commit/3b3509b3cba272c98d2235a8664ae9625ac729f8.diff

[PATCH] D107347: [Sema] haveSameParameterTypes - replace repeated isNull() test with assertions

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3b3509b3cba2: [Sema] haveSameParameterTypes - replace repeated isNull() test with assertions (authored by RKSimon). Repository: rG LLVM Github Mon

[PATCH] D111971: [clang] Allocate 2 bits to store the constexpr specifier kind when serializing

adamcz accepted this revision. adamcz added a comment. This revision is now accepted and ready to land. Fix LGTM As for the test, I suggest putting it in clang/test/AST/, maybe in ast-dump-constant-expr? You can write a CHECK-NEXT: thingy to verify that consteval is preserved. The test already

[PATCH] D111985: [Clang] Add elementwise min/max builtins.

fhahn created this revision. fhahn added reviewers: aaron.ballman, scanon, craig.topper, rjmccall, erichkeane. fhahn requested review of this revision. Herald added a project: clang. This patch implements __builtin_elementwise_max and __builtin_elementwise_min, as specified in D111529

[PATCH] D111986: [Clang] Add elementwise abs builtin.

fhahn created this revision. fhahn added reviewers: aaron.ballman, scanon, craig.topper, rjmccall, erichkeane. Herald added a subscriber: mstorsjo. fhahn requested review of this revision. Herald added a project: clang. This patch implements __builtin_elementwise_abs as specified in D111529

[PATCH] D99797: [analyzer] Implemented RangeSet::Factory::unite function to handle intersections and adjacency

ASDenysPetrov added a comment. In D99797#3059203 , @steakhal wrote: > PS: the test coverage is outstanding! Thank you for this analysis. Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:149 + +RangeSet RangeSet::Fac

[PATCH] D109372: [RISCV][RFC] Add Clang support for RISC-V overlay system

edward-jones updated this revision to Diff 380347. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109372/new/ https://reviews.llvm.org/D109372 Files: clang/include/clang/Basic/Attr.td clang/include/clang/Basic/AttrDocs.td clang/include/clang/Basic/DiagnosticDriverKinds.td clang/in

[PATCH] D111529: Specify Clang vector builtins.

fhahn updated this revision to Diff 380351. fhahn marked an inline comment as done. fhahn added a comment. Thanks for the latest set of comments! I tried to incorporate the suggestions about improving the reduction wording. I also added an example. I also put up 2 patches to start with the impl

[PATCH] D110258: [AArch64] Always add -tune-cpu argument to -cc1 driver

dmgreen added a comment. There are clang release notes that could also do with a line or two, after all the -mtune flag being a clang flag. The X86 notes for reference were added in https://releases.llvm.org/12.0.0/docs/ReleaseNotes.html and https://releases.llvm.org/12.0.0/tools/clang/docs/Rel

[PATCH] D111529: Specify Clang vector builtins.

fhahn updated this revision to Diff 380352. fhahn marked an inline comment as done. fhahn added a comment. adjust padding wording. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111529/new/ https://reviews.llvm.org/D111529 Files: clang/docs/Langu

[PATCH] D111529: Specify Clang vector builtins.

fhahn marked 2 inline comments as done. fhahn added inline comments. Comment at: clang/docs/LanguageExtensions.rst:553 +Each builtin returns a scalar equivalent to applying the specified +operation(x, y) as horizontal recursive pairwise reduction to all vector +elements. In each

[PATCH] D107450: [clang-tidy] Fix wrong FixIt in performance-move-const-arg

Sockke added a comment. Hi, Could anyone please review this diff? @whisperity, @aaron.ballman CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107450/new/ https://reviews.llvm.org/D107450 ___ cfe-commits mailing list cfe-commits@lists.llvm.org h

[clang] cbf778a - Remove also Block-ABI-Apple.txt from the Makefile

Author: Sylvestre Ledru Date: 2021-10-18T14:56:23+02:00 New Revision: cbf778a592fa5ee7c2bdd3d3ee7b468da2a7c9e6 URL: https://github.com/llvm/llvm-project/commit/cbf778a592fa5ee7c2bdd3d3ee7b468da2a7c9e6 DIFF: https://github.com/llvm/llvm-project/commit/cbf778a592fa5ee7c2bdd3d3ee7b468da2a7c9e6.dif

[clang] 5644d15 - [analyzer][NFC] Add unittests for CallDescription and split the old ones

Author: Balazs Benics Date: 2021-10-18T14:57:24+02:00 New Revision: 5644d152578f4604f7dc8c908a0a3f91a726ad80 URL: https://github.com/llvm/llvm-project/commit/5644d152578f4604f7dc8c908a0a3f91a726ad80 DIFF: https://github.com/llvm/llvm-project/commit/5644d152578f4604f7dc8c908a0a3f91a726ad80.diff

[clang] 3ec7b91 - [analyzer][NFC] Refactor CallEvent::isCalled()

Author: Balazs Benics Date: 2021-10-18T14:57:24+02:00 New Revision: 3ec7b91141da4b3f4dce4964ca3ea7c3549584d2 URL: https://github.com/llvm/llvm-project/commit/3ec7b91141da4b3f4dce4964ca3ea7c3549584d2 DIFF: https://github.com/llvm/llvm-project/commit/3ec7b91141da4b3f4dce4964ca3ea7c3549584d2.diff

[clang] 72d04d7 - [analyzer] Allow matching non-CallExprs using CallDescriptions

Author: Balazs Benics Date: 2021-10-18T14:57:24+02:00 New Revision: 72d04d7b2b53eea977e160551077cf1a3f51ba9a URL: https://github.com/llvm/llvm-project/commit/72d04d7b2b53eea977e160551077cf1a3f51ba9a DIFF: https://github.com/llvm/llvm-project/commit/72d04d7b2b53eea977e160551077cf1a3f51ba9a.diff

[PATCH] D111794: [analyzer][NFC] Add unittests for CallDescription and split the old ones

This revision was automatically updated to reflect the committed changes. Closed by commit rG5644d152578f: [analyzer][NFC] Add unittests for CallDescription and split the old ones (authored by steakhal). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM

[PATCH] D111534: [analyzer][NFC] Refactor CallEvent::isCalled()

This revision was automatically updated to reflect the committed changes. Closed by commit rG3ec7b91141da: [analyzer][NFC] Refactor CallEvent::isCalled() (authored by steakhal). Herald added a project: clang. Herald added a subscriber: cfe-commits. Changed prior to commit: https://reviews.llvm.

[PATCH] D111535: [analyzer] Allow matching non-CallExprs using CallDescriptions

This revision was automatically updated to reflect the committed changes. Closed by commit rG72d04d7b2b53: [analyzer] Allow matching non-CallExprs using CallDescriptions (authored by steakhal). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Mon

[PATCH] D105169: [Clang/Test]: Rename enable_noundef_analysis to disable-noundef-analysis and turn it off by default

ostannard added a comment. This change is causing a lot of failures in the address sanitiser tests on the 2-stage AArch64 buildbots. For example: https://lab.llvm.org/buildbot/#/builders/179/builds/1326 I can reproduce the failures on another AArch64 machine, they only happen with a 2-stage bu

[PATCH] D105169: [Clang/Test]: Rename enable_noundef_analysis to disable-noundef-analysis and turn it off by default

sylvestre.ledru added a comment. This change caused libclc to fail to build on old ubuntu (using llvm-spir 10.0.0-1) See: https://bugs.llvm.org/show_bug.cgi?id=52200 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105169/new/ https://reviews.llvm.o

[PATCH] D105169: [Clang/Test]: Rename enable_noundef_analysis to disable-noundef-analysis and turn it off by default

aqjune added a comment. I will revert this patch, since its fix needs some time for me to investigate. I have access to an AArch server, so I can give it a try by myself. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105169/new/ https://reviews.llv

[PATCH] D111993: [libomptarget][WIP] Patch amdgpu DeviceRTL until it compiles

JonChesterfield created this revision. JonChesterfield added a reviewer: jdoerfert. Herald added subscribers: kerbowa, t-tye, tpr, dstuttard, yaxunl, nhaehnle, jvesely, kzhuravl. JonChesterfield requested review of this revision. Herald added subscribers: openmp-commits, cfe-commits, sstefan1, wdn

[PATCH] D111993: [libomptarget][WIP] Patch amdgpu DeviceRTL until it compiles

JonChesterfield added inline comments. Comment at: clang/lib/Driver/ToolChains/AMDGPUOpenMP.cpp:255 options::OPT_fno_openmp_target_new_runtime, false)) -BitcodeSuffix = "new-amdgcn-" + GPUArch; +BitcodeSuffix = "new-amdgpu-" + GPUArch; else --

[PATCH] D111993: [libomptarget][WIP] Patch amdgpu DeviceRTL until it compiles

JonChesterfield added inline comments. Comment at: openmp/libomptarget/DeviceRTL/src/Synchronization.cpp:87 +#if 0 +// Can't spell the dispatch from runtime ordering like: +template Suggestion offline is that delaying the check in clang for these builtins until

[PATCH] D109652: [PowerPC] Restrict various P10 options to P10 only.

lei accepted this revision. lei added a comment. LGTM I think you went a bit overkill with the tests for this patch 🙂. Please cut down the number of run lines before committing. Comment at: clang/test/Driver/ppc-p10-features-support-check.c:4 +// RUN: --check-prefix=HASPAIR

[PATCH] D111985: [Clang] Add elementwise min/max builtins.

fhahn updated this revision to Diff 380409. fhahn added a comment. polish tests a bit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111985/new/ https://reviews.llvm.org/D111985 Files: clang/include/clang/Basic/Builtins.def clang/include/clang/

[PATCH] D111986: [Clang] Add elementwise abs builtin.

fhahn updated this revision to Diff 380411. fhahn added a comment. polish tests a bit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111986/new/ https://reviews.llvm.org/D111986 Files: clang/include/clang/Basic/Builtins.def clang/include/clang/

[PATCH] D112001: [Clang] Add min/max reduction builtins.

fhahn created this revision. fhahn added reviewers: aaron.ballman, scanon, craig.topper, rjmccall, erichkeane. fhahn requested review of this revision. Herald added a project: clang. This patch implements __builtin_reduce_max and __builtin_reduce_min as specified in D111529

[clang] ab41a1c - [clang] Disable -clear-ast-before-backend with -print-stats

Author: Arthur Eubanks Date: 2021-10-18T08:43:32-07:00 New Revision: ab41a1c50558f23e5b6aa7a3b68825f9b4a71fe7 URL: https://github.com/llvm/llvm-project/commit/ab41a1c50558f23e5b6aa7a3b68825f9b4a71fe7 DIFF: https://github.com/llvm/llvm-project/commit/ab41a1c50558f23e5b6aa7a3b68825f9b4a71fe7.diff

[PATCH] D111973: [clang] Disable -clear-ast-before-backend with -print-stats

This revision was automatically updated to reflect the committed changes. Closed by commit rGab41a1c50558: [clang] Disable -clear-ast-before-backend with -print-stats (authored by aeubanks). Changed prior to commit: https://reviews.llvm.org/D111973?vs=380281&id=380421#toc Repository: rG LLVM

[PATCH] D111973: [clang] Disable -clear-ast-before-backend with -print-stats

aeubanks added a comment. In D111973#3069304 , @dblaikie wrote: > Could you check some of the stats output is valid/expected, not just > corrupt/garbage? "just doesn't crash" isn't a great criteria for a test. forgot to upload the diff, but I did so in

[PATCH] D111973: [clang] Disable -clear-ast-before-backend with -print-stats

aeubanks added a comment. In D111973#3070519 , @aeubanks wrote: > In D111973#3069304 , @dblaikie > wrote: > >> Could you check some of the stats output is valid/expected, not just >> corrupt/garbage? "just doesn

[PATCH] D112008: Add -extra-arg-clang-tidy to {clang-tidy-diff,run-clang-tidy}.py

Xavier created this revision. Xavier added a reviewer: alexfh. Xavier added a project: clang-tools-extra. Xavier requested review of this revision. Herald added a subscriber: cfe-commits. This small patch adds a new `-extra-arg-clang-tidy` option to clang-tidy-diff and run-clang-tidy scripts. Thi

[PATCH] D111870: [clangd] Add a way to enable IncludeCleaner through config

kbobyrev updated this revision to Diff 380426. kbobyrev added a comment. Fix the warning range. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111870/new/ https://reviews.llvm.org/D111870 Files: clang-tools-extra/clangd/Config.h clang-tools-ext

[PATCH] D111534: [analyzer][NFC] Refactor CallEvent::isCalled()

ASDenysPetrov added a comment. Thank you for adding me. I'll make a deeper review later. Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/CallEvent.h:1289 + /// E.g. { "std", "vector", "data" } -> "vector", "std" + auto begin_qualified_name_parts() const { +

[PATCH] D111909: [clang-tidy] DefinitionsInHeadersCheck: Added option for checking C Code

schrc3b6 added a comment. In D111909#3069668 , @whisperity wrote: > Will `int I;` being in a header, with no initialiser, be caught? Currently it will be caught. 1 warning generated. ./foo.h:1:5: warning: variable 'i' defined in a header file; vari

[PATCH] D112008: Add -extra-arg-clang-tidy to {clang-tidy-diff,run-clang-tidy}.py

Xavier updated this revision to Diff 380429. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112008/new/ https://reviews.llvm.org/D112008 Files: clang-tools-extra/clang-tidy/tool/clang-tidy-diff.py clang-tools-extra/clang-tidy/tool/run-clang-tidy.py Index: clang-tools-extra/clang-tid

[PATCH] D112008: Add -extra-arg-clang-tidy to {clang-tidy-diff,run-clang-tidy}.py

Xavier updated this revision to Diff 380431. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112008/new/ https://reviews.llvm.org/D112008 Files: clang-tools-extra/clang-tidy/tool/clang-tidy-diff.py clang-tools-extra/clang-tidy/tool/run-clang-tidy.py Index: clang-tools-extra/clang-tid

[PATCH] D111909: [clang-tidy] DefinitionsInHeadersCheck: Added option for checking C Code

whisperity added a comment. In D111909#3070593 , @schrc3b6 wrote: > I guess you don't want that to be cought if it is actually a tentative > definition. If I remember correctly for clang and gcc -fno-common is the > default. > I think we could do one of

[PATCH] D112008: Add -extra-arg-clang-tidy to {clang-tidy-diff,run-clang-tidy}.py

Xavier added a comment. **Note**: manually tested the two scripts; - For `clang-tidy-diff.py` git diff -U0 --no-prefix --no-color $(git merge-base origin/master HEAD)..HEAD \ | ~/git/llvm-project/clang-tools-extra/clang-tidy/tool/clang-tidy-diff.py -quiet -clang-tidy-binary clang-tidy-

[PATCH] D112008: Add -extra-arg-clang-tidy to {clang-tidy-diff,run-clang-tidy}.py

Xavier updated this revision to Diff 380436. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112008/new/ https://reviews.llvm.org/D112008 Files: clang-tools-extra/clang-tidy/tool/clang-tidy-diff.py clang-tools-extra/clang-tidy/tool/run-clang-tidy.py Index: clang-tools-extra/clang-tid

[clang] 1fb24fe - Reland [clang] Pass -clear-ast-before-backend in Clang::ConstructJob()

Author: Arthur Eubanks Date: 2021-10-18T09:08:16-07:00 New Revision: 1fb24fe85a19ae71b00875ff6c96ef1831dcf7e3 URL: https://github.com/llvm/llvm-project/commit/1fb24fe85a19ae71b00875ff6c96ef1831dcf7e3 DIFF: https://github.com/llvm/llvm-project/commit/1fb24fe85a19ae71b00875ff6c96ef1831dcf7e3.diff

[PATCH] D112013: [clang][ASTImporter] Fix for importing functions with EST_Unevaluated prototype.

balazske created this revision. Herald added subscribers: steakhal, whisperity, martong, teemperor, gamesh411, Szelethus, dkrupp. Herald added a reviewer: a.sidorin. Herald added a reviewer: shafik. balazske requested review of this revision. Herald added a project: clang. Herald added a subscribe

[PATCH] D74531: [WebAssembly] Emit clangast in custom section aligned by 4 bytes

sbc100 added inline comments. Comment at: llvm/lib/MC/WasmObjectWriter.cpp:374 + // Custom sections in wasm also have a string identifier with extra paddings + // for alignment for special sections. + // TODO: support section alignment at asm and llvm level? I

[PATCH] D106681: [analyzer][NFC] Move a block from `getBindingForElement` to separate functions

ASDenysPetrov updated this revision to Diff 380441. ASDenysPetrov retitled this revision from "[analyzer] Retrieve a value from list initialization of constant multi-dimensional array." to "[analyzer][NFC] Move a block from `getBindingForElement` to separate functions". ASDenysPetrov edited the s

[PATCH] D111534: [analyzer][NFC] Refactor CallEvent::isCalled()

steakhal marked 3 inline comments as done. steakhal added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/CallEvent.h:1289 + /// E.g. { "std", "vector", "data" } -> "vector", "std" + auto begin_qualified_name_parts() const { +return std::

[PATCH] D111975: [clang-format] [PR52015] clang-format should put __attribute__((foo)) on its own line before @interface / @implementation / @protocol

benhamilton accepted this revision. benhamilton added a comment. Thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111975/new/ https://reviews.llvm.org/D111975 ___ cfe-commits mailing list cfe-com

[PATCH] D111870: [clangd] Add a way to enable IncludeCleaner through config

sammccall added inline comments. Comment at: clang-tools-extra/clangd/Config.h:89 /// Controls warnings and errors when parsing code. + enum IncludeCleanerPolicy { UnusedHeaders, None }; you've accidentally split this comment from its decl ===

[PATCH] D111863: [libunwind] Add an interface for dynamic .eh_frame registration

steven_wu added a comment. I don't know enough about Dwarf unwinding but the implementation looks generally good. Can you please add a testcase indicating how ORCJIT is planning to use it? Comment at: libunwind/src/DwarfParser.hpp:158 + FDE_Info

[PATCH] D112001: [Clang] Add min/max reduction builtins.

craig.topper added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:16673 + if (!VecTy) + if (!TyA->getAs()) + return Diag(A->getBeginLoc(), diag::err_elementwise_math_invalid_arg_type_2) Is this indented incorrectly? There appear to be 2 ifs

[clang] 2e4e200 - Fix a comment in SemaSYCL to make sure I can commit

Author: Erich Keane Date: 2021-10-18T10:12:28-07:00 New Revision: 2e4e2004afc51303bbb8836e886363f2056d73eb URL: https://github.com/llvm/llvm-project/commit/2e4e2004afc51303bbb8836e886363f2056d73eb DIFF: https://github.com/llvm/llvm-project/commit/2e4e2004afc51303bbb8836e886363f2056d73eb.diff L

[PATCH] D111986: [Clang] Add elementwise abs builtin.

craig.topper added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:3109 + Result = Builder.CreateBinaryIntrinsic( + llvm::Intrinsic::abs, Op0, Builder.getFalse(), nullptr, "elt.abs"); +else Did we discuss that this is different than

[PATCH] D112019: [clang-format] [PR51412] AlignConsecutiveMacros fights with Visual Studio and resource.h

MyDeveloperDay created this revision. MyDeveloperDay added reviewers: curdeius, HazardyKnusperkeks, krasimir. MyDeveloperDay added projects: clang, clang-format. MyDeveloperDay requested review of this revision. clang-format `AlignConsecutiveMacros` feature causes real problems when using Win32 r

[PATCH] D112020: [RISCV] Use clang_builtin_alias for all RISCV vector intrinsics.

craig.topper created this revision. craig.topper added reviewers: khchen, arcbbb, kito-cheng, HsiangKai, evandro. Herald added subscribers: achieveartificialintelligence, jeroen.dobbelaere, StephenFan, vkmr, frasercrmck, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei,

[PATCH] D112022: [WebAssembly] Add prototype relaxed swizzle instructions

ngzhian created this revision. ngzhian added a reviewer: tlively. Herald added subscribers: ecnelises, sunfish, hiraditya, jgravelle-google, sbc100, dschuff. ngzhian requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, aheejin. Herald added projects: clang, LLVM.

[PATCH] D112022: [WebAssembly] Add prototype relaxed swizzle instructions

ngzhian added inline comments. Comment at: llvm/lib/Target/WebAssembly/WebAssemblyInstrSIMD.td:1365 + +def wasm_relaxed_swizzle : SDNode<"WebAssemblyISD::RELAXED_SWIZZLE", wasm_swizzle_t>; + @tlively i'm not 100% sure if this is needed or the right thing to do,

[clang] 5b949a6 - Fix crash when diagnosing a CTAD failure in an array new expression

Author: Aaron Ballman Date: 2021-10-18T14:01:55-04:00 New Revision: 5b949a649aff0406a878e8eb8d7d5efba0a55e4a URL: https://github.com/llvm/llvm-project/commit/5b949a649aff0406a878e8eb8d7d5efba0a55e4a DIFF: https://github.com/llvm/llvm-project/commit/5b949a649aff0406a878e8eb8d7d5efba0a55e4a.diff

[PATCH] D112024: [clang] diagnose_as attribute for Fortify diagnosing like builtins.

mbenfield created this revision. mbenfield added a reviewer: george.burgess.iv. Herald added a reviewer: aaron.ballman. mbenfield requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.or

[PATCH] D111529: Specify Clang vector builtins.

craig.topper added inline comments. Comment at: clang/docs/LanguageExtensions.rst:557 +``i in [0, Number of elements / 2)``. If the numbers of elements is not a +power of 2, the vector is widening with neutral elements for the reduction +at the end to the next power of 2. ---

[PATCH] D112001: [Clang] Add min/max reduction builtins.

fhahn updated this revision to Diff 380486. fhahn added a comment. Remove stray `!TyA->getAs()` check. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112001/new/ https://reviews.llvm.org/D112001 Files: clang/include/clang/Basic/Builtins.def cla

[PATCH] D112001: [Clang] Add min/max reduction builtins.

fhahn marked an inline comment as done. fhahn added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:16673 + if (!VecTy) + if (!TyA->getAs()) + return Diag(A->getBeginLoc(), diag::err_elementwise_math_invalid_arg_type_2) craig.topper wrote: >

[PATCH] D111986: [Clang] Add elementwise abs builtin.

craig.topper added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:3109 + Result = Builder.CreateBinaryIntrinsic( + llvm::Intrinsic::abs, Op0, Builder.getFalse(), nullptr, "elt.abs"); +else craig.topper wrote: > Did we discuss that

[PATCH] D105168: [RISCV] Unify the arch string parsing logic to RISCVISAInfo.

craig.topper added a comment. In D105168#3069499 , @teemperor wrote: > This broke the modules build: > > While building module 'LLVM_Utils' imported from > lvm/lib/Support/TargetParser.cpp:14: > In file included from :209: > llvm/include/llvm/Suppo

[PATCH] D111371: [Support][ThinLTO] Move ThinLTO caching to LLVM Support library.

This revision was automatically updated to reflect the committed changes. Closed by commit rG92b8cc52bbc8: [Support][ThinLTO] Move ThinLTO caching to LLVM Support library (authored by noajshu, committed by phosek). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews

[clang] 92b8cc5 - [Support][ThinLTO] Move ThinLTO caching to LLVM Support library

Author: Noah Shutty Date: 2021-10-18T12:08:49-07:00 New Revision: 92b8cc52bbc8194f2cd6a5f742b874969421afca URL: https://github.com/llvm/llvm-project/commit/92b8cc52bbc8194f2cd6a5f742b874969421afca DIFF: https://github.com/llvm/llvm-project/commit/92b8cc52bbc8194f2cd6a5f742b874969421afca.diff L

[PATCH] D111009: Update inline builtin handling to honor gnu inline attribute

nickdesaulniers added a comment. See also: https://github.com/ClangBuiltLinux/linux/issues/1477. Surprising that this didn't show up in newer kernels, just older (but still supported) kernel versions. Sorry I missed that in my tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[clang] 8e46e34 - Revert "[Support][ThinLTO] Move ThinLTO caching to LLVM Support library"

Author: Petr Hosek Date: 2021-10-18T12:24:05-07:00 New Revision: 8e46e34d243524b9a1f9487718ea60e990b35fa3 URL: https://github.com/llvm/llvm-project/commit/8e46e34d243524b9a1f9487718ea60e990b35fa3 DIFF: https://github.com/llvm/llvm-project/commit/8e46e34d243524b9a1f9487718ea60e990b35fa3.diff LO

[PATCH] D112028: [RISCV] Remove the HasSideEffects property from riscv_vector.td

craig.topper created this revision. craig.topper added reviewers: HsiangKai, kito-cheng, arcbbb, khchen. Herald added subscribers: achieveartificialintelligence, StephenFan, vkmr, frasercrmck, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, bruce

Re: [clang] 2edb89c - Lex arguments for __has_cpp_attribute and friends as expanded tokens

On Sun, 17 Oct 2021 at 04:58, Aaron Ballman via cfe-commits < cfe-commits@lists.llvm.org> wrote: > > Author: Aaron Ballman > Date: 2021-10-17T07:54:48-04:00 > New Revision: 2edb89c746848c52964537268bf03e7906bf2542 > > URL: > https://github.com/llvm/llvm-project/commit/2edb89c746848c52964537268bf03

  1   2   >